Re: [Qemu-devel] [PATCH v2 1/7] hw/riscv/sifive_u: Create a U54 SoC object

2018-05-12 Thread Michael Clark
On Sat, May 12, 2018 at 11:27 AM, Alistair Francis wrote: > Create a SiFive Unleashed U54 SoC and use that in the sifive_u machine. > > We leave the SoC, RAM, device tree and reset/fdt loading as part of the > machine. All the other device creation has been moved to

[Qemu-devel] [PULL 8/8] block/file-posix: add x-check-page-cache=on|off option

2018-05-12 Thread Stefan Hajnoczi
mincore(2) checks whether pages are resident. Use it to verify that page cache has been dropped. You can trigger a verification failure by mmapping the image file from another process that loads a byte from a page, forcing it to become resident. bdrv_co_invalidate_cache() will fail while that

Re: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0

2018-05-12 Thread David Hildenbrand
On 12.05.2018 06:59, Richard Henderson wrote: > The warning is > > target/s390x/misc_helper.c:209:21: error: suggest > braces around initialization of subobject [-Werror,-Wmissing-braces] > SysIB sysib = { 0 }; > ^ > {} > > While the original

[Qemu-devel] [PULL 7/8] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-05-12 Thread Stefan Hajnoczi
On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use this to drop page cache on the destination host during shared storage migration. This way the destination host will read the latest copy of the data and will not use stale data from the page cache. The flow is as follows: 1.

[Qemu-devel] [PULL 2/8] checkpatch: add a --strict check for utf-8 in commit logs

2018-05-12 Thread Stefan Hajnoczi
From: Joe Perches Some find using utf-8 in commit logs inappropriate. Some patch commit logs contain unintended utf-8 characters when doing things like copy/pasting compilation output. Look for the start of any commit log by skipping initial lines that look like email headers

Re: [Qemu-devel] [PATCH v2 7/7] hw/riscv/sifive_u: Connect the Cadence GEM Ethernet device

2018-05-12 Thread Michael Clark
On Sat, May 12, 2018 at 11:28 AM, Alistair Francis wrote: > Connect the Cadence GEM ethernet device. This also requires us to > expose the plic interrupt lines. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark

Re: [Qemu-devel] [PATCH v2 5/7] hw/riscv/sifive_u: Set the interrupt controler number of interrupts

2018-05-12 Thread Michael Clark
On Sat, May 12, 2018 at 11:28 AM, Alistair Francis wrote: > Set the interrupt-controller ndev to the correct number taken from the > HiFive Unleashed board. > > Signed-off-by: Alistair Francis > If you look at hw/riscv/virt.c we have removed

[Qemu-devel] [PULL 6/8] checkpatch: reduce MAINTAINERS update message frequency

2018-05-12 Thread Stefan Hajnoczi
From: Joe Perches When files are being added/moved/deleted and a patch contains an update to the MAINTAINERS file, assume it's to update the MAINTAINERS file correctly and do not emit the "does MAINTAINERS need updating?" message. Reported by many people. Signed-off-by: Joe

[Qemu-devel] [PULL 0/8] Block patches

2018-05-12 Thread Stefan Hajnoczi
The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-05-08 17:05:58 +0100) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

Re: [Qemu-devel] [PATCH v2 16/17] s390x: initialize memory region for memory devices

2018-05-12 Thread David Hildenbrand
On 11.05.2018 20:43, Eduardo Habkost wrote: > On Fri, May 11, 2018 at 03:34:05PM -0300, Murilo Opsfelder Araujo wrote: >> On Fri, May 11, 2018 at 03:19:52PM +0200, David Hildenbrand wrote: >>> While s390x has no real interface for communicating devices mapped into >>> the physical address space of

Re: [Qemu-devel] [PATCH v2 6/7] hw/riscv/sifive_u: Move the uart device tree node under /soc/

2018-05-12 Thread Michael Clark
On Sat, May 12, 2018 at 11:28 AM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/sifive_u.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Qemu-devel] [PULL 1/8] blockjob: drop block_job_pause/resume_all()

2018-05-12 Thread Stefan Hajnoczi
Commit 8119334918e86f45877cfc139192d54f2449a239 ("block: Don't block_job_pause_all() in bdrv_drain_all()") removed the only callers of block_job_pause/resume_all(). Pausing and resuming now happens in child_job_drained_begin/end() so it's no longer necessary to globally pause/resume jobs.

[Qemu-devel] [PULL 4/8] checkpatch: ignore email headers better

2018-05-12 Thread Stefan Hajnoczi
From: Joe Perches There are some patches created by git format-patch that when scanned by checkpatch report errors on lines like To: address.tld This is a checkpatch false positive. Improve the logic a bit to ignore folded email headers to avoid emitting these messages.

Re: [Qemu-devel] [PULL 0/8] Block patches

2018-05-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180512092824.13848-1-stefa...@redhat.com Subject: [Qemu-devel] [PULL 0/8] Block patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v3] migration: discard non-migratable RAMBlocks

2018-05-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180510220248.10272-1-...@kaod.org Subject: [Qemu-devel] [PATCH v3] migration: discard non-migratable RAMBlocks === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2 04/17] pc: route all memory devices through the machine hotplug handler

2018-05-12 Thread Paolo Bonzini
On 11/05/2018 15:19, David Hildenbrand wrote: > +if (dev->parent_bus) { > +if (object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE)) { > +return HOTPLUG_HANDLER(machine); > +} > +} > + How do you get here with a MemoryDevice that has !dev->parent_bus? Thanks,

[Qemu-devel] [Bug 1686170] Re: qemu-system-x86_64+gdb: unable to correctly disassemble "real mode" (i8086) instructions after attaching to QEMU started with "-S -s" options

2018-05-12 Thread Vladislav K. Valtchev
Hi, are there any updates on this issue? I'm using qemu 2.11.1 and I believe I'm experiencing the same problem explained by Duane. I'm unable to debug with gdb 32-bit kernel code using qemu-system-x86_64. GDB complains that the target architecture is x86_64, even if VM's CPU is currently

Re: [Qemu-devel] [PATCH v2 04/17] pc: route all memory devices through the machine hotplug handler

2018-05-12 Thread David Hildenbrand
On 12.05.2018 16:47, Paolo Bonzini wrote: > On 11/05/2018 15:19, David Hildenbrand wrote: >> +if (dev->parent_bus) { >> +if (object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE)) { >> +return HOTPLUG_HANDLER(machine); >> +} >> +} >> + > > How do you get here

Re: [Qemu-devel] [PATCH RFC 0/2] Fix UART serial implementation

2018-05-12 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180511205724.4039-1-cyrus...@gmail.com Subject: [Qemu-devel] [PATCH RFC 0/2] Fix UART

[Qemu-devel] [Bug 1770859] [NEW] qemu-img compare -m option is missing

2018-05-12 Thread Коренберг Марк
Public bug reported: Comparing images using multiple streams (like qemu-img convert) maybe effectively sped up when one of the images (or both) is RBD. qemu-img convert does it's job perfectly while converting. Please implement the same for image comparison. Since operations are read-only, -W is

[Qemu-devel] [PATCH 4/4] target/xtensa: Convert to TranslatorOps

2018-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 229 -- 1 file changed, 122 insertions(+), 107 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 45f32dc71f..9de45e4be4 100644

[Qemu-devel] [PATCH 1/4] target/xtensa: Replace DISAS_UPDATE with DISAS_NORETURN

2018-05-12 Thread Richard Henderson
The usage of DISAS_UPDATE is after noreturn helpers. It is thus indistinguishable from DISAS_NORETURN. Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] target/xtensa: Change gen_intermediate_code dc to pointer

2018-05-12 Thread Richard Henderson
This will reduce the size of the patch in the next patch, where the context will have to be a pointer. Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 122 +++--- 1 file changed, 61 insertions(+), 61 deletions(-)

[Qemu-devel] [PATCH 2/4] target/xtensa: Convert to DisasContextBase

2018-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 89 +++ 1 file changed, 43 insertions(+), 46 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index a1e63f9661..cc48d105e9 100644 ---

[Qemu-devel] [PATCH 0/4] target/xtensa: Convert to TranslatorOps

2018-05-12 Thread Richard Henderson
I have one xtensa image against which to test this. There are enough options going on here in the xtensa frontend that this probably needs a better work-out. r~ Richard Henderson (4): target/xtensa: Replace DISAS_UPDATE with DISAS_NORETURN target/xtensa: Convert to DisasContextBase

Re: [Qemu-devel] [PATCH v2 20/27] target/riscv: Remove floatX_maybe_silence_nan from conversions

2018-05-12 Thread Michael Clark
On Sat, May 12, 2018 at 12:43 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > This is now handled properly by the generic softfloat code. > > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian

[Qemu-devel] [PULL 5/8] checkpatch: emit a warning on file add/move/delete

2018-05-12 Thread Stefan Hajnoczi
From: Joe Perches Whenever files are added, moved, or deleted, the MAINTAINERS file patterns can be out of sync or outdated. To try to keep MAINTAINERS more up-to-date, add a one-time warning whenever a patch does any of those. Signed-off-by: Joe Perches

[Qemu-devel] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset

2018-05-12 Thread Stefan Hajnoczi
From: Pasi Savanainen Check that a commit log doesn't contain UTF-8 when a mail header explicitly defines a different charset, like 'Content-Type: text/plain; charset="us-ascii"' Signed-off-by: Pasi Savanainen Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 3/9] target/ppc: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Alexander Graf > Cc: David Gibson > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/ppc/translate.c | 20

Re: [Qemu-devel] [PATCH 4/9] target/riscv: Introduce cpu_riscv_get_fcsr

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH 5/9] target/riscv: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH 0/5] linux-user: move socket.h definitions to CPU directories

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/10/2018 07:25 PM, Laurent Vivier wrote: > Splitting out socket.h definitions helps to read the code > and to fix the bugs... > > No code change, except for the last one that ports > definitions from linux for sparc as the values are not the > correct ones. > > Laurent Vivier (5): >

Re: [Qemu-devel] [PATCH v5 1/3] update-linux-headers.sh: unistd.h, kvm consistency

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 06:32 PM, Michael S. Tsirkin wrote: > Rework the update script slightly, add the unistd.h header and its > dependencies on all architectures. > > This also removes the IA64 and MIPS from a KVM blacklist: > Linux dropped IA64, and there was never a reason to > exclude MIPS from kvm

Re: [Qemu-devel] [PATCH 1/9] target/alpha: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/alpha/helper.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/target/alpha/helper.c b/target/alpha/helper.c > index

Re: [Qemu-devel] [PATCH 2/9] target/mips: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Aurelien Jarno > Cc: Yongbok Kim > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 3 ++- >

Re: [Qemu-devel] [PATCH 9/9] target/xtensa: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Max Filippov > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/xtensa/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH 8/9] target/unicore32: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Guan Xuetao > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/unicore32/translate.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH 7/9] target/sparc: Honor CPU_DUMP_FPU

2018-05-12 Thread Philippe Mathieu-Daudé
On 05/11/2018 12:52 AM, Richard Henderson wrote: > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/sparc/cpu.c