Re: [Qemu-devel] [PATCH 4/9] target/riscv: Introduce cpu_riscv_get_fcsr

On Fri, May 11, 2018 at 3:52 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Signed-off-by:

Re: [Qemu-devel] [PATCH] RISC-V: make it possible to alter default reset vector

On Tue, May 8, 2018 at 9:08 AM, Antony Pavlov wrote: > The RISC-V Instruction Set Manual, Volume II: > Privileged Architecture, Version 1.10 states > that upon reset the pc is set to > an implementation-defined reset vector > (see chapter 3.3 Reset). > > This patch makes

Re: [Qemu-devel] [PATCH 4/9] target/riscv: Introduce cpu_riscv_get_fcsr

On 05/17/2018 07:46 PM, Michael Clark wrote: > > > On Fri, May 11, 2018 at 3:52 PM, Richard Henderson > > wrote: > > Cc: Michael Clark > > Cc: Palmer Dabbelt

Re: [Qemu-devel] [PATCH v2 01/10] intel-iommu: send PSI always even if across PDEs

On Thu, May 17, 2018 at 04:42:54PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > During IOVA page table walking, there is a special case when the PSI > > covers one whole PDE (Page Directory Entry, which contains 512 Page > > Table Entries) or more. In the

Re: [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

On 05/17/2018 06:34 PM, Richard Henderson wrote: > On 05/17/2018 02:24 PM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 05/17/2018 10:46 AM, Alex Bennée wrote: Broken since I updated to 18.04 Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > For UNMAP-only IOMMU notifiers, we don't really need to walk the page > s/really// ;-) Ok. > > tables. Fasten that procedure by skipping the page table walk. That > > should

Re: [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64

On 05/17/2018 05:30 PM, Richard Henderson wrote: > On 05/17/2018 10:47 AM, Alex Bennée wrote: >> This runs through the usual float to float conversions and crucially >> also runs with ARM Alternative Half Precision Format. >> >> Signed-off-by: Alex Bennée >> [rth: tweak

Re: [Qemu-devel] [PATCH v2 03/10] intel-iommu: add iommu lock

On Thu, May 17, 2018 at 04:32:52PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > Add a per-iommu big lock to protect IOMMU status. Currently the only > > thing to be protected is the IOTLB/context cache, since that can be > > accessed even without BQL,

Re: [Qemu-devel] [edk2] [PATCH 1/4] ovmf: add and link with Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE

On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This NULL library will let us call > Tcg2PhysicalPresenceLibProcessRequest() unconditionally from > BdsPlatform when building without TPM2_ENABLE. > > Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

Anton Nefedov writes: > On 15/5/2018 8:40 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 05/15/2018 02:01 AM, Markus Armbruster wrote: >>> >> QAPI language design alternatives: >> >> 1. Having unions cover all

[Qemu-devel] [PATCH v4 08/14] spapr: handle pc-dimm unplug via hotplug handler chain

Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ unplug memory devices (which a pc-dimm is) later. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v4 11/14] pc-dimm: implement new memory device functions

Implement the new functions, we don't have to care about alignment for these DIMMs right now, so leave that function unimplemented. Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 17 + 1 file changed, 17 insertions(+) diff --git a/hw/mem/pc-dimm.c

[Qemu-devel] [PATCH v3 12/12] intel-iommu: new sync_shadow_page_table

Firstly, introduce the sync_shadow_page_table() helper to resync the whole shadow page table of an IOMMU address space. Meanwhile, when we receive domain invalidation or similar requests (for example, context entry invalidations, global invalidations, ...), we should not really run the replay

[Qemu-devel] [PATCH v3 10/12] intel-iommu: simplify page walk logic

Let's move the notify_unmap check into the new vtd_page_walk_one() function so that we can greatly simplify the vtd_page_walk_level() logic. No functional change at all. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 66 ---

Re: [Qemu-devel] [PATCH v2 5/8] linux-user: move ppc socket.h definitions to ppc/sockbits.h

Le 17/05/2018 à 01:17, Philippe Mathieu-Daudé a écrit : > On 05/16/2018 05:55 PM, Laurent Vivier wrote: >> No code change. >> >> Signed-off-by: Laurent Vivier >> --- >> linux-user/generic/sockbits.h | 9 + >> linux-user/ppc/sockbits.h | 19 +++ >>

Re: [Qemu-devel] FW: [PATCH 2/2] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

On 5/17/2018 10:41 AM, 858585 jemmy wrote: On Thu, May 17, 2018 at 3:31 PM, Aviad Yehezkel wrote: On 5/17/2018 5:42 AM, 858585 jemmy wrote: On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel wrote: Hi Lidong and David, Sorry for the

[Qemu-devel] [PATCH v4 07/14] spapr: route all memory devices through the machine hotplug handler

Necessary to hotplug them cleanly later. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index b7c5c95f7a..2f315f963b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3666,6 +3666,7 @@

Re: [Qemu-devel] [PATCH v6 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

Daniel Henrique Barboza writes: > On 05/15/2018 12:35 PM, Markus Armbruster wrote: >> Daniel Henrique Barboza writes: >> >>> This patch updates the descriptions of 'guest-suspend-ram' and >>> 'guest-suspend-hybrid' to mention that both commands

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > That is not really necessary. Removing that node struct and put the > > list entry directly into VTDAddressSpace. It simplfies the code a lot. > > > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [RFC PATCH 07/12] qcow2-bitmap: add basic bitmaps info

17.05.2018 00:17, John Snow wrote: On 05/14/2018 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: 12.05.2018 04:25, John Snow wrote: Add functions for querying the basic information inside of bitmaps. Restructure the bitmaps flags masks to facilitate providing a list of flags belonging to the

Re: [Qemu-devel] [PATCH v3 5/8] xen_disk: remove use of grant map/unmap

On Fri, May 04, 2018 at 08:26:04PM +0100, Paul Durrant wrote: > Now that the (native or emulated) xen_be_copy_grant_refs() helper is > always available, the xen_disk code can be significantly simplified by > removing direct use of grant map and unmap operations. > > Signed-off-by: Paul Durrant

Re: [Qemu-devel] FW: [PATCH 2/2] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

On 5/17/2018 5:42 AM, 858585 jemmy wrote: On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel wrote: Hi Lidong and David, Sorry for the late response, I had to ramp up on migration code and build a setup on my side. PSB my comments for this patch below. For the RDMA

Re: [Qemu-devel] [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

On 05/16/18 11:29, Laszlo Ersek wrote: > Hi Marc-André, > > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >> with TPM2 (I haven't tested TPM1, for

Re: [Qemu-devel] [PATCH] RISC-V: make it possible to alter default reset vector

On Tue, 8 May 2018 00:08:38 +0300 Antony Pavlov wrote: Please comment this patch! > The RISC-V Instruction Set Manual, Volume II: > Privileged Architecture, Version 1.10 states > that upon reset the pc is set to > an implementation-defined reset vector > (see chapter

Re: [Qemu-devel] [PATCH V7 RESEND 16/17] COLO: notify net filters about checkpoint/failover event

* Zhang Chen (zhangc...@gmail.com) wrote: > From: zhanghailiang > > Notify all net filters about the checkpoint and failover event. > > Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert > ---

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

Hi Peter, On 05/04/2018 05:08 AM, Peter Xu wrote: > That is not really necessary. Removing that node struct and put the > list entry directly into VTDAddressSpace. It simplfies the code a lot. > > Signed-off-by: Peter Xu > --- > include/hw/i386/intel_iommu.h | 9 ++--

Re: [Qemu-devel] [PULL 09/28] target/arm: convert conversion helpers to fpst/ahp_flag

On 16 May 2018 at 16:52, Richard Henderson wrote: > diff --git a/target/arm/translate.c b/target/arm/translate.c > index 731cf327a1..613598d090 100644 > --- a/target/arm/translate.c > +++ b/target/arm/translate.c Just noticed, but in the 32-bit translator where the

[Qemu-devel] [Bug 1459626] Re: emacs (gtk3) core dumped with -vga qxl

Looking through old bug tickets... can you still reproduce this issue with the latest versions of QEMU, x11, kernel, spice, etc.? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1459622] Re: firefox hang with virtfs

Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH 3/4] bochs-display: add dirty tracking support

Signed-off-by: Gerd Hoffmann --- hw/display/bochs-display.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index beeda58475..9ea6f798f4 100644 ---

[Qemu-devel] [PATCH 4/4] bochs-display: add pcie support

Signed-off-by: Gerd Hoffmann --- hw/display/bochs-display.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 9ea6f798f4..23dbf57b8f 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c

Re: [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring

What about patches 1-4? 07.05.2018 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here are some preliminary refactoring patches, before NBD reconnect series. Vladimir Sementsov-Ogievskiy (5): block/nbd-client: split channel errors from export errors block/nbd: move connection code

Re: [Qemu-devel] [edk2] [PATCH 3/4] ovmf: replace SecurityPkg with OvfmPkg Tcg2PhysicalPresenceLibQemu

On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and: > > - removed all the functions that are unreachable from > Tcg2PhysicalPresenceLibProcessRequest() > > - replaced

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/2] hw/arm/smmu-common: Fix coverity issue in get_block_pte_address

Hi Philippe, On 05/16/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > On 05/16/2018 01:23 PM, Peter Maydell wrote: >> On 16 May 2018 at 16:16, Philippe Mathieu-Daudé wrote: >>> Hi Eric, >>> >>> On 05/16/2018 03:03 PM, Eric Auger wrote: Coverity points out that this can

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

Hi Peter, On 05/16/2018 06:18 PM, Peter Maydell wrote: > On 16 May 2018 at 15:33, Auger Eric wrote: >> On 05/08/2018 06:25 PM, Peter Maydell wrote: >>> This runs into something I found when I was implementing the Arm >>> Memory Protection Controller -- at the point when the

Re: [Qemu-devel] [RFC 00/10] [TESTING NEEDED] python: futurize --stage1 (Python 3 compatibility)

On Fri, 05/11 19:20, Eduardo Habkost wrote: > TESTING NEEDED: Due to the amount of changes, I didn't test all > scripts touched by this series. If you are responsible for any > of the touched files, I would appreciate help on testing the > series. The tests/docker and tests/vm changes look good

[Qemu-devel] [PATCH v4 02/14] memory-device: introduce separate config option

Some architectures might support memory devices, while they don't support DIMM/NVDIMM. So let's - Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE - Introduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE. Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v4 12/14] memory-device: factor out pre-plug into hotplug handler

Let's move all pre-plug checks we can do without the device being realized into the applicable hotplug handler for pc and spapr. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 11 +++ hw/mem/memory-device.c | 72

Re: [Qemu-devel] [PATCH v6 1/2] qmp: adding 'wakeup-suspend-support' in query-target

Daniel Henrique Barboza writes: > On 05/15/2018 12:45 PM, Markus Armbruster wrote: >> Daniel Henrique Barboza writes: >> >>> When issuing the qmp/hmp 'system_wakeup' command, what happens in a >>> nutshell is: >>> >>> - qmp_system_wakeup_request

[Qemu-devel] [PATCH v3 11/12] intel-iommu: new vtd_sync_shadow_page_table_range

I pick part of the page walk implementation out into this single function. It was only used now for PSIs, but actually it can be used not only for invalidations but for any place that we want to synchronize the shadow page table. No functional change at all. Here I passed in context entry

[Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

Create a new header file, move the bochs vbe dispi interface defines to it, so they can be used outside vga code. Signed-off-by: Gerd Hoffmann --- hw/display/vga_int.h | 35 ++- include/hw/display/bochs-vbe.h | 64

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

Hi Peter, On 05/17/2018 12:02 PM, Peter Xu wrote: > On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> That is not really necessary. Removing that node struct and put the >>> list entry directly into VTDAddressSpace. It

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

On Thu, May 17, 2018 at 12:10:41PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/17/2018 12:02 PM, Peter Xu wrote: > > On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: > >> Hi Peter, > >> > >> On 05/04/2018 05:08 AM, Peter Xu wrote: > >>> That is not really necessary. Removing that

Re: [Qemu-devel] [PATCH v6 2/2] iothread: let aio_epoll_disable fit to aio_context_destroy

I enjoyed the great benefit of your suggestions, and I will improve next time. :) This time, I ask maintainers to touch up the commit message base on version 5 and merge it, thanks very much. On 2018/5/17 14:22, Peter Xu wrote: > On Thu, May 17, 2018 at 10:26:17AM +0800, Jie Wang wrote: >>

Re: [Qemu-devel] [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU > with TPM2 (I haven't tested TPM1, for lack of interest). > > PPI test runs successfully with Windows

[Qemu-devel] [PATCH v4 09/14] spapr: handle cpu core unplug via hotplug handler chain

Let's handle it via hotplug_handler_unplug(). Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 286c38c842..13d153b5a6 100644 --- a/hw/ppc/spapr.c +++

[Qemu-devel] [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers

We can have devices that need certain other resources that are e.g. system resources managed by the machine. We need a clean way to assign these resources (without violating layers as brought up by Igor). One example is virtio-mem/virtio-pmem. Both device types need to be assigned some region in

[Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

For multi stage hotplug handlers, we'll have to do some error handling in some hotplug functions, so let's use a local error variable (except for unplug requests). Also, add code to pass control to the final stage hotplug handler at the parent bus. Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler

Necessary to hotplug them cleanly later. We could drop the PC_DIMM check, as PC_DIMM are just memory devices, but this approach is cleaner. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

(Hello, Jintack, Feel free to test this branch again against your scp error case when you got free time) I rewrote some of the patches in V3. Major changes: - Dropped mergable interval tree, instead introduced IOVA tree, which is even simpler. - Fix the scp error issue that Jintack

[Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

During IOVA page table walking, there is a special case when the PSI covers one whole PDE (Page Directory Entry, which contains 512 Page Table Entries) or more. In the past, we skip that entry and we don't notify the IOMMU notifiers. This is not correct. We should send UNMAP notification to

[Qemu-devel] [PATCH v3 05/12] intel-iommu: introduce vtd_page_walk_info

During the recursive page walking of IOVA page tables, some stack variables are constant variables and never changed during the whole page walking procedure. Isolate them into a struct so that we don't need to pass those contants down the stack every time and multiple times. Signed-off-by: Peter

[Qemu-devel] [PATCH v3 09/12] intel-iommu: maintain per-device iova ranges

For each VTDAddressSpace, now we maintain what IOVA ranges we have mapped and what we have not. With that information, now we only send MAP or UNMAP when necessary. Say, we don't send MAP notifies if we know we have already mapped the range, meanwhile we don't send UNMAP notifies if we know we

[Qemu-devel] [PATCH v3 06/12] intel-iommu: pass in address space when page walk

We pass in the VTDAddressSpace too. It'll be used in the follow up patches. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 4953d02ed0..fe5ee77d46 100644 ---

[Qemu-devel] [PATCH 2/4] display: add new bochs-display device

After writing up the virtual mdev device emulating a display supporting the bochs vbe dispi interface (mbochs.ko) and seeing how simple it actually is I've figured that would be useful for qemu too. So, here it is, -device bochs-display. It is basically -device VGA without legacy vga emulation.

Re: [Qemu-devel] [PATCH 1/3] hw/arm/smmuv3: Cache/invalidate config data

Hi Peter, On 05/16/2018 08:31 PM, Eric Auger wrote: > Let's cache config data to avoid fetching and parsing STE/CD > structures on each translation. We invalidate them on data structure > invalidation commands. You may remember that initially I was taking a QemuMutex to protect IOTLB/cache

Re: [Qemu-devel] [PATCH v4 01/10] block: Introduce API for copy offloading

On Fri, May 11, 2018 at 08:08:14PM +0800, Fam Zheng wrote: > Introduce the bdrv_co_copy_range() API for copy offloading. Block > drivers implementing this API support efficient copy operations that > avoid reading each block from the source device and writing it to the > destination devices.

Re: [Qemu-devel] [edk2] [PATCH 4/4] ovmf: process TPM PPI request in AfterConsole()

On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI > requests from PlatformBootManagerAfterConsole(). > > Laszlo understanding of edk2 is that the PPI operation

Re: [Qemu-devel] [PATCH v7 11/11] tests: functional tests for QMP command set-numa-node

On Wed, 16 May 2018 19:12:30 -0300 Eduardo Habkost wrote: > On Fri, May 04, 2018 at 10:37:49AM +0200, Igor Mammedov wrote: > > * start QEMU with 2 unmapped cpus, > > * while in preconfig state > > * add 2 numa nodes > > * assign cpus to them > > * exit preconfig

Re: [Qemu-devel] [edk2] [PATCH 2/4] ovmf: add QemuTpm.h header

On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add some common macros and type definitions corresponding to the QEMU > TPM interface. > > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PATCH v4 01/14] memory-device: drop assert related to align and start of address space

The start of the address space does not have to be aligned for the search. Handle this case explicitly when starting the search for a new address. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 10/14] memory-device: new functions to handle plug/unplug

We will need a handful of new functions: - set_addr(): To set the calculated address - get_memory_region(): To add it to the memory region container - get_addr(): If the device has any specific alignment requirements Using these and the existing functions, we can properly plug/unplug memory

[Qemu-devel] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers

For multi stage hotplug handlers, we'll have to do some error handling in some hotplug functions, so let's use a local error variable (except for unplug requests). Also, add code to pass control to the final stage hotplug handler at the parent bus. Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH V7 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO

Zhang Chen writes: > On Tue, May 15, 2018 at 10:29 PM, Markus Armbruster > wrote: > >> Zhang Chen writes: >> >> > From: zhanghailiang >> > >> > If some errors happen during VM's COLO FT stage, it's

[Qemu-devel] [PATCH v3 04/12] intel-iommu: only do page walk for MAP notifiers

For UNMAP-only IOMMU notifiers, we don't really need to walk the page tables. Fasten that procedure by skipping the page table walk. That should boost performance for UNMAP-only notifiers like vhost. Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 2 ++

[Qemu-devel] [PATCH v3 07/12] intel-iommu: trace domain id during page walk

This patch only modifies the trace points. Previously we were tracing page walk levels. They are redundant since we have page mask (size) already. Now we trace something much more useful which is the domain ID of the page walking. That can be very useful when we trace more than one devices on

Re: [Qemu-devel] [PATCH v3 6/8] xen_backend: make the xen_feature_grant_copy flag private

On Fri, May 04, 2018 at 08:26:05PM +0100, Paul Durrant wrote: > There is no longer any use of this flag outside of the xen_backend code. > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD -- Anthony PERARD

[Qemu-devel] [PATCH v4 03/14] qdev: let machine hotplug handler to override bus hotplug handler

From: Igor Mammedov it will allow to return another hotplug handler than the default one for a specific bus based device type. Which is needed to handle non trivial plug/unplug sequences that need the access to resources configured outside of bus where device is attached.

[Qemu-devel] [PATCH v3 02/12] intel-iommu: remove IntelIOMMUNotifierNode

That is not really necessary. Removing that node struct and put the list entry directly into VTDAddressSpace. It simplfies the code a lot. Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 9 ++-- hw/i386/intel_iommu.c | 41

[Qemu-devel] [PATCH v3 03/12] intel-iommu: add iommu lock

Add a per-iommu big lock to protect IOMMU status. Currently the only thing to be protected is the IOTLB/context cache, since that can be accessed even without BQL, e.g., in IO dataplane. Note that we don't need to protect device page tables since that's fully controlled by the guest kernel.

Re: [Qemu-devel] [PATCH v3 09/12] intel-iommu: maintain per-device iova ranges

On Thu, May 17, 2018 at 04:59:24PM +0800, Peter Xu wrote: [...] > +/* Update local IOVA mapped ranges */ > +if (entry->perm) { > +if (mapped) { > +/* If it's exactly the same translation, skip */ > +if (!memcmp(mapped, , sizeof(target))) { > +

Re: [Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

Finally, what about this? 13.04.2018 17:31, Vladimir Sementsov-Ogievskiy wrote: Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [RFC PATCH 06/12] qapi: add bitmap info

17.05.2018 00:15, John Snow wrote: On 05/14/2018 10:30 AM, Vladimir Sementsov-Ogievskiy wrote: 12.05.2018 04:25, John Snow wrote: Add some of the necessary scaffolding for reporting bitmap information. Signed-off-by: John Snow ---   qapi/block-core.json | 60

Re: [Qemu-devel] [PATCH v4 05/10] file-posix: Implement bdrv_co_copy_range

On Fri, May 11, 2018 at 08:08:18PM +0800, Fam Zheng wrote: > With copy_file_range(2), we can implement the bdrv_co_copy_range > semantics. > > Signed-off-by: Fam Zheng > --- > block/file-posix.c | 96 > +++-- >

Re: [Qemu-devel] [PATCH v4 04/10] qcow2: Implement copy offloading

On Fri, May 11, 2018 at 08:08:17PM +0800, Fam Zheng wrote: > +static int qcow2_handle_l2meta(BlockDriverState *bs, QCowL2Meta *l2meta) > +{ > +int ret = 0; > + > +while (l2meta != NULL) { > +QCowL2Meta *next; > + > +if (!ret) { > +ret =

Re: [Qemu-devel] FW: [PATCH 2/2] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

On Thu, May 17, 2018 at 3:31 PM, Aviad Yehezkel wrote: > > > On 5/17/2018 5:42 AM, 858585 jemmy wrote: >> >> On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel >> wrote: >>> >>> Hi Lidong and David, >>> Sorry for the late response, I had to

[Qemu-devel] [PATCH v4 14/14] memory-device: factor out plug into hotplug handler

Let's move the plug logic into the applicable hotplug handler for pc and spapr. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 35 --- hw/mem/memory-device.c | 40 ++--

[Qemu-devel] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler

Let's move the unplug logic into the applicable hotplug handler for pc and spapr. We'll move the plug logic next, then this will look more symmetrical in the hotplug handlers. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 17 -

Re: [Qemu-devel] [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

On 05/17/18 09:54, Laszlo Ersek wrote: > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >> with TPM2 (I haven't tested TPM1, for lack of interest).

[Qemu-devel] [PATCH v3 08/12] util: implement simple iova tree

Introduce a simplest iova tree implementation based on GTree. Signed-off-by: Peter Xu --- include/qemu/iova-tree.h | 134 +++ util/iova-tree.c | 114 + MAINTAINERS | 6 ++

[Qemu-devel] [PATCH 0/4] display: add new bochs-display device

Gerd Hoffmann (4): vga: move bochs vbe defines to header file display: add new bochs-display device bochs-display: add dirty tracking support bochs-display: add pcie support hw/display/vga_int.h | 35 +--- include/hw/display/bochs-vbe.h | 64

Re: [Qemu-devel] [PATCH V7 RESEND 17/17] COLO: quick failover process by kick COLO thread

* Zhang Chen (zhangc...@gmail.com) wrote: > From: zhanghailiang > > COLO thread may sleep at qemu_sem_wait(>colo_checkpoint_sem), > while failover works begin, It's better to wakeup it to quick > the process. > > Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PULL 0/7] x86 queue, 2018-05-15

On 15 May 2018 at 22:54, Eduardo Habkost wrote: > The following changes since commit ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20180515-pull-request' into staging (2018-05-15 > 12:50:06 +0100) > > are available

Re: [Qemu-devel] [PATCH v3-a 00/27] target/arm: Scalable Vector Extension

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180516223007.10256-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v3-a 00/27] target/arm: Scalable Vector Extension === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v3 7/8] xen_disk: use a single entry iovec

On Fri, May 04, 2018 at 08:26:06PM +0100, Paul Durrant wrote: > Since xen_disk now always copies data to and from a guest there is no need > to maintain a vector entry corresponding to every page of a request. > This means there is less per-request state to maintain so the ioreq > structure can

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

On 05/17/2018 03:05 AM, Markus Armbruster wrote: QAPI language design alternatives: 1. Having unions cover all discriminator values explicitly is useful. 2. Having unions repeat all the discriminator values explicitly is not useful. All we need is replacing the code enforcing that by code

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

Hi, > > Related: can modules depend on modules, so we could make x_keymap a > > module of its own and have both gtk and sdl depend on it? > > > > That would also be useful when trying to modularize spice. > > How hard would it be to modularize the libspice-server side? The part > of the

Re: [Qemu-devel] [PATCH] pnv: add a physical mapping array describing MMIO ranges in each chip

Hi Cédric, On 05/17/2018 10:18 AM, Cédric Le Goater wrote: > Based on previous work done in skiboot, the physical mapping array > helps in calculating the MMIO ranges of each controller depending on > the chip id and the chip type. This is will be particularly useful for > the P9 models which use

[Qemu-devel] [PATCH v8 08/11] tests: extend qmp test with preconfig checks

Add permission checks for commands at 'preconfig' stage. Signed-off-by: Igor Mammedov --- v8: * there isn't QDECREF anymore use qobject_unref instead * add negative test for exit-preconfig v6: * replace 'cont' with 'exit-preconfig' command v5: *

Re: [Qemu-devel] [PATCH v6 1/2] qmp: adding 'wakeup-suspend-support' in query-target

On 05/17/2018 05:44 AM, Markus Armbruster wrote: Daniel Henrique Barboza writes: On 05/15/2018 12:45 PM, Markus Armbruster wrote: Daniel Henrique Barboza writes: When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell

Re: [Qemu-devel] [RFC PATCH v2 00/12] iommu: add MemTxAttrs argument to IOMMU translate function

On 17 May 2018 at 13:46, Paolo Bonzini wrote: > Yes, this also sounds good. It does have the same issue for VFIO that > get_num_indexes() would be called too late to fail (and again, in a > place where it's hard to fail). > > Maybe the index count and the index-from/to-attrs

Re: [Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

On 05/17/2018 04:52 AM, Vladimir Sementsov-Ogievskiy wrote: Finally, what about this? 13.04.2018 17:31, Vladimir Sementsov-Ogievskiy wrote: Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Still waiting on

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

On 17/05/2018 15:45, Gerd Hoffmann wrote: > Hi, > >>> Related: can modules depend on modules, so we could make x_keymap a >>> module of its own and have both gtk and sdl depend on it? >>> >>> That would also be useful when trying to modularize spice. >> >> How hard would it be to modularize the

Re: [Qemu-devel] [PATCH v3 28/38] target-microblaze: dec_msr: Plug a temp leak

On 05/16/2018 03:51 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Plug a temp leak. > > Reported-by: Richard Henderson > Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 36/38] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp

On 05/16/2018 03:51 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Cleanup eval_cond_jmp to use tcg_gen_movcond_i64(). > No functional change. > > Suggested-by: Richard Henderson > Signed-off-by: Edgar E. Iglesias

[Qemu-devel] [PATCH v2] linux-user: update comments to point to tcg_exec_init()

cpu_init() was replaced by cpu_create() since 2.12 but comments weren't updated. So update stale comments to point that page sizes arei actually initialized by tcg_exec_init(). Also move another qemu_host_page_size related comment before tcg_exec_init() where it belongs. Signed-off-by: Igor

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers

On Thu, 17 May 2018 10:15:19 +0200 David Hildenbrand wrote: > For multi stage hotplug handlers, we'll have to do some error handling > in some hotplug functions, so let's use a local error variable (except > for unplug requests). > > Also, add code to pass control to the final

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

Hi, > > +ifeq ($(CONFIG_X11),y) > > +sdl.mo-objs += x_keymap.o > > +gtk.mo-objs += x_keymap.o > > Would this cause symbol clash if both sdl & gtk modules are loaded > at the same time, or have we used linker scripts to limit what symbols > each module exposes ? Related: can modules depend on

[Qemu-devel] KVM Forum 2018: Call For Participation

KVM Forum 2018: Call For Participation October 24-26, 2018 - Edinburgh International Conference Centre - Edinburgh, UK (All submissions must be received before midnight June 14, 2018)

Re: [Qemu-devel] [PATCH v2] linux-user: update comments to point to tcg_exec_init()

Le 17/05/2018 à 13:51, Igor Mammedov a écrit : > cpu_init() was replaced by cpu_create() since 2.12 but comments > weren't updated. So update stale comments to point that page > sizes arei actually initialized by tcg_exec_init(). Also move > another qemu_host_page_size related comment before

  1   2   3   4   >