[Qemu-devel] [PATCH] aspeed_scu: Implement RNG register

The ASPEED SoCs contain a single register that returns random data when read. This models that register so that guests can use it. Signed-off-by: Joel Stanley --- hw/misc/aspeed_scu.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/misc/aspeed_scu.c

Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

On Sat, 26 May 2018 01:23:03 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > - Guard two Linux only headers. > - Define `ENOATTR` only if not only defined >(it's defined in system headers on Darwin). > > Signed-off-by: Keno Fischer

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

On Mon, 28 May 2018 11:20:36 +0200 Cédric Le Goater wrote: > On 05/28/2018 09:18 AM, Thomas Huth wrote: > > On 28.05.2018 09:06, Cédric Le Goater wrote: > >> On 05/28/2018 08:17 AM, Thomas Huth wrote: > >>> On 25.05.2018 16:02, Greg Kurz wrote: > On Fri, 18 May 2018

[Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

Removing a drive with drive_del while it is being used to run an I/O intensive workload can cause QEMU to crash. An AIO flush can yield at some point: blk_aio_flush_entry() blk_co_flush(blk) bdrv_co_flush(blk->root->bs) ... qemu_coroutine_yield() and let the HMP command to run, free

Re: [Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

On Fri, 25 May 2018 16:02:46 +0200 Kevin Wolf wrote: > Am 25.05.2018 um 13:53 hat Greg Kurz geschrieben: > > On Fri, 25 May 2018 10:37:15 +0200 > > Kevin Wolf wrote: > > > > > Am 25.05.2018 um 00:53 hat Greg Kurz geschrieben: > > > > Removing a drive

Re: [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

Am 25.04.2018 um 20:32 hat Eric Blake geschrieben: > Based-on: <20180424192506.149089-1-ebl...@redhat.com> > ([PATCH v2 0/6] block: byte-based AIO read/write) > Based-on: <20180424220157.177385-1-ebl...@redhat.com> > ([PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers) > > My quest

Re: [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures

On 05/25/18 18:48, Michael S. Tsirkin wrote: > Sort alphabetically. Will help us see if anything is missing (e.g. tile > is not there now). > > Signed-off-by: Michael S. Tsirkin > --- > arch_init.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > >

Re: [Qemu-devel] [PATCH 4/8] qcow: Switch qcow_co_writev to byte-based calls

Am 25.04.2018 um 20:32 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internals of the qcow > driver write function, by iterating over offset/bytes instead of > sector_num/nb_sectors, and repurposing

Re: [Qemu-devel] [PATCH 3/8] qcow: Switch qcow_co_readv to byte-based calls

Am 25.04.2018 um 20:32 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internals of the qcow > driver read function, by iterating over offset/bytes instead of > sector_num/nb_sectors, and repurposing

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/18 09:32, Laszlo Ersek wrote: > On 05/23/18 01:40, Michael S. Tsirkin wrote: >> On Wed, May 23, 2018 at 12:42:09AM +0200, Laszlo Ersek wrote: >>> Hold on, >>> >>> On 05/22/18 21:51, Laszlo Ersek wrote: >>> It had taken years until the edk2 core gained a universal

Re: [Qemu-devel] [PATCH 2/8] qcow: Switch get_cluster_offset to be byte-based

Am 25.04.2018 um 20:32 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internal helper function > get_cluster_offset(), by changing n_start and n_end to by byte > offsets rather than sector indices within the

Re: [Qemu-devel] [Bug 1773753] [NEW] virsh managed save fails with qemu version v2.12.0-813-g5a5c383b13-dirty on powerpc

On Mon, May 28, 2018 at 09:12:21AM -, Satheesh Rajendran wrote: > Public bug reported: > > Host Env: > IBM Power8 with Fedora28 base with compiled upstream kernel, qemu, libvirt. > > Host Kernel: 4.17.0-rc5-00069-g3acf4e395260 > > qemu-kvm(5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b): >

Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP

On Thu, 24 May 2018 17:42:03 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > I'm queueing this version (including v8 of patches 5-7) on > > numa-next. > > > > Markus, Daniel: you were the people I remember expressing some > > concerns

Re: [Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

Daniel P. Berrangé writes: > Just a ping to say I'd like us to restart work this patch and try to get > it mergable for the 2.13 cycle, so I can rely it on for the ACL support > I've had out of tree since 2.6 :-) Fair enough. I'll see what I can do.

Re: [Qemu-devel] [PATCH v7 04/11] hmp: disable monitor in preconfig state

On Fri, 25 May 2018 16:39:34 -0300 Eduardo Habkost wrote: > On Fri, May 25, 2018 at 08:05:30AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Thu, May 24, 2018 at 08:16:20PM +0200, Markus Armbruster wrote: > > >> Markus

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

Daniel P. Berrangé writes: > On Mon, Aug 14, 2017 at 07:49:54AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 08/11/2017 11:05 AM, Markus Armbruster wrote: >> >> We've wanted -object to support non-scalar properties for a while. >> >>

[Qemu-devel] [Bug 1773753] Re: virsh managed save fails with qemu version v2.12.0-813-g5a5c383b13-dirty on powerpc

To recover from the failed state it requires below steps to be run. # virsh destroy avocado-vt-vm1 Domain avocado-vt-vm1 destroyed # virsh undefine --managed-save avocado-vt-vm1 Domain avocado-vt-vm1 has been undefined -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] release retrospective, next release timing, numbering

On 02/05/2018 11:10, Daniel P. Berrangé wrote: >> it would allow to postpone incompatible removals to relatively seldom >> major releases, add new features during more often minor releases, and >> fix bugs during regular patch releases. >> >> major releases can be scheduled every 1-2 years, for

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

On 05/28/2018 09:18 AM, Thomas Huth wrote: > On 28.05.2018 09:06, Cédric Le Goater wrote: >> On 05/28/2018 08:17 AM, Thomas Huth wrote: >>> On 25.05.2018 16:02, Greg Kurz wrote: On Fri, 18 May 2018 18:44:02 +0200 Cédric Le Goater wrote: > This IRQ number hint can

[Qemu-devel] [Bug 1773753] [NEW] virsh managed save fails with qemu version v2.12.0-813-g5a5c383b13-dirty on powerpc

Public bug reported: Host Env: IBM Power8 with Fedora28 base with compiled upstream kernel, qemu, libvirt. Host Kernel: 4.17.0-rc5-00069-g3acf4e395260 qemu-kvm(5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b): v2.12.0-813-g5a5c383b13-dirty libvirt(4804a4db33a37f828d033733bc47f6eff5d262c3): Guest

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

Daniel P. Berrangé writes: > On Mon, Aug 14, 2017 at 01:24:17PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Fri, Aug 11, 2017 at 12:47:44PM -0500, Eric Blake wrote: >> >> On 08/11/2017 11:05 AM, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH] ARM: ACPI: Fix use-after-free due to memory realloc

Hi Shannon, On 05/28/2018 10:42 AM, Shannon Zhao wrote: > acpi_data_push uses g_array_set_size to resize the memory size. If there > is no enough contiguous memory, the address will be changed. So previous > pointer could not be used any more. It must update the pointer and use > the new one. >

Re: [Qemu-devel] [PATCH v5 43/49] docker: move debian-powerpc-cross to sid based build

On Fri, 05/25 15:19, Alex Bennée wrote: > The original Jessie based cross builder hasn't worked for a while. The > state of the libraries is still perilous for cross-building QEMU but > we can use it for building TCG tests. > > The debian-apt-fake.sh script can also be dropped as it is no longer

Re: [Qemu-devel] [PULL 20/37] qcow2: Give the refcount cache the minimum possible size by default

On Mon 28 May 2018 10:38:55 AM CEST, Kevin Wolf wrote: >> > +if (!refcount_cache_size_set) { >> > +*refcount_cache_size = MIN_REFCOUNT_CACHE_SIZE * >> > s->cluster_size; >> >> ...but in the else clause down here, we don't have the cast, and >> Coverity complains that we

[Qemu-devel] [PATCH] ARM: ACPI: Fix use-after-free due to memory realloc

acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. So previous pointer could not be used any more. It must update the pointer and use the new one. Signed-off-by: Shannon Zhao ---

Re: [Qemu-devel] [PATCH 00/14] block: Make blockdev-create a job and stable API

Am 25.05.2018 um 20:13 hat Eric Blake geschrieben: > On 05/25/2018 11:33 AM, Kevin Wolf wrote: > > This changes the x-blockdev-create QMP command so that it doesn't block > > the monitor and the main loop any more, but starts a background job that > > performs the image creation. > > > > The

Re: [Qemu-devel] [PULL 20/37] qcow2: Give the refcount cache the minimum possible size by default

Am 25.05.2018 um 19:10 hat Peter Maydell geschrieben: > On 15 May 2018 at 16:40, Kevin Wolf wrote: > > From: Alberto Garcia > > > > The L2 and refcount caches have default sizes that can be overridden > > using the l2-cache-size and refcount-cache-size (an

Re: [Qemu-devel] [PATCH 0/6] Update Linux headers to 4.17-rc6

On 25/05/2018 16:00, Michael S. Tsirkin wrote: > On Fri, May 25, 2018 at 02:27:49PM +0100, Peter Maydell wrote: >> This series updates our copy of the Linux kernel headers to 4.17-rc6. >> To do that we have to fix up some issues: >> * we had a hand-hacked definition of VIRTIO_GPU_CAPSET_VIRGL2 >>

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

Eduardo Habkost writes: > On Fri, May 25, 2018 at 08:30:59AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: > [...] >> >> >> Worse, a machine type property that is

[Qemu-devel] [PATCH v8 4/5] monitor: fix comment for monitor_lock

Fix typo in d622cb5879c. Meanwhile move these variables close to each other. monitor_qapi_event_state can be declared static, add that. Reported-by: Markus Armbruster Signed-off-by: Peter Xu --- monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4

[Qemu-devel] [PATCH v8 5/5] monitor: add lock to protect mon_fdsets

Introduce a new global big lock for mon_fdsets. Take it where needed. The monitor_fdset_get_fd() handling is a bit tricky: now we need to call qemu_mutex_unlock() which might pollute errno, so we need to make sure the correct errno be passed up to the callers. To make things simpler, we let

[Qemu-devel] [PATCH v8 0/5] monitor: let Monitor be thread safe

v8: - some wording changes according to previous comments [Markus] - return -ENOENT too in stubs/fdset.c:monitor_fdset_get_fd() [Stefan] - refactor the fdset functions a bit, drop "ret" where proper [Markus] - one more patch to fix monitor_lock comment [Markus] - regular rebase and torturing v7:

[Qemu-devel] [PATCH v4 18/19] replay: describe reverse debugging in docs/replay.txt

This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt

[Qemu-devel] [PATCH v8 1/5] monitor: rename out_lock to mon_lock

The out_lock is protecting a few Monitor fields. In the future the monitor code will start to run in multiple threads. We are going to turn it into a bigger lock to protect not only the out buffer but also most of the rest. Since at it, rearrange the Monitor struct a bit. Reviewed-by: Stefan

[Qemu-devel] [PATCH v4 17/19] gdbstub: add reverse continue support in replay mode

This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were

[Qemu-devel] [PATCH v4 19/19] replay: allow loading any snapshots before recording

This patch enables using -loadvm in recording mode to allow starting the execution recording from any of the available snapshots. It also fixes loading of the record/replay state, therefore snapshots created in replay mode may also be used for starting the new recording. Signed-off-by: Pavel

[Qemu-devel] [Bug 1773743] [NEW] qemu-user -g xxx -E LD_PROFILE=xxx segfault

Public bug reported: Here is two simple steps to reproduce the bug: $ qemu-x86_64 -E LD_PROFILE=libc.so.6 -E LD_PROFILE_OUTPUT=. -g 12345 -L / /bin/ls (libc.so and /bin/ls might change on your system, in this case we just need a binary with a profilable needed library) In a other window

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

On 28.05.2018 09:06, Cédric Le Goater wrote: > On 05/28/2018 08:17 AM, Thomas Huth wrote: >> On 25.05.2018 16:02, Greg Kurz wrote: >>> On Fri, 18 May 2018 18:44:02 +0200 >>> Cédric Le Goater wrote: >>> This IRQ number hint can possibly be used by the VIO devices if the

[Qemu-devel] [PATCH v4 15/19] replay: flush rr queue before loading the vmstate

Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing

[Qemu-devel] [PATCH v4 14/19] translator: fix breakpoint processing

QEMU cannot pass through the breakpoints when 'si' command is used in remote gdb. This patch disables inserting the breakpoints when we are already single stepping though the gdb remote protocol. This patch also fixes icount calculation for the blocks that include breakpoints - instruction with

[Qemu-devel] [PATCH v8 3/5] monitor: more comments on lock-free elements

Add some explicit comments for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH v4 12/19] timer: remove replay clock probe in deadline calculation

Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. However, this probing was made in replay mode for the timer lists that are empty. This patch removes clock probing in

[Qemu-devel] [PATCH v4 13/19] replay: refine replay-time module

This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/replay/replay-time.c

[Qemu-devel] [PATCH v4 11/19] replay: flush events when exiting

This patch adds events processing when emulation finishes instead of just cleaning the queue. Now the bdrv coroutines will be in consistent state when emulator closes. It allows correct polling of the block layer at exit. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v8 2/5] monitor: protect mon->fds with mon_lock

mon->fds were protected by BQL. Now protect it by mon_lock so that it can even be used in monitor iothread. Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- monitor.c | 22 ++

[Qemu-devel] [PATCH v4 05/19] replay: finish record/replay before closing the disks

After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |

[Qemu-devel] [PATCH v4 09/19] replay: introduce breakpoint at the specified step

This patch introduces replay_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. The commands have one argument - number of instructions executed since the start of the

[Qemu-devel] [PATCH v4 10/19] replay: implement replay-seek command to proceed to the desired step

This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified step. The commands automatically loads nearest snapshot and replay the execution to find the desired step. Signed-off-by: Pavel Dovgalyuk -- v2: - renamed replay_seek

[Qemu-devel] [PATCH v4 16/19] gdbstub: add reverse step support in replay mode

GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v4 06/19] qcow2: introduce icount field for snapshots

This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake)

[Qemu-devel] [PATCH v4 08/19] replay: introduce info hmp/qmp command

This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the execution step (number or recorded/replayed instructions). Signed-off-by: Pavel Dovgalyuk -- v2: -

[Qemu-devel] [PATCH v4 04/19] replay: don't drain/flush bdrv queue while RR is working

In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode.

[Qemu-devel] [PATCH v4 07/19] migration: introduce icount field for snapshots

Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for rewinding the recorded execution to the specific moment of the time. E.g., 'reverse step' action needs to load the nearest

[Qemu-devel] [PATCH v4 03/19] replay: update docs for record/replay with block devices

This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt

[Qemu-devel] [PATCH v4 01/19] block: implement bdrv_snapshot_goto for blkreplay

From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v4 02/19] replay: disable default snapshot for record/replay

From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file

[Qemu-devel] [PATCH v4 00/19] reverse debugging

GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

On Thu, May 24, 2018 at 11:03:55AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Similar to previous patch, but introduce a new global big lock for > > mon_fdsets. Take it where needed. > > The previous patch is "monitor: more comments on lock-free >

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

On 05/28/2018 08:17 AM, Thomas Huth wrote: > On 25.05.2018 16:02, Greg Kurz wrote: >> On Fri, 18 May 2018 18:44:02 +0200 >> Cédric Le Goater wrote: >> >>> This IRQ number hint can possibly be used by the VIO devices if the >>> "irq" property is defined on the command line but it

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

Hi yang, Alibaba made this proposal for NVDimm snapshot optimization, can you give some advice about this discussion? Thanks -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, May 14, 2018 9:49 PM To: Kevin Wolf Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

On Fri, May 25, 2018 at 10:01:57AM +0100, Stefan Hajnoczi wrote: > On Fri, May 25, 2018 at 11:30:22AM +0800, Peter Xu wrote: > > On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote: > > > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote: > > > > int

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

On Thu, May 24, 2018 at 01:16:11PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote: > >> Regarding the subject: what are "fleids"? > > > > Ouch. :( I meant the word "fields". > > Can touch that up in

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

On 25.05.2018 16:02, Greg Kurz wrote: > On Fri, 18 May 2018 18:44:02 +0200 > Cédric Le Goater wrote: > >> This IRQ number hint can possibly be used by the VIO devices if the >> "irq" property is defined on the command line but it seems it is never >> the case. It is not used in

[Qemu-devel] [RFC PATCH] hw/misc/unimp: Add create_unimplemented_subregion_device()

The create_unimplemented_device() function is very useful to register unimplemented devices to the SysBus 'absolute' address. Some devices are modelled as container of memory subregions, the subregions being mmio-mapped relatively to the container base address. With these container devices, the

<    1   2