The device designator data returned in INQUIRY command will be useful to
fill in source/target fields during copy offloading. Do this when
connecting to the target and save the data for later use.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c | 41
v8: Fix compiling against new glibc and libiscsi on Fedora 28 where v7 had
conflict definitions. [Stefan, myself]
- Add HAVE_COPY_FILE_RANGE in configure.
- Drop IDENT_DESCR_TGT_DESCR from scsi constants header.
v7: Fix qcow2.
v6: Pick up rev-by from Stefan and Eric.
Tweak patch
Signed-off-by: Fam Zheng
---
tests/docker/dockerfiles/fedora.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/fedora.docker
b/tests/docker/dockerfiles/fedora.docker
index b706f42405..65d7761cf5 100644
---
Issue EXTENDED COPY (LID1) command to implement the copy_range API.
The parameter data construction code is modified from libiscsi's
iscsi-dd.c.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c| 219 +++
From: Chen Hanxiao
This patch adds support for getting the usage of mounted
filesystem.
It's very useful when we try to monitor guest's filesystem.
Cc: Michael Roth
Cc: Eric Blake
Signed-off-by: Chen Hanxiao
---
v2:
add description in qapi-schema and version numbers
v3:
use float for
Thanks deeply for your clear explanation!
Let me try to conclude what I learned from your description.
qemu_set_irq() qemu_set_irq()
[ device ] -> [ GIC ] -> [ CPU ]
Detailed:
[device]
=>qemu_set_irq()
[GIC]
With copy_file_range(2), we can implement the bdrv_co_copy_range
semantics.
Signed-off-by: Fam Zheng
---
block/file-posix.c | 98 +++--
configure | 17 +++
include/block/raw-aio.h | 10 -
3 files changed, 120 insertions(+), 5
We don't verify the request range against s->size in the I/O callbacks
except for raw_co_pwritev. This is inconsistent (especially for
raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them, in the meanwhile
make the helper reusable by the coming new callbacks.
Note that in most cases the block
The two callbacks are implemented quite similarly to the read/write
functions: bdrv_co_copy_range_from maps for read and calls into bs->file
or bs->backing depending on the allocation status; bdrv_co_copy_range_to
maps for write and calls into bs->file.
Reviewed-by: Stefan Hajnoczi
Introduce the bdrv_co_copy_range() API for copy offloading. Block
drivers implementing this API support efficient copy operations that
avoid reading each block from the source device and writing it to the
destination devices. Examples of copy offload primitives are SCSI
EXTENDED COPY and Linux
This loop is repeated a growing number times. Make a helper.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
block/iscsi.c | 54 ---
1 file changed, 17 insertions(+), 37 deletions(-)
diff --git a/block/iscsi.c
Just pass down to ->file.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/raw-format.c | 32
1 file changed, 32 insertions(+)
diff --git a/block/raw-format.c b/block/raw-format.c
index b69a0674b3..f2e468df6f 100644
--- a/block/raw-format.c
+++
At the same time, fix the repeated re-reading of the argv and env
arrays from guest memory. Instead read into a unified array once.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 203 ++-
1 file changed, 106 insertions(+), 97 deletions(-)
At the same time, merge do_open_to_handle_at into the new function.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 84 ++--
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 108 +++
1 file changed, 69 insertions(+), 39 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 48bb1c0231..e208f8647a 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 36 ++--
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4d9b9cad6e..3dfb77ac11 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 59 ++--
1 file changed, 40 insertions(+), 19 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index b5736436f8..bbe9d6d9fb 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 113 ---
1 file changed, 63 insertions(+), 50 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 2a172e24eb..24514329b0 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 156 ++-
1 file changed, 94 insertions(+), 62 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 53eac58ec0..b3838c5161 100644
--- a/linux-user/syscall.c
+++
At the same time, merge do_ioctl into the new function.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 190 ++-
1 file changed, 97 insertions(+), 93 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index
From: Junyan He
Guest writes to vNVDIMM labels are intercepted and performed on the
backend by QEMU. When the backend is a real persistent memort, QEMU
needs to take proper operations to ensure its write persistence on the
persistent memory. Otherwise, a host power failure may result in the
loss
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Fri, 25 May 2018 16:39:34 -0300
> Eduardo Habkost wrote:
>
> > On Fri, May 25, 2018 at 08:05:30AM +0200, Markus Armbruster wrote:
> > > Eduardo Habkost writes:
> > >
> > > > On Thu, May 24, 2018 at 08:16:20PM +0200, Markus Armbruster wrote:
On 31 May 2018 at 23:49, Richard Henderson wrote:
> This will allow us to protect gdbserver_fd from the guest.
Ha, I hadn't realised we already had an internal-to-QEMU filedescriptor :-)
thanks
-- PMM
Guest xml(cpu portion):
...
32
/machine
hvm
/home/kvmci/linux/vmlinux
root=/dev/sda2 rw console=tty0 console=ttyS0,115200
init=/sbin/init initcall_debug
...
Host lscpu:
# lscpu
Architecture: ppc64le
Byte Order: Little Endian
When hot-plugging a block device fails due to image locking errors,
users won't see the helpful 'Is another process using the image?'
message in QMP because currently the error hint is not carried over
there.
Even though extending QMP to include hint is a conceivably easy task,
Libvirt will need
With copy_file_range(2), we can implement the bdrv_co_copy_range
semantics.
Signed-off-by: Fam Zheng
---
block/file-posix.c | 98 +++--
configure | 17 +++
include/block/raw-aio.h | 10 -
3 files changed, 120 insertions(+), 5
Introduce the bdrv_co_copy_range() API for copy offloading. Block
drivers implementing this API support efficient copy operations that
avoid reading each block from the source device and writing it to the
destination devices. Examples of copy offload primitives are SCSI
EXTENDED COPY and Linux
v9: Don't break older libiscsi. [patchew]
v8: Fix compiling against new glibc and libiscsi on Fedora 28 where v7 had
conflict definitions. [Stefan, myself]
- Add HAVE_COPY_FILE_RANGE in configure.
- Drop IDENT_DESCR_TGT_DESCR from scsi constants header.
v7: Fix qcow2.
v6: Pick up
We don't verify the request range against s->size in the I/O callbacks
except for raw_co_pwritev. This is inconsistent (especially for
raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them, in the meanwhile
make the helper reusable by the coming new callbacks.
Note that in most cases the block
On Fri, Jun 01, 2018 at 03:29:45PM +0800, Wei Wang wrote:
> On 06/01/2018 01:07 PM, Peter Xu wrote:
> > On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote:
> > > On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote:
> > > > This is the deivce part implementation to add a new feature,
> >
On 06/01/2018 01:07 PM, Peter Xu wrote:
On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote:
On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote:
This is the deivce part implementation to add a new feature,
VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 294 +++
1 file changed, 158 insertions(+), 136 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 36e2bb838e..e37a3ab643 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 132 ---
1 file changed, 87 insertions(+), 45 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index bbe9d6d9fb..88e0da31ba 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 123 +++
1 file changed, 79 insertions(+), 44 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4be71367fc..4d9b9cad6e 100644
--- a/linux-user/syscall.c
+++
Le 01/06/2018 à 09:30, Richard Henderson a écrit :
> There was supposed to be a single point of return for do_syscall
> so that tracing works properly. However, there are a few bugs
> in that area. It is significantly simpler to simply split out
> an inner function to enforce this.
>
>
Hi Peter,
Thank you a lot for the analysis!
So it'll be simpler
> if you start with the buffer in the host QEMU process, map this
> in to the guest's physical address space at some GPA, tell the
> guest kernel that that's the GPA to use, and have the guest kernel
> map that GPA into the guest
From: Junyan He
As more flag parameters besides the existing 'share' are going to be
added to following functions
memory_region_init_ram_from_file
qemu_ram_alloc_from_fd
qemu_ram_alloc_from_file
let's switch them to use the 'flags' parameters so as to ease future
flag additions.
The
From: Junyan He
Add a pair of configure options --{enable,disable}-libpmem to control
whether QEMU is compiled with PMDK libpmem [1].
QEMU may write to the host persistent memory (e.g. in vNVDIMM label
emulation and live migration), so it must take the proper operations
to ensure the
On Thu, 31 May 2018 21:25:57 -0400
Keno Fischer wrote:
> The size to pass to the `connect` call is the size of the entire
> `struct sockaddr_un`. Passing anything shorter than this causes errors
> on darwin.
>
From the linux unix(7) manual page:
ret = connect (data_socket, (const
On Thu, 05/31 23:45, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Type: series
> Message-id: 20180601062849.28641-1-f...@redhat.com
> Subject: [Qemu-devel] [PATCH v8 00/11] qemu-img convert with copy offloading
>
> ===
On Thu, 31 May 2018 21:26:02 -0400
Keno Fischer wrote:
> These functions will need custom implementations on Darwin. Since the
> implementation is very similar among all of them, and 9p-util already
> has the _nofollow version of fgetxattrat, let's move them all there.
>
> Signed-off-by: Keno
On 06/01/2018 12:58 PM, Peter Xu wrote:
On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote:
This is the deivce part implementation to add a new feature,
VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
receives the guest free page hints from the driver and clears
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 187 +--
1 file changed, 92 insertions(+), 95 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 258aff0411..d0bf650c62 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/qemu.h| 2 +-
linux-user/syscall.c | 20 ++--
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 05a82a3628..623a8d8b7a 100644
--- a/linux-user/qemu.h
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 77 +---
1 file changed, 43 insertions(+), 34 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e208f8647a..b5736436f8 100644
--- a/linux-user/syscall.c
+++
Transform outermost "break" to "return ret". If the immediately
preceeding statement was an assignment to ret, return the value
directly.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 969 +--
1 file changed, 390 insertions(+), 579
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 311 +--
1 file changed, 154 insertions(+), 157 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index d0bf650c62..8ea2099001 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 109 +--
1 file changed, 73 insertions(+), 36 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 24514329b0..36092d753d 100644
--- a/linux-user/syscall.c
+++
On 06/01/2018 12:30 AM, Richard Henderson wrote:
> This function is, as I think everyone will agree, way too large.
> This is about a third of the complete change, but I thought I'd
> get some feedback on the method and form before I go any farther.
Bah. I also meant to say
Based-on:
From: Junyan He
When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it
needs to know whether the backend storage is a real persistent memory,
in order to decide whether special operations should be performed to
ensure the data persistence.
This boolean option 'pmem' allows users to
From: Junyan He
The nvdimm kind memory does not support post copy now.
We disable post copy if we have nvdimm memory and print some
log hint to user.
Signed-off-by: Junyan He
---
migration/ram.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180601062849.28641-1-f...@redhat.com
Subject: [Qemu-devel] [PATCH v8 00/11] qemu-img convert with copy offloading
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked
On 31 May 2018 at 21:39, Aaron Lindsay wrote:
> On May 31 15:18, Peter Maydell wrote:
>>if (arm_feature(env, ARM_FEATURE_V7VE) {
>>/* v7 Virtualization Extensions. In real hardware this implies
>> * EL2 and also the presence of the Security Extensions.
>> * For QEMU,
Public bug reported:
PowerPC KVM guest does not emulate L2 and L2 caches for vCPU, it would
be good to have them enabled if not any known issues/limitation already
with PowerPC.
Host Env:
kernel: 4.17.0-rc7-00045-g0512e0134582
qemu: v2.12.0-923-gc181ddaa17-dirty
#libvirtd -V
libvirtd (libvirt)
On 31 May 2018 at 17:00, Peter Maydell wrote:
> target-arm queue. This has the "plumb txattrs through various
> bits of exec.c" patches, and a collection of bug fixes from
> various people.
>
> v2: fix compile error on arm hosts...
>
> thanks
> -- PMM
>
>
> The following changes since commit
On Thu, May 31, 2018 at 10:34:45AM +0800, Fam Zheng wrote:
> The implementation is similar to the 'qemu-img convert'. In the
> beginning of the job, offloaded copy is attempted. If it fails, further
> I/O will go through the existing bounce buffer code path.
>
> Signed-off-by: Fam Zheng
> ---
>
It's a BlockBackend wrapper of the BDS interface.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/block-backend.c | 18 ++
include/sysemu/block-backend.h | 4
2 files changed, 22 insertions(+)
diff --git a/block/block-backend.c
This function is, as I think everyone will agree, way too large.
This is about a third of the complete change, but I thought I'd
get some feedback on the method and form before I go any farther.
r~
Richard Henderson (33):
linux-user: Split out do_syscall1
linux-user: Relax single exit from
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8ea2099001..f7b7051c1c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -12081,7 +12081,7 @@
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 82 +++-
1 file changed, 43 insertions(+), 39 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f7b7051c1c..4269ec2c23 100644
--- a/linux-user/syscall.c
+++
These are relatively simple unconditionally defined syscalls.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 198 ---
1 file changed, 111 insertions(+), 87 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 65
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a9b59a8658..fb1a8a4e7e 100644
--- a/linux-user/syscall.c
+++
At the same time, merge do_name_to_handle_at into the new function.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 129 +--
1 file changed, 64 insertions(+), 65 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index
There is no reason to list these, since -ENOSYS is the default.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 140 ---
1 file changed, 140 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 88e0da31ba..6a701ea8f6
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 45 +---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 6a701ea8f6..b568144369 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 176 +--
1 file changed, 101 insertions(+), 75 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e37a3ab643..c3bd625965 100644
--- a/linux-user/syscall.c
+++
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180601073050.8054-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH 00/33] linux-user: Begin splitting do_syscall
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On Thu, 31 May 2018 21:25:58 -0400
Keno Fischer wrote:
> If the size returned from llistxattr is 0, we skipped the malloc
> call, leaving xattr.value uninitialized. However, this value is
> later passed to `g_free` without any further checks, causing an
Ouch, good catch.
> error. Fix that by
On Fri, Jun 01, 2018 at 02:28:44PM +0800, Fam Zheng wrote:
> With copy_file_range(2), we can implement the bdrv_co_copy_range
> semantics.
>
> Signed-off-by: Fam Zheng
> ---
> block/file-posix.c | 98 +++--
> configure | 17 +++
>
That’s right.
Pavel Dovgalyuk
From: Arnabjyoti Kalita [mailto:akal...@cs.stonybrook.edu]
Sent: Friday, June 01, 2018 11:27 AM
To: Pavel Dovgalyuk
Cc: Stefan Hajnoczi; qemu-devel@nongnu.org; Pavel Dovgalyuk
Subject: Re: [Qemu-devel] Recording I/O activity after KVM does a VMEXIT
Dear
On Fri, 06/01 10:37, Stefan Hajnoczi wrote:
> On Thu, May 31, 2018 at 11:45:17PM -0700, no-re...@patchew.org wrote:
> > /var/tmp/patchew-tester-tmp-2l7s8dte/src/block/iscsi.c: In function
> > ‘iscsi_populate_target_desc’:
> > /var/tmp/patchew-tester-tmp-2l7s8dte/src/block/iscsi.c:2242:15: error:
On Fri, Jun 01, 2018 at 03:36:01PM +0800, Wei Wang wrote:
> On 06/01/2018 12:00 PM, Peter Xu wrote:
> > On Tue, Apr 24, 2018 at 02:13:46PM +0800, Wei Wang wrote:
> > > This patch adds an API to clear bits corresponding to guest free pages
> > > from the dirty bitmap. Spilt the free page block if
On Thu, 31 May 2018 21:26:03 -0400
Keno Fischer wrote:
> The current file only has the Linux versions of these functions.
> Rename the file accordingly and update the Makefile to only build
> it on Linux. A Darwin version of these will follow later in the
> series.
>
> Signed-off-by: Keno
On Thu, 31 May 2018 21:26:04 -0400
Keno Fischer wrote:
> This code previously relied on P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR
> having the same numerical value and deferred any errorchecking to the
> syscall itself. However, while the former assumption is true on Linux,
> it is not true in
On 06/01/2018 12:00 PM, Peter Xu wrote:
On Tue, Apr 24, 2018 at 02:13:46PM +0800, Wei Wang wrote:
This patch adds an API to clear bits corresponding to guest free pages
from the dirty bitmap. Spilt the free page block if it crosses the QEMU
RAMBlock boundary.
Signed-off-by: Wei Wang
CC: Dr.
From: Junyan He
We need to use these flags in other files rather than just in exec.c,
For example, RAM_SHARED should be used when create a ram block from file.
We expose them the exec/memory.h
Signed-off-by: Junyan He
---
exec.c| 17 -
include/exec/memory.h |
From: Junyan He
QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and
live migration. If the backend is on the persistent memory, QEMU needs
to take proper operations to ensure its writes persistent on the
persistent memory. Otherwise, a host power failure may result in the
loss the
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1527840629-18648-1-git-send-email-junyan...@gmx.com
Subject: [Qemu-devel] [PATCH V6 0/7]
Dear Pavel,
Thank you for providing me with all the details. Let us take an example of
a Network packet. In icount mode, when the network backend, receives a
network packet, you record the whole packet with the help of the
replay-filter. This packet will be written to the log file. Now when the
* Greg Kurz (gr...@kaod.org) wrote:
> On Thu, 31 May 2018 21:25:56 -0400
> Keno Fischer wrote:
>
> > strchrnul is a GNU extension and thus unavailable on a number of targets.
> > In the review for a commit removing strchrnul from 9p, I was asked to
> > create a qemu_strchrnul helper to factor
Hi there,
I am doing some test on qemu vcpu hotplug and I run into some trouble.
An emulation failure occurs and qemu prints the following msg:
KVM internal error. Suberror: 1
emulation failure
EAX= EBX= ECX= EDX=0600
ESI= EDI= EBP=
Just pass down to ->file.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/raw-format.c | 32
1 file changed, 32 insertions(+)
diff --git a/block/raw-format.c b/block/raw-format.c
index b69a0674b3..f2e468df6f 100644
--- a/block/raw-format.c
+++
The device designator data returned in INQUIRY command will be useful to
fill in source/target fields during copy offloading. Do this when
connecting to the target and save the data for later use.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c | 41
It's a BlockBackend wrapper of the BDS interface.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/block-backend.c | 18 ++
include/sysemu/block-backend.h | 4
2 files changed, 22 insertions(+)
diff --git a/block/block-backend.c
The new blk_co_copy_range interface offers a more efficient way in the
case of network based storage. Make use of it to allow faster convert
operation.
Since copy offloading cannot do zero detection ('-S') and compression
(-c), only try it when these options are not used.
Signed-off-by: Fam
On Thu, May 31, 2018 at 11:45:17PM -0700, no-re...@patchew.org wrote:
> /var/tmp/patchew-tester-tmp-2l7s8dte/src/block/iscsi.c: In function
> ‘iscsi_populate_target_desc’:
> /var/tmp/patchew-tester-tmp-2l7s8dte/src/block/iscsi.c:2242:15: error:
> ‘IDENT_DESCR_TGT_DESCR’ undeclared (first use in
On Thu, 31 May 2018 21:26:00 -0400
Keno Fischer wrote:
> In the review of
>
> 9p: Avoid warning if FS_IOC_GETVERSION is not defined
>
> Grep Kurz noted this error path was failing to set errp.
> Fix that.
>
> Signed-off-by: Keno Fischer
> ---
This is a bug fix so I've applied it to
On Fri, Jun 01, 2018 at 02:28:39PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/fedora.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems reasonable, Fedora is a cutting-edge distro. Unlike stable
distros like CentOS and Debian where we
On Thu, 31 May 2018 21:26:01 -0400
Keno Fischer wrote:
> Both `stbuf` and `local_ioc_getversion` where unused when
> FS_IOC_GETVERSION was not defined, causing a compiler warning.
>
> Reorgnaize the code to avoid this warning.
>
> Signed-off-by: Keno Fischer
> ---
>
> Changes since v1:
> *
The new blk_co_copy_range interface offers a more efficient way in the
case of network based storage. Make use of it to allow faster convert
operation.
Since copy offloading cannot do zero detection ('-S') and compression
(-c), only try it when these options are not used.
Signed-off-by: Fam
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 42 ++
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e2e2d58e84..fc3dc3f40d 100644
--- a/linux-user/syscall.c
+++
There was supposed to be a single point of return for do_syscall
so that tracing works properly. However, there are a few bugs
in that area. It is significantly simpler to simply split out
an inner function to enforce this.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 89
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 62
1 file changed, 23 insertions(+), 39 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4269ec2c23..a413aad658 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 179 +++
1 file changed, 113 insertions(+), 66 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index b3838c5161..2a172e24eb 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 123 +--
1 file changed, 60 insertions(+), 63 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index b568144369..53eac58ec0 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 325 ++-
1 file changed, 165 insertions(+), 160 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3dfb77ac11..36e2bb838e 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 127 +++
1 file changed, 80 insertions(+), 47 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 36092d753d..bde1f9872f 100644
--- a/linux-user/syscall.c
+++
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 129 ++-
1 file changed, 67 insertions(+), 62 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index c3bd625965..b9e07c2d3f 100644
--- a/linux-user/syscall.c
+++
On Thu, 31 May 2018 21:25:56 -0400
Keno Fischer wrote:
> strchrnul is a GNU extension and thus unavailable on a number of targets.
> In the review for a commit removing strchrnul from 9p, I was asked to
> create a qemu_strchrnul helper to factor out this functionality.
> Do so, and use it in a
From: Junyan He
Because we need to make sure the pmem kind memory data is synced
after migration, we choose to call pmem_persist() when the migration
finish. This will make sure the data of pmem is safe and will not
lose if power is off.
Signed-off-by: Junyan He
---
include/qemu/pmem.h | 1 +
1 - 100 of 347 matches
Mail list logo
