[Qemu-devel] [PATCH] typedefs: add QJSON

2018-06-08 Thread Greg Kurz
Since commit 83ee768d6247b, we now have two places that define the QJSON type: $ git grep 'typedef struct QJSON QJSON' include/migration/vmstate.h:typedef struct QJSON QJSON; migration/qjson.h:typedef struct QJSON QJSON; This breaks docker-test-build@centos6: In file included from

Re: [Qemu-devel] [PATCH] typedefs: add QJSON

2018-06-08 Thread Greg Kurz
On Fri, 8 Jun 2018 10:04:39 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > Since commit 83ee768d6247b, we now have two places that define the > > QJSON type: > > > > $ git grep 'typedef struct QJSON QJSON' > > include/migration/vmstate.h:typedef struct QJSON

Re: [Qemu-devel] [PATCH v2 2/8] ppc4xx_i2c: Move register state to private struct and remove unimplemented sdata and intr registers

2018-06-08 Thread BALATON Zoltan
On Fri, 8 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 03:31:48PM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan It's not clear to me why this is preferable to having the registers embedded in the state structure. The latter is pretty standard practice for qemu. Maybe

[Qemu-devel] [PATCH v4] target/ppc: Allow PIR read in privileged mode

2018-06-08 Thread Greg Kurz
From: luporl According to PowerISA, the PIR register should be readable in privileged mode also, not only in hypervisor privileged mode. PowerISA 3.0 - 4.3.3 Processor Identification Register "Read access to the PIR is privileged; write access is not provided." Figure 18 in section 4.4.4

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
On 08.06.2018 12:52, Greg Kurz wrote: > On Fri, 8 Jun 2018 11:24:51 +0200 > David Hildenbrand wrote: > >> +1 for error_abort, even if it takes another line. > +1 for error_abort > call shouldn't fail, but if does it won't be silently ignored > and introduce undefined

[Qemu-devel] [Bug 1467240] Re: Regression - bridged networking broken for Mac OS X guest

2018-06-08 Thread Thomas Huth
Patch had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5df6a1855b62dc6535 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH v2 03/10] python: futurize -f libfuturize.fixes.fix_next_call

2018-06-08 Thread Eduardo Habkost
Change obj.next() calls to next(obj). This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f libfuturize.fixes.fix_next_call $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 05/10] python: futurize -f lib2to3.fixes.fix_standarderror

2018-06-08 Thread Eduardo Habkost
Rename StandardError to Exception. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_standarderror $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 02/10] python: futurize -f libfuturize.fixes.fix_absolute_import

2018-06-08 Thread Eduardo Habkost
Make implicit relative imports explicit and add "from __future__ import absolute_import" at the top of each relevant module. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4)

[Qemu-devel] [PATCH v2 08/10] python: futurize -f lib2to3.fixes.fix_renames

2018-06-08 Thread Eduardo Habkost
Change sys.maxint to sys.maxsize. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_renames $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 06/10] python: futurize -f lib2to3.fixes.fix_reduce

2018-06-08 Thread Eduardo Habkost
Handle the move of reduce() to functools.reduce(). This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_reduce $py Reviewed-by: Stefan

[Qemu-devel] [PATCH v4 07/10] hw/block/nvme: Always apply block configuration to block driver

2018-06-08 Thread Ari Sundholm
This allows the block driver to use the block configuration of the new NVMe device. One use for this information is to set request limits using this information. Signed-off-by: Ari Sundholm --- hw/block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c

[Qemu-devel] [PATCH v6 27/49] tests/tcg: enable building for MIPS

2018-06-08 Thread Alex Bennée
This doesn't add any additional tests but enables building the multiarch tests for MIPS using docker cross compilers. We don't have a cross compiler for mips64 big endian though. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v2 10/10] python: futurize -f lib2to3.fixes.fix_numliterals

2018-06-08 Thread Eduardo Habkost
Convert octal literals into the new syntax. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_numliterals $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 09/10] python: futurize -f lib2to3.fixes.fix_except

2018-06-08 Thread Eduardo Habkost
Convert "except X, T" to "except X as T". This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_except $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v6 46/49] target/sh4: Fix translator.c assertion failure for gUSA

2018-06-08 Thread Alex Bennée
From: Richard Henderson The translator loop does not allow the tb_start hook to set dc->base.is_jmp; the only hook allowed to do that is translate_insn. Split the work between init_disas_context where we validate the gUSA parameters, and translate_insn where we emit code. Signed-off-by:

[Qemu-devel] [PATCH v6 45/49] tests/tcg: override runners for broken tests

2018-06-08 Thread Alex Bennée
To get a clean run of check-tcg these tests are currently skipped: - hello-mips for mips - linux-test for sparc Signed-off-by: Alex Bennée --- v4 - document broken tests in commit - temporarily demote fcvt while fixes percolate upstream v5 - reinstate fcvt - remove test-mmap

[Qemu-devel] [PULL 24/31] RISC-V: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-11-f4...@amsat.org Signed-off-by: Peter Maydell --- target/riscv/op_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/op_helper.c

[Qemu-devel] [PULL 05/31] smbus: add a smbus_eeprom_init_one() routine

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater This is an helper routine to add a single EEPROM on an I2C bus. It can be directly used by smbus_eeprom_init() which adds a certain number of EEPROMs on mips and x86 machines. Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 19/31] hw/core/register: Add trailing '\n' to qemu_log() call

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180606152128.449-6-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/core/register.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/register.c

[Qemu-devel] [PULL 28/31] sdcard: Add a 'spec_version' property, default to Spec v2.00

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé As of this commit, the Spec v1 is not working, and all controllers expect the cards to be conformant to Spec v2. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180607180641.874-4-f4...@amsat.org Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH v6 31/49] tests/tcg: enable building for Alpha

2018-06-08 Thread Alex Bennée
We can't use our normal Debian based compilers as Alpha isn't an officially supported architecture. However it is available as a port and fortunately cross compilers for all these targets are included in Debian Sid, the perpetual rolling/unstable/testing version of Debian. Signed-off-by: Alex

[Qemu-devel] [PATCH v6 47/49] tests: add top-level make dependency for docker builds

2018-06-08 Thread Alex Bennée
One problem with satisfying your docker dependencies in a sub-make it you might end up trying to satisfy the dependency multiple times. This is especially a problem with debian-sid based cross compilers and CI setups. We solve this by doing a docker build pass at the top level before any sub-makes

Re: [Qemu-devel] [PATCH v2 00/10] python: futurize --stage1 (Python 3 compatibility)

2018-06-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180608122952.2009-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10] python: futurize --stage1 (Python 3 compatibility) === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v3 3/3] glib: enforce the minimum required version and warn about old APIs

2018-06-08 Thread Daniel P . Berrangé
There are two useful macros that can be defined before including glib.h that are related to the min required glib version - GLIB_VERSION_MIN_REQUIRED When this is defined, if code uses an API that was deprecated in this version, or older, a compiler warning will be emitted. This alerts

Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40

2018-06-08 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 10:28:39AM +0200, Olaf Hering wrote: > Am Thu, 7 Jun 2018 09:25:24 +0100 > schrieb Daniel P. Berrangé : > > > https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms > > SLE12-SP2: 2.48.2 Thanks I'm adding that info Regards, Daniel -- |:

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Cornelia Huck
On Thu, 7 Jun 2018 18:37:16 +0200 Pierre Morel wrote: > On 07/06/2018 11:54, Cornelia Huck wrote: > > -- > > | scsw(g) | ssch > > -- | > > | guest > >

[Qemu-devel] [PATCH v4 01/10] block: Move two block permission constants to the relevant enum

2018-06-08 Thread Ari Sundholm
This allows using the two constants outside of block.c, which will happen in a subsequent patch. Signed-off-by: Ari Sundholm --- block.c | 6 -- include/block/block.h | 7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v6 44/49] tests/tcg: add run, diff, and skip helper macros

2018-06-08 Thread Alex Bennée
As we aren't using the default runners for all the test cases it is easy to miss out things like timeouts. To help with this we add some helpers and use them so we only need to make core changes in one place. Signed-off-by: Alex Bennée --- v5 - new for v5 v5.1 - diff-test->diff-out ---

[Qemu-devel] [PATCH v6 07/49] docker: allow "cc" command to run in user context

2018-06-08 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 59bce9f19a..37bfa98005 100755 ---

[Qemu-devel] [PATCH v6 19/49] tests/tcg/i386/test-i386: use modern vector_size attributes

2018-06-08 Thread Alex Bennée
The compiler complains about the old __mode__ style attributes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/i386/test-i386.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 08/10] hw/block/fdc: Always apply block configuration to block driver

2018-06-08 Thread Ari Sundholm
This allows the block driver to use the block configuration of the new floppy device. One use for this information is to set request limits using this information. Signed-off-by: Ari Sundholm --- hw/block/fdc.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/fdc.c

[Qemu-devel] [PATCH v6 38/49] tests/tcg: enable building for RISCV64

2018-06-08 Thread Alex Bennée
As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include| 1 + tests/docker/dockerfiles/debian-riscv64-cross.docker | 12

[Qemu-devel] [PULL 10/31] ftgmac100: add IEEE 802.1Q VLAN support

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The ftgmac100 NIC supports VLAN tag insertion and the MAC engine also has a control to remove VLAN tags from received packets. The VLAN control bits and VLAN tag information are contained in the second word of the transmit and receive descriptors. The Insert VLAN bit and

[Qemu-devel] [PATCH v6 28/49] tests/tcg/mips: include common mips hello-mips

2018-06-08 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/mips/Makefile.target | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 tests/tcg/mips/Makefile.target diff --git a/tests/tcg/mips/Makefile.target

[Qemu-devel] [PULL 04/31] aspeed: add an I2C RTC device to all machines

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The AST2500 EVB does not have an RTC but we can pretend that one is plugged on the I2C bus header. The romulus and witherspoon boards expects an Epson RX8900 I2C RTC but a ds1338 is good enough for the basic features we need. Signed-off-by: Cédric Le Goater Reviewed-by:

[Qemu-devel] [PATCH v6 33/49] tests/tcg: enable building for HPPA

2018-06-08 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v5 - add EXTRA_RUNS for mmap tests --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-hppa-cross.docker | 12

[Qemu-devel] [PATCH v6 30/49] tests/tcg: enable building for ppc64

2018-06-08 Thread Alex Bennée
Currently this just enables building the multiarch tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/ppc64le/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/tcg/ppc64le/Makefile.include

[Qemu-devel] [PULL 29/31] sdcard: Disable SEND_IF_COND (CMD8) for Spec v1

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé CMD8 is "Reserved" in Spec v1.10. Spec v2.00 introduces the SEND_IF_COND command: 6.4.1 Power Up CMD8 is newly added in the Physical Layer Specification Version 2.00 to support multiple voltage ranges and used to check whether the card supports

[Qemu-devel] [PULL 02/31] aspeed: remove ignore_memory_transaction_failures on all boards

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Message-id: 20180530064049.27976-2-...@kaod.org Signed-off-by: Peter Maydell --- hw/arm/aspeed.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index

[Qemu-devel] [PATCH v6 21/49] tests/tcg: move ARM specific tests into subdir

2018-06-08 Thread Alex Bennée
These only need to be built for ARM guests. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - do VPATH manipulation in tests/tcg/arm/Makefile.target - merge with fix hello-arm

[Qemu-devel] [PULL 07/31] misc: add pca9552 LED blinker model

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater Specs are available here : https://www.nxp.com/docs/en/application-note/AN264.pdf This is a simple model supporting the basic registers for led and GPIO mode. The device also supports two blinking rates but not the model yet. Signed-off-by: Cédric Le Goater

[Qemu-devel] [PATCH v2 3/6] spapr: move memory hotplug support check into spapr_memory_pre_plug()

2018-06-08 Thread David Hildenbrand
Let's finish cleaning up the hotplug handler. This check can be performed in the pre_plug code as the very first thing. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

[Qemu-devel] [PATCH v2 6/6] spapr: handle cpu core unplug via hotplug handler chain

2018-06-08 Thread David Hildenbrand
Factor out cpu core unplug into separate function from spapr_core_release(). Then use generic hotplug_handler_unplug() to trigger cpu core unplug, which would call spapr_machine_device_unplug() -> spapr_core_unplug() in the end. This way unplug operation is not buried in spapr internals and

[Qemu-devel] [PATCH v6 16/49] tests/tcg/i386: fix test-i386

2018-06-08 Thread Alex Bennée
We don't include anything from qemu itself for the build. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v4 - reword commit message to be more accurate ---

[Qemu-devel] [PATCH v3 4/7] qmp: enable query-[chardev|version|name|uuid|iothreads|memdev] commands in preconfig state

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: Igor Mammedov subj commands, are informational and do not depend on machine being initialized. Make them available early in preconfig runstate to make the later a little bit more useful. Signed-off-by: Igor Mammedov --- qapi/char.json | 3 ++- qapi/misc.json | 12 +++- 2 files

[Qemu-devel] [PATCH v6 42/49] Makefile.target: add (clean-/build-)guest-tests targets

2018-06-08 Thread Alex Bennée
Now all the build infrastructure is in place we can build tests for each guest that we support. That support mainly depends on having cross compilers installed or docker setup. To keep all the logic for that together we put the rules in tests/tcg/Makefile.include and include it from the main

[Qemu-devel] [PATCH v3 7/7] hmp: Allow HMP in preconfig state again

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now we can cope with preconfig in HMP, reenable by reverting commit 71dc578e116599ea73c8a2a4e693134702ec0e83. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- monitor.c | 6 -- 1 file changed, 6 deletions(-) diff

[Qemu-devel] [PATCH v4 03/10] block: Add a mechanism for passing a block driver a block configuration

2018-06-08 Thread Ari Sundholm
A block driver may need to know about the block configuration, most critically the sector sizes, of a block backend for alignment purposes or for some other reason. It doesn't seem like qemu has an existing mechanism for a block backend to convey the required information to the relevant block

[Qemu-devel] [PATCH v6 39/49] docker: move debian-powerpc-cross to sid based build

2018-06-08 Thread Alex Bennée
The original Jessie based cross builder hasn't worked for a while. The state of the libraries is still perilous for cross-building QEMU but we can use it for building TCG tests. The debian-apt-fake.sh script can also be dropped as it is no longer used. Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v6 23/49] tests/tcg/arm: fix up test-arm-iwmmxt test

2018-06-08 Thread Alex Bennée
We need to rename the source file to a .S so we can do a single-line assemble and link invocation. We also specify the additional CFLAGS for the compile as it's a non-standard ARM binary. Signed-off-by: Alex Bennée [rth: force fpu configuration] Signed-off-by: Richard Henderson Reviewed-by:

[Qemu-devel] [PATCH v6 05/49] docker: Add "cc" subcommand

2018-06-08 Thread Alex Bennée
Signed-off-by: Fam Zheng [AJB: add if args.paths check] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - add if args.paths check to avoid iterating null argument --- tests/docker/docker.py | 25 + 1 file

[Qemu-devel] [PATCH v6 15/49] tests/tcg/i386: Build fix for hello-i386

2018-06-08 Thread Alex Bennée
From: Fam Zheng We have -Werror=missing-prototype, add a dummy prototype to avoid that warning. Signed-off-by: Fam Zheng Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- tests/tcg/i386/hello-i386.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/i386/hello-i386.c

[Qemu-devel] [PULL 20/31] hw/mips/boston: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-7-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/mips/boston.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/mips/boston.c

[Qemu-devel] [PATCH v2 0/6] spapr: machine hotplug handler cleanups

2018-06-08 Thread David Hildenbrand
I'll be messing with machine hotplug handlers of pc/spapr/s390x in the context of [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers So this is a spin-off of the cleanup patches in the context of hotplug handlers. v1 -> v2: - dropped the three "local_err" patches - tweaked some

[Qemu-devel] [PULL 27/31] sdcard: Allow commands valid in SPI mode

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé >From the "Physical Layer Simplified Specification Version 1.10" Chapter 7.3 "SPI Mode Transaction Packets" Table 57: "Commands and arguments" Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Message-id: 20180607180641.874-3-f4...@amsat.org

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread David Hildenbrand
On 08.06.2018 14:55, Michael S. Tsirkin wrote: > On Fri, Jun 08, 2018 at 02:32:09PM +0200, David Hildenbrand wrote: >> > if (TYPE_PC_DIMM) { > pc_dimm_plug() > /* do here additional concrete machine specific things */ > } else if (TYPE_VIRTIO_MEM) { >

Re: [Qemu-devel] [PATCH v2 2/6] spapr: move lookup of the node into spapr_memory_plug()

2018-06-08 Thread Greg Kurz
On Fri, 8 Jun 2018 14:48:12 +0200 David Hildenbrand wrote: > Let's clean the hotplug handler up by moving lookup of the node into > the function where it is actually being used. > > Signed-off-by: David Hildenbrand > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 12 +--- > 1 file

[Qemu-devel] [PATCH v4 09/10] block/blklogwrites: Use block limits from the backend block configuration

2018-06-08 Thread Ari Sundholm
This is to ensure that writes are aligned properly for logging writes to the virtual block device. This is important because the dm-log-writes log format has a granularity of one sector for both the offset and the size of each write. By using the logical sector size for alignment, the log records

[Qemu-devel] [PATCH v2 01/10] python: futurize -f libfuturize.fixes.fix_print_with_import

2018-06-08 Thread Eduardo Habkost
Change all Python code to use print as a function. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f libfuturize.fixes.fix_print_with_import $py

[Qemu-devel] [PATCH v2 07/10] python: futurize -f lib2to3.fixes.fix_tuple_params

2018-06-08 Thread Eduardo Habkost
Remove implicit tuple parameter unpacking. This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_tuple_params $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH] block/qcow2: save dirty_bitmaps_loaded during reopen

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
This variable was introduced to handle reopens. We need it on the following qcow2_do_open, to don't try load bitmaps again. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index

[Qemu-devel] [PATCH v4 04/10] hw/scsi/scsi-disk: Always apply block configuration to block driver

2018-06-08 Thread Ari Sundholm
This allows the block driver to use the block configuration of the new SCSI device. One use for this information is to set request limits using this information. Signed-off-by: Ari Sundholm --- hw/scsi/scsi-disk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/scsi-disk.c

[Qemu-devel] [PATCH v4 10/10] block/blklogwrites: Use the block device logical sector size when logging writes

2018-06-08 Thread Ari Sundholm
The guest OS may perform writes which are aligned to the logical sector size instead of the physical one, so logging at this granularity records the writes performed on the block device most faithfully. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 47

[Qemu-devel] [PATCH v6 14/49] tests/tcg: enable building for i386

2018-06-08 Thread Alex Bennée
While you can construct a compile command that does work using the x86_64 host compiler that most people use this is flakey. Different distros handle this is different ways so we default to using a known good i386 compiler via docker. Signed-off-by: Alex Bennée Reviewed-by: Philippe

[Qemu-devel] [PATCH v6 10/49] tests/tcg/multiarch: Build fix for linux-test

2018-06-08 Thread Alex Bennée
From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg

2018-06-08 Thread Alex Bennée
Hi, Not a super amount has changed since the last version but review comments and review tags have been added. The new patches at the end enable a .travis.yml run and try and make the image building part of check-tcg -j safe. Essentially the problem is trying to avoid re-building the images

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-08 Thread Cédric Le Goater
On 06/06/2018 03:31 PM, BALATON Zoltan wrote: > Basic emulation of the M41T80 serial (I2C) RTC chip. Only getting time > of day is implemented. Setting time and RTC alarm are not supported. > > Signed-off-by: BALATON Zoltan > --- > MAINTAINERS | 1 + >

[Qemu-devel] [PATCH v6 06/49] docker: extend "cc" command to accept compiler

2018-06-08 Thread Alex Bennée
When calling our cross-compilation images we want to call something other than the default cc. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng --- v2 - use arg.cc default to simplify logic --- tests/docker/docker.py | 4 +++- 1 file changed, 3

[Qemu-devel] [PULL 00/31] target-arm queue

2018-06-08 Thread Peter Maydell
+0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180608 for you to fetch changes up to 113f31c06c6bf16451892b2459d83c9b9c5e9844: sdcard: Disable CMD19/CMD23 for Spec v2 (2018-06-08 13:15:34 +0100

[Qemu-devel] [PATCH v6 11/49] tests/tcg/multiarch: enable additional linux-test tests

2018-06-08 Thread Alex Bennée
Un-comment the remaining tests. I removed the itimer value tests because I'm fairly sure a re-arming timer will always have a different value in it when you grab it. I've also fixed up the clone thread flags as QEMU will only allow a clone to use flags which match glibc. However the test is

[Qemu-devel] [PULL 16/31] hw/digic: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-3-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/char/digic-uart.c | 4 ++-- hw/timer/digic-timer.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 14/31] hw/i2c: Add trace events

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606191801.6331-1-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- Makefile.objs | 1 + hw/i2c/core.c | 25 ++--- hw/i2c/trace-events | 7 +++ 3

[Qemu-devel] [PULL 06/31] aspeed: Add EEPROM I2C devices

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The Aspeed boards have at least one EEPROM to hold the Vital Product Data (VPD). Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery Message-id: 20180530064049.27976-6-...@kaod.org Signed-off-by: Peter Maydell --- hw/arm/aspeed.c | 13 + 1 file

[Qemu-devel] [PULL 03/31] aspeed: add support for the witherspoon-bmc board

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. Add support for their BMC including a couple of I2C devices as found on real HW. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery Message-id: 20180530064049.27976-3-...@kaod.org

[Qemu-devel] [PULL 22/31] target/arm: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-9-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/helper.c

[Qemu-devel] [PATCH v6 24/49] tests/tcg: enable building for AArch64

2018-06-08 Thread Alex Bennée
We only have compilers for the (default) little endian variants. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v4 - update MAINTAINERS --- MAINTAINERS| 1 +

[Qemu-devel] [PULL 30/31] sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180607180641.874-6-f4...@amsat.org Signed-off-by: Peter Maydell --- include/hw/sd/sd.h | 1 + hw/sd/sd.c | 7 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v6 35/49] tests/tcg: enable building for sh4

2018-06-08 Thread Alex Bennée
As before, using Debian SID compilers. While the compiler can be coerced into generating big-endian code it seems the linker can't deal with it so we only enable the building for little endian SH4. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 26/31] sdcard: Update the Configuration Register (SCR) to Spec Version 1.10

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé The initial implementation is based on the Specs v1.10 (see a1bb27b1e98). However the SCR is anouncing the card being v1.01. The new chapters added in version 1.10 are: 4.3.10 Switch function command Switch function command (CMD6) 1 is used to switch or

[Qemu-devel] [PATCH v6 32/49] tests/tcg/alpha: add Alpha specific tests

2018-06-08 Thread Alex Bennée
These tests did use their own crt.o stub however that is a little stone age so we drop crt.S and just statically link to the cross compilers libraries. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v4 -

[Qemu-devel] [PATCH v2 4/6] spapr: introduce machine unplug handler

2018-06-08 Thread David Hildenbrand
We'll be handling unplug of e.g. CPUs and PCDIMMs via the general hotplug handler soon, so let's add that handler function. Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH v6 49/49] .travis.yml: add check-tcg test

2018-06-08 Thread Alex Bennée
Signed-off-by: Alex Bennée --- .travis.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index 814be151f4..f1d2d9edec 100644 --- a/.travis.yml +++ b/.travis.yml @@ -152,3 +152,9 @@ matrix: - TEST_CMD="" before_script: - ./configure

[Qemu-devel] [PATCH v3 2/7] hmp: Allow help on preconfig commands

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow the 'help' command in preconfig state but make it only list the preconfig commands. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- hmp-commands.hx | 1 + monitor.c | 8 +++- 2 files changed, 8

[Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Reenable HMP in preconfig mode; it's pretty easy and anyway I want to do a similar thing for OOB eventually. We'll want to enable more commands in preconfig mode to make it useful at some point. Dave v3 Add Igor's patch to enable most of the same info commands

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread Igor Mammedov
On Thu, 7 Jun 2018 16:00:54 +0200 David Hildenbrand wrote: > On 07.06.2018 15:44, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 13:27:01 +0200 > > David Hildenbrand wrote: > > > >> On 31.05.2018 16:13, Igor Mammedov wrote: > >>> On Wed, 30 May 2018 16:13:32 +0200 > >>> David Hildenbrand

[Qemu-devel] [PATCH v2 00/10] python: futurize --stage1 (Python 3 compatibility)

2018-06-08 Thread Eduardo Habkost
v2 note (v1 was RFC): Except for a trivial change in patch 02/10, this series is the same as the RFC I sent previously. I plan to merge it and include it in a pull request soon. >From the futurize[1] documentation: > This applies fixes that modernize Python 2 code without > changing the

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread David Hildenbrand
>>> if (TYPE_PC_DIMM) { >>> pc_dimm_plug() >>> /* do here additional concrete machine specific things */ >>> } else if (TYPE_VIRTIO_MEM) { >>> virtio_mem_plug() <- do forwarding in there >>> /* and do here additional concrete machine specific things */ >>> } else if (TYPE_CPU) {

[Qemu-devel] [PATCH v2 04/10] python: futurize -f lib2to3.fixes.fix_has_key

2018-06-08 Thread Eduardo Habkost
Change "dict.has_key(key)" to "key in dict" This is necessary for Python 3 compatibility. Done using: $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ sort -u | grep -v README.sh4) $ futurize -w -f lib2to3.fixes.fix_has_key $py Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v6 01/49] configure: add support for --cross-cc-FOO

2018-06-08 Thread Alex Bennée
This allows us to specify cross compilers for our guests. This is useful for building test images/programs. Currently we re-run the compile test for each target. I couldn't think of a way to cache the value for a given arch without getting messier configure code. The cross compiler for the guest

[Qemu-devel] [PATCH v6 17/49] tests/tcg/i386: add runner for test-i386-fprem

2018-06-08 Thread Alex Bennée
The runner needs to compare against a reference run. We also only run this test when SPEED=slow as it takes a while. Signed-off-by: Alex Bennée --- v5 - include test-i386-fprem.ref v5.1 - remove the 69Mb test-i386-fprem.ref - generate test-i386-fprem.ref on developers machine - add

[Qemu-devel] [PATCH v4 05/10] hw/ide/qdev: Always apply block configuration to block driver

2018-06-08 Thread Ari Sundholm
This allows the block driver to use the block configuration of the new IDE device. One use for this information is to set request limits using this information. Signed-off-by: Ari Sundholm --- hw/ide/qdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c

[Qemu-devel] [PATCH v6 26/49] tests/tcg: move MIPS specific tests into subdir

2018-06-08 Thread Alex Bennée
These only need to be built for MIPS guests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/README | 11 --- tests/tcg/mips/README | 7 +++ tests/tcg/{ => mips}/hello-mips.c | 0 3 files

[Qemu-devel] [PATCH v6 02/49] configure: move i386_cc to cross_cc_i386

2018-06-08 Thread Alex Bennée
Also dont assume x86_64 compiler can build i386 binaries. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - drop using system x86_64 compiler for i386 compiles v3 - fix cross_cc_i386 when on i386 v4 - fix merge conflicts - sort

[Qemu-devel] [PATCH v6 48/49] tests/docker: prevent sub-makes re-building debian-sid

2018-06-08 Thread Alex Bennée
This is a bit of a hack but having ensured Debian SID is built at least once in the top-level we don't need to do it over and over again. Perhaps a better solution would be to have docker.py spit out the dependency if a base image is too old? Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v6 04/49] configure: set cross_cc_FOO for host compiler

2018-06-08 Thread Alex Bennée
We can build tests for the host system with the compiler that we have selected. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- configure | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 2d6e095196..b374868eab 100755

[Qemu-devel] [PATCH v6 29/49] tests/tcg: enable building for s390x

2018-06-08 Thread Alex Bennée
This doesn't add any additional tests but enables building the multiarch tests for s390x. Signed-off-by: Alex Bennée Acked-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand --- tests/tcg/s390x/Makefile.include | 2 ++ 1

[Qemu-devel] [PULL 08/31] aspeed: add the pc9552 chips to the witherspoon machine

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The pca9552 LED blinkers on the Witherspoon machine are used for leds but also as GPIOs to control fans and GPUs. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180530064049.27976-8-...@kaod.org

[Qemu-devel] [PATCH v6 03/49] configure: allow user to specify --cross-cc-cflags-foo=

2018-06-08 Thread Alex Bennée
As an individual compiler may be able to support several targets with the appropriate flags we need to expose this to the user as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v3 - fix up the cross-cc v4 - add --help text - sort cross_cc_foo lines --- configure | 10

[Qemu-devel] [PULL 11/31] ftgmac100: fix multicast hash routine

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater Based on the multicast hash calculation of the FTGMAC100 Linux driver. Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180530061711.23673-4-...@kaod.org Signed-off-by: Peter Maydell --- hw/net/ftgmac100.c | 4 ++-- 1 file changed, 2

<    1   2   3   4   5   >