[Qemu-devel] [PULL 12/31] ftgmac100: remove check on runt messages

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater This is a ethernet wire limitation not needed in emulation. It breaks U-Boot n/w stack also. Signed-off-by: Cédric Le Goater Message-id: 20180530061711.23673-5-...@kaod.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/net/ftgmac100.c | 6 -- 1

[Qemu-devel] [PULL 17/31] xilinx-dp: Add trailing '\n' to qemu_log() call

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180606152128.449-4-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/display/xlnx_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/display/xlnx_dp.c

[Qemu-devel] [PATCH v6 22/49] tests/tcg: enable building for ARM

2018-06-08 Thread Alex Bennée
This allows us to use the docker cross compiler image to build these tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v5 - add EXTRA_RUNS for mmap tests --- tests/tcg/arm/Makefile.include | 8 tests/tcg/arm/Makefile.target

[Qemu-devel] [PULL 31/31] sdcard: Disable CMD19/CMD23 for Spec v2

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé These commands got introduced by Spec v3 (see 0c3fb03f7ec and 4481bbc79d2). Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180607180641.874-7-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sd.c | 6 ++ 1 file changed,

[Qemu-devel] [PULL 25/31] target/xtensa: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Max Filippov Message-id: 20180606152128.449-12-f4...@amsat.org Signed-off-by: Peter Maydell --- target/xtensa/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 13/31] hw/arm: Remove the deprecated xlnx-ep108 machine

2018-06-08 Thread Peter Maydell
From: Thomas Huth It has been marked as deprecated since QEMU v2.11, so it is time to remove this now. The xlnx-zcu102 machine is very much the same and can be used as a replacement instead. Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 23/31] target/m68k: Add trailing '\n' to qemu_log() call

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-id: 20180606152128.449-10-f4...@amsat.org Signed-off-by: Peter Maydell --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v6 34/49] tests/tcg: enable building for m68k

2018-06-08 Thread Alex Bennée
As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v5 - add EXTRA_RUNS for mmap tests --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-m68k-cross.docker |

[Qemu-devel] [PATCH v6 12/49] tests/tcg/multiarch: move most output to stdout

2018-06-08 Thread Alex Bennée
The default test run outputs to stdout so it can be re-directed. Errors are still reported to stderr. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v4 - remove space in fprintf () to keep checkpatch happy

[Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow a bunch of the info commands to be used in preconfig. version, chardev, name, uuid,memdev, iothreads Were enabled in QMP in the previous patch from Igor status, hotpluggable_cpus Was enabled in the original allow-preconfig series history is HMP

[Qemu-devel] [PATCH v6 43/49] tests/Makefile.include: add [build|clean|check]-tcg targets

2018-06-08 Thread Alex Bennée
This will ensure all linux-user targets build their guest test programs and ensure check-tcg will run the respective tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - use -include instead of complex macro stuff - also include

[Qemu-devel] [PATCH v6 18/49] tests/tcg/x86_64: add Makefile.target

2018-06-08 Thread Alex Bennée
The sources for x86_64 are shared in the i386 directory which will be included thanks to TARGET_BASE_ARCH. However not all sources build so we need to filter out the ones we can't build in the 64 bit world and those that can't be built for 32 bit. Signed-off-by: Alex Bennée Reviewed-by: Philippe

[Qemu-devel] [PATCH v4 02/10] block: Add blklogwrites

2018-06-08 Thread Ari Sundholm
From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format.

[Qemu-devel] [PATCH v4 06/10] hw/block/virtio-blk: Always apply block configuration to block driver

2018-06-08 Thread Ari Sundholm
This allows the block driver to use the block configuration of the new VirtIO block device. One use for this information is to set request limits using this information. Signed-off-by: Ari Sundholm --- hw/block/virtio-blk.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v6 09/49] tests/tcg: move architecture independent tests into subdir

2018-06-08 Thread Alex Bennée
We will want to build these for all supported guest architectures so lets move them all into one place. We also drop test_path at this point because it needs qemu utils and glib bits which is hard to support for cross compiling. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by:

[Qemu-devel] [PATCH v4 00/10] New block driver: blklogwrites

2018-06-08 Thread Ari Sundholm
This patch series adds a new block driver, blklogwrites, to QEMU. The driver is given two block devices: a raw device backed by an image or a host block device, and a log device, typically backed by a file, on which writes to the raw device are logged. The logging format used is the same as in

[Qemu-devel] [PATCH v6 37/49] tests/tcg: enable building for mips64

2018-06-08 Thread Alex Bennée
As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-mips64-cross.docker | 12

[Qemu-devel] [PATCH v6 08/49] docker: Makefile.include introduce DOCKER_SCRIPT

2018-06-08 Thread Alex Bennée
Define this in one place to make it easy to re-use. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include

[Qemu-devel] [PATCH v6 13/49] tests/tcg: move i386 specific tests into subdir

2018-06-08 Thread Alex Bennée
These only need to be built for i386 guests. This includes a stub tests/tcg/i386/Makfile.target which absorbs some of what was in tests/tcg/Makefile. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard

[Qemu-devel] [PATCH v6 40/49] tests/tcg: enable building for PowerPC

2018-06-08 Thread Alex Bennée
Now we have restored debian-image-powerpc-cross using Debian SID compilers we can build for 32 bit powerpc. Although PPC32 supports a range of pages sizes currently only 4k works so the others are commented out for now. We can also merge the ppc64 support under the base architecture directory to

[Qemu-devel] [PATCH v6 20/49] tests/tcg/i386/test-i386: fix printf format

2018-06-08 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/i386/test-i386.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c index caef4da176..a29b41e764 100644 ---

[Qemu-devel] [PULL 09/31] ftgmac100: compute maximum frame size depending on the protocol

2018-06-08 Thread Peter Maydell
From: Cédric Le Goater The maximum frame size includes the CRC and depends if a VLAN tag is inserted or not. Adjust the frame size limit in the transmit handler using on the FTGMAC100State buffer size and in the receive handler use the packet protocol. Signed-off-by: Cédric Le Goater

[Qemu-devel] [PULL 15/31] hw/sd/milkymist-memcard: Add trailing '\n' to qemu_log() call

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-2-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/milkymist-memcard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v6 41/49] tests/tcg/Makefile: update to be called from Makefile.target

2018-06-08 Thread Alex Bennée
This make is now invoked from each individual target make with the appropriate CC and EXTRA_CFLAGS set for each guest. It then includes additional Makefile.targets from: - tests/tcg/multiarch (always) - tests/tcg/$(TARGET_BASE_ARCH) (if available) - tests/tcg/$(TARGET_NAME) The order is

[Qemu-devel] [PULL 18/31] ppc/pnv: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson Message-id: 20180606152128.449-5-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/ppc/pnv_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv_core.c

[Qemu-devel] [PATCH v2 1/6] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
The node property can always be queried and the value has already been verified in pc_dimm_realize(). Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/ppc/spapr.c

[Qemu-devel] [PATCH v2 2/6] spapr: move lookup of the node into spapr_memory_plug()

2018-06-08 Thread David Hildenbrand
Let's clean the hotplug handler up by moving lookup of the node into the function where it is actually being used. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

[Qemu-devel] [PULL 01/31] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-06-08 Thread Peter Maydell
From: Shannon Zhao While we skip the GIC_INTERNAL irqs, we don't change the register offset accordingly. This will overlap the GICR registers value and leave the last GIC_INTERNAL irq's registers out of update. Fix this by skipping the registers banked by GICR. Also for migration compatibility

[Qemu-devel] [PULL 21/31] stellaris: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180606152128.449-8-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/stellaris.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v2 5/6] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-08 Thread David Hildenbrand
Factor out memory unplug into separate function from spapr_lmb_release(). Then use generic hotplug_handler_unplug() to trigger memory unplug, which will call spapr_machine_device_unplug() -> spapr_memory_unplug() in the end. This way unplug operation is not buried in lmb internals and located in

[Qemu-devel] [PATCH v6 36/49] tests/tcg: enable building for sparc64

2018-06-08 Thread Alex Bennée
As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v5 - add Makefile with EXTRA_RUNS for mmap tests --- tests/docker/Makefile.include| 1 +

[Qemu-devel] [PATCH v3 1/7] hmp: Add flag for preconfig commands

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a flag to command definitions to allow them to be used in preconfig and check it. If users try to use commands that aren't available, tell them to use the exit_preconfig comand we're adding in a few patches. Signed-off-by: Dr. David Alan Gilbert ---

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 02:32:09PM +0200, David Hildenbrand wrote: > > >>> if (TYPE_PC_DIMM) { > >>> pc_dimm_plug() > >>> /* do here additional concrete machine specific things */ > >>> } else if (TYPE_VIRTIO_MEM) { > >>> virtio_mem_plug() <- do forwarding in there > >>> /* and do

Re: [Qemu-devel] [PATCH v2 00/10] python: futurize --stage1 (Python 3 compatibility)

2018-06-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180608122952.2009-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10] python:

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Halil Pasic
On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code now needs to do a hsch (instead of a ssch). The real channel subsystem should figure this out, as we

Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type

2018-06-08 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 11:55:09AM +0800, Peter Xu wrote: > Instead, use a dynamic function to detect which clock we'll use. The > problem is that the old code will let monitor initialization depend on > configure_accelerator() (that's where qtest_enabled() start to take > effect). After this

[Qemu-devel] [PULL 3/5] slirp: fix domainname version availability

2018-06-08 Thread Samuel Thibault
The change missed the 2.12 deadline. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- qapi/net.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/net.json b/qapi/net.json index 32681a1af7..6b7d93cb59 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -161,7

[Qemu-devel] [PULL 2/5] slirp: Add Samuel Thibault's staging tree for slirp

2018-06-08 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Acked-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 41cd3736a9..4c73c16fee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1675,6 +1675,7 @@ S: Maintained F: slirp/ F: net/slirp.c F:

[Qemu-devel] [PULL 0/5] slirp updates

2018-06-08 Thread Samuel Thibault
The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2018-06-01 14:58:53 +0100) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git

[Qemu-devel] [PULL 5/5] slirp: reformat m_inc routine

2018-06-08 Thread Samuel Thibault
From: Prasad J Pandit Coding style changes to the m_inc routine and minor refactoring. Reported-by: ZDI Disclosures Signed-off-by: Prasad J Pandit Signed-off-by: Samuel Thibault --- slirp/mbuf.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 2/4] hw/ppc/spapr_drc: Replace error_setg(_abort) by abort()

2018-06-08 Thread Markus Armbruster
David Gibson writes: > On Fri, Jun 08, 2018 at 12:54:36AM -0300, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 06/08/2018 12:03 AM, David Gibson wrote: >> > On Thu, Jun 07, 2018 at 11:46:43AM -0300, Philippe Mathieu-Daudé wrote: >> >> Use abort() instead of error_setg(_abort), >> >> as

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-08 Thread Markus Armbruster
Peter Xu writes: > On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Previously we cleanup the queues when we got CLOSED event. It was used >> >> we clean up >> >> > to make sure we won't leftover replies/events of a old client to a new >> >> we

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
On 08.06.2018 09:34, Greg Kurz wrote: > On Thu, 7 Jun 2018 18:52:12 +0200 > David Hildenbrand wrote: > >> The node property can always be queried and the value has already been >> verified in pc_dimm_realize(). >> >> Signed-off-by: David Hildenbrand >> --- >> hw/ppc/spapr.c | 9 + >>

Re: [Qemu-devel] [PATCH v1 8/8] s390x: local error handling in hotplug handler functions

2018-06-08 Thread Christian Borntraeger
On 06/08/2018 09:40 AM, David Hildenbrand wrote: > On 08.06.2018 09:27, Christian Borntraeger wrote: >> >> >> On 06/08/2018 09:25 AM, Cornelia Huck wrote: >>> On Thu, 7 Jun 2018 18:52:18 +0200 >>> David Hildenbrand wrote: >>> Let's introduce and use local error variables in the hotplug

Re: [Qemu-devel] [Qemu-block] [RFC PATCH V4] qemu-img: make convert async

2018-06-08 Thread Stefan Hajnoczi
On Thu, Jun 07, 2018 at 01:19:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 07.06.2018 13:10, Stefan Hajnoczi wrote: > > On Fri, Jun 01, 2018 at 07:16:14PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 20.02.2017 17:59, Peter Lieven wrote: > > > > Am 20.02.2017 um 15:50 schrieb Stefan

Re: [Qemu-devel] [PATCH v1 3/8] spapr: move all DIMM checks into spapr_memory_plug

2018-06-08 Thread David Hildenbrand
On 08.06.2018 10:05, Greg Kurz wrote: > On Thu, 7 Jun 2018 18:52:13 +0200 > David Hildenbrand wrote: > >> Let's clean the hotplug handler up by moving everything into >> spapr_memory_plug(). >> >> Signed-off-by: David Hildenbrand >> --- >> hw/ppc/spapr.c | 23 ++- >> 1

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/8] pc: local error handling in hotplug handler functions

2018-06-08 Thread David Hildenbrand
On 08.06.2018 10:04, Thomas Huth wrote: > On 07.06.2018 18:52, David Hildenbrand wrote: >> Let's introduce and use local error variables in the hotplug handler >> functions. > > Why? You don't check local_err in the functions, so I fail to see why > this is needed? If you need this in a later

[Qemu-devel] [PATCH v8 2/6] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-06-08 Thread Wei Wang
The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages counter. For example, the free page optimization clears bits of free pages from the bitmap in an iothread context. This patch makes migration_bitmap_clear_dirty update the bitmap and counter

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Igor Mammedov
On Fri, 8 Jun 2018 10:41:36 +0200 David Hildenbrand wrote: > On 08.06.2018 10:39, Igor Mammedov wrote: > > On Fri, 8 Jun 2018 10:07:31 +0200 > > Thomas Huth wrote: > > > >> On 08.06.2018 09:48, David Hildenbrand wrote: > >>> On 08.06.2018 09:46, Greg Kurz wrote: > On Fri, 8 Jun

[Qemu-devel] [PATCH v3 5/6] ramfb: enable vgabios

2018-06-08 Thread Gerd Hoffmann
--- hw/display/ramfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 258783fe3b..477316a14d 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@ -88,6 +88,7 @@ RAMFBState *ramfb_setup(Error **errp) s = g_new0(RAMFBState, 1); +

[Qemu-devel] [PATCH] hw/arm/smmuv3: Fix translate error handling

2018-06-08 Thread Eric Auger
From: Jia He In case the STE's config is "Bypass" we currently don't set the IOMMUTLBEntry perm flags and the access does not succeed. Also if the config is 0b0xx (Aborted/Reserved), decode_ste and smmuv3_decode_config currently returns -EINVAL and we don't enter the expected code path: we

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-08 Thread Wei Wang
On 06/08/2018 10:17 AM, Peter Xu wrote: On Thu, Jun 07, 2018 at 07:59:22PM +0800, Wei Wang wrote: Not necessarily _need_ to share it, I meant it can be shared using qemu command line. Live migration doesn't happen all the time, and that optimization doesn't run that long, if users want to have

Re: [Qemu-devel] [PATCH v1 8/8] s390x: local error handling in hotplug handler functions

2018-06-08 Thread Christian Borntraeger
On 06/08/2018 09:25 AM, Cornelia Huck wrote: > On Thu, 7 Jun 2018 18:52:18 +0200 > David Hildenbrand wrote: > >> Let's introduce and use local error variables in the hotplug handler >> functions. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio-ccw.c | 11 ---

Re: [Qemu-devel] [PATCH v1 8/8] s390x: local error handling in hotplug handler functions

2018-06-08 Thread David Hildenbrand
On 08.06.2018 09:27, Christian Borntraeger wrote: > > > On 06/08/2018 09:25 AM, Cornelia Huck wrote: >> On Thu, 7 Jun 2018 18:52:18 +0200 >> David Hildenbrand wrote: >> >>> Let's introduce and use local error variables in the hotplug handler >>> functions. >>> >>> Signed-off-by: David

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
On 08.06.2018 09:46, Greg Kurz wrote: > On Fri, 8 Jun 2018 09:42:48 +0200 > David Hildenbrand wrote: > >> On 08.06.2018 09:34, Greg Kurz wrote: >>> On Thu, 7 Jun 2018 18:52:12 +0200 >>> David Hildenbrand wrote: >>> The node property can always be queried and the value has already been

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/8] pc: local error handling in hotplug handler functions

2018-06-08 Thread Thomas Huth
On 07.06.2018 18:52, David Hildenbrand wrote: > Let's introduce and use local error variables in the hotplug handler > functions. Why? You don't check local_err in the functions, so I fail to see why this is needed? If you need this in a later patch, I think this should simply be part of that

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> Peter Xu writes: > >> >> > >> >> > On Tue, Jun 05,

Re: [Qemu-devel] [PATCH v2 2/8] ppc4xx_i2c: Move register state to private struct and remove unimplemented sdata and intr registers

2018-06-08 Thread David Gibson
On Wed, Jun 06, 2018 at 03:31:48PM +0200, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan It's not clear to me why this is preferable to having the registers embedded in the state structure. The latter is pretty standard practice for qemu. > --- > hw/i2c/ppc4xx_i2c.c | 75 >

Re: [Qemu-devel] [PATCH v1 6/8] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-08 Thread Igor Mammedov
On Thu, 7 Jun 2018 18:52:16 +0200 David Hildenbrand wrote: > Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ > unplug memory devices (which a pc-dimm is) later. Perhaps something like following would be better: Factor out memory unplug into separate function from

Re: [Qemu-devel] [PATCH v1 5/8] spapr: introduce machine unplug handler

2018-06-08 Thread Greg Kurz
On Thu, 7 Jun 2018 18:52:15 +0200 David Hildenbrand wrote: > We'll be handling unplug of e.g. CPUs and PCDIMMs via the general > hotplug handler soon, so let's add that handler function. > > Signed-off-by: David Hildenbrand > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 6 ++ > 1

Re: [Qemu-devel] [PULL 0/7] 9p patches 2018-06-07

2018-06-08 Thread Peter Maydell
On 7 June 2018 at 16:21, Greg Kurz wrote: > The following changes since commit 5d328d7d2f1fd4fb160bcfb6e4eb838720274438: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20180605.0' > into staging (2018-06-07 08:59:28 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-08 Thread Dr. David Alan Gilbert
* Andreas Färber (afaer...@suse.de) wrote: > Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: > > For debugging purposes it is very useful to: > > - See the description of the field. This information is already filled > >in but not shown in "qom-list" command. > > No objection on this

Re: [Qemu-devel] [PULL 0/5] slirp updates

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 07:13, Samuel Thibault wrote: > The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2018-06-01 14:58:53 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 0/3] glib: update the min required version

2018-06-08 Thread Peter Maydell
On 6 June 2018 at 18:32, Daniel P. Berrangé wrote: > The previous patch to bump glib to 2.42 hit problems with Peter's build > environment for testing merge: > > https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02557.html > > This posting drops back to 2.40, which allows Ubuntu 14.04

Re: [Qemu-devel] [RFC PATCH v2 7/7] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10

2018-06-08 Thread Peter Maydell
On 7 June 2018 at 19:06, Philippe Mathieu-Daudé wrote: > Due to physical restriction in SPI mode the maximum transfer > speed is limited. All the extensions added after Spec v3 are > simply not supported in SPI mode: You say here that SPI mode doesn't support extensions added "after spec v3"...

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2018-06-08 Thread Thomas Huth
Marking as fixed, according to comment #13 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1636217 Title: qemu-kvm 2.7 does not boot kvm VMs

Re: [Qemu-devel] [OpenRISC] OpenRISC: SMP support for more than 2 cores

2018-06-08 Thread Davidson Francis
On 07-06-2018 12:56, Richard Henderson wrote: On 06/07/2018 06:27 AM, Davidson Francis wrote: Dear all, Currently Qemu supports only 2 cores when SMP enabled for or1k architecure, so I would like to know if there is a quick way to increase the number of cores by changing a few lines of code or

Re: [Qemu-devel] [PATCH v1 8/8] s390x: local error handling in hotplug handler functions

2018-06-08 Thread Cornelia Huck
On Thu, 7 Jun 2018 18:52:18 +0200 David Hildenbrand wrote: > Let's introduce and use local error variables in the hotplug handler > functions. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v1 3/8] spapr: move all DIMM checks into spapr_memory_plug

2018-06-08 Thread Greg Kurz
On Thu, 7 Jun 2018 18:52:13 +0200 David Hildenbrand wrote: > Let's clean the hotplug handler up by moving everything into > spapr_memory_plug(). > > Signed-off-by: David Hildenbrand > --- > hw/ppc/spapr.c | 23 ++- > 1 file changed, 10 insertions(+), 13 deletions(-) > >

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-08 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote: > On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > Previously we cleanup the queues when we got CLOSED event. It was used > > > > we clean up > > > > > to make sure we won't leftover

Re: [Qemu-devel] [PATCH v1 3/8] spapr: move all DIMM checks into spapr_memory_plug

2018-06-08 Thread Igor Mammedov
On Fri, 8 Jun 2018 10:07:59 +0200 David Hildenbrand wrote: > On 08.06.2018 10:05, Greg Kurz wrote: > > On Thu, 7 Jun 2018 18:52:13 +0200 > > David Hildenbrand wrote: > > > >> Let's clean the hotplug handler up by moving everything into > >> spapr_memory_plug(). > >> > >> Signed-off-by:

Re: [Qemu-devel] [RFC v2 04/12] Add vhost-user-backend

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 12:34:15AM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jun 4, 2018 at 11:36 AM, Daniel P. Berrangé > wrote: > > On Fri, Jun 01, 2018 at 06:27:41PM +0200, Marc-André Lureau wrote: > >> Create a vhost-user-backend object that holds a connection to a > >> vhost-user

Re: [Qemu-devel] [PATCH v2 1/8] ppc4xx_i2c: Clean up and improve error logging

2018-06-08 Thread BALATON Zoltan
On Fri, 8 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 12:56:32PM -0300, Philippe Mathieu-Daudé wrote: On 06/06/2018 10:31 AM, BALATON Zoltan wrote: Make it more readable by converting register indexes to decimal (avoids lot of superfluous 0x0) and distinguish errors caused by

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] target/ppc: Allow PIR read in privileged mode

2018-06-08 Thread David Gibson
On Wed, Jun 06, 2018 at 11:19:22AM +0200, Greg Kurz wrote: > On Wed, 6 Jun 2018 10:53:17 +1000 > David Gibson wrote: > > > On Tue, Jun 05, 2018 at 06:46:12PM +0200, Greg Kurz wrote: > > > On Mon, 4 Jun 2018 10:53:22 +1000 > > > David Gibson wrote: > > > > > > > On Mon, May 07, 2018 at

Re: [Qemu-devel] [PATCH v1 6/8] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-08 Thread Igor Mammedov
On Fri, 8 Jun 2018 11:02:23 +0200 David Hildenbrand wrote: > On 08.06.2018 10:56, Igor Mammedov wrote: > > On Thu, 7 Jun 2018 18:52:16 +0200 > > David Hildenbrand wrote: > > > >> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ > >> unplug memory devices (which a

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 13:28:01 +0200 David Hildenbrand wrote: > On 08.06.2018 12:52, Greg Kurz wrote: > > On Fri, 8 Jun 2018 11:24:51 +0200 > > David Hildenbrand wrote: > > > >> +1 for error_abort, even if it takes another line. > > +1 for error_abort > > call shouldn't fail,

Re: [Qemu-devel] [PATCH v3 0/6] ramfb: simple boot framebuffer, no legacy vga

2018-06-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180608112001.14729-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/6] ramfb: simple boot framebuffer, no legacy vga === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH 5/6] block: Add backing passthrough implementations for copy_range

2018-06-08 Thread Fam Zheng
Similar to bdrv_co_block_status_from_backing we add the two passthrough callbacks for copy_range. This will be used by the block driver filters so that they can support copy offloading. Signed-off-by: Fam Zheng --- block/io.c| 24

[Qemu-devel] [PATCH 1/6] file-posix: Fix EINTR handling

2018-06-08 Thread Fam Zheng
EINTR should be checked against errno, not ret. While fixing the bug, collecting the branches with a switch block. Signed-off-by: Fam Zheng --- block/file-posix.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c

[Qemu-devel] [PATCH 0/6] mirror: Use copy offloading

2018-06-08 Thread Fam Zheng
This is the third part of copy offloading work. The first patches are fixes and improvements in preparation for enabling mirror job. The last patch does a similar change to the backup patch: it inserts a blk_aio_copy_range call before the usual bounce buffer code in mirror_iteration. Fam Zheng

Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type

2018-06-08 Thread Markus Armbruster
Peter Xu writes: > On Fri, Jun 08, 2018 at 07:38:11AM +0200, Markus Armbruster wrote: > > [...] > >> > +/* >> > + * This should never be called before configure_accelerator() since >> > + * only until then could we know whether qtest was enabled or not. >> >> Uh, we know it after then, not

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Greg Kurz
On Thu, 7 Jun 2018 18:52:12 +0200 David Hildenbrand wrote: > The node property can always be queried and the value has already been > verified in pc_dimm_realize(). > > Signed-off-by: David Hildenbrand > --- > hw/ppc/spapr.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) >

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/4] pc-bios/s390-ccw/net: Update code for the latest changes in SLOF

2018-06-08 Thread Christian Borntraeger
On 06/07/2018 02:22 PM, Thomas Huth wrote: > The ip_version information now has to be stored in the filename_ip_t > structure, and there is now a common function called tftp_get_error_info() > which can be used to get the error string for a TFTP error code. > We can also get rid of some

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Greg Kurz
On Fri, 8 Jun 2018 09:42:48 +0200 David Hildenbrand wrote: > On 08.06.2018 09:34, Greg Kurz wrote: > > On Thu, 7 Jun 2018 18:52:12 +0200 > > David Hildenbrand wrote: > > > >> The node property can always be queried and the value has already been > >> verified in pc_dimm_realize(). > >> > >>

[Qemu-devel] [PATCH v8 3/6] migration: API to clear bits of guest free pages from the dirty bitmap

2018-06-08 Thread Wei Wang
This patch adds an API to clear bits corresponding to guest free pages from the dirty bitmap. Spilt the free page block if it crosses the QEMU RAMBlock boundary. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin CC: Peter Xu ---

[Qemu-devel] [PATCH v8 0/6] virtio-balloon: free page hint reporting support

2018-06-08 Thread Wei Wang
This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those free pages are not transferred by the

Re: [Qemu-devel] [PATCH v1 6/8] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-08 Thread David Hildenbrand
On 08.06.2018 10:56, Igor Mammedov wrote: > On Thu, 7 Jun 2018 18:52:16 +0200 > David Hildenbrand wrote: > >> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ >> unplug memory devices (which a pc-dimm is) later. > Perhaps something like following would be better: > >

Re: [Qemu-devel] [PATCH v1 7/8] spapr: handle cpu core unplug via hotplug handler chain

2018-06-08 Thread Greg Kurz
On Thu, 7 Jun 2018 18:52:17 +0200 David Hildenbrand wrote: > Let's handle it via hotplug_handler_unplug() to make plug/unplug code > look symmetrical. > > Acked-by: Igor Mammedov > Signed-off-by: David Hildenbrand > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 12 +++- > 1 file

Re: [Qemu-devel] [PATCH v1 6/8] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-08 Thread David Hildenbrand
On 08.06.2018 11:35, Igor Mammedov wrote: > On Fri, 8 Jun 2018 11:02:23 +0200 > David Hildenbrand wrote: > >> On 08.06.2018 10:56, Igor Mammedov wrote: >>> On Thu, 7 Jun 2018 18:52:16 +0200 >>> David Hildenbrand wrote: >>> Let's handle it via hotplug_handler_unplug(). E.g. necessary to

[Qemu-devel] [PATCH] block/qcow2-bitmap: fix free_bitmap_clusters

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
This assert may fail, because bitmap_table is not initialized. Just drop it, as it's obvious, that bitmap_table_load sets bitmap_table parameter only when returning zero. Reported-by: Pavel Butsykin Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 1 - 1 file changed, 1

Re: [Qemu-devel] [PATCH v4] target/ppc: Allow PIR read in privileged mode

2018-06-08 Thread David Gibson
On Fri, Jun 08, 2018 at 11:46:55AM +0200, Greg Kurz wrote: > From: luporl > > According to PowerISA, the PIR register should be readable in privileged > mode also, not only in hypervisor privileged mode. > > PowerISA 3.0 - 4.3.3 Processor Identification Register > > "Read access to the PIR is

Re: [Qemu-devel] [PATCH 00/11] misc: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread Peter Maydell
On 6 June 2018 at 16:21, Philippe Mathieu-Daudé wrote: > Nothing very exciting here. > I sometimes miss to notice some trace events, running with -d unimp,trace... > then using 'grep ^...'. This is only due to a missing '\n' :) > > Philippe Mathieu-Daudé (11): > hw/sd/milkymist-memcard: Add

Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default

2018-06-08 Thread Peter Xu
On Thu, Jun 07, 2018 at 01:40:22PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > There was a regression reported by Eric Auger before with OOB: > > > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > > > The fix is 951702f39c ("monitor: bind dispatch bh to

Re: [Qemu-devel] [PATCH v1 0/8] pc/spapr/s390x: machine hotplug handler cleanups

2018-06-08 Thread David Hildenbrand
On 07.06.2018 18:52, David Hildenbrand wrote: > I'll be messing with machine hotplug handlers of pc/spapr/s390x in the > context of > [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers > > So this is a spin-off of the cleanup patches produced so far. > > David Hildenbrand (8): >

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-08 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote: >> On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote: >> > Peter Xu writes: >> > >> > > Previously we cleanup the queues when we got CLOSED event. It was used >> > >> > we clean up >> > >> >

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Gibson
On Fri, Jun 08, 2018 at 09:46:57AM +0200, Greg Kurz wrote: > On Fri, 8 Jun 2018 09:42:48 +0200 > David Hildenbrand wrote: > > > On 08.06.2018 09:34, Greg Kurz wrote: > > > On Thu, 7 Jun 2018 18:52:12 +0200 > > > David Hildenbrand wrote: > > > > > >> The node property can always be queried

Re: [Qemu-devel] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
On 08.06.2018 10:20, David Gibson wrote: > On Fri, Jun 08, 2018 at 09:46:57AM +0200, Greg Kurz wrote: >> On Fri, 8 Jun 2018 09:42:48 +0200 >> David Hildenbrand wrote: >> >>> On 08.06.2018 09:34, Greg Kurz wrote: On Thu, 7 Jun 2018 18:52:12 +0200 David Hildenbrand wrote: >

Re: [Qemu-devel] [PATCH v1 4/8] spapr: local error handling in hotplug handler functions

2018-06-08 Thread Greg Kurz
On Thu, 7 Jun 2018 18:52:14 +0200 David Hildenbrand wrote: > Let's introduce and use local error variables in the hotplug handler > functions. > > Signed-off-by: David Hildenbrand > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 29 - > 1 file changed, 20

[Qemu-devel] [PATCH v8 4/6] migration/ram.c: add ram save state notifiers

2018-06-08 Thread Wei Wang
This patch adds a ram save state notifier list, and expose RAMState for the notifer callbacks to use. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin CC: Peter Xu --- include/migration/misc.h | 52 +++

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Igor Mammedov
On Fri, 8 Jun 2018 10:07:31 +0200 Thomas Huth wrote: > On 08.06.2018 09:48, David Hildenbrand wrote: > > On 08.06.2018 09:46, Greg Kurz wrote: > >> On Fri, 8 Jun 2018 09:42:48 +0200 > >> David Hildenbrand wrote: > >> > >>> On 08.06.2018 09:34, Greg Kurz wrote: > On Thu, 7 Jun 2018

<    1   2   3   4   5   >