Re: [Qemu-devel] [PATCH v2 01/10] qapi: Add default-variant for flat unions

2018-06-13 Thread Max Reitz
On 2018-06-12 17:25, Markus Armbruster wrote: > Max Reitz writes: > >> This patch allows specifying a discriminator that is an optional member >> of the base struct. In such a case, a default value must be provided >> that is used when no value is given. > > Hmm. Can you explain why you need t

[Qemu-devel] Questions about qemu enabling TCI (tcg/tci.c)

2018-06-13 Thread yt zhang
Dear technicians, Good day. I encountered some difficulties in learning about the TCI part of QEMU. When I use the following configuration command to enable TCI: "configure --enable-tcg-interpreter" Run the command as: "qemu-x86_64 hello-one" (hello-one is my own executable fil

Re: [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups

2018-06-13 Thread David Hildenbrand
On 13.06.2018 15:34, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:44 +0200 > David Hildenbrand wrote: > >> This is another set of cleanups as the result from >> [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers >> And is based on the two series >> [PATCH v1 0/2] memory:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-13 Thread BALATON Zoltan
On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 10:50:59AM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 07:35:28PM +0200, BALATON Zoltan wrote: On Wed, 6 Jun 2018, Philippe Mathieu-Daudé wrote: On 06/06/2018 10:31 AM, BALATON Z

Re: [Qemu-devel] [PATCH 1/2] hw/mips/jazz: create ESP device directly via qdev

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:06, Mark Cave-Ayland wrote: >> >> Heh, those are disgusting indeed. :)  So I guess it would have to stay, >> only MIPS can use the pure MemoryRegion-based approach. > > The only option I can think of is inserting an AddressSpace between the > esp/ledma device and the IOMMU Address

Re: [Qemu-devel] [PATCH] tracing.txt: add missing '-' for trace option

2018-06-13 Thread Yaowei Bai
On Wed, Jun 13, 2018 at 06:27:49AM -0500, Eric Blake wrote: > On 06/12/2018 10:50 PM, Emilio G. Cota wrote: > >On Tue, Jun 12, 2018 at 23:15:49 -0400, Yaowei Bai wrote: > >>Signed-off-by: Yaowei Bai > >>--- > >> docs/devel/tracing.txt | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Thomas Huth
On 13.06.2018 15:54, Paolo Bonzini wrote: > On 13/06/2018 14:53, Thomas Huth wrote: >> On 13.06.2018 14:48, Paolo Bonzini wrote: >>> On 13/06/2018 07:05, Thomas Huth wrote: diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c index 8d915c6..4324034 100644 --- a/tests/vmgenid-test

Re: [Qemu-devel] [PATCH] Remove COPYING.PYTHON

2018-06-13 Thread Stefan Hajnoczi
On Mon, Jun 11, 2018 at 03:01:52PM -0300, Eduardo Habkost wrote: > The COPYING.PYTHON file was added when we added the compatibility > argparse.py module, which was licensed under the Python Software > Foundation License Version 2. > > Now the compatibility argparse.py module was removed, and we a

Re: [Qemu-devel] [RFC PATCH 1/1] nvdimm: let qemu requiring section alignment of pmem resource.

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 11:04:25PM +0800, Haozhong Zhang wrote: > On 06/11/18 19:55, Dan Williams wrote: > > On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi > > wrote: > > > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote: > > >> Nvdimm driver use Memory hot-plug APIs to map it's pmem r

Re: [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug()

2018-06-13 Thread David Hildenbrand
On 13.06.2018 15:10, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:54 +0200 > David Hildenbrand wrote: > >> We'll be factoring out some pc-dimm specific and some memory-device >> checks next. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/i386/pc.c | 2 ++ >> hw/mem/pc-dimm.

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > We can keep daemonizing flow in QEMU as it's now. > > But Eduardo's idea about libvirt created socked + letting QEMU connect to it > > has a merit. It should fix

Re: [Qemu-devel] [PATCH v2] cpu hot-del: leak fix by free the relevant members

2018-06-13 Thread Igor Mammedov
On Wed, 13 Jun 2018 13:15:37 + "liujunjie (A)" wrote: > Hi > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Tuesday, June 12, 2018 9:40 PM > > To: liujunjie (A) > > Cc: pbonz...@redhat.com; r...@twiddle.net; crosthwaite.pe...@gmail.com; > > lin

Re: [Qemu-devel] [PATCH 3/3] block: Remove deprecated -drive option serial

2018-06-13 Thread Markus Armbruster
Kevin Wolf writes: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. > > Signed-off-by: Kevin Wolf > --- > include/hw/block/block.h | 1 - > include/sysemu/

Re: [Qemu-devel] [PATCH v5 09/10] migration: poll the cm event while wait RDMA work request completion

2018-06-13 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function > maybe loop forever. so we should also poll the cm event fd, and when > receive RDMA_CM_EVENT_DISCONNECTED and RDMA_CM_EVENT_DEVICE_REMOVAL, > we consider some error happened. > >

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 03:53 PM, Paolo Bonzini wrote: > On 13/06/2018 15:44, Auger Eric wrote: >>> Queuing this patch. I'm not sure how I missed this, I have actually >>> tested it with SMMU. >> no problem. Strange also I was the only one facing the issue. > > No, I must have blundered it betwe

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 22:05:02 +1000 David Gibson wrote: > On Wed, Jun 13, 2018 at 10:19:15AM +0200, Greg Kurz wrote: > > On Wed, 13 Jun 2018 10:45:06 +1000 > > David Gibson wrote: > > > > > On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > > > > Bits set in the PCR disable feature

Re: [Qemu-devel] [PATCH v5 04/10] migration: implement bi-directional RDMA QIOChannel

2018-06-13 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > From: Lidong Chen > > This patch implements bi-directional RDMA QIOChannel. Because different > threads may access RDMAQIOChannel currently, this patch use RCU to protect it. > > Signed-off-by: Lidong Chen Paolo: Does it make sense the way RCU is

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 01:47:00PM +0800, Peter Xu wrote: > On Mon, Jun 11, 2018 at 05:45:49PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jun 08, 2018 at 10:18:25AM +0200, Markus Armbruster wrote: > > > Stefan Hajnoczi writes: > > > > On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote: > > >

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > > We can keep daemonizing flow in QEMU as it's now. > > > But Eduardo's idea about libvirt cr

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] jobs: minor doc fixups

2018-06-13 Thread Kevin Wolf
Am 07.06.2018 um 01:02 hat John Snow geschrieben: > One is from my manual completion series, > the other is from the recent refactor. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-06-13 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote: > On 2018-03-29 14:51, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Counting from the IVHD ID field to the all-devices entry, we have 28 > > bytes, not 36. > > > > Signed-off-by: Jan Kiszka > > --- > > hw/i386/acpi-build.c | 2 +- >

Re: [Qemu-devel] [PATCH] loader: implement START_SEG_ADDR_RECORD

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 01:46:34PM +0800, Su Hang wrote: > > I do have time, the function mentioned in last comments isn't difficult to > implement, but I wonder how to write corresponding qtest-case for cortex-m3. > You > know, becuase #current# QEMU doesn't surpport the cortex-m3 instruction, I

Re: [Qemu-devel] [PATCH 1/2] stellaris: Stop using armv7m_init()

2018-06-13 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 03:43:27PM +0100, Peter Maydell wrote: > The stellaris board is still using the legacy armv7m_init() function, > which predates conversion of the ARMv7M into a proper QOM container > object. Make the board code directly create the ARMv7M object instead. > > Signed-off-by: P

Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-06-13 Thread Jan Kiszka
On 2018-06-13 16:26, Michael S. Tsirkin wrote: > On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote: >> On 2018-03-29 14:51, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Counting from the IVHD ID field to the all-devices entry, we have 28 >>> bytes, not 36. >>> >>> Signed-off-by: Jan Kis

Re: [Qemu-devel] [PATCH 2/2] hw/arm/armv7m: Remove unused armv7m_init() function

2018-06-13 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 03:43:28PM +0100, Peter Maydell wrote: > Remove the now-unused armv7m_init() function. This was a legacy from > before we properly QOMified ARMv7M, and it has some flaws: > > * it combines work that needs to be done by an SoC object (creating >and initializing the TYPE

Re: [Qemu-devel] [RFC v2 1/3] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2018 at 04:23:40PM +0800, Zihan Yang wrote: > Michael S. Tsirkin 于2018年6月12日周二 下午9:43写道: > > > > On Tue, Jun 12, 2018 at 05:13:22PM +0800, Zihan Yang wrote: > > > The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, > > > add a new type TYPE_PXB_PCIE_HOST to b

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-13 Thread David Hildenbrand
On 13.06.2018 16:07, David Hildenbrand wrote: > On 13.06.2018 15:03, Igor Mammedov wrote: >> On Mon, 11 Jun 2018 14:16:51 +0200 >> David Hildenbrand wrote: >> >>> We already verify when realizing that the memdev property has been >>> set. We have no more accesses to get_memory_region() before the

[Qemu-devel] [PULL 1/1] block: Ignore generated job QAPI files

2018-06-13 Thread Jeff Cody
From: Eric Blake Commit bf42508f introduced new generated files; make sure they don't get accidentally committed from an in-tree build. Signed-off-by: Eric Blake Reviewed-by: Jeff Cody Reviewed-by: Max Reitz Message-id: 20180531212435.165261-1-ebl...@redhat.com Signed-off-by: Jeff Cody ---

[Qemu-devel] [PULL 0/1] Block patches

2018-06-13 Thread Jeff Cody
The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-p

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Farhan Ali
Hi Daniel On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates to the guest all the cipher algorithms that the backend cryptodev can support. But in certain cases where the guest has more perf

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: > Hi Daniel > > On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: > > On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: > > > The virtio-crypto driver currently propagates to the guest > > > all the cipher algorithms that the ba

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Thomas Huth
On 13.06.2018 15:44, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: >> On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: >>> We've got three ways of enabling an accelerator: -machine accel=xyz, >>> -accel xyz and -enable-xyz. For new QEMU use

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 05:11:51PM +0200, Thomas Huth wrote: > On 13.06.2018 15:44, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: > >> On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: > >>> We've got three ways of enabling an accelerator:

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

2018-06-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> When you mix scalar and non-scalar keys, whether you get an "already >> set as scalar" or an "already set as dict" error depends on qdict >> iteration order. Neither message makes much sense. Replace by >> ""Canno

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] block: Remove deprecated -drive geometry options

2018-06-13 Thread Jeff Cody
On Wed, Jun 13, 2018 at 02:34:56PM +0200, Kevin Wolf wrote: > The -drive options cyls, heads, secs and trans were deprecated in > QEMU 2.10. It's time to remove them. > > hd-geo-test tested both the old version with geometry options in -drive > and the new one with -device. Therefore the code usin

Re: [Qemu-devel] [Qemu-block] [PATCH 2/3] block: Remove deprecated -drive option addr

2018-06-13 Thread Jeff Cody
On Wed, Jun 13, 2018 at 02:34:57PM +0200, Kevin Wolf wrote: > The -drive option addr was deprecated in QEMU 2.10. It's time to remove > it. > > Signed-off-by: Kevin Wolf Reviewed-by: Jeff Cody > --- > include/sysemu/blockdev.h | 1 - > blockdev.c| 17 + > devi

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] block: Remove deprecated -drive option serial

2018-06-13 Thread Jeff Cody
On Wed, Jun 13, 2018 at 04:18:17PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > remove it. > > > > Tests need to be updated to set the serial number with -global instead > > of using the -drive option. > > > > Si

Re: [Qemu-devel] [PATCH 01/12] migration: do not wait if no free thread

2018-06-13 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Jun 12, 2018 at 10:42:25AM +0800, Xiao Guangrong wrote: > > > > > > On 06/11/2018 03:39 PM, Peter Xu wrote: > > > On Mon, Jun 04, 2018 at 05:55:09PM +0800, guangrong.x...@gmail.com wrote: > > > > From: Xiao Guangrong > > > > > > > > Instead of put

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Thomas Huth
On 13.06.2018 17:19, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 05:11:51PM +0200, Thomas Huth wrote: >> On 13.06.2018 15:44, Daniel P. Berrangé wrote: >>> On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote:

[Qemu-devel] [PATCH v0 0/2] enable/disable copy-on-read via qmp

2018-06-13 Thread Denis Plotnikov
In some cases there is a need to perform a special access pattern to a disk backend. This may be done by providing disk reading access to external readers. In this case there should be the ability to enable/disable the copy-on-read mode for the disk during VM runtime. By the moment, there is no su

[Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-13 Thread Denis Plotnikov
The command enables/disables copy-on-read mode for VM's disk while VM is running. This is needed when using external disk readers to shape access pattern to the disk backend. Signed-off-by: Denis Plotnikov --- blockdev.c | 38 ++ qapi/block-core.jso

[Qemu-devel] [PATCH v0 1/2] block: check for read-only on copy-on-read setting

2018-06-13 Thread Denis Plotnikov
We should always check whether block device is in the read-only state before enabling copy-on-read. The patch embeds the check in the copy-on-read setter. Signed-off-by: Denis Plotnikov --- block.c | 4 +--- block/io.c| 10 -- block/stream.c| 5 +++--

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-13 Thread Igor Mammedov
On Wed, 13 Jun 2018 12:58:46 +0200 David Hildenbrand wrote: > On 08.06.2018 17:12, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 03:07:53PM +0200, David Hildenbrand wrote: > >> On 08.06.2018 14:55, Michael S. Tsirkin wrote: > >>> On Fri, Jun 08, 2018 at 02:32:09PM +0200, David Hildenb

Re: [Qemu-devel] [PATCH v5] cutils: Provide strchrnul

2018-06-13 Thread Greg Kurz
On Tue, 12 Jun 2018 23:48:31 -0400 Keno Fischer wrote: > strchrnul is a GNU extension and thus unavailable on a number of targets. > In the review for a commit removing strchrnul from 9p, I was asked to > create a qemu_strchrnul helper to factor out this functionality. > Do so, and use it in a nu

Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression

2018-06-13 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > The compressed page is not normal page Is this the right reason? I think we always increment some counter for a page - so what gets incremented for a compressed page? Is the real answer that we do: ram_sav

[Qemu-devel] [PATCH v4 2/2] qapi: remove empty flat union branches and types

2018-06-13 Thread Anton Nefedov
Flat unions may now have uncovered branches, so it is possible to get rid of empty types defined for that purpose only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 52 +++- qapi/crypto.json | 13 + qapi/misc.json |

[Qemu-devel] [PATCH v4 0/2] qapi: allow empty branches in flat unions

2018-06-13 Thread Anton Nefedov
since v3: - patch 2 fixed: BlockdevQcow2Encryption::QCryptoBlockOptionsQCow deletion was a mistake v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg06836.html Anton Nefedov (2): qapi: allow empty branches in flat unions qapi: remove empty flat union branches and types docs

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-13 Thread David Hildenbrand
On 13.06.2018 17:48, Igor Mammedov wrote: > On Wed, 13 Jun 2018 12:58:46 +0200 > David Hildenbrand wrote: > >> On 08.06.2018 17:12, Michael S. Tsirkin wrote: >>> On Fri, Jun 08, 2018 at 03:07:53PM +0200, David Hildenbrand wrote: On 08.06.2018 14:55, Michael S. Tsirkin wrote: > On Fri

[Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-13 Thread Anton Nefedov
It often happens that just a few discriminator values imply extra data in a flat union. Existing checks did not make possible to leave other values uncovered. Such cases had to be worked around by either stating a dummy (empty) type or introducing another (subset) discriminator enumeration. Both o

Re: [Qemu-devel] [PATCH V6 0/7] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-06-13 Thread Igor Mammedov
On Tue, 12 Jun 2018 15:43:58 + Junyan He wrote: > static void file_memory_backend_set_pmem(Object *o, bool value, Error **errp) > { > HostMemoryBackend *backend = MEMORY_BACKEND(o); > HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o); > > if (host_memory_backend_mr_inited(backen

Re: [Qemu-devel] [PATCH] kvm: Delete the slot only when KVM_MEM_READONLY flag is changed

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 04:15, Shannon Zhao wrote: > > > On 2018/6/12 20:17, Paolo Bonzini wrote: >> On 16/05/2018 11:18, Shannon Zhao wrote: >>> According to KVM commit 75d61fbc, it needs to delete the slot before >>> changing the KVM_MEM_READONLY flag. But QEMU commit 235e8982 only check >>> whether KVM_

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jun 13, 2018 at 05:11:51PM +0200, Thomas Huth wrote: >> On 13.06.2018 15:44, Daniel P. Berrangé wrote: >> > On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: >> >> On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: >> >>> We've got thr

Re: [Qemu-devel] [PULL 4/8] bus: do not unref the added child bus on realize

2018-06-13 Thread Paolo Bonzini
On 12/06/2018 12:44, Gerd Hoffmann wrote: > > When the parent bus removes the child property, it takes care of > removing the added reference, in object_finalize_child_property(). > > Signed-off-by: Marc-André Lureau > Message-id: 20180531195119.22021-2-marcandre.lur...@redhat.com > Signed-off-b

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-13 Thread Eric Blake
On 06/13/2018 10:47 AM, Denis Plotnikov wrote: The command enables/disables copy-on-read mode for VM's disk while VM is running. This is needed when using external disk readers to shape access pattern to the disk backend. Signed-off-by: Denis Plotnikov --- Deferring thoughts on the actual de

Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate

2018-06-13 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Sync up xbzrle_cache_miss_prev only after migration iteration goes > forward > > Signed-off-by: Xiao Guangrong Yeh, I think you're right. Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 2

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-13 Thread Konrad Rzeszutek Wilk
On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > > > AMD

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 02:53:04PM +0200, Thomas Huth wrote: > On 13.06.2018 14:48, Paolo Bonzini wrote: > > On 13/06/2018 07:05, Thomas Huth wrote: > >> diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c > >> index 8d915c6..4324034 100644 > >> --- a/tests/vmgenid-test.c > >> +++ b/tests/vmge

Re: [Qemu-devel] [PULL 5/8] object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence

2018-06-13 Thread Paolo Bonzini
On 12/06/2018 12:44, Gerd Hoffmann wrote: > From: Marc-André Lureau > > A link property can be set during creation, with > object_property_add_link() and later with object_property_set_link(). > > add_link() doesn't add a reference to the target object, while > set_link() does. > > Furthemore,

Re: [Qemu-devel] [PULL 6/8] usb-ccid: fix bus leak

2018-06-13 Thread Paolo Bonzini
On 12/06/2018 12:44, Gerd Hoffmann wrote: > From: Marc-André Lureau > > qbus_create_inplace() creates a new reference in realize(), it must be > released in unrealize(). > > Signed-off-by: Marc-André Lureau > Message-id: 20180531195119.22021-4-marcandre.lur...@redhat.com > Signed-off-by: Gerd H

Re: [Qemu-devel] [PATCH 04/12] migration: introduce migration_update_rates

2018-06-13 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > It is used to slightly clean the code up, no logic is changed Actually, there is a slight change; iterations_prev is always updated when previously it was only updated with xbzrle on; still the change makes m

Re: [Qemu-devel] [PATCH 0/4] Fix usb-ccid hotplug regression

2018-06-13 Thread Paolo Bonzini
On 31/05/2018 21:51, Marc-André Lureau wrote: > Hi, > > The following series fixes the usb-ccid hotplug regression introduced > by commit 675f22c6d3b0: the plugged device is not completely removed > on device_del anymore, due to an extra reference added when doing > set_link(). It turns out the me

Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO

2018-06-13 Thread Paolo Bonzini
On 01/06/2018 20:51, Emilio G. Cota wrote: > On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote: >> From: Philippe Mathieu-Daudé >> >> Signed-off-by: Philippe Mathieu-Daudé >> Message-Id: <20180308223946.26784-25-f4...@amsat.org> >> Signed-off-by: Paolo Bonzini >> --- >> default-config

Re: [Qemu-devel] [PULL 4/8] bus: do not unref the added child bus on realize

2018-06-13 Thread Marc-André Lureau
Hi On Wed, Jun 13, 2018 at 6:05 PM, Paolo Bonzini wrote: > On 12/06/2018 12:44, Gerd Hoffmann wrote: >> >> When the parent bus removes the child property, it takes care of >> removing the added reference, in object_finalize_child_property(). >> >> Signed-off-by: Marc-André Lureau >> Message-id:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/7] mac_newworld: add PMU device

2018-06-13 Thread Programmingkid
+static uint64_t mos6522_pmu_read(void *opaque, hwaddr addr, unsigned size) +{ +PMUState *s = opaque; +MOS6522PMUState *mps = &s->mos6522_pmu; +MOS6522State *ms = MOS6522(mps); + +addr = (addr >> 9) & 0xf; This 9 should be replaced with a macro that communicates what this value mea

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 12:09:59PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > > > On F

Re: [Qemu-devel] [PATCH 05/12] migration: show the statistics of compression

2018-06-13 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Then the uses can adjust the parameters based on this info > > Currently, it includes: > pages: amount of pages compressed and transferred to the target VM > busy: amount of count that no free thread to compr

Re: [Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits

2018-06-13 Thread Paolo Bonzini
On 06/06/2018 00:15, Justin Terry (VM) wrote: > Some variations of Linux kernels end up accessing MSR's that the Windows > Hypervisor doesn't implement which causes a GP to be returned to the guest. > This fix registers QEMU for unimplemented MSR access and globally returns 0 on > reads and ignores

Re: [Qemu-devel] [RFC PATCH 1/1] nvdimm: let qemu requiring section alignment of pmem resource.

2018-06-13 Thread Igor Mammedov
On Tue, 12 Jun 2018 23:04:25 +0800 Haozhong Zhang wrote: > On 06/11/18 19:55, Dan Williams wrote: > > On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi > > wrote: > > > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote: > > >> Nvdimm driver use Memory hot-plug APIs to map it's pmem re

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-13 Thread Konrad Rzeszutek Wilk
On Wed, Jun 13, 2018 at 05:21:29PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 12:09:59PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > > > O

Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO

2018-06-13 Thread Philippe Mathieu-Daudé
On 06/13/2018 01:21 PM, Paolo Bonzini wrote: > On 01/06/2018 20:51, Emilio G. Cota wrote: >> On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote: >>> From: Philippe Mathieu-Daudé >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> Message-Id: <20180308223946.26784-25-f4...@amsat.org> >>> Si

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 12:34:21PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 13, 2018 at 05:21:29PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 12:09:59PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > > > > O

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-13 Thread Max Reitz
On 2018-06-13 18:02, Eric Blake wrote: > On 06/13/2018 10:47 AM, Denis Plotnikov wrote: >> The command enables/disables copy-on-read mode for VM's disk while >> VM is running. >> >> This is needed when using external disk readers to shape access pattern >> to the disk backend. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status

2018-06-13 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > On Mon, Jun 11, 2018 at 2:48 PM, Markus Armbruster > wrote: > > > Zhang Chen writes: > > > > > On Thu, Jun 7, 2018 at 8:59 PM, Markus Armbruster > > wrote: > > > > > >> Zhang Chen writes: > > >> > > >> > Libvirt or other high level software can use t

Re: [Qemu-devel] [PATCH v13 3/5] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-06-13 Thread Moger, Babu
> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] > On Behalf Of Babu Moger > Sent: Tuesday, June 12, 2018 2:47 PM > To: Eduardo Habkost > Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com; > r...@twiddle.net; mtosa...@redhat.com

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments

2018-06-13 Thread John Snow
On 06/13/2018 08:30 AM, Peter Maydell wrote: > On 12 June 2018 at 18:30, Richard Henderson > wrote: >> On 06/11/2018 04:17 AM, Peter Maydell wrote: >>> The codebase has a bit of a mix of different multiline >>> comment styles. State a preference for the Linux kernel >>> style: >>> /* >>>

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 05:39:50PM +0100, Daniel P. Berrangé wrote: [...] > > The code that finds the AMD_SSBD and sets the 'ssbd' is: > > > > + if (cpu_has(c, X86_FEATURE_AMD_SSBD)) { > > + set_cpu_cap(c, X86_FEATURE_SSBD); > > + set_cpu_cap(c, X86_FEATURE_MSR_SP

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 02:53:37PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 10:47:45AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > > People have been trying to add qom-get etc for quite a while (I trie

Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name

2018-06-13 Thread Paolo Bonzini
On 12/06/2018 20:25, Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 05:12:58PM +0200, Paolo Bonzini wrote: >> On 12/06/2018 17:01, Eduardo Habkost wrote: > > Remove OSPKE from the feature name array so users don't try to > configure it manually. > > Signed-off-by: Eduardo Habk

Re: [Qemu-devel] [PATCH v5 03/10] migration: avoid concurrent invoke channel_close by different threads

2018-06-13 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 11:28:02PM +0800, Lidong Chen wrote: > The channel_close maybe invoked by different threads. For example, source > qemu invokes qemu_fclose in main thread, migration thread and return path > thread. Destination qemu invokes qemu_fclose in main thread, listen thread > and COL

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 03:23:09PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > > > We can keep dae

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-13 Thread Julia Suvorova via Qemu-devel
On 13.06.2018 17:05, Stefan Hajnoczi wrote: On Tue, Jun 12, 2018 at 11:46:32PM +0300, Julia Suvorova wrote: ARMv6-M supports 6 Thumb2 instructions. This patch checks for these instructions and allows their execution. Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit. This pa

Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 07:01:23PM +0200, Paolo Bonzini wrote: > On 12/06/2018 20:25, Eduardo Habkost wrote: > > On Tue, Jun 12, 2018 at 05:12:58PM +0200, Paolo Bonzini wrote: > >> On 12/06/2018 17:01, Eduardo Habkost wrote: > > > > Remove OSPKE from the feature name array so users don't tr

Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO

2018-06-13 Thread Philippe Mathieu-Daudé
On 06/13/2018 01:35 PM, Philippe Mathieu-Daudé wrote: > On 06/13/2018 01:21 PM, Paolo Bonzini wrote: >> On 01/06/2018 20:51, Emilio G. Cota wrote: >>> On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé >>>

Re: [Qemu-devel] [PATCH v13 3/5] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 04:52:18PM +, Moger, Babu wrote: [...] > > What do you think our options are here? > > Should we drop automatic topoext completely and move forward? > What are your thoughts? Let's drop automatic topoext by now, and see if we find solutions later. I don't want to hold

Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 19:16, Eduardo Habkost wrote: >> Second, for user-mode emulation it makes sense to allow flipping of >> OSPKE and OSXSAVE, because that corresponds to different behaviors of >> the underlying kernels. There have been bugs in fact with programs that >> incorrectly tested XSAVE instead

[Qemu-devel] [PATCH] sdl2: restore window dimensions by resize

2018-06-13 Thread Amadeusz Sławiński
instead of destroying and recreating window, fixes segfault caused by handle_keyup trying to access no more existing window when using Ctrl-Alt-U to restore window "un-scaled" dimensions Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x77f92b80 (

[Qemu-devel] [PATCH 3/3] Revert "bus: do not unref the added child bus on realize"

2018-06-13 Thread Marc-André Lureau
This is wrong. object_finalize_child_property()'s unref balances the ref in object_property_add_child(). qbus_realize's unref balances the ref that was initially placed by object_new/object_initialize. This reverts commit f3d58385a6d3d82f65db602c5506e2d3d8c82394. Reported-by: Paolo Bonzini Sig

[Qemu-devel] [PATCH 1/3] Revert "usb-ccid: fix bus leak"

2018-06-13 Thread Marc-André Lureau
The bus is not owned by the device. This reverts commit 410a096adf991ce437d4d7dabc59b6557e6d488d. Signed-off-by: Marc-André Lureau --- hw/usb/dev-smartcard-reader.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index f7c91230d5.

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Halil Pasic
On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: Hi Daniel On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates to the guest a

[Qemu-devel] [PATCH 2/3] Revert "usb: release the created buses"

2018-06-13 Thread Marc-André Lureau
The USB device don't hold the bus. There is no ASAN related reports anymore. This reverts commit cd7bc87868d534f95e928cad98e2a52df7695771. Signed-off-by: Marc-André Lureau --- hw/usb/dev-storage.c | 16 hw/usb/dev-uas.c | 2 -- 2 files changed, 18 deletions(-) diff --git

[Qemu-devel] [PATCH 0/3] Fix usb-ccid hotplug regression follow-up

2018-06-13 Thread Marc-André Lureau
Hi, The series "[Qemu-devel] [PATCH 0/4] Fix usb-ccid hotplug regression" made wrong assumptions about bus ref'counting pointed out by Paolo after it was merged. This series reverts the 2 offending patches, as well as a older related patch that is now clearly wrong as well. Marc-André Lureau (3)

[Qemu-devel] [PATCH v3 2/8] qapi: add unmap to BlockDeviceStats

2018-06-13 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- qapi/block-core.json | 29 +++-- include/block/accounting.h | 1 + block/qapi.c | 6 ++ 3 files changed, 30 insertion

[Qemu-devel] [PATCH v3 4/8] scsi: store unmap offset and nb_sectors in request struct

2018-06-13 Thread Anton Nefedov
it allows to report it in the error handler Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c inde

[Qemu-devel] [PATCH v3 5/8] scsi: move unmap error checking to the complete callback

2018-06-13 Thread Anton Nefedov
This will help to account the operation in the following commit. The difference is that we don't call scsi_disk_req_check_error() before the 1st discard iteration anymore. That function also checks if the request is cancelled, however it shouldn't get canceled until it yields in blk_aio() function

[Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields

2018-06-13 Thread Anton Nefedov
Make the stat fields definition slightly more readable. Also reorder total_time_ns stats read-write-flush as done elsewhere. Cosmetic change only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) dif

[Qemu-devel] [PATCH v3 0/8] discard blockstats

2018-06-13 Thread Anton Nefedov
new in v3: - based on qapi series: (http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg03638.html) - qapi 'Since' clauses changed 2.12 -> 3.0 (RB tags not stripped) - patch 3 rebase: ide_issue_trim_cb invalid path has changed, so block_acct_invalid() is moved to ide_

[Qemu-devel] [PATCH v3 6/8] scsi: account unmap operations

2018-06-13 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 0b68a8d..ed72662 100644 --- a/hw/scsi/scsi-disk.

[Qemu-devel] [PATCH v3 3/8] ide: account UNMAP (TRIM) operations

2018-06-13 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- hw/ide/core.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c62efc..352429b 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -440,6 +440,14 @@ static void ide_issue_trim_cb(void *opaque, int ret) TrimA

[Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations

2018-06-13 Thread Anton Nefedov
This will help to identify how many of the user-issued discard operations (accounted on a device level) have actually suceeded down on the host file (even though the numbers will not be exactly the same if non-raw format driver is used (e.g. qcow2 sending metadata discards)). Signed-off-by: Anton

[Qemu-devel] [PATCH v3 8/8] qapi: query-blockstat: add driver specific file-posix stats

2018-06-13 Thread Anton Nefedov
A block driver can provide a callback to report driver-specific statistics. file-posix driver now reports discard statistics Signed-off-by: Anton Nefedov --- qapi/block-core.json | 39 +++ include/block/block.h | 1 + include/block/block_int.h | 1

<    1   2   3   4   5   >