[Qemu-devel] [PATCH v5 06/46] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h"

2018-06-25 Thread Philippe Mathieu-Daudé
These files don't use anything exposed by "qemu/cutils.h", simplify preprocessing including directly "qemu/units.h". Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson (ppc parts) --- hw/arm/msf2-soc.c | 2 +- hw/arm/msf2-som.c | 2 +- hw/core/machine.c | 2 +- hw/display/sm501.c

[Qemu-devel] [PATCH v5 10/46] hw/smbios: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH v5 23/46] hw/tricore: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Bastian Koppelmann --- hw/tricore/tricore_testboard.c | 13 +++-- 1 file

[Qemu-devel] [PATCH v5 19/46] hw/s390x: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Cornelia Huck --- hw/s390x/s390-skeys.c| 3 ++-

[Qemu-devel] [PATCH v5 26/46] hw/cris: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/axis_dev88.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Vasily Gorbik
This change has been done on purpose. Uncompressed image is not going to be bootable any more. In future the decompressor phase would get more function (early memory detection as an example) and there is no chance to duplicate that code in uncompressed image as well (to keep it bootable on its

[Qemu-devel] [PATCH v5 46/46] bsd-user: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 19/46] hw/s390x: Use the IEC binary prefix definitions

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 15:16:15 +0200 David Hildenbrand wrote: > On 25.06.2018 15:07, Cornelia Huck wrote: > > On Mon, 25 Jun 2018 09:42:11 -0300 > > Philippe Mathieu-Daudé wrote: > > > >> It eases code review, unit is explicit. > >> > >> Patch generated using: > >> > >> $ git grep -E

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 14:30, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 06/06/2018 12:02 PM, Philippe Mathieu-Daudé wrote: >> On 06/06/2018 11:53 AM, Thomas Huth wrote: >>> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote: These COMs are hard to find, and the companie dropped the support

[Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup

2018-06-25 Thread Alex Bennée
As we don't always take the normal exit path when running a guest we can skip the normal exit destructors where gcov normally dumps it's info. The GCC manual suggests long running programs use __gcov_dump() to flush out the coverage state periodically so we use that here. Signed-off-by: Alex

[Qemu-devel] [PATCH v1 02/10] travis: test out-of-tree builds

2018-06-25 Thread Alex Bennée
From: Philippe Mathieu-Daudé Force one config to build 'out-of-tree' (object files and executables are created in a tree outside the project source code). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- .travis.yml | 8 +++- 1 file changed, 7 insertions(+), 1

[Qemu-devel] [PATCH v1 00/10] Travis updates and code coverage tweaks

2018-06-25 Thread Alex Bennée
The main changes since last weeks RFC are that I ended up doing more furtling than I wanted to make the Travis coverage report sane. Rather than mess around with .travis.yml I pushed this all into a script. I also got to the bottom of the missing coverage reports under linux-user. It seems as

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > > > > On

[Qemu-devel] [PATCH v3 3/9] s390x/tod: factor out TOD into separate device

2018-06-25 Thread David Hildenbrand
Let's treat this like a separate device. TCG will have to store the actual state/time later on. Include cpu-qom.h in kvm_s390x.h (due to S390CPU) to compile tod-kvm.c. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- hw/s390x/Makefile.objs | 3 + hw/s390x/s390-virtio-ccw.c

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:49 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 10:36:33 +0200 > Vasily Gorbik wrote: > >> This change has been done on purpose. Uncompressed image is not going >> to be bootable any more. In future the decompressor phase would get >> more function (early memory detection

[Qemu-devel] [PATCH v5 05/46] hw: Use IEC binary prefix definitions from "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Code change produced with: $ git ls-files | egrep '\.[ch]$' | \ xargs sed -i -e 's/\(\W[KMGTPE]\)_BYTE/\1iB/g' Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson (ppc parts) --- include/qemu/cutils.h | 8 +--- hw/arm/msf2-soc.c | 4 ++--

[Qemu-devel] [PATCH v5 11/46] hw/xen: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alan Robinson --- hw/block/xen_disk.c| 3 ++-

[Qemu-devel] [PATCH v5 03/46] x86/cpu: Use definitions from "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Eduardo Habkost --- target/i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1e69e68f25..a5c9200788 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -18,6 +18,7

[Qemu-devel] [PATCH v5 24/46] hw/microblaze: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/microblaze/petalogix_ml605_mmu.c | 7 ---

[Qemu-devel] [PATCH v5 35/46] hw/usb: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/ccid-card-passthru.c | 5 +++-- hw/usb/combined-packet.c | 3 ++-

Re: [Qemu-devel] [PATCH v3 11/49] qapi/commands: add #if conditions to commands

2018-06-25 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Wrap generated code with #if/#endif using an 'ifcontext' on >> QAPIGenCSnippet objects. >> >> Signed-off-by: Marc-André Lureau >> --- >> scripts/qapi/commands.py | 19 ++- >> tests/test-qmp-cmds.c| 4 ++-- >> 2

[Qemu-devel] [PATCH v5 29/46] hw/mips/r4k: Constify params_size

2018-06-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index e5cf8ed1a3..fc38b4bf99 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -79,8 +79,9 @@ typedef struct

[Qemu-devel] [PATCH v5 37/46] hw/vfio: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/pci-quirks.c | 9 + hw/vfio/pci.c| 3 ++- 2 files changed, 7

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: Convert .bdrv_truncate callback to coroutine_fn

2018-06-25 Thread Max Reitz
On 2018-06-25 11:51, Kevin Wolf wrote: > Am 25.06.2018 um 11:02 hat Stefan Hajnoczi geschrieben: >> On Thu, Jun 21, 2018 at 07:06:56PM +0200, Kevin Wolf wrote: >>> bdrv_truncate() is an operation that can block (even for a quite long >>> time, depending on the PreallocMode) in I/O paths that

Re: [Qemu-devel] [PATCH v3 01/13] 9p: linux: Fix a couple Linux assumptions

2018-06-25 Thread Greg Kurz
On Sat, 16 Jun 2018 20:56:45 -0400 Keno Fischer wrote: > From: Keno Fischer > > - Guard Linux only headers. > - Add qemu/statfs.h header to abstract over the which >headers are needed for struct statfs I've suggested in some other mail that you introduce a QEMU type for struct statfs

Re: [Qemu-devel] [PATCH v3 09/16] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf

2018-06-25 Thread Thomas Huth
On 24.06.2018 06:06, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/arm/omap.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h > index 39abba753d..e7fbd340f3 100644 >

[Qemu-devel] [PATCH v5 21/46] hw/xtensa: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Max Filippov --- hw/xtensa/xtfpga.c | 9

[Qemu-devel] [PATCH v5 30/46] hw/mips: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis ---

[Qemu-devel] [PATCH v5 17/46] hw/m68k: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/m68k/mcf5208.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH v2 07/14] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 03:08 AM, Thomas Huth wrote: > On 22.06.2018 22:10, Philippe Mathieu-Daudé wrote: >> On 06/22/2018 04:38 PM, Thomas Huth wrote: >>> On 22.06.2018 15:40, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/omap_i2c.c | 20

[Qemu-devel] [PATCH v5 38/46] hw/virtio: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/virtio/virtio-net.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO

2018-06-25 Thread Gerd Hoffmann
Currently, the HDA device tries to sync itself with the QEMU audio backend by waiting for the guest driver to handle buffer completion interrupts. This causes the backend to often read too much data from the device, as well as running out of data whenever the guest takes too long to handle the

Re: [Qemu-devel] [PATCH v3 04/13] 9p: darwin: Handle struct dirent differences

2018-06-25 Thread Greg Kurz
On Sat, 16 Jun 2018 20:56:48 -0400 Keno Fischer wrote: > On darwin d_seekoff exists, but is optional and does not seem to > be commonly used by file systems. Use `telldir` instead to obtain > the seek offset. > Thinking again about this one, I guess we also need our own type for dirent and

Re: [Qemu-devel] [PATCH v3 03/13] 9p: darwin: Handle struct stat(fs) differences

2018-06-25 Thread Greg Kurz
On Sat, 16 Jun 2018 20:56:47 -0400 Keno Fischer wrote: > Signed-off-by: Keno Fischer > --- The problem with 'struct stat' and 'struct statfs' is that they're not only system types, but also part of the FileOperations API in fsdev/file-op-9p.h: int (*lstat)(FsContext *, V9fsPath *, struct

[Qemu-devel] Some issues of hotpluging memory and cpus

2018-06-25 Thread linzhecheng
Hi, all, I had some problems when doing memory hot plugging. After a lot of tests, I was able to stably reproduce the following issues with Windows 2012 R2: 1. If I hot-plug the memory immediately after hot-plugging the CPUs, these memory devices will not be detected by windows OS because I

Re: [Qemu-devel] [PATCH v2 7/7] xlnx-zynqmp: Improve GIC wiring and MMIO mapping

2018-06-25 Thread Peter Maydell
On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > This commit improve the way the GIC is realized and connected in the > ZynqMP SoC. The security extensions are enabled only if requested in the > machine state. The same goes for the virtualization extensions. > > All the GIC to APU CPU(s)

[Qemu-devel] [PATCH v1 09/10] linux-user: introduce preexit_cleanup

2018-06-25 Thread Alex Bennée
To avoid repeating ourselves move our preexit clean-up code into a helper function. I figured the continuing effort to split of the syscalls made it worthwhile creating a new file for it now. Signed-off-by: Alex Bennée --- linux-user/Makefile.objs | 2 +- linux-user/exit.c| 28

[Qemu-devel] [PATCH v3 8/9] s390x/tcg: rearm the CKC timer during migration

2018-06-25 Thread David Hildenbrand
If the CPU data is migrated after the TOD clock, the CKC timer of a CPU is not rearmed. Let's rearm it when loading the CPU state. Introduce tcg-stub.c just like kvm-stub.c for tcg specific stubs. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/Makefile.objs | 1 +

Re: [Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 05:39, Robert Hoo wrote: > Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as > SPEC_CTRL. > > Signed-off-by: Robert Hoo > --- > target/i386/cpu.c | 2 +- > target/i386/cpu.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git

[Qemu-devel] [PATCH v5 27/46] hw/lm32: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- hw/lm32/lm32_boards.c | 13 +++-- hw/lm32/milkymist.c

[Qemu-devel] [PATCH v5 12/46] hw/tpm: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- include/hw/acpi/tpm.h | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH v5 41/46] hw/ppc: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/sam460ex.c | 2 +- target/ppc/mmu_helper.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PULL 4/6] audio/hda: detect output buffer overruns

2018-06-25 Thread Gerd Hoffmann
If some event caused some larger playback hickup the fine-grained timer adjust isn't able to recover. Use a buffer overruns as indicator for that. Reset timer adjust logic in case we detected one. Signed-off-by: Gerd Hoffmann Message-id: 20180622111200.30561-5-kra...@redhat.com ---

Re: [Qemu-devel] [PATCH v5 19/46] hw/s390x: Use the IEC binary prefix definitions

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 09:42:11 -0300 Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé >

[Qemu-devel] [PATCH v2] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Joel Stanley
This adds Cedric as the maintainer, with Andrew and I as reviewers, for the ASPEED boards and the peripherals we have developed. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Andrew Jeffery Acked-by: Cédric Le Goater Signed-off-by: Joel Stanley -- v2: fix includes path --- MAINTAINERS |

Re: [Qemu-devel] [PATCH v3 19/49] qapi: factor out check_known_keys()

2018-06-25 Thread Markus Armbruster
Marc-André Lureau writes: > The following patches are going to need similar checks from various > code path. This refactoring will report all conflicting keys (instead > of the first one encountered). > > Modify unknown-expr-key to check plural form. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH] MAINTAINERS: update target-mips maintainers

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 14:14, Philippe Mathieu-Daudé wrote: > Hi Peter, > I suggest to apply this patch as a build fix to avoid more email bounces: > > ** Message not delivered ** > > Your message couldn't be delivered to yongbok@mips.com because the > remote server is misconfigured. See

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 15:00, Joel Stanley wrote: > This adds Cedric as the maintainer, with Andrew and I as reviewers, for > the ASPEED boards and the peripherals we have developed. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Andrew Jeffery > Acked-by: Cédric Le Goater > Signed-off-by:

[Qemu-devel] [Bug 1778350] Re: Android-x86 4.4-r5 won't boot on QEMU since v2.11.0-rc2

2018-06-25 Thread navicrej
After 'git bisect' -ing it I found the commit that is responsible for this: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fa99d2519cbf71f871e46871df12cb446dc1c3e -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH v1 01/10] travis: do not waste time cloning unused submodules

2018-06-25 Thread Alex Bennée
From: Philippe Mathieu-Daudé Builds only require: - dtc - keycodemapdb - capstone Signed-off-by: Philippe Mathieu-Daudé [AJB: drop wget cache] Signed-off-by: Alex Bennée --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index

[Qemu-devel] [PATCH v1 03/10] build-system: remove per-test GCOV reporting

2018-06-25 Thread Alex Bennée
I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex

[Qemu-devel] [PATCH v1 08/10] build-system: add coverage-report target

2018-06-25 Thread Alex Bennée
This will build a coverage report under the current directory in reports/coverage. At the users option a report can be generated by directly invoking something like: make foo/bar/coverage-report.html Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 07:54:00PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > This was in fact one release longer than our deprecation policy says. > > > Are we serious about the

[Qemu-devel] [PATCH v1 07/10] build-system: add clean-coverage target

2018-06-25 Thread Alex Bennée
This can be used to remove any stale coverage data before any particular test run. This is useful for analysing individual tests. Signed-off-by: Alex Bennée --- Makefile | 11 +++ docs/devel/testing.rst | 11 --- 2 files changed, 19 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v1 06/10] travis: add gcovr summary for GCOV build

2018-06-25 Thread Alex Bennée
This gives a more useful summary, sorted by descending % coverage, after the tests have run. The final numbers will give an idea if our coverage is getting better or worse. To keep the width sane we need to post process the file that the old gcovr tool generates. This is done with a mix of sed,

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > > Am 22.06.2018 um 15:36 hat

[Qemu-devel] [PATCH v3 0/9] s390x: TOD refactoring + TCG CPU hotplug support

2018-06-25 Thread David Hildenbrand
The TOD in TCG is not handled correctly: - each CPU has its own TOD based on CPU creation time vs. a system TOD - TOD is not migrated - TOD timer is not restarted during migration - CKC interrupts/TOD timer is not cleared when resetting the CKC This (and a cpu creation problem for single threaded

[Qemu-devel] [PATCH v3 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts

2018-06-25 Thread David Hildenbrand
Let's stop the timer and delete any pending CKC IRQ before doing anything else. While at it, add a comment while the check for ckc == -1ULL is needed. Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PATCH v3 1/9] s390x/tcg: avoid overflows in time2tod/tod2time

2018-06-25 Thread David Hildenbrand
Big values for the TOD/ns clock can result in some overflows that can be avoided. Not all overflows can be handled however, as the conversion either multiplies by 4.096 or divided by 4.096. Apply the trick used in the Linux kernel in arch/s390/include/asm/timex.h for tod_to_ns() and use the same

[Qemu-devel] [PATCH v3 5/9] s390x/tcg: properly implement the TOD

2018-06-25 Thread David Hildenbrand
Right now, each CPU has its own TOD. Especially, the TOD will differ based on creation time of a CPU - e.g. when hotplugging a CPU the times will differ quite a lot, resulting in stall warnings in the guest. Let's use a single TOD by implementing our new TOD device. Prepare it for TOD-clock epoch

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Andrew Jeffery
On Mon, 25 Jun 2018, at 20:43, Philippe Mathieu-Daudé wrote: > Hi Joel, > > On 06/25/2018 08:07 AM, Joel Stanley wrote: > > This adds Cedric as the maintainer, with Andrew and I as reviewers, for > > the ASPEED boards and the peripherals we use. > > Good idea, this should speed up ASPEED

[Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines checked Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v5 01/46] include: Add IEC binary prefixes in "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Loosely based on 076b35b5a56. Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/units.h | 20 1 file changed, 20 insertions(+) create mode 100644 include/qemu/units.h diff --git a/include/qemu/units.h b/include/qemu/units.h new file mode

[Qemu-devel] [PATCH v5 02/46] vdi: Use definitions from "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil --- block/vdi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 1d8ed67dbf..6555cffb88 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -50,6 +50,7 @@ */ #include

[Qemu-devel] [PATCH v5 16/46] hw/riscv: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark --- hw/riscv/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PATCH v5 36/46] hw/sd: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c| 4 ++-- hw/sd/sdhci.c | 6 +++--- 2 files changed, 5 insertions(+), 5

[Qemu-devel] [PATCH v5 44/46] tests/crypto: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- tests/benchmark-crypto-cipher.c | 6 +++--- tests/benchmark-crypto-hash.c | 5 +++--

Re: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup

2018-06-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 06/25/2018 08:19 AM, Alex Bennée wrote: >> As we don't always take the normal exit path when running a guest we >> can skip the normal exit destructors where gcov normally dumps it's >> info. The GCC manual suggests long running programs use

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Guenter Roeck
On 06/25/2018 05:26 AM, Christian Borntraeger wrote: On 06/25/2018 10:49 AM, Cornelia Huck wrote: On Mon, 25 Jun 2018 10:36:33 +0200 Vasily Gorbik wrote: This change has been done on purpose. Uncompressed image is not going to be bootable any more. In future the decompressor phase would

[Qemu-devel] [PULL 6/6] audio: Convert use of atoi to qemu_strtoi

2018-06-25 Thread Gerd Hoffmann
From: Nia Alarie If qemu_strtoi indicates an error, return the default value. Signed-off-by: Nia Alarie Message-Id: <20180316144047.30904-1-nia.ala...@gmail.com> Signed-off-by: Gerd Hoffmann --- audio/audio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/audio/audio.c

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-25 Thread Max Reitz
On 2018-03-19 09:07, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > If it appropriate for 2.12, let's push it. If not - then for 2.13. > > > v2: - squash 02 (indentation fix) to 01 > - drop comment from qcow2_check_metadata_overlap() > - set

Re: [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 10:31:52 +0200 Thomas Huth wrote: > On 15.06.2018 11:49, Thomas Huth wrote: > > The rom_ptr() function allows direct access to the ROM blobs that we > > load during startup. However, there are currently no checks for the > > size of the accesses, so it's currently possible to

Re: [Qemu-devel] [PATCH 0/3] aspeed/smc: small fixes

2018-06-25 Thread Peter Maydell
On 12 June 2018 at 07:57, Cédric Le Goater wrote: > Hello, > > Here is a short series of cleanups and fixes for issues in the Aspeed > SMC controller model discovered when experimenting with the MMIO exec > feature and also from tests under a QEMU PowerNV machine. > > Indeed, the OPAL/skiboot

Re: [Qemu-devel] [PATCH v4] xilinx_spips: Make dma transactions as per dma_burst_size

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 10:47, Sai Pavan Boddu wrote: > From: Sai Pavan Boddu > > Qspi dma has a burst length of 64 bytes, So limit the transactions w.r.t > dma-burst-size property. > > Signed-off-by: Sai Pavan Boddu > Reviewed-by: Edgar E. Iglesias > --- > Changes for V2: >Remove dynamic

[Qemu-devel] [RFC v2 1/2] Add bpf support to qemu

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran This commit adds the libbpf library provided by Linux to Qemu. Signed-off-by: Sameeh Jubran --- MAINTAINERS |6 + configure | 46 + include/standard-headers/linux/libbpf.h | 284

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-25 Thread Markus Armbruster
Markus Armbruster writes: > Andreas Färber writes: > >> Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: >>> * Andreas Färber (afaer...@suse.de) wrote: Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: > For debugging purposes it is very useful to: > - See the description

Re: [Qemu-devel] [PATCH v1 05/10] docker: add gcovr to travis image

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 08:19 AM, Alex Bennée wrote: > Useful for debugging if nothing else as the gcovr on the Travis images > are a little old. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/travis.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 05:39, Robert Hoo wrote: > IA32_PRED_CMD MSR gives software a way to issue commands that affect the state > of indirect branch predictors. Enumerated by CPUID.(EAX=7H,ECX=0):EDX[26]. > IA32_ARCH_CAPABILITIES MSR enumerates architectural features of RDCL_NO and > IBRS_ALL. Enumerated

[Qemu-devel] [PATCH v5 15/46] hw/misc: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/auxbus.c | 3 ++- hw/misc/edu.c| 3 ++- 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v5 07/46] hw/ivshmem: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/misc/ivshmem.c | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH v5 32/46] hw/ppc: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson --- hw/ppc/mac.h | 3 ++- include/hw/ppc/spapr.h | 5

[Qemu-devel] [PATCH v5 39/46] hw/rdma: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/vmw/pvrdma.h | 3 ++- 1

[Qemu-devel] [PATCH v5 40/46] cutils: Do not include "qemu/units.h" directly

2018-06-25 Thread Philippe Mathieu-Daudé
All files using "qemu/units.h" definitions already include it directly, we can now remove it from "qemu/cutils.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum --- include/qemu/cutils.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/cutils.h

[Qemu-devel] [PULL 0/6] Audio 20180625 patches

2018-06-25 Thread Gerd Hoffmann
The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-20180625-pull-request

[Qemu-devel] [PATCH v5 45/46] linux-user: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- linux-user/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 5/7] intc/arm_gic: Add virtualization extensions logic

2018-06-25 Thread Peter Maydell
On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > This commit adds the actual implementation of the GICv2 virtualization > extensions logic. > > For the vCPU interfaces, most of the existing CPU interface code is > reused. Calls to macros or functions modifying the distributor state are >

Re: [Qemu-devel] [PATCH v2 4/7] intc/arm_gic: Add the virtualization extensions to the GIC state

2018-06-25 Thread Peter Maydell
On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > Add the necessary parts of the virtualization extensions state to the > GIC state. We choose to increase the size of the CPU interfaces state to > add space for the vCPU interfaces (the GIC_NCPU_VCPU macro). This way, > we'll be able to

[Qemu-devel] [RFC v2 2/2] virtio-net: Example Patch for using BPF

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran This commit is a sample only for using the libbpf in the code and shouldn't be committed. Signed-off-by: Sameeh Jubran --- hw/net/Makefile.objs | 4 hw/net/virtio-net.c | 4 2 files changed, 8 insertions(+) diff --git a/hw/net/Makefile.objs

[Qemu-devel] [RFC v2 0/2] Add BPF suuport to Qemu

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran The Berkeley Packet Filter has been in the kernel for a while now and I think it is time that it is introduced to Qemu. This patch is an infrastructure for any future usage of the BPF in Qemu. It is important to note that the tun driver had started supporting using BPF

[Qemu-devel] [PATCH] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Joel Stanley
This adds Cedric as the maintainer, with Andrew and I as reviewers, for the ASPEED boards and the peripherals we use. Signed-off-by: Joel Stanley --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2874ddce6097..14bcf2ed3e3d 100644

Re: [Qemu-devel] [RFC v2 0/2] Add BPF suuport to Qemu

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 12:07, Sameeh Jubran wrote: > From: Sameeh Jubran > > The Berkeley Packet Filter has been in the kernel for a while now and I > think it is time that it is introduced to Qemu. This patch is an > infrastructure for any future usage of the BPF in Qemu. > > It is important to

[Qemu-devel] [PATCH v1 04/10] .gitignore: add .gcov files

2018-06-25 Thread Alex Bennée
These are temporary files generated on gcov runs and shouldn't be included in the source tree. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index

Re: [Qemu-devel] Why qom-get is not available in qemu monitor

2018-06-25 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Dongli Zhang (dongli.zh...@oracle.com) wrote: >> Hi, >> >> Would you mind help confirm why qom-get command is not supported by qemu >> monitor, but only qapi? >> >> Is this a feature (qom-get in monitor) totally useless for some reason, or >> it is >>

Re: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup

2018-06-25 Thread Philippe Mathieu-Daudé
Hi Alex, On 06/25/2018 08:19 AM, Alex Bennée wrote: > As we don't always take the normal exit path when running a guest we > can skip the normal exit destructors where gcov normally dumps it's > info. The GCC manual suggests long running programs use __gcov_dump() > to flush out the coverage

[Qemu-devel] [PATCH v5 00/46] Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
Hi, This series: - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h" (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?) - clean hw/ includes; - replace different constants used for byte size with their corresponding IEC binary prefix definitions.

[Qemu-devel] [PATCH v5 13/46] hw/block: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/m25p80.c | 5 +++-- hw/block/nvme.c| 3 ++- hw/block/tc58128.c | 3 ++- 3

[Qemu-devel] [PATCH v5 18/46] hw/sparc: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 10 ++ hw/sparc/sun4m.c | 10 +-

[Qemu-devel] [PATCH v5 09/46] hw/scsi: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:31 AM, Thomas Huth wrote: > On 15.06.2018 11:49, Thomas Huth wrote: >> The rom_ptr() function allows direct access to the ROM blobs that we >> load during startup. However, there are currently no checks for the >> size of the accesses, so it's currently possible to crash QEMU for

[Qemu-devel] [PATCH v5 43/46] vl: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index

  1   2   3   4   >