Re: [Qemu-devel] [PATCH] nbd/client: add x-block-status hack for testing server

2018-06-29 Thread Eric Blake
On 06/29/2018 05:01 AM, Vladimir Sementsov-Ogievskiy wrote: Sorry for being late, here are some thoughts. Anyway, idea is good, we've planned to do something like this, but you were the first) Actually, I'm now leaning towards a bit more extensive improvement that would let 'qemu-img map

Re: [Qemu-devel] [PULL 23/32] tcg: Support MMU protection regions smaller than TARGET_PAGE_SIZE

2018-06-29 Thread Peter Maydell
On 28 June 2018 at 23:26, Laurent Vivier wrote: > Le 28/06/2018 à 22:05, Peter Maydell a écrit : >> Do you have a repro case (images, command line) that I can >> use to investigate ? > - checkout the branch q800-dev-part1 from > git://github.com/vivier/qemu-m68k.git > > - configure and build >

[Qemu-devel] [PATCH for-3.0] accel/tcg: Don't treat invalid TLB entries as needing recheck

2018-06-29 Thread Peter Maydell
In get_page_addr_code() when we check whether the TLB entry is marked as TLB_RECHECK, we should not go down that code path if the TLB entry is not valid at all (ie the TLB_INVALID bit is set). Reported-by: Laurent Vivier Signed-off-by: Peter Maydell --- This fixes the abort that Laurent was

Re: [Qemu-devel] [PATCH v2 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()

2018-06-29 Thread David Hildenbrand
On 29.06.2018 16:49, Igor Mammedov wrote: > On Thu, 28 Jun 2018 14:14:15 +0200 > David Hildenbrand wrote: > >> Let's set the alignment just like for the posix variant. This will >> implicitly set the alignment of the underlying memory region and >> therefore make memory_region_get_alignment(mr)

Re: [Qemu-devel] [PATCH v0 1/7] migration: add background snapshot capability

2018-06-29 Thread Eric Blake
On 06/29/2018 03:03 AM, Denis Plotnikov wrote: The capability is used for the background vmstate saving using the migration infrastructure. Background vmstate saving means that the majority of vmstate (RAM) is saved in the background when VM's vCPUS are running. This helps to reduce the VM

Re: [Qemu-devel] [PATCH v7 3/6] qcow2: Reduce REFT_OFFSET_MASK

2018-06-29 Thread Daniel P . Berrangé
On Fri, Jun 29, 2018 at 10:22:22AM -0500, Eric Blake wrote: > On 06/29/2018 03:44 AM, Kevin Wolf wrote: > > Am 28.06.2018 um 21:07 hat Eric Blake geschrieben: > > > Match our code to the spec change in the previous patch - there's > > > no reason for the refcount table to allow larger offsets than

Re: [Qemu-devel] [PATCH v2 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()

2018-06-29 Thread David Hildenbrand
On 29.06.2018 17:56, Igor Mammedov wrote: > On Fri, 29 Jun 2018 17:39:10 +0200 > David Hildenbrand wrote: > >> On 29.06.2018 16:49, Igor Mammedov wrote: >>> On Thu, 28 Jun 2018 14:14:15 +0200 >>> David Hildenbrand wrote: >>> Let's set the alignment just like for the posix variant. This

[Qemu-devel] [PATCH 1/2] tcg: Define and use new tlb_hit() and tlb_hit_page() functions

2018-06-29 Thread Peter Maydell
The condition to check whether an address has hit against a particular TLB entry is not completely trivial. We do this in various places, and in fact in one place (get_page_addr_code()) we have got the condition wrong. Abstract it out into new tlb_hit() and tlb_hit_page() inline functions (one for

Re: [Qemu-devel] [PATCH v7 6/6] qcow2: Avoid memory over-allocation on compressed images

2018-06-29 Thread Kevin Wolf
Am 29.06.2018 um 17:16 hat Eric Blake geschrieben: > On 06/29/2018 04:03 AM, Kevin Wolf wrote: > > Am 28.06.2018 um 21:07 hat Eric Blake geschrieben: > > > When reading a compressed image, we were allocating s->cluster_data > > > to 32*cluster_size + 512 (possibly over 64 megabytes, for an image >

[Qemu-devel] [PATCH 0/2] tcg: fix TLB miss check in get_page_addr_code()

2018-06-29 Thread Peter Maydell
In commit 71b9a45330fe220d1 we changed the condition we use to determine whether we need to refill the TLB in get_page_addr_code() to if (unlikely(env->tlb_table[mmu_idx][index].addr_code != (addr & (TARGET_PAGE_MASK | TLB_INVALID_MASK { This isn't the right check

Re: [Qemu-devel] [PATCH v2 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()

2018-06-29 Thread Igor Mammedov
On Fri, 29 Jun 2018 17:39:10 +0200 David Hildenbrand wrote: > On 29.06.2018 16:49, Igor Mammedov wrote: > > On Thu, 28 Jun 2018 14:14:15 +0200 > > David Hildenbrand wrote: > > > >> Let's set the alignment just like for the posix variant. This will > >> implicitly set the alignment of the

Re: [Qemu-devel] [PULL 0/3] Min glib patches

2018-06-29 Thread Peter Maydell
On 29 June 2018 at 12:25, Daniel P. Berrangé wrote: > The following changes since commit 609ef9f451759151d0bfe7c3843410ab94d68f18: > > Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' > into staging (2018-06-28 17:53:31 +0100) > > are available in the Git repository

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-06-29 Thread Peter Maydell
>From upstream QEMU's point of view the status of this bug is "it's an old bug report that tended to accumulate 'this seems like it's the same as my bug' extra comments; we have fixed the underlying cause of the original bug, so leave this one closed and file new ones with proper reproducer

Re: [Qemu-devel] [PATCH v5 8/8] block: Add blklogwrites

2018-06-29 Thread Ari Sundholm
On 06/29/2018 03:05 PM, Kevin Wolf wrote: Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben: From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file

[Qemu-devel] [PATCH 2/2] accel/tcg: Correct "is this a TLB miss" check in get_page_addr_code()

2018-06-29 Thread Peter Maydell
In commit 71b9a45330fe220d1 we changed the condition we use to determine whether we need to refill the TLB in get_page_addr_code() to if (unlikely(env->tlb_table[mmu_idx][index].addr_code != (addr & (TARGET_PAGE_MASK | TLB_INVALID_MASK { This isn't the right check (it

Re: [Qemu-devel] [PATCH for-3.0] accel/tcg: Don't treat invalid TLB entries as needing recheck

2018-06-29 Thread Laurent Vivier
Le 29/06/2018 à 18:17, Peter Maydell a écrit : > In get_page_addr_code() when we check whether the TLB entry > is marked as TLB_RECHECK, we should not go down that code > path if the TLB entry is not valid at all (ie the TLB_INVALID > bit is set). > > Reported-by: Laurent Vivier > Signed-off-by:

Re: [Qemu-devel] [PATCH v5 8/8] block: Add blklogwrites

2018-06-29 Thread Kevin Wolf
Am 29.06.2018 um 18:02 hat Ari Sundholm geschrieben: > On 06/29/2018 03:05 PM, Kevin Wolf wrote: > > Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben: > > > +s->cur_log_sector = 1; > > > +s->nr_entries = 0; > > > > Would it be useful to implement a mode that appends to the log? > > >

Re: [Qemu-devel] [PATCH v2 0/3] image fleecing

2018-06-29 Thread John Snow
On 06/29/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote: > Image fleecing, or external (or pull) backup scheme is near to complete. > Here is forgotten test, written by Fam in far 2014, with two my necessary > patches, previously sent separately, so the series are called "v2" > > v2: > 01:

Re: [Qemu-devel] [Qemu-block] [PATCH v7 6/6] qcow2: Avoid memory over-allocation on compressed images

2018-06-29 Thread Kevin Wolf
Am 29.06.2018 um 17:47 hat Kevin Wolf geschrieben: > Am 29.06.2018 um 17:16 hat Eric Blake geschrieben: > > On 06/29/2018 04:03 AM, Kevin Wolf wrote: > > > Am 28.06.2018 um 21:07 hat Eric Blake geschrieben: > > > > When reading a compressed image, we were allocating s->cluster_data > > > > to

[Qemu-devel] [PULL v2 6/7] hw/riscv/sifive_u: Move the uart device tree node under /soc/

2018-06-29 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index f71527eaff..46459cd368 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -194,7

[Qemu-devel] [PULL v2 1/7] hw/riscv/sifive_u: Create a SiFive U SoC object

2018-06-29 Thread Alistair Francis
Create a SiFive Unleashed U54 SoC and use that in the sifive_u machine. We leave the SoC, RAM, device tree and reset/fdt loading as part of the machine. All the other device creation has been moved to the SoC. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c

[Qemu-devel] [PULL v2 0/7] riscv-pull queue

2018-06-29 Thread Alistair Francis
-20180629 for you to fetch changes up to e4847c96685e210649e6ec90fecd732a744dad75: hw/riscv/sifive_u: Connect the Cadence GEM Ethernet device (2018-06-29 09:51:05 -0700) RISC-V: SoCify SiFive boards and connect GEM This series

Re: [Qemu-devel] [PATCH v5] crypto: Implement TLS Pre-Shared Keys (PSK).

2018-06-29 Thread Richard W.M. Jones
On Fri, Jun 29, 2018 at 06:03:43PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 28, 2018 at 07:46:24PM +0100, Richard W.M. Jones wrote: > > diff --git a/crypto/tlssession.c b/crypto/tlssession.c > > index 96a02deb69..50df64e0a9 100644 > > --- a/crypto/tlssession.c > > +++ b/crypto/tlssession.c >

[Qemu-devel] [PULL 06/11] hw/input/tsc2005: Convert a fprintf() call to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/input/tsc2005.c| 7 +++ hw/input/trace-events | 3 +++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index

[Qemu-devel] [PULL 01/11] simpletrace: Convert name from mapping record to str

2018-06-29 Thread Stefan Hajnoczi
From: Eduardo Habkost The rest of the code assumes that idtoname is a (int -> str) dictionary, so convert the data accordingly. This is necessary to make the script work with Python 3 (where reads from a binary file return 'bytes' objects, not 'str'). Fixes the following error: $ python3

[Qemu-devel] [PULL 07/11] hw/net/ne2000: Add trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/ne2000.c | 17 - hw/net/trace-events | 4 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index

Re: [Qemu-devel] [PATCH v2 0/3] qcow2 compress threads

2018-06-29 Thread Kevin Wolf
Am 20.06.2018 um 16:48 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > Here are compress threads for qcow2, to increase performance of > compressed writes. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PULL v3 00/60] Misc patches for soft freeze

2018-06-29 Thread Peter Maydell
On 29 June 2018 at 12:05, Paolo Bonzini wrote: > The following changes since commit 4a83bf2f339d4b63ecd5ef48b9816c3b7ee24553: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20180627' > into staging (2018-06-28 15:31:42 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Mark Cave-Ayland
On 29/06/18 19:18, Emilio G. Cota wrote: On Fri, Jun 29, 2018 at 13:17:11 +0100, Mark Cave-Ayland wrote: Whilst trying to debug an issue in OpenBIOS, I noticed that the gdbstub single-step functionality was broken which I bisected down to this commit: (snip) commit

Re: [Qemu-devel] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread John Snow
CC Qemu Block; looks like QED is a bit busted. On 06/27/2018 10:25 AM, Quytelda Kahja wrote: > Hello all, > I wanted to submit a bug report in the tracker, but it seem to require > an Ubuntu One account, which I'm having trouble with, so I'll just > give it here and hopefully somebody can make

[Qemu-devel] [PATCH] tcg: Fix --disable-tcg build breakage

2018-06-29 Thread Philippe Mathieu-Daudé
Fix the --disable-tcg breakage introduced by 8bca9a03ec60d: $ configure --disable-tcg [...] $ make -C i386-softmmu exec.o make: Entering directory 'i386-softmmu' CC exec.o In file included from source/qemu/exec.c:62:0: source/qemu/include/exec/ram_addr.h:96:6:

Re: [Qemu-devel] [PULL v3 00/60] Misc patches for soft freeze

2018-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2018 03:03 PM, Peter Maydell wrote: > On 29 June 2018 at 12:05, Paolo Bonzini wrote: >> The following changes since commit 4a83bf2f339d4b63ecd5ef48b9816c3b7ee24553: >> >> Merge remote-tracking branch >> 'remotes/juanquintela/tags/migration/20180627' into staging (2018-06-28 >>

[Qemu-devel] [PATCH v2 05/21] docker: add gcovr to travis image

2018-06-29 Thread Alex Bennée
Useful for debugging if nothing else as the gcovr on the Travis images are a little old. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/docker/dockerfiles/travis.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 03/21] build-system: remove per-test GCOV reporting

2018-06-29 Thread Alex Bennée
I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex

[Qemu-devel] [PATCH v2 11/21] docker: filter out linux-user builds for mingw

2018-06-29 Thread Alex Bennée
The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the effect of defaulting all docker builds to the current configured set of targets. This is actually reasonable behaviour but does run into problems if you have linux-user builds configured and you want to test the windows cross

[Qemu-devel] [PATCH v2 07/21] build-system: add clean-coverage target

2018-06-29 Thread Alex Bennée
This can be used to remove any stale coverage data before any particular test run. This is useful for analysing individual tests. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- v2 - s/to any/to delete any/ --- Makefile | 11 +++ docs/devel/testing.rst |

[Qemu-devel] [PATCH v2 18/21] docker: add special handling for FROM:debian-%-user targets

2018-06-29 Thread Alex Bennée
These will have been build with debootstrap so we need to check against the debian-bootstrap dockerfile. This does mean sticking to debian-FOO-user as the naming conventions for boot-strapped images. The actual cross image is built on top. Signed-off-by: Alex Bennée --- tests/docker/docker.py |

[Qemu-devel] [PATCH v2 21/21] .shippable.yml: add linux-user cross-build for ppc-softmmu

2018-06-29 Thread Alex Bennée
Use our new ability to use linux-user powered docker images to build ppc-softmmu. Signed-off-by: Alex Bennée --- .shippable.yml | 8 1 file changed, 8 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index f74a3de3ff..12f9d3b221 100644 --- a/.shippable.yml +++

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Image fleecing test case 222

2018-06-29 Thread John Snow
On 06/29/2018 01:58 PM, Eric Blake wrote: > On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Fam Zheng >> >> This tests the workflow of creating a lightweight point-in-time snapshot >> with blockdev-backup command, and exporting it with built-in NBD server. >> >> It's

[Qemu-devel] [PATCH v2 17/21] docker: drop QEMU build-dep from bootstrap

2018-06-29 Thread Alex Bennée
This is best done with any child images that actually need it. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-bootstrap.docker | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-bootstrap.docker

[Qemu-devel] [PULL v2 4/7] hw/riscv/sifive_u: Set the soc device tree node as a simple-bus

2018-06-29 Thread Alistair Francis
To allow Linux to ennumerate devices on the /soc/ node set it as a "simple-bus". Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index

[Qemu-devel] [PULL v2 2/7] hw/riscv/sifive_e: Create a SiFive E SoC object

2018-06-29 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_e.c | 97 +++-- include/hw/riscv/sifive_e.h | 16 +- 2 files changed, 86 insertions(+), 27 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index

[Qemu-devel] [PULL v2 7/7] hw/riscv/sifive_u: Connect the Cadence GEM Ethernet device

2018-06-29 Thread Alistair Francis
Connect the Cadence GEM ethernet device. This also requires us to expose the plic interrupt lines. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- default-configs/riscv32-softmmu.mak | 3 +- default-configs/riscv64-softmmu.mak | 3 +- hw/riscv/sifive_u.c | 50

Re: [Qemu-devel] [PATCH v2 1/3] blockdev-backup: enable non-root nodes for backup source

2018-06-29 Thread John Snow
On 06/29/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote: > This is needed to implement image-fleecing scheme, when we create > a temporary node, mark our active node to be backing for the temp, > and start backup(sync=none) from active node to the temp node. > Temp node then represents a

Re: [Qemu-devel] [PATCH] audio/hda: drop atomics

2018-06-29 Thread Philippe Mathieu-Daudé
On 06/27/2018 01:15 PM, Philippe Mathieu-Daudé wrote: > On 06/27/2018 08:19 AM, Gerd Hoffmann wrote: >> Doesn't build on 32bit clang. And because we run under qemu mutex >> anyway they are not needed. >> >> Signed-off-by: Gerd Hoffmann > > Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [Qemu-devel] [RFC v3 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer,

Re: [Qemu-devel] [RFC v3 02/10] ADB: VIA probes ADB bus when it is idle

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c| 4 ++ hw/input/adb-mouse.c | 4 ++ hw/input/adb.c| 115

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Venu Busireddy
On 2018-06-27 22:27:33 -0500, Venu Busireddy wrote: > On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote: > > > On 2018-06-27 23:12:12 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jun 27, 2018 at 02:59:01PM -0500, Venu

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-06-29 Thread Leonardo Müller
QEMU from git apparently is fixed, but Ubuntu's version is still problematic. Using an Xubuntu 18.04 guest, it's possible to reproduce the crash using: while true ; do xrandr --output Virtual-0 --mode 640x480 ; sleep 1 ; xrandr --output Virtual-0 --mode 1280x720 ; sleep 1 ; xrandr --output

[Qemu-devel] [PATCH v2 12/21] docker: ubuntu: Update the package list before installing new ones

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since docker caches the different layers, updating the package list does not invalidate the previous "apt-get update" layer, and it is likely "apt-get install" hits an outdated repository. See

[Qemu-devel] [PATCH v2 19/21] docker: add special rule for deboostrapped images

2018-06-29 Thread Alex Bennée
We might as well have a custom rule for this. For one things the dependencies are different. We drop the test and EXECUTABLE lines from the general rule as they are no longer needed there. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 26 +- 1 file

Re: [Qemu-devel] [PATCH] migration: Appease coverity, skip empty block trees

2018-06-29 Thread Stefan Hajnoczi
On Fri, Jun 22, 2018 at 04:11:22PM -0400, John Snow wrote: > If a tree consists exclusively of implicit filter nodes, we might crash > QEMU. This configuration should not exist in practice, but if it did, > skipping it would be fine. > > For the purposes of debug builds, throw an assert to remind

Re: [Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 01:34:04PM +0200, Paolo Bonzini wrote: > On 28/06/2018 20:30, Eduardo Habkost wrote: > >> For migration to work, you need to add new "features" corresponding to > >> the bits in the MSR, and include them in the Icelake-Server and > >> Icelake-Client models. Unfortunately

[Qemu-devel] [PULL 11/11] hw/block/pflash_cfi: Convert from DPRINTF() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé [Fixed lx -> PRIx64 as suggested by Philippe. --Stefan] Signed-off-by: Stefan Hajnoczi --- hw/block/pflash_cfi01.c | 42 +++-- hw/block/pflash_cfi02.c | 18 +-

[Qemu-devel] [PULL 02/11] trace: Fix format string for the struct timeval members casted to size_t

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé This fixes when using GCC with -Wformat-signedness: migration/trace.h: In function ‘_nocheck__trace_dirty_bitmap_load_success’: migration/trace.h:6368:24: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 3 has type ‘long unsigned

Re: [Qemu-devel] [PATCH v3] docs: add guidance on configuring CPU models for x86

2018-06-29 Thread Eduardo Habkost
On Wed, Jun 27, 2018 at 05:01:03PM +0100, Daniel P. Berrangé wrote: > With the recent set of CPU hardware vulnerabilities on x86, it is > increasingly difficult to understand which CPU configurations are > good to use and what flaws they might be vulnerable to. > > This doc attempts to help

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Emilio G. Cota
On Fri, Jun 29, 2018 at 13:17:11 +0100, Mark Cave-Ayland wrote: > Whilst trying to debug an issue in OpenBIOS, I noticed that the gdbstub > single-step functionality was broken which I bisected down to this commit: (snip) > commit b0c2d5213a14f8b9d44096ee879a5d7f10fbc505 > Author: Emilio G. Cota

Re: [Qemu-devel] [PATCH 3/3] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Thu, Jun 28, 2018 at 12:15:33PM +0200, Greg Kurz wrote: > It is unsafe to rely on *_enabled() helpers before the accelerator has > been initialized, ie, accel_init_machine() has succeeded, because they > always return false. But it is still possible to end up calling them > indirectly by

Re: [Qemu-devel] [Qemu-block] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread Kevin Wolf
Am 29.06.2018 um 22:16 hat Eric Blake geschrieben: > On 06/29/2018 03:07 PM, John Snow wrote: > > CC Qemu Block; looks like QED is a bit busted. > > > > On 06/27/2018 10:25 AM, Quytelda Kahja wrote: > > > Hello all, > > > I wanted to submit a bug report in the tracker, but it seem to require > >

[Qemu-devel] [PATCH v2 06/21] travis: add gcovr summary for GCOV build

2018-06-29 Thread Alex Bennée
This gives a more useful summary, sorted by descending % coverage, after the tests have run. The final numbers will give an idea if our coverage is getting better or worse. To keep the width sane we need to post process the file that the old gcovr tool generates. This is done with a mix of sed,

[Qemu-devel] [PATCH v2 08/21] build-system: add coverage-report target

2018-06-29 Thread Alex Bennée
This will build a coverage report under the current directory in reports/coverage. At the users option a report can be generated by directly invoking something like: make foo/bar/coverage-report.html Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v2 14/21] docker: Clean the MXE base image

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Using the duplicated same package is confusing. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian8-mxe.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 15/21] docker: Do not run tests in 'intermediate' images

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé We can still build the DOCKER_INTERMEDIATE_IMAGES images, but they won't appear in 'make test*@$IMAGE'. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 13/21] docker: ubuntu: Use SDL2

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Do not test the deprecated API versions (see cabd35840749d). Debian MXE MinGW cross images are already using SDL2. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/ubuntu.docker | 4 ++-- 1 file changed, 2

Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-06-29 Thread Stefan Hajnoczi
On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote: > +static void virtio_rng_set_status(VirtIODevice *vdev, uint8_t status) > +{ > +VirtIORNG *vrng = VIRTIO_RNG(vdev); > + > +if (!vdev->vm_running) { > +return; > +} > +vdev->status = status; Please add a comment

Re: [Qemu-devel] [PATCH v2 2/2] pci: allow DeviceClass fw_name to override pci_dev_fw_name() if set

2018-06-29 Thread Mark Cave-Ayland
On 29/06/18 18:04, Michael S. Tsirkin wrote: On Fri, Jun 29, 2018 at 02:56:16PM +0100, Mark Cave-Ayland wrote: The current implementation of pci_dev_fw_name() scans through a fixed set of PCI class descriptions to determine the firmware device name but in some cases this isn't always

Re: [Qemu-devel] [PATCH 0/2] tcg: fix TLB miss check in get_page_addr_code()

2018-06-29 Thread Richard Henderson
On 06/29/2018 09:21 AM, Peter Maydell wrote: > In commit 71b9a45330fe220d1 we changed the condition we use to > determine whether we need to refill the TLB in get_page_addr_code() to > if (unlikely(env->tlb_table[mmu_idx][index].addr_code != > (addr & (TARGET_PAGE_MASK

[Qemu-devel] [PULL 03/11] sdcard: Reduce sdcard_set_blocklen() trace digits

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Per the Physical Layer Simplified Spec. "5.3 CSD Register": "The maximum block length might therefore be in the range 512...2048 bytes" Therefore 3 hexdigits are enough to report the block length. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH] block/fleecing-filter: new filter driver for fleecing

2018-06-29 Thread John Snow
On 06/21/2018 11:48 AM, Vladimir Sementsov-Ogievskiy wrote: > We need to synchronize backup job with reading from fleecing image > like it was done in block/replication.c. > > Otherwise, the following situation is theoretically possible: > > 1. client start reading > 2. client understand,

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 11:39:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 29, 2018 at 12:35:09PM +0200, Paolo Bonzini wrote: > > On 29/06/2018 12:29, Greg Kurz wrote: > > > It is unsafe to rely on *_enabled() helpers before the accelerator has > > > been initialized, ie,

Re: [Qemu-devel] [PATCH v5 01/46] include: Add IEC binary prefixes in "qemu/units.h"

2018-06-29 Thread Eric Blake
On 06/29/2018 10:02 AM, Daniel P. Berrangé wrote: Are you suggesting this? #define KiB (INT32_C(1) << 10) #define MiB (INT32_C(1) << 20) #define GiB (INT32_C(1) << 30) #define TiB (INT64_C(1) << 40) #define PiB (INT64_C(1) << 50) #define EiB (INT64_C(1) << 60) Maybe,

Re: [Qemu-devel] [PATCH v5] crypto: Implement TLS Pre-Shared Keys (PSK).

2018-06-29 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 07:46:24PM +0100, Richard W.M. Jones wrote: > diff --git a/crypto/tlssession.c b/crypto/tlssession.c > index 96a02deb69..50df64e0a9 100644 > --- a/crypto/tlssession.c > +++ b/crypto/tlssession.c > @@ -21,6 +21,7 @@ > #include "qemu/osdep.h" > #include

Re: [Qemu-devel] [PATCH v2 1/3] blockdev-backup: enable non-root nodes for backup source

2018-06-29 Thread Eric Blake
On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: This is needed to implement image-fleecing scheme, when we create a temporary node, mark our active node to be backing for the temp, and start backup(sync=none) from active node to the temp node. Temp node then represents a kind of

[Qemu-devel] [PULL v2 3/7] hw/riscv/sifive_plic: Use gpios instead of irqs

2018-06-29 Thread Alistair Francis
Instead of creating the interrupt in lines with qemu_allocate_irq() use qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*() helpers later on. Signed-off-by: Alistair Francis Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark

Re: [Qemu-devel] [PULL 0/2] 9p patches 2018-06-29

2018-06-29 Thread Peter Maydell
On 29 June 2018 at 14:20, Greg Kurz wrote: > The following changes since commit 609ef9f451759151d0bfe7c3843410ab94d68f18: > > Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' > into staging (2018-06-28 17:53:31 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 0/3] image fleecing

2018-06-29 Thread Vladimir Sementsov-Ogievskiy
29.06.2018 19:38, John Snow wrote: On 06/29/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote: Image fleecing, or external (or pull) backup scheme is near to complete. Here is forgotten test, written by Fam in far 2014, with two my necessary patches, previously sent separately, so the series

Re: [Qemu-devel] CPU model versioning separate from machine type versioning ?

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 11:19:17AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 29, 2018 at 09:53:53AM +0100, Dr. David Alan Gilbert wrote: [...] > > We're going to have to say something like: > > 'For the new XYZ vulnerability make sure you're using > > Haswell-3.2 or later, SkyLake-2.6 or

[Qemu-devel] [PULL 09/11] hw/net/etraxfs_eth: Convert printf() calls to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Suggested-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/etraxfs_eth.c | 8 hw/net/trace-events | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/net/etraxfs_eth.c

[Qemu-devel] [PULL 08/11] hw/net/ne2000: Convert printf() calls to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/ne2000.c | 8 ++-- hw/net/trace-events | 2 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 26b234b7eb..07d79e317f

[Qemu-devel] [PULL 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/block/fdc.c| 6 +++--- hw/block/trace-events | 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index

[Qemu-devel] [PULL 05/11] hw/char/parallel: Convert from pdebug() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/char/parallel.c | 16 +--- hw/char/trace-events | 4 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index

Re: [Qemu-devel] [RFC v3 07/10] hw/m68k: add Nubus support

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/display/macfb.c | 56 ++ hw/nubus/Makefile.objs | 4 +

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Emilio G. Cota
On Fri, Jun 29, 2018 at 19:38:02 +0100, Mark Cave-Ayland wrote: > On 29/06/18 19:18, Emilio G. Cota wrote: > >I tried the last known good commit (as per your bisect) and get the same > >results > >as above. > > > >Is there any other way I could try reproducing this? Also, can you > >reproduce

Re: [Qemu-devel] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread Eric Blake
On 06/29/2018 03:07 PM, John Snow wrote: CC Qemu Block; looks like QED is a bit busted. On 06/27/2018 10:25 AM, Quytelda Kahja wrote: Hello all, I wanted to submit a bug report in the tracker, but it seem to require an Ubuntu One account, which I'm having trouble with, so I'll just give it

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 02:55:44PM -0500, Eric Blake wrote: > Now that we have useful access to the type name as a comment > in the generated qapi-introspect.c, we don't need to regenerate > code with a temporary -u option just to get at type names. > > Signed-off-by: Eric Blake Reviewed-by:

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 05:18:21PM +0200, Igor Mammedov wrote: > On Fri, 29 Jun 2018 12:14:05 +0100 > Daniel P. Berrangé wrote: > > > On Fri, Jun 29, 2018 at 01:08:38PM +0200, Paolo Bonzini wrote: > > > On 29/06/2018 13:07, Greg Kurz wrote: > > > Also asserting current_machine != NULL is

Re: [Qemu-devel] [PATCH v2 12/20] 9p: darwin: Explicitly cast comparisons of mode_t with -1

2018-06-29 Thread Eric Blake
On 05/31/2018 08:26 PM, Keno Fischer wrote: Comparisons of mode_t with -1 require an explicit cast, since mode_t is unsigned on Darwin. It's not JUST that mode_t is unsigned (an unsigned int compares just fine against -1), but ALSO that mode_t has unspecified width. That is, you cannot

[Qemu-devel] [PATCH v2 04/21] .gitignore: add .gcov files

2018-06-29 Thread Alex Bennée
These are temporary files generated on gcov runs and shouldn't be included in the source tree. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v2 00/21] Travis, Code Coverage and Cross Build updates

2018-06-29 Thread Alex Bennée
Hi, I've picked up some more of Philippe's fixes and in the process had another look at the problem of cross compiling powerpc. In the end the consensus seems to be a linux-user build was the best solution as there are still supported native powerpc toolchains in Jessie (until 2020). So I dusted

[Qemu-devel] [PATCH v2 01/21] travis: do not waste time cloning unused submodules

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Builds only require: - dtc - keycodemapdb - capstone Signed-off-by: Philippe Mathieu-Daudé [AJB: drop wget cache] Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 16/21] docker: add env parser to docker.py build step

2018-06-29 Thread Alex Bennée
We need to pass environment variables down to the debbootstrap.pre script to be able to specify build parameters. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index

Re: [Qemu-devel] [PATCH v1] s390x/tcg: fix locking problem with tcg_s390_tod_updated

2018-06-29 Thread Richard Henderson
On 06/29/2018 10:05 AM, David Hildenbrand wrote: > tcg_s390_tod_updated() is always called with the iothread being locked > (e.g. from S390TODClass->set() e.g. via HELPER(sck) or on incomming > migration). The helper we call takes the lock itself - bad. > > Let's change that by factoring out

[Qemu-devel] [PULL v2 5/7] hw/riscv/sifive_u: Set the interrupt controler number of interrupts

2018-06-29 Thread Alistair Francis
Set the interrupt-controller ndev to the correct number taken from the HiFive Unleashed board. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index

[Qemu-devel] [PATCH] tests/migration: Skip tests for ppc tcg

2018-06-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment. $ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: SKIP

Re: [Qemu-devel] [PATCH v3 02/20] virtio: pci-legacy: Validate queue pfn

2018-06-29 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 12:15:22PM +0100, Suzuki K Poulose wrote: > Legacy PCI over virtio uses a 32bit PFN for the queue. If the > queue pfn is too large to fit in 32bits, which we could hit on > arm64 systems with 52bit physical addresses (even with 64K page > size), we simply miss out a proper

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Image fleecing test case 222

2018-06-29 Thread Eric Blake
On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: From: Fam Zheng This tests the workflow of creating a lightweight point-in-time snapshot with blockdev-backup command, and exporting it with built-in NBD server. It's tested that any post-snapshot writing to the original device

Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2018-06-29 Thread Eric Blake
On 05/20/2014 01:04 AM, Fam Zheng wrote: Thanks for Eric's and Markus' reviewing! Thread necromancy - now that patch 15/15 has had a revival four years later (two different threads proposing a test 222 for image fleecing) - I want to double check if anything else in this series still needs

[Qemu-devel] [PULL 04/11] hw/char/serial: Convert from DPRINTF macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/char/serial.c | 5 +++-- hw/char/trace-events | 4 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 605b0d02f9..26f53ba02f

Re: [Qemu-devel] [PULL v2 0/7] riscv-pull queue

2018-06-29 Thread Philippe Mathieu-Daudé
the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-pull-20180629 > > for you to fetch changes up to e4847c96685e210649e6ec90fecd732a744dad75: > > hw/riscv/sifive_u: Connect the Cadence GEM Ethernet

[Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eric Blake
Now that we have useful access to the type name as a comment in the generated qapi-introspect.c, we don't need to regenerate code with a temporary -u option just to get at type names. Signed-off-by: Eric Blake --- scripts/qapi-gen.py| 5 + scripts/qapi/introspect.py | 12

  1   2   3   4   5   >