From: Marc-André Lureau
The documentation is generated only once, and doesn't know C
pre-conditions. Add 'If:' sections for top-level entities.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-13-marcandre.lur...@redhat.com>
Signed-off-by:
From: Marc-André Lureau
Modify the test visitor to check correct passing of values.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-5-marcandre.lur...@redhat.com>
[Accidental change to roms/seabios dropped]
Signed-off-by: Markus Armbruster
From: Marc-André Lureau
Accept 'if' key in top-level elements, accepted as string or list of
string type. The following patches will modify the test visitor to
check the value is correctly saved, and generate #if/#endif code (as a
single #if/endif line or a series for a list).
Example of 'if'
Now you've made me subscribe again to qemu-devel ;)
On 30/06/18 18:07, Bryce Lanham wrote:
> Oh hi!
>
> Luckily gmail brought this to the top since I don’t pay attention to the
> list. I’m away from my computer at the moment, but I had more than this
> working, including interrupts, Ethernet,
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180703163451.16936-1-laur...@vivier.eu
Subject: [Qemu-devel] [PULL 0/7] Linux user for 3.0 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved
the handle_qmp_command tracepoint from handle_qmp_command() to
monitor_qmp_dispatch_one(). This delays tracing from enqueue time to
dequeue time. Revert that. Dequeue remains adequately visible via
tracepoint
All callers of qmp_build_error_object() duplicate the code to wrap it
in a response object. Replace it by qmp_error_response() that
captures the duplicated code, including error_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Commit cf869d53172 "qmp: support out-of-band (oob) execution" added a
general mechanism for command-independent arguments just for an
out-of-band flag:
The "control" key is introduced to store this extra flag. "control"
field is used to store arguments that are shared by all the
There's just one use of qobject_from_jsonf() to parse a JSON object
left: timestamp_put(). Switch it to qdict_from_jsonf_nofail().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-29-arm...@redhat.com>
---
qapi/qmp-event.c | 10 +-
1 file
Hi Stafford,
On 07/02/2018 12:10 PM, Stafford Horne wrote:
> From: Richard Henderson
>
> All of the existing code was boilerplate from elsewhere,
> and would crash the guest upon the first signal.
>
> Signed-off-by: Richard Henderson
> Signed-off-by: Stafford Horne
>
> ---
> v2:
> Add a
You want to attach with an Arm-aware gdb to the QEMU debug stub, not
connect an x86 gdb to the x86 QEMU process. On Debian/Ubuntu the gdb in
the 'gdb-multiarch' package will do.
Also, I gave you a wrong command line by mistake: you need "-g 1234",
not "-g -" (-g wants the TCP port as an option).
Marc-André Lureau writes:
> Hi
>
> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>>> Add helpers to wrap generated code with #if/#endif lines.
>>>
>>> Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC
>>> inherit from it, for full C
On 03/07/2018 13:07, Robert Hoo wrote:
>> FEAT_XSAVE_COMP_LO, /* CPUID[EAX=0xd,ECX=0].EAX */
>> FEAT_XSAVE_COMP_HI, /* CPUID[EAX=0xd,ECX=0].EDX */
>> +FEATURE_WORDS_NUM_CPUID,
>> +FEATURE_WORDS_FIRST_MSR = FEATURE_WORDS_NUM_CPUID,
>> +FEAT_MSR_ARCH_CAPABILITIES =
On 03/07/2018 12:14, Alex Bennée wrote:
> The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the
> effect of defaulting all docker builds to the current configured set
> of targets. This is actually reasonable behaviour but does run into
> problems if you have linux-user builds
On 03/07/2018 12:14, Alex Bennée wrote:
> The following changes since commit 46d0885adff9b99622d72f23a8b04c298a8bf91d:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2018-07-03 09:49:20 +0100)
>
> are available in the Git repository at:
>
>
On 07/03/2018 04:06 PM, Kevin Wolf wrote:
Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file
I probably should have added more context here...
We carry this patch to sgabios in Fedora to enable cross compilation. It
would be nice to get it into the qemu sgabios git repo so we don't have
to track it downstream anymore
Thanks,
Cole
On 03/25/2018 03:03 PM, Cole Robinson wrote:
> From:
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed by an image or a
host block device, and a log device, typically backed by a file, on
which writes to the raw device are logged.
The logging format used is the same as in
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index
From: Vladimir Sementsov-Ogievskiy
Make a separate function for compression to be parallelized later.
- use .avail_out field instead of .next_out to calculate size of
compressed data. It looks more natural and it allows to keep dest to
be void pointer
- set avail_out to be at least one
On Mon, 2 Jul 2018 22:10:26 -0300
Eduardo Habkost wrote:
> I forgot a hyphen when amending the compat code on commit
> e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
>
> Fixes: e00516475c270dcb6705753da96063f95699abf2
> Signed-off-by: Eduardo Habkost
> ---
> Bug detected by
Markus Armbruster writes:
[...]
> Let's add a hint to the commit message. Pergaps:
>
> qapi-introspect: add preprocessor conditions to generated QLit
>
> This commit adds 'ifcond' conditions to top-level QLit objects.
> Future work will add them to object and enum type members, i.e.
Am 03.07.2018 um 16:59 hat Kevin Wolf geschrieben:
> From: Aapo Vienamo
>
> Implements a block device write logging system, similar to Linux kernel
> device mapper dm-log-writes. The write operations that are performed
> on a block device are logged to a file or another block device. The
> write
On Tue, Jul 3, 2018 at 6:05 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote:
>> On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote:
>> > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote:
>> > Risks:
>> > 1. If one cloned VM is exploited then
While just setting the MSR bits is sufficient, we can tidy
the helper code by extracting the MSR test to a helper and
then forcing it true for user-only.
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 15 ---
target/ppc/translate_init.inc.c | 2 ++
2 files
Beginning with John Arbuckle's fdiv test case, clean up some
of the fp helpers. As with fdiv, fre and fresqrt are missing
divide-by-zero exceptions.
I've also noticed that load/store were using arithmetic conversions
to/from float32. These should be using the non-arithmetic algorithms
listed in
Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben:
> From: Aapo Vienamo
>
> Implements a block device write logging system, similar to Linux kernel
> device mapper dm-log-writes. The write operations that are performed
> on a block device are logged to a file or another block device. The
>
On 03/07/18 13:47, Andrew Jones wrote:
This infrastructure already is used in hw/ppc/spapr.c
Whould it be better if we would pass something like kvm-type=48bGPA?
Otherwise I can decode another virt machine option (min_vm_phys_shift)
in kvm_type callback.
Yes, this is what I'm thinking. I
I got a solution, the patch is below:
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 608fb18..4cdc2bb 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2184,7 +2184,9 @@ static void scsi_disk_reset(DeviceState *dev)
SCSIDiskState *s = DO_UPCAST(SCSIDiskState,
On Tue, 07/03 07:48, Eric Blake wrote:
> On 07/03/2018 03:00 AM, Fam Zheng wrote:
> > On Tue, 07/03 10:47, Roman Kagan wrote:
> > > On Mon, Jul 02, 2018 at 03:55:33PM -0500, Eric Blake wrote:
> > > > On 07/02/2018 11:58 AM, Roman Kagan wrote:
> > > > > This series modifies the management of
On 03.07.2018. 01:37, Philippe Mathieu-Daudé wrote:
> Cc'ing Jason, the "Network devices" maintainer.
>
> On 02/17/2018 04:22 PM, Paul Burton wrote:
>> This patch introduces support for emulating the ethernet controller
>> found in the Intel EG20T Platform Controller Hub, referred to as pch_gbe
>>
> Enable CONFIG_PCH_GBE_PCI in mips64el-softmmu.mak (currently the only
> default config to enable Boston board support) and create the pch_gbe
> device when using the Boston board.
>
> This provides the board with an ethernet controller matching that found
> on real Boston boards as part of the
Marc-André Lureau writes:
> Hi
>
> On Tue, Jul 3, 2018 at 2:09 PM, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>>> The generator will take (obj, condition) tuples to wrap generated QLit
>>> objects for 'obj' with #if/#endif conditions.
>>>
>>> This commit adds 'ifcond' condition
Marc-André Lureau writes:
> The documentation is generated only once, and doesn't know C
> pre-conditions. Add 'If:' sections for top-level entities.
>
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi/doc.py | 22 --
> tests/qapi-schema/doc-good.json | 2
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background on the storage device as nearly all
modern filesystems or hardware have a 4k alignment internally.
646f34fa5482e495483de230b4cf0f2ae4fd2781:
tcg: Fix --disable-tcg build breakage (2018-07-02 13:42:05 +0100)
are available in the Git repository at:
g...@github.com:stffrdhrn/qemu.git tags/pull-or-20180703
for you to fetch changes up to dfc84745bbaa0fea2abc8575dd349f6e4bb7edc7:
target/openrisc: Fix writes to interrupt mask
On Tue, 07/03 09:38, ryang wrote:
> The current paths for modules are CONFIG_QEMU_MODDIR and paths relative
> to the executable. Qemu and its modules can be installed and executed in
> paths that are different from these search paths. This change allows
> a search path to be specified by
On 07/03/2018 09:19 AM, Gerd Hoffmann wrote:
> The rate of pulseaudio absorbing the audio stream is used to control the
> the rate of the guests audio stream. When the emulated hardware uses
> small chunks (like intel-hda does) we need small chunks on the audio
> backend side too, otherwise that
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file or another block device. The
write log format is identical to the dm-log-writes format.
Marc-André Lureau writes:
> From: Markus Armbruster
>
> Types & visitors are coupled and must be handled together to avoid
> temporary build regression.
>
> Wrap generated types/visitor code with #if/#endif using the context
> helpers.
I'll insert here:
Derived from a patch by Marc-André.
From: Vladimir Sementsov-Ogievskiy
Do data compression in separate threads. This significantly improve
performance for qemu-img convert with -W (allow async writes) and -c
(compressed) options.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Kevin Wolf
---
block/qcow2.h | 3 +++
Marc-André Lureau writes:
> Add #if defined(CONFIG_SPICE) in generated code, and adjust the
> qmp/hmp code accordingly.
>
> query-qmp-schema no longer reports the command/events etc as
> available when disabled at compile time.
>
> Commands made conditional:
>
> * query-spice
>
> Before the
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file or another block device. The
write log format is identical to the dm-log-writes format.
tory at:
>
> git://github.com/dgibson/qemu.git tags/ppc-for-3.0-20180703
>
> for you to fetch changes up to 29f9cef39eb1ae55e82c6763eb22d7a1bdff7276:
>
> ppc: Include vga cirrus card into the compiling process (2018-07-03
> 11:23:09 +1000)
>
> -
Memory operations have no side effects on fp state.
The use of a "real" conversions between float64 and float32
would raise exceptions for SNaN and out-of-range inputs.
Signed-off-by: Richard Henderson
---
target/ppc/helper.h| 4 +-
target/ppc/fpu_helper.c| 63
On Mon, Jul 02, 2018 at 04:36:10PM +0100, Peter Maydell wrote:
> On 2 July 2018 at 16:09, Stafford Horne wrote:
> > Hi Peter,
> >
> > Changes since v1:
> > - Un"fixed" an incorrect checkpatch warning pointed out by Richard.
> >
> > Please consider for pull.
> >
> > The following changes since
Hi Aleksandar,
On 07/03/2018 06:46 AM, Aleksandar Markovic wrote:
> On 03.07.2018. 01:37, Philippe Mathieu-Daudé wrote:
>> Cc'ing Jason, the "Network devices" maintainer.
>>
>> On 02/17/2018 04:22 PM, Paul Burton wrote:
>>> This patch introduces support for emulating the ethernet controller
>>>
Marc-André Lureau writes:
> Wrap generated code with #if/#endif using an 'ifcontext' on
> QAPIGenCSnippet objects.
>
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi/commands.py | 21 -
> tests/test-qmp-cmds.c| 5 +++--
> 2 files changed, 15 insertions(+), 11
On Tue, 3 Jul 2018 09:28:17 -0500
Venu Busireddy wrote:
> On 2018-07-03 12:58:25 +0300, Roman Kagan wrote:
> > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote:
> > > On 7/2/2018 9:14 AM, Roman Kagan wrote:
> > > > Is the scheme going to be applied/extended to other transports
Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> Tested-By: Guido Günther
> Reviewed-by: Laurent Vivier
> ---
> linux-user/syscall.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>
From: Ari Sundholm
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
Signed-off-by: Kevin Wolf
---
include/block/block.h | 7 +++
block.c | 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
From: Vladimir Sementsov-Ogievskiy
No reason to forbid them, and they are needed to improve performance
with compress-threads in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Kevin Wolf
---
qemu-img.c | 5 -
1 file changed, 5 deletions(-)
diff --git
The following changes since commit a395717cbd26e7593d3c3fe81faca121ec6d13e8:
Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
staging (2018-07-03 11:49:51 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to
Am 03.07.2018 um 16:48 hat Ari Sundholm geschrieben:
> This patch series adds a new block driver, blklogwrites, to QEMU. The
> driver is given two block devices: a raw device backed by an image or a
> host block device, and a log device, typically backed by a file, on
> which writes to the raw
Hi
On Tue, Jul 3, 2018 at 2:09 PM, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
>> The generator will take (obj, condition) tuples to wrap generated QLit
>> objects for 'obj' with #if/#endif conditions.
>>
>> This commit adds 'ifcond' condition to top-level QLit objects.
>>
>> See
The current paths for modules are CONFIG_QEMU_MODDIR and paths relative
to the executable. Qemu and its modules can be installed and executed in
paths that are different from these search paths. This change allows
a search path to be specified by environment variable.
An example usage for this is
Hi all.
before v4 realization, I'd like to discuss some questions.
Our proposal for v4 is the following:
1. don't reconnect on nbd_open. So, on open we do only one connect
attempt, and if it fails, open fails.
2. don't configure timeout between attempts. instead do the following:
1s
From: Richard Henderson
While openrisc has a split i/d tlb, qemu does not. Perform a
lookup on both i & d tlbs in parallel and put the composite
rights into qemu's tlb. This avoids ping-ponging the qemu tlb
between EXEC and READ.
Signed-off-by: Richard Henderson
Signed-off-by: Stafford Horne
On 07/03/2018 03:25 AM, Gerd Hoffmann wrote:
> On Mon, Jul 02, 2018 at 02:03:58PM -0300, Philippe Mathieu-Daudé wrote:
>> On 07/02/2018 01:43 PM, Gerd Hoffmann wrote:
>>> On Mon, Jul 02, 2018 at 06:33:45PM +0200, Gerd Hoffmann wrote:
Two vga cards will try to register for the same legacy
On 2018-07-03 12:58:25 +0300, Roman Kagan wrote:
> On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote:
> > On 7/2/2018 9:14 AM, Roman Kagan wrote:
> > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote:
> > > > The patch set "Enable virtio_net to act as a standby for a
Marc-André Lureau writes:
> Wrap generated code with #if/#endif using an 'ifcontext' on
> QAPIGenCSnippet objects.
>
> This makes a conditional event's qapi_event_send_FOO() compile-time
> conditional, but its enum QAPIEvent member remains unconditional for
> now. A follow up patch "qapi-event:
On 07/03/2018 05:20 PM, Ari Sundholm wrote:
On 07/03/2018 04:06 PM, Kevin Wolf wrote:
Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are
Marc-André Lureau writes:
> Add #if defined(CONFIG_VNC) in generated code, and adjust the
> qmp/hmp code accordingly.
>
> query-qmp-schema no longer reports the command/events etc as
> available when disabled at compile.
>
> Commands made conditional:
>
> * query-vnc, query-vnc-servers,
Markus Armbruster writes:
> Marc-André Lureau writes:
>
>> Wrap generated code with #if/#endif using an 'ifcontext' on
>> QAPIGenCSnippet objects.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> scripts/qapi/commands.py | 21 -
>> tests/test-qmp-cmds.c| 5 +++--
>> 2
Hi
On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
>> Hi
>>
>> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote:
>>> Marc-André Lureau writes:
>>>
Add helpers to wrap generated code with #if/#endif lines.
Add QAPIGenCSnippet class
Tidy the invalid exception checking so that we rely on softfloat for
initial argument validation, and select the kind of invalid operand
exception only when we know we must. Pass and return float64 values
directly rather than bounce through the CPU_DoubleU union.
Signed-off-by: Richard Henderson
commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property")
introduced get/set accessors for the "irq" property to warn of its
usage, but the warning in the get pollutes the monitor 'info qtree'.
Signed-off-by: Cédric Le Goater
---
hw/ppc/spapr_vio.c | 15 ---
1 file changed, 12
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
Reviewed-by: Laurent Vivier
---
linux-user/strace.list | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/strace.list b/linux-user/strace.list
index 2bc5ba04d4..afe4db07f3 100644
---
This silents the following warning:
Cloning into './debootstrap.git'...
warning: redirecting to
https://salsa.debian.org/installer-team/debootstrap.git/
See https://lists.debian.org/debian-devel-announce/2018/01/msg4.html
Signed-off-by: Philippe Mathieu-Daudé
---
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-9-arm...@redhat.com>
---
tests/test-qga.c | 20
1 file changed, 20 insertions(+)
diff --git a/tests/test-qga.c b/tests/test-qga.c
index 30c9643257..6b632e3da4 100644
---
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
Reviewed-by: Laurent Vivier
---
linux-user/strace.list | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.list b/linux-user/strace.list
index 90cf7e338a..31093c3371 100644
---
Affects documentation and a few error messages.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-2-arm...@redhat.com>
---
docs/devel/qapi-code-gen.txt| 2 +-
docs/interop/qmp-spec.txt | 2 +-
monitor.c
Events are broadcast to all monitors. If another monitor's client has
a command with the same ID in flight, the event will incorrectly claim
that command was dropped. This must be fixed before out-of-band
execution can graduate from "experimental".
Signed-off-by: Markus Armbruster
Reviewed-by:
There's just one use of qobject_from_jsonf() to parse a JSON object
left: timestamp_put(). Switch it to qdict_from_jsonf_nofail().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-29-arm...@redhat.com>
---
qapi/qmp-event.c | 10 +-
1 file
monitor_qmp_dispatch_one() frees a QMPRequest manually, because it
needs to keep a reference to ->id. Premature optimization. Take an
additional reference so we can use qmp_request_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
The following changes since commit e8c858944ea61923ca563bb5905bf04624d05f16:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2018-07-02 19:07:19 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-03
for
qmp_greeting() offers capabilities to the client, and
qmp_qmp_capabilities() accepts or denies capabilities requested by the
client. The two compute the set of available capabilities
independently. Not nice.
Clean this up as follows. Compute available capabilities just once in
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-28-arm...@redhat.com>
---
qapi/qmp-dispatch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 761812e924..6f2d466596 100644
--- a/qapi/qmp-dispatch.c
get_qmp_greeting() returns a QDict * as QObject *. It's caller
converts it right back.
Return QDict * instead. While there, rename to qmp_greeting().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-26-arm...@redhat.com>
---
monitor.c | 13
Many uses of qobject_from_jsonf() convert JSON objects. Create new
convenience function qdict_from_jsonf_nofail() that includes the
conversion to QDict. The next few commits will put it to use.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
We commonly initialize attributes to None in .init(), then set their
real value in .check(). Accessing the attribute before .check()
yields None. If we're lucky, the code that accesses the attribute
prematurely chokes on None.
It won't for .ifcond, because None is a legitimate value.
Leave the
qobject_from_jsonf() aborts on error, unlike qobject_from_jsonv(),
which returns null. Since all remaining users of qobject_from_jsonf()
cope fine with null, change it to return null.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
On Sat, Jun 30, 2018 at 5:53 AM, Peter Maydell wrote:
> On 29 June 2018 at 18:22, Alistair Francis wrote:
>> The following changes since commit 75507f1aba6feb73ae43329922d51571550b9128:
>>
>> Merge remote-tracking branch 'remotes/berrange/tags/min-glib-pull-request'
>> into staging
All callers of qmp_build_error_object() duplicate the code to wrap it
in a response object. Replace it by qmp_error_response() that
captures the duplicated code, including error_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Wrap generated code with #if/#endif using an 'ifcontext' on
QAPIGenCSnippet objects.
Signed-off-by: Marc-André Lureau
---
scripts/qapi/commands.py | 26 +-
tests/test-qmp-cmds.c| 4 ++--
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-33-arm...@redhat.com>
---
docs/devel/qapi-code-gen.txt | 61 +++-
1 file changed, 25 insertions(+), 36 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt
Commit cf869d53172 "qmp: support out-of-band (oob) execution"
accidentally made qemu-ga accept and ignore "control". Fix that.
Out-of-band execution in a monitor that doesn't support it now fails
with
{"error": {"class": "GenericError", "desc": "QMP input member 'control' is
unexpected"}}
Accept 'if' key in top-level elements, accepted as string or list of
string type. The following patches will modify the test visitor to
check the value is correctly saved, and generate #if/#endif code (as a
single #if/endif line or a series for a list).
Example of 'if' key:
{ 'struct':
The following patch is going to break list entries with #if/#endif, so
they should have the trailing ',' as suffix.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
---
scripts/qapi/introspect.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Wrap generated code with #if/#endif using an 'ifcontext' on
QAPIGenCSnippet objects.
This makes a conditional event's qapi_event_send_FOO() compile-time
conditional, but its enum QAPIEvent member remains unconditional for
now. A follow up patch "qapi-event: add 'if' condition to implicit
event
On 07/03/2018 04:46 AM, Vladimir Sementsov-Ogievskiy wrote:
#
+# @x-dirty-bitmap: A "qemu:dirty-bitmap:NAME" string to query in
place of
+# traditional "base:allocation" block status (see
+# NBD_OPT_LIST_META_CONTEXT in the NBD protocol)
(since 3.0)
+#
> Please consider for pull:
>
> The following changes since commit 646f34fa5482e495483de230b4cf0f2ae4fd2781:
>
> tcg: Fix --disable-tcg build breakage (2018-07-02 13:42:05 +0100)
>
> are available in the Git repository at:
>
> g...@github.com:stffrdhrn/qemu.git
some distros provide a qemu-CPU-static binary beside the qemu-CPU one.
This change allows to use it by providing "--qemu-suffix -static" to the
script.
Signed-off-by: Laurent Vivier
Message-Id: <20180627205317.10343-4-laur...@vivier.eu>
---
scripts/qemu-binfmt-conf.sh | 41
On 07/03/2018 08:46 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all.
before v4 realization, I'd like to discuss some questions.
Our proposal for v4 is the following:
1. don't reconnect on nbd_open. So, on open we do only one connect
attempt, and if it fails, open fails.
2. don't configure
On 07/03/2018 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
In the subject: s/drity/dirty/, s/separte/separate/
Separate can_merge, to reuse it for transaction support for merge
command.
Also, switch some asserts to errors.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Reviewed-by: Eric
On 07/03/2018 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/transaction.json | 2 ++
blockdev.c| 53 ++-
2 files changed, 54 insertions(+), 1 deletion(-)
I'll let John handle
To allow Linux to ennumerate devices on the /soc/ node set it as a
"simple-bus".
Signed-off-by: Alistair Francis
Reviewed-by: Michael Clark
---
hw/riscv/sifive_u.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
index
The following changes since commit f988c7e191141e92de2059d04a5f9a9bb01f399c:
Merge remote-tracking branch 'remotes/shorne/tags/pull-or-20180703' into
staging (2018-07-03 16:04:41 +0100)
are available in the Git repository at:
g...@github.com:alistair23/qemu.git tags/pull-riscv-pull
Instead of creating the interrupt in lines with qemu_allocate_irq() use
qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*()
helpers later on.
Signed-off-by: Alistair Francis
Suggested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael Clark
Tidy the invalid exception checking so that we rely on softfloat for
initial argument validation, and select the kind of invalid operand
exception only when we know we must. Pass and return float64 values
directly rather than bounce through the CPU_DoubleU union.
Note that because we know
301 - 400 of 516 matches
Mail list logo
