The inotify userspace API for reading events is quite horrible, so it is
useful to wrap it in a more friendly API to avoid duplicating code
across many users in QEMU. Wrapping it also allows introduction of a
platform portability layer, so that we can add impls for non-Linux based
equivalents in
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1
An update to
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05660.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02961.html
v5:
When an object is in turn owned by another user object, it is not
desirable to expose this in the QOM object hierarchy, as it is
just an internal implementation detail, we should be free to change
without exposure.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Le 15/10/2018 à 14:16, Aleksandar Markovic a écrit :
>> From: Fredrik Noring
>> Sent: Saturday, October 13, 2018 1:09 PM
>> To: Aleksandar Markovic; Maciej W. Rozycki; Philippe Mathieu-Daudé
>> Cc: Richard Henderson; Aurelien Jarno; Petar Jovanovic; Peter Maydell;
>> Jürgen Urban; >
On 10/19/18 7:26 AM, Paolo Bonzini wrote:
Other people are doing a much better work than myself at handling some
subsystems. For those files it is better if I downgrade myself to
reviewer or recognize that I am not actually doing any work there.
Cc: Daniel P. Berrange
Cc: Gerd Hoffmann
Cc:
On 10/13/18 8:53 PM, Richard Henderson wrote:
Choose return false or raise exception. Except...
I wonder if we might write this as
int shamt = a->shamt;
if (shamt == 0) {
shamt = 64;
}
Good catch. I'll add a comment, that a shamt of 0 is intended for RV128.
If the user only wants to compile targets that do not require the
"register" device, we should also not compile register.c. Add a proper
CONFIG_REGISTER switch to be able to choose this more flexibly.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak| 1 +
If the user only wants to compile targets that do not require the
"or-irq" device, we should also not compile or-irq.c. Add a proper
CONFIG_OR_IRQ switch to be able to choose this more flexibly.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 1 +
The "unimplemented-device" is currently only used for one arm board.
Let's add a CONFIG switch to make sure that we only compile it when
it is really necessary.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 1 +
hw/misc/Makefile.objs | 2 +-
2 files changed, 2
This device is not user-creatable and currently only used for the
"alpha" target. So if the user does not want to compile alpha-softmmu,
we should also not compile this device. Add a proper config switch to
be able to compile this more flexibly.
Signed-off-by: Thomas Huth
---
On Fri, Oct 19, 2018 at 11:33:06AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
>
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Add a QAuthZList object type that implements the QAuthZ interface. This
> > built-in implementation maintains a trivial
We've got many devices that can not be created directly by the user
and which are only used on some few target architectures. When the
user does not compile the corresponding qemu-softmmu-xxx target, we
should also not compile these devices. Add some CONFIG switches to
make our build system a
If the user only wants to compile targets that do not require the
"split-irq" device, we should also not compile split-irq.c. Add a proper
CONFIG_SPLIT_IRQ switch to be able to choose this more flexibly.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 1 +
hw/core/Makefile.objs
On 10/19/18 7:39 AM, Markus Armbruster wrote:
Commit 97f40301f1d "error: Functions to report warnings and
informational messages" copied the "use error_setg() instead"
admonition from the error reporting functions to new functions even
though it doesn't actually apply there. Drop it. Also drop
On 11 October 2018 at 21:51, Richard Henderson
wrote:
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 736880ee71..d59ffa1c67 100644
> ---
On 11 October 2018 at 21:52, Richard Henderson
wrote:
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.c | 81 ++
> 1 file changed, 26 insertions(+), 55 deletions(-)
> -/* VLD2/3/4 to all lanes: bit 5 indicates register
On 19/10/2018 14:55, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote:
>> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> Add an authorization backend that talks to PAM to check whether the user
>>> identity
On 19/10/2018 14:26, Paolo Bonzini wrote:
> Other people are doing a much better work than myself at handling some
> subsystems. For those files it is better if I downgrade myself to
> reviewer or recognize that I am not actually doing any work there.
>
> Cc: Daniel P. Berrange
> Cc: Gerd
On 19/10/2018 14:53, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 11:41:45AM +0200, Philippe Mathieu-Daudé wrote:
>> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
>>> Add a QAuthZListFile object type that implements the QAuthZ interface. This
>>> built-in implementation is a proxy around
On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote:
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Add an authorization backend that talks to PAM to check whether the user
> > identity is allowed. This only uses the PAM account
On Fri 19 Oct 2018 01:08:52 PM CEST, Daniel P. Berrangé wrote:
> Using 64-bit arithmetic increases the performance for xts-aes-128
> when built with gcrypt:
>
> Encrypt: 272 MB/s -> 355 MB/s
> Decrypt: 275 MB/s -> 362 MB/s
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Alberto Garcia
On 10/19/2018 7:55 AM, Peter Maydell wrote:
On 18 October 2018 at 23:10, Brad Smith wrote:
Use MAP_STACK in qemu_alloc_stack() on OpenBSD.
Added to -current and will be in our soon to be 6.4 release.
MAP_STACK Indicate that the mapping is used as a stack. This
flag
On 19/10/2018 14:41, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 11:57:45AM +0200, Philippe Mathieu-Daudé wrote:
>> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> Add a QAuthZList object type that implements the QAuthZ interface. This
>>> built-in
On Fri, Oct 19, 2018 at 11:41:45AM +0200, Philippe Mathieu-Daudé wrote:
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > Add a QAuthZListFile object type that implements the QAuthZ interface. This
> > built-in implementation is a proxy around the QAtuhZList object type,
> > initializing it
On 2018-10-19 14:26, Paolo Bonzini wrote:
> Other people are doing a much better work than myself at handling some
> subsystems. For those files it is better if I downgrade myself to
> reviewer or recognize that I am not actually doing any work there.
>
> Cc: Daniel P. Berrange
> Cc: Gerd
Use MAP_STACK in qemu_alloc_stack() on OpenBSD.
Added to our 6.4 release.
MAP_STACK Indicate that the mapping is used as a stack. This
flag must be used in combination with MAP_ANON and
MAP_PRIVATE.
Implement MAP_STACK option for mmap(). Synchronous faults
On 10/13/18 8:18 PM, Richard Henderson wrote:
On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
+# Argument sets:
+ rs1 rd
+_dw uimm rs1 rd
+ nzuimm rd
+ rs1 rs2
+_dw uimm rs1 rs2
I guess this is good enough for now.
What I'd like to see is
On Thu, Oct 18, 2018 at 07:53:30PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
>
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > In many cases a single VM will just need to whilelist a single identity
> > as the allowed user of network services. This is especially the case for
> > TLS
On Fri, Oct 19, 2018 at 02:26:13PM +0200, Paolo Bonzini wrote:
> Other people are doing a much better work than myself at handling some
> subsystems. For those files it is better if I downgrade myself to
> reviewer or recognize that I am not actually doing any work there.
>
> Cc: Daniel P.
Commit 97f40301f1d "error: Functions to report warnings and
informational messages" copied the "use error_setg() instead"
admonition from the error reporting functions to new functions even
though it doesn't actually apply there. Drop it. Also drop it from
vreport(), where it doesn't apply
No one is using this function anymore, so we can safely remove it.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block.c | 21 -
include/block/block.h | 1 -
2 files changed, 22 deletions(-)
diff --git a/block.c b/block.c
index
On Fri, Oct 19, 2018 at 11:56:00AM +0200, Philippe Mathieu-Daudé wrote:
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > In many cases a single VM will just need to whilelist a single identity
> > as the allowed user of network services. This is especially the case for
> > TLS live migration
On 19/10/2018 14:37, Thomas Huth wrote:
> The null-machine code used to be target specific since it used the
> target-specific cpu_init() function in the past. But in the recent
> commit 2278b93941d42c30e2950 ("Use cpu_create(type) instead of
> cpu_init(cpu_model)") this has been change, so that
On Fri, Oct 19, 2018 at 11:57:45AM +0200, Philippe Mathieu-Daudé wrote:
> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Add a QAuthZList object type that implements the QAuthZ interface. This
> > built-in implementation maintains a trivial access control
On 19 October 2018 at 12:59, Alex Bennée wrote:
> Isn't this likely due to the newer kernel accessing hardware we are not
> emulating properly?
Yes, it will be the missing cprman emulation. There was another
bug/thread on this recently.
thanks
-- PMM
The null-machine code used to be target specific since it used the
target-specific cpu_init() function in the past. But in the recent
commit 2278b93941d42c30e2950 ("Use cpu_create(type) instead of
cpu_init(cpu_model)") this has been change, so that the code now
uses the common cpu_create()
On 19/10/2018 14:24, Roman Kapl wrote:
> From: Rudolf Marek
>
> Fix the SYSCALL instruction in 64-bit (long mode). The RF flag
> should be cleared in R11 as well as in the RFLAGS. Intel
> and AMD CPUs behave same. AMD has this documented in the
> APM vol 3.
>
> Signed-off-by: Roman Kapl
>
Now that all callers are passing the new options using the QDict we no
longer need the 'flags' parameter.
This patch makes the following changes:
1) The update_options_from_flags() call is no longer necessary
so it can be removed.
2) The update_flags_from_options() call is now used
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block/stream.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff
Other people are doing a much better work than myself at handling some
subsystems. For those files it is better if I downgrade myself to
reviewer or recognize that I am not actually doing any work there.
Cc: Daniel P. Berrange
Cc: Gerd Hoffmann
Cc: Eric Blake
Cc: Thomas Huth
Cc: Laurent
This function takes three options (cache.direct, cache.no-flush and
read-only) from a QemuOpts object and updates the flags accordingly.
If any of those options is not set (because it was missing from the
original QDict or because it had an invalid value) then the function
aborts with a failed
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
blockdev.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/blockdev.c
This patch replaces the bdrv_reopen() call that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
blockdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/blockdev.c
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block/commit.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git
Most callers of bdrv_reopen() only use it to switch a BlockDriverState
between read-only and read-write, so this patch adds a new function
that does just that.
We also want to get rid of the flags parameter in the bdrv_reopen()
API, so this function sets the "read-only" option and passes the
When reopen_f() puts a block device in the reopen queue, some of the
new options are passed using a QDict, but others ("read-only" and the
cache options) are passed as flags.
This patch puts those flags in the QDict. This way the flags parameter
becomes redundant and we'll be able to get rid of
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block/commit.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c
This function is used to put the hidden and secondary disks in
read-write mode before launching the backup job, and back in read-only
mode afterwards.
This patch does the following changes:
- Use an options QDict with the "read-only" option instead of
passing the changes as flags only.
Now that all callers are passing all flag changes as QDict options,
the flags parameter is no longer necessary, so we can get rid of it.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block.c | 5 +++--
block/replication.c | 6 ++
include/block/block.h | 3 +--
Towards the end of bdrv_reopen_queue_child(), before starting to
process the children, the update_flags_from_options() function is
called in order to have BDRVReopenState.flags in sync with the options
from the QDict.
This is necessary because during the reopen process flags must be
updated for
The 'block-commit' QMP command is implemented internally using two
different drivers. If the source image is the active layer then the
mirror driver is used (commit_active_start()), otherwise the commit
driver is used (commit_start()).
In both cases the destination image must be put temporarily
Hi all,
when reopening a BlockDriverState using bdrv_reopen() and friends the
new options can be specified either with a QDict or with flags. Both
methods overlap and that makes the semantics and the implementation
unnecessarily complicated.
This series removes the 'flags' parameter from these
From: Rudolf Marek
Fix the SYSCALL instruction in 64-bit (long mode). The RF flag
should be cleared in R11 as well as in the RFLAGS. Intel
and AMD CPUs behave same. AMD has this documented in the
APM vol 3.
Signed-off-by: Roman Kapl
Signed-off-by: Rudolf Marek
---
target/i386/seg_helper.c |
The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3:
Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-10-19
11:20:05 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git
Le 19/10/2018 à 14:16, Laurent Vivier a écrit :
> The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging
> (2018-10-19 11:20:05 +0100)
>
> are available in the Git
From: Cortland Tölva
In preparation for adding user mode emulation support for the
Linux usbfs interface, check for its kernel header.
Signed-off-by: Cortland Tölva
Reviewed-by: Laurent Vivier
Message-Id: <20181008163521.17341-2-...@tolva.net>
Signed-off-by: Laurent Vivier
---
configure |
From: Cortland Tölva
Userspace submits a USB Request Buffer to the kernel, optionally
discards it, and finally reaps the URB. Thunk buffers from target
to host and back.
Tested by running an i386 scanner driver on ARMv7 and by running
the PowerPC lsusb utility on x86_64. The discardurb ioctl
From: Cortland Tölva
Userspace submits a USB Request Buffer to the kernel, optionally
discards it, and finally reaps the URB. Thunk buffers from target
to host and back.
Tested by running an i386 scanner driver on ARMv7 and by running
the PowerPC lsusb utility on x86_64. The discardurb ioctl
From: Cortland Tölva
Provide ioctl definitions for the generic thunk mechanism to
convert most usbfs calls. Calculate arg size at runtime.
Signed-off-by: Cortland Tölva
Reviewed-by: Laurent Vivier
Message-Id: <20181008163521.17341-3-...@tolva.net>
Signed-off-by: Laurent Vivier
---
From: Cortland Tölva
In preparation for adding user mode emulation support for the
Linux usbfs interface, check for its kernel header.
Signed-off-by: Cortland Tölva
Reviewed-by: Laurent Vivier
Message-Id: <20181008163521.17341-2-...@tolva.net>
Signed-off-by: Laurent Vivier
---
configure |
From: Cortland Tölva
Provide ioctl definitions for the generic thunk mechanism to
convert most usbfs calls. Calculate arg size at runtime.
Signed-off-by: Cortland Tölva
Reviewed-by: Laurent Vivier
Message-Id: <20181008163521.17341-3-...@tolva.net>
Signed-off-by: Laurent Vivier
---
The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3:
Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-10-19
11:20:05 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git
On Fri, Oct 19, 2018 at 02:00:21PM +0200, Paolo Bonzini wrote:
> On 19/10/2018 13:22, Daniel P. Berrangé wrote:
> > Copying Paolo, since this probably falls under the "misc patches"
> > maintainer bucket.
>
> I think we should define a "generic maintainer stuff" bucket where every
> maintainer is
Isn't this likely due to the newer kernel accessing hardware we are not
emulating properly?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1797262
Title:
qemu arm no longer able to boot RPI Kernels
On 19/10/2018 12:25, Daniel P. Berrangé wrote:
> I really don't want to use an application specific templating system.
> While we're using Jekyll for the website today, I don't think it is
> a good idea to assume that for the longer term.
>
> Even today I can't actually run the jekyll website on
On 19/10/2018 12:13, Marc-André Lureau wrote:
> Thanks Valgrind:
>
> ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321
> ==955==at 0x483A965: realloc (vg_replace_malloc.c:785)
> ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so)
> ==955==by
Hi Richard,
On 17/10/2018 00:31, Richard Henderson wrote:
> Create struct ARMISARegisters, to be accessed during translation.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.h | 32
> hw/intc/armv7m_nvic.c | 12 +--
> target/arm/cpu.c | 178
On 19/10/2018 13:22, Daniel P. Berrangé wrote:
> Copying Paolo, since this probably falls under the "misc patches"
> maintainer bucket.
I think we should define a "generic maintainer stuff" bucket where every
maintainer is supposed to send patches with a Reviewed-by. Maintainers
are probably
On 19 October 2018 at 11:18, Hongbo Zhang wrote:
> Remove the unused herder files, 'virt' can be compiled and run without
> including them.
>
> Signed-off-by: Hongbo Zhang
> ---
> hw/arm/virt.c | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index
On 30/08/2018 12:57, Daniel P. Berrangé wrote:
> The 'q35' machine type implements an Intel Series 3 chipset,
> of which there are several variants:
>
> https://www.intel.com/Assets/PDF/datasheet/316966.pdf
>
> The key difference between the 82P35 MCH ('p35', PCI device ID 0x29c0)
> and 82Q35
On 18 October 2018 at 23:10, Brad Smith wrote:
> Use MAP_STACK in qemu_alloc_stack() on OpenBSD.
>
> Added to -current and will be in our soon to be 6.4 release.
>
> MAP_STACK Indicate that the mapping is used as a stack. This
>flag must be used in combination with MAP_ANON
On 19/10/2018 12:50, Li Qiang wrote:
> Signed-off-by: Li Qiang
> ---
> hw/usb/ccid-card-emulated.c | 20 ++--
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
> index b356edb..25976ed 100644
> ---
On 19/10/2018 13:04, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote:
>> On 09/10/2018 15:04, Daniel P. Berrangé wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> Add an authorization backend that talks to PAM to check whether the user
>>> identity
On 19/10/2018 12:43, Alex Bennée wrote:
> The purpose of the code is to use the designated compiler for building
> the targets test cases. This is not actually host_cc which will still
> be cc even when we are cross compiling. As the tests for $cpu all use
> $cc we should do the same.
>
>
They are not consecutive with DAC1_FRAME* and DAC2_FRAME*; Coverity
still complains about es1370_read, while es1370_write was fixed in
commit cf9270e5220671f49cc238deaf6136669cc07ae1.
Fixes: 154c1d1f960c5147a3f8ef00907504112f271cd8
Signed-off-by: Paolo Bonzini
---
hw/audio/es1370.c | 10
The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18
13:40:19 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git
On 18 October 2018 at 20:00, Laurent Vivier wrote:
> The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6:
>
> Merge remote-tracking branch
> 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18
> 13:40:19 +0100)
>
> are available in the Git
On 2018-10-19 12:43, Alex Bennée wrote:
> The purpose of the code is to use the designated compiler for building
> the targets test cases. This is not actually host_cc which will still
> be cc even when we are cross compiling. As the tests for $cpu all use
> $cc we should do the same.
>
>
Hi Aleksandar,
On Thu, Oct 18, 2018 at 9:20 PM Aleksandar Markovic
wrote:
>
> From: Philippe Mathieu-Daudé
>
> Increase the size of insn_flags holder size to 64 bits. This is
> needed for future extensions since existing bits are almost all used.
>
Why did you remove my S-o-b tag...?
>
On Thu, Oct 18, 2018 at 01:13:51PM -0700, Kees Cook wrote:
> I spent way too much time trying to figure out why the emulated NVDIMM
> was missing under Linux. In an effort to help others who might be looking
> for these kinds of things in the future, include a hint.
>
> Signed-off-by: Kees Cook
On 19/10/2018 11:03, Peter Maydell wrote:
> On 18 October 2018 at 21:31, Paolo Bonzini wrote:
>> The exception.pad field is going to be renamed to pending in an upcoming
>> header file update. Remove the unnecessary initialization; it was
>> introduced to please valgrind (commit 7e680753cfa2)
On 19/10/2018 10:46, Thomas Huth wrote:
>>
> It's in a pull request already, so this is likely too late: But for the
> next time, could you maybe rather use a "/* fall through */" comment
> instead of a goto? That looks less ugly.
Wait, it's not ugly, it's wrong. The label is placed incorrectly.
On Fri, Oct 19, 2018 at 01:34:58AM +0300, Julia Suvorova wrote:
> v3:
> * Refactoring moved to a separate patch [Daniel]
> * "websock" option renamed to "websocket" [Stefan]
> * Added documentation [Daniel]
> v2:
> * Fixed initialization order [Daniel]
> * Function arguments
On 19/10/2018 13:25, Daniel P. Berrangé wrote:
> Paolo, I think this is a patch for your misc patches queue.
It looks to me than this is more block/trivial than the busy misc queue.
>
> On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote:
>> The sheepdog mailing list is setup to
From: Jeff Cody
This adds configure options to control the following block drivers:
* Bochs
* Cloop
* Dmg
* Qcow (V1)
* Vdi
* Vvfat
* qed
* parallels
* sheepdog
Each of these defaults to being enabled.
Signed-off-by: Jeff Cody
Signed-off-by: Markus Armbruster
---
Hmm, we got quite a few
Paolo, I think this is a patch for your misc patches queue.
On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote:
> The sheepdog mailing list is setup to stop and queue messages from
> non-subscribers, pending moderator approval. Unfortunately it seems
> that the moderation queue is
Copying Paolo, since this probably falls under the "misc patches"
maintainer bucket.
On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote:
> In some cases the Author: email address in patches submitted to the
> list gets mangled such that it says
>
> John Doe via Qemu-devel
>
Mao Zhongyi writes:
> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
>
> Cc: alex.ben...@linaro.org
> Cc: f...@redhat.com
> Cc: phi...@redhat.com
>
> Signed-off-by: Mao Zhongyi
Reviewed-by: Alex Bennée
Adds a new CPU flag to enable the Enlightened VMCS KVM feature.
QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the
version to be advertised in lower 16 bits of CPUID.0x400A:EAX.
Suggested-by: Ladi Prosek
Signed-off-by: Vitaly Kuznetsov
---
target/i386/cpu.c | 1 +
On 19/10/2018 13:00, Thomas Huth wrote:
> The migration test for s390x sometimes hangs when running with TCG,
> similar to the problems that we have already observed with TCG for
> the ppc64 guests. Thus disable the s390x test when we are not running
> with KVM for now until the problem with TCG
Ping - it has 2 reviews, but never made it into the i386 maintainers
tree / pull request. Can someone queue this patch for merge.
On Thu, Aug 30, 2018 at 11:57:57AM +0100, Daniel P. Berrangé wrote:
> The 'q35' machine type implements an Intel Series 3 chipset,
> of which there are several
Update to kvm/next commit 1e58e5e59148 ("KVM: VMX: enable nested
virtualization by default").
kvm_put_vcpu_events() needs to be fixed as 'pad' was renamed to
'pending' in 'struct kvm_vcpu_events'
Signed-off-by: Vitaly Kuznetsov
---
linux-headers/asm-powerpc/kvm.h | 1 +
Hyper-V Enlightened VMCS feature was merged to KVM, enable it in Qemu.
The feature gives us a significant performance boost for Hyper-V on KVM
deployments.
The first patch of the series is posted for completeness only.
Vitaly Kuznetsov (2):
linux-headers: update
x86: hv_evmcs CPU flag
The current XTS test overloads two different tests in a single function
making the code a little hard to follow. Split it into distinct test
cases.
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrangé
---
tests/test-crypto-xts.c | 140 +++-
1 file
Validate that the XTS cipher mode will correctly operate with plain
text, cipher text and IV buffers that are not 64-bit aligned.
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrangé
---
tests/test-crypto-xts.c | 86 +
1 file changed, 86
The tweak encrypt/decrypt functions are identical except for the
comments, so can be merged. Profiling data shows that the compiler is
in fact already merging the two merges in the object files.
Reviewed-by: Marc-André Lureau
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrangé
---
Add testing coverage for AES with XTS, ECB and CTR modes
Reviewed-by: Marc-André Lureau
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrangé
---
tests/benchmark-crypto-cipher.c | 149 +++-
1 file changed, 126 insertions(+), 23 deletions(-)
diff --git
Using 64-bit arithmetic increases the performance for xts-aes-128
when built with gcrypt:
Encrypt: 272 MB/s -> 355 MB/s
Decrypt: 275 MB/s -> 362 MB/s
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 84
1 file changed, 58
201 - 300 of 408 matches
Mail list logo