[Qemu-devel] [PATCH v6 01/11] util: add helper APIs for dealing with inotify in portable manner

2018-10-19 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Wrapping it also allows introduction of a platform portability layer, so that we can add impls for non-Linux based equivalents in

[Qemu-devel] [PATCH v6 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver

2018-10-19 Thread Daniel P . Berrangé
IN_ISDIR is not a bit that one can request when registering a watch with inotify_add_watch. Rather it is a bit that is set automatically when reading events from the kernel. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c | 3 +-- 1 file changed, 1

[Qemu-devel] [PATCH v6 00/11] Add a standard authorization framework

2018-10-19 Thread Daniel P . Berrangé
An update to v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05660.html v4: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02961.html v5:

[Qemu-devel] [PATCH v6 02/11] qom: don't require user creatable objects to be registered

2018-10-19 Thread Daniel P . Berrangé
When an object is in turn owned by another user object, it is not desirable to expose this in the QOM object hierarchy, as it is just an internal implementation detail, we should be free to change without exposure. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v7 0/7] target/mips: Limited support for the R5900

2018-10-19 Thread Laurent Vivier
Le 15/10/2018 à 14:16, Aleksandar Markovic a écrit : >> From: Fredrik Noring >> Sent: Saturday, October 13, 2018 1:09 PM >> To: Aleksandar Markovic; Maciej W. Rozycki; Philippe Mathieu-Daudé >> Cc: Richard Henderson; Aurelien Jarno; Petar Jovanovic; Peter Maydell; >> Jürgen Urban; >

Re: [Qemu-devel] [PATCH] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems

2018-10-19 Thread Eric Blake
On 10/19/18 7:26 AM, Paolo Bonzini wrote: Other people are doing a much better work than myself at handling some subsystems. For those files it is better if I downgrade myself to reviewer or recognize that I am not actually doing any work there. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc:

Re: [Qemu-devel] [PATCH 16/28] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2018-10-19 Thread Bastian Koppelmann
On 10/13/18 8:53 PM, Richard Henderson wrote: Choose return false or raise exception. Except... I wonder if we might write this as int shamt = a->shamt; if (shamt == 0) { shamt = 64; } Good catch. I'll add a comment, that a shamt of 0 is intended for RV128.

[Qemu-devel] [PATCH 3/5] configs: Add a CONFIG_REGISTER switch for the "register" device

2018-10-19 Thread Thomas Huth
If the user only wants to compile targets that do not require the "register" device, we should also not compile register.c. Add a proper CONFIG_REGISTER switch to be able to choose this more flexibly. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak| 1 +

[Qemu-devel] [PATCH 1/5] configs: Add a CONFIG_OR_IRQ switch for the or-irq device

2018-10-19 Thread Thomas Huth
If the user only wants to compile targets that do not require the "or-irq" device, we should also not compile or-irq.c. Add a proper CONFIG_OR_IRQ switch to be able to choose this more flexibly. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 1 +

[Qemu-devel] [PATCH 4/5] configs: Add a CONFIG_UNIMP switch for the "unimplemented-device"

2018-10-19 Thread Thomas Huth
The "unimplemented-device" is currently only used for one arm board. Let's add a CONFIG switch to make sure that we only compile it when it is really necessary. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 1 + hw/misc/Makefile.objs | 2 +- 2 files changed, 2

[Qemu-devel] [PATCH 5/5] configs: Add a CONFIG_SMC37C669 switch for the "smc37c669-superio" device

2018-10-19 Thread Thomas Huth
This device is not user-creatable and currently only used for the "alpha" target. So if the user does not want to compile alpha-softmmu, we should also not compile this device. Add a proper config switch to be able to compile this more flexibly. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 11:33:06AM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add a QAuthZList object type that implements the QAuthZ interface. This > > built-in implementation maintains a trivial

[Qemu-devel] [PATCH 0/5] Add more CONFIG switches to make the build more modular

2018-10-19 Thread Thomas Huth
We've got many devices that can not be created directly by the user and which are only used on some few target architectures. When the user does not compile the corresponding qemu-softmmu-xxx target, we should also not compile these devices. Add some CONFIG switches to make our build system a

[Qemu-devel] [PATCH 2/5] configs: Add a CONFIG_SPLIT_IRQ switch for the split-irq device

2018-10-19 Thread Thomas Huth
If the user only wants to compile targets that do not require the "split-irq" device, we should also not compile split-irq.c. Add a proper CONFIG_SPLIT_IRQ switch to be able to choose this more flexibly. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 1 + hw/core/Makefile.objs

Re: [Qemu-devel] [PATCH] error: Drop bogus "use error_setg() instead" admonitions

2018-10-19 Thread Eric Blake
On 10/19/18 7:39 AM, Markus Armbruster wrote: Commit 97f40301f1d "error: Functions to report warnings and informational messages" copied the "use error_setg() instead" admonition from the error reporting functions to new functions even though it doesn't actually apply there. Drop it. Also drop

Re: [Qemu-devel] [PATCH 05/20] target/arm: Mark some arrays const

2018-10-19 Thread Peter Maydell
On 11 October 2018 at 21:51, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/translate.c > index 736880ee71..d59ffa1c67 100644 > ---

Re: [Qemu-devel] [PATCH 17/20] target/arm: Use gvec for NEON VLD all lanes

2018-10-19 Thread Peter Maydell
On 11 October 2018 at 21:52, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 81 ++ > 1 file changed, 26 insertions(+), 55 deletions(-) > -/* VLD2/3/4 to all lanes: bit 5 indicates register

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 14:55, Daniel P. Berrangé wrote: > On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote: >> On 09/10/2018 15:04, Daniel P. Berrangé wrote: >>> From: "Daniel P. Berrange" >>> >>> Add an authorization backend that talks to PAM to check whether the user >>> identity

Re: [Qemu-devel] [PATCH] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems

2018-10-19 Thread Laurent Vivier
On 19/10/2018 14:26, Paolo Bonzini wrote: > Other people are doing a much better work than myself at handling some > subsystems. For those files it is better if I downgrade myself to > reviewer or recognize that I am not actually doing any work there. > > Cc: Daniel P. Berrange > Cc: Gerd

Re: [Qemu-devel] [PATCH v5 09/11] authz: add QAuthZListFile object type for a file access control list

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 14:53, Daniel P. Berrangé wrote: > On Fri, Oct 19, 2018 at 11:41:45AM +0200, Philippe Mathieu-Daudé wrote: >> On 09/10/2018 15:04, Daniel P. Berrangé wrote: >>> Add a QAuthZListFile object type that implements the QAuthZ interface. This >>> built-in implementation is a proxy around

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote: > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add an authorization backend that talks to PAM to check whether the user > > identity is allowed. This only uses the PAM account

Re: [Qemu-devel] [PATCH v3 4/8] crypto: convert xts_tweak_encdec to use xts_uint128 type

2018-10-19 Thread Alberto Garcia
On Fri 19 Oct 2018 01:08:52 PM CEST, Daniel P. Berrangé wrote: > Using 64-bit arithmetic increases the performance for xts-aes-128 > when built with gcrypt: > > Encrypt: 272 MB/s -> 355 MB/s > Decrypt: 275 MB/s -> 362 MB/s > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alberto Garcia

Re: [Qemu-devel] [PATCH v2] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Brad Smith
On 10/19/2018 7:55 AM, Peter Maydell wrote: On 18 October 2018 at 23:10, Brad Smith wrote: Use MAP_STACK in qemu_alloc_stack() on OpenBSD. Added to -current and will be in our soon to be 6.4 release. MAP_STACK Indicate that the mapping is used as a stack. This flag

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 14:41, Daniel P. Berrangé wrote: > On Fri, Oct 19, 2018 at 11:57:45AM +0200, Philippe Mathieu-Daudé wrote: >> On 09/10/2018 15:04, Daniel P. Berrangé wrote: >>> From: "Daniel P. Berrange" >>> >>> Add a QAuthZList object type that implements the QAuthZ interface. This >>> built-in

Re: [Qemu-devel] [PATCH v5 09/11] authz: add QAuthZListFile object type for a file access control list

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 11:41:45AM +0200, Philippe Mathieu-Daudé wrote: > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > Add a QAuthZListFile object type that implements the QAuthZ interface. This > > built-in implementation is a proxy around the QAtuhZList object type, > > initializing it

Re: [Qemu-devel] [PATCH] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems

2018-10-19 Thread Thomas Huth
On 2018-10-19 14:26, Paolo Bonzini wrote: > Other people are doing a much better work than myself at handling some > subsystems. For those files it is better if I downgrade myself to > reviewer or recognize that I am not actually doing any work there. > > Cc: Daniel P. Berrange > Cc: Gerd

[Qemu-devel] [PATCH v3] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Brad Smith
Use MAP_STACK in qemu_alloc_stack() on OpenBSD. Added to our 6.4 release. MAP_STACK Indicate that the mapping is used as a stack. This flag must be used in combination with MAP_ANON and MAP_PRIVATE. Implement MAP_STACK option for mmap(). Synchronous faults

Re: [Qemu-devel] [PATCH 15/28] target/riscv: Convert quadrant 0 of RVXC insns to decodetree

2018-10-19 Thread Bastian Koppelmann
On 10/13/18 8:18 PM, Richard Henderson wrote: On 10/12/18 10:30 AM, Bastian Koppelmann wrote: +# Argument sets: + rs1 rd +_dw uimm rs1 rd + nzuimm rd + rs1 rs2 +_dw uimm rs1 rs2 I guess this is good enough for now. What I'd like to see is

Re: [Qemu-devel] [PATCH v5 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2018-10-19 Thread Daniel P . Berrangé
On Thu, Oct 18, 2018 at 07:53:30PM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > In many cases a single VM will just need to whilelist a single identity > > as the allowed user of network services. This is especially the case for > > TLS

Re: [Qemu-devel] [PATCH] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 02:26:13PM +0200, Paolo Bonzini wrote: > Other people are doing a much better work than myself at handling some > subsystems. For those files it is better if I downgrade myself to > reviewer or recognize that I am not actually doing any work there. > > Cc: Daniel P.

[Qemu-devel] [PATCH] error: Drop bogus "use error_setg() instead" admonitions

2018-10-19 Thread Markus Armbruster
Commit 97f40301f1d "error: Functions to report warnings and informational messages" copied the "use error_setg() instead" admonition from the error reporting functions to new functions even though it doesn't actually apply there. Drop it. Also drop it from vreport(), where it doesn't apply

[Qemu-devel] [PATCH v3 09/15] block: Drop bdrv_reopen()

2018-10-19 Thread Alberto Garcia
No one is using this function anymore, so we can safely remove it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 21 - include/block/block.h | 1 - 2 files changed, 22 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH v5 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 11:56:00AM +0200, Philippe Mathieu-Daudé wrote: > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > In many cases a single VM will just need to whilelist a single identity > > as the allowed user of network services. This is especially the case for > > TLS live migration

Re: [Qemu-devel] [PATCH] hw/core: Move null-machine into the common-obj list

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 14:37, Thomas Huth wrote: > The null-machine code used to be target specific since it used the > target-specific cpu_init() function in the past. But in the recent > commit 2278b93941d42c30e2950 ("Use cpu_create(type) instead of > cpu_init(cpu_model)") this has been change, so that

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 11:57:45AM +0200, Philippe Mathieu-Daudé wrote: > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add a QAuthZList object type that implements the QAuthZ interface. This > > built-in implementation maintains a trivial access control

Re: [Qemu-devel] [Bug 1797262] Re: qemu arm no longer able to boot RPI Kernels

2018-10-19 Thread Peter Maydell
On 19 October 2018 at 12:59, Alex Bennée wrote: > Isn't this likely due to the newer kernel accessing hardware we are not > emulating properly? Yes, it will be the missing cprman emulation. There was another bug/thread on this recently. thanks -- PMM

[Qemu-devel] [PATCH] hw/core: Move null-machine into the common-obj list

2018-10-19 Thread Thomas Huth
The null-machine code used to be target specific since it used the target-specific cpu_init() function in the past. But in the recent commit 2278b93941d42c30e2950 ("Use cpu_create(type) instead of cpu_init(cpu_model)") this has been change, so that the code now uses the common cpu_create()

Re: [Qemu-devel] [PATCH] Clear RF on SYSCALL instruction

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 14:24, Roman Kapl wrote: > From: Rudolf Marek > > Fix the SYSCALL instruction in 64-bit (long mode). The RF flag > should be cleared in R11 as well as in the RFLAGS. Intel > and AMD CPUs behave same. AMD has this documented in the > APM vol 3. > > Signed-off-by: Roman Kapl >

[Qemu-devel] [PATCH v3 13/15] block: Stop passing flags to bdrv_reopen_queue_child()

2018-10-19 Thread Alberto Garcia
Now that all callers are passing the new options using the QDict we no longer need the 'flags' parameter. This patch makes the following changes: 1) The update_options_from_flags() call is no longer necessary so it can be removed. 2) The update_flags_from_options() call is now used

[Qemu-devel] [PATCH v3 05/15] block: Use bdrv_reopen_set_read_only() in stream_start/complete()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/stream.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[Qemu-devel] [PATCH] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems

2018-10-19 Thread Paolo Bonzini
Other people are doing a much better work than myself at handling some subsystems. For those files it is better if I downgrade myself to reviewer or recognize that I am not actually doing any work there. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Eric Blake Cc: Thomas Huth Cc: Laurent

[Qemu-devel] [PATCH v3 14/15] block: Remove assertions from update_flags_from_options()

2018-10-19 Thread Alberto Garcia
This function takes three options (cache.direct, cache.no-flush and read-only) from a QemuOpts object and updates the flags accordingly. If any of those options is not set (because it was missing from the original QDict or because it had an invalid value) then the function aborts with a failed

[Qemu-devel] [PATCH v3 06/15] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH v3 07/15] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() call that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH v3 03/15] block: Use bdrv_reopen_set_read_only() in commit_start/complete()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH v3 01/15] block: Add bdrv_reopen_set_read_only()

2018-10-19 Thread Alberto Garcia
Most callers of bdrv_reopen() only use it to switch a BlockDriverState between read-only and read-write, so this patch adds a new function that does just that. We also want to get rid of the flags parameter in the bdrv_reopen() API, so this function sets the "read-only" option and passes the

[Qemu-devel] [PATCH v3 10/15] qemu-io: Put flag changes in the options QDict in reopen_f()

2018-10-19 Thread Alberto Garcia
When reopen_f() puts a block device in the reopen queue, some of the new options are passed using a QDict, but others ("read-only" and the cache options) are passed as flags. This patch puts those flags in the QDict. This way the flags parameter becomes redundant and we'll be able to get rid of

[Qemu-devel] [PATCH v3 04/15] block: Use bdrv_reopen_set_read_only() in bdrv_commit()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v3 02/15] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()

2018-10-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH v3 11/15] block: Clean up reopen_backing_file() in block/replication.c

2018-10-19 Thread Alberto Garcia
This function is used to put the hidden and secondary disks in read-write mode before launching the backup job, and back in read-only mode afterwards. This patch does the following changes: - Use an options QDict with the "read-only" option instead of passing the changes as flags only.

[Qemu-devel] [PATCH v3 12/15] block: Remove flags parameter from bdrv_reopen_queue()

2018-10-19 Thread Alberto Garcia
Now that all callers are passing all flag changes as QDict options, the flags parameter is no longer necessary, so we can get rid of it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 5 +++-- block/replication.c | 6 ++ include/block/block.h | 3 +--

[Qemu-devel] [PATCH v3 15/15] block: Assert that flags are up-to-date in bdrv_reopen_prepare()

2018-10-19 Thread Alberto Garcia
Towards the end of bdrv_reopen_queue_child(), before starting to process the children, the update_flags_from_options() function is called in order to have BDRVReopenState.flags in sync with the options from the QDict. This is necessary because during the reopen process flags must be updated for

[Qemu-devel] [PATCH v3 08/15] block: Use bdrv_reopen_set_read_only() in the mirror driver

2018-10-19 Thread Alberto Garcia
The 'block-commit' QMP command is implemented internally using two different drivers. If the source image is the active layer then the mirror driver is used (commit_active_start()), otherwise the commit driver is used (commit_start()). In both cases the destination image must be put temporarily

[Qemu-devel] [PATCH v3 00/15] Don't pass flags to bdrv_reopen_queue()

2018-10-19 Thread Alberto Garcia
Hi all, when reopening a BlockDriverState using bdrv_reopen() and friends the new options can be specified either with a QDict or with flags. Both methods overlap and that makes the semantics and the implementation unnecessarily complicated. This series removes the 'flags' parameter from these

[Qemu-devel] [PATCH] Clear RF on SYSCALL instruction

2018-10-19 Thread Roman Kapl
From: Rudolf Marek Fix the SYSCALL instruction in 64-bit (long mode). The RF flag should be cleared in R11 as well as in the RFLAGS. Intel and AMD CPUs behave same. AMD has this documented in the APM vol 3. Signed-off-by: Roman Kapl Signed-off-by: Rudolf Marek --- target/i386/seg_helper.c |

[Qemu-devel] [PULL 0/3] Linux user for 3.1 patches

2018-10-19 Thread Laurent Vivier
The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-10-19 11:20:05 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

Re: [Qemu-devel] [2 0/3] Linux user for 3.1 patches

2018-10-19 Thread Laurent Vivier
Le 19/10/2018 à 14:16, Laurent Vivier a écrit : > The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging > (2018-10-19 11:20:05 +0100) > > are available in the Git

[Qemu-devel] [PULL 1/3] linux-user: Check for Linux USBFS in configure

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva In preparation for adding user mode emulation support for the Linux usbfs interface, check for its kernel header. Signed-off-by: Cortland Tölva Reviewed-by: Laurent Vivier Message-Id: <20181008163521.17341-2-...@tolva.net> Signed-off-by: Laurent Vivier --- configure |

[Qemu-devel] [2 3/3] linux-user: Implement special usbfs ioctls.

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva Userspace submits a USB Request Buffer to the kernel, optionally discards it, and finally reaps the URB. Thunk buffers from target to host and back. Tested by running an i386 scanner driver on ARMv7 and by running the PowerPC lsusb utility on x86_64. The discardurb ioctl

[Qemu-devel] [PULL 3/3] linux-user: Implement special usbfs ioctls.

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva Userspace submits a USB Request Buffer to the kernel, optionally discards it, and finally reaps the URB. Thunk buffers from target to host and back. Tested by running an i386 scanner driver on ARMv7 and by running the PowerPC lsusb utility on x86_64. The discardurb ioctl

[Qemu-devel] [PULL 2/3] linux-user: Define ordinary usbfs ioctls.

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva Provide ioctl definitions for the generic thunk mechanism to convert most usbfs calls. Calculate arg size at runtime. Signed-off-by: Cortland Tölva Reviewed-by: Laurent Vivier Message-Id: <20181008163521.17341-3-...@tolva.net> Signed-off-by: Laurent Vivier ---

[Qemu-devel] [2 1/3] linux-user: Check for Linux USBFS in configure

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva In preparation for adding user mode emulation support for the Linux usbfs interface, check for its kernel header. Signed-off-by: Cortland Tölva Reviewed-by: Laurent Vivier Message-Id: <20181008163521.17341-2-...@tolva.net> Signed-off-by: Laurent Vivier --- configure |

[Qemu-devel] [2 2/3] linux-user: Define ordinary usbfs ioctls.

2018-10-19 Thread Laurent Vivier
From: Cortland Tölva Provide ioctl definitions for the generic thunk mechanism to convert most usbfs calls. Calculate arg size at runtime. Signed-off-by: Cortland Tölva Reviewed-by: Laurent Vivier Message-Id: <20181008163521.17341-3-...@tolva.net> Signed-off-by: Laurent Vivier ---

[Qemu-devel] [2 0/3] Linux user for 3.1 patches

2018-10-19 Thread Laurent Vivier
The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-10-19 11:20:05 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 02:00:21PM +0200, Paolo Bonzini wrote: > On 19/10/2018 13:22, Daniel P. Berrangé wrote: > > Copying Paolo, since this probably falls under the "misc patches" > > maintainer bucket. > > I think we should define a "generic maintainer stuff" bucket where every > maintainer is

[Qemu-devel] [Bug 1797262] Re: qemu arm no longer able to boot RPI Kernels

2018-10-19 Thread Alex Bennée
Isn't this likely due to the newer kernel accessing hardware we are not emulating properly? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1797262 Title: qemu arm no longer able to boot RPI Kernels

Re: [Qemu-devel] [web PATCH 0/4] Add web section reporting information about CVEs in QEMU

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 12:25, Daniel P. Berrangé wrote: > I really don't want to use an application specific templating system. > While we're using Jekyll for the website today, I don't think it is > a good idea to assume that for the longer term. > > Even today I can't actually run the jekyll website on

Re: [Qemu-devel] [PATCH] websock: fix handshake leak

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:13, Marc-André Lureau wrote: > Thanks Valgrind: > > ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321 > ==955==at 0x483A965: realloc (vg_replace_malloc.c:785) > ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so) > ==955==by

Re: [Qemu-devel] [PATCH v4 1/8] target/arm: Move some system registers into a substructure

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Richard, On 17/10/2018 00:31, Richard Henderson wrote: > Create struct ARMISARegisters, to be accessed during translation. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 32 > hw/intc/armv7m_nvic.c | 12 +-- > target/arm/cpu.c | 178

Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 13:22, Daniel P. Berrangé wrote: > Copying Paolo, since this probably falls under the "misc patches" > maintainer bucket. I think we should define a "generic maintainer stuff" bucket where every maintainer is supposed to send patches with a Reviewed-by. Maintainers are probably

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-19 Thread Peter Maydell
On 19 October 2018 at 11:18, Hongbo Zhang wrote: > Remove the unused herder files, 'virt' can be compiled and run without > including them. > > Signed-off-by: Hongbo Zhang > --- > hw/arm/virt.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index

Re: [Qemu-devel] [PATCH] i386: clarify that the Q35 machine type implements a P35 chipset

2018-10-19 Thread Paolo Bonzini
On 30/08/2018 12:57, Daniel P. Berrangé wrote: > The 'q35' machine type implements an Intel Series 3 chipset, > of which there are several variants: > > https://www.intel.com/Assets/PDF/datasheet/316966.pdf > > The key difference between the 82P35 MCH ('p35', PCI device ID 0x29c0) > and 82Q35

Re: [Qemu-devel] [PATCH v2] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 23:10, Brad Smith wrote: > Use MAP_STACK in qemu_alloc_stack() on OpenBSD. > > Added to -current and will be in our soon to be 6.4 release. > > MAP_STACK Indicate that the mapping is used as a stack. This >flag must be used in combination with MAP_ANON

Re: [Qemu-devel] [PATCH 2/2] hw: ccid-card-emulated: cleanup resource when realize in error path

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:50, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > hw/usb/ccid-card-emulated.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c > index b356edb..25976ed 100644 > ---

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 13:04, Daniel P. Berrangé wrote: > On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote: >> On 09/10/2018 15:04, Daniel P. Berrangé wrote: >>> From: "Daniel P. Berrange" >>> >>> Add an authorization backend that talks to PAM to check whether the user >>> identity

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > >

[Qemu-devel] [PULL 01/47] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT

2018-10-19 Thread Paolo Bonzini
They are not consecutive with DAC1_FRAME* and DAC2_FRAME*; Coverity still complains about es1370_read, while es1370_write was fixed in commit cf9270e5220671f49cc238deaf6136669cc07ae1. Fixes: 154c1d1f960c5147a3f8ef00907504112f271cd8 Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 10

[Qemu-devel] [PULL v3 00/47] Miscellaneous patches for 2018-10-18

2018-10-19 Thread Paolo Bonzini
The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 13:40:19 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [2 0/2] Linux user for 3.1 patches

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 20:00, Laurent Vivier wrote: > The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 > 13:40:19 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Thomas Huth
On 2018-10-19 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > >

Re: [Qemu-devel] [PULL v2 14/28] target/mips: Increase 'supported ISAs/ASEs' flag holder size

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On Thu, Oct 18, 2018 at 9:20 PM Aleksandar Markovic wrote: > > From: Philippe Mathieu-Daudé > > Increase the size of insn_flags holder size to 64 bits. This is > needed for future extensions since existing bits are almost all used. > Why did you remove my S-o-b tag...? >

Re: [Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name

2018-10-19 Thread Stefan Hajnoczi
On Thu, Oct 18, 2018 at 01:13:51PM -0700, Kees Cook wrote: > I spent way too much time trying to figure out why the emulated NVDIMM > was missing under Linux. In an effort to help others who might be looking > for these kinds of things in the future, include a hint. > > Signed-off-by: Kees Cook

Re: [Qemu-devel] [PULL 06/48] target-i386: kvm: do not initialize padding fields

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 11:03, Peter Maydell wrote: > On 18 October 2018 at 21:31, Paolo Bonzini wrote: >> The exception.pad field is going to be renamed to pending in an upcoming >> header file update. Remove the unnecessary initialization; it was >> introduced to please valgrind (commit 7e680753cfa2)

Re: [Qemu-devel] [PATCH] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 10:46, Thomas Huth wrote: >> > It's in a pull request already, so this is likely too late: But for the > next time, could you maybe rather use a "/* fall through */" comment > instead of a goto? That looks less ugly. Wait, it's not ugly, it's wrong. The label is placed incorrectly.

Re: [Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support

2018-10-19 Thread Stefan Hajnoczi
On Fri, Oct 19, 2018 at 01:34:58AM +0300, Julia Suvorova wrote: > v3: > * Refactoring moved to a separate patch [Daniel] > * "websock" option renamed to "websocket" [Stefan] > * Added documentation [Daniel] > v2: > * Fixed initialization order [Daniel] > * Function arguments

Re: [Qemu-devel] [PATCH] block: drop moderated sheepdog mailing list from MAINTAINERS file

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 13:25, Daniel P. Berrangé wrote: > Paolo, I think this is a patch for your misc patches queue. It looks to me than this is more block/trivial than the busy misc queue. > > On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote: >> The sheepdog mailing list is setup to

[Qemu-devel] [PATCH] block: Make more block drivers compile-time configurable

2018-10-19 Thread Markus Armbruster
From: Jeff Cody This adds configure options to control the following block drivers: * Bochs * Cloop * Dmg * Qcow (V1) * Vdi * Vvfat * qed * parallels * sheepdog Each of these defaults to being enabled. Signed-off-by: Jeff Cody Signed-off-by: Markus Armbruster --- Hmm, we got quite a few

Re: [Qemu-devel] [PATCH] block: drop moderated sheepdog mailing list from MAINTAINERS file

2018-10-19 Thread Daniel P . Berrangé
Paolo, I think this is a patch for your misc patches queue. On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote: > The sheepdog mailing list is setup to stop and queue messages from > non-subscribers, pending moderator approval. Unfortunately it seems > that the moderation queue is

Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list

2018-10-19 Thread Daniel P . Berrangé
Copying Paolo, since this probably falls under the "misc patches" maintainer bucket. On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote: > In some cases the Author: email address in patches submitted to the > list gets mangled such that it says > > John Doe via Qemu-devel >

Re: [Qemu-devel] [PATCH 2/3] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)

2018-10-19 Thread Alex Bennée
Mao Zhongyi writes: > Various shell files contain a mix between obsolete `` > and modern $(); It would be nice to convert to using $() > everywhere. > > Cc: alex.ben...@linaro.org > Cc: f...@redhat.com > Cc: phi...@redhat.com > > Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée

[Qemu-devel] [PATCH 2/2] x86: hv_evmcs CPU flag support

2018-10-19 Thread Vitaly Kuznetsov
Adds a new CPU flag to enable the Enlightened VMCS KVM feature. QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the version to be advertised in lower 16 bits of CPUID.0x400A:EAX. Suggested-by: Ladi Prosek Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 1 +

Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG

2018-10-19 Thread Laurent Vivier
On 19/10/2018 13:00, Thomas Huth wrote: > The migration test for s390x sometimes hangs when running with TCG, > similar to the problems that we have already observed with TCG for > the ppc64 guests. Thus disable the s390x test when we are not running > with KVM for now until the problem with TCG

Re: [Qemu-devel] [PATCH] i386: clarify that the Q35 machine type implements a P35 chipset

2018-10-19 Thread Daniel P . Berrangé
Ping - it has 2 reviews, but never made it into the i386 maintainers tree / pull request. Can someone queue this patch for merge. On Thu, Aug 30, 2018 at 11:57:57AM +0100, Daniel P. Berrangé wrote: > The 'q35' machine type implements an Intel Series 3 chipset, > of which there are several

[Qemu-devel] [PATCH 1/2] linux-headers: update

2018-10-19 Thread Vitaly Kuznetsov
Update to kvm/next commit 1e58e5e59148 ("KVM: VMX: enable nested virtualization by default"). kvm_put_vcpu_events() needs to be fixed as 'pad' was renamed to 'pending' in 'struct kvm_vcpu_events' Signed-off-by: Vitaly Kuznetsov --- linux-headers/asm-powerpc/kvm.h | 1 +

[Qemu-devel] [PATCH 0/2] i386/kvm: add support for Hyper-V Enlightened VMCS

2018-10-19 Thread Vitaly Kuznetsov
Hyper-V Enlightened VMCS feature was merged to KVM, enable it in Qemu. The feature gives us a significant performance boost for Hyper-V on KVM deployments. The first patch of the series is posted for completeness only. Vitaly Kuznetsov (2): linux-headers: update x86: hv_evmcs CPU flag

[Qemu-devel] [PATCH v3 7/8] crypto: refactor XTS cipher mode test suite

2018-10-19 Thread Daniel P . Berrangé
The current XTS test overloads two different tests in a single function making the code a little hard to follow. Split it into distinct test cases. Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/test-crypto-xts.c | 140 +++- 1 file

[Qemu-devel] [PATCH v3 8/8] crypto: add testing for unaligned buffers with XTS cipher mode

2018-10-19 Thread Daniel P . Berrangé
Validate that the XTS cipher mode will correctly operate with plain text, cipher text and IV buffers that are not 64-bit aligned. Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/test-crypto-xts.c | 86 + 1 file changed, 86

[Qemu-devel] [PATCH v3 2/8] crypto: remove code duplication in tweak encrypt/decrypt

2018-10-19 Thread Daniel P . Berrangé
The tweak encrypt/decrypt functions are identical except for the comments, so can be merged. Profiling data shows that the compiler is in fact already merging the two merges in the object files. Reviewed-by: Marc-André Lureau Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé ---

[Qemu-devel] [PATCH v3 1/8] crypto: expand algorithm coverage for cipher benchmark

2018-10-19 Thread Daniel P . Berrangé
Add testing coverage for AES with XTS, ECB and CTR modes Reviewed-by: Marc-André Lureau Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-cipher.c | 149 +++- 1 file changed, 126 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH v3 4/8] crypto: convert xts_tweak_encdec to use xts_uint128 type

2018-10-19 Thread Daniel P . Berrangé
Using 64-bit arithmetic increases the performance for xts-aes-128 when built with gcrypt: Encrypt: 272 MB/s -> 355 MB/s Decrypt: 275 MB/s -> 362 MB/s Signed-off-by: Daniel P. Berrangé --- crypto/xts.c | 84 1 file changed, 58

<    1   2   3   4   5   >