[Qemu-devel] [RFC 30/48] target/m68k: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/m68k/translate.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index dd7d868b25..9b5a4b1eb5 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -116,6 +116,7

[Qemu-devel] [RFC 28/48] target/i386: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 86e59d7bf7..1d7b20bce3 100644 --- a/target/i386/translate.c +++ b/target/i386/

[Qemu-devel] [RFC 45/48] plugin: lockstep execution support

Signed-off-by: Emilio G. Cota --- include/qemu/plugin-api.h | 7 +++ include/qemu/plugin.h | 5 + cpus.c| 1 + plugin.c | 35 +++ qemu-plugins.symbols | 3 +++ 5 files changed, 51 insertions(+) diff --git a

[Qemu-devel] [RFC 27/48] target/sh4: prepare for 2-pass translation (WIP)

XXX: cleanly get the gUSA instructions Signed-off-by: Emilio G. Cota --- target/sh4/translate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index ea88d46c04..a3b0fb46a2 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@

[Qemu-devel] [RFC 29/48] target/hppa: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/hppa/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6c2a7fbc46..08ebbeb21c 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -4757,6 +4757,8 @@ static void hpp

[Qemu-devel] [RFC 34/48] target/s390x: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/s390x/translate.c | 49 ++-- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 6ac1a8d821..0c41e0d83a 100644 --- a/target/s390x/translate.c +++ b/tar

[Qemu-devel] [RFC 37/48] target/openrisc: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/openrisc/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 947330e10a..2f084668f9 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -1308,6 +1308,

[Qemu-devel] [RFC 36/48] target/xtensa: prepare for 2-pass translation

Signed-off-by: Emilio G. Cota --- target/xtensa/translate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 14ab1c5ceb..83711f2a18 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -879

[Qemu-devel] [RFC 31/48] target/mips: prepare for 2-pass translation (WIP)

XXX: fill in plugin_insn Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index efafc6e795..46ed40cf8f 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25455,6 +

[Qemu-devel] [RFC 44/48] cpus: lockstep execution support

Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 27 +++ cpus.c| 113 +- 2 files changed, 139 insertions(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 1ac56fe84b..5841421a20 100644 --- a/include/qo

Re: [Qemu-devel] [PATCH v2 01/29] target/riscv: Move CPURISCVState pointer to DisasContext

On Thu, 25 Oct 2018 09:54:56 PDT (-0700), Peter Maydell wrote: On 25 October 2018 at 17:38, Palmer Dabbelt wrote: On Sat, 20 Oct 2018 00:14:23 PDT (-0700), kbast...@mail.uni-paderborn.de wrote: CPURISCVState is rarely used, so there is no need to pass it to every translate function. This pave

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

Hi Richard, > > Option 3: Extend the mips_opcode::membership field. > > It's trivial to extend the field to uint64_t. Is the membership field intended to be used? The opcodes for CLZ and CLO clash with the R5900 opcodes for MADD1 and MADDU1, resulting in incorrect disassembly of MADD1 and MADDU1

Re: [Qemu-devel] [PATCH v2 02/29] targer/riscv: Activate decodetree and implemnt LUI & AUIPC

On Sat, 20 Oct 2018 00:14:24 PDT (-0700), kbast...@mail.uni-paderborn.de wrote: for now only LUI & AUIPC are decoded and translated. If decodetree fails, we fall back to the old decoder. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v1 -> v2:

Re: [Qemu-devel] [PATCH v2 01/29] target/riscv: Move CPURISCVState pointer to DisasContext

On 25 October 2018 at 17:38, Palmer Dabbelt wrote: > On Sat, 20 Oct 2018 00:14:23 PDT (-0700), kbast...@mail.uni-paderborn.de > wrote: >> >> CPURISCVState is rarely used, so there is no need to pass it to every >> translate function. This paves the way for decodetree which only passes >> DisasCont

Re: [Qemu-devel] [PULL 0/8] Qcrypto next patches

On 24 October 2018 at 19:05, Daniel P. Berrangé wrote: > The following changes since commit c96292036a17857d62b8b5d3c8752bac3d6b7193: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-oct-2018-part-2-v2' into staging > (2018-10-24 16:31:40 +0100) > > are available in the Gi

Re: [Qemu-devel] [PATCH v2 01/29] target/riscv: Move CPURISCVState pointer to DisasContext

On Sat, 20 Oct 2018 00:14:23 PDT (-0700), kbast...@mail.uni-paderborn.de wrote: CPURISCVState is rarely used, so there is no need to pass it to every translate function. This paves the way for decodetree which only passes DisasContext to translate functions. Signed-off-by: Bastian Koppelmann --

Re: [Qemu-devel] [Qemu-trivial] [PATCH] piix: use TYPE_FOO constants than string constats

Hello Laurent, Thanks, This patch has been in Michael's pull request. Maybe you can drop it. Thanks, Li Qiang Laurent Vivier 于2018年10月25日周四 下午9:52写道： > On 11/10/2018 13:38, Li Qiang wrote: > > Make them more QOMConventional. > > Cc:qemu-triv...@nongnu.org > > > > Signed-off-by: Li Qiang > >

[Qemu-devel] [RFC v4 00/71] per-CPU locks

[I forgot to add the cover letter to git send-email; here it is] v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg04179.html "Why is this an RFC?" See v3 link above. Also, see comment at the bottom of this message regarding the last patch of this series. Changes since v3: - Add R-b'

[Qemu-devel] [Bug 1799766] Re: -device does not work as -drive do

Hi, As you yourself say, -drive does work, so this is really not about -drive, but about -blockdev. -drive creates part of the device as well, so to speak, whereas -blockdev only creates one (or more) nodes in the block layer. You can only eject something from devices, however, so you cannot eje

[Qemu-devel] [RFC v4 02/71] cpu: rename cpu->work_mutex to cpu->lock

This lock will soon protect more fields of the struct. Give it a more appropriate name. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 5 +++-- cpus-common.c | 14 +++--- cpus.c| 4 ++-- qom/cpu.c | 2 +- 4 files changed,

[Qemu-devel] [RFC v4 11/71] m68k: convert to helper_cpu_halted_set

Cc: Laurent Vivier Signed-off-by: Emilio G. Cota --- target/m68k/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ae3651b867..d55e707cf6 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translat

Re: [Qemu-devel] [PATCH v3 6/7] memory-device: avoid overflows on very huge devices

On Tue, Oct 23, 2018 at 05:23:05PM +0200, David Hildenbrand wrote: > Should not be a problem right now, but it could theoretically happen > in the future. > > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > hw/mem/memory-device.c | 3 ++- > 1 file changed, 2 insertions(+),

[Qemu-devel] [RFC v4 32/71] exec: use cpu_reset_interrupt

Signed-off-by: Emilio G. Cota --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 4fd831ef06..cd171adb93 100644 --- a/exec.c +++ b/exec.c @@ -776,7 +776,7 @@ static int cpu_common_post_load(void *opaque, int version_id) /* 0x01 was CPU_INTE

Re: [Qemu-devel] [PATCH v3 6/7] memory-device: avoid overflows on very huge devices

On Tue, 23 Oct 2018 17:23:05 +0200 David Hildenbrand wrote: > Should not be a problem right now, but it could theoretically happen > in the future. > > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > hw/mem/memory-device.c | 3 ++- > 1 file changed, 2 insertions(+), 1 del

Re: [Qemu-devel] [PATCH v3 5/7] memory-device: use QEMU_IS_ALIGNED

On Tue, Oct 23, 2018 at 05:23:04PM +0200, David Hildenbrand wrote: > Shorter and easier to read. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > hw/mem/memory-device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

[Qemu-devel] [RFC v4 39/71] i386/hax-all: convert to cpu_interrupt_request

Signed-off-by: Emilio G. Cota --- target/i386/hax-all.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index 8b53a9708f..70cea8b1a1 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c @@

[Qemu-devel] [RFC v4 03/71] cpu: introduce cpu_mutex_lock/unlock

The few direct users of &cpu->lock will be converted soon. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 33 +++ cpus.c | 48 +++-- stubs/cpu-lock.c| 20 +++ stubs/Makefile.objs | 1 +

[Qemu-devel] [RFC v4 30/71] cpu: define cpu_interrupt_request helpers

Add a comment about how atomic_read works here. The comment refers to a "BQL-less CPU loop", which will materialize toward the end of this series. Note that the modifications to cpu_reset_interrupt are there to avoid deadlock during the CPU lock transition; once that is complete, cpu_interrupt_req

[Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set

Signed-off-by: Emilio G. Cota --- target/alpha/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index e5d62850c5..25cd95931d 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -1226,8 +12

Re: [Qemu-devel] [PATCH v3 3/7] range: pass const pointer where possible

On Tue, Oct 23, 2018 at 05:23:02PM +0200, David Hildenbrand wrote: > If there are no changes, let's use a const pointer. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > include/qemu/range.h | 6 +++--- > 1 file changed, 3 insertion

[Qemu-devel] [RFC v4 20/71] lm32: convert to cpu_halted

Cc: Michael Walle Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/lm32/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/lm32/op_helper.c b/target/lm32/op_helper.c index 234d55e056..392634441b 100644 --- a/target/lm32/op_helper.c

[Qemu-devel] [RFC v4 01/71] cpu: convert queued work to a QSIMPLEQ

Instead of open-coding it. While at it, make sure that all accesses to the list are performed while holding the list's lock. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 6 +++--- cpus-common.c | 25 - cpus.c| 14

[Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set

Signed-off-by: Emilio G. Cota --- accel/tcg/tcg-runtime.h | 2 ++ accel/tcg/tcg-runtime.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/accel/tcg/tcg-runtime.h b/accel/tcg/tcg-runtime.h index 1bd39d136d..d767f8515b 100644 --- a/accel/tcg/tcg-runtime.h +++ b/accel/tcg/tcg-runtime.h @

[Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set

Signed-off-by: Emilio G. Cota --- target/hppa/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index ce05d5619d..df9179e70f 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2845,8 +2845,7 @@ s

[Qemu-devel] [RFC v4 22/71] mips: convert to cpu_halted

Cc: Aurelien Jarno Cc: Aleksandar Markovic Cc: James Hogan Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/mips/cps.c | 2 +- hw/misc/mips_itu.c | 4 ++-- target/mips/kvm.c | 2 +- target/mips/op_helper.c | 8 target/mips/translate.c | 4 ++--

[Qemu-devel] [RFC v4 04/71] cpu: make qemu_work_cond per-cpu

This eliminates the need to use the BQL to queue CPU work. While at it, give the per-cpu field a generic name ("cond") since it will soon be used for more than just queueing CPU work. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 6 ++-- cpus-common.c | 72 +

[Qemu-devel] [RFC v4 14/71] cpu: define cpu_halted helpers

cpu->halted will soon be protected by cpu->lock. We will use these helpers to ease the transition, since right now cpu->halted has many direct callers. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 24 1 file changed, 24 insertions

[Qemu-devel] [RFC v4 17/71] ppc: convert to cpu_halted

In ppce500_spin.c, acquire the lock just once to update both cpu->halted and cpu->stopped. In hw/ppc/spapr_hcall.c, acquire the lock just once to update cpu->halted and call cpu_has_work, since later in the series we'll acquire the BQL (if not already held) from cpu_has_work. Cc: David Gibson Cc

[Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 10 -- cpus-common.c | 2 +- cpus.c| 5 - 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/include/qom/cpu.h b/i

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

On Tue, Oct 23, 2018 at 05:23:00PM +0200, David Hildenbrand wrote: > The qemu api claims to be easier to use, and the resulting code seems to > agree. > > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > qapi/string-input-visitor.c | 17 ++--- > 1 file changed,

[Qemu-devel] [RFC v4 13/71] microblaze: convert to helper_cpu_halted_set

Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 78ca265b04..008b84d456 100644 --- a/target/microblaze/translate.c +++

[Qemu-devel] [RFC v4 06/71] cpu: introduce process_queued_cpu_work_locked

This completes the conversion to cpu_mutex_lock/unlock in the file. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cpus-common.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index 3fccee5585..c2ad554d54 10

[Qemu-devel] [RFC v4 37/71] i386: convert to cpu_interrupt_request

Signed-off-by: Emilio G. Cota --- target/i386/cpu.c| 2 +- target/i386/helper.c | 4 ++-- target/i386/svm_helper.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b91d80af0a..9eaf3274b2 100644 --- a/target/i386/cpu.c

[Qemu-devel] [RFC v4 08/71] ppc: convert to helper_cpu_halted_set

Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- target/ppc/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 4e59dd5f42..2d31b5f7a1 100644 --- a/target/ppc/tra

[Qemu-devel] [RFC v4 19/71] i386: convert to cpu_halted

Cc: Eduardo Habkost Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/i386/cpu.h | 2 +- target/i386/cpu.c | 2 +- target/i386/hax-all.c | 4 ++-- target/i386/helper.c | 4 ++-- target/i386/hvf/hvf.c | 8 target/i386/hvf/x86hvf.c

[Qemu-devel] [RFC v4 38/71] i386/kvm: convert to cpu_interrupt_request

Signed-off-by: Emilio G. Cota --- target/i386/kvm.c | 54 +++ 1 file changed, 31 insertions(+), 23 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index effaf87f01..f4b96d6963 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2

[Qemu-devel] [RFC v4 09/71] cris: convert to helper_cpu_halted_set

And fix the temp leak along the way. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/cris/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 4ae1c04daf..0ccb65fbed 100644 --- a/target/cris

[Qemu-devel] [RFC v4 23/71] riscv: convert to cpu_halted

Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Emilio G. Cota --- target/riscv/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/op_helper.c b/target/

[Qemu-devel] [RFC v4 25/71] sparc: convert to cpu_halted

Cc: Fabien Chouteau Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/sparc/leon3.c | 2 +- hw/sparc/sun4m.c | 8 hw/sparc64/sparc64.c | 4 ++-- target/sparc/helper.c | 2 +- 4 files changed, 8 insertions(+), 8 de

Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings

On Tue, Oct 23, 2018 at 05:23:01PM +0200, David Hildenbrand wrote: > Right now, we parse uint64_t values just like int64_t values, resulting > in negative values getting accepted and certain valid large numbers only > being representable as negative numbers. Also, reported errors indicate > that an

[Qemu-devel] [RFC v4 27/71] gdbstub: convert to cpu_halted

Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index c8478de8f5..a5ff50d9e7 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1305,7 +1305,7 @@ static int gdb_handle_packet(GDBState *s,

[Qemu-devel] [RFC v4 26/71] xtensa: convert to cpu_halted

Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/xtensa/cpu.c | 2 +- target/xtensa/helper.c| 2 +- target/xtensa/op_helper.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index

[Qemu-devel] [RFC v4 21/71] m68k: convert to cpu_halted

Cc: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/m68k/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 8d09ed91c4..61ba1a6dec 100644 --- a/target/m68k/op_helper.c +++

[Qemu-devel] [RFC v4 15/71] tcg-runtime: convert to cpu_halted_set

Signed-off-by: Emilio G. Cota --- accel/tcg/tcg-runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c index 4aa038465f..70e3c9de71 100644 --- a/accel/tcg/tcg-runtime.c +++ b/accel/tcg/tcg-runtime.c @@ -172,5 +172,5 @@ void

[Qemu-devel] [RFC v4 28/71] openrisc: convert to cpu_halted

Cc: Stafford Horne Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index b66a45c1e0..ab4d8fb520 100644 --- a/target/openr

[Qemu-devel] [RFC v4 35/71] openrisc: use cpu_reset_interrupt

From: Paolo Bonzini Cc: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_helpe

[Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/intc/s390_flic.c| 2 +- target/s390x/cpu.c | 18 +++--- target/s390x/excp_helper.c |

[Qemu-devel] [RFC v4 44/71] cris: convert to cpu_interrupt_request

Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/cris/cpu.c| 2 +- target/cris/helper.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/cris/cpu.c b/target/cris/cpu.c index a23aba2688..3cdba581e6 100644 --- a/t

[Qemu-devel] [RFC v4 29/71] cpu-exec: convert to cpu_halted

Signed-off-by: Emilio G. Cota --- accel/tcg/cpu-exec.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 870027d435..f37c9b1e94 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -422,14 +42

[Qemu-devel] [RFC v4 41/71] i386/hvf: convert to cpu_request_interrupt

Signed-off-by: Emilio G. Cota --- target/i386/hvf/hvf.c| 8 +--- target/i386/hvf/x86hvf.c | 26 +++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index fb3b2a26a1..da789117c8 100644 --- a/target/i386/

[Qemu-devel] [RFC v4 49/71] nios: convert to cpu_interrupt_request

Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index fbfaa2ce26..49a75414d3 100644 --- a/target/nios2/cpu.c +++ b/tar

[Qemu-devel] [RFC v4 48/71] mips: convert to cpu_interrupt_request

Cc: Aurelien Jarno Cc: Aleksandar Markovic Cc: James Hogan Signed-off-by: Emilio G. Cota --- target/mips/cpu.c | 7 --- target/mips/kvm.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 497706b669..992d64e796 100644 --- a/t

[Qemu-devel] [RFC v4 18/71] sh4: convert to cpu_halted

Cc: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/sh4/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index 4f825bae5a..57cc363ccc 100644 --- a/target/sh4/op_helper.c +++ b/t

[Qemu-devel] [RFC v4 40/71] i386/whpx-all: convert to cpu_interrupt_request

Signed-off-by: Emilio G. Cota --- target/i386/whpx-all.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 9673bdc219..0d8cfa3a19 100644 --- a/target/i386/whpx-all.c +++ b/target/i3

[Qemu-devel] [RFC v4 52/71] moxie: convert to cpu_interrupt_request

Cc: Anthony Green Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/moxie/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/moxie/cpu.c b/target/moxie/cpu.c index 8d67eb6727..bad92cfc61 100644 --- a/target/moxie/cpu.c +++ b/target/moxie/cpu.c

[Qemu-devel] [RFC v4 33/71] i386: use cpu_reset_interrupt

From: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/i386/hax-all.c| 4 ++-- target/i386/hvf/x86hvf.c | 8 target/i386/kvm.c| 14 +++--- target/i386/seg_helper.c | 13 ++--- target/i386/

[Qemu-devel] [RFC v4 16/71] arm: convert to cpu_halted

Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx_gpio.c | 2 +- hw/arm/pxa2xx_pic.c | 2 +- target/arm/arm-powerctl.c | 4 ++-- target/arm/cpu.c

[Qemu-devel] [RFC v4 34/71] s390x: use cpu_reset_interrupt

From: Paolo Bonzini Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/s390x/excp_helper.c | 2

[Qemu-devel] [RFC v4 56/71] microblaze: convert to cpu_interrupt_request

Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/microblaze/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 9b546a2c18..206fdd8651 100644 --- a/target/microblaze/cpu.

[Qemu-devel] [RFC v4 51/71] alpha: convert to cpu_interrupt_request

Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/alpha/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index a953897fcc..4e8965fb6c 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -42,10

[Qemu-devel] [RFC v4 43/71] sh4: convert to cpu_interrupt_request

Cc: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index b9f393b7c7..58ea212f53 100644 --- a/target/sh4/cpu

[Qemu-devel] [RFC v4 45/71] hppa: convert to cpu_interrupt_request

Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 00bf444620..1ab4e62850 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -60,7 +60,7 @@ stati

[Qemu-devel] [RFC v4 47/71] m68k: convert to cpu_interrupt_request

Cc: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/m68k/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 582e3a73b3..99a7eb4340 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@

[Qemu-devel] [RFC v4 46/71] lm32: convert to cpu_interrupt_request

Cc: Michael Walle Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c index b7499cb627..1508bb6199 100644 --- a/target/lm32/cpu.c +++ b/target/lm32/cpu.c @@ -

[Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_request

Cc: Stafford Horne Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/openrisc/cputimer.c | 2 +- target/openrisc/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 850f88761c..739404e4f5 100644

[Qemu-devel] [RFC v4 31/71] ppc: use cpu_reset_interrupt

From: Paolo Bonzini Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/ppc/excp_helper.c | 2 +- 1 file changed, 1 inser

[Qemu-devel] [RFC v4 57/71] accel/tcg: convert to cpu_interrupt_request

Signed-off-by: Emilio G. Cota --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index f37c9b1e94..d590f1f6

[Qemu-devel] [RFC v4 65/71] xtensa: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Signed-off-by: Emilio G. Cota --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index d4ca35e6cc..5f3b4a70b0 100644 --- a/target/xtensa/cpu.c +

[Qemu-devel] [RFC v4 58/71] cpu: call .cpu_has_work with the CPU lock held

Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index a86690c7a5..9826cdfa4c 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -84,7 +84,8 @@ struct TranslationBlock

[Qemu-devel] [RFC v4 63/71] riscv: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Signed-off-by: Emilio G. Cota --- target/riscv/cpu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/ri

[Qemu-devel] [RFC v4 55/71] unicore32: convert to cpu_interrupt_request

Cc: Guan Xuetao Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c index 2b49d1ca40..65c5334551 1006

[Qemu-devel] [RFC v4 42/71] ppc: convert to cpu_interrupt_request

Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- hw/ppc/ppc.c| 2 +- target/ppc/excp_helper.c| 2 +- target/ppc/kvm.c| 4 ++-- target/ppc/translate_init.inc.c | 14 +++--- 4 files changed, 11 ins

[Qemu-devel] [RFC v4 59/71] cpu: introduce cpu_has_work_with_iothread_lock

It will gain some users soon. Suggested-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 9826cdfa4c..b5c3b2c734 100644 --- a

[Qemu-devel] [RFC v4 53/71] sparc: convert to cpu_interrupt_request

Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/sparc64/sparc64.c | 4 ++-- target/sparc/cpu.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sparc64/sparc64.c b/hw/sparc64/sparc64.c index 372bbd4f5b..58

[Qemu-devel] [RFC v4 62/71] s390x: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Signed-off-by: Emilio G. Cota --- target/s390x/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/cpu.c b/target/s390x/cp

[Qemu-devel] [RFC v4 64/71] sparc: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota --- target/sparc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 88427283c1..54bffc1a6c 100644 ---

[Qemu-devel] [RFC v4 36/71] arm: convert to cpu_interrupt_request

Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/arm/cpu.c| 2 +- target/arm/helper.c | 12 +--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 9c5cda8eb7..733

[Qemu-devel] [RFC v4 61/71] mips: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Signed-off-by: Emilio G. Cota --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 992d64e796..dcda1bce31 100644 --- a/

[Qemu-devel] [RFC v4 50/71] s390x: convert to cpu_interrupt_request

Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/intc/s390_flic.c | 2 +- target/s390x/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [RFC v4 70/71] cpus-common: move exclusive_idle higher in the file

This will simplify the following commit's diff. Signed-off-by: Emilio G. Cota --- cpus-common.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index 232cb12c46..ad8a8ef535 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -73,

[Qemu-devel] [RFC v4 68/71] cpu: add async_run_on_cpu_no_bql

Some async jobs do not need the BQL. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 14 ++ cpus-common.c | 39 ++- 2 files changed, 48 insertions(+), 5 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index ed68e089c5..0e

[Qemu-devel] [RFC v4 60/71] ppc: convert to cpu_has_work_with_iothread_lock

Soon we will call cpu_has_work without the BQL. Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- target/ppc/translate_init.inc.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate_init.inc.c b/

[Qemu-devel] [RFC v4 69/71] cputlb: queue async flush jobs without the BQL

This yields sizable scalability improvements, as the below results show. Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) Workload: Ubuntu 18.04 ppc64 compiling the linux kernel with "make -j N", where N is the number of cores in the guest. Speedup vs a single

[Qemu-devel] [RFC v4 66/71] cpu: protect most CPU state with cpu->lock

Instead of taking the BQL every time we exit the exec loop, have a per-CPU lock to serialize accesses the the CPU's state. Differently from the BQL, this lock is uncontended so acquiring it is cheap. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 20 ++-- cpus.c| 300 +++

[Qemu-devel] [RFC v4 67/71] cpus-common: release BQL earlier in run_on_cpu

After completing the conversion to per-CPU locks, there is no need to release the BQL after having called cpu_kick. Signed-off-by: Emilio G. Cota --- cpus-common.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index c2ad55

[Qemu-devel] [RFC v4 71/71] cpus-common: wait on the CPU lock for exclusive work completion

The current implementation of exclusive work can suffer from high contention when the number of guest CPUs is large (> 16 or so). The reason is that all CPUs end up waiting on the same condvar/mutex pair, which unnecessarily slows them down to wake up. Fix it by having them wait on their "local" c

Re: [Qemu-devel] [PATCH v1] arm: check bit index before usage

On 22 October 2018 at 19:10, P J P wrote: > From: Prasad J Pandit > > While performing gpio write via strongarm_gpio_handler_update > routine, the 'bit' index could access beyond s->handler[28] array. > Add check to avoid OOB access. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit >

Re: [Qemu-devel] [Qemu-trivial] [PATCH 07/10] scripts/decodetree.py: remove unused imports

On 04/10/2018 17:18, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > scripts/decodetree.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/decodetree.py b/scripts/decodetree.py > index 277f9a9bba..457cffea90 100755 > --- a/scripts/decodetree.py > +++ b/scripts/decodetre

Re: [Qemu-devel] [Qemu-trivial] [PATCH 10/10] scripts/qemu.py: remove trailing quotes on docstring

On 04/10/2018 17:18, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > scripts/qemu.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 7abe26de69..676eb9709a 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -88,7

Re: [Qemu-devel] [Qemu-trivial] [PATCH] piix: use TYPE_FOO constants than string constats

On 11/10/2018 13:38, Li Qiang wrote: > Make them more QOMConventional. > Cc:qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > hw/pci-host/piix.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Applied, Thanks, Laurent

<    1   2   3   >