Re: [Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related opcodes. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 470 > > 1 file changed, 235 insertions(+), 235 deletions(-)

[Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add`

2018-10-30 Thread Kashyap Chamarthy
Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP equivalent, too. Suggested-by: Thomas Huth Signed-off-by: Kashyap Chamarthy --- hmp-commands.hx | 6 -- hmp.c | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx

Re: [Qemu-devel] [PATCH v2 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Rename MMI-related masks. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 13:01, Peter Maydell wrote: > ...having sent this out and moved on to something else, I have > discovered a problem with it. If you configure a build tree > using this, and then switch back to a git branch which has > the older configure, then that configure will end up

Re: [Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:35, Aleksandar Markovic wrote: Perhaps checkpatch.pl should make sure the commit messages do not contain "address@hidden" and "Reviewed-off-by"? $ git log | grep address@hidden Signed-off-by: Michael S. Tsirkin Signed-off-by: Ronald Hecht Signed-off-by: Justin

Re: [Qemu-devel] [PATCH 5/9] qom/globals: generalize object_property_set_globals()

2018-10-30 Thread Igor Mammedov
On Tue, 30 Oct 2018 16:16:43 +0400 Marc-André Lureau wrote: > Hi > > On Mon, Oct 29, 2018 at 5:11 PM Igor Mammedov wrote: > > > > On Wed, 12 Sep 2018 16:55:27 +0400 > > Marc-André Lureau wrote: > > > > > Handle calls of object_property_set_globals() with any object type, > > > but only

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:40, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > Reviewed-by: Richard Henderson > --- > hw/arm/xilinx_zynq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xilinx_zynq.c

Re: [Qemu-devel] [PULL 0/3] Usb 20181029 patches

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 20:02, Gerd Hoffmann wrote: > The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-10-19 19:01:07 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] qga: fix an off-by-one issue

2018-10-30 Thread Michael Roth
Quoting Li Qiang (2018-10-17 21:10:37) > Signed-off-by: Li Qiang Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga > --- > qga/commands-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index

[Qemu-devel] [PULL 10/24] qga-win: add debugging information

2018-10-30 Thread Michael Roth
The windows code generaly lacks debug information (compared to posix code). This patch adds some related to HW info in guest-get-fsinfo command. Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/commands-win32.c | 15 +++ 1 file

Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 14:08, Peter Maydell wrote: On 30 October 2018 at 13:01, Peter Maydell wrote: ...having sent this out and moved on to something else, I have discovered a problem with it. If you configure a build tree using this, and then switch back to a git branch which has the older configure,

[Qemu-devel] [PATCH v2 06/10] qom/object: set globals when initializing object

2018-10-30 Thread Marc-André Lureau
Set globals for all objects, although only TYPE_DEVICE & TYPE_USER_CREATABLE can have globals for now. Replaces the qdev post-init callback (which was the last called in the hierarchy order) by an explicit call during object creation after post-init, to maintain the call ordering. Signed-off-by:

[Qemu-devel] [PULL 06/24] qga: linux: return disk device in guest-get-fsinfo

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Report device node of the disk on Linux (e.g. "/dev/sda2"). Requirs libudev. Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth --- qga/commands-posix.c | 7 ++- qga/qapi-schema.json | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [qemu-s390x] [PATCH] call HotplugHandler->plug() as the last step in device realization

2018-10-30 Thread Igor Mammedov
On Wed, 24 Oct 2018 15:09:36 +0200 David Hildenbrand wrote: > On 16.10.18 15:56, Igor Mammedov wrote: > > On Tue, 16 Oct 2018 15:33:40 +0200 > > Igor Mammedov wrote: > > > >> When [2] was fixed it was agreed that adding and calling post_plug() > >> callback after device_reset() was low risk

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 11:46, Mark Cave-Ayland a écrit : > On 30/10/2018 06:46, Hervé Poussineau wrote: > >> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >>> From: Laurent Vivier >>> >>> This is broken as the linux driver seems broken too... >>> >>> Co-developed-by: Mark Cave-Ayland >>>

Re: [Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Rename MMI-related opcodes. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 470 1 file changed, 235 insertions(+), 235 deletions(-)

[Qemu-devel] [PATCH v3 1/3] linux-user: Add support for statx() syscall

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation includes invoking other (more mature) syscalls (from the same 'stat' family) on the host side. This way, problems of availability of statx() on the host side are avoided. On some systems with

[Qemu-devel] [PATCH v3 3/3] linux-user: Add support for SO_REUSEPORT

2018-10-30 Thread Aleksandar Markovic
From: Yunqiang Su Add support for SO_REUSEPORT, including strace support. SO_REUSEPORT was introduced relatively recently, since Linux 3.9, so use '#if defined SO_REUSEPORT'. Reviewed-by: Laurent Vivier Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic --- linux-user/strace.c |

[Qemu-devel] [PATCH v3 0/3] linux-user: Support for misc features

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic This series add support for two system calls and a socket-related improvement. v2-v3: - patch on statx() modified according to the feedback - patch on semtimedop() modified according to the feedback v1->v2: - fixed a typo in the title - cosmetic comment

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 12:49, Laurent Vivier wrote: > Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : >> On 30/10/2018 08:15, Richard Henderson wrote: >> >>> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: You can install your own disk using debian-installer, with: ... -M q800 \

Re: [Qemu-devel] [PATCH 1/3] configure: Rename FILES variable to LINKS

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:50, Peter Maydell wrote: The FILES variable is used to accumulate a list of things to symlink from the source tree into the build tree. These don't have to be individual files; symlinking an entire directory of data files is also fine. Rename it to something less confusing

Re: [Qemu-devel] [PATCH v2] strongarm: mask off high[32:28] bits from dir and state registers

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 12:49, P J P wrote: +-- On Mon, 29 Oct 2018, Peter Maydell wrote --+ | > switch (offset) { | > case GPDR:/* GPIO Pin-Direction registers */ | > -s->dir = value; | > +s->dir = value & 0x3f; | | The commit message says it's masking [31:28], but the

Re: [Qemu-devel] [PATCH RFC 1/4] slirp: add helper for tcp6 socket creation

2018-10-30 Thread Maxim Samoylov
On 27.10.2018 14:11, Samuel Thibault wrote: Hello, Thanks for working on this! Hi! I preferred to make this RFC simple and straightforward with dumb code duplication because I wasn't sure if the feature is useful for upstream at all :) I will then unify v4 and v6 implementations as you

Re: [Qemu-devel] [PATCH] Add Alistair as a RISC-V Maintainer

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 18:41, Palmer Dabbelt wrote: > On Mon, 29 Oct 2018 10:59:47 PDT (-0700), Peter Maydell wrote: >> >> On 29 October 2018 at 17:14, Palmer Dabbelt wrote: >>> >>> I don't think we have anything ready to go right now: your PCIe patches >>> still have some outstanding feedback

[Qemu-devel] [PULL 01/24] qga: Support Unicode paths in guest-file-open on win32

2018-10-30 Thread Michael Roth
From: Jonathon Reinhart Currently, the win32 port of QEMU Guest Agent does not properly handle Unicode paths. The JSON decoder produces a valid UTF-8 path string, but this is passed directly to CreateFileA, which is expecting an ANSI string and not UTF-8. This leads to mangled filenames. This

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote: > Indicates support state for somerhing (device, backend, subsystem, ...) > in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. > > Signed-off-by: Gerd Hoffmann [...] > +typedef struct QemuSupportState { > +

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 08:15, Richard Henderson wrote: > On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >> You can install your own disk using debian-installer, with: >> >> ... >> -M q800 \ >> -serial none -serial mon:stdio \ >> -m 1000M -drive file=m68k.qcow2,format=qcow2 \ >> -net

Re: [Qemu-devel] [PULL 00/27] MIPS queue for October 2018, part 4

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 15:19, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit 03f400883a1dd92fac5b0d9127b38e34c9a722d7: > > target/mips: Add MXU decoding engine (2018-10-29 14:13:47 +0100) > > are available in the git repository at: > >

[Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Aleksandar Markovic
Perhaps checkpatch.pl should make sure the commit messages do not contain "address@hidden" and "Reviewed-off-by"? $ git log | grep address@hidden Signed-off-by: Michael S. Tsirkin Signed-off-by: Ronald Hecht Signed-off-by: Justin Chevrier Signed-off-by: Justin Chevrier

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Gerd, On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend, subsystem, ...) "something" in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. Signed-off-by: Gerd Hoffmann --- include/qemu/support-state.h | 17

[Qemu-devel] [PULL 03/24] qga: ignore non present cpus when handling qmp_guest_get_vcpus()

2018-10-30 Thread Michael Roth
From: Igor Mammedov If VM has VCPUs plugged sparselly (for example a VM started with 3 VCPUs (cpu0, cpu1 and cpu2) and then cpu1 was hotunplugged so only cpu0 and cpu2 are present), QGA will rise a error error: internal error: unable to execute QEMU agent command 'guest-get-vcpus':

[Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related opcodes. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 470 1 file changed, 235 insertions(+), 235 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread wj193102
Thanks for your reply. At 2018-10-30 16:33:15, "Peter Maydell" wrote: >On 30 October 2018 at 02:16, wj193102 wrote: >> Hi, everyone. >> When I have installed the QEMU3.0.0 in the Linux on non X86 CPUS, I want >> to use user space emulator to run Wine. I can get the source code for Wine >>

[Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add`

2018-10-30 Thread Kashyap Chamarthy
The intended functionality of QMP `cpu-add` is replaced with `device_add` (and `query-hotpluggable-cpus`). So let's deprecate `cpu-add`. A complete example of vCPU hotplug with the recommended way (using `device_add`) is provided as part of a seperate docs patch. Suggested-by: Eduardo Habkost

[Qemu-devel] [PATCH v3 0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug

2018-10-30 Thread Kashyap Chamarthy
The first patch deprecates the QMP `cpu-add`, the second its HMP equivalent, and the third documents vCPU hotplug procedure using QMP `device_add` et al. v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html Kashyap Chamarthy (3): Deprecate QMP `cpu-add` Deprecate HMP

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Stefan Berger
On 10/30/18 7:26 AM, Peter Maydell wrote: On 30 October 2018 at 11:14, Marc-André Lureau wrote: Hi Peter On Tue, Oct 30, 2018 at 2:45 PM Peter Maydell wrote: Hi; this gives some test failures (all hosts): TEST: tests/tpm-crb-swtpm-test... (pid=305) /i386/tpm/crb-swtpm/test:

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : > On 30/10/2018 08:15, Richard Henderson wrote: > >> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >>> You can install your own disk using debian-installer, with: >>> >>> ... >>> -M q800 \ >>> -serial none -serial mon:stdio \ >>> -m

[Qemu-devel] [PATCH 3/3] configure: Use FILES loop for all build tree symlinks

2018-10-30 Thread Peter Maydell
A few places in configure were doing ad-hoc calls to the symlink function to set up symlinks from the build tree back to the source tree. We have a loop that does this already for all files and directories listed in the FILES environment variable; use that instead. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Enable MIPS 032 user mode for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 4 1 file changed, 4 insertions(+) diff --git a/target/mips/translate_init.inc.c

[Qemu-devel] [PATCH v3 2/3] linux-user: Add support for semtimedop() syscall

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for semtimedop() emulation. It is based on invocation of safe_semtimedop(). Conversion is left out of safe_semtimedop(), since other safe_xxx() usually don't contain similar conversions. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic

Re: [Qemu-devel] [PATCH v2 2/2] arm: exynos4: Add dma support for smdkc210

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:40, Philippe Mathieu-Daudé wrote: > From: Guenter Roeck > > QEMU already supports pl330. Instantiate it for smdkc210. > > Signed-off-by: Guenter Roeck > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > [PMD: Do not set default qdev properties] >

Re: [Qemu-devel] [PATCH v3 1/3] linux-user: Add support for statx() syscall

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 13:55, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Implement support for translation of system call statx(). The > implementation includes invoking other (more mature) syscalls > (from the same 'stat' family) on the host side. This way, > problems of availability

Re: [Qemu-devel] [PATCH v2 2/2] arm: exynos4: Add dma support for smdkc210

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 15:06, Peter Maydell wrote: On 30 October 2018 at 11:40, Philippe Mathieu-Daudé wrote: From: Guenter Roeck QEMU already supports pl330. Instantiate it for smdkc210. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis [PMD: Do not set

[Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1

2018-10-30 Thread Marc-André Lureau
Hi, The migration code expects the RAM block name to match between the source and destination. However the backend type may change, so it is possible (so far) to migrate from a hostmem-file to a hostmem-memfd for example. However, hostmem backends use inconsistent RAM naming, which can cause a

[Qemu-devel] [PATCH v2 08/10] tests: add user-creatable test to test-qdev-global-props

2018-10-30 Thread Marc-André Lureau
Add a TYPE_USER_CREATABLE object global property check. Rename the test, since it is no longer QDev-specific. Signed-off-by: Marc-André Lureau --- ...dev-global-props.c => test-global-props.c} | 128 -- tests/Makefile.include| 4 +- 2 files changed,

Re: [Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 14:48, Aleksandar Markovic wrote: > >> From: Paolo Bonzini >> >> Sure, both are good ideas. Can you write a patch for it? > > I would rather not, I prefer to see it as a black box. So do most of the rest of us :-) This is why sometimes it does not have all the features

[Qemu-devel] [PATCH v2 09/10] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-10-30 Thread Marc-André Lureau
The following patch is going to add compatiblity parameters. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 2 +- hw/i386/pc_piix.c| 15 --- hw/i386/pc_q35.c | 13 +++-- 3 files changed, 24 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v2 1/8] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-10-30 Thread Steffen Görtz
Adds a new qtest command "set_irq_in" which allows to set qemu gpio lines to a given level. Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html which never got merged. Signed-off-by: Steffen Görtz Originally-by: Matthew Ogilvie --- qtest.c | 40

[Qemu-devel] [PATCH v2 7/8] tests/microbit-test: Add Tests for nRF51 GPIO

2018-10-30 Thread Steffen Görtz
The test suite for the nRF51 GPIO peripheral for now only tests initial state. Additionally a set of tests testing an implementation detail of the model are included. Signed-off-by: Steffen Görtz --- tests/microbit-test.c | 122 ++ 1 file changed, 122

Re: [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 03:50, Zhang Chen wrote: > The original code just follow the TCP state diagram, > but in this case, we can skip the TCPS_TIME_WAIT state to simplify > the implementation. > > Signed-off-by: Zhang Chen > --- > net/filter-rewriter.c | 3 ++- > 1 file changed, 2

Re: [Qemu-devel] [PATCH v2] migration: avoid segmentfault when take a snapshot of a VM which being migrated

2018-10-30 Thread Dr. David Alan Gilbert
* Jia Lina (jialin...@baidu.com) wrote: > During an active background migration, snapshot will trigger a > segmentfault. As snapshot clears the "current_migration" struct > and updates "to_dst_file" before it finds out that there is a > migration task, Migration accesses the null pointer in >

[Qemu-devel] [PULL 7/7] editorconfig: set emacs mode

2018-10-30 Thread Marc-André Lureau
Some time ago, I proposed to use an (eval) in .dir-locals.el to set the mode for all json files and Makefile. Unfortunately, this isn't safe, and emacs will prompt the user, which isn't very friendly. Fortunately, editorconfig provides a special config key which does allow to set the emacs mode.

Re: [Qemu-devel] [PATCH] Add Alistair as a RISC-V Maintainer

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 17:54, Philippe Mathieu-Daudé wrote: > http://lists.nongnu.org/archive/html/qemu-riscv/ returns 404 Not > found: The requested URL /archive/html/qemu-riscv/ was not found on > this server. > > This might be a cron job and I need to wait. Yeah, it will do that until the

[Qemu-devel] [PATCH] hw: qdev: fix error in comment

2018-10-30 Thread Li Qiang
Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index a24d0dd566..92851e55df 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@

Re: [Qemu-devel] [qemu-s390x] [PATCH] call HotplugHandler->plug() as the last step in device realization

2018-10-30 Thread David Hildenbrand
On 30.10.18 16:15, Igor Mammedov wrote: > On Wed, 24 Oct 2018 15:09:36 +0200 > David Hildenbrand wrote: > >> On 16.10.18 15:56, Igor Mammedov wrote: >>> On Tue, 16 Oct 2018 15:33:40 +0200 >>> Igor Mammedov wrote: >>> When [2] was fixed it was agreed that adding and calling post_plug()

Re: [Qemu-devel] [PULL 00/19] Bitmaps patches

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 21:24, John Snow wrote: > The following changes since commit 62b658db1df7c6fa574caae038144f24bf6ca495: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-10-29 17:03:27 +) > > are available in the Git repository at: > >

[Qemu-devel] [PATCH for-3.1] target/arm: Remove can't-happen if() from handle_vec_simd_shli()

2018-10-30 Thread Peter Maydell
In handle_vec_simd_shli() we have a check: if (size > 3 && !is_q) { unallocated_encoding(s); return; } However this can never be true, because we calculate int size = 32 - clz32(immh) - 1; where immh is a 4 bit field which we know cannot be all-zeroes. So the

Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified

2018-10-30 Thread Markus Armbruster
Eric Blake writes: > A quick coredump on an incomplete command line: > ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on > > #0 0x7723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0 > #1 0x7723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0 > #2

[Qemu-devel] [PULL 0/5] MIPS queue for October 2018, part 5

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 3f3285491dd52014852a56135c90e428c8b507ea: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2018-10-30 14:09:25 +) are available in the git repository at:

[Qemu-devel] [PULL 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related masks. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PULL 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related functions. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff

[Qemu-devel] [PULL 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Enable MIPS 032 user mode for R5900. Expose to end-user only features that make sense and are appropriately tested. In this case, enable only MIPS 032 user mode for R5900. About defined(CONFIG_USER_ONLY), it is just because a reasonable testing was not provided for

[Qemu-devel] [PULL 4/5] target/mips: Remove some spurious R5900-related comments

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove some spurious R5900-related comments. Very similar comments are in the vicinity of the area in question, and in file translate.c. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 12 1 file

Re: [Qemu-devel] [PATCH v2 2/2] x86: hv_evmcs CPU flag support

2018-10-30 Thread Vitaly Kuznetsov
Roman Kagan writes: > On Mon, Oct 22, 2018 at 06:55:06PM +0200, Vitaly Kuznetsov wrote: >> Adds a new CPU flag to enable the Enlightened VMCS KVM feature. >> QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the >> version to be advertised in lower 16 bits of CPUID.0x400A:EAX. >>

[Qemu-devel] [PULL 5/7] chardev: Add websocket support

2018-10-30 Thread Marc-André Lureau
From: Julia Suvorova via Qemu-devel New option "websocket" added to allow using WebSocket protocol for chardev socket backend. Example: -chardev socket,websocket,server,id=... Signed-off-by: Julia Suvorova Message-Id: <20181018223501.21683-3-jus...@mail.ru> Reviewed-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH] Add qemu-ri...@nongnu.org as the RISC-V list

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 18:43, Palmer Dabbelt wrote: We now have a RISC-V specific QEMU development list. Signed-off-by: Palmer Dabbelt Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_list() to tests

2018-10-30 Thread Marc-André Lureau
The function is only used by a test, move it there. Signed-off-by: Marc-André Lureau --- include/hw/qdev-properties.h | 1 - hw/core/qdev-properties.c | 9 - tests/test-qdev-global-props.c | 18 ++ 3 files changed, 14 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [Question] About object oriented programming in qemu

2018-10-30 Thread Li Qiang
Hello all, Today I read the BusClass’ definition. The comment /* FIXME first arg should be BusState */ remind me that OOP in qemu is not very OOP. Maybe we should take the first arg as the Object pointer, just as the cpp’s this pointer. For example, we can define the BusClass function as

[Qemu-devel] [PATCH] target/m68k: use EXCP_ILLEGAL instead of EXCP_UNSUPPORTED

2018-10-30 Thread Laurent Vivier
Coldfire defines an "Unsupported instruction" exception if execution of a valid instruction is attempted but the required hardware is not present in the processor. We use it with instructions that are in fact undefined or illegal, and the exception expected in this case by the kernel is the

Re: [Qemu-devel] [PATCH v3 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 30/10/18 16:44, Aleksandar Markovic wrote: From: Aleksandar Markovic Enable MIPS 032 user mode for R5900. Expose to end-user only features that make sense and are appropriately tested. In this case, enable only MIPS 032 user mode for R5900. About defined(CONFIG_USER_ONLY),

Re: [Qemu-devel] [PATCH 0/2] RFC: object: recommend a few type check macros

2018-10-30 Thread Daniel P . Berrangé
On Tue, Oct 30, 2018 at 08:37:47PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Oct 1, 2018 at 5:47 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Sep 24, 2018 at 1:30 PM Igor Mammedov wrote: > > > > > > On Fri, 21 Sep 2018 15:13:30 +0400 > > > Marc-André Lureau wrote: > > > > >

Re: [Qemu-devel] [PATCH for-3.1] target/arm: Remove can't-happen if() from handle_vec_simd_shli()

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 17:25, Peter Maydell wrote: In handle_vec_simd_shli() we have a check: if (size > 3 && !is_q) { unallocated_encoding(s); return; } However this can never be true, because we calculate int size = 32 - clz32(immh) - 1; where immh is a 4 bit field

Re: [Qemu-devel] vhost-user devices work with chardev from different threads

2018-10-30 Thread Marc-André Lureau
Hi On Mon, Oct 29, 2018 at 5:35 PM Yury Kotov wrote: > > > > 29.10.2018, 09:46, "Marc-André Lureau" : > > Hi > > > > On Mon, Oct 22, 2018 at 5:24 PM Yury Kotov > > wrote: > > > >> Hi, > >> > >> I examined vhost-user devices and found some chardev using strangeness. > >> > >> Is it ok, that

Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > Here is a small series of fixes for the monitor, mostly related to > threading issues. Series looks good on first glance, but thread safety is subtle business, so I'd like to give it a bit more time for review. Bug fixes like these can go in after soft

Re: [Qemu-devel] [PATCH v2 00/19] ACPI reorganization for hardware-reduced support

2018-10-30 Thread Samuel Ortiz
Hi Markus, On Mon, Oct 29, 2018 at 06:28:48PM +0100, Markus Armbruster wrote: > You neglected to cc: maintainers. I'm doing that for you now. > scripts/get_maintainer.pl can help you finding maintainers. Sorry about that. I sent a v3 with all maintainers cc'ed. Cheers, Samuel. > Samuel Ortiz

[Qemu-devel] [PATCH v2 10/10] hostmem: use object id for memory region name with >= 3.1

2018-10-30 Thread Marc-André Lureau
hostmem-file and hostmem-memfd use the whole object path for the memory region name, and hostname-ram uses only the path component (the object id, or canonical path basename): qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio (qemu)

[Qemu-devel] [PATCH v2 6/8] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-10-30 Thread Steffen Görtz
This adds a model of the nRF51 GPIO peripheral. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf The nRF51 series microcontrollers support up to 32 GPIO pins in various configurations. The pins can be used as input pins with pull-ups or pull-down. Furthermore, three

[Qemu-devel] [PATCH for-3.1] milkymist: Check for failure trying to load BIOS image

2018-10-30 Thread Peter Maydell
Check the return value from load_image_targphys(), which tells us whether our attempt to load the BIOS image into RAM failed. (Spotted by Coverity, CID 1190305.) Signed-off-by: Peter Maydell --- hw/lm32/milkymist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH for-3.1] hw/ppc/ppc440_uc: Remove dead code in sdram_size()

2018-10-30 Thread Peter Maydell
Coverity points out in CID 1390588 that the test for sh == 0 in sdram_size() can never fire, because we calculate sh with sh = 1024 - ((bcr >> 6) & 0x3ff); which must result in a value between 1 and 1024 inclusive. Without the relevant manual for the SoC, we're not completely sure of the

Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version

2018-10-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > This structure and command have missed qemu version 3.0, so fix it to since > version 3.1. > > Signed-off-by: Zhang Chen Queued > --- > qapi/migration.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Aleksandar Markovic
> Do you mind adding those one line comment when applying this series? > > > +#if defined(CONFIG_USER_ONLY) > >#if defined(CONFIG_USER_ONLY) /* System mode not implemented */ > > > +#if !defined(TARGET_MIPS64) > >#if !defined(TARGET_MIPS64) /* Only O32 user-mode ABI is supported */ I

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Murilo Opsfelder Araujo
Hi, Gerd. On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote: > Indicates support state for somerhing (device, backend, subsystem, ...) > in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. > > Signed-off-by: Gerd Hoffmann > --- > include/qemu/support-state.h | 17

[Qemu-devel] [PULL 4/7] chardev/char-socket: Function headers refactoring

2018-10-30 Thread Marc-André Lureau
From: Julia Suvorova via Qemu-devel Upcoming websocket support requires additional parameters in function headers that are already overloaded. This patch replaces the bunch of parameters with a single structure pointer. Signed-off-by: Julia Suvorova Message-Id:

[Qemu-devel] [PATCH v2 8/8] hw/timer/nrf51_timer: Add nRF51 Timer peripheral

2018-10-30 Thread Steffen Görtz
This patch adds the model for the nRF51 timer peripheral. Currently, only the TIMER mode is implemented. Signed-off-by: Steffen Görtz --- hw/timer/Makefile.objs | 1 + hw/timer/nrf51_timer.c | 358 + hw/timer/trace-events | 5 +

[Qemu-devel] [PATCH v2 5/8] tests: Add bbc:microbit / nRF51 test suite

2018-10-30 Thread Steffen Görtz
The microbit-test includes tests for the nRF51 NVMC peripheral and will host future nRF51 peripheral tests and board-level bbc:microbit tests. Signed-off-by: Steffen Görtz --- tests/Makefile.include | 2 + tests/microbit-test.c | 117 + 2 files

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

2018-10-30 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > [adding qemu-trivial] > > On 03/20/2017 07:27 PM, wangguang wrote: > > Subject: [PATCH] Fix Colo doc secondeary should be secondary > > This line feels redundant compared to the overall mail's subject line. > In turn, that subject could use a space

Re: [Qemu-devel] [PATCH v3 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 16:44, Aleksandar Markovic wrote: From: Aleksandar Markovic Misc changes in comments and strings for R5900. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 12 1 file changed, 12 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] MAINTAINERS: s390: Remove myself

2018-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2018 10:37:15 +0100 Alexander Graf wrote: > I haven't realistically maintained s390 related parts for quite a while > now, so let's remove my name from the MATINAINERS file to reflect reality. > > Signed-off-by: Alexander Graf > --- > MAINTAINERS | 4 > 1 file changed, 4

Re: [Qemu-devel] [PATCH for-3.1] milkymist: Check for failure trying to load BIOS image

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 18:00, Peter Maydell wrote: Check the return value from load_image_targphys(), which tells us whether our attempt to load the BIOS image into RAM failed. (Spotted by Coverity, CID 1190305.) Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PULL 0/7] Chardev patches

2018-10-30 Thread Marc-André Lureau
The following changes since commit 3f3285491dd52014852a56135c90e428c8b507ea: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2018-10-30 14:09:25 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/chrdev-pull-request

[Qemu-devel] [PULL 1/7] websock: fix handshake leak

2018-10-30 Thread Marc-André Lureau
Missed in f69a8bde293. Thanks Valgrind: ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321 ==955==at 0x483A965: realloc (vg_replace_malloc.c:785) ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so) ==955==by 0x49AA05C: g_vasprintf (in

[Qemu-devel] [PATCH v2 3/8] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral

2018-10-30 Thread Steffen Görtz
Add a model of the NRF51 random number generator peripheral. This is a simple random generator that continuously generates new random values after startup. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [PATCH v2 00/19] ACPI reorganization for hardware-reduced support

2018-10-30 Thread Markus Armbruster
Samuel Ortiz writes: > Hi Markus, > > On Mon, Oct 29, 2018 at 06:28:48PM +0100, Markus Armbruster wrote: >> You neglected to cc: maintainers. I'm doing that for you now. >> scripts/get_maintainer.pl can help you finding maintainers. > Sorry about that. I sent a v3 with all maintainers cc'ed. I

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 16:46, Cornelia Huck wrote: On Tue, 30 Oct 2018 15:13:45 +0100 Philippe Mathieu-Daudé wrote: On 30/10/18 15:00, Gerd Hoffmann wrote: On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: +## +# @SupportState: +# +# Indicate Support level of qemu devices,

[Qemu-devel] [PULL 3/7] char-socket: make 'fd' incompatible with 'reconnect'

2018-10-30 Thread Marc-André Lureau
A chardev socket created with the 'fd=' argument is not going to handle reconnection properly by recycling the same fd (or not in a supported way). Let's forbid this case. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- chardev/char-socket.c | 4 1 file changed, 4

Re: [Qemu-devel] [PATCH v2 2/2] x86: hv_evmcs CPU flag support

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 18:38, Vitaly Kuznetsov wrote: > Roman Kagan writes: > >> On Mon, Oct 22, 2018 at 06:55:06PM +0200, Vitaly Kuznetsov wrote: >>> Adds a new CPU flag to enable the Enlightened VMCS KVM feature. >>> QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the >>> version to be

Re: [Qemu-devel] [PULL 0/5] MIPS queue for October 2018, part 5

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 30/10/18 18:28, Aleksandar Markovic wrote: From: Aleksandar Markovic The following changes since commit 3f3285491dd52014852a56135c90e428c8b507ea: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2018-10-30 14:09:25 +) are

Re: [Qemu-devel] [PATCH] Add qemu-ri...@nongnu.org as the RISC-V list

2018-10-30 Thread Alistair Francis
On Tue, Oct 30, 2018 at 10:45 AM Palmer Dabbelt wrote: > > We now have a RISC-V specific QEMU development list. > > Signed-off-by: Palmer Dabbelt Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [Qemu-devel] [PULL 0/5] MIPS queue for October 2018, part 5

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 17:49, Philippe Mathieu-Daudé wrote: > 1h44min between a series posted and the same series sent as pull request is > quite fast for qemu-devel@. > > I'm sorry to complain about this, but this is not the first time I review > your patches and make comment, and see the

Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Laurent Vivier
On 30/10/2018 07:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/scsi/esp.c | 292 >>

<    1   2   3   4   5   >