Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
+-- On Tue, 30 Oct 2018, Paolo Bonzini wrote --+ | | Reviewed-by: Paolo Bonzini | | with one change below: | | > +if ((s->sstat1 & PHASE_MASK) == PHASE_MI) { | > +assert(s->msg_len >= 0); | | should be > 0 as well. Sent patch v3. Thank you. -- Prasad J Pandit / Red Hat

[Qemu-devel] [PATCH v3] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
From: Prasad J Pandit While writing a message in 'lsi_do_msgin', message length value in 'msg_len' could be invalid. Add check to avoid OOB access issue. Signed-off-by: Prasad J Pandit --- hw/scsi/lsi53c895a.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) Update

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS| 1 + > hw/arm/xilinx_zynq.c | 18 ++ > hw/dma/pl330.c | 2 +- > include/hw/dma/pl330.h | 41 + >

Re: [Qemu-devel] [PULL 0/2] Ui 20181029 patches

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 14:18, Gerd Hoffmann wrote: > The following changes since commit 285278ca785f5fa9a570927e1c0958a2ca2b2150: > > Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into > staging (2018-10-27 19:55:08 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-10-30 Thread Gerd Hoffmann
Fixes: CVE-2018-??? Cc: P J P Reported-by: Wangjunqing Suggested-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/audio/fmopl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index e7e578a48e..7199afaa3c 100644 ---

Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 07:28, P J P wrote: > From: Prasad J Pandit > > While writing a message in 'lsi_do_msgin', message length value > in 'msg_len' could be invalid. Add check to avoid OOB access issue. > > Signed-off-by: Prasad J Pandit Reviewed-by: Paolo Bonzini with one change below: > --- >

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-30 Thread Markus Armbruster
Guenter Roeck writes: > On 10/29/18 6:24 AM, Peter Maydell wrote: >> On 27 October 2018 at 12:04, Guenter Roeck wrote: >>> On 10/26/18 3:12 AM, Peter Maydell wrote: Hi Guenter; there's a proposal here to deprecate (and eventually remove) the 'collie' board (strongarm) from QEMU. Is

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 02:16, wj193102 wrote: > Hi, everyone. > When I have installed the QEMU3.0.0 in the Linux on non X86 CPUS, I want > to use user space emulator to run Wine. I can get the source code for Wine > and the RPM file for Wine from the WineHQ web page. > I used to compile Wine

Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-30 Thread Mark Cave-Ayland
On 29/10/2018 23:36, Philippe Mathieu-Daudé wrote: > Hi Marc, Laurent. > > On Mon, Oct 29, 2018 at 2:43 PM Mark Cave-Ayland > wrote: >> >> From: Laurent Vivier >> >> On Sparc and PowerMac, the bit 0 of the address >> selects the register type (control or data) and >> bit 1 selects the channel

Re: [Qemu-devel] [PATCH v2 0/4] Adding LZFSE compression support for DMG block driver.

2018-10-30 Thread Stefan Hajnoczi
On Thu, Aug 16, 2018 at 10:58:33AM -0300, Julio Faracco wrote: > Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to > generate compressed DMGs as an alternative to BZIP2. Possible, Apple > want to keep this algorithm as default in long term. Some years ago, > Apple opened the

Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-30 Thread Marc-André Lureau
Hi On Tue, Oct 30, 2018 at 9:48 AM Peter Xu wrote: > > On Mon, Oct 29, 2018 at 04:57:27PM +0400, Marc-André Lureau wrote: > > Hi, > > > > Here is a small series of fixes for the monitor, mostly related to > > threading issues. > > Hi, Marc-André, Markus, > > I'd be glad to know how you think

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Richard Henderson
On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: > +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) > +{ > +SysBusDevice *busdev; > +DeviceState *dev; > + > +dev = qdev_create(NULL, TYPE_PL330); > +qdev_prop_set_uint8(dev, "num_chnls", 8); > +

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Paolo Bonzini
On 29/10/2018 22:39, Emilio G. Cota wrote: > I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. > Given that now it does not depend on the BQL, it could actually > work in user-mode if called. If we really wanted to make sure > that no user-mode would call it, then a

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 9:18, Richard Henderson wrote: On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) +{ +SysBusDevice *busdev; +DeviceState *dev; + +dev = qdev_create(NULL, TYPE_PL330); +qdev_prop_set_uint8(dev,

Re: [Qemu-devel] [PATCH 0/4] MAINTAINERS: s390: several updates

2018-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2018 22:14:45 +0100 Alexander Graf wrote: > On 29.10.18 16:42, Christian Borntraeger wrote: > > I discussed the following maintainer updates at the kvm forum with > > Conny. This is the first set of changes. > > Can the affected persons please Ack the relevant patches? > > > >

[Qemu-devel] [PATCH] MAINTAINERS: PPC: Remove myself

2018-10-30 Thread Alexander Graf
I haven't really been maintaining any PowerPC code for quite a while now, so let's reflect reality: David does all the work and embedded PPC is in "Odd Fixes" state rather than supported now. Signed-off-by: Alexander Graf --- MAINTAINERS | 30 ++ 1 file changed, 14

[Qemu-devel] [PATCH] MAINTAINERS: DT: Remove myself and degrade

2018-10-30 Thread Alexander Graf
I haven't really maintained the device tree infrastructure in QEMU for a long time by now. I also haven't seen Peter work on the code for the last 2 years, so let's put it into Odd Fixes to make room for others to step up :). Signed-off-by: Alexander Graf --- MAINTAINERS | 3 +-- 1 file

[Qemu-devel] [PATCH] MAINTAINERS: s390: Remove myself

2018-10-30 Thread Alexander Graf
I haven't realistically maintained s390 related parts for quite a while now, so let's remove my name from the MATINAINERS file to reflect reality. Signed-off-by: Alexander Graf --- MAINTAINERS | 4 1 file changed, 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

<    1   2   3   4   5