Re: [Qemu-devel] [PATCH v6 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-11-15 Thread Daniel P . Berrangé
On Thu, Nov 08, 2018 at 02:23:18AM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Oct 19, 2018 at 5:47 PM Daniel P. Berrangé > wrote: > > diff --git a/qemu-options.hx b/qemu-options.hx > > index a1c3e0e59c..a9654b8115 100644 > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > @@ -4447,6

Re: [Qemu-devel] [PATCH V2] net/filter-rewriter.c: Fix coverity static analysis issue

2018-11-15 Thread Peter Maydell
On 2 November 2018 at 02:21, Jason Wang wrote: > > On 2018/10/31 上午8:50, Zhang Chen wrote: >> >> The original code just follow the TCP state diagram, >> but in this case, we can skip the TCPS_TIME_WAIT state to simplify >> the implementation. >> >> Signed-off-by: Zhang Chen >> --- >>

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181114233831.10374-1-ehabk...@redhat.com Type: series Subject: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PULL 01/22] target/ppc: add external PID support

2018-11-15 Thread Peter Maydell
On 8 November 2018 at 12:16, David Gibson wrote: > From: Roman Kapl > > External PID is a mechanism present on BookE 2.06 that enables application to > store/load data from different address spaces. There are special version of > some > instructions, which operate on alternate address space,

Re: [Qemu-devel] [PATCH] keymaps: detect recursive keyboard layout file

2018-11-15 Thread Li Qiang
Gerd Hoffmann 于2018年11月15日周四 下午6:15写道: > On Thu, Nov 15, 2018 at 01:04:23AM -0800, Li Qiang wrote: > > When the parse_keyboard_layout() find a "include " line > > in the keyboard layout file, it will call parse_keyboard_layout() > > to perform a recursive parse. If the keyboard layout is

Re: [Qemu-devel] [PATCH] simple firmware.json test tool

2018-11-15 Thread Philippe Mathieu-Daudé
On 15/11/18 8:56, Gerd Hoffmann wrote: Hi, Perhaps print a few shell commands first? Such as: ( VARSTORE=$(mktemp) trap 'rm -f -- "$VARSTORE"' EXIT cat -- '[VARSTORE_TEMPLATE]' >> "$VARSTORE" qemu ... ) It really does take separate actions, just like when

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-15 Thread David Hildenbrand
On 15.11.18 10:48, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 14.11.18 18:38, Markus Armbruster wrote: >>> David Hildenbrand writes: >>> The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in

Re: [Qemu-devel] [PATCH] keymaps: detect recursive keyboard layout file

2018-11-15 Thread Gerd Hoffmann
On Thu, Nov 15, 2018 at 01:04:23AM -0800, Li Qiang wrote: > When the parse_keyboard_layout() find a "include " line > in the keyboard layout file, it will call parse_keyboard_layout() > to perform a recursive parse. If the keyboard layout is malformed > by adding a line include itself, this can

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

2018-11-15 Thread Philippe Mathieu-Daudé
On 15/11/18 7:05, Li Qiang wrote: And also the g_malloc doesn't need check return value, remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- target/i386/hax-all.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/target/i386/hax-all.c

[Qemu-devel] [PATCH] vl.c: remove outdated comment

2018-11-15 Thread Li Qiang
Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- vl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/vl.c b/vl.c index fa25d1ae2d..ae63018a1d 100644 --- a/vl.c +++ b/vl.c @@ -1522,9 +1522,6 @@ static int machine_help_func(QemuOpts *opts, MachineState *machine) return 1; }

Re: [Qemu-devel] [PATCH qemu] configure/fdt: Use more strict test for libfdt version

2018-11-15 Thread Daniel P . Berrangé
On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote: > The libfdt installed in the system is preferred to the dtc submodule by > default. The recent libfdt update added a new symbol - fdt_check_full - > and this breaks compile if there is an older libfdt installed in > the system.

Re: [Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests

2018-11-15 Thread Markus Armbruster
David Hildenbrand writes: > On 14.11.18 17:21, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> Basically copy all int64 list tests but adapt them to work on uint64 >>> instead. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> tests/test-string-input-visitor.c | 71

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-15 Thread Markus Armbruster
David Hildenbrand writes: > On 14.11.18 18:38, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> The input visitor has some problems right now, especially >>> - unsigned type "Range" is used to process signed ranges, resulting in >>> inconsistent behavior and ugly/magical code >>>

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Daniel P . Berrangé
On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology)

Re: [Qemu-devel] Are FreeBSD guest images working?

2018-11-15 Thread Philippe Mathieu-Daudé
On 15/11/18 9:58, Peter Xu wrote: Hi, the list, I am trying to boot a FreeBSD guest but failed. It hangs at the kernel booting phase: /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68 syms=[0x8+0x159ee8+0x8 Booting... (nothing more) It's just as simple as downloading the image and

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

2018-11-15 Thread Alex Bennée
Li Qiang writes: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang Reviewed-by: Alex Bennée > --- > target/i386/hax-all.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git

Re: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: tcg: Implement addex instruction

2018-11-15 Thread David Gibson
On Thu, Nov 15, 2018 at 02:22:59PM +1100, Suraj Jitindar Singh wrote: > Implement the addex instruction introduced in ISA V3.00 in qemu tcg. > > The add extended using alternate carry bit (addex) instruction performs > the same operation as the add extended (adde) instruction, but using the >

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

2018-11-15 Thread Peter Maydell
On 15 November 2018 at 09:51, Alex Bennée wrote: > > Alistair Francis writes: > >> On 14/11/2018 3:12 am, Peter Maydell wrote: >>> On 13 November 2018 at 20:10, Alistair Francis wrote: These two and the Xilinx boards seem a little out of place in this patch. I agree they probably

[Qemu-devel] [PATCH v6 11/16] gdbstub: add support for extended mode packet

2018-11-15 Thread Luc Michel
Add support for the '!' extended mode packet. This is required for the multiprocess extension. Signed-off-by: Luc Michel --- gdbstub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index eec1cf0d09..ada53ac559 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1294,10

Re: [Qemu-devel] [PATCH] Support u-boot noload images for arm as used by NetBSD/evbarm GENERIC kernel.

2018-11-15 Thread Peter Maydell
On 15 November 2018 at 09:22, Nick Hudson wrote: > ping Hi; thanks for the ping. This patch is in my to-review queue but it may be a little while til I get to it, as I'm currently prioritising work for the 3.1 release, and this will be a new feature for 4.0. thanks -- PMM

[Qemu-devel] [PATCH v6 08/16] gdbstub: add multiprocess support to Xfer:features:read:

2018-11-15 Thread Luc Michel
Change the Xfer:features:read: packet handling to support the multiprocess extension. This packet is used to request the XML description of the CPU. In multiprocess mode, different descriptions can be sent for different processes. This function now takes the process to send the description for as

[Qemu-devel] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets

2018-11-15 Thread Luc Michel
Change the sC packet handling to support the multiprocess extension. Instead of returning the first thread, we return the first thread of the current process. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- gdbstub.c | 11 --- 1 file

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

2018-11-15 Thread Alex Bennée
Alistair Francis writes: > On 14/11/2018 3:12 am, Peter Maydell wrote: >> On 13 November 2018 at 20:10, Alistair Francis wrote: >>> These two and the Xilinx boards seem a little out of place in this >>> patch. I agree they probably aren't maintained as well as they should >>> be, but the

[Qemu-devel] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached

2018-11-15 Thread Luc Michel
When gdb_set_stop_cpu() is called with a CPU associated to a process currently not attached by the GDB client, return without modifying the stop CPU. Otherwise, GDB gets confused if it receives packets with a thread-id it does not know about. Signed-off-by: Luc Michel Acked-by: Alistair Francis

Re: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: tcg: Implement addex instruction

2018-11-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181115032259.23968-1-sjitindarsi...@gmail.com Type: series Subject: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: tcg: Implement addex instruction === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v6 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters

2018-11-15 Thread Luc Michel
Create two separate CPU clusters for APUs and RPUs. Signed-off-by: Luc Michel Reviewed-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 3 +++ hw/arm/xlnx-zynqmp.c | 21 + 2 files changed, 20 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v6 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo

2018-11-15 Thread Luc Michel
Change the thread info related packets handling to support multiprocess extension. Add the CPUs class name in the extra info to help differentiate them in multiprocess mode. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 35 +-- 1

[Qemu-devel] [PATCH v6 10/16] gdbstub: add multiprocess support to 'D' packets

2018-11-15 Thread Luc Michel
'D' packets are used by GDB to detach from a process. In multiprocess mode, the PID to detach from is sent in the request. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 60 --- 1 file changed, 53 insertions(+),

[Qemu-devel] [PATCH v6 12/16] gdbstub: add support for vAttach packets

2018-11-15 Thread Luc Michel
Add support for the vAttach packets. In multiprocess mode, GDB sends them to attach to additional processes. Signed-off-by: Luc Michel --- gdbstub.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index ada53ac559..0427d1c4f0 100644

[Qemu-devel] [PATCH v6 09/16] gdbstub: add multiprocess support to gdb_vm_state_change()

2018-11-15 Thread Luc Michel
Add support for multiprocess extension in gdb_vm_state_change() function. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 4cbc81ae5b..5df9929f92 100644

[Qemu-devel] [PATCH v6 13/16] gdbstub: processes initialization on new peer connection

2018-11-15 Thread Luc Michel
When a new connection is established, we set the first process to be attached, and the others detached. The first CPU of the first process is selected as the current CPU. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis --- gdbstub.c | 20 +++- 1 file changed, 15

[Qemu-devel] [PATCH v6 05/16] gdbstub: add multiprocess support to vCont packets

2018-11-15 Thread Luc Michel
Add the gdb_first_cpu() and gdb_next_cpu() to iterate over all the CPUs in currently attached processes. Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to iterate over CPUs of a given process. Use them to add multiprocess extension support to vCont packets. Signed-off-by: Luc

[Qemu-devel] [PATCH v6 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets

2018-11-15 Thread Luc Michel
Add a couple of helper functions to cope with GDB threads and processes. The gdb_get_process() function looks for a process given a pid. The gdb_get_cpu() function returns the CPU corresponding to the (pid, tid) pair given as parameters. The read_thread_id() function parses the thread-id sent

[Qemu-devel] [PATCH v6 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-15 Thread Luc Michel
The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It checks if the CPU is a direct child of a CPU cluster. If it is, the returned PID is the cluster ID plus one (cluster IDs start at 0, GDB PIDs at 1). When the CPU is not a child of such a container, the PID of the first

[Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support

2018-11-15 Thread Luc Michel
Add multiprocess extension support by enabling multiprocess mode when the peer requests it, and by replying that we actually support it in the qSupported reply packet. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- gdbstub.c | 6 ++ 1 file

[Qemu-devel] [PATCH v6 02/16] gdbstub: introduce GDB processes

2018-11-15 Thread Luc Michel
Add a structure GDBProcess that represent processes from the GDB semantic point of view. CPUs can be split into different processes, by grouping them under different cpu-cluster objects. Each occurrence of a cpu-cluster object implies the existence of the corresponding process in the GDB stub.

[Qemu-devel] [PATCH v6 01/16] hw/cpu: introduce CPU clusters

2018-11-15 Thread Luc Michel
This commit adds the cpu-cluster type. It aims at gathering CPUs from the same cluster in a machine. For now it only has a `cluster-id` property. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Edgar

[Qemu-devel] [PATCH v6 00/16] gdbstub: support for the multiprocess extension

2018-11-15 Thread Luc Michel
changes since v5: - patch 1Rebased on top of master - patch 2Cluster ID handling hardening to ensure uint32_t overflow won't cause PID 0 to be used [Edgar] - patch 2Fix the GDB process ordering function to avoid uint32_t overflow when comparing two

Re: [Qemu-devel] [PATCH] Support u-boot noload images for arm as used by NetBSD/evbarm GENERIC kernel.

2018-11-15 Thread Nick Hudson
ping On 07/11/2018 13:19, Nick Hudson wrote: noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point.  Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately Signed-off-by:

Re: [Qemu-devel] [PATCH v2 for-4.0 00/13] block: byte-based blocking read/write

2018-11-15 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: 20181115020334.1189829-1-ebl...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 for-4.0

[Qemu-devel] [PATCH] keymaps: detect recursive keyboard layout file

2018-11-15 Thread Li Qiang
When the parse_keyboard_layout() find a "include " line in the keyboard layout file, it will call parse_keyboard_layout() to perform a recursive parse. If the keyboard layout is malformed by adding a line include itself, this can cause an infinite parse. Thus cause qemu a segv. This patch avoid

Re: [Qemu-devel] [PATCH v2 for-4.0 00/13] block: byte-based blocking read/write

2018-11-15 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: 20181115020334.1189829-1-ebl...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 for-4.0 00/13]

[Qemu-devel] [PATCH v4 1/4] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-15 Thread xiezhide
This patch factor out throttle parameter parse code to common function which will be used by block and fsdev. rename function throttle_parse_options to throttle_parse_group to resolve function name conflict Signed-off-by: xiezhide --- block/throttle.c| 6 ++-- blockdev.c

[Qemu-devel] [PATCH v4 4/4] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ qapi/tlimits.json

[Qemu-devel] [PATCH v4 3/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- Makefile| 9 + Makefile.objs | 4 ++ fsdev/qemu-fsdev-dummy.c| 11 + fsdev/qemu-fsdev-throttle.c | 98

[Qemu-devel] [PATCH v4 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (4): fsdev-throttle-qmp: factor out throttle code to reuse code fsdev-throttle-qmp: move struct

[Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-15 Thread xiezhide
this patch move ThrottleLimits to new file and rename struct field with common format Signed-off-by: xiezhide --- Makefile | 9 +++ Makefile.objs | 4 ++ blockdev.c| 51 +--- qapi/block-core.json | 122 +

[Qemu-devel] Are FreeBSD guest images working?

2018-11-15 Thread Peter Xu
Hi, the list, I am trying to boot a FreeBSD guest but failed. It hangs at the kernel booting phase: /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68 syms=[0x8+0x159ee8+0x8 Booting... (nothing more) It's just as simple as downloading the image and boot so I can't think of anything

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_malloc0

2018-11-15 Thread Laurent Vivier
On 15/11/2018 07:05, Li Qiang wrote: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > target/i386/hax-all.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > Reviewed-by: Laurent

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-15 Thread Luc Michel
On 11/14/18 11:27 AM, Edgar E. Iglesias wrote: > On Wed, Nov 14, 2018 at 09:43:27AM +0100, Luc Michel wrote: >> Hi Edgar, >> >> On 11/13/18 12:06 PM, Edgar E. Iglesias wrote: >>> On Sat, Nov 10, 2018 at 09:11:34AM +0100, Luc Michel wrote: The gdb_get_cpu_pid() function does the PID lookup

[Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

2018-11-15 Thread root
From: Li Qiang And also the g_malloc doesn't need check return value, remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- target/i386/hax-all.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c

<    1   2   3   4