BITMAP_LAST_WORD_MASK(nbits) returns 0x when "nbits=0", which
makes bitmap_count_one fail to handle the "nbits=0" case. It appears to be
preferred to remain BITMAP_LAST_WORD_MASK identical to the kernel
implementation that it is ported from.
So this patch fixes bitmap_count_one to handle
Count the number of 1s in a bitmap starting from an offset.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
Reviewed-by: Dr. David Alan Gilbert
---
include/qemu/bitmap.h | 13 +
1 file changed, 13 insertions(+)
diff --git
On 14 November 2018 at 10:16, Cornelia Huck wrote:
> The following changes since commit 6ff144698935e8bdbc96d255cf49b1a7d54174ac:
>
> Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag'
> into staging (2018-11-13 12:32:30 +)
>
> are available in the Git repository
Add support for the '!' extended mode packet. This is required for the
multiprocess extension.
Signed-off-by: Luc Michel
---
gdbstub.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index eec1cf0d09..ada53ac559 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1294,10
On 15 November 2018 at 09:51, Alex Bennée wrote:
>
> Alistair Francis writes:
>
>> On 14/11/2018 3:12 am, Peter Maydell wrote:
>>> On 13 November 2018 at 20:10, Alistair Francis wrote:
These two and the Xilinx boards seem a little out of place in this
patch. I agree they probably
Li Qiang writes:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
Reviewed-by: Alex Bennée
> ---
> target/i386/hax-all.c | 15 +++
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git
On 15/11/18 9:58, Peter Xu wrote:
Hi, the list,
I am trying to boot a FreeBSD guest but failed. It hangs at the
kernel booting phase:
/boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68 syms=[0x8+0x159ee8+0x8
Booting...
(nothing more)
It's just as simple as downloading the image and
On Thu, Nov 08, 2018 at 02:23:18AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Oct 19, 2018 at 5:47 PM Daniel P. Berrangé
> wrote:
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index a1c3e0e59c..a9654b8115 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -4447,6
On 2 November 2018 at 02:21, Jason Wang wrote:
>
> On 2018/10/31 上午8:50, Zhang Chen wrote:
>>
>> The original code just follow the TCP state diagram,
>> but in this case, we can skip the TCPS_TIME_WAIT state to simplify
>> the implementation.
>>
>> Signed-off-by: Zhang Chen
>> ---
>>
On Thu, Nov 15, 2018 at 09:33:08PM +1100, David Gibson wrote:
> On Thu, Nov 15, 2018 at 10:11:12AM +, Daniel P. Berrangé wrote:
> > On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote:
> > > The libfdt installed in the system is preferred to the dtc submodule by
> > > default.
The ram save state notifier callback, for example the free page
optimization offerred by virtio-balloon, may need to check if
postcopy is in use, so move migrate_postcopy() to the outside header.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
CC:
This patch adds a function to enable a precopy notifier callback outside
the migration subsystem to disable the bulk stage flag. This is needed by
the free page optimization offered by virtio-balloon.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
The bitmap mutex is used to synchronize threads to update the dirty
bitmap and the migration_dirty_pages counter. For example, the free
page optimization clears bits of free pages from the bitmap in an
iothread context. This patch makes migration_bitmap_clear_dirty update
the bitmap and counter
The new feature enables the virtio-balloon device to receive hints of
guest free pages from the free page vq.
A notifier is registered to the migration precopy notifier chain. The
notifier calls free_page_start after the migration thread syncs the dirty
bitmap, so that the free page optimization
On Thu, 15 Nov 2018 10:05:59 +
Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote:
> > Many of the current virtio-*-pci device types actually represent
> > 3 different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0
> Hi, the list,
>
> I am trying to boot a FreeBSD guest but failed. It hangs at the
> kernel booting phase:
>
> /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68
> syms=[0x8+0x159ee8+0x8
> Booting...
> (nothing more)
>
> It's just as simple as downloading the image and boot so I can't
On 14.11.18 17:09, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> Let's use the new function.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> qapi/string-input-visitor.c | 6 ++
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/qapi/string-input-visitor.c
On Wed, 14 Nov 2018 21:38:31 -0200
Eduardo Habkost wrote:
> diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h
> index 813082b0d7..1d2a11504f 100644
> --- a/hw/virtio/virtio-pci.h
> +++ b/hw/virtio/virtio-pci.h
(...)
> +/**
> + * VirtioPCIDeviceTypeInfo:
> + *
> + * Template for
On 15/11/2018 12:46, Peter Maydell wrote:
> Coverity complains (CID 1390847) about some dead code in
> do_sigreturn(). This is an if (err) clause that can never be
> true, copied from the kernel (where __get_user returns an error).
> The one code path that could report an error is in the
>
Record the command line that was used to start QEMU. This can be
useful for debugging.
Signed-off-by: Paolo Bonzini
---
tests/libqtest.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index
On 11/14/18 2:00 AM, Emilio G. Cota wrote:
> The following might be related: I'm seeing segfaults with -smp 8
> and beyond when doing bootup+shutdown of an aarch64 guest on
> an x86-64 host.
I'm not seeing that. Anything else special on the command-line?
Are the segv in the code_gen_buffer or
Coverity complains (CID 1390847) about some dead code in
do_sigreturn(). This is an if (err) clause that can never be
true, copied from the kernel (where __get_user returns an error).
The one code path that could report an error is in the
currently commented-out pseudocode for handling FPU
On Fri, Nov 9, 2018 at 9:39 PM Marc-André Lureau
wrote:
>
> After iov_discard_front(), the iov may be smaller than its initial
> size. Fixes the heap-buffer-overflow spotted by ASAN:
>
> ==9036==ERROR: AddressSanitizer: heap-buffer-overflow on address
> 0x606001e0 at pc 0x7fe632eca3f0 bp
On 17 October 2018 at 10:51, Stefan Hajnoczi wrote:
> On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Theoretically possible that we finish the skipping loop with bs = NULL
>> and the following code will crash trying to dereference it. Fix that.
>>
>>
On Thu, Aug 30, 2018 at 8:50 PM Marc-André Lureau
wrote:
>
> Now that the VhostUserMsg.request field is used for both master &
> slave requests, since commit d84599f56c820d8c1ac9928a76500dcdfbbf194d:
>
> contrib/libvhost-user/libvhost-user.c:953:20: error: implicit conversion from
> enumeration
On 4 November 2018 at 07:42, Seth K wrote:
> I corrected these 2 memory regions based on specifications from the chip
> manufacturer. The existing ranges seem to overlap and and cause odd
> behavior and/or crashes when trying to set up multiple UARTs,
> I also played with changing
Ping
Li Qiang 于2018年11月1日周四 下午1:59写道：
> parse_fw_cfg() reports "can't load" without further details. Get
> the details from g_file_get_contents(), and include them in the
> error message.
>
> Signed-off-by: Li Qiang
> ---
> vl.c | 6 --
> 1 file changed, 4 insertions(+), 2
Gerd Hoffmann (4):
keymaps: remove modifiers include
keymaps: drop nl-be map
keymaps: remove common include
keymaps: drop support for include files
ui/keymaps.c | 7 +-
pc-bios/keymaps/common| 157
pc-bios/keymaps/modifiers |
It doesn't define any keys, only includes "common".
Which makes it effectively an "en-us" map.
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/nl-be | 3 ---
1 file changed, 3 deletions(-)
delete mode 100644 pc-bios/keymaps/nl-be
diff --git a/pc-bios/keymaps/nl-be b/pc-bios/keymaps/nl-be
Signed-off-by: Gerd Hoffmann
---
ui/keymaps.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/ui/keymaps.c b/ui/keymaps.c
index 085889b555..6e44f738ed 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -115,10 +115,9 @@ static int parse_keyboard_layout(kbd_layout_t *k,
"common" is the only file using it, so we can just include it directly.
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/common| 19 ++-
pc-bios/keymaps/modifiers | 18 --
2 files changed, 18 insertions(+), 19 deletions(-)
delete mode 100644
Copy the content into the sl and sv files (the only ones left which are
not generated by qemu-keymap).
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/common | 174
pc-bios/keymaps/sl | 177 -
On Mon, 5 Nov 2018 02:40:35 +0100
Samuel Ortiz wrote:
> From: Yang Zhong
>
> The ACPI MCFG getter is not x86 specific and could be called from
> anywhere within generic ACPI API, so let's export it.
So far it's x86 or more exactly q35 specific thing,
for example it won't work with arm/virt
On Mon, 5 Nov 2018 02:40:37 +0100
Samuel Ortiz wrote:
> This property is currently defined under i386/pc while it only describes
> a region size that's eventually fetched from the AML ACPI code.
>
> We can make it more generic and shareable across machine types by moving
> it to
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> slirp/libslirp.h | 6 ++
> net/slirp.c | 19 +++
> slirp/if.c | 2 +-
> slirp/ip6_icmp.c | 6 --
> slirp/slirp.c| 11 ++-
> 5 files changed, 36
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> slirp/libslirp.h | 6 ++
> slirp/slirp.h| 2 +-
> net/slirp.c | 23 +++
> slirp/ip6_icmp.c | 21 ++---
> 4 files changed, 40 insertions(+), 12 deletions(-)
Hello,
As I got no replies to my last mails, here again the full patch
set (rebased on current master) in the hope to get this merged.
The first few patches are cleanup, the last two patches add the
pmemload feature. Only 5/6 requires an ack (although all
mentioned issues should be fixed), all
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
i is only 32-bit. To prevent possible truncation when dumping large
memory regions use l which is target long.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
Reviewed-by: Dr. David Alan Gilbert
---
hmp-commands.hx | 4 ++--
hmp.c | 4 ++--
2 files changed, 4
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
This enables completion for the filename arguments.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
Reviewed-by: Dr. David Alan Gilbert
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index
qemu_open() allow passing file descriptors to qemu which is used in
restricted environments like libvirt where open() is prohibited.
Suggested-by: Eric Blake
Signed-off-by: Simon Ruderich
Reviewed-by: Eric Blake
---
cpus.c | 20 ++--
1 file changed, 10 insertions(+), 10
On 14 November 2018 at 13:10, Alex Bennée wrote:
> The following changes since commit 186ac05f749c69e98030f037aa930ff2bc4ad7fb:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging
> (2018-11-13 11:45:16 +)
>
> are available in the Git
It's the natural type for object sizes and matches the return value of
sizeof(buf).
Signed-off-by: Simon Ruderich
Reviewed-by: Eric Blake
---
cpus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index c0d796f441..ee54595733 100644
--- a/cpus.c
+++
On 14/11/2018 13:36, Marc-André Lureau wrote:
> qemu_set_nonblock() does some event registration with the main loop on
> win32, let's have a callback.
>
> Signed-off-by: Marc-André Lureau
Perhaps a better interface would be register_poll_fd, which is called
before a file descriptor can be
On 11/15/18 3:02 AM, no-re...@patchew.org wrote:
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181115020334.1189829-1-ebl...@redhat.com
Type:
On 15/11/2018 13:29, Paolo Bonzini wrote:
> Record the command line that was used to start QEMU. This can be
> useful for debugging.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/libqtest.c | 26 +++---
> 1 file changed, 15 insertions(+), 11 deletions(-)
It seems to be a
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Replace strong dependency on QEMU.
>
> Signed-off-by: Marc-André Lureau
> ---
> slirp/libslirp.h | 1 +
> net/slirp.c | 6 ++
> slirp/slirp.c| 2 +-
> 3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/slirp/libslirp.h
On 10/11/2018 14:45, Marc-André Lureau wrote:
> Let's not mix command line and chardev pointers.
>
> Signed-off-by: Marc-André Lureau
This would probably be a good place to implement the suggestion I have
just sent.
Paolo
> ---
> slirp/libslirp.h | 2 +-
> slirp/misc.h | 4 ++--
>
On 10/11/2018 14:45, Marc-André Lureau wrote:
> EMU_RSH handling was dropped in commit
> 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a.
>
> The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra
> looks unsafe (double free is likely to occur).
>
> Signed-off-by: Marc-André Lureau
>
On 11/15/18 5:09 AM, David Hildenbrand wrote:
Three more: in qobject-input-visitor.c's
qobject_input_type_number_keyval(),
This one is interesting, as it properly bails out when parsing "inf"
(via isFinite()). - should we do the same for the string input visitor?
Especially, should we forbid
301 - 351 of 351 matches
Mail list logo
