[Qemu-devel] [PATCH V9 5/9] hw/arm/virt: add pvpanic device in virt acpi table

2018-11-26 Thread Peng Hao
Add pvpanic device in virt acpi table, so when kenrel command line uses acpi=force, kernel can get info from acpi table. Signed-off-by: Peng Hao --- hw/arm/virt-acpi-build.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c

[Qemu-devel] [PATCH V9 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-26 Thread Peng Hao
Prepare for pvpanic-mmio configure interface. Signed-off-by: Peng Hao --- hw/arm/sysbus-fdt.c | 2 ++ hw/arm/virt.c | 1 + hw/misc/pvpanic.c | 10 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index ad698d4..34577f3

[Qemu-devel] [PATCH V9 3/9] hw/misc/pvpanic: Add the MMIO interface

2018-11-26 Thread Peng Hao
Add pvpanic new type "TYPE_PVPANIC_MMIO" Signed-off-by: Peng Hao --- hw/misc/pvpanic.c | 50 +++ include/hw/misc/pvpanic.h | 1 + 2 files changed, 47 insertions(+), 4 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index

[Qemu-devel] [PATCH V9 1/9] hw/misc/pvpanic: Build the pvpanic device in $(common-obj)

2018-11-26 Thread Peng Hao
From: Philippe Mathieu-Daudé The 'pvpanic' ISA device can be use by any machine with an ISA bus. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Peng Hao --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH V9 2/9] hw/misc/pvpanic: Cosmetic renaming

2018-11-26 Thread Peng Hao
From: Philippe Mathieu-Daudé To ease the MMIO device addition in the next patch, rename: - ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE. - MemoryRegion io -> mr. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Peng Hao --- hw/misc/pvpanic.c | 28 1 file changed,

[Qemu-devel] [PATCH V9 0/9] add pvpanic mmio support

2018-11-26 Thread Peng Hao
The first patches are simple cleanups: - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile it once for the x86/arm/aarch64 archs, - patch 2 simply renames ISA fields/definitions to generic ones. Then instead of add/use the MMIO pvpanic device in

[Qemu-devel] [PATCH V9 4/9] hw/arm/virt: Use the pvpanic device

2018-11-26 Thread Peng Hao
Add pvpanic device in arm virt machine. Signed-off-by: Peng Hao --- default-configs/arm-softmmu.mak | 1 + hw/arm/virt.c | 21 + include/hw/arm/virt.h | 1 + 3 files changed, 23 insertions(+) diff --git a/default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH for-3.1 2/2] iotests: Test migration with -blockdev

2018-11-26 Thread Kevin Wolf
Check that block node activation and inactivation works with a block graph that is built with individually created nodes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/234 | 105 + tests/qemu-iotests/234.out | 27 ++ tests/qemu-iotests/group

[Qemu-devel] [PATCH for-3.1 0/2] block: Fix crash on migration with explicit child nodes

2018-11-26 Thread Kevin Wolf
Kevin Wolf (2): block: Don't inactivate children before parents iotests: Test migration with -blockdev block.c| 22 tests/qemu-iotests/234 | 105 + tests/qemu-iotests/234.out | 27 ++ tests/qemu-iotests/group |

[Qemu-devel] [PATCH for-3.1 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Kevin Wolf
bdrv_child_cb_inactivate() asserts that parents are already inactive when children get inactivated. This precondition is necessary because parents could still issue requests in their inactivation code. When block nodes are created individually with -blockdev, all of them are monitor owned and

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0

2018-11-26 Thread Alex Bennée
Li Qiang writes: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-triv...@nongnu.org > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Markus Armbruster > Signed-off-by: Li Qiang Reviewed-by: Alex Bennée > --- > target/i386/hax-all.c | 15

Re: [Qemu-devel] [RFC 12/48] atomic_template: define pre/post macros

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Nov 22, 2018 at 17:12:34 +, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > In preparation for plugin support. >> > >> > Signed-off-by: Emilio G. Cota >> >> More macros for the macro-god. I guess this works but I wonder if it's >> possible to do a

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread Cédric Le Goater
On 11/26/18 6:39 AM, David Gibson wrote: > On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: >> >> +/* >> + * Returns whether the event notification should be forwarded. >> + */ >> +static bool xive_source_lsi_trigger(XiveSource *xsrc, uint32_t >> srcno) >

Re: [Qemu-devel] [RFC 22/48] cpu: hook plugin vcpu events

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Nov 23, 2018 at 17:10:53 +, Alex Bennée wrote: >> Emilio G. Cota writes: > (snip) >> > @@ -1322,12 +1323,21 @@ static void qemu_tcg_rr_wait_io_event(CPUState >> > *cpu) >> > >> > static void qemu_wait_io_event(CPUState *cpu) >> > { >> > +bool asleep

Re: [Qemu-devel] [RFC 10/48] exec: export do_tb_flush

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Nov 22, 2018 at 17:09:22 +, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > This will be used by plugin code to flush the code cache as well >> > as doing other bookkeeping in a safe work environment. >> >> This seems a little excessive given the

Re: [Qemu-devel] [RFC 19/48] translate-all: notify plugin code of tb_flush

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Nov 23, 2018 at 17:00:59 +, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > Signed-off-by: Emilio G. Cota >> > --- >> > accel/tcg/translate-all.c | 6 ++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git a/accel/tcg/translate-all.c

Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue

2018-11-26 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote: > > > > +#include "qemu/osdep.h" > > > +#include "qemu/bitmap.h" > > > +#include "qemu/threaded-workqueue.h" > > > + > > > +#define SMP_CACHE_BYTES 64 > > > > That's architecture

Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations

2018-11-26 Thread Igor Mammedov
On Fri, 23 Nov 2018 11:11:50 -0500 "Michael S. Tsirkin" wrote: > On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote: > > * arm/virt is broken but it looks like linux doesn't care, lets fix it > > anyways > > * x86, got lucky since we didn't use extended fields, > >fix it so

[Qemu-devel] [PATCH] doc: fix the configuration path

2018-11-26 Thread Marc-André Lureau
Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1644985 Signed-off-by: Marc-André Lureau --- Makefile | 9 ++--- qemu-ga.texi | 4 ++-- 2 files changed, 8

Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations

2018-11-26 Thread Samuel Ortiz
On Mon, Nov 26, 2018 at 11:31:25AM +0100, Igor Mammedov wrote: > On Fri, 23 Nov 2018 11:11:50 -0500 > "Michael S. Tsirkin" wrote: > > > On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote: > > > * arm/virt is broken but it looks like linux doesn't care, lets fix it > > > anyways > >

[Qemu-devel] [PATCH v2 1/2] pc: acpi: use correct RSDT length for checksum

2018-11-26 Thread Igor Mammedov
AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) for checksum calculation isn't correct since we are adding extra 16 bytes. But acpi_data_push() zeroes out table, so just by luck we are summing up exta zeros which still yelds correct checksum. Fix it up by explicitly

Re: [Qemu-devel] [PATCH v5 24/24] docs: Update pvrdma device documentation

2018-11-26 Thread Marcel Apfelbaum
Re-sending the comments, some of the recipients didn't get it, Thanks, Marcel On 11/25/18 9:51 AM, Marcel Apfelbaum wrote: On 11/22/18 2:14 PM, Yuval Shaia wrote: Interface with the device is changed with the addition of support for MAD packets. Adjust documentation accordingly. While

Re: [Qemu-devel] [PATCH] ehci: fix fetch qtd race

2018-11-26 Thread li qiang
在 2018/11/26 18:08, Gerd Hoffmann 写道: > The token field contains the (guest-filled) state of the qtd, which > indicates whenever the other fields are valid or not. So make sure > we read the token first, otherwise we may end up with an stale next > pointer: > >(1) ehci reads next >(2)

Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue

2018-11-26 Thread Paolo Bonzini
On 26/11/18 09:18, Xiao Guangrong wrote: >> >>> +static uint64_t get_free_request_bitmap(Threads *threads, >>> ThreadLocal *thread) >>> +{ >>> +    uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap; >>> + >>> +    request_fill_bitmap = >>> atomic_rcu_read(>request_fill_bitmap); >>>

Re: [Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum

2018-11-26 Thread Igor Mammedov
On Fri, 23 Nov 2018 11:10:01 -0500 "Michael S. Tsirkin" wrote: > On Thu, Nov 22, 2018 at 11:29:33AM +0100, Igor Mammedov wrote: > > AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) > > for checksum calculation isn't correct since we are adding extra 16 bytes. > > But

Re: [Qemu-devel] [PATCH v2] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-26 Thread Gerd Hoffmann
On Tue, Nov 20, 2018 at 04:34:19PM +0800, linzhecheng wrote: > If no kernel driver is active, we can already claim and perform I/O on > it without detaching it. Queued for 3.1 thanks, Gerd

Re: [Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use

2018-11-26 Thread Gerd Hoffmann
On Fri, Nov 23, 2018 at 02:46:46PM +0800, linzhecheng wrote: > From: Wang Xin > > The cirrus bank0/1 offset should be updated before we update the vram's alias > offset. Queued for 3.1 thanks, Gerd

[Qemu-devel] [PATCH] ehci: fix fetch qtd race

2018-11-26 Thread Gerd Hoffmann
The token field contains the (guest-filled) state of the qtd, which indicates whenever the other fields are valid or not. So make sure we read the token first, otherwise we may end up with an stale next pointer: (1) ehci reads next (2) guest writes next (3) guest writes token (4) ehci

Re: [Qemu-devel] [PATCH v5 10/24] qapi: Define new QMP message for pvrdma

2018-11-26 Thread Yuval Shaia
On Mon, Nov 26, 2018 at 11:01:59AM +0100, Markus Armbruster wrote: > Yuval Shaia writes: > > > pvrdma requires that the same GID attached to it will be attached to the > > backend device in the host. > > > > A new QMP messages is defined so pvrdma device can broadcast any change > > made to its

Re: [Qemu-devel] [PATCH v5 10/24] qapi: Define new QMP message for pvrdma

2018-11-26 Thread Markus Armbruster
Yuval Shaia writes: > pvrdma requires that the same GID attached to it will be attached to the > backend device in the host. > > A new QMP messages is defined so pvrdma device can broadcast any change > made to its GID table. This event is captured by libvirt which in turn > will update the GID

Re: [Qemu-devel] [question] live migration about redir-usb

2018-11-26 Thread Gerd Hoffmann
On Mon, Nov 26, 2018 at 09:07:32AM +, linzhecheng wrote: > > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Monday, November 26, 2018 4:50 PM > > To: linzhecheng > > Cc: qemu-devel@nongnu.org; wangxin (U) ; > > Zhoujian (jay) > > Subject: Re:

Re: [Qemu-devel] [PATCH 2/2] vfio-ccw: support async command subregion

2018-11-26 Thread Cornelia Huck
On Fri, 23 Nov 2018 15:13:12 +0100 Pierre Morel wrote: > On 22/11/2018 17:54, Cornelia Huck wrote: > > A vfio-ccw device may provide an async command subregion for > > issuing halt/clear subchannel requests. If it is present, use > > it for sending halt/clear request to the device; if not, fall

[Qemu-devel] [PULL 1/1] 9p: fix QEMU crash when renaming files

2018-11-26 Thread Greg Kurz
When using the 9P2000.u version of the protocol, the following shell command line in the guest can cause QEMU to crash: while true; do rm -rf aa; mkdir -p a/b & touch a/b/c & mv a aa; done With 9P2000.u, file renaming is handled by the WSTAT command. The v9fs_wstat() function calls

Re: [Qemu-devel] [RFC v2 00/28] vSMMUv3/pSMMUv3 2 stage VFIO integration

2018-11-26 Thread Auger Eric
Hi Shameer, On 11/23/18 5:28 PM, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Qemu-devel [mailto:qemu-devel- >> bounces+shameerali.kolothum.thodi=huawei@nongnu.org] On Behalf Of >> Eric Auger >> Sent: 21 September 2018 09:18 >> To: eric.auger@gmail.com;

[Qemu-devel] [PATCH] target: hax: fix a typo

2018-11-26 Thread Li Qiang
Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- target/i386/hax-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index 502ce6f0af..464744a406 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c @@ -205,7

[Qemu-devel] [PULL 0/1] 9p fixes for v3.1.0-rc3

2018-11-26 Thread Greg Kurz
The following changes since commit 5298f4d67a911dd9cefa4c4185eed242074d64c2: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2018-11-23 08:54:52 +) are available in the Git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0

2018-11-26 Thread Laurent Vivier
On 26/11/2018 10:56, Li Qiang wrote: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-triv...@nongnu.org > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Markus Armbruster > Signed-off-by: Li Qiang > --- > target/i386/hax-all.c | 15 +++ >

Re: [Qemu-devel] [PATCH for-3.1 18/25] MAINTAINERS: Add missing entries for the QObject section

2018-11-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 28e5038c73..ac5d25491f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1846,12

[Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0

2018-11-26 Thread Li Qiang
And also the g_malloc doesn't need check return value, remove it. Cc: qemu-triv...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Li Qiang --- target/i386/hax-all.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff

Re: [Qemu-devel] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

2018-11-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ac5d25491f..c73dde10a5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1887,6 +1887,7 @@ S: Supported > F:

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-26 Thread Cornelia Huck
On Fri, 23 Nov 2018 14:08:03 +0100 Pierre Morel wrote: > On 22/11/2018 17:54, Cornelia Huck wrote: > > Add a region to the vfio-ccw device that can be used to submit > > asynchronous I/O instructions. ssch continues to be handled by the > > existing I/O region; the new region handles hsch and

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-26 Thread Cédric Le Goater
On 11/26/18 6:44 AM, David Gibson wrote: > On Fri, Nov 23, 2018 at 11:28:24AM +0100, Cédric Le Goater wrote: >> On 11/23/18 2:10 AM, David Gibson wrote: >>> On Thu, Nov 22, 2018 at 05:50:07PM +1100, Benjamin Herrenschmidt wrote: On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote: >

Re: [Qemu-devel] [qemu-s390x] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-11-26 Thread Cornelia Huck
On Sat, 24 Nov 2018 22:07:57 +0100 Halil Pasic wrote: > On Thu, 22 Nov 2018 17:54:29 +0100 > Cornelia Huck wrote: > > > [This is the Linux kernel part, git tree is available at > > https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git > > vfio-ccw-caps > > > > The companion

Re: [Qemu-devel] [question] live migration about redir-usb

2018-11-26 Thread linzhecheng
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, November 26, 2018 4:50 PM > To: linzhecheng > Cc: qemu-devel@nongnu.org; wangxin (U) ; > Zhoujian (jay) > Subject: Re: [Qemu-devel] [question] live migration about redir-usb > > On Mon, Nov 26, 2018

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-26 Thread Bastian Koppelmann
On 11/26/18 4:20 AM, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [Qemu-devel] [question] live migration about redir-usb

2018-11-26 Thread Gerd Hoffmann
On Mon, Nov 26, 2018 at 06:53:23AM +, linzhecheng wrote: > > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Monday, November 26, 2018 2:46 PM > > To: linzhecheng > > Cc: qemu-devel@nongnu.org; wangxin (U) ; > > Zhoujian (jay) > > Subject: Re:

Re: [Qemu-devel] [PATCH V5_resend 7/7] hostmem-file: add 'sync' option

2018-11-26 Thread Pankaj Gupta
> > This option controls whether QEMU mmap(2) the memory backend file with > MAP_SYNC flag, which can fully guarantee the guest write persistence Not sure 'persistence' is the right word here. I think it should be something like 'consistent filesystem metadata for every guest write' just to

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-26 Thread Gerd Hoffmann
Hi, > What are the required semantics for update/switch/refresh? > These don't seem to be documented. Can we validly make > those be asychronous, or does the midlayer require that > the operation has completed and been reflected onscreen > before the update/switch/refresh callback returns ?

Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue

2018-11-26 Thread Xiao Guangrong
On 11/24/18 8:17 AM, Emilio G. Cota wrote: On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote: +static uint64_t get_free_request_bitmap(Threads *threads, ThreadLocal *thread) +{ +uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap; + +

Re: [Qemu-devel] [PATCH v5 01/36] ppc/xive: introduce a XIVE interrupt source model

2018-11-26 Thread Cédric Le Goater
+ */ + +#ifndef PPC_XIVE_H +#define PPC_XIVE_H + +#include "hw/sysbus.h" >>> >>> So, I'm a bit dubious about making the XiveSource a SysBus device - >>> I'm concerned it won't play well with tying it into the other devices >>> like PHB that "own" it in real hardware.

Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue

2018-11-26 Thread Xiao Guangrong
On 11/24/18 8:12 AM, Emilio G. Cota wrote: On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote: + /* + * the bit in these two bitmaps indicates the index of the @requests This @ is not ASCII, is it? Good eyes. :) Will fix it. + * respectively. If it's the

Re: [Qemu-devel] [PATCH v3 3/5] migration: use threaded workqueue for compression

2018-11-26 Thread Xiao Guangrong
On 11/24/18 2:29 AM, Dr. David Alan Gilbert wrote: static void -update_compress_thread_counts(const CompressParam *param, int bytes_xmit) +update_compress_thread_counts(CompressData *cd, int bytes_xmit) Keep the const? Yes, indeed. Will correct it in the next version. +if

<    1   2   3   4