Peter Maydell writes:
> On Fri, 30 Nov 2018 at 07:40, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > Add an assert somewhere and catch it with the usual
>> > "instantiate everything" qtest?
>
>> The troublemaker is (3), where we may end up with an overridden
>> realize-like method and
This new error option allows users of blkdebug to inject errors only on
certain kinds of I/O operations. Users usually want to make a very
specific operation fail, not just any; but right now they simply hope
that the event that triggers the error injection is followed up with
that very
Hi,
This series adds a --salvage option to qemu-img convert. With this,
qemu-img will not abort when it encounters an I/O error. Instead, it
tries to narrow it down and will treat the affected sectors as being
completely 0 (and print a warning).
Testing this is not so easy, because while real
On 2018-12-03 11:06, Jason Wang wrote:
> This allows flexibility to be reused for all kinds of command line
> used by other tests.
>
> Signed-off-by: Jason Wang
> ---
> tests/virtio-net-test.c | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
v1->v2:
- Update for QEMU release numbering, next is 4.0 not 3.2. Only
patch 8 and the commit log of patch 9 updated.
RFC->v1:
- Add Cc reported by get_maintainer
- Fixup some commit logs (no code changes in patches 1-7)
- Add Geoffrey's Tested-by
- Add patches 8 & 9 which define a QEMU
On 12/3/18 8:48 AM, Li Zhijian wrote:
> Don't expect read(2) can always read as many as it's told.
>
> Signed-off-by: Li Zhijian
> ---
> hw/core/loader.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
r~
The following changes since commit 83ea23cd207a03c5736be0231acbf7f8b05dbf52:
i386: hvf: Fix overrun of _decode_tbl1 (2018-12-03 15:09:55 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to
This adds a salvaging mode (--salvage) to qemu-img convert which ignores
read errors and treats the respective areas as containing only zeroes.
This can be used for instance to at least partially recover the data
from terminally corrupted qcow2 images.
Signed-off-by: Max Reitz
---
qemu-img.c
On Wed, Nov 21, 2018 at 03:12:03PM +, Paul Durrant wrote:
> This patch adds the transformations necessary to get dataplane/xen-qdisk.c
> to build against the new XenBus/XenDevice framework. MAINTAINERS is also
> updated due to the introduction of dataplane/xen-qdisk.h.
>
> NOTE: Existing data
On Mon, 3 Dec 2018 at 11:04, Peng Hao wrote:
>
> The first patches are simple cleanups:
> - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile
>it once for the x86/arm/aarch64 archs,
> - patch 2 simply renames ISA fields/definitions to generic ones.
Hi
On Mon, Dec 3, 2018 at 9:23 PM Daniel P. Berrangé wrote:
>
> The files included are taken from formal builds of previous versions
> of QEMU, going back to 2.0.0
>
> - qemu-doc.html
> - qemu-qmp-ref.html
> - qemu-ga-ref.html
>
> To import them all content outside of is stripped and
>
On Wed, Nov 21, 2018 at 03:12:02PM +, Paul Durrant wrote:
> Not all of the code duplicated from xen_disk.c is required as the basis for
> the new dataplane implementation so this patch removes extraneous code,
> along with the legacy #includes and calls to the legacy xen_pv_printf()
>
On 12/3/18 8:48 AM, Li Zhijian wrote:
> Some address/memory APIs have different type between
> 'hwaddr/target_ulong addr' and 'int len'. It is very unsafety, espcially
> some APIs will be passed a non-int len by caller which might cause
> overflow quietly.
> Below is an potential overflow case:
>
On 12/3/18 8:26 AM, Max Reitz wrote:
So because apparently there is going to be an rc4 anyway (like basically
always...), I'd really like to bring this fix into it, unless there are
any objections from anyone (though all of you are more than welcome to
explicitly agree, too :-)).
I agree with
Make sure that the new locality passed to tpm_tis_prep_abort()
is valid. This is merely a precaution since none of the current
callers passes an invalid locality number into this function.
Add a comment to aborting_locty that it may be any locality, including
TPM_TIS_NO_LOCALITY.
Signed-off-by:
On Mon, 3 Dec 2018 at 16:58, Kevin Wolf wrote:
>
> The following changes since commit 83ea23cd207a03c5736be0231acbf7f8b05dbf52:
>
> i386: hvf: Fix overrun of _decode_tbl1 (2018-12-03 15:09:55 +)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git
Move img_convert()'s quiet flag into the ImgConvertState so it is
accessible by nested functions. -q dictates that it suppresses anything
but errors, so if those functions want to emit warnings, they need to
query this flag first. (There currently are no such warnings, but there
will be as of
Signed-off-by: Max Reitz
---
qapi/block-core.json | 5 -
block/blkdebug.c | 8
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 045206196b..bfe48f71f4 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@
Gerd Hoffmann writes:
> Make utf16_to_str return an allocated string. Remove the assumtion that
> the number of string bytes equals the number of utf16 chars (which is
> only true for ascii chars). Instead call wcstombs twice, once to figure
> the storage size and once for the actual
On 12/3/18 11:01 AM, Kamil Rytarowski wrote:
> On 03.12.2018 17:08, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson
>> ---
>> tcg/i386/tcg-target.inc.c | 9 +
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
>> index
Patchew URL:
https://patchew.org/QEMU/1543851204-41186-1-git-send-email-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-4.0 00/71] qtest: qgraph driver framework
Message-id:
On 12/3/18 9:32 AM, Paolo Bonzini wrote:
There is no reason for CONFIG_VHOST_NET to be specific to a single target;
it is a host feature that can be add to all targets, as long as they support
s/add/added/
the virtio-net device. Currently CONFIG_VHOST_NET depends on CONFIG_KVM,
but
On 12/1/18 11:43 AM, Philippe Mathieu-Daudé wrote:
On 1/12/18 12:57, Peter Maydell wrote:
On Fri, 30 Nov 2018 at 20:47, Corey Minyard wrote:
On 11/30/18 11:39 AM, Peter Maydell wrote:
On Mon, 26 Nov 2018 at 20:04, wrote:
From: Philippe Mathieu-Daudé
/* XXX: make this persistent */
On 12/3/18 6:26 AM, Markus Armbruster wrote:
Dominik Csapak writes:
This makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN. A management layer might need the specific reason
of those events to determine which cleanups or other actions it needs to do.
This
On 12/3/18 3:26 AM, Dominik Csapak wrote:
Needed so the patch after next can add ShutdownCause to QMP events
SHUTDOWN and RESET.
Signed-off-by: Dominik Csapak
---
include/sysemu/sysemu.h | 20
qapi/run-state.json | 34 ++
2 files
On 12/3/18 3:26 AM, Dominik Csapak wrote:
It is interesting to know whether the shutdown cause was 'quit' or
'reset', especially when using "--no-reboot". In that case, a management
layer can now determine if the guest wanted a reboot or shutdown, and
can act accordingly.
Changes the ouput of
On 11/26/2018 08:56 PM, Eduardo Habkost wrote:
Remove the "apic initialization failed" prefix (it conveys no
useful information), replace "invalid" with "too large", and add
an error hint with two possible solutions for the problem.
Before:
$ qemu-system-x86_64 -machine q35 -smp 256
On 12/3/18 3:26 AM, Dominik Csapak wrote:
This makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN. A management layer might need the specific reason
of those events to determine which cleanups or other actions it needs to do.
This patch also fixes the iotests to
On Mon, 3 Dec 2018 21:06:00 +0800
Li Qiang wrote:
> Hello Alex, Paolo and all
>
> I have a question about VFIO about the BAR.
>
> Why we have two MemoryRegion for every device’s BAR.
> I mean in VFIOBAR we have a field ‘mr’.
> typedef struct VFIOBAR {
> VFIORegion region;
>
Both GCC v4.8 and Clang v3.4 support the -Waddress option, so we do
not need the compiler version check here anymore.
Signed-off-by: Thomas Huth
---
audio/alsaaudio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 362a227..635be73 100644
---
Don't expect read(2) can always read as many as it's told.
Signed-off-by: Li Zhijian
---
hw/core/loader.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index fa41842..9cbceab 100644
--- a/hw/core/loader.c
+++
On Mon, 3 Dec 2018 at 14:39, Li Zhijian wrote:
>
> Some address/memory APIs have different type between
> 'hwaddr/target_ulong addr' and 'int len'. It is very unsafety, espcially
> some APIs will be passed a non-int len by caller which might cause
> overflow quietly.
> Below is an potential
On Fri, 30 Nov 2018 at 11:29, Gerd Hoffmann wrote:
>
> On Thu, Nov 29, 2018 at 08:09:56AM -0600, Eric Blake wrote:
> > On 11/29/18 6:35 AM, Gerd Hoffmann wrote:
> > > We must set the correct context (via eglMakeCurrent) before
> > > calling qemu_egl_create_context, so we need a thin wrapper and
On Mon, 3 Dec 2018 at 14:03, Max Reitz wrote:
>
> On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote:
> > Hi all!
> >
> > v2: add fix:)
> >
> > We've faced the following mirror bug:
> >
> > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock.
>
> So because apparently there
Eric Blake writes:
> RFC8259 obsoletes RFC7159. Fix a couple of URLs to point to the
> newer version.
>
> Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
On 12/3/18 1:48 PM, Markus Armbruster wrote:
Eric Blake writes:
On 12/3/18 10:30 AM, Max Reitz wrote:
Hi,
QMP accepts double keys in dicts without complaining. The value it is
using is apparently the last one specified:
JSON says it is undefined what happens when a client passes double
On Nov 30 16:14, Peter Maydell wrote:
> On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay
> wrote:
> > diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> > index 50de58e4a2..32c3397948 100644
> > --- a/target/arm/cpu.h
> > +++ b/target/arm/cpu.h
> > @@ -993,6 +993,16 @@ void pmu_op_finish(CPUARMState
Provide a trivial implementation with zero limited ordering regions,
which causes the LDLAR and STLLR instructions to devolve into the
LDAR and STLR instructions from the base ARMv8.0 instruction set.
Signed-off-by: Richard Henderson
---
v2: Mark LORID_EL1 read-only.
Add TLOR access checks.
Because EL3 has a fixed execution mode, we can properly decide
which of the bits are RES{0,1}.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 2 --
target/arm/helper.c | 14 +-
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/target/arm/cpu.h
Since arm_hcr_el2_eff includes a check against
arm_is_secure_below_el3, we can often remove a
nearby check against secure state.
In some cases, sort the call to arm_hcr_el2_eff
to the end of a short-circuit logical sequence.
Signed-off-by: Richard Henderson
---
target/arm/helper.c| 22
Hello! Thank you for your kindly and detailed report.
Since this is via the INT 13h mechanism, the problem is likely in
SeaBIOS.
If I'm reading the version strings right, it looks like QEMU 2.0.0 QEMU
1.1.2 appear to be working correctly for you, but do you know what
versions of the SeaBIOS
The following changes since commit 039d4e3df0049bdd8f93a2de735a816483b13954:
scsi: Address spurious clang warning (2018-11-27 23:56:12 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/fixes-31-20181203-pull-request
for you to fetch changes up
Make utf16_to_str return an allocated string. Remove the assumtion that
the number of string bytes equals the number of utf16 chars (which is
only true for ascii chars). Instead call wcstombs twice, once to figure
the storage size and once for the actual conversion (as suggested by the
wcstombs
On 11/12/2018 02:31 PM, Eduardo Habkost wrote:
On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote:
This adds tests for SMP option, by passing -smp with
various combinations of cpus, cores, threads, and sockets
values it checks that invalid topologies are not accepted
The bulk of the work here, beyond base HPD, is defining the
TTBCR2 register. In addition we must check TTBCR.T2E, which
is not present (RES0) for AArch64.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 9 +
target/arm/cpu.c| 4
Post v8.4 bits taken from SysReg_v85_xml-00bet8.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 79d58978f7..20d97b66de 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1302,6
On Nov 30 16:10, Peter Maydell wrote:
> On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay
> wrote:
> >
> > Signed-off-by: Aaron Lindsay
> > ---
> > target/arm/cpu.h| 4 ++--
> > target/arm/helper.c | 12 ++--
> > 2 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git
On Mon, 3 Dec 2018 at 16:46, Eric Blake wrote:
>
> The following changes since commit 4750e1a888ac3d320607f33b676f299005be98e6:
>
> Update version for v3.1.0-rc3 release (2018-11-28 17:37:34 +)
>
> are available in the Git repository at:
>
> https://repo.or.cz/qemu/ericb.git
Eric Blake writes:
> On 12/3/18 10:30 AM, Max Reitz wrote:
>> Hi,
>>
>> QMP accepts double keys in dicts without complaining. The value it is
>> using is apparently the last one specified:
>
> JSON says it is undefined what happens when a client passes double
> keys. We are probably best off if
Slash is unix directory separator, so they are not allowed in filenames.
Note this also stops the classic escape via "../".
Fixes: CVE-2018-16867
Reported-by: Michael Hanselmann
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-id:
On 12/3/18 1:50 PM, Gerd Hoffmann wrote:
Make utf16_to_str return an allocated string. Remove the assumtion that
s/assumtion/assumption/ (but probably too late to worry about commit
typos in a pull request :)
the number of string bytes equals the number of utf16 chars (which is
only true
Three relatively simple post-8.0 extensions.
Changes since v1:
* Add TLOR access checks for LOR registers.
* Clean up access to HCR_EL2.
* Clean up setting of SCR_EL3.
* Other changes as noted within each patch.
r~
Richard Henderson (10):
target/arm: Move id_aa64mmfr* to
Since the TCR_*.HPD bits were RES0 in ARMv8.0, we can simply
interpret the bits as if ARMv8.1-HPD is present without checking.
We will need a slightly different check for hpd for aarch32.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu64.c | 1 +
The enable for TGE has already occurred within arm_hcr_el2_amo
and friends. Moreover, when E2H is also set, the sense is
supposed to be reversed, which has also already occurred within
the helpers.
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 3 ---
1 file changed, 3 deletions(-)
Post v8.3 bits taken from SysReg_v85_xml-00bet8.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 656a96a8f8..79d58978f7 100644
--- a/target/arm/cpu.h
+++
At the same time, define the fields for these registers,
and use those defines in arm_pamax().
Signed-off-by: Richard Henderson
v2: Include the v8.5 fields; init the registers for kvm.
Upcase all of the field names.
---
target/arm/cpu.h | 26 --
Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine
that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into
account, as documented for the plethora of bits in HCR_EL2.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 67 +--
On 12/3/18 4:19 PM, Peter Maydell wrote:
> On Mon, 3 Dec 2018 at 20:45, Aaron Lindsay
> wrote:
>>
>> On Nov 30 16:10, Peter Maydell wrote:
>>> PMCEID2 and PMCEID3 are only defined from ARMv8.1; before that they
>>> are UNDEFINED. So these registers need to be only defined if a
>>> suitable
I ran plenty of QEMU/SeaBIOS configurations and these are the results:
Ubuntu 18.04:
OK --> QEMU qemu-2.0.0 + SEABIOS rel-1.7.4-0-g96917a8
OK --> QEMU qemu-2.0.0 + SEABIOS 1.10.2-1ubuntu1 (default)
BAD --> QEMU Debian 1:2.11+dfsg-1ubuntu7.8 (default) + SEABIOS
On Mon, 3 Dec 2018 at 20:45, Aaron Lindsay wrote:
>
> On Nov 30 16:10, Peter Maydell wrote:
> > PMCEID2 and PMCEID3 are only defined from ARMv8.1; before that they
> > are UNDEFINED. So these registers need to be only defined if a
> > suitable feature bit or ID register field check passes.
>
> It
Alright, I managed to compile 2.5.0, 2.5.1 and 2.6.0 by simply making
memfd_create() non-static.
It turns out that 2.6.0 is the first version causing problems. I tested
each of these with the provided SeaBIOS version and with SeaBIOS
rel-1.7.4-0-g96917a8.
--
You received this bug notification
Patchew URL:
https://patchew.org/QEMU/20181203160840.15115-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-4.0 0/5] tcg/i386: Improve guest_base handling
Message-id:
On 12/03/2018 01:10 PM, Peter Xu wrote:
On Mon, Dec 03, 2018 at 10:18:28AM +0800, Wei Wang wrote:
This patch adds an API to clear bits corresponding to guest free pages
from the dirty bitmap. Spilt the free page block if it crosses the QEMU
RAMBlock boundary.
Signed-off-by: Wei Wang
CC: Dr.
Hi
On Mon, Dec 3, 2018 at 11:26 AM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Chardev backends may not handle safely IO events from concurrent
> > threads.
>
> What exactly could go wrong? Or is this a well-known fact that doesn't
> need further elaboration?
chardev are not
Make utf16_to_str return an allocated string. Remove the assumtion that
the number of string bytes equals the number of utf16 chars (which is
only true for ascii chars). Instead call wcstombs twice, once to figure
the storage size and once for the actual conversion (as suggested by the
wcstombs
Marc-André Lureau writes:
> Not all backends are able to switch gcontext. Those backends cannot
> drive a OOB monitor (the monitor would then be blocking on main
> thread).
>
> For example, ringbuf, spice, or more esoteric input chardevs like
> braille or MUX.
>
> We currently forbid MUX because
Hi
On Mon, Dec 3, 2018 at 12:23 PM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Not all backends are able to switch gcontext. Those backends cannot
> > drive a OOB monitor (the monitor would then be blocking on main
> > thread).
> >
> > For example, ringbuf, spice, or more
Hi
On Mon, Dec 3, 2018 at 11:25 AM Markus Armbruster wrote:
>
> This one needs review by a chardev guy, with an eye on its use in the
> next patch. Paolo?
>
> Marc-André Lureau writes:
>
> > The feature should be set if the chardev is able to switch
> > GMainContext. Callers that want to put a
Richard Henderson writes:
> It is unused since b68686bd4bfeb70040b4099df993dfa0b4f37b03.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> tcg/aarch64/tcg-target.inc.c | 12
> 1 file changed, 12 deletions(-)
>
> diff --git a/tcg/aarch64/tcg-target.inc.c
v2:
- add comment about the (preexisting) issue noted by armbru.
- change error code as suggested by bsd.
- update reporter email address.
Gerd Hoffmann (2):
usb-mtp: fix utf16_to_str
usb-mtp: outlaw slashes in filenames
hw/usb/dev-mtp.c | 24 ++--
1 file changed, 18
Marc-André Lureau writes:
> Add a monitor_destroyed global to check if monitor_cleanup() has been
> already called. In this case, don't insert the new monitor in the
> list, but free it instead.
>
> Signed-off-by: Marc-André Lureau
The commit message explains what the patch does, but not why
I have patch at http://lists.nongnu.org/archive/html/qemu-
devel/2018-10/msg05401.html, please let me know when it can be merged,
thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1796754
Title:
On 12/03/2018 01:31 PM, Peter Xu wrote:
On Mon, Dec 03, 2018 at 10:18:30AM +0800, Wei Wang wrote:
This patch adds a function to enable a precopy notifier callback outside
the migration subsystem to disable the bulk stage flag. This is needed by
the free page optimization offered by
On 12/03/2018 01:20 PM, Peter Xu wrote:
On Mon, Dec 03, 2018 at 10:18:29AM +0800, Wei Wang wrote:
This patch adds a notifier chain for the memory precopy. This enables various
precopy optimizations to be invoked at specific places.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan
On 12/03/2018 04:20 PM, Wei Wang wrote:
On 12/03/2018 01:31 PM, Peter Xu wrote:
On Mon, Dec 03, 2018 at 10:18:30AM +0800, Wei Wang wrote:
This patch adds a function to enable a precopy notifier callback
outside
the migration subsystem to disable the bulk stage flag. This is
needed by
the
On 30/11/2018 16:58, Tony Krowiak wrote:
On 11/30/18 4:31 AM, Pierre Morel wrote:
On 29/11/2018 21:42, Tony Krowiak wrote:
On 11/22/18 11:35 AM, Pierre Morel wrote:
Two good reasons to use the base device as a child of the
AP BUS:
- We can easily find the device without traversing the qtree.
Slash is unix directory separator, so they are not allowed in filenames.
Note this also stops the classic escape via "../".
Fixes: CVE-2018-16867
Reported-by: Michael Hanselmann
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
301 - 377 of 377 matches
Mail list logo
