[Qemu-devel] [PATCH 21/26] target/arm: Implement pauth_addpac

2018-12-07 Thread Richard Henderson
This is not really functional yet, because the crypto is not yet implemented. This, however follows the AddPAC pseudo function. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 20/26] target/arm: Implement pauth_auth

2018-12-07 Thread Richard Henderson
This is not really functional yet, because the crypto is not yet implemented. This, however follows the Auth pseudo function. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 23/26] target/arm: Add PAuth system registers

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.c | 66 + 1 file changed, 66 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index c73525f813..f466c174e6 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -5071,6

[Qemu-devel] [PATCH 19/26] target/arm: Implement pauth_strip

2018-12-07 Thread Richard Henderson
Stripping out the authentication data does not require any crypto, it merely requires the virtual address parameters. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/target/arm/helper-a64.c

[Qemu-devel] [PATCH v4 3/5] iotests: Filter cid numbers in VMDK extent info

2018-12-07 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.filter | 1 + tests/qemu-iotests/iotests.py| 1 + 2 files changed, 2 insertions(+) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index

Re: [Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.12.2018 um 08:10 hat Markus Armbruster geschrieben: >> This is a reasonably careful review of the QAPI-related parts, but more >> of an eye-over for the remainder. >> >> Kevin Wolf writes: >> >> > From: Fam Zheng >> > >> > This makes VMDK support blockdev-create.

Re: [Qemu-devel] [PATCH v2 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-07 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 07 December 2018 12:15 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org; Stefano Stabellini ; > Michael S. Tsirkin ; Marcel Apfelbaum > ; Paolo

[Qemu-devel] [PATCH 08/26] target/arm: Decode PAuth within disas_data_proc_2src

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 8 1 file changed, 8 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 7ba4c996cf..d034a5edf3 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4884,6

[Qemu-devel] [PATCH 00/26] target/arm: Implement ARMv8.3-PAuth

2018-12-07 Thread Richard Henderson
This has survivied a small user-only smoke test. I need to build a kernel with the right patches in order to both test this in system mode as well as verify the hashes that I am producing vs ARM Fast Model. However, $ aarch64-linux-gcc-8.0.1 -msign-return-address=all z.c $

[Qemu-devel] [PATCH 05/26] target/arm: Decode PAuth within system hint space

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 93 +- 1 file changed, 81 insertions(+), 12 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 7c1cc1ce8e..0df344f9e8 100644 ---

[Qemu-devel] [PATCH 02/26] target/arm: Add SCTLR bits through ARMv8.5

2018-12-07 Thread Richard Henderson
Post v8.4 bits taken from SysReg_v85_xml-00bet8. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 0766e32a1b..80d65866c6 100644 ---

[Qemu-devel] [PATCH 15/26] target/arm: Introduce arm_mmu_idx

2018-12-07 Thread Richard Henderson
The pattern ARMMMUIdx mmu_idx = core_to_arm_mmu_idx(env, cpu_mmu_index(env, false)); is computing the full ARMMMUIdx, stripping off the ARM bits, and then putting them back. Avoid the extra two steps with the appropriate helper function. Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH 26/26] target/arm: Tidy TBI handling in gen_a64_set_pc

2018-12-07 Thread Richard Henderson
We can perform this with fewer operations. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 65 ++ 1 file changed, 23 insertions(+), 42 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

Re: [Qemu-devel] [PATCH for-4.0 v4 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-12-07 Thread Caio Carrara
On Wed, Dec 05, 2018 at 05:57:04PM -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology)

Re: [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
01.12.2018 1:03, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on >

[Qemu-devel] [PATCH 17/26] target/arm: Reuse aa64_va_parameters for setting tbflags

2018-12-07 Thread Richard Henderson
The arm_regime_tbi{0,1} functions are replacable with the new function by giving the lowest and highest address. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 35 - target/arm/helper.c | 55 + 2 files changed,

[Qemu-devel] [PATCH 07/26] target/arm: Decode PAuth within disas_data_proc_1src

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 146 + 1 file changed, 146 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c5ec430b42..7ba4c996cf 100644 --- a/target/arm/translate-a64.c +++

Re: [Qemu-devel] [PATCH v6 10/27] qapi: factor out checking for keys

2018-12-07 Thread Marc-André Lureau
On Wed, Dec 5, 2018 at 8:26 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Introduce a new helper function to check if the given keys are known, > > and if mandatory keys are present. The function will be reused in > > other places in the following code changes. > > > >

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-07 Thread Kevin Wolf
Am 06.12.2018 um 12:05 hat Christian Borntraeger geschrieben: > > > On 05.12.2018 17:09, Vladimir Sementsov-Ogievskiy wrote: > > 05.12.2018 18:52, Christian Borntraeger wrote: > >> > >> > >> On 05.12.2018 14:39, Vladimir Sementsov-Ogievskiy wrote: > >>> 05.12.2018 15:35, Christian Borntraeger

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Thomas Huth
On 2018-12-03 16:32, Paolo Bonzini wrote: > From: Emanuele Giuseppe Esposito > > Add qgraph API that allows to add/remove nodes and edges from the graph, > implementation of Depth First Search to discover the paths and basic unit > test to check correctness of the API. > Included also a main

[Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-07 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- hw/scsi/scsi-disk.c | 105 +-- hw/scsi/trace-events | 29 2 files changed, 81 insertions(+), 53 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 0e9027c8f3..29e541efdb 100644 ---

Re: [Qemu-devel] [PATCH 18/71] tests/libqos: embed allocators instead of malloc-ing them

2018-12-07 Thread Paolo Bonzini
On 07/12/18 13:32, Thomas Huth wrote: > On 2018-12-03 16:32, Paolo Bonzini wrote: >> qgraph will embed these objects instead of allocating them in a separate >> object. Expose a new API "generic_alloc_init" and "generic_alloc_destroy" >> for that, and rename the existing API with s/init/new/ and

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Halil Pasic
On Fri, 7 Dec 2018 14:17:20 +0100 Cornelia Huck wrote: > On Fri, 7 Dec 2018 13:52:53 +0100 > Halil Pasic wrote: > > > On Fri, 7 Dec 2018 13:29:46 +0100 > > Cornelia Huck wrote: > > > > > On Fri, 7 Dec 2018 13:17:02 +0100 > > > Christian Borntraeger wrote: > > > > > > > On 05.12.2018

Re: [Qemu-devel] [PATCH v3 1/4] vmdk: Refactor vmdk_create_extent

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 07:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > From: Fam Zheng > > > > The extracted vmdk_init_extent takes a BlockBackend object and > > initializes the format metadata. It is the common part between "qemu-img > > create" and "blockdev-create". > > > > Add

[Qemu-devel] [PATCH 06/26] target/arm: Rearrange decode in disas_data_proc_1src

2018-12-07 Thread Richard Henderson
Now properly signals unallocated for REV64 with SF=0. Allows for the opcode2 field to be decoded shortly. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 11/26] target/arm: Rearrange decode in disas_uncond_b_reg

2018-12-07 Thread Richard Henderson
This will enable PAuth decode in a subsequent patch. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

[Qemu-devel] [PATCH 12/26] target/arm: Decode PAuth within disas_uncond_b_reg

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 100 +++-- 1 file changed, 95 insertions(+), 5 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 5fa2647771..d4df2b48b1 100644 --- a/target/arm/translate-a64.c

[Qemu-devel] [PATCH 13/26] target/arm: Decode Load/store register (pac)

2018-12-07 Thread Richard Henderson
Not that there are any stores involved, but why argue with ARM's naming convention. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c

Re: [Qemu-devel] [PATCH v5 0/2] [PATCH v4] Add arm SBSA reference machine

2018-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1544173675-14217-1-git-send-email-hongbo.zh...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

[Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Kevin Wolf
Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/237 | 233 + tests/qemu-iotests/237.out | 347 + tests/qemu-iotests/group | 1 + 3 files changed, 581 insertions(+) create mode 100755

Re: [Qemu-devel] [PATCH v2 2/3] s390: cpu feature for diagnose 318 andlimit max VCPUs to 247

2018-12-07 Thread Cornelia Huck
On Thu, 6 Dec 2018 17:24:17 -0500 Collin Walling wrote: > Diagnose 318 is a new z14.2 CPU feature. Since we are able to emulate > it entirely via KVM, we can add guest support for earlier models. A > new CPU feature for diagnose 318 (shortened to diag318) will be made > available to guests

Re: [Qemu-devel] [PATCH 1/1] iotests: make 235 work on s390 (and others)

2018-12-07 Thread Kevin Wolf
Am 05.12.2018 um 16:34 hat Eric Blake geschrieben: > On 12/5/18 2:43 AM, Christian Borntraeger wrote: > > "-machine pc" will not work all architectures. Lets fall back to the > > default machine by not specifying it. > > > > In addition we also need to specify -no-shutdown on s390 as qemu will >

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Cornelia Huck
On Fri, 7 Dec 2018 13:17:02 +0100 Christian Borntraeger wrote: > On 05.12.2018 15:51, Cornelia Huck wrote: > > vfio-ap devices do not pin any pages in the host. Therefore, they > > are belived to be compatible with memory ballooning. > > > > Flag them as compatible, so both vfio-ap and a

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Cornelia Huck
On Fri, 7 Dec 2018 13:32:14 +0100 Christian Borntraeger wrote: > On 07.12.2018 13:29, Cornelia Huck wrote: > > On Fri, 7 Dec 2018 13:17:02 +0100 > > Christian Borntraeger wrote: > > > >> On 05.12.2018 15:51, Cornelia Huck wrote: > >>> vfio-ap devices do not pin any pages in the host.

Re: [Qemu-devel] [PATCH v4 2/5] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> From: Fam Zheng >> >> This makes VMDK support blockdev-create. The implementation reuses the >> image creation code in vmdk_co_create_opts which now acceptes a callback >> pointer to "retrieve" BlockBackend pointers from the caller. This way

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Paolo Bonzini
On 07/12/18 13:42, Thomas Huth wrote: > The license statement is inaccurate. There is no "GNU *Lesser* General > Public License version *2*" ... so I'm assuming you wanted to use one of > these two options: > > - GNU Library General Public License, version 2.0 > - GNU Lesser General Public

Re: [Qemu-devel] [PATCH v10 1/9] mirror: inherit supported write/zero flags

2018-12-07 Thread Alberto Garcia
On Mon 03 Dec 2018 11:14:53 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH 16/26] target/arm: Create ARMVAParameters and helpers

2018-12-07 Thread Richard Henderson
Split out functions to extract the virtual address parameters. Let the functions choose T0 or T1 address space half, if present. Extract (most of) the control bits that vary between EL or Tx. Signed-off-by: Richard Henderson --- target/arm/helper.c | 274

[Qemu-devel] [PATCH 18/26] target/arm: Export aa64_va_parameters to internals.h

2018-12-07 Thread Richard Henderson
We need to reuse this from helper-a64.c. Provide a stub definition for CONFIG_USER_ONLY. This matches the stub definitions that we removed for arm_regime_tbi{0,1} before. Signed-off-by: Richard Henderson --- target/arm/internals.h | 29 + target/arm/helper.c|

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/5] crypto/block-luks: fix memory leak in qcrypto_block_luks_create

2018-12-07 Thread Alberto Garcia
On Wed 05 Dec 2018 03:46:56 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Free block->cipher and block->ivgen on error path. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] Logging dirty pages from vhost-net in-kernel with vIOMMU

2018-12-07 Thread Jason Wang
On 2018/12/6 下午8:44, Jason Wang wrote: On 2018/12/6 下午8:11, Jintack Lim wrote: On Thu, Dec 6, 2018 at 2:33 AM Jason Wang wrote: On 2018/12/5 下午10:47, Jintack Lim wrote: On Tue, Dec 4, 2018 at 8:30 PM Jason Wang wrote: On 2018/12/5 上午2:37, Jintack Lim wrote: Hi, I'm wondering how the

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-07 Thread Alberto Garcia
On Wed 05 Dec 2018 03:46:57 PM CET, Vladimir Sementsov-Ogievskiy wrote: > qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are > almost identical, let's reduce code duplication and simplify further > improvements. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > +static int

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Halil Pasic
On Fri, 7 Dec 2018 13:29:46 +0100 Cornelia Huck wrote: > On Fri, 7 Dec 2018 13:17:02 +0100 > Christian Borntraeger wrote: > > > On 05.12.2018 15:51, Cornelia Huck wrote: > > > vfio-ap devices do not pin any pages in the host. Therefore, they > > > are belived to be compatible with memory

Re: [Qemu-devel] [PATCH v3 1/4] vmdk: Refactor vmdk_create_extent

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.12.2018 um 07:40 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > From: Fam Zheng >> > >> > The extracted vmdk_init_extent takes a BlockBackend object and >> > initializes the format metadata. It is the common part between "qemu-img >> > create" and

Re: [Qemu-devel] [PATCH 14/14] iotests: Enhance 223, 233 to cover 'qemu-nbd --list'

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
01.12.2018 1:03, Eric Blake wrote: > Any good new feature deserves some regression testing :) > Coverage includes: > - 223: what happens when there are 0 or more than 1 export, > proof that we can see multiple contexts including qemu:dirty-bitmap > - 233: proof that we can list over TLS, and that

[Qemu-devel] [PATCH v4 5/5] vmdk: Reject excess extents in blockdev-create

2018-12-07 Thread Kevin Wolf
Clarify that the number of extents provided in BlockdevCreateOptionsVmdk must match the number of extents that will actually be used. Providing more extents will result in an error now. This requires adapting the test case to provide the right number of extents. Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create

2018-12-07 Thread Kevin Wolf
I picked up the patch series from Fam and rebased it to current master (which involved a major rework on the test case) and tried to address Markus' review comments for v2. I did not do any further review of the actual code, but it passes the tests, so I guess having it in tree is better than

Re: [Qemu-devel] [PATCH v2 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:28PM +, Paul Durrant wrote: > This patch adds the basic boilerplate for a 'XenBus' object that will act > as a parent to 'XenDevice' PV backends. > A new 'XenBridge' object is also added to connect XenBus to the system bus. > > The XenBus object is instantiated

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Christian Borntraeger
On 07.12.2018 13:29, Cornelia Huck wrote: > On Fri, 7 Dec 2018 13:17:02 +0100 > Christian Borntraeger wrote: > >> On 05.12.2018 15:51, Cornelia Huck wrote: >>> vfio-ap devices do not pin any pages in the host. Therefore, they >>> are belived to be compatible with memory ballooning. >>> >>>

Re: [Qemu-devel] [PATCH 18/71] tests/libqos: embed allocators instead of malloc-ing them

2018-12-07 Thread Thomas Huth
On 2018-12-03 16:32, Paolo Bonzini wrote: > qgraph will embed these objects instead of allocating them in a separate > object. Expose a new API "generic_alloc_init" and "generic_alloc_destroy" > for that, and rename the existing API with s/init/new/ and s/uninit/free/. Could you please add a

Re: [Qemu-devel] [PATCH v4 2/5] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > From: Fam Zheng > > This makes VMDK support blockdev-create. The implementation reuses the > image creation code in vmdk_co_create_opts which now acceptes a callback > pointer to "retrieve" BlockBackend pointers from the caller. This way we > separate the logic between

Re: [Qemu-devel] [PATCH] aio_poll race condition.

2018-12-07 Thread Remy NOEL
Indeed, i did not add those for the cover letter (i used the wiki's commit hook though) Anyway, I sent a V2 after discovering the rcu usage hada significant performance impact. It was not sent to the New email fo Fam Zheng though. i'll forward it to its new address, thanks. Regards. Remy

[Qemu-devel] [PATCH 01/26] target/arm: Add state for the ARMv8.3-PAuth extension

2018-12-07 Thread Richard Henderson
Add storage space for the 5 encryption keys. Migrate them when the extension is enabled. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 23 +++ target/arm/machine.c | 23 +++ 2 files changed, 46 insertions(+) diff --git a/target/arm/cpu.h

[Qemu-devel] [PATCH 14/26] target/arm: Move cpu_mmu_index out of line

2018-12-07 Thread Richard Henderson
This function is, or will shortly become, too big to inline. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 48 + target/arm/helper.c | 44 + 2 files changed, 49 insertions(+), 43 deletions(-) diff

Re: [Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 08:10 hat Markus Armbruster geschrieben: > This is a reasonably careful review of the QAPI-related parts, but more > of an eye-over for the remainder. > > Kevin Wolf writes: > > > From: Fam Zheng > > > > This makes VMDK support blockdev-create. The implementation reuses the >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci()

2018-12-07 Thread Laurent Vivier
Le 30/11/2018 à 10:53, Li Qiang a écrit : > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > util/vfio-helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c > index 9cd42e..342d4a2285 100644 > ---

Re: [Qemu-devel] [PATCH 12/14] nbd/client: Work around 3.0 bug for listing meta contexts

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
01.12.2018 1:03, Eric Blake wrote: > Commit 3d068aff forgot to advertise available qemu: contexts > when the client requests a list with 0 queries. Furthermore, > 3.0 shipped with a qemu-img hack of x-dirty-bitmap (commit > 216ee365) that _silently_ acts as though the entire image is > clean if a

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Christian Borntraeger
On 05.12.2018 15:51, Cornelia Huck wrote: > vfio-ap devices do not pin any pages in the host. Therefore, they > are belived to be compatible with memory ballooning. > > Flag them as compatible, so both vfio-ap and a balloon can be > used simultaneously. > > Signed-off-by: Cornelia Huck Does it

Re: [Qemu-devel] [PATCH v4 5/5] vmdk: Reject excess extents in blockdev-create

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > Clarify that the number of extents provided in BlockdevCreateOptionsVmdk > must match the number of extents that will actually be used. Providing > more extents will result in an error now. > > This requires adapting the test case to provide the right number of > extents. >

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Cornelia Huck
On Fri, 7 Dec 2018 13:52:53 +0100 Halil Pasic wrote: > On Fri, 7 Dec 2018 13:29:46 +0100 > Cornelia Huck wrote: > > > On Fri, 7 Dec 2018 13:17:02 +0100 > > Christian Borntraeger wrote: > > > > > On 05.12.2018 15:51, Cornelia Huck wrote: > > > > vfio-ap devices do not pin any pages in the

Re: [Qemu-devel] [PATCH 2/6] qemu/queue.h: leave head structs anonymous unless necessary

2018-12-07 Thread Paolo Bonzini
On 07/12/18 08:28, Markus Armbruster wrote: > > $ git-grep 'Q[A-Z]*_HEAD([^,]' | grep -v '#define' | grep -v QTAILQ_HEAD > block/qcow2-bitmap.c:typedef QSIMPLEQ_HEAD(Qcow2BitmapList, Qcow2Bitmap) > Qcow2BitmapList; > include/block/block.h:typedef QSIMPLEQ_HEAD(BlockReopenQueue, >

Re: [Qemu-devel] [PATCH 6/6] checkpatch: warn about queue/queue.h head structs that are not typedef-ed

2018-12-07 Thread Paolo Bonzini
On 07/12/18 10:02, Markus Armbruster wrote: > Let's state the rationale for requiring a typedef in the commit > message, or point to a prior commit that has it. Sure---the rationale is simply that they are structs (or unions in the case of QTAILQ but it's just an implementation detail), and we

[Qemu-devel] [PATCH 03/26] target/arm: Add PAuth active bit to tbflags

2018-12-07 Thread Richard Henderson
There are 5 bits of state that could be added, but to save space within tbflags, add only a single enable bit. Helpers will determine the rest of the state at runtime. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4 target/arm/translate.h | 2 ++

[Qemu-devel] [PATCH 04/26] target/arm: Add PAuth helpers

2018-12-07 Thread Richard Henderson
The cryptographic internals are stubbed out for now, but the enable and trap bits are checked. Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 12 +++ target/arm/internals.h | 6 ++ target/arm/helper-a64.c | 169 3 files changed, 187

[Qemu-devel] [PATCH 09/26] target/arm: Move helper_exception_return to helper-a64.c

2018-12-07 Thread Richard Henderson
This function is only used by AArch64. Code movement only. Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 2 + target/arm/helper.h | 1 - target/arm/helper-a64.c | 155 target/arm/op_helper.c | 155

[Qemu-devel] [PATCH 25/26] target/arm: Enable PAuth for user-only, part 2

2018-12-07 Thread Richard Henderson
FIXME: We should have an attribute that controls the EL1 enable bits. We may not always want to turn on pointer authentication with -cpu max. Signed-off-by: Richard Henderson --- target/arm/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index

Re: [Qemu-devel] [Qemu-arm] more serial ports on arm?

2018-12-07 Thread Peter Maydell
On Fri, 7 Dec 2018 at 04:43, Jason A. Donenfeld wrote: > > On Tue, Nov 20, 2018 at 11:08 AM Peter Maydell > wrote: > > It's still stuck, because unconditionally adding a second serial > > port to the virt board breaks some commonly used existing guest > > code (UEFI + Linux), and it's not clear

Re: [Qemu-devel] [PATCH v5 0/2] [PATCH v4] Add arm SBSA reference machine

2018-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1544173675-14217-1-git-send-email-hongbo.zh...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

[Qemu-devel] [PATCH 24/26] target/arm: Enable PAuth for user-only -cpu max

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu64.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 1d57be0c91..84f70b2a24 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -316,6 +316,10 @@ static void aarch64_max_initfn(Object

[Qemu-devel] [PATCH v4 1/5] vmdk: Refactor vmdk_create_extent

2018-12-07 Thread Kevin Wolf
From: Fam Zheng The extracted vmdk_init_extent takes a BlockBackend object and initializes the format metadata. It is the common part between "qemu-img create" and "blockdev-create". Add a "BlockBackend *pbb" parameter to vmdk_create_extent, to return the opened BB to the caller in the next

[Qemu-devel] [PATCH v4 2/5] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Kevin Wolf
From: Fam Zheng This makes VMDK support blockdev-create. The implementation reuses the image creation code in vmdk_co_create_opts which now acceptes a callback pointer to "retrieve" BlockBackend pointers from the caller. This way we separate the logic between file/extent acquisition and

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-07 Thread Kevin Wolf
Am 05.12.2018 um 13:23 hat Denis Plotnikov geschrieben: > At the time, the "drained section" doesn't protect Block Driver State > from the requests appearing in the vCPU threads. > This could lead to the data loss because of request coming to > an unexpected BDS. > > For example, when a request

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Markus Armbruster
git-am complains Applying: iotests: Add VMDK tests for blockdev-create .git/rebase-apply/patch:281: trailing whitespace. format: .git/rebase-apply/patch:308: trailing whitespace. format: .git/rebase-apply/patch:335: trailing whitespace.

[Qemu-devel] [PATCH 2/2] scsi-generic: Convert from DPRINTF() macro to trace events

2018-12-07 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- hw/scsi/scsi-generic.c | 56 -- hw/scsi/trace-events | 11 + 2 files changed, 37 insertions(+), 30 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 7237b4162e..842f8e0893 100644

[Qemu-devel] [PATCH 22/26] target/arm: Implement pauth_computepac

2018-12-07 Thread Richard Henderson
This is the main crypto routine, an implementation of QARMA. This matches, as much as possible, ARM pseudocode. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 240 +++- 1 file changed, 239 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 10/26] target/arm: Add new_pc argument to helper_exception_return

2018-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 2 +- target/arm/helper-a64.c| 10 +- target/arm/translate-a64.c | 7 ++- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cutils: Assert in-range base for string-to-integer conversions

2018-12-07 Thread Laurent Vivier
Le 06/12/2018 à 16:18, Eric Blake a écrit : > POSIX states that the value of endptr is unspecified if strtol() > fails with EINVAL due to an invalid base argument. Since none of > the callers to check_strtox_error() initialized endptr, we could > end up propagating uninitialized data back to a

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/237 | 233 + > tests/qemu-iotests/237.out | 347 + > tests/qemu-iotests/group | 1 + > 3 files changed, 581 insertions(+) >

Re: [Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create

2018-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181207115343.6747-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181207115343.6747-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v4 0/5] vmdk: Implement

Re: [Qemu-devel] [PATCH v10 2/9] blkverify: set supported write/zero flags

2018-12-07 Thread Alberto Garcia
On Mon 03 Dec 2018 11:14:54 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:29PM +, Paul Durrant wrote: > +static char *disk_to_vbd_name(unsigned int disk) > +{ > +char *name, *prefix = (disk >= 26) ? > +disk_to_vbd_name((disk / 26) - 1) : g_strdup(""); > + > +name = g_strdup_printf("%s%c", prefix, 'a' + disk); I don't

Re: [Qemu-devel] [PATCH v10 3/9] quorum: set supported write flags

2018-12-07 Thread Alberto Garcia
On Fri 07 Dec 2018 03:46:13 PM CET, Anton Nefedov wrote: >>> +static void quorum_set_supported_flags(BlockDriverState *bs) >>> +{ >>> +BDRVQuorumState *s = bs->opaque; >>> +int i; >>> + >>> +bs->supported_write_flags = BDRV_REQ_FUA; >>> +for (i = 0; i < s->num_children; i++) { >>>

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Eric Blake
On 12/7/18 4:00 AM, Andrey Shinkevich wrote: In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existing QCOW2 bitmaps will be shown, such as a bitmap name, flags and granularity: image: /vz/vmprivate/VM1/harddisk.hdd file

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Eduardo Habkost
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > >

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-07 Thread Laurent Vivier
On 07/12/2018 16:37, Philippe Mathieu-Daudé wrote: > On 12/7/18 2:17 PM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> --- >> hw/scsi/scsi-disk.c | 105 +-- >> hw/scsi/trace-events | 29 >> 2 files changed, 81 insertions(+), 53

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 16:40 hat Eric Blake geschrieben: > On 12/7/18 8:45 AM, Kevin Wolf wrote: > > Am 07.12.2018 um 14:12 hat Markus Armbruster geschrieben: > > > git-am complains > > > > > > Applying: iotests: Add VMDK tests for blockdev-create > > > .git/rebase-apply/patch:281: trailing

Re: [Qemu-devel] [qemu-web PATCH] Add license files for GPLv2+ and CC-BY-SA-4.0

2018-12-07 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 10:40:50AM -0600, Eric Blake wrote: > On 12/7/18 9:16 AM, Daniel P. Berrangé wrote: > > The intent is that from this point onwards, content for this repository > > is dual-licensed under the GPLv2+ and CC-BY-SA-4.0 > > > > With git HEAD at

[Qemu-devel] [for-4.0 PATCH v4 4/9] qapi: Define PCIe link speed and width properties

2018-12-07 Thread Alex Williamson
Create properties to be able to define speeds and widths for PCIe links. The only tricky bit here is that our get and set callbacks translate from the fixed QAPI automagic enums to those we define in PCI code to represent the actual register segment value. Cc: Eric Blake Tested-by: Geoffrey

[Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2018-12-07 Thread Philippe Mathieu-Daudé
Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). There is no need to null check it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f69e7eb399..36303ed59c 100644 ---

Re: [Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:04:00PM +0100, Philippe Mathieu-Daudé wrote: > Add a function to read the full content of file on the host, and add > a new 'file' name item to the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé Need to be careful with options that let users play with

Re: [Qemu-devel] [PATCH 2/6] hw/arm: Remove unused include

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:03:56PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt-acpi-build.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 5785fb697c..98d7f7cf20 100644 >

Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-07 Thread Thomas Huth
On 2018-12-03 16:32, Paolo Bonzini wrote: > From: Emanuele Giuseppe Esposito > > Add qgraph API that allows to add/remove nodes and edges from the graph, > implementation of Depth First Search to discover the paths and basic unit > test to check correctness of the API. > Included also a main

[Qemu-devel] [for-4.0 PATCH v4 5/9] pcie: Add link speed and width fields to PCIESlot

2018-12-07 Thread Alex Williamson
Add fields allowing the PCIe link speed and width of a PCIESlot to be configured, with an instance_post_init callback on the root port parent class to set defaults. This allows child classes to set these via properties or via their own instance_init callback, without requiring all implementions

[Qemu-devel] [for-4.0 PATCH v4 1/9] q35/440fx/arm/spapr/ccw: Add QEMU 4.0 machine type

2018-12-07 Thread Alex Williamson
For reference only, Eduardo plans to merge this via his tree. Acked-by: David Gibson Reviewed-by: Eric Auger Signed-off-by: Alex Williamson --- hw/arm/virt.c | 19 +-- hw/i386/pc_piix.c | 15 --- hw/i386/pc_q35.c | 13

[Qemu-devel] [for-4.0 PATCH v4 2/9] pcie: Create enums for link speed and width

2018-12-07 Thread Alex Williamson
In preparation for reporting higher virtual link speeds and widths, create enums and macros to help us manage them. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Tested-by: Geoffrey McRae Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Signed-off-by: Alex Williamson ---

Re: [Qemu-devel] [PATCH v2 10/18] xen: add header and build dataplane/xen-block.c

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:36PM +, Paul Durrant wrote: > This patch adds the transformations necessary to get dataplane/xen-block.c > to build against the new XenBus/XenDevice framework. MAINTAINERS is also > updated due to the introduction of dataplane/xen-block.h. > > NOTE: Existing data

Re: [Qemu-devel] [PATCH] MAINTAINERS: update status of FPU emulation

2018-12-07 Thread Richard Henderson
On 12/5/18 6:48 AM, Alex Bennée wrote: > Given I've spent a fair amount of time around this code now I'm > putting myself forward as a maintainer. Also given that the code has > been extensively re-written and has testing and new incoming features > it's probably more than just Odd Fixes. > >

[Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace

2018-12-07 Thread Philippe Mathieu-Daudé
QEMU interacts with various firmwares. We already have some helpers for some firmwares. Later we will add UEFI helpers. This series introduce the hw/firmware namespace for this. There is no need to move hw/smbios sources into a specific directory, we only focus on the headers. Philippe

[Qemu-devel] [Bug 1803160] Re: qemu-3.1.0-rc0: tcg.c crash in temp_load

2018-12-07 Thread Richard Henderson
This second crash is of course a different bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1803160 Title: qemu-3.1.0-rc0: tcg.c crash in temp_load Status in QEMU: Fix Committed Bug

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 17:52 hat Eric Blake geschrieben: > On 12/7/18 10:42 AM, Kevin Wolf wrote: > > Am 07.12.2018 um 16:40 hat Eric Blake geschrieben: > > > On 12/7/18 8:45 AM, Kevin Wolf wrote: > > > > Am 07.12.2018 um 14:12 hat Markus Armbruster geschrieben: > > > > > git-am complains > > > > > > >

  1   2   3   >