[Qemu-devel] [PATCH v1 3/5] i386: extend x86_apicid_* functions for smp_dies support

2019-01-13 Thread Like Xu
This patch rewrites the width/offset-apicid calculation with compatibility. It keeps the original symmetry as a default method and sets the die_id as well as node_id for leageacy numde_node auto-configuration. Signed-off-by: Like Xu --- hw/i386/pc.c | 37 +++---

[Qemu-devel] [PATCH v1 4/5] i386: enable CPUID.1F leaf generation based on spec

2019-01-13 Thread Like Xu
This patch uses the new socket/die/core/thread model to generate cpuid.1f eax/ebx/ecx/edx values especially the subleaf 2 which keeps die level information and adds an option in the cpu_x86_cpuid. Signed-off-by: Like Xu --- target/i386/cpu.c | 57

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-13 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 10/01/19 14:30, Pavel Dovgalyuk wrote: > > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > > (including > external > > ones). > > qemu_start_warp_timer uses the deadline for setting warp timer (which > > should

Re: [Qemu-devel] [PATCH 1/5] vfio: update kernel headers.

2019-01-13 Thread Gerd Hoffmann
On Fri, Jan 11, 2019 at 09:32:43AM -0600, Eric Blake wrote: > On 1/11/19 3:31 AM, Gerd Hoffmann wrote: > > Temporary, for testing convinience. > > convenience > > > > > Once qemu master is synced with the linux 5.0-rc1 headers > > this is not needed any more. > > What's the timeline for when

Re: [Qemu-devel] [PATCH] hw/vfio/common: Refactor container initialization

2019-01-13 Thread Alexey Kardashevskiy
On 12/01/2019 03:45, Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little bit more

Re: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110191901.5082-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190110191901.5082-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the

[Qemu-devel] [PATCH v2 2/4] qga: fix send_response error handling

2019-01-13 Thread Basil Salman
Sometimes qemu-ga fails to send a response to client due to memory allocation issues due to a large response message, this can be experienced while trying to read large number of bytes using QMP command guest-file-read. Added a check to send an error response to qemu-ga client in such cases.

[Qemu-devel] [PATCH v2 0/4] QGA - Win fixes

2019-01-13 Thread Basil Salman
This patch series addresses serveral issues with qga-win please review them and share your thoughts. Basil Salman (3): qga-win: prevent crash when executing guest-file-read with large count qga: fix send_response error handling qga: Installer: Wait for installation to finish Sameeh Jubran

[Qemu-devel] [PATCH v2 1/4] qga-win: prevent crash when executing guest-file-read with large count

2019-01-13 Thread Basil Salman
BZ: #1594054 guest-file-read command is currently implelmented to read from a file handle count number of bytes. when executed with a very large count number qemu-ga crashes. after some digging turns out that qemu-ga crashes after trying to allocate a buffer large enough to save the data read in

Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.st...@bahia.lan/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.st...@bahia.lan/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive Type: series

Re: [Qemu-devel] [PATCH] contrib/gitdm: Fix a typo

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/201905.8270-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] contrib/gitdm: Fix a typo Type: series Message-id:

Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110120843.3839-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110120843.3839-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices Type: series Message-id:

Re: [Qemu-devel] [PATCH 0/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

2019-01-13 Thread Leonid Bloch
On 1/11/19 9:14 PM, Markus Armbruster wrote: > Back in September, Leonid Block added a whole bunch of macros (commit * Bloch. :) > 540b8492618) to improve readability of qcow2.h a bit (commit > b6a95c6d100). He later used them to fix the "vdi" driver's parameter > cluster_size's default value

Re: [Qemu-devel] [PATCH 1/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

2019-01-13 Thread Leonid Bloch
Hi, On 1/11/19 9:14 PM, Markus Armbruster wrote: > We define 54 macros for the powers of two >= 1024. We use six, in six > macro definitions. Four of them could just as well use the common MiB > macro, so do that. The remaining two can't, because they get passed > to stringify. Replace the

[Qemu-devel] [PATCH v2 3/4] qga: Installer: Wait for installation to finish

2019-01-13 Thread Basil Salman
Installation might fail if we don't wait for the provider unregisteration process to finish. Signed-off-by: Sameeh Jubran Signed-off-by: Basil Salman --- qga/installer/qemu-ga.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/installer/qemu-ga.wxs

[Qemu-devel] [PATCH v2 4/4] qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error

2019-01-13 Thread Basil Salman
From: Sameeh Jubran This patch handles the case where VSS Provider is already registered, where in such case qga uninstalls the provider and registers it again. Signed-off-by: Sameeh Jubran Signed-off-by: Basil Salman --- qga/vss-win32/install.cpp | 11 +++ 1 file changed, 11

Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.st...@bahia.lan/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [Qemu-devel] [PATCH v1 0/3] [RFC] get real IOMMU information from VFIO IOMMU

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1547037680-21458-1-git-send-email-pmo...@linux.ibm.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

[Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Fei Li
From: Fei Li Let's supplement the msi_uninit() when failing to realize the pci edu device. Cc: Markus Armbruster Cc: Peter Xu Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Fei Li --- hw/misc/edu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/edu.c

Re: [Qemu-devel] [PATCH 0/4] Add ignore-external migration capability

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110120120.9943-1-yury-ko...@yandex-team.ru/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-13 Thread Fei Li
在 2019/1/8 上午1:29, Markus Armbruster 写道: Fei Li writes: Utilize the existed errp to propagate the error instead of the temporary _abort. Cc: Markus Armbruster Cc: Jiri Slaby Signed-off-by: Fei Li --- hw/misc/edu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Marcel Apfelbaum
On 1/13/19 4:36 PM, Fei Li wrote: From: Fei Li Let's supplement the msi_uninit() when failing to realize the pci edu device. Cc: Markus Armbruster Cc: Peter Xu Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Fei Li --- hw/misc/edu.c | 1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support.

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190111093116.17188-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support. Type: series Message-id:

[Qemu-devel] [PATCH v2] slirp: check data length while emulating ident function

2019-01-13 Thread P J P
From: Prasad J Pandit While emulating identification protocol, tcp_emu() does not check available space in the 'sc_rcv->sb_data' buffer. It could lead to heap buffer overflow issue. Add check to avoid it. Reported-by: Kira <864786...@qq.com> Signed-off-by: Prasad J Pandit --- slirp/tcp_subr.c

[Qemu-devel] [PATCH for-4.0 1/5] Fix segmentation fault when qemu_signal_init fails

2019-01-13 Thread Fei Li
From: Fei Li When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate the err to

[Qemu-devel] [PATCH for-4.0 4/5] migration: add more error handling for postcopy_ram_enable_notify

2019-01-13 Thread Fei Li
From: Fei Li Call postcopy_ram_incoming_cleanup() to do the cleanup when postcopy_ram_enable_notify fails. Besides, report the error message when qemu_ram_foreach_migratable_block() fails. Cc: Dr. David Alan Gilbert Signed-off-by: Fei Li Reviewed-by: Dr. David Alan Gilbert ---

[Qemu-devel] [PATCH for-4.0 2/5] migration: fix the multifd code when receiving less channels

2019-01-13 Thread Fei Li
From: Fei Li In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, however the destination does not exit but keeps waiting until the source is killed deliberately. Fix this by dumping the

[Qemu-devel] [PATCH for-4.0 5/5] migration: unify error handling for process_incoming_migration_co

2019-01-13 Thread Fei Li
From: Fei Li In the current code, if process_incoming_migration_co() fails we do the same error handing: set the error state, close the source file, do the cleanup for multifd, and then exit(EXIT_FAILURE). To make the code clearer, add a "goto fail" to unify the error handling. Cc: Dr. David

Re: [Qemu-devel] [PATCH v2 0/3] optimize waiting for free thread to do compression

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190111063732.10484-1-xiaoguangr...@tencent.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Encode the SCSI channel (bus) in the SRP LUNs

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1547042603-21147-1-git-send-email-th...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181217231629.24147-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181217231629.24147-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] ui: vnc: finish

Re: [Qemu-devel] [PATCH] slirp: check data length while emulating ident function

2019-01-13 Thread P J P
+-- On Fri, 11 Jan 2019, Marc-André Lureau wrote --+ | > | Check looks correct, it should probably return 1. | > | > Function comment says return 1 if 'm' is valid and should be appended via | > sbappend(). Not sure if unprocessed 'm' should go to sbappend(). | | If you look at the rest of the

[Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues

2019-01-13 Thread Fei Li
All these five patches have gotten the Reviewed-by: the first patch is to fix one segmentation fault and the other four are to fix some migration issues. To be more detail, they are extracted from previous "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to callers to handle.", but

[Qemu-devel] [PATCH for-4.0 3/5] migration: multifd_save_cleanup() can't fail, simplify

2019-01-13 Thread Fei Li
From: Fei Li multifd_save_cleanup() takes an Error ** argument and returns an error code even though it can't actually fail. Its callers dutifully check for failure. Remove the useless argument and return value, and simplify the callers. Cc: Dr. David Alan Gilbert Cc: Markus Armbruster

Re: [Qemu-devel] [PATCH v9 00/21] Fixing record/replay and adding reverse debugging

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/154703587757.13472.3898702635363120794.stgit@pasha-VirtualBox/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

Re: [Qemu-devel] [PATCH] contrib/gitdm: Fix a typo

2019-01-13 Thread Paolo Bonzini
On 11/01/19 23:39, Philippe Mathieu-Daudé wrote: > On 1/11/19 10:28 PM, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/201905.8270-1-phi...@redhat.com/ >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information:

Re: [Qemu-devel] [PATCH v5 0/4] allow to load initrd below 4G for recent kernel

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1547197071-14504-1-git-send-email-lizhij...@cn.fujitsu.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1547197071-14504-1-git-send-email-lizhij...@cn.fujitsu.com Subject:

Re: [Qemu-devel] [PATCH v1 00/19] testing/next queue for travis and docker

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110174516.21586-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH for-4.0 v9 12/16] qemu_thread: supplement error handling for iothread_complete/qemu_signalfd_compat

2019-01-13 Thread Fei Li
在 2019/1/9 上午12:18, fei 写道: 在 2019年1月8日,01:50,Markus Armbruster 写道: Fei Li writes: For iothread_complete: utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary _abort. For qemu_signalfd_compat: add a local_err to hold the error, and

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-13 Thread P J P
+-- On Fri, 11 Jan 2019, Daniel P. Berrangé wrote --+ | qga/commands.c already includes qemu/osdep.h which includs unistd.h. | | The build problem patchew reported was from *mingw* builds where | sysconf does not exist. I see; Not sure how to fix it. Maybe with conditional declaration? #ifdef

Re: [Qemu-devel] [PATCH v2 0/3] optimize waiting for free thread to do compression

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190111063732.10484-1-xiaoguangr...@tencent.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH] ftgmac100: implement the new MDIO interface on Aspeed SoC

2019-01-13 Thread Andrew Jeffery
On Fri, 11 Jan 2019, at 23:27, Cédric Le Goater wrote: > The PHY behind the MAC of an Aspeed SoC can be controlled using two > different MDC/MDIO interfaces. The same registers PHYCR (MAC60) and > PHYDATA (MAC64) are involved but they have a different layout. > > BIT31 of the Feature Register

Re: [Qemu-devel] [PULL 0/2] Linux user for 4.0 patches

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110083737.5036-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190110083737.5036-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 0/2] Linux user for 4.0

Re: [Qemu-devel] [PATCH v2] slirp: check data length while emulating ident function

2019-01-13 Thread Samuel Thibault
P J P, le dim. 13 janv. 2019 23:29:48 +0530, a ecrit: > From: Prasad J Pandit > > While emulating identification protocol, tcp_emu() does not check > available space in the 'sc_rcv->sb_data' buffer. It could lead to > heap buffer overflow issue. Add check to avoid it. > > Reported-by: Kira

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-13 Thread Dave Chinner
On Fri, Jan 11, 2019 at 02:45:04AM -0500, Pankaj Gupta wrote: > > > > > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > > This patch series has implementation for "virtio pmem". > > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > > which allows to bypass the

[Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions

2019-01-13 Thread Fredrik Noring
This series introduces limited support for R5900 multimedia instructions (MMIs) by implementing and testing PCPYLD, PCPYUD, LQ and SQ. 32 128-bit multimedia registers (MMRs) are introduced. They are split into two 64-bit halves: the lower halves are the GPRs and the upper halves are accessible by

[Qemu-devel] [PATCH 5/9] target/mips: Support the R5900 LQ multimedia instruction

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 46 - 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 8c350729bc..79505bb6c2 100644 --- a/target/mips/translate.c +++

[Qemu-devel] [PATCH 6/9] target/mips: Support the R5900 SQ multimedia instruction

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 44 +++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 79505bb6c2..1c7c649d36 100644 --- a/target/mips/translate.c +++

[Qemu-devel] [PATCH 4/9] target/mips: Support the R5900 PCPYUD multimedia instruction

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 40faf9cb36..8c350729bc 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c

Re: [Qemu-devel] [PATCH] crypto: finish removing TABs

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181217231639.24250-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181217231639.24250-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] crypto: finish

[Qemu-devel] [PATCH 2/9] target/mips: Introduce 32 R5900 128-bit multimedia registers

2019-01-13 Thread Fredrik Noring
The 32 R5900 128-bit MMRs are split into two 64-bit halves: the lower halves are the GPRs and the upper halves are accessible by the R5900- specific multimedia instructions. Signed-off-by: Fredrik Noring --- target/mips/cpu.h | 2 ++ target/mips/translate.c | 14 -- 2 files

[Qemu-devel] [PATCH 3/9] target/mips: Support the R5900 PCPYLD multimedia instruction

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 9d5150ec8b..40faf9cb36 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c

[Qemu-devel] [PATCH 1/9] target/mips: Require TARGET_MIPS64 for R5900 multimedia instructions

2019-01-13 Thread Fredrik Noring
The R5900 MMIs operate on 128-bit registers that will be split into two halves: lower 64-bit GPRs and upper 64-bit MMRs. The MMIs will therefore be left unimplemented in 32-bit mode with the o32 ABI. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 28 1

Re: [Qemu-devel] [PATCH] hw/pvrdma: Post CQE when receive invalid gid index

2019-01-13 Thread Yuval Shaia
On Sat, Jan 12, 2019 at 05:11:39PM +0200, Marcel Apfelbaum wrote: > > > On 1/9/19 10:15 PM, Yuval Shaia wrote: > > This error should propagate back to guest. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_backend.h | 1 + > > hw/rdma/vmw/pvrdma_qp_ops.c | 6 -- > > 2

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-13 Thread Yuval Shaia
On Sun, Jan 13, 2019 at 09:24:40PM +0200, Yuval Shaia wrote: > On Sat, Jan 12, 2019 at 05:02:24PM +0200, Marcel Apfelbaum wrote: > > Do not initialize structs with {0} since some > > CLANG versions do not support it. > > > > Use memset instead. > > It is easier than patching CLANG ha? :) > > >

Re: [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2019-01-13 Thread Fredrik Noring
Hi Aleksandar, > - Suggestion: The next MIPS pull request is scehuled for Friday, > Jan 18, 2018. It would be fantastic if you could prepare the > following by Jan 14: > > * Add 32 TCGv_i64 registers that would represent higher halves > of R5900 general purpose registers. Done! > * Add

[Qemu-devel] [PATCH 9/9] tests/tcg/mips: Test R5900 multimedia instruction SQ

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsn32r5900/Makefile | 1 + tests/tcg/mips/mipsn32r5900/sq.c | 105 +++ 2 files changed, 106 insertions(+) create mode 100644 tests/tcg/mips/mipsn32r5900/sq.c diff --git a/tests/tcg/mips/mipsn32r5900/Makefile

Re: [Qemu-devel] [PATCH v2 0/9] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019053451.14304-1-tao3...@intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH 7/9] tests/tcg/mips: Test R5900 multimedia instructions PCPYUD and PCPYLD

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsn32r5900/Makefile | 25 +++ tests/tcg/mips/mipsn32r5900/pcpyuld.c | 46 +++ 2 files changed, 71 insertions(+) create mode 100644 tests/tcg/mips/mipsn32r5900/Makefile create mode 100644

[Qemu-devel] [PATCH 8/9] tests/tcg/mips: Test R5900 multimedia instruction LQ

2019-01-13 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsn32r5900/Makefile | 3 +- tests/tcg/mips/mipsn32r5900/lq.c | 111 +++ 2 files changed, 113 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/mips/mipsn32r5900/lq.c diff --git

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-13 Thread Yuval Shaia
On Sat, Jan 12, 2019 at 05:02:24PM +0200, Marcel Apfelbaum wrote: > Do not initialize structs with {0} since some > CLANG versions do not support it. > > Use memset instead. It is easier than patching CLANG ha? :) > > Signed-off-by: Marcel Apfelbaum > --- > contrib/rdmacm-mux/main.c | 12

Re: [Qemu-devel] [PATCH 3/3] contrib/rdmacm-mux: fix clang compilation

2019-01-13 Thread Yuval Shaia
On Sat, Jan 12, 2019 at 05:02:25PM +0200, Marcel Apfelbaum wrote: > Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation >of RDMA User MAD multiplexer). > > The above commit introduces a new contrib target, adding a global dependency > to libumad library in case

Re: [Qemu-devel] [PATCH 00/13] Misc fixes / improvements for the docker and travis configs

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190109163114.17010-1-berra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH 1/3] contrib/rdmacm-mux: remove Wno-format-truncation flag

2019-01-13 Thread Yuval Shaia
On Sat, Jan 12, 2019 at 05:02:23PM +0200, Marcel Apfelbaum wrote: > The flag is not recognized by some CLANG versions. > Add proper constraints in code instead. > > Signed-off-by: Marcel Apfelbaum > --- > contrib/rdmacm-mux/Makefile.objs | 2 +- > contrib/rdmacm-mux/main.c| 6 -- >

Re: [Qemu-devel] [PATCH 0/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

2019-01-13 Thread Markus Armbruster
Leonid Bloch writes: > On 1/11/19 9:14 PM, Markus Armbruster wrote: >> Back in September, Leonid Block added a whole bunch of macros (commit > > * Bloch. :) I apologize for my carelessness. Explanation, no excuse: $ git-log --author=armbru -Sblock -i --oneline | wc -l 167 $

Re: [Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-13 Thread Markus Armbruster
Alex Bennée writes: > Aleksandar Markovic writes: > >> On Monday, January 7, 2019, Alex Bennée wrote: >> >>> >>> Hi, >>> >>> Added a few more updates mostly of IBMers with non corporate emails. >> >> >> Alex, it seems logical to me that you also create a section on gitdm in >> MAINTAINERS, and

Re: [Qemu-devel] [PULLv2 00/65] slirp updates

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190114000326.29847-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190114000326.29847-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULLv2 00/65]

Re: [Qemu-devel] [PATCH] ftgmac100: implement the new MDIO interface on Aspeed SoC

2019-01-13 Thread Cédric Le Goater
On 1/14/19 4:29 AM, Joel Stanley wrote: > On Fri, 11 Jan 2019 at 23:58, Cédric Le Goater wrote: >> >> The PHY behind the MAC of an Aspeed SoC can be controlled using two >> different MDC/MDIO interfaces. The same registers PHYCR (MAC60) and >> PHYDATA (MAC64) are involved but they have a

[Qemu-devel] [PATCH 4/7] target/xtensa: extract debug helpers

2019-01-13 Thread Max Filippov
Move HELPER functions related to native debugging from op_helper.c to dbg_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/dbg_helper.c | 129 target/xtensa/op_helper.c | 92

[Qemu-devel] [PATCH 7/7] target/xtensa: move non-HELPER functions to helper.c

2019-01-13 Thread Max Filippov
Move remaining non-HELPER functions from op_helper.c to helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/helper.c| 61 --- target/xtensa/op_helper.c | 56 --- 2 files changed,

[Qemu-devel] [PATCH 3/7] target/xtensa: extract MMU helpers

2019-01-13 Thread Max Filippov
Move MMU-related helper functions from op_helper.c and helper.c to mmu_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/helper.c | 487 -- target/xtensa/mmu_helper.c | 818

[Qemu-devel] [PATCH 2/7] target/xtensa: extract windowed registers helpers

2019-01-13 Thread Max Filippov
Move helper functions related to register windows from op_helper.c to win_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/op_helper.c | 190 - target/xtensa/win_helper.c | 222

[Qemu-devel] [PATCH 5/7] target/xtensa: extract interrupt and exception helpers

2019-01-13 Thread Max Filippov
Move helper functions related to interrupt and exception handling from op_helper.c and helper.c to exc_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/exc_helper.c | 258

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Markus Armbruster
Peter Xu writes: > On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: >> From: Fei Li >> >> Let's supplement the msi_uninit() when failing to realize >> the pci edu device. >> >> Cc: Markus Armbruster >> Cc: Peter Xu >> Cc: Michael S. Tsirkin >> Cc: Marcel Apfelbaum >> Signed-off-by:

Re: [Qemu-devel] [PULLv2 00/65] slirp updates

2019-01-13 Thread Samuel Thibault
no-re...@patchew.org, le dim. 13 janv. 2019 19:16:44 -0800, a ecrit: > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > === TEST SCRIPT BEGIN === >

[Qemu-devel] [PATCH] vhost-user-blk: enable discard/write zeroes features

2019-01-13 Thread Changpeng Liu
Linux commit 1f23816b8 "virtio_blk: add discard and write zeroes support" added the support in the Guest kernel, while here enable the feature bits support with vhost-user-blk driver. Also enable the test example utility with DISCARD command support. Signed-off-by: Changpeng Liu ---

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Peter Xu
On Mon, Jan 14, 2019 at 08:02:23AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: > >> From: Fei Li > >> > >> Let's supplement the msi_uninit() when failing to realize > >> the pci edu device. > >> > >> Cc: Markus Armbruster >

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-13 Thread Pankaj Gupta
> > Until you have images (and hence host page cache) shared between > > multiple guests. People will want to do this, because it means they > > only need a single set of pages in host memory for executable > > binaries rather than a set of pages per guest. Then you have > > multiple guests

[Qemu-devel] [PATCH 0/7] target/xtensa: group helpers by functionality

2019-01-13 Thread Max Filippov
Hello, this series moves helper functions for FPU, windowed registers, MMU, native debug, interrupt and exception handling from op_helper.c and helper.c to separate *_helper.c files. There's no functional changes. Max Filippov (7): target/xtensa: extract FPU helpers target/xtensa: extract

[Qemu-devel] [PATCH 6/7] target/xtensa: drop dump_state helper

2019-01-13 Thread Max Filippov
Drop unused helper dump_state from op_helper.c Signed-off-by: Max Filippov --- target/xtensa/helper.h| 1 - target/xtensa/op_helper.c | 11 --- 2 files changed, 12 deletions(-) diff --git a/target/xtensa/helper.h b/target/xtensa/helper.h index 2ebba0b2c2bf..89eb97e26514 100644 ---

[Qemu-devel] [PATCH 1/7] target/xtensa: extract FPU helpers

2019-01-13 Thread Max Filippov
Move FPU-related HELPER functions from op_helper.c to fpu_helper.c No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/fpu_helper.c | 166 target/xtensa/op_helper.c | 135

Re: [Qemu-devel] [PATCH v2 02/13] spapr: Rename xics to intc in interrupt controller agnostic code

2019-01-13 Thread Cédric Le Goater
On 1/11/19 10:00 PM, Greg Kurz wrote: > All this code is used with both the XICS and XIVE interrupt controllers. I am not fond of the name : spapr_dt_intc_irq(), it seems a bit redundant. Nevertheless, Reviewed-by: Cédric Le Goater Thanks, C. > > Signed-off-by: Greg Kurz > --- >

<    1   2