Re: [Qemu-devel] [RFC v1 1/3] intel_iommu: scalable mode emulation

2019-02-13 Thread Peter Xu
On Wed, Feb 13, 2019 at 03:38:55PM +0800, Yi Sun wrote: [...] > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > > > index 8b72735..396ac8e 100644 > > > --- a/hw/i386/intel_iommu.c > > > +++ b/hw/i386/intel_iommu.c > > > @@ -37,6 +37,34 @@ > > > #include "kvm_i386.h" > > >

Re: [Qemu-devel] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-13 Thread Cédric Le Goater
On 2/13/19 2:33 AM, David Gibson wrote: > On Tue, Feb 12, 2019 at 08:05:53AM +0100, Cédric Le Goater wrote: >> On 2/12/19 2:06 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:39:45PM +0100, Cédric Le Goater wrote: The IRQ number space of the XIVE and XICS interrupt mode are aligned

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefano Garzarella
On Wed, Feb 13, 2019 at 04:01:43PM +0800, Stefan Hajnoczi wrote: > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > support" added fields to struct virtio_blk_config. This changes > > the size of the config

[Qemu-devel] [PATCH v2 08/25] hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig

2019-02-13 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 23 +++- hw/arm/Kconfig | 47 +

[Qemu-devel] [PATCH v2 13/25] hw/arm: Express dependencies of the virt machine with Kconfig

2019-02-13 Thread Thomas Huth
Dependencies have been determined by looking at hw/arm/virt.c Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 14 +- hw/arm/Kconfig | 19 +++ hw/arm/Makefile.objs| 3 ++- 3 files changed, 22 insertions(+), 14

[Qemu-devel] [PATCH v2 11/25] hw/arm: Express dependencies of collie with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the Strongarm collie machine. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 7 +++

[Qemu-devel] [PATCH v2 14/25] hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig

2019-02-13 Thread Thomas Huth
Netduino only depends on the stm32f205 SoC which in turn depends on its components. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 9 + hw/arm/Kconfig | 7 +++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v2 07/25] hw/arm: Express dependencies of stellaris with Kconfig

2019-02-13 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 10 ++ 2 files changed, 11 insertions(+), 6 deletions(-) diff

Re: [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree

2019-02-13 Thread Bastian Koppelmann
On 2/13/19 3:15 AM, Palmer Dabbelt wrote: On Tue, Feb 12, 2019 at 3:21 PM Palmer Dabbelt wrote: [snip] Do you, by any chance, have a v7? It looks like there's quite a few merge conflicts here, and while I'm OK fixing them I don't want to do it if you already have. I made it through my

[Qemu-devel] [PATCH v2 04/25] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the fsl-imx31 / kzm machine. This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 5 +

[Qemu-devel] [PATCH v4 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-13 Thread Knut Omang
Add a helper function to add PCIe capability for Access Control Services (ACS) ACS support in the associated root port is needed to pass through individual functions of a device to different VMs with VFIO without Alex Williamson's pcie_acs_override kernel patch or similar in the guest. Single

[Qemu-devel] [PATCH v4 0/2] pcie: Add simple ACS "support" to the generic PCIe root port

2019-02-13 Thread Knut Omang
These two patches together implements a PCIe capability config space header for Access Control Services (ACS) for the new Qemu specific generic root port. ACS support in the associated root port is a prerequisite to be able to pass individual functions of a device populating the port through to an

[Qemu-devel] [PATCH v4 2/2] gen_pcie_root_port: Add ACS (Access Control Services) capability

2019-02-13 Thread Knut Omang
Claim ACS support in the generic PCIe root port to allow passthrough of individual functions of a device to different guests (in a nested virt.setting) with VFIO. Without this patch, all functions of a device, such as all VFs of an SR/IOV device, will end up in the same IOMMU group. A similar

[Qemu-devel] Seeking QEMU makefile advice

2019-02-13 Thread Markus Armbruster
Hi Paolo, I'm trying to resolve a FIXME in a patch I recently posted. Here's what I want to do: QAPI_COMMON_MODULES = block-core block char common crypto introspect QAPI_COMMON_MODULES += job migration misc net rdma rocker run-state QAPI_COMMON_MODULES += sockets tpm trace

[Qemu-devel] [PATCH v2 23/25] hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig

2019-02-13 Thread Thomas Huth
This cleans up most settings in default-configs/aarch64-softmmu.mak. Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 4 hw/arm/Kconfig | 11 +++ hw/display/Kconfig | 1 + 3 files changed, 12 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v2 03/25] hw/arm: Express dependencies of integratorcp with Kconfig

2019-02-13 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 11 +-- hw/arm/Kconfig | 9 + hw/display/Kconfig | 1 + 3 files

[Qemu-devel] [PATCH v2 12/25] hw/arm: Express dependencies of the aspeed boards with Kconfig

2019-02-13 Thread Thomas Huth
Dependencies have been determined by looking at hw/arm/aspeed.c Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 10 ++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v2 16/25] hw/arm: Express dependencies of the MPS2 boards with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the mps2-an* machines. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 19 +-- hw/arm/Kconfig | 17 + 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v2 10/25] hw/arm: Express dependencies of xilinx-zynq with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the xilinx-zynq-a9 board. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 14 ++ 2 files

Re: [Qemu-devel] [PATCH 1/2] qga-win: include glib when building VSS DLL

2019-02-13 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 03:29:16PM -0600, Michael Roth wrote: > Commit 3ebee3b191e defined assert() as g_assert(), but when we build > the VSS DLL component of QGA (to handle fsfreeze) we do not include > glib, which results in breakage when building with VSS support enabled. > > Fix this by

Re: [Qemu-devel] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-13 Thread Cornelia Huck
On Mon, 11 Feb 2019 20:16:56 -0500 Collin Walling wrote: > Latest systems and host kernels support mepoch, which is a > feature that was meant to be supported for z14 GA1 from the > get-go. Let's copy it to the z14 GA1 default CPU model. > > Machines s390-ccw-virtio-3.1 and older will retain

Re: [Qemu-devel] NSIS - including DLL dependencies for Windows

2019-02-13 Thread Stefan Weil
On 13.02.19 10:32, Daniel P. Berrangé wrote: > FYI, I re-discovered a way to do this without needing wine, just plain > binutils > > x86_64-w64-mingw32-objdump -p /path/to/binary.exe | grep "DLL Name" | awk > '{print $3}' See also https://github.com/gsauthof/pe-util. The command line tool

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-13 Thread Kevin Wolf
Am 13.02.2019 um 07:58 hat Stefan Hajnoczi geschrieben: > On Tue, Feb 12, 2019 at 12:58:40PM +0100, Kevin Wolf wrote: > > Am 12.02.2019 um 04:22 hat Stefan Hajnoczi geschrieben: > > > On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > 11.02.2019 6:42,

Re: [Qemu-devel] [PATCH v2 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-13 Thread Dr. David Alan Gilbert
* Yuval Shaia (yuval.sh...@oracle.com) wrote: > Allow interrogating device internals through HMP interface. > The exposed indicators can be used for troubleshooting by developers or > sysadmin. > There is no need to expose these attributes to a management system (e.x. > libvirt) because (1) most

Re: [Qemu-devel] [PATCH v2] hostmem-file: reject invalid pmem file sizes

2019-02-13 Thread Wei Yang
On Wed, Feb 13, 2019 at 03:14:01PM +0800, Stefan Hajnoczi wrote: >Guests started with NVDIMMs larger than the underlying host file produce >confusing errors inside the guest. This happens because the guest >accesses pages beyond the end of the file. > >Check the pmem file size on startup and

[Qemu-devel] [PATCH v2 22/25] hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the NRF51 / microbit machine. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 6 ++ hw/arm/Makefile.objs| 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 25/25] hw/arm: Remove hard-enablement of the remaining PCI devices

2019-02-13 Thread Thomas Huth
The PCI devices should be pulled in by default if PCI_DEVICES is set, so there is no need anymore to enforce them in the configs file. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 1 file changed, 8 deletions(-) diff --git a/default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v2 09/25] hw/arm: Express dependencies of the PXA2xx machines with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the PXA2xx machines (akita, borzoi, connex and verdex gumstix, tosa, mainstone, spitz, terrier and z2). This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth ---

[Qemu-devel] [PATCH v2 15/25] hw/arm: Express dependencies of allwinner / cubieboard with Kconfig

2019-02-13 Thread Thomas Huth
Add dependencies for the Cubitech Cubieboard. Note that CONFIG_AHCI has a hard dependency on CONFIG_PCI currently, so PCI is now always selected by AHCI, even for boards that only want to use AHCI via a sysbus device. We should break up that dependency later by splitting ahci.c into sysbus and

[Qemu-devel] [PATCH v2 18/25] hw/arm: Express dependencies of canon-a1100 with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the DIGIC / canon-a1100 machine. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 +- hw/arm/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 00/25] Kconfig dependencies for ARM machines

2019-02-13 Thread Thomas Huth
This series reworks the default-configs/arm-softmmu.mak and default-configs/aarch64-softmmu.mak files to use the new Kconfig-style dependencies instead. Based-on: 1549562254-41157-1-git-send-email-pbonz...@redhat.com ("Support Kconfig in QEMU") The first half of the patches is slightly

[Qemu-devel] [PATCH v2 01/25] hw/arm: Express dependencies of the exynos machines with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the Exynos-related boards (nuri and smdkc210). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 16 ++-- hw/arm/Kconfig

[Qemu-devel] [Bug 1813940] Re: kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device

2019-02-13 Thread Darek Stojaczyk
> Does this patch from Jagannathan Raman fixes it? > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01397.html It fixes my case. Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v4 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-13 Thread Stefano Garzarella
On Tue, Feb 12, 2019 at 09:19:13AM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 02:49:44PM +0100, Stefano Garzarella wrote: > > This series adds the support of DISCARD and WRITE_ZEROES commands > > and extends the virtio-blk-test to test WRITE_ZEROES command when > > the feature is

Re: [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-13 Thread Cornelia Huck
On Mon, 11 Feb 2019 20:16:55 -0500 Collin Walling wrote: > The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent > on the multiple-epoch facility (mepoch). Let's print a warning if these > features are enabled without mepoch. > > While we're at it, let's move the FEAT_GROUP_INIT

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 09:22:46 +0100 Cédric Le Goater wrote: > On 2/13/19 2:32 AM, David Gibson wrote: > > On Tue, Feb 12, 2019 at 08:18:19AM +0100, Cédric Le Goater wrote: > >> On 2/12/19 2:11 AM, David Gibson wrote: > >>> On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefan Hajnoczi
On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > >

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2019 at 09:05:11PM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > support" added fields to struct virtio_blk_config. This changes > > the size of the config

Re: [Qemu-devel] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-13 Thread Cédric Le Goater
On 2/13/19 2:32 AM, David Gibson wrote: > On Tue, Feb 12, 2019 at 08:18:19AM +0100, Cédric Le Goater wrote: >> On 2/12/19 2:11 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: The interrupt mode is chosen by the CAS negotiation process and

Re: [Qemu-devel] [RFC v1 1/3] intel_iommu: scalable mode emulation

2019-02-13 Thread Peter Xu
On Wed, Feb 13, 2019 at 04:03:05PM +0800, Peter Xu wrote: > On Wed, Feb 13, 2019 at 03:38:55PM +0800, Yi Sun wrote: > > [...] > > > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > > > > index 8b72735..396ac8e 100644 > > > > --- a/hw/i386/intel_iommu.c > > > > +++

Re: [Qemu-devel] [RFC 1/4] numa, spapr: add thread-id in the possible_cpus list

2019-02-13 Thread Igor Mammedov
On Wed, 13 Feb 2019 12:25:45 +1100 David Gibson wrote: > On Tue, Feb 12, 2019 at 10:48:24PM +0100, Laurent Vivier wrote: > > spapr_possible_cpu_arch_ids() counts only cores, and so > > the number of available CPUs is the number of vCPU divided > > by smp_threads. > > > > ... -smp

[Qemu-devel] [PATCH v2 17/25] hw/arm: Express dependencies of the raspi machines with Kconfig

2019-02-13 Thread Thomas Huth
Most of the code is directly controlled by the CONFIG_RASPI switch, so not much to add here additionally. Note that CONFIG_SDHCI currently has a hard requirement for PCI, so we select that switch now always there instead of depending on it. We should split up sdhci.c into sysbus and pci parts

[Qemu-devel] [PATCH v2 24/25] hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig

2019-02-13 Thread Thomas Huth
Dependencies have been determined with trial-and-error and by looking at the xlnx-versal.c source file. Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 721cc07..027c063 100644 --- a/hw/arm/Kconfig +++

[Qemu-devel] [PATCH v2 20/25] hw/arm: Express dependencies of the MSF2 machine with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the emcraft-sf2 machine - we also distinguis between the machine (CONFIG_EMCRAFT_SF2) and the SoC (CONFIG_MSF2) now. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 8 hw/arm/Makefile.objs

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-13 Thread Philippe Mathieu-Daudé
Hi Laurent, On 2/13/19 9:49 AM, Laurent Vivier wrote: > On 12/02/2019 06:34, Michael S. Tsirkin wrote: >> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: There are several functions/variable which are not used anymore.

[Qemu-devel] [PATCH v2 02/25] hw/arm: Express dependencies of the highbank machines with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the highbank machine (and the midway machine). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig |

[Qemu-devel] [PATCH v2 06/25] hw/arm: Express dependencies of the OMAP machines with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the OMAP machines (cheetah, n800, n810, sx1 and sx1-v1). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 15 +++

Re: [Qemu-devel] [PATCH v2] hostmem-file: reject invalid pmem file sizes

2019-02-13 Thread Wei Yang
On Wed, Feb 13, 2019 at 03:14:01PM +0800, Stefan Hajnoczi wrote: >Guests started with NVDIMMs larger than the underlying host file produce >confusing errors inside the guest. This happens because the guest >accesses pages beyond the end of the file. > >Check the pmem file size on startup and

Re: [Qemu-devel] [PATCH 2/2] qga-win: fix VSS build breakage due to unintended gnu99 C++ flag

2019-02-13 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 03:29:17PM -0600, Michael Roth wrote: > Commit 7be41675f7c set -std=gnu99 for C code via QEMU_CFLAGS. Currently > we generate a "custom" QEMU_CXXFLAGS for VSS DLL C++ build by > filtering out some options from QEMU_CFLAGS and adding some others. > Since we don't filter out

Re: [Qemu-devel] [PATCH v4 14/15] spapr: add hotplug hooks for PHB hotplug

2019-02-13 Thread David Hildenbrand
On 12.02.19 19:25, Greg Kurz wrote: > Hotplugging PHBs is a machine-level operation, but PHBs reside on the > main system bus, so we register spapr machine as the handler for the > main system bus. > > Provide the usual pre-plug, plug and unplug-request handlers. > > Move the checking of the PHB

Re: [Qemu-devel] [PATCH 1/5] block/dirty-bitmap: add recording and busy properties

2019-02-13 Thread Vladimir Sementsov-Ogievskiy
On 12.02.2019 1:02, John Snow wrote: > The current API allows us to report a single status, which we've defined as: > > Frozen: has a successor, treated as qmp_locked, may or may not be enabled. > Locked: no successor, qmp_locked. may or may not be enabled. > Disabled: Not frozen or locked,

Re: [Qemu-devel] NSIS - including DLL dependencies for Windows

2019-02-13 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 10:49:11AM +, Daniel P. Berrangé wrote: > On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote: > > Hi, > > How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS > > installer? (and also in a standalone build to be zipped up, but that's less >

Re: [Qemu-devel] [PATCH v3 2/2] gen_pcie_root_port: Add ACS (Access Control Services) capability

2019-02-13 Thread Knut Omang
On Mon, 2019-02-11 at 10:07 +0200, Marcel Apfelbaum wrote: > > On 2/10/19 8:53 AM, Knut Omang wrote: > > Claim ACS support in the generic PCIe root port to allow > > passthrough of individual functions of a device to different > > guests (in a nested virt.setting) with VFIO. > > Without this

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-13 Thread Jason Wang
On 2019/2/13 上午2:40, Michael S. Tsirkin wrote: On Tue, Feb 12, 2019 at 03:00:55PM +0800, Jason Wang wrote: On 2019/2/12 下午2:48, Jason Wang wrote: On 2019/2/11 下午9:40, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are

Re: [Qemu-devel] [PATCH v2 3/3] s390x/cpumodel: add z14 GA2 model

2019-02-13 Thread Cornelia Huck
On Mon, 11 Feb 2019 20:16:57 -0500 Collin Walling wrote: > Introduce the z14 GA2 cpu model for QEMU. There are no new features > introduced with this model, and will inherit the same feature set as > z14 GA1. > > Signed-off-by: Collin Walling > Acked-by: Christian Borntraeger > Reviewed-by:

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 09:48:57 +0800 Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > > qemu-system-ppc64:

Re: [Qemu-devel] [PATCH 07/19] target/ppc: Make special ORs match x86 pause and don't generate on mttcg

2019-02-13 Thread Cédric Le Goater
On 2/13/19 5:54 AM, David Gibson wrote: > On Wed, Feb 13, 2019 at 11:03:12AM +1100, Benjamin Herrenschmidt wrote: >> On Tue, 2019-02-12 at 16:59 +1100, David Gibson wrote: >>> On Mon, Jan 28, 2019 at 10:46:13AM +0100, Cédric Le Goater wrote: From: Benjamin Herrenschmidt There's no

[Qemu-devel] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-13 Thread Laszlo Ersek
Hi, using QEMU, when I specify a nonzero LUN for the hard disk that sits on the "SCSI bus" that embodies the USB Bulk Only Transfer device, then UsbMassStorageDxe fails to recognize the hard disk. (1) Consider the following QEMU command line snippet: -drive

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-13 Thread Laurent Vivier
On 12/02/2019 06:34, Michael S. Tsirkin wrote: > On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>> There are several functions/variable which are not used anymore. >>> >>> This serials just remove those without functional

[Qemu-devel] [PATCH v2 21/25] hw/arm: Express dependencies for remaining IMX boards with Kconfig

2019-02-13 Thread Thomas Huth
IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 -- hw/arm/Kconfig | 18 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v2 19/25] hw/arm: Express dependencies of sabrelite with Kconfig

2019-02-13 Thread Thomas Huth
Add Kconfig dependencies for the Sabrelite / iMX6 machine. Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig | 7 +++ hw/arm/Makefile.objs| 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [RFC v1 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-13 Thread Yi Sun
On 19-02-12 14:27:28, Peter Xu wrote: > On Wed, Jan 30, 2019 at 01:09:12PM +0800, Yi Sun wrote: > > From: "Liu, Yi L" > > > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > > Mode. This patch adds emulation of 256bits qi_desc. > > > > [Yi Sun is co-developer to rebase and refine

[Qemu-devel] [PATCH v2 05/25] hw/arm: Express dependencies of musicpal with Kconfig

2019-02-13 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 6 +- hw/arm/Kconfig | 6 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [RFC 1/4] numa, spapr: add thread-id in the possible_cpus list

2019-02-13 Thread Laurent Vivier
On 13/02/2019 09:42, Igor Mammedov wrote: On Wed, 13 Feb 2019 12:25:45 +1100 David Gibson wrote: On Tue, Feb 12, 2019 at 10:48:24PM +0100, Laurent Vivier wrote: spapr_possible_cpu_arch_ids() counts only cores, and so the number of available CPUs is the number of vCPU divided by smp_threads.

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-13 Thread Wei Yang
On Wed, Feb 13, 2019 at 09:49:01AM +0100, Laurent Vivier wrote: >On 12/02/2019 06:34, Michael S. Tsirkin wrote: >> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: There are several functions/variable which are not used

Re: [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf

2019-02-13 Thread Stefano Garzarella
On Tue, Feb 12, 2019 at 03:53:22PM +0100, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested (with -d unimp): > > $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin > dma: command df not supported > dma: command df not supported > dma: command df not

Re: [Qemu-devel] [PATCH v3 3/3] tpm_tis: convert tpm_tis_show_buffer() to use trace event

2019-02-13 Thread Liam Merwick
On 12/02/2019 21:01, Stefan Berger wrote: On 2/12/19 3:48 PM, Liam Merwick wrote: cppcheck reports: [hw/tpm/tpm_tis.c:113]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int' Rather than just converting the format specifier to use '%u", the

Re: [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std"

2019-02-13 Thread Philippe Mathieu-Daudé
On 2/13/19 8:07 AM, Thomas Huth wrote: > The sun4uv_init() function expects vga_interface_type to be either > VGA_STD or VGA_NONE and sets up a stdvga device or no vga card > accordingly. > However, the code in vl.c prefers the Cirrus VGA card to stdvga if > it is available and the user and the

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-13 Thread BALATON Zoltan
Hello, On Wed, 13 Feb 2019, Mark Cave-Ayland wrote: On 12/02/2019 23:59, BALATON Zoltan wrote: This looks interesting, however I never received the original via the mailing list. Did it get held somewhere because its size? It appears in the list archives:

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefano Garzarella
On Wed, Feb 13, 2019 at 09:32:27AM +0100, Stefano Garzarella wrote: > On Wed, Feb 13, 2019 at 04:01:43PM +0800, Stefan Hajnoczi wrote: > > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > > support" added

Re: [Qemu-devel] [RFC 1/4] numa, spapr: add thread-id in the possible_cpus list

2019-02-13 Thread Igor Mammedov
On Wed, 13 Feb 2019 10:08:24 +0100 Laurent Vivier wrote: > On 13/02/2019 09:42, Igor Mammedov wrote: > > On Wed, 13 Feb 2019 12:25:45 +1100 > > David Gibson wrote: > > > >> On Tue, Feb 12, 2019 at 10:48:24PM +0100, Laurent Vivier wrote: > >>> spapr_possible_cpu_arch_ids() counts only

Re: [Qemu-devel] [PATCH v6 48/49] linux-user: Split out ioctl

2019-02-13 Thread Laurent Vivier
Hi, this one is really a cut'n'paste but it introduces a problem with qemu-alpha, I don't know how/why: $ sudo unshare --ipc --uts --pid --fork --kill-child --mount chroot chroot/alpha/sid/ Unsupported ioctl: cmd=0x80047476 And then it hangs. I'll try to debug. Thanks, Laurent On

Re: [Qemu-devel] [PATCH] s390x/kvm: add tracepoint to ioeventfd interface

2019-02-13 Thread Cornelia Huck
On Tue, 12 Feb 2019 17:12:33 +0100 David Hildenbrand wrote: > On 12.02.19 16:58, Cornelia Huck wrote: > > On Tue, 12 Feb 2019 16:52:09 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> Hi Cornelia, > >> > >> On 2/12/19 4:30 PM, Cornelia Huck wrote: > >>> Trace when assigning/unassigning. >

Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-13 Thread Marc-André Lureau
Hi On Wed, Feb 13, 2019 at 12:55 PM Thomas Huth wrote: > > This is very convenient for people like me who store their QEMU git trees > on gitlab.com: Automatic CI pipelines are now run for each branch that is > pushed to the server - useful for some extra-testing before sending PULL- > requests

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 12:27:13 +0100 Greg Kurz wrote: > On Wed, 13 Feb 2019 09:03:33 +0100 > Cédric Le Goater wrote: > > > On 2/13/19 2:33 AM, David Gibson wrote: > > > On Tue, Feb 12, 2019 at 08:05:53AM +0100, Cédric Le Goater wrote: > > >> On 2/12/19 2:06 AM, David Gibson wrote: > >

Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-13 Thread Thomas Huth
On 2019-02-13 13:06, Marc-André Lureau wrote: > Hi > > On Wed, Feb 13, 2019 at 12:55 PM Thomas Huth wrote: >> >> This is very convenient for people like me who store their QEMU git trees >> on gitlab.com: Automatic CI pipelines are now run for each branch that is >> pushed to the server - useful

Re: [Qemu-devel] [PATCH v4 03/15] spapr_irq: Set LSIs at interrupt controller init

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 14:48:44 +1100 David Gibson wrote: > On Tue, Feb 12, 2019 at 07:24:13PM +0100, Greg Kurz wrote: > > The pseries machine only uses LSIs to support legacy PCI devices. Every > > PHB claims 4 LSIs at realize time. When using in-kernel XICS (or upcoming > > in-kernel XIVE), QEMU

Re: [Qemu-devel] [PATCH v1 12/15] s390x/tcg: Implement XxC and checks for most FP instructions

2019-02-13 Thread David Hildenbrand
On 12.02.19 21:23, Richard Henderson wrote: > On 2/12/19 3:03 AM, David Hildenbrand wrote: >> -uint64_t HELPER(cegb)(CPUS390XState *env, int64_t v2, uint32_t m3) >> +uint64_t HELPER(cegb)(CPUS390XState *env, int64_t v2, uint32_t m) >> { >> -int old_mode = s390_swap_bfp_rounding_mode(env, m3);

[Qemu-devel] [PATCH] build: Correct explanation of unnest-vars example

2019-02-13 Thread Markus Armbruster
Cc: Fam Zheng Signed-off-by: Markus Armbruster --- rules.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index 86e033d815..19f3d2c126 100644 --- a/rules.mak +++ b/rules.mak @@ -327,7 +327,7 @@ endef # ../water/ice.mo-libs = -licemaker #

Re: [Qemu-devel] [PATCH v4 05/15] spapr_irq: Expose the phandle of the interrupt controller

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 14:52:04 +1100 David Gibson wrote: > On Tue, Feb 12, 2019 at 07:24:26PM +0100, Greg Kurz wrote: > > This will be used by PHB hotplug in order to create the "interrupt-map" > > property of the PHB node. > > > > Reviewed-by: Cédric Le Goater > > Signed-off-by: Greg Kurz > >

[Qemu-devel] [PATCH] s390x: upgrade status of KVM cores to "supported"

2019-02-13 Thread Cornelia Huck
We are actually paid to look after this. Signed-off-by: Cornelia Huck --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9a76845581b1..73ff5915638e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -377,7 +377,7 @@ S390 M: Halil

Re: [Qemu-devel] [RFC v1 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-13 Thread Peter Xu
On Wed, Feb 13, 2019 at 05:00:41PM +0800, Yi Sun wrote: [...] > > > > > > /* context entry operations */ > > > #define vtd_get_ce_size(s, ce) \ > > > @@ -65,6 +66,9 @@ > > > #define vtd_pe_get_slpt_base(pe) ((pe)->val[0] & > > > VTD_SM_PASID_ENTRY_SLPTPTR) > > > #define

Re: [Qemu-devel] Combining -loadvm and -snapshot

2019-02-13 Thread Kevin Wolf
Am 13.02.2019 um 07:07 hat Markus Armbruster geschrieben: > Cc'ing the QCOW2 folks. > > Drew DeVault writes: > > > I recently ran into an issue where I found I couldn't combine the > > -loadvm and -snapshot flags, nor any conceivable combination of > > alternate approaches like loadvm via the

[Qemu-devel] Clearing slirp/ license

2019-02-13 Thread Marc-André Lureau
Hi, As we are trying to move slirp/ in a standalone project, which eventually could be installed as a shared library, we need to clear the license. slirp is supposed to be 3-Clause BSD license (according to https://git.qemu.org/?p=qemu.git;a=commit;h=2f5f89963186d42a7ded253bc6cf5b32abb45cec) but

Re: [Qemu-devel] [PATCH] s390x: upgrade status of KVM cores to "supported"

2019-02-13 Thread Christian Borntraeger
On 13.02.2019 11:35, Cornelia Huck wrote: > We are actually paid to look after this. > > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

[Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-13 Thread Thomas Huth
This is very convenient for people like me who store their QEMU git trees on gitlab.com: Automatic CI pipelines are now run for each branch that is pushed to the server - useful for some extra-testing before sending PULL- requests for example. Since the runtime of the jobs is limited to 1h, the

Re: [Qemu-devel] [Qemu-block] [PATCH v3] drive-mirror: add incremental mode

2019-02-13 Thread 滴滴云
On 2019/2/5 8:02 AM,“John Snow” wrote: > On 1/31/19 7:17 AM, mahaocong wrote: > > From: mahaocong > > > > Please use "git send-email" where possible, it will help keep the > formatting right. Use "RESEND" or "v4" when sending out a cover letter > revision, so the tools can see it

Re: [Qemu-devel] [PATCH v2] hostmem-file: reject invalid pmem file sizes

2019-02-13 Thread Igor Mammedov
On Wed, 13 Feb 2019 16:53:54 +0800 Wei Yang wrote: > On Wed, Feb 13, 2019 at 03:14:01PM +0800, Stefan Hajnoczi wrote: > >Guests started with NVDIMMs larger than the underlying host file produce > >confusing errors inside the guest. This happens because the guest > >accesses pages beyond the end

Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-13 Thread Philippe Mathieu-Daudé
On 2/13/19 7:53 AM, Yuval Shaia wrote: > The function argument rdma_dev_res is not needed as it is stored in the > backend_dev object at init. > > Signed-off-by: Yuval Shaia > Reviewed-by: Marcel Apfelbaum Should we teach checkpatch.pl to check name/space/email?

Re: [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std"

2019-02-13 Thread Mark Cave-Ayland
On 13/02/2019 07:07, Thomas Huth wrote: > The sun4uv_init() function expects vga_interface_type to be either > VGA_STD or VGA_NONE and sets up a stdvga device or no vga card > accordingly. > However, the code in vl.c prefers the Cirrus VGA card to stdvga if > it is available and the user and the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 09:03:33 +0100 Cédric Le Goater wrote: > On 2/13/19 2:33 AM, David Gibson wrote: > > On Tue, Feb 12, 2019 at 08:05:53AM +0100, Cédric Le Goater wrote: > >> On 2/12/19 2:06 AM, David Gibson wrote: > >>> On Mon, Jan 07, 2019 at 07:39:45PM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] Clearing slirp/ license

2019-02-13 Thread Thomas Huth
On 2019-02-13 12:03, Marc-André Lureau wrote: > Hi, > > As we are trying to move slirp/ in a standalone project, which > eventually could be installed as a shared library, we need to clear > the license. > > slirp is supposed to be 3-Clause BSD license (according to >

[Qemu-devel] [Bug 1813940] Re: kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device

2019-02-13 Thread Dr. David Alan Gilbert
That also fixes the case I'd hit -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813940 Title: kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device Status in QEMU: Confirmed

Re: [Qemu-devel] [PATCH v4 01/15] spapr_irq: Add an @xics_offset field to sPAPRIrq

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 14:26:01 +1100 David Gibson wrote: > On Tue, Feb 12, 2019 at 07:24:00PM +0100, Greg Kurz wrote: > > Only pseries machines, either recent ones started with ic-mode=xics > > or older ones using the legacy irq allocation scheme, need to set the > > @offset of the ICS to

[Qemu-devel] [PATCH v2] chardev/wctablet: Fix a typo

2019-02-13 Thread Philippe Mathieu-Daudé
The correct name is Wacom. Fix the typo which is present since 378af96155d. Reviewed-by: Marc-André Lureau Signed-off-by: Philippe Mathieu-Daudé --- v2: Use correct English in description --- chardev/wctablet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH] hostmem: simplify ifdef-s in file_backend_memory_alloc()

2019-02-13 Thread Igor Mammedov
cleanup file_backend_memory_alloc() by using one CONFIG_POSIX ifdef instead of several ones within the function to make it simpler to follow. Signed-off-by: Igor Mammedov Suggested-by: Wei Yang --- Cc: Haozhong Zhang Cc: Zhang Yi Cc: Eduardo Habkost Cc: Stefan Hajnoczi CC: Wei Yang ---

Re: [Qemu-devel] [PATCH] hostmem: fix crash when querying empty host-nodes property via QMP

2019-02-13 Thread Igor Mammedov
On Tue, 5 Feb 2019 15:31:27 +0100 Igor Mammedov wrote: > QEMU will crashes with > qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion > `qov->root && ((>stack)->slh_first == ((void *)0))' failed > when trying to get value of empty hostmem.host-nodes property. > > Fix it by

Re: [Qemu-devel] [PATCH v1 08/15] s390x/tcg: Handle SET FPC AND LOAD FPC 3-bit BFP rounding modes

2019-02-13 Thread David Hildenbrand
On 12.02.19 20:56, Richard Henderson wrote: > On 2/12/19 11:32 AM, David Hildenbrand wrote: >>> Yes, you want round_to_odd. I suppose that's not valid for float128 right >>> now? >> >> roundAndPackFloat64() >> >> as well as >> >> roundAndPackFloat128() >> >> support it. >> >> It's not

Re: [Qemu-devel] [PATCH v4 13/15] spapr_drc: Allow FDT fragment to be added later

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 15:05:24 +1100 David Gibson wrote: > On Tue, Feb 12, 2019 at 07:25:19PM +0100, Greg Kurz wrote: > > The current logic is to provide the FDT fragment when attaching a device > > to a DRC. This works perfectly fine for our current hotplug support, but > > soon we will add

Re: [Qemu-devel] [PATCH 1/2] qga-win: include glib when building VSS DLL

2019-02-13 Thread Michael Roth
Quoting Daniel P. Berrangé (2019-02-13 03:12:06) > On Tue, Feb 12, 2019 at 03:29:16PM -0600, Michael Roth wrote: > > Commit 3ebee3b191e defined assert() as g_assert(), but when we build > > the VSS DLL component of QGA (to handle fsfreeze) we do not include > > glib, which results in breakage when

  1   2   3   4   5   >