Re: [Qemu-devel] [PATCH v1] tests: Add a simple device_del test for PCI devices

2019-02-15 Thread Thomas Huth
On 14/02/2019 18.11, David Hildenbrand wrote: > The issue with testing asynchronous unplug requests it that they usually > require a running guest to handle the request. However, to test if > unplug of PCI devices works, we can apply a nice little trick on some > architectures: > > On system

[Qemu-devel] [PATCH 1/2] .travis.yml: Test with disable-replication

2019-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We've had the build break with replication disabled, so lets test that case in travis. Suggsted-by: Alex Bennée Signed-off-by: Dr. David Alan Gilbert --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml

[Qemu-devel] [PATCH 2/2] .travis.yml: Remove disable-uuid

2019-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 315d3184525 turned --disable-uuid into a warning only; remove the check from Travis. Signed-off-by: Dr. David Alan Gilbert --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[Qemu-devel] MemoryRegionOps access sizes

2019-02-15 Thread BALATON Zoltan
Hello, Could someone please explain how the MemoryRegionOps valid.{min,max}_access_size and unaligned and corresponding impl constraints work and where are these implemented? And in particular if this would work: static const MemoryRegionOps ops = { .read = readfn, .write = writefn,

Re: [Qemu-devel] [PATCH 1/2] .travis.yml: Test with disable-replication

2019-02-15 Thread Thomas Huth
On 15/02/2019 10.45, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > We've had the build break with replication disabled, so lets > test that case in travis. > > Suggsted-by: Alex Bennée > Signed-off-by: Dr. David Alan Gilbert > --- > .travis.yml | 2 +- > 1 file

Re: [Qemu-devel] [PATCH v2 3/9] ccid-card-passthru: Assert on a stricter expression

2019-02-15 Thread Wei Yang
Would it be better to have some description? On Thu, Feb 14, 2019 at 09:19:33PM +0100, Philippe Mathieu-Daudé wrote: >Suggested-by: Paolo Bonzini >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/usb/ccid-card-passthru.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git

[Qemu-devel] [PATCH 11/17] target/ppc: Remove vscr_nj and vscr_sat

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson These macros are no longer used. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index 2c22292e7f..a62f628d28 100644 --- a/target/ppc/cpu.h +++

Re: [Qemu-devel] [PATCH] lsi: implement basic SBCL functionality

2019-02-15 Thread Paolo Bonzini
On 14/02/19 23:04, Sven Schnelle wrote: > HP-UX checks this register after sending data to the target. If there's no > valid > information present, it assumes the client disconnected because the kernel > sent > to much data. Implement at least some of the SBCL functionality that is > possible >

[Qemu-devel] [PATCH 06/17] target/ppc: convert xxspltib to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index

Re: [Qemu-devel] [PATCH v2 7/7] ui/cocoa: Perform UI operations only on the main thread

2019-02-15 Thread Peter Maydell
On Fri, 15 Feb 2019 at 01:28, BALATON Zoltan wrote: > > On Thu, 14 Feb 2019, Peter Maydell wrote: > > - (void)sendEvent:(NSEvent *)event > > { > > COCOA_DEBUG("QemuApplication: sendEvent\n"); > > -[super sendEvent: event]; > > +if (!cocoaView || ![cocoaView handleEvent:event]) { > > +

Re: [Qemu-devel] [PATCH] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-02-15 Thread Daniel P . Berrangé
On Mon, Jan 28, 2019 at 03:48:57PM -0200, Eduardo Habkost wrote: > On Fri, Jan 18, 2019 at 01:38:26PM +, Daniel P. Berrangé wrote: > > A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only > > support the virtio-1 (aka modern) mode. Currently if the user launches > > QEMU,

Re: [Qemu-devel] [RFC v1 3/3] intel_iommu: add scalable-mode option to make scalable mode work

2019-02-15 Thread Jason Wang
On 2019/2/15 下午1:39, Peter Xu wrote: On Fri, Feb 15, 2019 at 01:22:34PM +0800, Yi Sun wrote: [...] +/* TODO: read cap/ecap from host to decide which cap to be exposed. */ +if (s->scalable_mode) { +if (!s->caching_mode) { +error_report("Need to set caching-mode

Re: [Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read()

2019-02-15 Thread Wei Yang
On Thu, Feb 14, 2019 at 09:19:31PM +0100, Philippe Mathieu-Daudé wrote: >chardev::read() depends of what chardev::can_read() returns, move the >assertion to can_read(). > >Suggested-by: Paolo Bonzini >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/usb/ccid-card-passthru.c | 5 ++--- > 1 file

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Implement ARMv8.3-JSConv

2019-02-15 Thread Peter Maydell
On Thu, 14 Feb 2019 at 21:28, Richard Henderson wrote: > > On 2/14/19 1:10 PM, Richard Henderson wrote: > > On 2/14/19 5:53 AM, Peter Maydell wrote: > >> On Wed, 6 Feb 2019 at 05:29, Richard Henderson > >> wrote: > >>> > >>> Changes since v1: > >>> * Typo fixed in patch 2, which had scrogged

Re: [Qemu-devel] [PATCH 2/2] .travis.yml: Remove disable-uuid

2019-02-15 Thread Thomas Huth
On 15/02/2019 10.45, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Commit 315d3184525 turned --disable-uuid into a warning only; remove > the check from Travis. > > Signed-off-by: Dr. David Alan Gilbert > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 16/17] target/ppc: convert vadd*s and vsub*s to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/helper.h | 24 target/ppc/int_helper.c | 18 +++- target/ppc/translate/vmx-impl.inc.c | 57 + 3 files

[Qemu-devel] [PULL 0/1] qemu-openbios queue 20190215

2019-02-15 Thread Mark Cave-Ayland
-20190215 for you to fetch changes up to e9deadb1c10351213845428de7591931f790f111: Update OpenBIOS images to 3464681b built from submodule. (2019-02-15 10:07:40 +) qemu-openbios queue

Re: [Qemu-devel] [PATCH v2] hostmem: fix crash when querying empty host-nodes property via QMP

2019-02-15 Thread Stefano Garzarella
On Thu, Feb 14, 2019 at 05:57:33AM -0500, Igor Mammedov wrote: > QEMU will crashes with > qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion > `qov->root && ((>stack)->slh_first == ((void *)0))' failed > when trying to get value of not set hostmem's "host-nodes" > property,

[Qemu-devel] [PATCH 09/17] target/ppc: Pass integer to helper_mtvscr

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson We can re-use this helper elsewhere if we're not passing in an entire vector register. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/helper.h | 2 +- target/ppc/int_helper.c | 6 +++---

[Qemu-devel] [PATCH 07/17] target/ppc: convert xxspltw to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c

[Qemu-devel] [PATCH 08/17] target/ppc: convert xxsel to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 55 ++--- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c

[Qemu-devel] [PATCH 02/17] target/ppc: convert vaddu[b, h, w, d] and vsubu[b, h, w, d] over to use vector operations

2019-02-15 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- target/ppc/helper.h | 8 target/ppc/int_helper.c | 7 --- target/ppc/translate/vmx-impl.inc.c | 16 3 files changed, 8 insertions(+), 23

[Qemu-devel] [PATCH 13/17] target/ppc: Use mtvscr/mfvscr for vmstate

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson This is required before changing the representation of the register. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/machine.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/2] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-02-15 Thread Daniel P . Berrangé
A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only support the virtio-1 (aka modern) mode. Currently if the user launches QEMU, setting those devices to enable legacy mode, QEMU will silently create them in modern mode, ignoring the user's (mistaken) request. This patch

Re: [Qemu-devel] [PATCH v3] s390x/cpumodel: Set up CPU model for AQIC interception

2019-02-15 Thread Pierre Morel
On 14/02/2019 13:14, Pierre Morel wrote: A new CPU model facilities is introduced to support AP devices interruption interception for a KVM guest. "APQI" for "AP-Queue Interruption" facility The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates whether the PQAP instruction with the

[Qemu-devel] [PATCH 05/17] target/ppc: convert VSX logical operations to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c

[Qemu-devel] [PATCH 01/17] target/ppc: convert VMX logical instructions to use vector operations

2019-02-15 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate.c | 1 + target/ppc/translate/vmx-impl.inc.c | 47 + 2 files changed, 17 insertions(+), 31 deletions(-) diff --git

Re: [Qemu-devel] [PATCH qemu v2 4/4] spapr: Support NVIDIA V100 GPU with NVLink2

2019-02-15 Thread David Gibson
On Fri, Feb 15, 2019 at 03:42:56PM +1100, Alexey Kardashevskiy wrote: > > > On 15/02/2019 14:22, David Gibson wrote: > > On Thu, Feb 14, 2019 at 04:21:44PM +1100, Alexey Kardashevskiy wrote: > >> NVIDIA V100 GPUs have on-board RAM which is mapped into the host memory > >> space and accessible as

Re: [Qemu-devel] [PATCH qemu v2 0/4] spapr_pci, vfio: NVIDIA V100 + POWER9 passthrough

2019-02-15 Thread David Gibson
On Fri, Feb 15, 2019 at 03:34:52PM +1100, Alexey Kardashevskiy wrote: > > > On 15/02/2019 14:54, David Gibson wrote: > > On Fri, Feb 15, 2019 at 02:32:14PM +1100, Alexey Kardashevskiy wrote: > >> > >> > >> On 15/02/2019 14:24, David Gibson wrote: > >>> On Fri, Feb 15, 2019 at 11:35:02AM +1100,

[Qemu-devel] [PATCH 03/17] target/ppc: convert vspltis[bhw] to use vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson --- target/ppc/helper.h | 3 --- target/ppc/int_helper.c | 15 --- target/ppc/translate/vmx-impl.inc.c | 36 3 files changed, 8 insertions(+), 46 deletions(-)

[Qemu-devel] [PATCH 04/17] target/ppc: convert vsplt[bhw] to use vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/helper.h | 3 --- target/ppc/int_helper.c | 19 --- target/ppc/translate/vmx-impl.inc.c | 46 ++--- 3 files changed, 27

[Qemu-devel] [PATCH 00/17] target/ppc: convert instructions to use TCG vector operations

2019-02-15 Thread Mark Cave-Ayland
Now that all the pre-requisite patches and bugfixes have been merged, here is the remainder of Richard's "tcg, target/ppc vector improvements" patchset that converts various PPC VMX/VSX instructions over to use TCG vector operations. Compared to the original posted patchset I've made a few minor

[Qemu-devel] [PATCH 14/17] target/ppc: Add set_vscr_sat

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson This is required before changing the representation of the register. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/int_helper.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/2] Revert "globals: Allow global properties to be optional"

2019-02-15 Thread Daniel P . Berrangé
This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa. Relying on setting properties on parents types which may not be relevant to certain sub-classes had unexpected side-effects causing bugs in device config defaults. It is preferrable to be explicit about which devices get which

[Qemu-devel] [PATCH v2 0/2] hw: provide error checking of disable-legacy/modern property usage

2019-02-15 Thread Daniel P . Berrangé
Changed in v2: - Fix properties set for v2.6 machine type compat so that it only affects the virtio devices which support both legacy and modern modes. - Revert unneccessary patch allowing optional properties in machine prop back compat Daniel P. Berrangé (2): hw: report invalid

Re: [Qemu-devel] Proper use of unnest-vars (was: [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3))

2019-02-15 Thread Paolo Bonzini
On 15/02/19 08:53, Markus Armbruster wrote: > This time, $(obj-y) is very much not blank, and... > > @qapi/ final qapi-introspect.o qapi-types-target.o qapi-types.o > qapi-visit-target.o qapi-visit.o qapi-events-target.o qapi-events.o > qapi-commands-target.o qapi-commands.o > [Trailing

Re: [Qemu-devel] [PATCH] block: skip initializer BDS on recursive aio context attachment/detachment

2019-02-15 Thread Denis Plotnikov
On 08.02.2019 14:03, Kevin Wolf wrote: > Am 24.01.2019 um 08:48 hat Denis Plotnikov geschrieben: >> When there is a Backup Block Job running and shutdown command is sent to >> a guest, the guest crushes due to assert(!bs->walking_aio_notifiers). >> >> Call stack: >> >> 0 __GI_raise >> 1

Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-15 Thread Markus Armbruster
Alex Bennée writes: > Laszlo Ersek writes: > >> On 02/14/19 16:57, Alex Bennée wrote: >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to read the initial

[Qemu-devel] [PATCH] block: don't set the same context

2019-02-15 Thread Denis Plotnikov
Adds a fast path on aio context setting preventing unnecessary context setting routine. Also, it prevents issues with cyclic walk of child bds-es appeared because of registring aio walking notifiers: Call stack: 0 __GI_raise 1 __GI_abort 2 __assert_fail_base 3 __GI___assert_fail 4

Re: [Qemu-devel] Proper use of unnest-vars

2019-02-15 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/02/19 08:53, Markus Armbruster wrote: >> This time, $(obj-y) is very much not blank, and... >> >> @qapi/ final qapi-introspect.o qapi-types-target.o qapi-types.o >> qapi-visit-target.o qapi-visit.o qapi-events-target.o qapi-events.o >> qapi-commands-target.o

[Qemu-devel] [PATCH v4] spice: set device address and device display ID in QXL interface

2019-02-15 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the

Re: [Qemu-devel] [PATCH v3] s390x/cpumodel: Set up CPU model for AQIC interception

2019-02-15 Thread Christian Borntraeger
On 15.02.2019 10:53, Pierre Morel wrote: > On 14/02/2019 13:14, Pierre Morel wrote: >> A new CPU model facilities is introduced to support AP devices >> interruption interception for a KVM guest. >> >> "APQI" for "AP-Queue Interruption" facility >> >> The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL,

[Qemu-devel] [PATCH 12/17] target/ppc: Add helper_mfvscr

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson This is required before changing the representation of the register. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/arch_dump.c | 3 ++- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 5 +

[Qemu-devel] [PATCH 10/17] target/ppc: Use helper_mtvscr for reset and gdb

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Not setting flush_to_zero from gdb_set_avr_reg was a bug. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate_init.inc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/ppc/translate_init.inc.c

[Qemu-devel] [PATCH 17/17] target/ppc: convert vmin* and vmax* to vector operations

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/helper.h | 16 target/ppc/int_helper.c | 27 --- target/ppc/translate/vmx-impl.inc.c | 32 3

Re: [Qemu-devel] [PATCH 8/9] vhost-user-test: small changes to init_hugepagefs

2019-02-15 Thread Thomas Huth
On 14/02/2019 18.35, Paolo Bonzini wrote: > After the conversion to qgraph, the equivalent of "main" will be in > a constructor and will run even if the tests are not being requested. > Therefore, it should not assert that init_hugepagefs succeeds and will > be called when creating the TestServer.

Re: [Qemu-devel] [PATCH v1] tests: Add a simple device_del test for PCI devices

2019-02-15 Thread Greg Kurz
On Thu, 14 Feb 2019 18:11:28 +0100 David Hildenbrand wrote: > The issue with testing asynchronous unplug requests it that they usually > require a running guest to handle the request. However, to test if > unplug of PCI devices works, we can apply a nice little trick on some > architectures: >

Re: [Qemu-devel] QEMU xen coverity issues

2019-02-15 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 14 February 2019 18:29 > To: QEMU Developers > Cc: Paul Durrant ; Anthony Perard > > Subject: QEMU xen coverity issues > > Hi; we've just done another Coverity run, and it's pulled up some > issues in

[Qemu-devel] [PULL v2 00/25] target-arm queue

2019-02-15 Thread Peter Maydell
at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190215 for you to fetch changes up to 0f8b09b22234460cb5b8766a25066cf6b5f06842: gdbstub: Send a reply to the vKill packet. (2019-02-15 09:56:41 +

[Qemu-devel] [PATCH 15/17] target/ppc: Split out VSCR_SAT to a vector field

2019-02-15 Thread Mark Cave-Ayland
From: Richard Henderson Change the representation of VSCR_SAT such that it is easy to set from vector code. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/cpu.h| 4 +++- target/ppc/int_helper.c | 11 --- 2 files changed, 11 insertions(+), 4

Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory()

2019-02-15 Thread Igor Mammedov
On Fri, 15 Feb 2019 15:48:43 +0100 Paolo Bonzini wrote: > On 15/02/19 12:33, Igor Mammedov wrote: > > On Thu, 14 Feb 2019 19:11:27 +0100 > > Paolo Bonzini wrote: > > > >> On 14/02/19 15:07, Igor Mammedov wrote: > >>> Also some boards (ab)use memory_region_allocate_system_memory(), calling >

[Qemu-devel] [PATCH v8 06/11] authz: add QAuthZ object as an authorization base class

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server)

[Qemu-devel] [PATCH v8 05/11] hw/usb: switch MTP to use new inotify APIs

2019-02-15 Thread Daniel P . Berrangé
The internal inotify APIs allow a lot of conditional statements to be cleared out, and provide a simpler callback for handling events. Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c| 274 ++-- hw/usb/trace-events | 2 +- 2 files changed, 111

[Qemu-devel] [PATCH v8 00/11] Add a standard authorization framework

2019-02-15 Thread Daniel P . Berrangé
An update to v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05660.html v4: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02961.html v5:

Re: [Qemu-devel] [PATCH v2 6/6] tests/device-plug: Add memory unplug request test for spapr

2019-02-15 Thread Thomas Huth
On 15/02/2019 14.30, David Hildenbrand wrote: > We can easily test this, just like PCI. > > Signed-off-by: David Hildenbrand > --- > tests/device-plug-test.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/tests/device-plug-test.c b/tests/device-plug-test.c >

[Qemu-devel] [PATCH v8 01/11] util: add helper APIs for dealing with inotify in portable manner

2019-02-15 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Wrapping it also allows introduction of a platform portability layer, so that we can add impls for non-Linux based equivalents in

Re: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to decodetree

2019-02-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213155414.22285-1-pal...@sifive.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190213155414.22285-1-pal...@sifive.com Subject: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to

Re: [Qemu-devel] [PATCH for-3.2 v3 0/3] HMP/snapshot changes - do not use ID anymore

2019-02-15 Thread Kevin Wolf
Am 07.11.2018 um 14:09 hat Daniel Henrique Barboza geschrieben: > changes in v3: > - rebased to v3.1.0-rc0 tag > - hmp-commands.hx documentation now mentions the change of semantics > starting version 3.2. > - previous version link: >

[Qemu-devel] [v4 PATCH] hw/arm/bcm2835_peripherals: add bcm283x arm timer

2019-02-15 Thread Mark
Signed-off-by: Mark --- hw/arm/bcm2835_peripherals.c | 17 ++ hw/timer/Makefile.objs | 2 + hw/timer/bcm283x_timer.c | 271 +++ include/hw/arm/bcm2835_peripherals.h | 2 + include/hw/timer/bcm283x_timer.h | 50 + 5 files

[Qemu-devel] [PATCH 10/10] target/ppc: Add support for LPCR:HEIC on POWER9

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt This controls whether the External Interrupt (0x500) can be delivered to the hypervisor or not. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- target/ppc/excp_helper.c| 5 -

[Qemu-devel] [PATCH 09/10] target/ppc: Add POWER9 external interrupt model

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Adds support for the Hypervisor directed interrupts in addition to the OS ones. Signed-off-by: Benjamin Herrenschmidt [clg: - modified the icp_realize() and xive_tctx_realize() to take into account explicitely the POWER9 interrupt model - introduced a

Re: [Qemu-devel] [PATCH v2] block: don't set the same context

2019-02-15 Thread Kevin Wolf
Am 15.02.2019 um 14:03 hat Denis Plotnikov geschrieben: > Adds a fast path on aio context setting preventing > unnecessary context setting routine. > Also, it prevents issues with cyclic walk of child > bds-es appeared because of registering aio walking > notifiers: > > Call stack: > > 0

Re: [Qemu-devel] [PATCH for-next 3/6] blkdebug: Add @iotype error option

2019-02-15 Thread Max Reitz
On 14.02.19 03:35, Eric Blake wrote: > On 12/3/18 11:52 AM, Max Reitz wrote: >> This new error option allows users of blkdebug to inject errors only on >> certain kinds of I/O operations. Users usually want to make a very >> specific operation fail, not just any; but right now they simply hope >>

[Qemu-devel] [PATCH 11/12] target/ppc: Support for POWER9 native hash

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt (Might need more patch splitting) Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target/ppc/mmu-book3s-v3.h | 45 ++ target/ppc/mmu-hash64.h| 19 +--- target/ppc/mmu-book3s-v3.c | 18

[Qemu-devel] [PATCH v4 00/17] Add authorization support to all network services

2019-02-15 Thread Daniel P . Berrangé
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html This series builds on the core authorization framework: v8:

[Qemu-devel] [PATCH v4 3/6] migration: add support for a "tls-authz" migration parameter

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The QEMU instance that runs as the server for the migration data transport (ie the target QEMU) needs to be able to configure access control so it can prevent unauthorized clients initiating an incoming migration. This adds a new 'tls-authz' migration parameter that is

[Qemu-devel] [PATCH v4 1/6] qemu-nbd: add support for authorization of TLS clients

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use the NBD server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a

Re: [Qemu-devel] [PATCH v2 3/6] tests/device-plug: Add a simple PCI unplug request test

2019-02-15 Thread Thomas Huth
On 15/02/2019 14.30, David Hildenbrand wrote: > The issue with testing asynchronous unplug requests it that they usually > require a running guest to handle the request. However, to test if > unplug of PCI devices works, we can apply a nice little trick on some > architectures: > > On system

Re: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to decodetree

2019-02-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213155414.22285-1-pal...@sifive.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190213155414.22285-1-pal...@sifive.com Subject: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to

Re: [Qemu-devel] [PATCH] s390x: upgrade status of KVM cores to "supported"

2019-02-15 Thread Cornelia Huck
On Wed, 13 Feb 2019 11:35:19 +0100 Cornelia Huck wrote: > We are actually paid to look after this. > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9a76845581b1..73ff5915638e 100644

Re: [Qemu-devel] [PATCH v2 5/6] tests/device-plug: Add CPU core unplug request test for spapr

2019-02-15 Thread Thomas Huth
On 15/02/2019 14.30, David Hildenbrand wrote: > We can easily test this, just like PCI. ... maybe add a sentence why this is only done for spapr, and not for s390x and x86 ? > Signed-off-by: David Hildenbrand > --- > tests/device-plug-test.c | 20 > 1 file changed, 20

Re: [Qemu-devel] QEMU xen coverity issues

2019-02-15 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 14 February 2019 18:29 > To: QEMU Developers > Cc: Paul Durrant ; Anthony Perard > > Subject: QEMU xen coverity issues > > Hi; we've just done another Coverity run, and it's pulled up some > issues in

[Qemu-devel] [PATCH v8 11/11] authz: delete existing ACL implementation

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ subclasses provide a

[Qemu-devel] [PATCH v8 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver

2019-02-15 Thread Daniel P . Berrangé
IN_ISDIR is not a bit that one can request when registering a watch with inotify_add_watch. Rather it is a bit that is set automatically when reading events from the kernel. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé ---

[Qemu-devel] [PATCH 01/10] target/ppc: Fix nip on power management instructions

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Those instructions currently raise an exception from within the helper. This tends to result in a bogus nip value in the env context (typically the beginning of the TB). Such a helper needs a gen_update_nip() first. This fixes it with a different approach which is

[Qemu-devel] [PATCH 07/10] target/ppc: Detect erroneous condition in interrupt delivery

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt It's very easy for the CPU specific has_work() implementation and the logic in ppc_hw_interrupt() to be subtly out of sync. This can occasionally allow a CPU to wakeup from a PM state and resume executing past the PM instruction when it should resume at the 0x100

[Qemu-devel] [PATCH 08/10] target/ppc: Add Hypervisor Virtualization Interrupt on POWER9

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt This adds support for delivering that exception Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- target/ppc/cpu.h| 5 - target/ppc/excp_helper.c| 17 -

[Qemu-devel] [PATCH 2/3] xen-block: remove redundant assignment

2019-02-15 Thread Paul Durrant
The assignment to 'p' is unnecessary as the code will either goto 'invalid' or p will get overwritten. Spotted by Coverity: CID 1398638 Reported-by: Peter Maydell Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz ---

[Qemu-devel] [PATCH 02/10] target/ppc: Don't clobber MSR:EE on PM instructions

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt When issuing a power management instruction, we set MSR:EE to force ppc_hw_interrupt() into calling powerpc_excp() to deal with the fact that on P7 and P8, the system reset caused by the wakeup needs to be generated regardless of the MSR:EE value (using LPCR only).

Re: [Qemu-devel] [PATCH for-3.2 v3 1/3] block/snapshot.c: eliminate use of ID input in snapshot operations

2019-02-15 Thread Eric Blake
On 11/7/18 7:09 AM, Daniel Henrique Barboza wrote: > At this moment, QEMU attempts to create/load/delete snapshots > by using either an ID (id_str) or a name. The problem is that the code > isn't consistent of whether the entered argument is an ID or a name, > causing unexpected behaviors. > >

[Qemu-devel] [PATCH 0/3] Coverity fixes

2019-02-15 Thread Paul Durrant
Paul Durrant (3): dataplane/xen-block: remove dead code xen-block: remove redundant assignment xen-block: report error condition from vbd_name_to_disk() hw/block/dataplane/xen-block.c | 5 + hw/block/xen-block.c | 24 2 files changed, 17

Re: [Qemu-devel] [PATCH] hw/smbios: fix offset of type 3 sku field

2019-02-15 Thread Igor Mammedov
On Fri, 15 Feb 2019 15:36:00 + Daniel P. Berrangé wrote: > The type 3 SMBIOS structure[1] ends with fields > > ... > 0x14 - contained element count > 0x15 - contained element record length > 0x16 - sku number > > The smbios_type_3 struct missed the contained element record >

Re: [Qemu-devel] [PATCH v3 03/12] block: Filtered children access functions

2019-02-15 Thread Max Reitz
On 14.02.19 03:25, Eric Blake wrote: > On 2/13/19 4:53 PM, Max Reitz wrote: >> What bs->file and bs->backing mean depends on the node. For filter >> nodes, both signify a node that will eventually receive all R/W >> accesses. For format nodes, bs->file contains metadata and data, and >>

Re: [Qemu-devel] [PATCH v2] hw/block: report when pflash backing file isn't aligned

2019-02-15 Thread Markus Armbruster
Markus Armbruster writes: > Laszlo Ersek writes: > >> On 02/15/19 13:28, Alex Bennée wrote: >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to read the

[Qemu-devel] [PATCH 05/12] target/ppc: Cleanup 64-bit MMU includes

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt To enable inlining more things, move #include of mmu-hash64.h and mmu-radix64.h to mmu-book3s-v3.h Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target/ppc/mmu-book3s-v3.h | 3 +++ hw/ppc/spapr_hcall.c | 1 -

Re: [Qemu-devel] [PATCH] commit: Replace commit_top_bs on failure after deleting the block job

2019-02-15 Thread Kevin Wolf
Am 15.02.2019 um 14:49 hat Alberto Garcia geschrieben: > If there's an error in commit_start() then the block job must be > deleted before replacing commit_top_bs, otherwise it will fail because > of lack of permissions. This happens since the permission system was > introduced in

[Qemu-devel] [PATCH v4 01/17] util: add helper APIs for dealing with inotify in portable manner

2019-02-15 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Wrapping it also allows introduction of a platform portability layer, so that we can add impls for non-Linux based equivalents in

[Qemu-devel] [PATCH 01/12] target/ppc/spapr: Set LPCR:HR when using Radix mode

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The HW relies on LPCR:HR along with the PATE to determine whether to use Radix or Hash mode. In fact it uses LPCR:HR more commonly than the PATE. For us, it's also more efficient to do so, especially since unlike the HW we do not maintain a cache of the current PATE

[Qemu-devel] [PATCH 12/12] target/ppc: Basic POWER9 bare-metal radix MMU support

2019-02-15 Thread Cédric Le Goater
From: Benjamin Herrenschmidt No guest support yet Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 81 ++-- 1 file changed, 69 insertions(+), 12 deletions(-) diff --git a/target/ppc/mmu-radix64.c

Re: [Qemu-devel] [PATCH v2] block: don't set the same context

2019-02-15 Thread Eric Blake
On 2/15/19 7:12 AM, Eric Blake wrote: > On 2/15/19 7:03 AM, Denis Plotnikov wrote: >> Adds a fast path on aio context setting preventing >> unnecessary context setting routine. >> Also, it prevents issues with cyclic walk of child >> bds-es appeared because of registering aio walking >> notifiers:

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 14, 2019 at 06:53:51PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > If the migration fails before the channel is open (e.g. a bad > > address) we end up in the cleanup with rdma->channel==NULL. > > > >

[Qemu-devel] [PATCH v4 1/9] net: Introduce announce timer

2019-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'announce timer' will be used by migration, and explicit requests for qemu to perform network announces. Based on the work by Germano Veit Michel and Vlad Yasevich Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin ---

[Qemu-devel] [PATCH] build: get rid of target-obj-y

2019-02-15 Thread Paolo Bonzini
It is possible to specify the trace/ directory already in objs-y; there is no need to have a separate unnest-vars invocation. Signed-off-by: Paolo Bonzini --- Makefile.objs | 1 - Makefile.target | 7 ++- trace/Makefile.objs | 4 ++-- 3 files changed, 4 insertions(+), 8

[Qemu-devel] [PATCH v4 2/9] migration: Add announce parameters

2019-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add migration parameters that control RARP/GARP announcement timeouts. Based on earlier patches by myself and Vladislav Yasevich Signed-off-by: Dr. David Alan Gilbert Acked-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin --- hmp.c

Re: [Qemu-devel] [PULL v2 00/25] target-arm queue

2019-02-15 Thread Peter Maydell
14-2019' into staging (2019-02-14 > 18:33:00 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190215 > > for you to fetch changes up to 0f8b09b22234460cb5b8766a25066cf6b5f06842: > >

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-15 Thread Philippe Mathieu-Daudé
On 2/14/19 7:53 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the migration fails before the channel is open (e.g. a bad > address) we end up in the cleanup with rdma->channel==NULL. > > Spotted by Coverity: CID 1398634 > Fixes: fbbaacab2758cb3f32a0 >

Re: [Qemu-devel] [PATCH v2 02/25] hw/arm: Express dependencies of the highbank machines with Kconfig

2019-02-15 Thread Thomas Huth
On 14/02/2019 21.35, Paolo Bonzini wrote: > On 14/02/19 20:17, Peter Maydell wrote: >> On Wed, 13 Feb 2019 at 08:38, Thomas Huth wrote: >>> >>> Add Kconfig dependencies for the highbank machine (and the midway >>> machine). >>> This patch is slightly based on earlier work by Ákos Kovács (i.e. >>>

Re: [Qemu-devel] [PATCH] build: get rid of target-obj-y

2019-02-15 Thread Stefan Hajnoczi
On Fri, Feb 15, 2019 at 11:49:15AM +0100, Paolo Bonzini wrote: > It is possible to specify the trace/ directory already in objs-y; > there is no need to have a separate unnest-vars invocation. > > Signed-off-by: Paolo Bonzini > --- > Makefile.objs | 1 - > Makefile.target | 7 ++-

Re: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to decodetree

2019-02-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213155414.22285-1-pal...@sifive.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190213155414.22285-1-pal...@sifive.com Subject: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to

Re: [Qemu-devel] [PATCH 05/10] xics: Drop the KVM ICP class

2019-02-15 Thread Greg Kurz
On Fri, 15 Feb 2019 13:55:53 +0100 Cédric Le Goater wrote: > On 2/15/19 12:40 PM, Greg Kurz wrote: > > The KVM ICP class isn't used anymore. Drop it. > > Isn't migration complaining ? If not, > Hm.. no, but why would migration complain ? > Reviewed-by: Cédric Le Goater > > Thanks, > >

  1   2   3   4   >