Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-18 Thread Cleber Rosa
On 2/13/19 6:54 AM, Thomas Huth wrote: > This is very convenient for people like me who store their QEMU git trees > on gitlab.com: Automatic CI pipelines are now run for each branch that is > pushed to the server - useful for some extra-testing before sending PULL- > requests for example.

Re: [Qemu-devel] [PATCH v4] ppc: add host-serial and host-model machine attributes

2019-02-18 Thread Daniel P . Berrangé
On Mon, Feb 18, 2019 at 11:43:49PM +0530, P J P wrote: > From: Prasad J Pandit > > On ppc hosts, hypervisor shares following system attributes > > - /proc/device-tree/system-id > - /proc/device-tree/model > > with a guest. This could lead to information leakage and misuse.[*] > Add machine

[Qemu-devel] [PATCH] hw/hppa/dino: mask out lower 2 bits of PCI config addr

2019-02-18 Thread Sven Schnelle
some versions of HP-UX 10.20 seems to rely on the fact that DINO strips out the lower 2 bits of the PCI configuration address. Also update the binary SeaBIOS distributed to the latest version from Helge's repository, which is required with that change. Signed-off-by: Sven Schnelle ---

Re: [Qemu-devel] [PATCH] Acceptance tests: drop usage of ":avocado: enable"

2019-02-18 Thread Caio Carrara
Hi, Cleber. On Mon, Feb 18, 2019 at 12:37:23PM -0500, Cleber Rosa wrote: > The Avocado test runner attemps to find its INSTRUMENTED (that is, > Python based tests) in a manner that is as safe as possible to the > user. Different from plain Python unittest, it won't load or > execute test code on

[Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index c493e3c4c7..93c4434bfb 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -2078,29

[Qemu-devel] [PATCH v2 0/2] s390x/vfio-ap: hot plug/unplug vfio-ap device

2019-02-18 Thread Tony Krowiak
This patch series introduces hot plug/unplug of a vfio-ap device. A vfio-ap device can be hot plugged only if: 1. The guest does not yet have a vfio-ap device (only one is allowed per guest) 2. The guest was started with the following CPU model features enabled: * ap=on * apft=on To

[Qemu-devel] [PATCH v2 2/2] s390x/vfio-ap: document hot plug/unplug of vfio-ap device

2019-02-18 Thread Tony Krowiak
Let's update the vfio-ap.txt document to include the hot plug/unplug support introduced in this patch set. Signed-off-by: Tony Krowiak --- docs/vfio-ap.txt | 58 +++- 1 file changed, 53 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v6 11/18] hw/arm/virt: Add memory hotplug framework

2019-02-18 Thread Auger Eric
Hi David, On 2/14/19 6:15 PM, David Hildenbrand wrote: > On 05.02.19 18:32, Eric Auger wrote: >> This patch adds the the memory hot-plug/hot-unplug infrastructure >> in machvirt. It is still not enabled as no device memory is allocated. >> >> Signed-off-by: Eric Auger >> Signed-off-by: Shameer

Re: [Qemu-devel] [RFC PATCH 0/2] bitmaps: add inconsistent bit

2019-02-18 Thread Vladimir Sementsov-Ogievskiy
14.02.2019 2:36, John Snow wrote: > Allow QEMU to read in bitmaps that have the in-use bit set, for the > purposes of allowing users to clear or reset these bitmaps. > > This is chosen in preference to a hard error on load to minimize > impact for a non-critical error, but to force the user or

Re: [Qemu-devel] [RFC PATCH 2/2] block/dirty-bitmap: implement inconsistent bit

2019-02-18 Thread Vladimir Sementsov-Ogievskiy
14.02.2019 2:36, John Snow wrote: > Signed-off-by: John Snow > --- > block/dirty-bitmap.c | 15 + > block/qcow2-bitmap.c | 42 ++- > blockdev.c | 43 >

[Qemu-devel] [PATCH v4] ppc: add host-serial and host-model machine attributes

2019-02-18 Thread P J P
From: Prasad J Pandit On ppc hosts, hypervisor shares following system attributes - /proc/device-tree/system-id - /proc/device-tree/model with a guest. This could lead to information leakage and misuse.[*] Add machine attributes to control such system information exposure to a guest. [*]

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: add host-serial and host-model machine attributes

2019-02-18 Thread P J P
Hello Greg, Dan, +-- On Mon, 18 Feb 2019, Greg Kurz wrote --+ | >>> +spapr->host_model = NULL; | >> | >> This isn't needed since object_initialize_with_type() already takes care | >> of zeroing the instance for us. | >> | >>> +spapr->host_serial = NULL; | >> | >> Same here. |

Re: [Qemu-devel] Testing sysbus devices

2019-02-18 Thread Stephen Checkoway
On Feb 18, 2019, at 13:08, Markus Armbruster wrote: > Stephen Checkoway writes: > >> On Feb 18, 2019, at 08:43, Thomas Huth wrote: >> >>> On 18/02/2019 07.07, Stephen Checkoway wrote: Hi all, I've been working on some improvements to the pflash_cfi02 block device

Re: [Qemu-devel] [PATCH] hw/hppa/dino: mask out lower 2 bits of PCI config addr

2019-02-18 Thread Sven Schnelle
Hi List, On Mon, Feb 18, 2019 at 07:28:51PM +0100, Sven Schnelle wrote: > some versions of HP-UX 10.20 seems to rely on the fact that DINO > strips out the lower 2 bits of the PCI configuration address. > Also update the binary SeaBIOS distributed to the latest version > from Helge's repository,

Re: [Qemu-devel] Fwd: QEMU: AMD IOMMU implementation bugs

2019-02-18 Thread David Kiarie
> > > > > 3. And this might be something specific to my AMD IOMMU (1022:1437, > Family > > 16h), but the PS4 OS is checks the entire word stored in these registers > > and computes the expression as: > > config[AMDVI_CAPAB_BAR_LOW] | cap[AMDVI_CAPAB_BAR_HIGH] << 32 > > So just storing half words

Re: [Qemu-devel] [PATCH v2 0/2] s390x/vfio-ap: hot plug/unplug vfio-ap device

2019-02-18 Thread Tony Krowiak
On 2/18/19 12:59 PM, Tony Krowiak wrote: PLEASE IGNORE THIS PATCH SERIES. A v3 VERSION IS FORTHCOMING. VERSION v2 has already been posted and reviewed. This patch series introduces hot plug/unplug of a vfio-ap device. A vfio-ap device can be hot plugged only if: 1. The guest does not yet

Re: [Qemu-devel] Object instantiation vs. device realization: what to do when?

2019-02-18 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 14 Feb 2019 at 16:21, Markus Armbruster wrote: >> >> One of qdev's perennial sources of confusion is what to do at object >> instantiation time, i.e. in TypeInfo::instance_init(), and what to do at >> device realization time, i.e. in DeviceClass::realize(). > >

Re: [Qemu-devel] [PATCH 1/1] Introduce a Python module structure

2019-02-18 Thread Caio Carrara
On Wed, Feb 06, 2019 at 11:29:01AM -0500, Cleber Rosa wrote: > This is a simple move of Python code that wraps common QEMU > functionality, and are used by a number of different tests > and scripts. > > By treating that code as a real Python module, we can more easily: > * reuse code > * have a

[Qemu-devel] [PATCH v3 2/2] s390x/vfio-ap: document hot plug/unplug of vfio-ap device

2019-02-18 Thread Tony Krowiak
Let's update the vfio-ap.txt document to include the hot plug/unplug support introduced in this patch set. Signed-off-by: Tony Krowiak --- docs/vfio-ap.txt | 61 +++- 1 file changed, 56 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v3 0/2] s390x/vfio-ap: hot plug/unplug vfio-ap device

2019-02-18 Thread Tony Krowiak
This patch series introduces hot plug/unplug of a vfio-ap device. To hot plug a vfio-ap device, the QEMU device_add function may be used: (qemu) device_add vfio-ap,sysfsdev=$path-to-mdev Where $path-to-mdev is the absolute path to the mediated matrix device to which AP resources to be

[Qemu-devel] [PATCH v3 1/2] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-02-18 Thread Tony Krowiak
Introduces hot plug/unplug support for the vfio-ap device. To hot plug a vfio-ap device using the QEMU device_add command: (qemu) device_add vfio-ap,sysfsdev=$path-to-mdev Where $path-to-mdev is the absolute path to the mediated matrix device to which AP resources to be

[Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-18 Thread Andrey Shinkevich
To write one byte to disk, Python2 may use 'chr' type. In Python3, conversion to 'byte' type is required. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/242 | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/242 b/tests/qemu-iotests/242

Re: [Qemu-devel] [PATCH v14 3/3] qcow2: list of bitmaps new test 242

2019-02-18 Thread Andrey Shinkevich
On 18/02/2019 19:12, Kevin Wolf wrote: > Am 08.02.2019 um 16:06 hat Andrey Shinkevich geschrieben: >> A new test file 242 added to the qemu-iotests set. It checks >> the format of qcow2 specific information for the new added >> section that lists details of bitmaps. >> >> Signed-off-by: Andrey

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-18 Thread John Snow
OK, I think it is a bug that you cannot at least repair the image, though the cause of corruption is still unknown to me. Do you have libvirt/QEMU logs from when then VM was shut down, before it wouldn't boot properly again? -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-18 Thread Eric Blake
[adding Eduardo for some python 2-vs-3 advice] On 2/18/19 1:59 PM, Andrey Shinkevich wrote: > To write one byte to disk, Python2 may use 'chr' type. > In Python3, conversion to 'byte' type is required. > > Signed-off-by: Andrey Shinkevich > --- > tests/qemu-iotests/242 | 9 +++-- > 1 file

Re: [Qemu-devel] [PATCH 01/10] xics: Explicitely call KVM ICP methods from the common code

2019-02-18 Thread Eric Blake
On 2/17/19 5:14 PM, David Gibson wrote: In the subject line: s/Explicitely/Explicitly/ > On Fri, Feb 15, 2019 at 12:39:48PM +0100, Greg Kurz wrote: >> The pre_save(), post_load() and synchronize_state() methods of the >> ICPStateClass type are really KVM only things. Make that obvious >> by

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2019-02-18 Thread Ciro Santilli 六四事件 法轮功
Did we open a precise glibc upstream bug for this so I can go upvote it? :-) Workaround from #12 also worked for me. Tested on Buildroot with this precise setup: https://github.com/cirosantilli/linux-kernel-module- cheat/tree/e855a262fd872171156894e9045814cb0f346dab#stack-smashing- detected For

Re: [Qemu-devel] [PATCH v4 01/17] block: enhance QEMUIOVector structure

2019-02-18 Thread Eric Blake
On 2/18/19 8:09 AM, Vladimir Sementsov-Ogievskiy wrote: > Add a possibility of embedded iovec, for cases when we need only one > local iov. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/qemu/iov.h | 64 -- > 1 file changed, 62

Re: [Qemu-devel] [PATCH 03/12] nbd: Restrict connection_co reentrance

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > nbd_client_attach_aio_context() schedules connection_co in the new > AioContext and this way reenters it in any arbitrary place that has > yielded. We can restrict this a bit to the function call where the > coroutine actually sits waiting when it's idle. >

Re: [Qemu-devel] [PATCH 04/12] io: Make qio_channel_yield() interruptible

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > Similar to how qemu_co_sleep_ns() allows to be preempted by an external allows preemption from an external > coroutine entry, allow reentering qio_channel_yield() early. > > Signed-off-by: Kevin Wolf > --- > include/io/channel.h | 9 ++--- >

Re: [Qemu-devel] [RFC PATCH 2/2] block/dirty-bitmap: implement inconsistent bit

2019-02-18 Thread Eric Blake
On 2/18/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:36, John Snow wrote: >> Signed-off-by: John Snow >> --- >> block/dirty-bitmap.c | 15 + >> block/qcow2-bitmap.c | 42 ++- >> blockdev.c | 43

Re: [Qemu-devel] [PATCH 05/12] nbd: Move nbd_read_eof() to nbd/client.c

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > The only caller of nbd_read_eof() is nbd_receive_reply(), so it doesn't > have to live in the header file, but can move next to its caller. > > Also add the missing coroutine_fn to the function and its caller. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCH 08/12] block: Don't poll in bdrv_set_aio_context()

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > The explicit aio_poll() call in bdrv_set_aio_context() was added in > commit c2b6428d388 as a workaround for bdrv_drain() failing to achieve > to actually quiesce everything (specifically the NBD client code to > switch AioContext). > > Now that the NBD

Re: [Qemu-devel] [PATCH] iotests: Skip 211 on insufficient memory

2019-02-18 Thread Eric Blake
On 2/18/19 12:06 PM, Max Reitz wrote: > VDI keeps the whole bitmap in memory, and the maximum size (which is > tested here) is 2 GB. This may not be available on all machines, and it > rarely is available when running a 32 bit build. > > Fix this by making VM.run_job() return the error string if

Re: [Qemu-devel] [PATCH 02/12] target/ppci/mmu: Use LPCR:HR to chose radix vs. hash translation

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 7:47 AM, David Gibson wrote: > On Fri, Feb 15, 2019 at 06:00:19PM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> Now that LPCR:HR is set properly for SPAPR, use it for deciding >> the translation type, which also works for bare metal "ppci" -> "ppc" in patch

Re: [Qemu-devel] [PATCH v6 09/18] hw/arm/virt: Implement kvm_type function for 4.0 machine

2019-02-18 Thread Auger Eric
Hi Peter, On 2/14/19 6:29 PM, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: >> >> This patch implements the machine class kvm_type() callback. >> It returns the max IPA shift needed to implement the whole GPA >> range including the RAM and IO regions located beyond. >>

Re: [Qemu-devel] [PATCH v4 1/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-18 Thread Eric Blake
On 2/18/19 3:42 PM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part of

Re: [Qemu-devel] [RFC PATCH 2/2] block/dirty-bitmap: implement inconsistent bit

2019-02-18 Thread John Snow
On 2/18/19 3:37 PM, Eric Blake wrote: > On 2/18/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: >> 14.02.2019 2:36, John Snow wrote: >>> Signed-off-by: John Snow >>> --- >>> block/dirty-bitmap.c | 15 + >>> block/qcow2-bitmap.c | 42

<    1   2   3   4   5