Re: [Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread Richard Henderson
On 2/25/19 3:55 AM, David Hildenbrand wrote: > +uint64_t HELPER(lcbb)(uint64_t addr, uint32_t m3) > +{ > +const uint32_t block_size = 1ul << (m3 + 6); > +const uint64_t rounded_addr = ROUND_UP(addr, block_size); > +uint32_t to_load = 16; > + > +if (rounded_addr != addr) { > +

Re: [Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread David Hildenbrand
On 25.02.19 17:14, Richard Henderson wrote: > On 2/25/19 3:55 AM, David Hildenbrand wrote: >> +uint64_t HELPER(lcbb)(uint64_t addr, uint32_t m3) >> +{ >> +const uint32_t block_size = 1ul << (m3 + 6); >> +const uint64_t rounded_addr = ROUND_UP(addr, block_size); >> +uint32_t to_load =

Re: [Qemu-devel] [PATCH] Discard old bitmap directories in QCOW2 image

2019-02-25 Thread Andrey Shinkevich
PINGing Please review this simple patch. On 12/02/2019 15:35, Andrey Shinkevich wrote: > Clean QCOW2 image from bitmap obsolete directory when a new one > is allocated and stored. It slows down the image growth a little bit. > The flag QCOW2_DISCARD_ALWAYS allows a call to raw_co_pdiscard() >

[Qemu-devel] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to represent sizes

2019-02-25 Thread Murilo Opsfelder Araujo
Using IEC binary prefixes from qemu/units.h provides a more human-friendly value to size constants. Suggested-by: Eric Blake Signed-off-by: Murilo Opsfelder Araujo --- hw/ppc/pnv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index

[Qemu-devel] [PATCH v2 2/3] ppc/pnv: add INITRD_MAX_SIZE constant

2019-02-25 Thread Murilo Opsfelder Araujo
The current 0x1000 value is actually 256MiB, not 128MB as the comment suggests. Move it to a constant and fix the comment (no change in the size value). Signed-off-by: Murilo Opsfelder Araujo --- hw/ppc/pnv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c

[Qemu-devel] [RFC PATCH 1/6] qdev: Fix latent bug with compat_props and onboard devices

2019-02-25 Thread Markus Armbruster
Compatibility properties started life as a qdev property thing: we supported them only for qdev properties, and implemented them with the machinery backing command line option -global. Recent commit fa0cb34d221 put them to use (tacitly) with memory backend objects (subtypes of

[Qemu-devel] [RFC PATCH 2/6] qom: Move compat_props machinery from qdev to QOM

2019-02-25 Thread Markus Armbruster
See the previous commit for rationale. Signed-off-by: Markus Armbruster --- hw/core/qdev.c | 39 --- include/hw/qdev-core.h | 4 include/qom/object.h | 3 +++ qom/object.c | 39 +++ 4 files

[Qemu-devel] [PATCH v2 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread David Hildenbrand
Let's simplify initialization to 0. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index

[Qemu-devel] [PATCH v2 1/7] s390x/tcg: RXE has an optional M3 field

2019-02-25 Thread David Hildenbrand
Will be needed, so add it to the format description. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-format.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/insn-format.def

[Qemu-devel] [PATCH v2 4/7] s390x/tcg: Factor out vec_full_reg_offset()

2019-02-25 Thread David Hildenbrand
We'll use that a lot along with gvec helpers, to calculate the start address of a vector. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper

2019-02-25 Thread John Snow
On 2/25/19 2:01 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:06, John Snow wrote: >> "Frozen" was a good description a long time ago, but it isn't adequate now. >> Rename the frozen predicate to has_successor to make the semantics of the >> predicate more clear to outside callers. >>

Re: [Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions

2019-02-25 Thread David Hildenbrand
On 25.02.19 21:03, David Hildenbrand wrote: > Before we start with the real magic, some more cleanups and refactorings. > This series does not depend on other patches not yet in master. > > Also add a variant of "LOAD LENGTHENED" that is used along with > vector instructions in linux (HFP

Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-25 Thread Eduardo Habkost
On Fri, Feb 22, 2019 at 02:26:13PM +0300, Andrey Shinkevich wrote: > The data type for bytes in Python3 differs from the one in Python2. > Those cases should be managed separately. > > v1: > In the first version, the TypeError in Python3 was handled as the > exception. > Discussed in the e-mail

Re: [Qemu-devel] [PATCH 12/15] s390-bios: Refactor virtio to run channel programs via cio

2019-02-25 Thread Cornelia Huck
On Mon, 25 Feb 2019 08:20:04 -0500 "Jason J. Herne" wrote: > On 2/4/19 6:44 AM, Cornelia Huck wrote: > > On Tue, 29 Jan 2019 08:29:19 -0500 > > "Jason J. Herne" wrote: > > > >> Now that we have a Channel I/O library let's modify virtio boot code to > >> make use of it for running channel

[Qemu-devel] [PATCH v2 1/3] ppc/pnv: increase kernel size limit to 256MiB

2019-02-25 Thread Murilo Opsfelder Araujo
Building kernel with CONFIG_DEBUG_INFO_REDUCED can generate a ~90MB image and building with CONFIG_DEBUG_INFO can generate a ~225M one, both exceeds the current limit of 32MiB. Increasing kernel size limit to 256MiB should fit for now. Signed-off-by: Murilo Opsfelder Araujo --- hw/ppc/pnv.c |

Re: [Qemu-devel] [PATCH v2] tcg: Implement tcg_gen_shri2_i64()

2019-02-25 Thread Richard Henderson
On 2/25/19 7:42 AM, David Hildenbrand wrote: > +void tcg_gen_shri2_i64(TCGv_i64 ret, TCGv_i64 al, TCGv_i64 ah, int64_t count) Actually, I now wonder if a better name might be tcg_gen_extract2_i64 (no other change to arguments, i.e. the "len" parameter that extract has is fixed at 64). Thoughts?

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread John Snow
On 2/25/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:22, John Snow wrote: >> Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as >> persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 >> that have been marked as "in use". >> >>

[Qemu-devel] [RFC PATCH 0/6] pc: Support firmware configuration with -blockdev

2019-02-25 Thread Markus Armbruster
This is RFC mostly due to the last patch. I'm not 100% sure my approach is sane, and there's also an unresolved FIXME. Please review. Based-on: <20190218125615.18970-1-arm...@redhat.com> Markus Armbruster (6): qdev: Fix latent bug with compat_props and onboard devices qom: Move

Re: [Qemu-devel] [PATCH v3 0/8] Misc target/mips fixes and improvements

2019-02-25 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Friday, February 22, 2019 8:26 PM > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH v3 0/8] Misc target/mips fixes and improvements > > From: Aleksandar Markovic > > A collection of misc

[Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

2019-02-25 Thread Stefan Hajnoczi
Test 238 does not require the kvm accelerator. tcg and qtest work too. Use qtest since it's always built in while kvm and tcg are not. Suggested-by: Thomas Huth Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/238 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

2019-02-25 Thread Murilo Opsfelder Araujo
First patch increases kernel size limit to 256MiB to fit images generated with CONFIG_DEBUG_INFO. Second patch just fixes a misleading comment regarding initrd size limit. Third patch uses IEC prefixes to represent size constants. v1..v2: Use IEC prefixes as per Eric Blake' suggestion.

[Qemu-devel] [RFC PATCH 6/6] pc: Support firmware configuration with -blockdev

2019-02-25 Thread Markus Armbruster
The PC machines put firmware in ROM by default. To get it put into flash memory (required by OVMF), you have to use -drive if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... Why two -drive? This permits setting up one part of the flash memory read-only, and the other part

[Qemu-devel] [RFC PATCH 3/6] vl: Fix latent bug with -global and onboard devices

2019-02-25 Thread Markus Armbruster
main() registers the user's -global only after we create the machine object, i.e. too late for devices created in the machine's .instance_init(). Fortunately, we know the bug is only latent: the commit before previous fixed a bug that would've crashed any attempt to create a device in an

[Qemu-devel] [PATCH v2 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread David Hildenbrand
Use a new CC helper to calculate the CC lazily if needed. While the PoP mentions that "A 32-bit unsigned binary integer" is placed into the first operand, there is no word telling that the other 32 bits (high part) are left untouched. Maybe the other 32-bit are unpredictable. So store 64 bit for

[Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions

2019-02-25 Thread David Hildenbrand
Before we start with the real magic, some more cleanups and refactorings. This series does not depend on other patches not yet in master. Also add a variant of "LOAD LENGTHENED" that is used along with vector instructions in linux (HFP instructions that can be used without HFP ). Implement "LOAD

Re: [Qemu-devel] [PATCH v3 10/10] iotests: add busy/recording bit test to 124

2019-02-25 Thread John Snow
On 2/23/19 5:06 PM, Eric Blake wrote: > On 2/22/19 6:06 PM, John Snow wrote: >> This adds a simple test that ensures the busy bit works for push backups, >> as well as doubling as bonus test for incremental backups that get >> interrupted >> by EIO errors. > > This makes 124 longer to run,

Re: [Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread Richard Henderson
On 2/25/19 8:17 AM, David Hildenbrand wrote: > On 25.02.19 17:14, Richard Henderson wrote: >> I don't understand all of this "blocksize" business, when they are all powers >> of two, and the maximum value returned is 16. >> >> As far as I can see, the result is obtained by -(addr | -16) regardless

[Qemu-devel] [PATCH v2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-02-25 Thread Maxiwell S. Garcia
This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest to collect host information. It is disabled by default to avoid unwanted information leakage. To enable it, use: ‘-M pseries,vpd-export=on’ Only the SE and TM keywords are returned at the moment: SE for Machine or Cabinet

[Qemu-devel] [RFC PATCH 5/6] vl: Create block backends before setting machine properties

2019-02-25 Thread Markus Armbruster
qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later, we rejigger the order. Block devices get

Re: [Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread David Hildenbrand
On 25.02.19 17:40, Richard Henderson wrote: > On 2/25/19 8:17 AM, David Hildenbrand wrote: >> On 25.02.19 17:14, Richard Henderson wrote: >>> I don't understand all of this "blocksize" business, when they are all >>> powers >>> of two, and the maximum value returned is 16. >>> >>> As far as I can

[Qemu-devel] [PATCH v2 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()

2019-02-25 Thread David Hildenbrand
Also properly wrap in 24bit mode. While at it, convert the comment (and drop the comment about fundamental TCG optimizations). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 41 +--- 1 file changed, 26

[Qemu-devel] [PATCH v2 6/7] s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP

2019-02-25 Thread David Hildenbrand
Nice trick to load a 32 bit value into vector element 0 (32 bit element size) from memory, zeroing out element1. The short HFP to long HFP conversion really only is a shift. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++

Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

2019-02-25 Thread Stefan Hajnoczi
On Thu, Feb 21, 2019 at 11:24:12AM +0100, Thomas Huth wrote: > On 21/02/2019 11.11, Stefan Hajnoczi wrote: > > Test 238 does not require the kvm accelerator. TCG works fine. > > > > Use the default accelerator instead of requiring kvm. > > > > Suggested-by: Thomas Huth > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/3] target/mips: Add emulation of three MMI instructions

2019-02-25 Thread Aleksandar Rikalo
> From: Mateja Marjanovic > Subject: [PATCH 0/3] target/mips: Add emulation of three MMI instructions > > From: Mateja Marjanovic > > This series adds emulation of PCPYH, PCPYLD, and PCPYUD MMI > instructions. > > Mateja Marjanovic (3): > target/mips: Add emulation of MMI instruction PCPYH >

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-25 Thread Stefan Hajnoczi
On Mon, Feb 25, 2019 at 09:50:26AM +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > QMP clients can usually detect the presence of features via schema > > introspection. There are rare features that do not involve schema > > changes and are therefore impossible to detect with

Re: [Qemu-devel] [PULL 0/9] various Travis and Docker fixes, add gitlab CI

2019-02-25 Thread Peter Maydell
On Fri, 22 Feb 2019 at 09:54, Alex Bennée wrote: > > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-02-21 13:09:33 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests

2019-02-25 Thread Peter Maydell
On Mon, 25 Feb 2019 at 16:23, Philippe Mathieu-Daudé wrote: > > On 2/24/19 5:41 PM, Michael S. Tsirkin wrote: > > On Sun, Feb 24, 2019 at 10:21:52AM +, Peter Maydell wrote: > >> In general I prefer it if you just re-send the cover-letter > >> email as a v2 rather than informally asking for a

[Qemu-devel] [RFC PATCH 4/6] sysbus: Fix latent bug with onboard devices

2019-02-25 Thread Markus Armbruster
The first call of sysbus_get_default() creates the main system bus and stores it in QOM as "/machine/unattached/sysbus". This must not happen before main() creates "/machine", or else container_get() would "helpfully" create it as "container" object, and the real creation of "/machine" would

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

2019-02-25 Thread Murilo Opsfelder Araujo
On Mon, Feb 25, 2019 at 07:58:06PM +0100, Cédric Le Goater wrote: > On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote: > > First patch increases kernel size limit to 256MiB to fit images generated > > with > > CONFIG_DEBUG_INFO. > > > > Second patch just fixes a misleading comment regarding

Re: [Qemu-devel] [PATCH v2] tcg: Implement tcg_gen_shri2_i64()

2019-02-25 Thread David Hildenbrand
On 25.02.19 17:34, Richard Henderson wrote: > On 2/25/19 7:42 AM, David Hildenbrand wrote: >> +void tcg_gen_shri2_i64(TCGv_i64 ret, TCGv_i64 al, TCGv_i64 ah, int64_t >> count) > > Actually, I now wonder if a better name might be tcg_gen_extract2_i64 > (no other change to arguments, i.e. the

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
21.02.2019 18:26, Andrey Shinkevich wrote: > The block-stream job needs to own the base node as the limiter > of the copy-on-read operation. So, the base node is included in > the job node list (block_job_add_bdrv). > Also, the block-stream job would not allow the base node to go > away due to the

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-25 Thread Andrew Randrianasulu
В сообщении от Monday 25 February 2019 19:19:01 Philippe Mathieu-Daudc3a9 написал(а): > Hi Andrew, > > On 2/23/19 1:35 AM, Andrew Randrianasulu wrote: > > Hello! > > > > I just pulled latest git > > [...] > > > and default build with simple ./configure on slackware 14.2 x86-64 box > > failed like

Re: [Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

2019-02-25 Thread Cédric Le Goater
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote: > First patch increases kernel size limit to 256MiB to fit images generated with > CONFIG_DEBUG_INFO. > > Second patch just fixes a misleading comment regarding initrd size limit. > > Third patch uses IEC prefixes to represent size constants.

[Qemu-devel] [PULL 00/40] target/xtensa queue

2019-02-25 Thread Max Filippov
at: git://github.com/OSLL/qemu-xtensa.git tags/20190225-xtensa for you to fetch changes up to 116f9089402081231ebc6d0012e4e029f21f63af: tests/tcg/xtensa: add FPU2000 coprocessor tests (2019-02-18 22:09:10 -0800) target/xtensa

Re: [Qemu-devel] [RFC v2 07/38] queue: add QTAILQ_REMOVE_SEVERAL

2019-02-25 Thread Alex Bennée
Emilio G. Cota writes: > This is faster than removing elements one by one. > > Will gain a user soon. > > Signed-off-by: Emilio G. Cota > --- > include/qemu/queue.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/qemu/queue.h b/include/qemu/queue.h > index

Re: [Qemu-devel] [PATCH v2] tcg: Implement tcg_gen_shri2_i64()

2019-02-25 Thread Richard Henderson
On 2/25/19 8:36 AM, David Hildenbrand wrote: > On 25.02.19 17:34, Richard Henderson wrote: >> On 2/25/19 7:42 AM, David Hildenbrand wrote: >>> +void tcg_gen_shri2_i64(TCGv_i64 ret, TCGv_i64 al, TCGv_i64 ah, int64_t >>> count) >> >> Actually, I now wonder if a better name might be

Re: [Qemu-devel] [PATCH] xen-block: stop leaking memory in xen_block_drive_create()

2019-02-25 Thread Anthony PERARD
On Tue, Feb 19, 2019 at 04:36:28PM +, Paul Durrant wrote: > > The locally allocated QDict-s need to be freed. ('file_layer' will be > > freed implicitly since it is added as an object to 'driver_layer'). > > > > Spotted by Coverity: CID 1398649 > > > > While in the neighbourhood free

Re: [Qemu-devel] [PATCH] hw/nvram/fw_cfg: Move boot_splash_filedata variables into fw_cfg.c

2019-02-25 Thread Laszlo Ersek
Hi Thomas, On 02/25/19 17:14, Thomas Huth wrote: > The global boot_splash_filedata and boot_splash_filedata_size variables > are only used in fw_cfg.c. So there is really no need that these need > to be global and reside in vl.c. Move them to fw_cfg.c instead. > > Signed-off-by: Thomas Huth >

Re: [Qemu-devel] [PATCH v2 1/3] ppc/pnv: increase kernel size limit to 256MiB

2019-02-25 Thread Cédric Le Goater
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote: > Building kernel with CONFIG_DEBUG_INFO_REDUCED can generate a ~90MB image and > building with CONFIG_DEBUG_INFO can generate a ~225M one, both exceeds the > current limit of 32MiB. > > Increasing kernel size limit to 256MiB should fit for now.

Re: [Qemu-devel] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to represent sizes

2019-02-25 Thread Cédric Le Goater
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote: > Using IEC binary prefixes from qemu/units.h provides a more human-friendly > value > to size constants. > > Suggested-by: Eric Blake > Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: Cédric Le Goater Thanks, C. > --- >

Re: [Qemu-devel] [PATCH v2 2/3] ppc/pnv: add INITRD_MAX_SIZE constant

2019-02-25 Thread Cédric Le Goater
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote: > The current 0x1000 value is actually 256MiB, not 128MB as the comment > suggests. Move it to a constant and fix the comment (no change in the size > value). > > Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: Cédric Le

[Qemu-devel] [PATCH v3 1/2] block/ssh: Implement .bdrv_refresh_filename()

2019-02-25 Thread Max Reitz
This requires some changes to keep iotests 104 and 207 working. qemu-img info in 104 will now return a filename including the user name and the port, which need to be filtered by adjusting REMOTE_TEST_DIR in common.rc. This additional information has to be marked optional, however (which is

[Qemu-devel] [PATCH v3 0/2] block/ssh: Implement .bdrv_refresh_filename()

2019-02-25 Thread Max Reitz
This series implements .bdrv_refresh_filename() for the ssh block driver, along with an appropriate .bdrv_dirname() so we don't chop off query strings for backing files with relative filenames. v3: - Keep iotests 104 and 207 working Max Reitz (2): block/ssh: Implement

Re: [Qemu-devel] [PATCH v2 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread Richard Henderson
On 2/25/19 12:03 PM, David Hildenbrand wrote: > Use a new CC helper to calculate the CC lazily if needed. While the > PoP mentions that "A 32-bit unsigned binary integer" is placed into the > first operand, there is no word telling that the other 32 bits (high > part) are left untouched. Maybe the

Re: [Qemu-devel] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls

2019-02-25 Thread John Snow
On 2/25/19 7:03 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:06, John Snow wrote: >> These mean the same thing now. Unify them and rename the merged call >> bdrv_dirty_bitmap_busy to indicate semantically what we are describing, >> as well as help disambiguate from the various _locked

Re: [Qemu-devel] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function

2019-02-25 Thread John Snow
On 2/25/19 9:59 AM, Vladimir Sementsov-Ogievskiy wrote: > 25.02.2019 16:37, Vladimir Sementsov-Ogievskiy wrote: >> 23.02.2019 3:22, John Snow wrote: >>> Instead of checking against busy, inconsistent, or read only directly, >>> use a check function with permissions bits that let us streamline

Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

2019-02-25 Thread Thomas Huth
On 25/02/2019 17.18, Stefan Hajnoczi wrote: > Test 238 does not require the kvm accelerator. tcg and qtest work too. > > Use qtest since it's always built in while kvm and tcg are not. > > Suggested-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/238 | 2 +- > 1

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-25 Thread Stefan Hajnoczi
On Mon, Feb 25, 2019 at 10:28:46AM +0100, Peter Krempa wrote: > On Mon, Feb 25, 2019 at 09:50:26 +0100, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > QMP clients can usually detect the presence of features via schema > > > introspection. There are rare features that do not

Re: [Qemu-devel] [RFC v2 07/38] queue: add QTAILQ_REMOVE_SEVERAL

2019-02-25 Thread Emilio G. Cota
On Mon, Feb 25, 2019 at 16:22:52 +, Alex Bennée wrote: > Emilio G. Cota writes: > > +/* remove @left, @right and all elements in between from @head */ > > +#define QTAILQ_REMOVE_SEVERAL(head, left, right, field) do {\ > > +if (((right)->field.tqe_next) != NULL) \

[Qemu-devel] [PATCH v3 2/2] block/ssh: Implement .bdrv_dirname()

2019-02-25 Thread Max Reitz
ssh_bdrv_dirname() is basically the generic bdrv_dirname(), except it takes care not to silently chop off any query string (i.e., host_key_check). Signed-off-by: Max Reitz Tested-by: Richard W.M. Jones --- block/ssh.c | 21 + 1 file changed, 21 insertions(+) diff --git

[Qemu-devel] [PATCH v2 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread David Hildenbrand
We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 ... Simple rename of variables. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-25 Thread liang yan
Confirmed the fix, thanks for the help. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815143 Title: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4

Re: [Qemu-devel] [PATCH 1/3] target/mips: Add emulation of MMI instruction PCPYH

2019-02-25 Thread Richard Henderson
On 2/25/19 8:10 AM, Mateja Marjanovic wrote: > +tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); tcg_gen_ext16u_i64. > +tcg_gen_movi_i64(t1, 0); > +tcg_gen_or_i64(t1, t0, t1); > +tcg_gen_shli_i64(t0, t0, 16); > +tcg_gen_or_i64(t1, t0, t1); > +

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-02-25 Thread Murilo Opsfelder Araujo
Hi, Maxiwell. On Mon, Feb 25, 2019 at 01:23:25PM -0300, Maxiwell S. Garcia wrote: > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries > guest to collect host information. It is disabled by default to > avoid unwanted information leakage. To enable it, use: > ‘-M

[Qemu-devel] [QEMU-PPC] [PATCH 2/4] target/ppc: Implement large decrementer support for TCG

2019-02-25 Thread Suraj Jitindar Singh
Prior to POWER9 the decrementer was a 32-bit register which decremented with each tick of the timebase. From POWER9 onwards the decrementer can be set to operate in a mode called large decrementer where it acts as a n-bit decrementing register which is visible as a 64-bit register, that is the

[Qemu-devel] [QEMU-PPC] [PATCH 3/4] target/ppc: Implement large decrementer support for KVM

2019-02-25 Thread Suraj Jitindar Singh
Implement support to allow KVM guests to take advantage of the large decrementer introduced on POWER9 cpus. To determine if the host can support the requested large decrementer size, we check it matches that specified in the ibm,dec-bits device-tree property. We also need to enable it in KVM by

Re: [Qemu-devel] [PATCH v5 04/14] audio: -audiodev command line option basic implementation

2019-02-25 Thread Zoltán Kővágó
On 2019-02-20 22:37, Kővágó, Zoltán wrote: [...] > diff --git a/audio/audio.c b/audio/audio.c > index ce8e6ea8c2..8ad8cbe559 100644 > --- a/audio/audio.c > +++ b/audio/audio.c [...] > @@ -2129,3 +1866,170 @@ void AUD_set_volume_in (SWVoiceIn *sw, int mute, > uint8_t lvol, uint8_t rvol) >

Re: [Qemu-devel] [PATCH v2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-02-25 Thread David Gibson
On Mon, Feb 25, 2019 at 01:23:25PM -0300, Maxiwell S. Garcia wrote: > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries > guest to collect host information. It is disabled by default to > avoid unwanted information leakage. To enable it, use: > ‘-M pseries,vpd-export=on’ > > Only

Re: [Qemu-devel] [PATCH v2 03/13] spapr/xive: activate KVM support

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:12PM +0100, Cédric Le Goater wrote: > All is in place for KVM now. State synchronization and migration will > come next. As with the kernel side capability, this should be moved later in the series to avoid breaking bisections. > > Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH v2 03/13] spapr/xive: activate KVM support

2019-02-25 Thread David Gibson
On Tue, Feb 26, 2019 at 10:49:27AM +1100, David Gibson wrote: > On Fri, Feb 22, 2019 at 02:13:12PM +0100, Cédric Le Goater wrote: > > All is in place for KVM now. State synchronization and migration will > > come next. > > As with the kernel side capability, this should be moved later in the >

Re: [Qemu-devel] [PATCH 3/3] target/mips: Add emulation of MMI instruction PCPYUD

2019-02-25 Thread Richard Henderson
On 2/25/19 8:10 AM, Mateja Marjanovic wrote: > +if (rd == 0) { > +/* nop */ > +} else if ((rt == 0) && (rs == 0)) { > +tcg_gen_movi_i64(cpu_gpr[rt], 0); > +tcg_gen_movi_i64(cpu_mmr[rt], 0); > +} else if (rt == 0) { > +tcg_gen_movi_i64(cpu_mmr[rd], 0); >

[Qemu-devel] [QEMU-PPC] [PATCH 1/4] target/ppc/spapr: Add SPAPR_CAP_LARGE_DECREMENTER

2019-02-25 Thread Suraj Jitindar Singh
Add spapr_cap SPAPR_CAP_LARGE_DECREMENTER to be used to control the availability and size of the large decrementer made available to the guest. Signed-off-by: Suraj Jitindar Singh --- hw/ppc/spapr.c | 2 ++ hw/ppc/spapr_caps.c| 45 +

[Qemu-devel] [QEMU-PPC] [PATCH 4/4] target/ppc/spapr: Enable the large decrementer by default on POWER9

2019-02-25 Thread Suraj Jitindar Singh
Enable the large decrementer by default on POWER9 cpu models. The default value applied is that provided in the cpu class. Signed-off-by: Suraj Jitindar Singh --- hw/ppc/spapr_caps.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index

Re: [Qemu-devel] [PATCH v2 04/13] spapr/xive: add state synchronization with KVM

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:13PM +0100, Cédric Le Goater wrote: > This extends the KVM XIVE device backend with 'synchronize_state' > methods used to retrieve the state from KVM. The HW state of the > sources, the KVM device and the thread interrupt contexts are > collected for the monitor usage

Re: [Qemu-devel] [PATCH v2 05/13] spapr/xive: introduce a VM state change handler

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:14PM +0100, Cédric Le Goater wrote: > This handler is in charge of stabilizing the flow of event notifications > in the XIVE controller before migrating a guest. This is a requirement > before transferring the guest EQ pages to a destination. > > When the VM is

Re: [Qemu-devel] [PATCH v2 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread David Hildenbrand
On 25.02.19 21:03, David Hildenbrand wrote: > We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 > ... Simple rename of variables. > > Reviewed-by: Thomas Huth > Reviewed-by: Richard Henderson > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 11

Re: [Qemu-devel] x86 segment limits enforcement with TCG

2019-02-25 Thread Stephen Checkoway
FWIW, I figured out an approach to this. Essentially, I'm reusing the function which computes linear addresses to enforce not only segment limits (in everything but long mode), but also read/write access (in protected mode). Unfortunately, that meant every call to the linear address computation

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-25 Thread Mark Cave-Ayland
On 19/02/2019 18:25, Emilio G. Cota wrote: > On Tue, Feb 19, 2019 at 14:22:37 +, Alex Bennée wrote: >> Emilio, >> >> Any chance you could run it through your benchmark suite? > > Something isn't quite right. For instance, gcc in SPEC doesn't > complete; it fails after 2s with some errors

Re: [Qemu-devel] [PATCH v2 02/13] spapr/xive: add hcall support when under KVM

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:11PM +0100, Cédric Le Goater wrote: > XIVE hcalls are all redirected to QEMU as none are on a fast path. > When necessary, QEMU invokes KVM through specific ioctls to perform > host operations. QEMU should have done the necessary checks before > calling KVM and, in

Re: [Qemu-devel] [PATCH v2 10/13] spapr: introduce routines to delete the KVM IRQ device

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:19PM +0100, Cédric Le Goater wrote: > If a new interrupt mode is chosen by CAS, the machine generates a > reset to reconfigure. At this point, the connection with the previous > KVM device needs to be closed and a new connection needs to opened > with the KVM device

Re: [Qemu-devel] [PATCH v2 07/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:16PM +0100, Cédric Le Goater wrote: > When the thread interrupt management state is retrieved from the KVM > VCPU, word2 is saved under the QEMU XIVE thread context to print out > the OS CAM line under the QEMU monitor. > > This breaks the migration of a TCG guest

[Qemu-devel] [Bug 1473451] Re: Please support the native bios format for dec alpha

2019-02-25 Thread empty
But In that case it’s impossible to emulate or even compile Windows for Dec Alpha. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1473451 Title: Please support the native bios format for dec alpha

Re: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

2019-02-25 Thread John Snow
On 2/22/19 7:06 PM, John Snow wrote: > The current internal meanings of "locked", "user_locked", > "qmp_locked", "frozen", "enabled", and "disabled" are all > a little muddled. > > Deprecate the @status field in favor of two new booleans > that carry very specific meanings. Then, rename and

Re: [Qemu-devel] [PATCH v2 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:20PM +0100, Cédric Le Goater wrote: > The activation of the KVM IRQ device depends on the interrupt mode > chosen at CAS time by the machine and some methods used at reset or by > the migration need to be protected. > > Signed-off-by: Cédric Le Goater Reviewed-by:

Re: [Qemu-devel] [PATCH 2/3] target/mips: Add emulation of MMI instruction PCPYLD

2019-02-25 Thread Richard Henderson
On 2/25/19 8:10 AM, Mateja Marjanovic wrote: > +if (rd == 0) { > +/* nop */ > +} else if ((rt == 0) && (rs == 0)) { > +tcg_gen_movi_i64(cpu_gpr[rt], 0); > +tcg_gen_movi_i64(cpu_mmr[rt], 0); > +} else if (rt == 0) { > +tcg_gen_movi_i64(cpu_gpr[rd], 0); >

Re: [Qemu-devel] [PATCH v2 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread Cornelia Huck
On Mon, 25 Feb 2019 23:28:27 +0100 David Hildenbrand wrote: > On 25.02.19 21:03, David Hildenbrand wrote: > > We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 > > ... Simple rename of variables. > > > > Reviewed-by: Thomas Huth > > Reviewed-by: Richard Henderson > >

Re: [Qemu-devel] [Qemu-block] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-25 Thread Nir Soffer
On Mon, Feb 25, 2019 at 10:36 PM Eduardo Habkost wrote: > On Fri, Feb 22, 2019 at 02:26:13PM +0300, Andrey Shinkevich wrote: > > The data type for bytes in Python3 differs from the one in Python2. > > Those cases should be managed separately. > > > > v1: > > In the first version, the TypeError

Re: [Qemu-devel] Questions about EDID

2019-02-25 Thread Programmingkid
> On Feb 25, 2019, at 10:26 AM, Gerd Hoffmann wrote: > > On Mon, Feb 25, 2019 at 09:05:30AM -0500, G 3 wrote: >> Hi Gerd, I was wondering if you have made any documentation for your EDID >> patches. If you have could you provide a link please? > > No docs. > >> Also could a feature be added

[Qemu-devel] [Bug 1816052] Re: qemu system emulator fails to start if no sound card is present on host

2019-02-25 Thread Like Xu
I would work around this issue by applying "export QEMU_AUDIO_DRV=none" to shell before we run the qemu command. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816052 Title: qemu system emulator

Re: [Qemu-devel] [PATCH v2 06/13] spapr/xive: add migration support for KVM

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:15PM +0100, Cédric Le Goater wrote: > When the VM is stopped, the VM state handler stabilizes the XIVE IC > and marks the EQ pages dirty. These are then transferred to destination > before the transfer of the device vmstates starts. > > The sPAPRXive interrupt

[Qemu-devel] [PULL 17/50] tests/device-plug: Add memory unplug request test for spapr

2019-02-25 Thread David Gibson
From: David Hildenbrand We can easily test this, just like PCI. On x86 ACPI, we need guest interaction to make it work, so it is not that easy to test. We might add tests for that later on. Reviewed-by: Michael S. Tsirkin Reviewed-by: Greg Kurz Reviewed-by: Thomas Huth Signed-off-by: David

[Qemu-devel] [PULL 39/50] spapr: populate PHB DRC entries for root DT node

2019-02-25 Thread David Gibson
From: Nathan Fontenot This add entries to the root OF node to advertise our PHBs as being DR-capable in accordance with PAPR specification. Signed-off-by: Nathan Fontenot Signed-off-by: Michael Roth Reviewed-by: David Gibson Signed-off-by: Greg Kurz Message-Id:

[Qemu-devel] [PULL 18/50] target/ppc/spapr: Set LPCR:HR when using Radix mode

2019-02-25 Thread David Gibson
From: Benjamin Herrenschmidt The HW relies on LPCR:HR along with the PATE to determine whether to use Radix or Hash mode. In fact it uses LPCR:HR more commonly than the PATE. For us, it's also more efficient to do so, especially since unlike the HW we do not maintain a cache of the current PATE

[Qemu-devel] [PULL 40/50] spapr_events: add support for phb hotplug events

2019-02-25 Thread David Gibson
From: Michael Roth Extend the existing EPOW event format we use for PCI devices to emit PHB plug/unplug events. Signed-off-by: Michael Roth Reviewed-by: David Gibson Signed-off-by: Greg Kurz Message-Id: <155059671405.1466090.535964535260503283.st...@bahia.lab.toulouse-stg.fr.ibm.com>

[Qemu-devel] [PULL 46/50] ppc/xive: xive does not have a POWER7 interrupt model

2019-02-25 Thread David Gibson
From: Cédric Le Goater Patch "target/ppc: Add POWER9 external interrupt model" should have removed the section covering PPC_FLAGS_INPUT_POWER7. Signed-off-by: Cédric Le Goater Message-Id: <20190219142530.17807-1-...@kaod.org> Signed-off-by: David Gibson --- hw/intc/xive.c | 3 --- 1 file

[Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-25 Thread Zhang Chen
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen --- migration/colo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/colo.c

[Qemu-devel] [PATCH 1/3] Migration/colo.c: Fix double close bug when occur COLO failover

2019-02-25 Thread Zhang Chen
From: Zhang Chen In migration_incoming_state_destroy(void) will check the mis->to_src_file to double close the mis->to_src_file when occur COLO failover. Signed-off-by: Zhang Chen --- migration/colo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/colo.c b/migration/colo.c

[Qemu-devel] [PATCH] fw_cfg: use __ATTR_RO_MODE to define rev sysfs

2019-02-25 Thread Wei Yang
Leverage __ATTR_RO_MODE to define rev sysfs instead of using open code to define the attribute. Signed-off-by: Wei Yang --- drivers/firmware/qemu_fw_cfg.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-25 Thread Peter Krempa
On Mon, Feb 25, 2019 at 17:40:01 +, Stefan Hajnoczi wrote: > On Mon, Feb 25, 2019 at 10:28:46AM +0100, Peter Krempa wrote: > > On Mon, Feb 25, 2019 at 09:50:26 +0100, Markus Armbruster wrote: [...] > > I'm slightly worried of misuse of the possibility to change the behavior > > on runtime.

Re: [Qemu-devel] [PATCH v5] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-25 Thread Wei Yang
On Mon, Feb 25, 2019 at 09:15:34AM +0800, Wei Yang wrote: >On Mon, Feb 25, 2019 at 09:07:08AM +0800, Wei Yang wrote: >>Currently we do device realization like below: >> >> hotplug_handler_pre_plug() >> dc->realize() >> hotplug_handler_plug() >> >>Before we do device realization and plug, we

  1   2   3   4   >