[Qemu-devel] [QEMU-PPC] [PATCH v3 2/4] target/ppc: Implement large decrementer support for TCG

2019-02-28 Thread Suraj Jitindar Singh
Prior to POWER9 the decrementer was a 32-bit register which decremented with each tick of the timebase. From POWER9 onwards the decrementer can be set to operate in a mode called large decrementer where it acts as a n-bit decrementing register which is visible as a 64-bit register, that is the

[Qemu-devel] [QEMU-PPC] [PATCH v3 1/4] target/ppc/spapr: Add SPAPR_CAP_LARGE_DECREMENTER

2019-02-28 Thread Suraj Jitindar Singh
Add spapr_cap SPAPR_CAP_LARGE_DECREMENTER to be used to control the availability of the large decrementer for a guest. Signed-off-by: Suraj Jitindar Singh --- hw/ppc/spapr.c | 2 ++ hw/ppc/spapr_caps.c| 17 + include/hw/ppc/spapr.h | 5 - 3 files changed, 23

[Qemu-devel] [PATCH] Fix coredump when using virtio-vga

2019-02-28 Thread 08005325
From: Michael Qiu When using command -device virtio-vga,virgl=on the default max_outputs is 0, this will lead coredump, (con=0x0, hw_ops=0x564452e0 , opaque=0x5754ec60) at ui/console.c:1872 (vpci_dev=0x5754ec60, errp=0x7fffdbb8) at

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup

2019-02-28 Thread Wei Yang
On Thu, Feb 28, 2019 at 02:57:07PM +0100, Igor Mammedov wrote: >On Thu, 28 Feb 2019 08:46:10 +0800 >Wei Yang wrote: > >> On Wed, Feb 27, 2019 at 06:27:49PM +0100, Igor Mammedov wrote: >> >On Wed, 27 Feb 2019 13:59:20 + >> >Wei Yang wrote: >> > >> >> On Wed, Feb 27, 2019 at 02:12:42PM

Re: [Qemu-devel] [PATCH v4 9/9] target/mips: Add support for DSPRAM

2019-02-28 Thread Philippe Mathieu-Daudé
Hi Yongbok, Aleksandar. (I believe this is the v6 of this patched, included in a v4 series). On 2/26/19 1:55 PM, Aleksandar Markovic wrote: > From: Yongbok Kim > > The optional Data Scratch Pad RAM (DSPRAM) block provides a general scratch > pad RAM > used for temporary storage of data. The

[Qemu-devel] [PATCH] hw/arm/acpi: enable SHPC native hot plug

2019-02-28 Thread Heyi Guo
After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have SHPC controller on ARM, so just enalbe SHPC native hot plug. Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Signed-off-by: Heyi Guo Signed-off-by: Heyi Guo ---

[Qemu-devel] [QEMU-PPC] [PATCH v3 3/4] target/ppc: Implement large decrementer support for KVM

2019-02-28 Thread Suraj Jitindar Singh
Implement support to allow KVM guests to take advantage of the large decrementer introduced on POWER9 cpus. To determine if the host can support the requested large decrementer size, we check it matches that specified in the ibm,dec-bits device-tree property. We also need to enable it in KVM by

[Qemu-devel] [QEMU-PPC] [PATCH 1/2] target/ppc/tcg: make spapr_caps apply cap-[cfpc/sbbc/ibs] non-fatal for tcg

2019-02-28 Thread Suraj Jitindar Singh
The spapr_caps cap-cfpc, cap-sbbc and cap-ibs are used to control the availability of certain mitigations to the guest. These haven't been implemented under TCG, it is unlikely they ever will be, and it is unclear as to whether they even need to be. As such, make failure to apply these

[Qemu-devel] [QEMU-PPC] [PATCH 0/2] Enable mitigations by default for pseries-4.0 machine type

2019-02-28 Thread Suraj Jitindar Singh
This series is based on the ppc-for-4.0 branch with my large-decrementer and count-cache-flush series applied. Suraj Jitindar Singh (2): target/ppc/tcg: make spapr_caps apply cap-[cfpc/sbbc/ibs] non-fatal for tcg target/ppc/spapr: Enable mitigations by default for pseries-4.0 machine

[Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-28 Thread Wei Yang
We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- v5: * different rules ->

Re: [Qemu-devel] [PATCH v5] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-28 Thread Wei Yang
On Thu, Feb 28, 2019 at 03:12:21PM +0100, Igor Mammedov wrote: >On Thu, 28 Feb 2019 09:13:25 +0800 >Wei Yang wrote: > >> On Wed, Feb 27, 2019 at 07:04:02PM +0100, Igor Mammedov wrote: >> >On Mon, 25 Feb 2019 09:15:34 +0800 >> >Wei Yang wrote: >> > >> >> On Mon, Feb 25, 2019 at 09:07:08AM

Re: [Qemu-devel] [PATCH] socket: fix blocking udp recvfrom.

2019-02-28 Thread llyzs
Hi, I believe this is because UDP packet can have 0 length payload. I quote some resources here: https://stackoverflow.com/questions/12505892/under-linux-can-recv-ever-return-0-on-udp https://stackoverflow.com/questions/5307031/how-to-detect-receipt-of-a-0-length-udp-datagram I also found out

[Qemu-devel] [QEMU-PPC] [PATCH 2/2] target/ppc/spapr: Enable mitigations by default for pseries-4.0 machine type

2019-02-28 Thread Suraj Jitindar Singh
There are currently 3 mitigations the availability of which is controlled by the spapr-caps mechanism, cap-cfpc, cap-sbbc, and cap-ibs. Enable these mitigations by default for the pseries-4.0 machine type. By now machine firmware should have been upgraded to allow these settings. Signed-off-by:

[Qemu-devel] [PATCH v2 09/40] target/xtensa: sort FLIX instruction opcodes

2019-02-28 Thread Max Filippov
Opcodes in different slots may read and write same resources (registers, states). In the absence of resource dependency loops it must be possible to sort opcodes to avoid interference. Record resources used by each opcode in the bundle. Build opcode dependency graph and use topological sort to

Re: [Qemu-devel] [PATCH v2 07/16] tests/tcg/xtensa: enable system tests

2019-02-28 Thread Philippe Mathieu-Daudé
On 2/28/19 9:25 PM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > > --- > v2 > - use cross CC for linker > - fix up test selection to skip linker.ld.S > --- > tests/tcg/xtensa/Makefile| 93 > tests/tcg/xtensa/Makefile.softmmu-target | 40

[Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-02-28 Thread Fabiano Rosas
For single stepping (via KVM) of a guest vcpu to work, KVM needs not only to support the SET_GUEST_DEBUG ioctl but to also recognize the KVM_GUESTDBG_SINGLESTEP bit in the control field of the kvm_guest_debug struct. This patch adds support for querying the single step capability so that QEMU can

Re: [Qemu-devel] [PATCH v2 10/16] tests/tcg: split cris tests into bare and libc directories

2019-02-28 Thread Philippe Mathieu-Daudé
Hi Alex, On 2/28/19 9:25 PM, Alex Bennée wrote: > Bare tests are standalone assembly tests that don't require linking to > any libc and hence can be built with kernel only compilers. The libc > tests need a compiler capable of building properly linked userspace > binaries. As we don't have such a

Re: [Qemu-devel] [PATCH v2 07/16] tests/tcg/xtensa: enable system tests

2019-02-28 Thread Max Filippov
On Thu, Feb 28, 2019 at 2:54 PM Philippe Mathieu-Daudé wrote: > Max: I think it should be quite easy to port your simulator to Alex's > new Makefile. I agree. > BTW is this simulator downloadable? I see the Zephyr project also uses > it, and I looked for it on https://ip.cadence.com/swdev but

Re: [Qemu-devel] [RFC v2 1/3] intel_iommu: scalable mode emulation

2019-02-28 Thread Peter Xu
On Thu, Feb 28, 2019 at 09:47:55PM +0800, Yi Sun wrote: > From: "Liu, Yi L" > > Intel(R) VT-d 3.0 spec introduces scalable mode address translation to > replace extended context mode. This patch extends current emulator to > support Scalable Mode which includes root table, context table and new

Re: [Qemu-devel] [PATCH v2] slirp: check for ioctlsocket error and 0-length udp payload.

2019-02-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190301064809.3074-1-llyzs@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190301064809.3074-1-llyzs@gmail.com Subject: [Qemu-devel] [PATCH v2] slirp: check for ioctlsocket

Re: [Qemu-devel] [PATCH v2 07/16] tests/tcg/xtensa: enable system tests

2019-02-28 Thread Alex Bennée
Max Filippov writes: > Hi Alex, > > On Thu, Feb 28, 2019 at 12:25 PM Alex Bennée wrote: > > [...] > >> diff --git a/tests/tcg/xtensa/Makefile.softmmu-target >> b/tests/tcg/xtensa/Makefile.softmmu-target >> new file mode 100644 >> index 00..1a4014506f >> --- /dev/null >> +++

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread Richard Henderson
On 2/28/19 11:05 AM, David Hildenbrand wrote: > So for writing from helpers, I can use probe_write(). What about testing > write access from TCG code? > > I could do a load, followed by a store of the loaded value. This should > work in most cases (but eventually could be observed by somebody

Re: [Qemu-devel] [RFC v2 3/3] intel_iommu: add scalable-mode option to make scalable mode work

2019-02-28 Thread Peter Xu
On Thu, Feb 28, 2019 at 09:47:57PM +0800, Yi Sun wrote: > This patch adds an option to provide flexibility for user to expose > Scalable Mode to guest. User could expose Scalable Mode to guest by > the config as below: > > "-device intel-iommu,caching-mode=on,scalable-mode=on" > > The Linux

Re: [Qemu-devel] [RFC v2 0/3] intel_iommu: support scalable mode

2019-02-28 Thread Tian, Kevin
> From: Yi Sun [mailto:yi.y@linux.intel.com] > Sent: Friday, March 1, 2019 3:13 PM > > On 19-03-01 15:07:34, Peter Xu wrote: > > On Thu, Feb 28, 2019 at 09:47:54PM +0800, Yi Sun wrote: > > > Intel vt-d rev3.0 [1] introduces a new translation mode called > > > 'scalable mode', which enables

Re: [Qemu-devel] [RFC v2 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-28 Thread Yi Sun
On 19-03-01 14:59:00, Peter Xu wrote: > On Thu, Feb 28, 2019 at 09:47:56PM +0800, Yi Sun wrote: > > From: "Liu, Yi L" > > > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > > Mode. This patch adds emulation of 256bits qi_desc. > > > > Signed-off-by: Liu, Yi L > > [Yi Sun is

Re: [Qemu-devel] [RFC v2 1/3] intel_iommu: scalable mode emulation

2019-02-28 Thread Yi Sun
On 19-03-01 14:52:19, Peter Xu wrote: > On Thu, Feb 28, 2019 at 09:47:55PM +0800, Yi Sun wrote: > > From: "Liu, Yi L" > > > > Intel(R) VT-d 3.0 spec introduces scalable mode address translation to > > replace extended context mode. This patch extends current emulator to > > support Scalable Mode

[Qemu-devel] [PATCH v2] slirp: check for ioctlsocket error and 0-length udp payload.

2019-02-28 Thread Vic Lee
Sometimes sorecvfrom() is called from slirp.c because revents == G_IO_IN, but there is 0 bytes available and recvfrom could be blocking indefinitely. This is likely due to 0-length udp payload. This also adds an error checking for ioctlsocket. Signed-off-by: Vic Lee --- slirp/socket.c | 10

Re: [Qemu-devel] [RFC v2 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-28 Thread Peter Xu
On Thu, Feb 28, 2019 at 09:47:56PM +0800, Yi Sun wrote: > From: "Liu, Yi L" > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > Mode. This patch adds emulation of 256bits qi_desc. > > Signed-off-by: Liu, Yi L > [Yi Sun is co-developer to rebase and refine the patch.] >

Re: [Qemu-devel] [RFC v2 0/3] intel_iommu: support scalable mode

2019-02-28 Thread Yi Sun
On 19-03-01 15:07:34, Peter Xu wrote: > On Thu, Feb 28, 2019 at 09:47:54PM +0800, Yi Sun wrote: > > Intel vt-d rev3.0 [1] introduces a new translation mode called > > 'scalable mode', which enables PASID-granular translations for > > first level, second level, nested and pass-through modes. The >

Re: [Qemu-devel] [PATCH v2 08/16] tests/tcg/arm: add ARMv6-M UNDEFINED 32-bit instruction test

2019-02-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 2/28/19 9:25 PM, Alex Bennée wrote: >> From: Stefan Hajnoczi >> >> Test that 32-bit instructions declared UNDEFINED in the ARMv6-M >> Reference Manual really do raise an exception. Also test that the 6 >> 32-bit instructions defined in the ARMv6-M

[Qemu-devel] [PATCH] qom: remove type_initialize() in object_new_with_type()

2019-02-28 Thread Wei Yang
Here is the abstraction of current call flow of object_new_with_type() object_initialize_with_type type_initialize object_initialize_with_type type_initialize This is not necessary to spread type_initialize in two places. Signed-off-by: Wei Yang ---

Re: [Qemu-devel] [RFC v2 3/3] intel_iommu: add scalable-mode option to make scalable mode work

2019-02-28 Thread Yi Sun
On 19-03-01 15:04:14, Peter Xu wrote: [...] > > @@ -3540,6 +3555,15 @@ static void vtd_init(IntelIOMMUState *s) > > s->cap |= VTD_CAP_CM; > > } > > > > +/* TODO: read cap/ecap from host to decide which cap to be exposed. */ > > +if (s->scalable_mode) { > > +if

Re: [Qemu-devel] [RFC v2 0/3] intel_iommu: support scalable mode

2019-02-28 Thread Peter Xu
On Thu, Feb 28, 2019 at 09:47:54PM +0800, Yi Sun wrote: > Intel vt-d rev3.0 [1] introduces a new translation mode called > 'scalable mode', which enables PASID-granular translations for > first level, second level, nested and pass-through modes. The > vt-d scalable mode is the key ingredient to

Re: [Qemu-devel] [PATCH v3 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-28 Thread Markus Armbruster
Marcel Apfelbaum writes: > Hi Yuval, > > On 2/27/19 4:06 PM, Yuval Shaia wrote: >> Allow interrogating device internals through HMP interface. >> The exposed indicators can be used for troubleshooting by developers or >> sysadmin. >> There is no need to expose these attributes to a management

Re: [Qemu-devel] [PATCH v2 3/8] decodetree: Document the usefulness of argument sets

2019-02-28 Thread Bastian Koppelmann
On 2/28/19 6:24 AM, Richard Henderson wrote: Cc: Bastian Koppelmann Signed-off-by: Richard Henderson --- docs/devel/decodetree.rst | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [Qemu-devel] [PATCH v2 2/8] decodetree: Move documentation to docs/devel/decodetree.rst

2019-02-28 Thread Bastian Koppelmann
On 2/28/19 6:24 AM, Richard Henderson wrote: One great big block comment isn't the best way to document the syntax of a language. Signed-off-by: Richard Henderson --- MAINTAINERS | 1 + docs/devel/decodetree.rst | 156 ++

Re: [Qemu-devel] [PATCH v1 12/33] s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT

2019-02-28 Thread David Hildenbrand
On 27.02.19 16:53, Richard Henderson wrote: > On 2/26/19 3:38 AM, David Hildenbrand wrote: >> To avoid an helper, we have to do the actual calculation of the element >> address (offset in cpu_env + cpu_env) manually. Factor that out into >> get_vec_element_ptr_i64(). The same logic will be reused

Re: [Qemu-devel] [PATCH v1 13/33] s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO

2019-02-28 Thread David Hildenbrand
On 27.02.19 16:56, Richard Henderson wrote: > On 2/26/19 3:38 AM, David Hildenbrand wrote: >> +zero_vec(TMP_VREG_0); >> +load_vec_element(s, TMP_VREG_0, enr, o->addr1, es); >> +gen_gvec_mov(get_field(s->fields, v1), TMP_VREG_0); > > load into TCGv_i64, zero real dest, store into real

Re: [Qemu-devel] [PATCH v3 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-28 Thread Marcel Apfelbaum
Hi Yuval, On 2/27/19 4:06 PM, Yuval Shaia wrote: Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of

Re: [Qemu-devel] regression: target/ppc: convert VSX logical operations to vector operations broke X for ppc64le guest

2019-02-28 Thread Andrew Randrianasulu
В сообщении от Thursday 28 February 2019 08:06:45 Mark Cave-Ayland написал(а): > On 26/02/2019 22:25, Andrew Randrianasulu wrote: > > (adding qemu-ppc, Richard and David - please make sure you add the relevant > maintainer on bug reports, as otherwise due to the high volume of mails to > the list

Re: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

2019-02-28 Thread Thomas Huth
On 27/02/2019 18.55, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/ > > Hi, > > This series seems to have some coding style problems. See output below for > more information: Fam, Paolo, Patchew is really going

[Qemu-devel] [PATCH v7 2/7] libvhost-user: Remove unnecessary FD flag check for event file descriptors

2019-02-28 Thread elohimes
From: Xie Yongji The vu_check_queue_msg_file() has checked the FD flag. So let's delete the redundant check after it. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- contrib/libvhost-user/libvhost-user.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v1 15/33] s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY

2019-02-28 Thread David Hildenbrand
On 27.02.19 17:08, Richard Henderson wrote: > On 2/26/19 3:38 AM, David Hildenbrand wrote: >> +void HELPER(vll)(CPUS390XState *env, void *v1, uint64_t addr, uint64_t >> bytes) >> +{ >> +S390Vector tmp = {}; >> +int i; >> + >> +bytes = MIN(bytes, 16); >> +for (i = 0; i < bytes;

[Qemu-devel] [PATCH v7 3/7] libvhost-user: Introduce vu_queue_map_desc()

2019-02-28 Thread elohimes
From: Xie Yongji Introduce vu_queue_map_desc() which should be independent with vu_queue_pop(); Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Reviewed-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 88 --- 1 file changed, 51 insertions(+), 37

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread David Hildenbrand
On 27.02.19 17:02, Richard Henderson wrote: > On 2/26/19 3:38 AM, David Hildenbrand wrote: >> Also fairly easy to implement. One issue we have is that exceptions will >> result in some vectors already being modified. At least handle it >> consistently per vector by using a temporary vector. Good

[Qemu-devel] [PATCH v7 0/7] vhost-user-blk: Add support for backend reconnecting

2019-02-28 Thread elohimes
From: Xie Yongji This patchset is aimed at supporting qemu to reconnect vhost-user-blk backend after vhost-user-blk backend crash or restart. The patch 1 introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring shared buffer between qemu and

[Qemu-devel] [PATCH v7 1/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-02-28 Thread elohimes
From: Xie Yongji This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back

[Qemu-devel] [PATCH v7 5/7] vhost-user-blk: Add support to get/set inflight buffer

2019-02-28 Thread elohimes
From: Xie Yongji This patch adds support for vhost-user-blk device to get/set inflight buffer from/to backend. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/block/vhost-user-blk.c | 28 include/hw/virtio/vhost-user-blk.h | 1 + 2 files

Re: [Qemu-devel] [RFC PATCH 3/4] spapr: Add NVDIMM device support

2019-02-28 Thread Shivaprasad G Bhat
Hi Igor, Thanks for the elaboration. Please find my response inline. On 02/21/2019 07:42 PM, Igor Mammedov wrote: On Tue, 19 Feb 2019 14:59:25 +0530 Shivaprasad G Bhat wrote: On 02/19/2019 01:41 PM, Igor Mammedov wrote: On Tue, 05 Feb 2019 23:26:27 -0600 Shivaprasad G Bhat wrote: Add

Re: [Qemu-devel] [PATCH v1 19/33] s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)

2019-02-28 Thread David Hildenbrand
On 27.02.19 17:20, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> +for (dst_idx = 0; dst_idx < NUM_VEC_ELEMENTS(es); dst_idx++) { >> +src_idx = dst_idx / 2; >> +if (!high) { >> +src_idx += NUM_VEC_ELEMENTS(es) / 2; >> +} >> +

[Qemu-devel] [PATCH v7 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-02-28 Thread elohimes
From: Xie Yongji This patch adds support for VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD message to set/get shared buffer to/from qemu. Then backend can track inflight I/O in this buffer. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- Makefile

[Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-02-28 Thread elohimes
From: Xie Yongji Since we now support the message VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart safely because it can track inflight I/O in shared memory. This patch allows qemu to reconnect the backend after connection closed. Signed-off-by: Xie

[Qemu-devel] [PATCH v7 7/7] contrib/vhost-user-blk: enable inflight I/O tracking

2019-02-28 Thread elohimes
From: Xie Yongji This patch enables inflight I/O tracking for vhost-user-blk backend so that we could restart it safely. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- contrib/vhost-user-blk/vhost-user-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-28 Thread Yuval Shaia
On Thu, Feb 28, 2019 at 10:35:38AM +0200, Marcel Apfelbaum wrote: > Hi Yuval, > > On 2/27/19 4:06 PM, Yuval Shaia wrote: > > Allow interrogating device internals through HMP interface. > > The exposed indicators can be used for troubleshooting by developers or > > sysadmin. > > There is no need

Re: [Qemu-devel] [PATCH v1 25/33] s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE

2019-02-28 Thread David Hildenbrand
On 28.02.19 00:39, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> +tmp = tcg_temp_new_i64(); >> +tcg_gen_movi_i64(tmp, data); >> +gen_gvec_dup_i64(es, get_field(s->fields, v1), tmp); >> +tcg_temp_free_i64(tmp); >> +return DISAS_NEXT; > > Reuse the

Re: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

2019-02-28 Thread Paolo Bonzini
On 28/02/19 09:37, Thomas Huth wrote: > On 27/02/2019 18.55, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/ >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more

Re: [Qemu-devel] [PATCH v1 27/33] s390x/tcg: Implement VECTOR SELECT

2019-02-28 Thread David Hildenbrand
On 28.02.19 00:42, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> +tcg_gen_not_vec(vece, t, c); >> +tcg_gen_and_vec(vece, t, t, b); > > tcg_gen_andc_vec(t, b, c); > >> +tcg_gen_not_i64(t, c); >> +tcg_gen_and_i64(t, b, t); > > Likewise. > Changed,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] virtio-balloon: Corrections to address verification

2019-02-28 Thread Greg Kurz
On Wed, 27 Feb 2019 10:20:12 +1100 David Gibson wrote: > On Mon, Feb 25, 2019 at 10:26:51AM +0100, Greg Kurz wrote: > > On Mon, 25 Feb 2019 10:37:11 +1100 > > David Gibson wrote: > > > > > On Fri, Feb 22, 2019 at 10:08:22AM +0100, Greg Kurz wrote: > > > > On Thu, 14 Feb 2019 15:39:13 +1100

Re: [Qemu-devel] [PATCH v1 29/33] s390x/tcg: Implement VECTOR STORE

2019-02-28 Thread David Hildenbrand
On 28.02.19 00:46, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> +static DisasJumpType op_vst(DisasContext *s, DisasOps *o) >> +{ >> +/* >> + * FIXME: On exceptions we must not modify any memory. >> + */ >> +store_vec_element(s, get_field(s->fields,

Re: [Qemu-devel] [PATCH v1 32/33] s390x/tcg: Implement VECTOR STORE WITH LENGTH

2019-02-28 Thread David Hildenbrand
On 28.02.19 00:49, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> Very similar to VECTOR LOAD WITH LENGTH, just the opposite direction. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/helper.h | 1 + >> target/s390x/insn-data.def | 2 ++

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-28 Thread Paolo Bonzini
On 28/02/19 08:14, Gerd Hoffmann wrote: > On Thu, Feb 28, 2019 at 08:01:53AM +0100, Thomas Huth wrote: >> On 28/02/2019 06.00, David Gibson wrote: >>> On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: The configure script checks multiple times whether it works in a git

[Qemu-devel] [PATCH] target-i386: add kvm stubs to user-mode emulators

2019-02-28 Thread Paolo Bonzini
The CPUID code will call kvm_arch_get_supported_cpuid() and, even though it is undef kvm_enabled() so it never runs for user-mode emulators, sometimes clang will not optimize it out at -O0. That could be considered a compiler bug, however at -O0 we give it a pass and just add the stubs.

[Qemu-devel] [PATCH v2] qcow2: discard bitmap when removed

2019-02-28 Thread Andrey Shinkevich
When a bitmap is removed, we can clean some space on the disk. The size of a cluster may be larger, so is the size of the bitmap that includes many clusters. Some bitmaps can be as large as tens of megabytes. The flag QCOW2_DISCARD_ALWAYS allows a call to the raw_co_pdiscard() that does the actual

Re: [Qemu-devel] [PATCH 1/2] audio: Use g_strdup_printf instead of manual building a string

2019-02-28 Thread Gerd Hoffmann
On Mon, Feb 25, 2019 at 03:43:34PM +, Frediano Ziglio wrote: > Instead of using lot of low level function and manually allocate > the temporary string in audio_process_options use more high > level GLib function. The function is not used in hot path but to > read some initial setting. Added

Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-28 Thread David Hildenbrand
On 28.02.19 01:03, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> Combine all variant in a single handler. As source and destination >> have different element sizes, we can't use gvec expansion. Expand >> manually. Also watch out for overlapping source and destination

Re: [Qemu-devel] [PULL 00/71] Block layer patches

2019-02-28 Thread Peter Maydell
On Mon, 25 Feb 2019 at 15:21, Kevin Wolf wrote: > > The following changes since commit 59a568b57848b10e8a44518a889323f12ccdd8f4: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20190222-pull-request' into staging (2019-02-25 > 12:49:07 +) > > are available in the Git

<    1   2   3   4