asavah writes:
> Public bug reported:
>
> I'm using qemu-user-arm for crosscompilation needs, usually via a wrapper.
> qemu-user-arm (4.0.0-rc0) crashes with SIGILL on at least 2 instructions:
>
> first case (sadly I don't have more data handy, can reproduce at a later time
> if needed):
>
Please ignore this incomplete patch series, it seems there's
something wrong with my email client.. :(
Sorry for this!
在 2019/3/25 上午12:51, Fei Li 写道:
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
Yeah, unfortunately we don't support cortex-a53 (or other 64-bit CPUs)
in qemu-arm. (We also don't support them as highest-EL-is-AArch32 config
in system mode.) Ideally we should fill in that gap, but in practice
most people aren't building aarch32 code for ARMv8 -- either they want
the
在 2019/2/5 上午12:34, Dr. David Alan Gilbert 写道:
* Markus Armbruster (arm...@redhat.com) wrote:
Dave, I tried to review the error paths, in particular resource cleanup,
but there's a lot going on, and I'm not feeling confident. Please have
a close look.
Fei Li writes:
From: Fei Li
Update
Hi Jason,
This series does not do the job. Test case: tap, 4 queues, 2 CPU (so
only 2 queues are enabled)
For Q0 and Q1 vhost_net_start_one succeeds,
For Q2:
vhost_net_start_one calls vhost_dev_start (the call succeeds, does not
start queue that is not enabled),
then vhost_net_start_one calls
The bug is in the same area as
https://bugs.launchpad.net/qemu/+bug/1821444 but in another branch of
'uint64_t helper_todouble(uint32_t arg=0x1)'.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Public bug reported:
Noticed on qemu-3.1.0 on GHC test suite where float32 comparisons didn't work
on NaNs.
Here is the minimal reproducer:
```c
// cat a.c
#include
#include
#include
int main() {
volatile float f1 = NAN;
volatile float f2 = NAN;
printf ("f1 (%e, %#x) >= f2 (%e,
qemu-kvm-4.0.0-0.2.rc0.fc31.x86_64
2019-03-24 10:09:11,070: cmd: qemu-system-x86_64 -no-user-config -m 4096
--machine accel=kvm -kernel /var/tmp/lorax.imgutils.5oejwg8q/isolinux/vmlinuz
-initrd /var/tmp/lmc-initrd-npcsdyha.img -drive
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Jiri Slaby
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
hw/misc/edu.c | 11 ---
1 file changed, 8 insertions(+), 3
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
return a flag to indicate if it succeeded rather than failing with
an error; make all callers check it.
The first patch modifies the qemu_thread_create() by
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Gerd Hoffmann
Signed-off-by: Fei Li
---
hw/usb/ccid-card-emulated.c | 17 -
1 file changed, 12 insertions(+), 5
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Stefan Hajnoczi
Cc: Eric Blake
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
iothread.c | 18 --
1 file
From: Fei Li
The callers of qemu_init_vcpu() already passed the **errp to handle
errors. In view of this, add a new Error parameter to qemu_init_vcpu()
and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to
propagate the error and let the further callers check it.
Besides, make
From: Fei Li
Add a local_err to hold the error, and return the corresponding
error code to replace the temporary _abort.
Cc: Markus Armbruster
Cc: David Gibson
Signed-off-by: Fei Li
Acked-by: David Gibson
Reviewed-by: Markus Armbruster
---
hw/ppc/spapr_hcall.c | 12
1 file
在 2019/2/15 下午8:35, Fei Li 写道:
在 2019/2/4 下午9:30, Markus Armbruster 写道:
Fei Li writes:
在 2019/2/1 下午9:04, Markus Armbruster 写道:
Fei Li writes:
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus
I should point that -cpu cortex-a53 is not available in qemu-arm,
I'm building arm 32 bit stuff.
qemu-arm -cpu help
Available CPUs:
arm1026
arm1136
arm1136-r2
arm1176
arm11mpcore
arm926
arm946
cortex-a15
cortex-a7
cortex-a8
cortex-a9
cortex-m0
cortex-m3
cortex-m33
We used to set backend unconditionally, this won't work for some
guests (e.g windows driver) who may not initialize all virtqueues. For
kernel backend, this will fail since it may try to validate the rings
during setting backend.
Fixing this by simply skipping the backend set when we find desc is
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote:
> This fixes when configuring with --without-default-devices:
>
> $ qemu-system-mips64el -M fulong2e --nodefaults -bios /dev/null
> qemu-system-mips64el: Unknown device 'ati-vga' for bus 'PCI'
> Aborted (core dumped)
>
> (gdb) bt
> #1
Emm, the order seems a mess.. I will resend this patch series later as v13.
So sorry for the trouble!
Have a nice day
Fei
在 2019/3/25 上午1:21, Fei Li 写道:
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
On Fri, Mar 22, 2019 at 10:12:11AM +, Dr. David Alan Gilbert wrote:
[...]
> > In general, when we reset the system, we want to bring it
> > back to exactly the state that it was in when QEMU was
> > first started. That means we need to reload all the rom blob
> > data into memory (because
On Fri, Mar 22, 2019 at 09:14:53AM +, Peter Maydell wrote:
> On Fri, 22 Mar 2019 at 07:38, P J P wrote:
> >
> > From: Prasad J Pandit
> >
> > Device tree blob(dtb) file can not be larger than 2MB in size.[*]
> > Add check to avoid loading large dtb files in load_device_tree(),
> > and
On Sat, Mar 23, 2019 at 05:26:36PM +0300, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the
On Fri, Mar 22, 2019 at 10:30:51AM +, Peter Maydell wrote:
> On Fri, 22 Mar 2019 at 10:11, P J P wrote:
> >
> > +-- On Fri, 22 Mar 2019, Peter Maydell wrote --+
> > | This document is specific to aarch64, but the part of
> > | QEMU's device tree code being modified here is
> > | architecture
On 2019/3/21 上午9:35, yuchenlin wrote:
Ping?
On 2019-03-13 14:56, yuchen...@synology.com wrote:
From: yuchenlin
Due to too early RCT0 interrput, win10x32 may hang on booting.
This problem can be reproduced by doing power cycle on win10x32 guest.
In our environment, we have 10 win10x32 and
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote:
> This is the default display device used in sun4m_hw_init():
>
> /* If no display specified, default to TCX */
>
> This fixes when configuring with --without-default-devices:
>
> $ sparc-softmmu/qemu-system-sparc --nodefaults
>
Out of curiousity, does the raspi2 machine support a PCI bus? I am
trying to boot Debian arm64 with qemu-system-aarch64, and am running
into all manner of complaints from qemu about missing devices. Is there
another machine like virt, but that offers support for boot devices?
--
You received
From: Fei Li
Update qemu_thread_create()'s callers by
- setting an error on qemu_thread_create() failure for callers that
set an error on failure;
- reporting the error and returning failure for callers that return
an error code on failure;
- reporting the error and setting some state for
On 2019/3/24 下午6:53, Yuri Benditovich wrote:
Hi Jason,
This series does not do the job. Test case: tap, 4 queues, 2 CPU (so
only 2 queues are enabled)
For Q0 and Q1 vhost_net_start_one succeeds,
For Q2:
vhost_net_start_one calls vhost_dev_start (the call succeeds, does not
start queue that is
On Mon, Mar 25, 2019 at 12:51:57AM +0800, Fei Li wrote:
> From: Fei Li
>
> The callers of qemu_init_vcpu() already passed the **errp to handle
> errors. In view of this, add a new Error parameter to qemu_init_vcpu()
> and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to
>
On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote:
> Now that I am checking out 4.0.0 rc's I see this diff is broken and
> depends on a function libfdt does not expose. The breakage is
> hidden by the fallback check in the configure script.
Ah, bother. That keeps happening,
On Fri, Mar 22, 2019 at 07:03:40PM +0100, Greg Kurz wrote:
> Signed-off-by: Greg Kurz
Applied to ppc-for-4.0.
> ---
> target/ppc/translate.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 98b37cebc2f5..aaafa3a715d8 100644
On 2019-03-25 12:26, Jason Wang wrote:
On 2019/3/21 上午9:35, yuchenlin wrote:
Ping?
On 2019-03-13 14:56, yuchen...@synology.com wrote:
From: yuchenlin
Due to too early RCT0 interrput, win10x32 may hang on booting.
This problem can be reproduced by doing power cycle on win10x32
guest.
In
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote:
> This fixes when configuring with --without-default-devices:
>
> $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null
> qemu-system-mips64: Unknown device 'piix4-usb-uhci' for bus 'PCI'
> Aborted (core dumped)
>
> (gdb) bt
> #0
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote:
> This fixes when configuring with --without-default-devices:
>
> $ qemu-system-ppc -M prep --nodefaults
> qemu-system-ppc: Machine type 'prep' is deprecated: use 40p machine type
> instead
> qemu-system-ppc: Unknown device 'isa-pcspk' for
> On Mar 22, 2019, at 05:25, Wainer dos Santos Moschetta
> wrote:
>
> Apply double quotes and period punctuation uniformly.
>
> Signed-off-by: Wainer dos Santos Moschetta
> ---
> tests/docker/Makefile.include | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On Sat, Mar 23, 2019 at 05:26:36PM +0300, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the
On Fri, Mar 22, 2019 at 07:55:57AM +0100, Markus Armbruster wrote:
> David Gibson writes:
>
> > target/ppc has a lot of old code that doesn't stick to the modern
> > style guidelines. That means we keep getting checkpatch warnings from
> > code motions in there, or from people copying the local
On Fri, Mar 22, 2019 at 07:03:35PM +0100, Greg Kurz wrote:
> Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable mitigations by
> default for pseries-4.0 machine type", some recent distros, eg. fedora29,
> fail to boot under TCG because of a kernel panic:
>
> [0.614425] Oops: Exception
On 25/03/2019 05.49, Thomas Huth wrote:
> On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote:
>> This fixes when configuring with --without-default-devices:
>>
>> $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null
>> qemu-system-mips64: Unknown device 'piix4-usb-uhci' for bus 'PCI'
>>
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Jiri Slaby
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
hw/misc/edu.c | 11 ---
1 file changed, 8 insertions(+), 3
From: Fei Li
The callers of qemu_init_vcpu() already passed the **errp to handle
errors. In view of this, add a new Error parameter to qemu_init_vcpu()
and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to
propagate the error and let the further callers check it.
Besides, make
From: Fei Li
Supplement the error handling for touch_all_pages: add an Error
parameter for it to propagate the error to its caller to do the
handling in case it fails.
Cc: Markus Armbruster
Signed-off-by: Fei Li
---
util/oslib-posix.c | 35 ++-
1 file changed,
From: Fei Li
Supplement the error handling for vnc_thread_worker_thread: add
an Error parameter for it to propagate the error to its caller to
handle in case it fails, and make it return a Boolean to indicate
whether it succeeds.
Cc: Markus Armbruster
Cc: Gerd Hoffmann
Signed-off-by: Fei Li
Le sam. 23 mars 2019 15:27, Jafar Abdi a écrit :
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code
> also
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote:
> Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable
> mitigations by
> default for pseries-4.0 machine type", some recent distros, eg.
> fedora29,
> fail to boot under TCG because of a kernel panic:
Good catch! I noticed this as well
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote:
> Even if all ISAs up to v3 indeed mention:
>
> If the "decrement and test CTR" option is specified (BO2=0), the
> instruction form is invalid.
>
> The UMs of all existing 64-bit server class processors say:
>
> If BO[2] = 0, the
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote:
> Signed-off-by: Greg Kurz
Tested-by: Suraj Jitindar Singh
> ---
> target/ppc/translate.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 98b37cebc2f5..aaafa3a715d8
From: Fei Li
qemu_thread_create() abort()s on error. Not nice. Give it a return
value and an Error ** argument, so it can return success/failure.
Considering qemu_thread_create() is quite widely used in qemu, split
this into two steps: this patch passes the _abort to
qemu_thread_create()
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Stefan Hajnoczi
Cc: Eric Blake
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
iothread.c | 18 --
1 file
From: Fei Li
Add a local_err to hold the error, and return the corresponding
error code to replace the temporary _abort.
Cc: Markus Armbruster
Cc: David Gibson
Signed-off-by: Fei Li
Acked-by: David Gibson
Reviewed-by: Markus Armbruster
---
hw/ppc/spapr_hcall.c | 12
1 file
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also
> use
> TRUE
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also
> use
> TRUE
From: Fei Li
qemu_thread_create() abort()s on error. Not nice. Give it a return
value and an Error ** argument, so it can return success/failure.
Considering qemu_thread_create() is quite widely used in qemu, split
this into two steps: this patch passes the _abort to
qemu_thread_create()
From: Fei Li
Utilize the existed errp to propagate the error instead of the
temporary _abort.
Cc: Markus Armbruster
Cc: Marc-André Lureau
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
dump.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
Categorize devices in "uncategorised devices" section
This patch is based on BiteSizedTask.
Signed-off-by: Ernest Esene
---
hw/dma/i82374.c | 2 ++
hw/i386/amd_iommu.c | 2 ++
hw/i386/intel_iommu.c | 2 ++
hw/i386/pc_piix.c | 1 +
hw/ipmi/ipmi_bmc_extern.c | 2 ++
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
return a flag to indicate if it succeeded rather than failing with
an error; make all callers check it.
The first patch modifies the qemu_thread_create() by
From: Fei Li
Set errno, do some cleanup, and return -1 to replace the temporary
_abort when failing to create sigwait_compat.
Cc: Markus Armbruster
Cc: Eric Blake
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
util/compatfd.c | 13 ++---
1 file changed, 10 insertions(+),
I filed a bug report for libfdt..
https://github.com/dgibson/dtc/issues/27
On 3/24/2019 12:03 AM, Brad Smith wrote:
Now that I am checking out 4.0.0 rc's I see this diff is broken and
depends on a function libfdt does not expose. The breakage is
hidden by the fallback check in the configure
From: Fei Li
Utilize the existed errp to propagate the error instead of the
temporary _abort.
Cc: Markus Armbruster
Cc: Marc-André Lureau
Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
---
dump.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also
> use
> TRUE
On Thu, Mar 14, 2019 at 05:55:26AM +0900, Stafford Horne wrote:
> On Tue, Mar 12, 2019 at 06:36:05PM +0100, Markus Armbruster wrote:
> > = hw/openrisc/openrisc_sim.c =
> > Jia Liu (maintainer:or1k-sim)
> > Stafford Horne (odd fixer:OpenRISC)
>
> For OpenRISC the main test I do is
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also
> use
> TRUE
From: Fei Li
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary _abort.
Cc: Markus Armbruster
Cc: Gerd Hoffmann
Cc: Christophe Fergeau
Cc: Marc-André Lureau
Signed-off-by: Fei Li
---
hw/usb/ccid-card-emulated.c | 17 -
From: Fei Li
Supplement the error handling for touch_all_pages: add an Error
parameter for it to propagate the error to its caller to do the
handling in case it fails.
Cc: Markus Armbruster
Signed-off-by: Fei Li
---
util/oslib-posix.c | 35 ++-
1 file changed,
On Fri 22 Mar 2019 04:54:59 PM CET, Alberto Garcia wrote:
>E <- D <- C <- B <- A
>
> 2) commit from C to E, then stream from C to A
>
>This fails because the commit job inserts a filter between C and B
>and the bdrv_freeze_backing_chain(bs, base) call in stream_start()
>fails.
>
>
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote:
> We use PPC_SEGMENT_64B in various places to guard code that is
> specific
> to 64-bit server processors compliant with arch 2.x. Consolidate the
> logic in a helper macro with an explicit name.
Tested-by: Suraj Jitindar Singh
>
>
Hi,
On 3/22/19 5:52 PM, Halil Pasic wrote:
On Mon, 18 Mar 2019 22:08:50 +0100
Philippe Mathieu-Daudé wrote:
Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a
écrit :
Hi Christian,
On 3/18/19 11:27 AM, Christian Borntraeger wrote:
On 16.03.19 12:09, Philippe Mathieu-Daudé wrote:
Hi Marcel,
67 matches
Mail list logo
