Re: [Qemu-devel] [PATCH v2 for-4.1] hw/arm/raspi: Diagnose requests for too much RAM

2019-03-29 Thread Philippe Mathieu-Daudé
Le ven. 29 mars 2019 10:20, Peter Maydell a écrit : > On Thu, 28 Mar 2019 at 21:29, Wainer dos Santos Moschetta > wrote: > > > > > > On 03/28/2019 12:29 PM, Peter Maydell wrote: > > > The Raspberry Pi boards have a physical memory map which does > > > not allow for more than 1GB of RAM.

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Auger Eric
Hi Shameer, [ + Laszlo, Ard, Leif ] On 3/21/19 11:47 AM, Shameer Kolothum wrote: > This is to disable/enable populating DT nodes in case > any conflict with acpi tables. The default is "off". The name of the option sounds misleading to me. Also we don't really know the scope of the disablement.

Re: [Qemu-devel] [Qemu-ppc] [PULL 4/8] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-29 Thread BALATON Zoltan
On Fri, 29 Mar 2019, David Gibson wrote: From: Greg Kurz Signed-off-by: Greg Kurz Message-Id: <155359567174.1794128.3183997593369465355.st...@bahia.lan> Signed-off-by: David Gibson --- target/ppc/translate.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-03-29 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 29 March 2019 09:32 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Pavel Hrdina writes: > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 3/28/19 3:06 PM, Eric Blake wrote: >> >> On 3/28/19 2:32 PM, Markus Armbruster wrote: >> >>> Markus Armbruster writes: >> Pavel Hrdina writes: >> >> >> > I'm

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.03.2019 21:40, Kevin Wolf wrote: > > Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on > >> loosening permissions. However file-locking

Re: [Qemu-devel] [PATCH v3 05/10] hw/arm/virt: Add ACPI support for device memory cold-plug

2019-03-29 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 29 March 2019 09:31 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 13:12, Kevin Wolf wrote: > Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 28.03.2019 21:40, Kevin Wolf wrote: >>> Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: bdrv_replace_child() calls bdrv_check_perm() with error_abort on

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 13:55, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 13:12, Kevin Wolf wrote: >> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 28.03.2019 21:40, Kevin Wolf wrote: Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >

[Qemu-devel] [PATCH 02/14] target/xtensa: don't announce exit simcall

2019-03-29 Thread Daniel P . Berrangé
From: Max Filippov Don't announce that exit simcall has been invoked: this is just noise. Reviewed-by: Richard Henderson Signed-off-by: Max Filippov --- target/xtensa/xtensa-semi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c

[Qemu-devel] [PATCH 07/14] hw/usb: avoid format truncation warning when formatting port name

2019-03-29 Thread Daniel P . Berrangé
hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’: hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\ tion=] 3339 | snprintf(port->name, sizeof(port->name), "usb2 port #%d", i+1);

[Qemu-devel] [PATCH 03/14] tests/tcg/xtensa: clean up test set

2019-03-29 Thread Daniel P . Berrangé
From: Max Filippov Drop test_fail: we know that exit simcall works. Now that it's not run automatically there's no point in keeping it. Drop test_pipeline: we're not modeling pipeline, we don't control ccount and there's no plan to do so. Enable test_boolean: it won't break on cores without

[Qemu-devel] [PATCH 04/14] linux-user: avoid string truncation warnings in uname field copying

2019-03-29 Thread Daniel P . Berrangé
In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from linux-user/uname.c:20: In function ‘strncpy’, inlined from ‘sys_uname’ at linux-user/uname.c:94:3: /usr/include/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’

[Qemu-devel] [PATCH 14/14] hw/s390x/3270-ccw: avoid taking address of fields in packed struct

2019-03-29 Thread Daniel P . Berrangé
Compiling with GCC 9 complains hw/s390x/3270-ccw.c: In function ‘emulated_ccw_3270_cb’: hw/s390x/3270-ccw.c:81:19: error: taking address of packed member of ‘struct SCHIB’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 81 | SCSW *s = >curr_status.scsw;

[Qemu-devel] [PATCH 10/14] usb-mtp: avoid warning about unaligned access to filename

2019-03-29 Thread Daniel P . Berrangé
The 'filename' field in ObjectInfo struct is declared as a zero length array of uint16_t. Accessing it is equivalent to taking the address of the field, and taking the address of fields in a packed struct causes unaligned pointer warnings: hw/usb/dev-mtp.c: In function ‘usb_mtp_write_metadata’:

[Qemu-devel] [PATCH 13/14] hw/s390x/ipl: avoid taking address of fields in packed struct

2019-03-29 Thread Daniel P . Berrangé
Compiling with GCC 9 complains hw/s390x/ipl.c: In function ‘s390_ipl_set_boot_menu’: hw/s390x/ipl.c:256:25: warning: taking address of packed member of ‘struct QemuIplParameters’ may result in an unaligned pointer value [-Waddress-of-packed-member] 256 | uint32_t *timeout =

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 10:57:55 +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > release. > > Commit hash, please. > > > This change cannot be detected through the usual mechanisms > > like schema

Re: [Qemu-devel] [PATCH v3 03/10] hw/arm/virt: Add virtual ACPI device

2019-03-29 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 28 March 2019 14:15 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

Re: [Qemu-devel] [PATCH 10/14] usb-mtp: avoid warning about unaligned access to filename

2019-03-29 Thread Thomas Huth
On 29/03/2019 12.11, Daniel P. Berrangé wrote: > The 'filename' field in ObjectInfo struct is declared as a > zero length array of uint16_t. Accessing it is equivalent > to taking the address of the field, and taking the address > of fields in a packed struct causes unaligned pointer > warnings: >

Re: [Qemu-devel] [PATCH 10/14] usb-mtp: avoid warning about unaligned access to filename

2019-03-29 Thread Peter Maydell
On Fri, 29 Mar 2019 at 11:22, Daniel P. Berrangé wrote: > > The 'filename' field in ObjectInfo struct is declared as a > zero length array of uint16_t. Accessing it is equivalent > to taking the address of the field, and taking the address > of fields in a packed struct causes unaligned pointer >

Re: [Qemu-devel] [PATCH v3] s390x/cpumodel: Set up CPU model for AQIC interception

2019-03-29 Thread Pierre Morel
On 15/02/2019 14:52, David Hildenbrand wrote: On 14.02.19 13:14, Pierre Morel wrote: A new CPU model facilities is introduced to support AP devices interruption interception for a KVM guest. This sentence is confusing. At first I thought you would introduce a new _fake_ facility. "Let's add

[Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
bdrv_replace_child() calls bdrv_check_perm() with error_abort on loosening permissions. However file-locking operations may fail even in this case, for example on NFS. And this leads to Qemu crash. Let's avoid such errors. Note, that we ignore such things anyway on permission update commit and

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.03.2019 13:12, Kevin Wolf wrote: > > Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 28.03.2019 21:40, Kevin Wolf wrote: > >>> Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >

[Qemu-devel] [PATCH 00/14] misc set of fixes for warnings under GCC 9

2019-03-29 Thread Daniel P . Berrangé
This series addresses all the warnings I see when building on Fedora 30 x86_64 with GCC 9 (gcc-9.0.1-0.10.fc30.x86_64). Ideally QEMU 4.0.0 would be warning-free with GCC 9, but depends whether maintainers like my approaches to fixing each set of warnings here ... Daniel P. Berrangé (11):

[Qemu-devel] [PATCH 01/14] target/xtensa: fix break_dependency for repeated resources

2019-03-29 Thread Daniel P . Berrangé
From: Max Filippov break_dependency incorrectly handles the case of dependency on an opcode that references the same register multiple times. E.g. the following instruction is translated incorrectly: { or a2, a3, a3 ; or a3, a2, a2 } This happens because resource indices of both dependency

[Qemu-devel] [PATCH 09/14] usb-mtp: fix string length for filename when writing metadata

2019-03-29 Thread Daniel P . Berrangé
The ObjectInfo 'length' field provides the length of the wide character string filename. This is then converted to a multi-byte character string. This may have a different byte count to the wide character string. We should use the C string length of the multi-byte string instead. Signed-off-by:

[Qemu-devel] [PATCH 05/14] linux-user: avoid string truncation warnings in elf field copying

2019-03-29 Thread Daniel P . Berrangé
In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from linux-user/elfload.c:2: In function ‘strncpy’, inlined from ‘fill_psinfo’ at linux-user/elfload.c:3208:12, inlined from ‘fill_note_info’ at linux-user/elfload.c:3390:5,

[Qemu-devel] [PATCH 06/14] sockets: avoid string truncation warnings when copying UNIX path

2019-03-29 Thread Daniel P . Berrangé
In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from util/qemu-sockets.c:18: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: warning:

[Qemu-devel] [PATCH 08/14] qxl: avoid unaligned pointer reads/writes

2019-03-29 Thread Daniel P . Berrangé
The SPICE_RING_PROD_ITEM() macro is initializing a local 'uint64_t *' variable to point to the 'el' field inside the QXLReleaseRing struct. This uint64_t field is not guaranteed aligned as the struct is packed. Code should not take the address of fields within a packed struct. Changing the

[Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-03-29 Thread Daniel P . Berrangé
The GCC 9 compiler complains about many places in s390 code that take the address of members of the 'struct SCHIB' which is marked packed: hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: hw/vfio/ccw.c:133:15: warning: taking address of packed member of ‘struct SCHIB’ may result in an

[Qemu-devel] [PATCH 12/14] hw/s390/css: avoid taking address members in packed structs

2019-03-29 Thread Daniel P . Berrangé
The GCC 9 compiler complains about many places in s390 code that take the address of members of the 'struct SCHIB' which is marked packed: hw/s390x/css.c: In function ‘sch_handle_clear_func’: hw/s390x/css.c:698:15: warning: taking address of packed member of ‘struct SCHIB’ may result in an

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 14:08, Kevin Wolf wrote: > Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.03.2019 13:12, Kevin Wolf wrote: >>> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Pavel Hrdina
On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote: > Pavel Hrdina writes: > > > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > On 3/28/19 3:06 PM, Eric Blake wrote: > >> >> On 3/28/19 2:32 PM, Markus Armbruster wrote: > >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties

2019-03-29 Thread Philippe Mathieu-Daudé
Le ven. 29 mars 2019 10:27, Alex Bennée a écrit : > > Like Xu writes: > > > Signed-off-by: Like Xu > > --- > > hw/arm/fsl-imx6.c | 5 + > > hw/arm/fsl-imx6ul.c| 5 + > > hw/arm/fsl-imx7.c | 5 + > > hw/arm/highbank.c | 1 + > > hw/arm/mcimx6ul-evk.c | 1 + > >

Re: [Qemu-devel] [PATCH 14/14] hw/s390x/3270-ccw: avoid taking address of fields in packed struct

2019-03-29 Thread David Hildenbrand
On 29.03.19 12:11, Daniel P. Berrangé wrote: > Compiling with GCC 9 complains > > hw/s390x/3270-ccw.c: In function ‘emulated_ccw_3270_cb’: > hw/s390x/3270-ccw.c:81:19: error: taking address of packed member of ‘struct > SCHIB’ may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH 13/14] hw/s390x/ipl: avoid taking address of fields in packed struct

2019-03-29 Thread David Hildenbrand
On 29.03.19 12:11, Daniel P. Berrangé wrote: > Compiling with GCC 9 complains > > hw/s390x/ipl.c: In function ‘s390_ipl_set_boot_menu’: > hw/s390x/ipl.c:256:25: warning: taking address of packed member of ‘struct > QemuIplParameters’ may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH 00/14] misc set of fixes for warnings under GCC 9

2019-03-29 Thread Peter Maydell
On Fri, 29 Mar 2019 at 11:13, Daniel P. Berrangé wrote: > > This series addresses all the warnings I see when building on Fedora 30 > x86_64 with GCC 9 (gcc-9.0.1-0.10.fc30.x86_64). > > Ideally QEMU 4.0.0 would be warning-free with GCC 9, but depends whether > maintainers like my approaches to

Re: [Qemu-devel] [PULL 0/8] ppc-for-4.0 queue 20190329

2019-03-29 Thread Peter Maydell
are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190329 > > for you to fetch changes up to 7d5489e6d15e2922e45a41e4808d03a48457a5ee: > > exec: Only count mapped memory backends for qemu_getr

Re: [Qemu-devel] [PATCH 14/14] hw/s390x/3270-ccw: avoid taking address of fields in packed struct

2019-03-29 Thread Thomas Huth
On 29/03/2019 12.11, Daniel P. Berrangé wrote: > Compiling with GCC 9 complains > > hw/s390x/3270-ccw.c: In function ‘emulated_ccw_3270_cb’: > hw/s390x/3270-ccw.c:81:19: error: taking address of packed member of ‘struct > SCHIB’ may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH 10/14] usb-mtp: avoid warning about unaligned access to filename

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 12:25:54PM +0100, Thomas Huth wrote: > On 29/03/2019 12.11, Daniel P. Berrangé wrote: > > The 'filename' field in ObjectInfo struct is declared as a > > zero length array of uint16_t. Accessing it is equivalent > > to taking the address of the field, and taking the address

Re: [Qemu-devel] [PATCH 00/14] misc set of fixes for warnings under GCC 9

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 11:50:48AM +, Peter Maydell wrote: > On Fri, 29 Mar 2019 at 11:13, Daniel P. Berrangé wrote: > > > > This series addresses all the warnings I see when building on Fedora 30 > > x86_64 with GCC 9 (gcc-9.0.1-0.10.fc30.x86_64). > > > > Ideally QEMU 4.0.0 would be

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 14:08, Kevin Wolf wrote: > Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.03.2019 13:12, Kevin Wolf wrote: >>> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat

Re: [Qemu-devel] [PATCH v3 04/10] hw/arm/virt: Add memory hotplug framework

2019-03-29 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 28 March 2019 15:38 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com;

Re: [Qemu-devel] [PULL 0/4] Net patches

2019-03-29 Thread Peter Maydell
On Fri, 29 Mar 2019 at 07:35, Jason Wang wrote: > > The following changes since commit a04d91c701251a9b32b7364ddb48029ba024cb75: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-device-tree-20190327' into staging (2019-03-28 > 12:39:43 +) > > are available in the git

<    1   2   3