[Qemu-devel] [PULL 1/7] usb-mtp: fix string length for filename when writing metadata

2019-05-02 Thread Gerd Hoffmann
From: Daniel P. Berrangé The ObjectInfo 'length' field provides the length of the wide character string filename. This is then converted to a multi-byte character string. This may have a different byte count to the wide character string. We should use the C string length of the multi-byte string

[Qemu-devel] [PULL 6/7] hw/usb/hcd-ohci: Move PCI-related code into a separate file

2019-05-02 Thread Gerd Hoffmann
From: Thomas Huth Some machines (like the pxa2xx-based ARM machines) only have a sysbus OHCI controller, but no PCI. With the new Kconfig-style build system, it will soon be possible to create QEMU binaries that only contain such PCI-less machines. However, the two OHCI controllers, for sysbus

Re: [Qemu-devel] [PATCH] qxl: check release info object

2019-05-02 Thread P J P
+-- On Thu, 25 Apr 2019, P J P wrote --+ | When releasing spice resources in release_resource() routine, | if release info object 'ext.info' is null, it leads to null | pointer dereference. Add check to avoid it. | | diff --git a/hw/display/qxl.c b/hw/display/qxl.c | index c8ce5781e0..632923add2

[Qemu-devel] [PULL 5/7] hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in ohci_die()

2019-05-02 Thread Gerd Hoffmann
From: Thomas Huth The ohci_die() function always assumes to be running with a PCI OHCI controller and calls the PCI-specific functions pci_set_word(). However, this function might also get called for the sysbus OHCI devices, so it likely fails in that case. To fix this issue, change the code

[Qemu-devel] [PULL 0/7] Usb 20190502 patches

2019-05-02 Thread Gerd Hoffmann
The following changes since commit f75d15231e56cb0f2bafe19faf1229c459a60731: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-30 17:06:57 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20190502-pull-request for you

[Qemu-devel] [Bug 1825452] Re: Pulse audio backend doesn't work in v4.0.0-rc4 release

2019-05-02 Thread Gerd Hoffmann
You can use -audiodev pa,id=whatever,server=unix:/home/ivan/.pulse_server to get things going with your configuration. Oh, and this has nothing to do with systemd: kraxel@gentoo ~ $ set | grep ^XDG XDG_CONFIG_DIRS=/etc/xdg XDG_DATA_DIRS=/usr/local/share:/usr/share

[Qemu-devel] [PULL 3/7] usb-mtp: change default to success for usb_mtp_update_object

2019-05-02 Thread Gerd Hoffmann
From: Bandan Das Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat failure) checks if lstat succeeded when updating attributes of a file. However, it also changed behavior to return an error by default. This is incorrect because for smaller file sizes, Qemu will attempt to

[Qemu-devel] [Bug 1826393] Re: QEMU 3.1.0 stuck waiting for 800ms (5 times slower) in pre-bios phase

2019-05-02 Thread Stefano Garzarella
Oh sorry, you're using the 'pc' machine, so please try this bios: https://github.com/qemu/qemu/blob/v4.0.0/pc-bios/bios.bin -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1826393 Title: QEMU 3.1.0

Re: [Qemu-devel] [PATCH v8 00/27] gdbstub: Refactor command packets handler

2019-05-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190502072641.4667-1-ari...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190502072641.4667-1-ari...@gmail.com Subject: [Qemu-devel] [PATCH v8 00/27] gdbstub:

Re: [Qemu-devel] [PATCH v2 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-05-02 Thread Laurent Vivier
On 01/05/2019 01:29, Alistair Francis wrote: > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘fill_psinfo’ at > /home/alistair/qemu/linux-user/elfload.c:3208:12, > inlined from ‘fill_note_info’ at >

[Qemu-devel] [PATCH v9 01/27] gdbstub: Add infrastructure to parse cmd packets

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..d5e0f3878a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res; }

[Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 90 ++- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d5e0f3878a..621d689868 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1418,11 +1418,6 @@ static inline int

[Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-02 Thread Jon Doron
This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets. version 9 changes: - checkpatch fixes version 8 changes: - Add new command to display the Supported qemu generic query/sets -

[Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void

[Qemu-devel] [PATCH v9 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 89f1ab6524..469aaeb875 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,21 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b42425b24c..10e3f12a68 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1634,6 +1634,27 @@ static void

[Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c47ef7dd9c..89f1ab6524 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext

[Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8dc2e1d507..daa602edc3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1710,6 +1710,30 @@ static void

[Qemu-devel] [PATCH v9 14/27] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void

[Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 21cdaf4678..36c7353a22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1588,6 +1588,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext

[Qemu-devel] [PATCH v9 17/27] gdbstub: Implement v commands with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9b0556f8be..d56d0fd235 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,106 @@ static void

[Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported

2019-05-02 Thread Jon Doron
qemu.Supported query reply back with the supported qemu query/set commands (commands are seperated with a semicolon from each other). gdb> maint packet qqemu.Supported Signed-off-by: Jon Doron --- gdbstub.c | 9 + 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstub.c

[Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void

[Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 36c7353a22..b42425b24c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1611,6 +1611,29 @@ static void

[Qemu-devel] [PATCH v9 11/27] gdbstub: Implement write memory (M pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void

[Qemu-devel] [PATCH v9 15/27] gdbstub: Implement file io (F pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3478ac778d..9fe130f30d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1772,6 +1772,39 @@ static void

[Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void

[Qemu-devel] [PATCH v9 20/27] gdbstub: Implement target halted (? pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2fd0d66f4d..d678191705 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2239,13 +2239,30 @@ static void

[Qemu-devel] [PATCH v9 23/27] gdbstub: Implement qemu physical memory mode

2019-05-02 Thread Jon Doron
Add a new query/set which changes the memory GDB sees to physical memory only. gdb> maint packet qqemu.PhyMemMode will reply the current phy_mem_mode state (1 for enabled, 0 for disabled) gdb> maint packet Qqemu.PhyMemMode:1 Will make GDB read/write only to physical memory, set to 0 to disable

[Qemu-devel] [PATCH v9 13/27] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void

[Qemu-devel] [PATCH v9 18/27] gdbstub: Implement generic query (q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 327 ++ 1 file changed, 327 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d56d0fd235..83ae8738cc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1915,6 +1915,323 @@ static void

[Qemu-devel] [PATCH v9 25/27] kvm: Add API to read/write a CPU MSR value

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- accel/kvm/kvm-all.c | 39 +++ include/sysemu/kvm.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..35207d910b 100644 --- a/accel/kvm/kvm-all.c +++

[Qemu-devel] [PATCH v9 24/27] gdbstub: Add another handler for setting qemu.sstep

2019-05-02 Thread Jon Doron
Follow GDB general query/set packet conventions, qemu.sstep can now be set with the following command as well: gdb> maint packet Qqemu.sstep:Value Signed-off-by: Jon Doron --- gdbstub.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 88ff6224e6..34da10260d

Re: [Qemu-devel] [PATCH v2 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

2019-05-02 Thread Thomas Huth
On 30/04/2019 20.13, Cao Jiaxi wrote: > Windows ARM64 uses LLP64 model, which breaks current assumptions. > > Signed-off-by: Cao Jiaxi > --- > util/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/cacheinfo.c b/util/cacheinfo.c > index

Re: [Qemu-devel] [PATCH v2] linux-user: avoid string truncation warnings in uname field copying

2019-05-02 Thread Laurent Vivier
On 01/05/2019 16:46, Daniel P. Berrangé wrote: > In file included from /usr/include/string.h:494, > from include/qemu/osdep.h:101, > from linux-user/uname.c:20: > In function ‘strncpy’, > inlined from ‘sys_uname’ at linux-user/uname.c:94:3: >

Re: [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c

2019-05-02 Thread Dr. David Alan Gilbert
* Wei Yang (richard.weiy...@gmail.com) wrote: > On Wed, May 01, 2019 at 09:24:06PM -0700, no-re...@patchew.org wrote: > >Patchew URL: > >https://patchew.org/QEMU/20190430034412.12935-1-richardw.y...@linux.intel.com/ > > > > > > > >Hi, > > > >This series failed the asan build test. Please find the

[Qemu-devel] [PATCH v9 21/27] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d678191705..8bdfae4b29 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2259,17 +2259,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void

[Qemu-devel] [PATCH v9 26/27] gdbstub: Add support to read a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet qqemu.kvm.Rdmsr:MsrIndex Signed-off-by: Jon Doron --- gdbstub.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 34da10260d..f48c3a2b5f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2141,7

[Qemu-devel] [PATCH v9 19/27] gdbstub: Implement generic set (Q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 83ae8738cc..2fd0d66f4d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v9 27/27] gdbstub: Add support to write a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet Qqemu.kvm.Wrmsr:MsrIndex,Value Signed-off-by: Jon Doron --- gdbstub.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index f48c3a2b5f..a434a3749e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2145,7 +2145,8

Re: [Qemu-devel] [PATCH] vl: fix -sandbox parsing crash when seccomp support is disabled

2019-05-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429134757.13570-1-marcandre.lur...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH] vhost: fix incorrect print type

2019-05-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1556605773-42019-1-git-send-email-wangji...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

[Qemu-devel] [PATCH v3 0/7] tests/qemu-iotests: Run basic iotests during "make check"

2019-05-02 Thread Thomas Huth
People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. This patch series now changes the "auto" group to only include tests that should be safe to run in all CI

[Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-02 Thread Thomas Huth
Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run during "make check" each time, too. Tests in this new group are supposed to run with every possible QEMU configuration, for example they must run with

[Qemu-devel] [PATCH v3 2/7] tests/qemu-iotests/check: Pick a default machine if necessary

2019-05-02 Thread Thomas Huth
qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have a default machine, so when running the qemu-iotests with such a binary, lots of tests are failing. Fix it by picking a default machine in the "check" script instead. Reviewed-by: Alex Bennée Reviewed-by: Philippe

[Qemu-devel] [PATCH v3 1/7] tests/qemu-iotests/005: Add a sanity check for large sparse file support

2019-05-02 Thread Thomas Huth
"check -raw 005" fails when running on certain filesystems - these do not support such large sparse files. Use the same check as in test 220 to skip the test in this case. Suggested-by: Eric Blake Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- tests/qemu-iotests/005 | 9 + 1

[Qemu-devel] [PATCH v3 3/7] tests/qemu-iotests: Do not hard-code the path to bash

2019-05-02 Thread Thomas Huth
bash is installed in a different directory on non-Linux systems like FreeBSD. Do not hard-code /bin/bash here so that the tests can run there, too. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Acked-by: Christian Borntraeger Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 0/3] qemu-img: rebase: Improve/optimize rebase operation

2019-05-02 Thread Sam Eiderman
This patch series aims to improve the speed of qemu-img rebase. 1. Mainly by removing unnecessary reads when rebasing on the same chain. 2. But also by minimizing the number of bdrv_open calls rebase requires.

[Qemu-devel] [PATCH v3 5/7] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests

2019-05-02 Thread Thomas Huth
A lot of tests run fine on FreeBSD and macOS, too - the limitation to Linux here was likely just copied-and-pasted from other tests. Thus remove the "_supported_os Linux" line from tests that run successful in our CI pipelines on FreeBSD and macOS. Reviewed-by: Alex Bennée Tested-by: Alex Bennée

[Qemu-devel] [PATCH v3 4/7] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-05-02 Thread Thomas Huth
We are going to enable the qemu-iotests during "make check" again, and for running the iotests, we need bash and gnu-sed. Reviewed-by: Li-Wen Hsu Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Christian Borntraeger Signed-off-by: Thomas Huth --- .cirrus.yml | 4 ++--

[Qemu-devel] [PATCH v3 7/7] tests: Run the iotests during "make check" again

2019-05-02 Thread Thomas Huth
People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every environment, we can

[Qemu-devel] [PATCH 1/3] qemu-img: rebase: Reuse parent BlockDriverState

2019-05-02 Thread Sam Eiderman
In safe mode we open the entire chain, including the parent backing file of the rebased file. Do not open a new BlockBackend for the parent backing file, which saves opening the rest of the chain twice, which for long chains saves many "pricy" bdrv_open() calls. Permissions for blk_new() were

Re: [Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-02 Thread Philippe Mathieu-Daudé
On 5/2/19 12:38 AM, Richard Henderson wrote: > About half of the values to which CPU_CFLAGS is set > have multiple space separated arguments. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > configure | 16 >

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-05-02 Thread Gerd Hoffmann
On Fri, Apr 19, 2019 at 09:56:23AM +0200, Thomas Huth wrote: > First patch fixes a problem with ohci_die(), second patch moves PCI code into > a separate file, so that the sysbus OHCI device can also be used without > the dependency on the PCI code. > > v2: Split the patch into two patches, one

Re: [Qemu-devel] [PATCH v2] usb/xchi: avoid trigger assertion if guest write wrong epid

2019-05-02 Thread Gerd Hoffmann
On Tue, Apr 30, 2019 at 02:21:41PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > we found the following core in our environment: > 0 0x7fc6b06c2237 in raise () > 1 0x7fc6b06c3928 in abort () > 2 0x7fc6b06bb056 in __assert_fail_base () > 3 0x7fc6b06bb102 in __assert_fail

Re: [Qemu-devel] [PATCH v2 4/5] hw/usb: avoid format truncation warning when formatting port name

2019-05-02 Thread Gerd Hoffmann
On Fri, Apr 12, 2019 at 01:16:25PM +0100, Daniel P. Berrangé wrote: > hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’: > hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\ > tion=] > 3339 |

Re: [Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-02 Thread Eric Blake
On 5/1/19 5:38 PM, Richard Henderson wrote: > About half of the values to which CPU_CFLAGS is set > have multiple space separated arguments. > > Signed-off-by: Richard Henderson > --- > configure | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-05-02 Thread Auger Eric
Hi Shameer, On 5/1/19 12:40 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 30 April 2019 16:50 >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com >> Cc:

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-05-02 Thread Ard Biesheuvel
On Wed, 1 May 2019 at 13:25, Shameerali Kolothum Thodi wrote: > > Hi Ard, > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: 01 May 2019 12:10 > > To: Shameerali Kolothum Thodi > > Cc: QEMU Developers ; qemu-arm > > ; Auger Eric ; Igor > >

[Qemu-devel] [PATCH v8 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void

[Qemu-devel] [PATCH v8 01/27] gdbstub: Add infrastructure to parse cmd packets

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..d5e0f3878a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res; }

[Qemu-devel] [PATCH v8 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 90 ++- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d5e0f3878a..621d689868 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1418,11 +1418,6 @@ static inline int

[Qemu-devel] [PATCH v8 10/27] gdbstub: Implement get register (p pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void

[Qemu-devel] [PATCH v8 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b42425b24c..10e3f12a68 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1634,6 +1634,27 @@ static void

[Qemu-devel] [PATCH v8 00/27] gdbstub: Refactor command packets handler

2019-05-02 Thread Jon Doron
This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets. version 8 changes: - Add new command to display the Supported qemu generic query/sets - kvm: Add API to read/write a MSR - Add

[Qemu-devel] [PATCH v8 17/27] gdbstub: Implement v commands with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9b0556f8be..d56d0fd235 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,106 @@ static void

[Qemu-devel] [PATCH v8 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 89f1ab6524..469aaeb875 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,21 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v8 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void

[Qemu-devel] [PATCH v8 27/27] gdbstub: Add support to write a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet Qqemu.kvm.Wrmsr:MsrIndex,Value Signed-off-by: Jon Doron --- gdbstub.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index d5cdda190a..2d9a8e6942 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2145,7 +2145,8

[Qemu-devel] [PATCH v8 23/27] gdbstub: Implement qemu physical memory mode

2019-05-02 Thread Jon Doron
Add a new query/set which changes the memory GDB sees to physical memory only. gdb> maint packet qqemu.PhyMemMode will reply the current phy_mem_mode state (1 for enabled, 0 for disabled) gdb> maint packet Qqemu.PhyMemMode:1 Will make GDB read/write only to physical memory, set to 0 to disable

[Qemu-devel] [PATCH v8 13/27] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void

[Qemu-devel] [PATCH v8 20/27] gdbstub: Implement target halted (? pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2fd0d66f4d..d678191705 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2239,13 +2239,30 @@ static void

[Qemu-devel] [PATCH v8 21/27] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d678191705..8bdfae4b29 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2259,17 +2259,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void

[Qemu-devel] [PATCH v8 16/27] gdbstub: Implement step (s pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext

[Qemu-devel] [PATCH v8 24/27] gdbstub: Add another handler for setting qemu.sstep

2019-05-02 Thread Jon Doron
Follow GDB general query/set packet conventions, qemu.sstep can now be set with the following command as well: gdb> maint packet Qqemu.sstep:Value Signed-off-by: Jon Doron --- gdbstub.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 6daf779af4..bceceeec57

[Qemu-devel] [PATCH v8 25/27] kvm: Add API to read/write a CPU MSR value

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- accel/kvm/kvm-all.c | 39 +++ include/sysemu/kvm.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..35207d910b 100644 --- a/accel/kvm/kvm-all.c +++

[Qemu-devel] [PATCH v8 15/27] gdbstub: Implement file io (F pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3478ac778d..9fe130f30d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1772,6 +1772,39 @@ static void

[Qemu-devel] [PULL 7/7] hw/usb: avoid format truncation warning when formatting port name

2019-05-02 Thread Gerd Hoffmann
From: Daniel P. Berrangé hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’: hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\ tion=] 3339 | snprintf(port->name, sizeof(port->name),

[Qemu-devel] [PATCH v8 22/27] gdbstub: Implement generic query qemu.Supported

2019-05-02 Thread Jon Doron
qemu.Supported query reply back with the supported qemu query/set commands (commands are seperated with a semicolon from each other). gdb> maint packet qqemu.Supported Signed-off-by: Jon Doron --- gdbstub.c | 9 + 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstub.c

[Qemu-devel] [PATCH v8 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 21cdaf4678..36c7353a22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1588,6 +1588,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v8 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 36c7353a22..b42425b24c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1611,6 +1611,29 @@ static void

[Qemu-devel] [PATCH v8 14/27] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void

[Qemu-devel] [PATCH v8 19/27] gdbstub: Implement generic set (Q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 83ae8738cc..2fd0d66f4d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v8 26/27] gdbstub: Add support to read a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet qqemu.kvm.Rdmsr:MsrIndex Signed-off-by: Jon Doron --- gdbstub.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index bceceeec57..d5cdda190a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2141,7

[Qemu-devel] [PATCH v8 11/27] gdbstub: Implement write memory (M pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void

[Qemu-devel] [PATCH v8 12/27] gdbstub: Implement read memory (m pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8dc2e1d507..daa602edc3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1710,6 +1710,30 @@ static void

[Qemu-devel] [PULL 2/7] usb-mtp: fix alignment of access of ObjectInfo filename field

2019-05-02 Thread Gerd Hoffmann
From: Daniel P. Berrangé The ObjectInfo struct's "filename" field is following a uint8_t field in a packed struct and thus has bad alignment for a 16-bit field. Switch the field to to uint8_t and use the helper function for accessing unaligned 16-bit data. Note that although the MTP spec

[Qemu-devel] [PATCH v8 18/27] gdbstub: Implement generic query (q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 327 ++ 1 file changed, 327 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d56d0fd235..83ae8738cc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1915,6 +1915,323 @@ static void

[Qemu-devel] [PULL 4/7] usb/xhci: avoid trigger assertion if guest write wrong epid

2019-05-02 Thread Gerd Hoffmann
From: Longpeng we found the following core in our environment: 0 0x7fc6b06c2237 in raise () 1 0x7fc6b06c3928 in abort () 2 0x7fc6b06bb056 in __assert_fail_base () 3 0x7fc6b06bb102 in __assert_fail () 4 0x00702e36 in xhci_kick_ep (...) 5 0x0047897a in

[Qemu-devel] [PATCH v8 04/27] gdbstub: Implement continue (c pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c47ef7dd9c..89f1ab6524 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext

Re: [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory

2019-05-02 Thread Corey Minyard
On Sun, Apr 28, 2019 at 08:47:26AM +0200, Philippe Mathieu-Daudé wrote: > Move the IPMI stub file to the stubs/ directory to simplify the > hw/acpi Makefile. > > Signed-off-by: Philippe Mathieu-Daudé I'm not sure of the overall view of this, but this is ok from an IPMI point of view in my view.

[Qemu-devel] [PATCH v2 1/3] qemu-img: rebase: Reuse parent BlockDriverState

2019-05-02 Thread Sam Eiderman
In safe mode we open the entire chain, including the parent backing file of the rebased file. Do not open a new BlockBackend for the parent backing file, which saves opening the rest of the chain twice, which for long chains saves many "pricy" bdrv_open() calls. Permissions for blk_new() were

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] ppc: Add dump-stack implementation

2019-05-02 Thread Greg Kurz
On Wed, 1 May 2019 15:35:22 +1000 Suraj Jitindar Singh wrote: > The monitor function dump-stack is used to dump the stack for a cpu. > This can be useful for debugging purposes when the stack cannot be > dumped by another means. > > Add a ppc implementation ppc_cpu_dump_stack(). > The stack

[Qemu-devel] [PATCH v3 01/40] s390x/tcg: Implement VECTOR ADD

2019-05-02 Thread David Hildenbrand
Introduce two types of fancy new helpers that will be reused a couple of times 1. gen_gvec_fn_3: Call an existing tcg_gen_gvec_X function with 3 parameters, simplifying parameter passing 2. gen_gvec128_3_i64: Call a function that performs 128 bit calculations using two 64 bit values per

[Qemu-devel] [PATCH v3 04/40] s390x/tcg: Implement VECTOR ADD WITH CARRY COMPUTE CARRY

2019-05-02 Thread David Hildenbrand
Similar to VECTOR ADD COMPUTE CARRY, however 128-bit handling only. Courtesy of Richard H. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 32 2 files changed, 34 insertions(+) diff --git

[Qemu-devel] [PATCH v3 00/40] s390x/tcg: Vector Instruction Support Part 2

2019-05-02 Thread David Hildenbrand
This is the second part of vector instruction support for s390x. It is based on the series by Richard: [PATCH v2 00/29] tcg vector improvements Part 1: Vector Support Instructions Part 2: Vector Integer Instructions Part 3: Vector String Instructions Part 4: Vector Floating-Point Instructions

[Qemu-devel] [PATCH v3 23/40] s390x/tcg: Implement VECTOR OR

2019-05-02 Thread David Hildenbrand
Reuse a gvec helper. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PATCH v3 34/40] s390x/tcg: Implement VECTOR SUBTRACT COMPUTE BORROW INDICATION

2019-05-02 Thread David Hildenbrand
Let's keep it simple for now and handle 8/16 bit elements via helpers. Especially for 8/16, we could come up with some bit tricks. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 52

[Qemu-devel] [PATCH v3 35/40] s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW INDICATION

2019-05-02 Thread David Hildenbrand
Fairly easy as only 128-bit handling is required. Simply perform the subtraction and then subtract the borrow. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 26 ++ 2 files

  1   2   3   4   >