Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Update the documentation URL

On Sat, May 04, 2019 at 02:16:50PM +0200, Philippe Mathieu-Daudé wrote: > The documentation URL is not working, but is backed up by the > Wayback Machine on the Internet Archive. > Replace the outdated link by a captured one. > Add another link to the VGADOC4b.ZIP archive content. Added to vga

Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include

On Mon, May 06, 2019 at 12:56:40AM +0200, Philippe Mathieu-Daudé wrote: > Commit ce3cf70edaaf split the ISA device out of the PCI one, > but forgot to remove the "hw/loader.h" header inclusion (the ISA > device calls rom_add_vga()). Remove the now unused include. Added to vga queue. thanks,

[Qemu-devel] [PATCH] block: remove bs from lists before closing

Close involves flush that can be performed asynchronously and bs must be protected from being referenced before it is deleted. Signed-off-by: Anton Kuchin --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9ae5c0ed2f..b505271a4d 100644

Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp

On Tue, May 07, 2019 at 10:48:03AM +1000, Anton Blanchard wrote: > Fix a typo in xvxsigdp where we put both results into the lower > doubleword. > > Fixes: dd977e4f45cb ("target/ppc: Optimize x[sv]xsigdp using deposit_i64()") > Signed-off-by: Anton Blanchard Applied, thanks. > --- >

Re: [Qemu-devel] [PATCH 2/9] target/ppc: Fix xxspltib

On Tue, May 07, 2019 at 10:48:04AM +1000, Anton Blanchard wrote: > xxspltib raises a VMX or a VSX exception depending on the register > set it is operating on. We had a check, but it was backwards. > > Fixes: f113283525a4 ("target-ppc: add xxspltib instruction") > Signed-off-by: Anton Blanchard

Re: [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p

On Tue, May 07, 2019 at 10:48:07AM +1000, Anton Blanchard wrote: > We were using set_cpu_vsr* when we should have used set_cpu_vsrl* Commit message doesn't appear to match the code. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > helpers for VSR register

Re: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: Add ibm, purr and ibm, spurr device-tree properties

On Tue, May 07, 2019 at 09:43:34AM +1000, Suraj Jitindar Singh wrote: > On Mon, 2019-05-06 at 13:23 +1000, David Gibson wrote: > > On Mon, May 06, 2019 at 11:48:03AM +1000, Suraj Jitindar Singh wrote: > > > The ibm,purr and ibm,spurr device tree properties are used to > > > indicate > > > that the

Re: [Qemu-devel] [PATCH 3/9] target/ppc: Fix xxbrq, xxbrw

On Tue, May 07, 2019 at 10:48:05AM +1000, Anton Blanchard wrote: > Fix a typo in xxbrq and xxbrw where we put both results into the lower > doubleword. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > helpers for VSR register access") > Signed-off-by: Anton

Re: [Qemu-devel] [PATCH 9/9] target/ppc: Fix vsum2sws

On Tue, May 07, 2019 at 10:48:11AM +1000, Anton Blanchard wrote: > A recent cleanup changed the pre zeroing of the result from 64 bit > to 32 bit operations: > > -result.u64[i] = 0; > +result.VsrW(i) = 0; > > This corrupts the result. > > Fixes: 60594fea298d ("target/ppc: remove

[Qemu-devel] [PATCH v3 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), itself an old compatibility function. Fold the two together to avoid re-using the stale interface. While we're there replace the explicit fprintf()s with error_report(). Signed-off-by: David Gibson --- hw/pci/pci.c |

[Qemu-devel] [PATCH v3 4/5] pci: Make is_bridge a bool

The is_bridge field in PCIDevice acts as a bool, but is declared as an int. Declare it as a bool for clarity, and change everything that writes it to use true/false instead of 0/1 to match. Signed-off-by: David Gibson --- hw/pci-bridge/dec.c| 4 ++-- hw/pci-bridge/i82801b11.c

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

On Tue, May 07, 2019 at 10:48:06AM +1000, Anton Blanchard wrote: > During the conversion these instructions were incorrectly treated as > stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > helpers for VSR

Re: [Qemu-devel] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm

On Tue, May 07, 2019 at 10:48:09AM +1000, Anton Blanchard wrote: > We should only look at 5 bits of each byte, not 6. > > Fixes: 3e00884f4e9f ("target-ppc: add vrldnmi and vrlwmi instructions") > Signed-off-by: Anton Blanchard Hrm. So, what lives in those extra bits in the 'w' instructions?

[Qemu-devel] [PATCH v3 2/5] pci: Simplify pci_bus_is_root()

pci_bus_is_root() currently relies on a method in the PCIBusClass. But it's always known if a PCI bus is a root bus when we create it, so using a dynamic method is overkill. This replaces it with an IS_ROOT bit in a new flags field, which is set on root buses and otherwise clear. As a bonus this

[Qemu-devel] [PATCH v3 1/5] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}()

These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson

[Qemu-devel] [PATCH v3 0/5] Simplify some not-really-necessary PCI bus callbacks

c2077e2c "pci: Adjust PCI config limit based on bus topology" introduced checking the availability of extended config space for PCI-E devices which are in a bus topology that doesn't permit extended config space access (e.g. under PCI-E to PCI then PCI to PCI-E bridges). This caused some problems

[Qemu-devel] Use of PreallocMode in block drivers (was: [PATCH] block/rbd: add preallocation support)

Cc: Peter for a libvirt perspective. Stefano Garzarella writes: > This patch adds the support of preallocation (off/full) for the RBD > block driver. > If available, we use rbd_writesame() to quickly fill the image when > full preallocation is required. > > Signed-off-by: Stefano Garzarella >

Re: [Qemu-devel] [PATCH 6/9] target/ppc: Fix vslv and vsrv

On Tue, May 07, 2019 at 10:48:08AM +1000, Anton Blanchard wrote: > vslv and vsrv are broken on little endian, we append 00 to the > high byte not the low byte. Fix it by using the VsrB() accessor. > > Signed-off-by: Anton Blanchard Applied, thanks. > --- > target/ppc/int_helper.c | 14

[Qemu-devel] [PATCH v3 3/5] pcie: Simplify pci_adjust_config_limit()

Since c2077e2c "pci: Adjust PCI config limit based on bus topology", pci_adjust_config_limit() has been used in the config space read and write paths to only permit access to extended config space on buses which permit it. Specifically it prevents access on devices below a vanilla-PCI bus via

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

Hi Marcel, On 5/7/19 7:49 AM, Marcel Apfelbaum wrote: > From: HQM > > In a GVT-g setup with dmabuf and GTK GUI, the current 2D texture at > surface_gl_update_texture is not necessarily > surface->texture. Adding a glBindTexture fixes related crashes and > artifacts, and is generally more

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

My real name is "HOU Qiming". @Marcel Apfelbaum can you incorporate that in your v2 patch? Thanks! Qiming On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé wrote: > Hi Marcel, > > On 5/7/19 7:49 AM, Marcel Apfelbaum wrote: > > From: HQM > > > > In a GVT-g setup with dmabuf and GTK GUI,

Re: [Qemu-devel] [PATCH] net: avoid to use variable length array in net_client_init()

On Mon, May 06, 2019 at 12:54:20PM -0500, Eric Blake wrote: > On 5/3/19 12:06 PM, Stefano Garzarella wrote: > > net_client_init() uses a variable length array to store the prefix > > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > > is 'fec0::0'). > > Since the IPv6 prefix can

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

On 5/7/19 9:49 AM, Hou Qiming wrote: My real name is "HOU Qiming". @Marcel Apfelbaum can you incorporate that in your v2 patch? Thanks! Sure thing, Thanks, Marcel Qiming On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé

[Qemu-devel] [PULL 5/8] vl: add -vga help support

From: Marc-André Lureau Provide help output similar to other argument help handling: $ qemu-system-x86_64 -vga help none std standard VGA (default) cirrus Cirrus VGA vmware VMWare SVGA xenfb qxl QXL VGA virtio Virtio VG

Re: [Qemu-devel] [PATCH v2 1/3] aspeed: add a per SoC mapping for the interrupt space

On 5/6/19 4:47 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 5/6/19 4:20 PM, Cédric Le Goater wrote: >> This will simplify the definition of new SoCs, like the AST2600 which >> should use a different CPU and a different IRQ number layout. >> >> Signed-off-by: Cédric Le Goater >> --- >>

Re: [Qemu-devel] [PATCH RFC] s390/css: handle CCW_FLAG_SKIP

On Mon, 6 May 2019 16:58:03 -0400 Eric Farman wrote: > On 5/6/19 1:17 PM, Cornelia Huck wrote: > > If a ccw has CCW_FLAG_SKIP set, and the command is of type > > read, read backwards, or sense, no data should be written > > to the guest for that command. > > > > Signed-off-by: Cornelia Huck >

Re: [Qemu-devel] [PATCH] i2c-ddc: move it to hw/display

On Mon, Mar 25, 2019 at 04:59:23PM +0100, Paolo Bonzini wrote: > Move it together with the other EDID code. hw/i2c should only > include the core and the adapters, not the slaves. Added to vga queue. thanks, Gerd

[Qemu-devel] [PATCH RFC v2] s390/css: handle CCW_FLAG_SKIP

If a ccw has CCW_FLAG_SKIP set, and the command is of type read, read backwards, or sense, no data should be written to the guest for that command. Signed-off-by: Cornelia Huck --- v1 -> v2: fixed checks for command type [Eric] Still only lightly tested (it boots); I don't think I have a tool

[Qemu-devel] [PULL 6/8] qxl: avoid unaligned pointer reads/writes

From: Daniel P. Berrangé The SPICE_RING_PROD_ITEM() macro is initializing a local 'uint64_t *' variable to point to the 'el' field inside the QXLReleaseRing struct. This uint64_t field is not guaranteed aligned as the struct is packed. Code should not take the address of fields within a packed

Re: [Qemu-devel] [PATCH v4 01/24] configure: Link test before auto-enabling gnutls

On 06/05/2019 19:33, Richard Henderson wrote: At least ubuntu 18.04 does not package static gnutls libraries. Signed-off-by: Richard Henderson --- configure | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH] ati-vga: Fix check for blt outside vram

On Tue, Apr 09, 2019 at 12:56:18PM +0200, BALATON Zoltan wrote: > Fix the check preventing calling pixman functions that would access > memory outside allocated vram. The r128 X driver sometimes seem to try > blits that span outside vram, this check prevents crashing QEMU in > that case. (The r128

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: > The SPICE_RING_PROD_ITEM() macro is initializing a local > 'uint64_t *' variable to point to the 'el' field inside > the QXLReleaseRing struct. This uint64_t field is not > guaranteed aligned as the struct is packed. > > Code

[Qemu-devel] [PULL 4/8] vl: constify VGAInterfaceInfo

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-id: 20190412152713.16018-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 8/8] i2c-ddc: move it to hw/display

From: Paolo Bonzini Move it together with the other EDID code. hw/i2c should only include the core and the adapters, not the slaves. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190325155923.30987-1-pbonz...@redhat.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL 2/8] hw/display/cirrus_vga: Update the documentation URL

From: Philippe Mathieu-Daudé The documentation URL is not working, but is backed up by the Wayback Machine on the Internet Archive. Replace the outdated link by a captured one. Add another link to the VGADOC4b.ZIP archive content. Signed-off-by: Philippe Mathieu-Daudé Message-id:

Re: [Qemu-devel] [PATCH] qxl: check release info object

On Thu, Apr 25, 2019 at 12:05:34PM +0530, P J P wrote: > From: Prasad J Pandit > > When releasing spice resources in release_resource() routine, > if release info object 'ext.info' is null, it leads to null > pointer dereference. Add check to avoid it. Added to vga patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 0/2] Add -vga help

On Fri, Apr 12, 2019 at 05:27:11PM +0200, Marc-André Lureau wrote: > Hi, > > SSIA, see patches. Series added to vga queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp

On 5/7/19 2:48 AM, Anton Blanchard wrote: > Fix a typo in xvxsigdp where we put both results into the lower > doubleword. > > Fixes: dd977e4f45cb ("target/ppc: Optimize x[sv]xsigdp using deposit_i64()") > Signed-off-by: Anton Blanchard > --- > target/ppc/translate/vsx-impl.inc.c | 2 +- > 1

[Qemu-devel] [PATCH v3] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

From: HOU Qiming In a GVT-g setup with dmabuf and GTK GUI, the current 2D texture at surface_gl_update_texture is not necessarily surface->texture. Adding a glBindTexture fixes related crashes and artifacts, and is generally more secure. Signed-off-by: HOU Qiming Tested-by: Marcel Apfelbaum

[Qemu-devel] [PULL 3/8] hw/display/cirrus_vga: Remove unused include

From: Philippe Mathieu-Daudé Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-id:

[Qemu-devel] [PULL 7/8] ati-vga: Fix check for blt outside vram

From: BALATON Zoltan Fix the check preventing calling pixman functions that would access memory outside allocated vram. The r128 X driver sometimes seem to try blits that span outside vram, this check prevents crashing QEMU in that case. (The r128 X driver may have problems even on real hardware

[Qemu-devel] [PULL 1/8] qxl: check release info object

From: Prasad J Pandit When releasing spice resources in release_resource() routine, if release info object 'ext.info' is null, it leads to null pointer dereference. Add check to avoid it. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pandit Message-id:

Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block

Am 03.05.2019 um 16:39 hat Alex Bennée geschrieben: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system. This includes: > > - formatting as " TESTiotest: nnn" > - calculating time diff at the end > - only dumping config on failure >

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

Hi Gerd, On 5/7/19 9:54 AM, Gerd Hoffmann wrote: > On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: >> The SPICE_RING_PROD_ITEM() macro is initializing a local >> 'uint64_t *' variable to point to the 'el' field inside >> the QXLReleaseRing struct. This uint64_t field is not >>

Re: [Qemu-devel] Update *BSD images with gnu-sed and bash (was: [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD)

> >> D'oh! Does anybody know what are the correct steps to update these images? > > > > (1) make the OPENBSD subsystem maintainer care > > > > (2) update > > > > (3) download the image from download.patchew.org, boot it and update it > > > > (4) upload the

[Qemu-devel] [PULL 0/8] Vga 20190507 patches

The following changes since commit a6ae23831b05a11880b40f7d58e332c45a6b04f7: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-05-03 15:26:09 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190507-pull

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

On 5/7/19 8:49 AM, Hou Qiming wrote: > My real name is "HOU Qiming". @Marcel Apfelbaum > can you incorporate that in your v2 > patch? Thanks! Thanks a lot Qiming :) > On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé > wrote: >

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

On Tue, May 07, 2019 at 10:11:02AM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 5/7/19 9:54 AM, Gerd Hoffmann wrote: > > On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: > >> The SPICE_RING_PROD_ITEM() macro is initializing a local > >> 'uint64_t *' variable to point

Re: [Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration

On 07/05/2019 10.44, Greg Kurz wrote: > This is a leftover of the handle backend, removed in QEMU 4.0. > > Signed-off-by: Greg Kurz > --- > fsdev/qemu-fsdev.h |1 - > 1 file changed, 1 deletion(-) > > diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h > index d9716b414492..844159d1e1ff

Re: [Qemu-devel] [PULL 0/1] Update slirp submodule

On Sat, 4 May 2019 at 13:41, Samuel Thibault wrote: > > The following changes since commit 52ec9dcc1ed5609674e7b52198c18207bb193548: > > Update slirp submodule (2019-05-04 14:38:05 +0200) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git

Re: [Qemu-devel] [PATCH v3 0/2] roms: Add 'clean' make rule and EDK2 documentation fix

On 05/06/19 16:19, Philippe Mathieu-Daudé wrote: > Hi, > > Two trivial patches waiting Laszlo's series to land. ... I think you can submit a pullreq with these two patches now -- because I believe that you refer to [Qemu-devel] [PULL 00/12] bundle edk2 platform firmware with QEMU above, and

[Qemu-devel] [PULL 02/15] pflash_cfi01: New pflash_cfi01_legacy_drive()

From: Markus Armbruster Factored out of pc_system_firmware_init() so the next commit can reuse it in hw/arm/virt.c. Signed-off-by: Markus Armbruster Reviewed-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190416091348.26075-3-arm...@redhat.com Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 10/15] osdep: Fix mingw compilation regarding stdio formats

From: Cao Jiaxi I encountered the following compilation error on mingw: /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macro redefined [-Werror,-Wmacro-redefined] #define __USE_MINGW_ANSI_STDIO 1 ^ /mnt/d/llvm-mingw/aarch64-w64-mingw32/include/_mingw.h:433:9:

[Qemu-devel] [PULL 04/15] hw/arm/raspi: Diagnose requests for too much RAM

The Raspberry Pi boards have a physical memory map which does not allow for more than 1GB of RAM. Currently if the user tries to ask for more then we fail in a confusing way: $ qemu-system-aarch64 --machine raspi3 -m 8G Unexpected error in visit_type_uintN() at qapi/qapi-visit-core.c:164:

[Qemu-devel] [PULL 14/15] target/arm: Implement XPSR GE bits

In the M-profile architecture, if the CPU implements the DSP extension then the XPSR has GE bits, in the same way as the A-profile CPSR. When we added DSP extension support we forgot to add support for reading and writing the GE bits, which are stored in env->GE. We did put in the code to add

Re: [Qemu-devel] [PULL 00/28] Kconfig for Arm machines

On 07/05/2019 13.52, Philippe Mathieu-Daudé wrote: > On 5/7/19 1:01 PM, Peter Maydell wrote: >> On Sun, 5 May 2019 at 14:57, Thomas Huth wrote: >>> >>> Hi Peter, >>> >>> the following changes since commit a6ae23831b05a11880b40f7d58e332c45a6b04f7: >>> >>> Merge remote-tracking branch >>>

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

On Dienstag, 7. Mai 2019 11:55:56 CEST Greg Kurz wrote: > > support the 'vii' feature of patch 5, which introduces the XML config > > What is patch 5 ?!? What is 'vii' ? I am a bit lost here... Hi Greg, Sorry that I caused a bit of confusion, You were actually commenting mostly on v2 of the

Re: [Qemu-devel] Use of PreallocMode in block drivers (was: [PATCH] block/rbd: add preallocation support)

On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: > Cc: Peter for a libvirt perspective. > > Stefano Garzarella writes: > > > This patch adds the support of preallocation (off/full) for the RBD > > block driver. > > If available, we use rbd_writesame() to quickly fill the image

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

Am 06.05.2019 um 22:33 hat John Snow geschrieben: > in blockdev_backup_prepare, we check to make sure that the target is > associated with a compatible aio context. However, do_blockdev_backup is > called later and has some logic to move the target to a compatible > aio_context. The transaction

Re: [Qemu-devel] [PATCH] block: remove bs from lists before closing

Am 07.05.2019 um 10:12 hat Anton Kuchin geschrieben: > Close involves flush that can be performed asynchronously and bs > must be protected from being referenced before it is deleted. > > Signed-off-by: Anton Kuchin Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH RFC v2] s390/css: handle CCW_FLAG_SKIP

On 07/05/2019 10:12, Cornelia Huck wrote: If a ccw has CCW_FLAG_SKIP set, and the command is of type read, read backwards, or sense, no data should be written to the guest for that command. Signed-off-by: Cornelia Huck --- v1 -> v2: fixed checks for command type [Eric] Still only lightly

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 0/9] s390x: new guest features

On 29.04.19 18:08, Cornelia Huck wrote: > On Mon, 29 Apr 2019 05:02:41 -0400 > Christian Borntraeger wrote: > >> Adding gen15. >> >> v2->v3: - merge deprecation patch into gen 15 patch >> - fix comments >> - use gen15a and gen15b instead of cpuid >> v1->v2: - rework csske

[Qemu-devel] [Bug 1826568] Re: RISC-V Disassembler/translator instruction decoding disagreement

I've encountered this message before for invalid instructions, and it often doesn't really mean there was an error. In particular for variable instruction length ISAs you'll see the error if the translator reads part of the insn and determines that it's invalid without needing to read the rest of

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > The Golang JSON parser decodes JSON numbers to float64 by default so > > will have this precision limitation too, though at least they provide > > a backdoor for custom parsing from the original serialized representation. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/5] pci: Make is_bridge a bool

On Tue, 7 May 2019 16:23:15 +1000 David Gibson wrote: > The is_bridge field in PCIDevice acts as a bool, but is declared as an int. > Declare it as a bool for clarity, and change everything that writes it to > use true/false instead of 0/1 to match. > Reviewed-by: Greg Kurz > Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [QEMU PATCH] MAINTAINERS: Downgrade status of block sections without "M:" to "Odd Fixes"

On 06/05/2019 09.48, Stefano Garzarella wrote: > Hi Thomas, > > On Mon, May 06, 2019 at 08:18:54AM +0200, Thomas Huth wrote: >> Fixes might still get picked up via the qemu-block mailing list, >> so the status is not "Orphan" yet. >> Also add the gluster mailing list as suggested by Niels here:

Re: [Qemu-devel] [PATCH v4 07/24] crypto: Change the qcrypto_random_bytes buffer type to void*

On 06/05/2019 19:33, Richard Henderson wrote: Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +-

Re: [Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field

On 07/05/2019 10.44, Greg Kurz wrote: > This was introduced along with -fsdev but it never got used. > > Signed-off-by: Greg Kurz > --- > fsdev/file-op-9p.h |1 - > 1 file changed, 1 deletion(-) > > diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h > index 3fa062b39f1b..c757c8099f54

Re: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > We already define SDCardModes/SDCardStates as enums. Declare > > the mode/state as enums too, this make gdb debugging sessions > > friendlier: instead of numbers, the mode/state name is displayed. > > > >

Re: [Qemu-devel] [PATCH] Deprecate Python 2 support

On Tue, May 07, 2019 at 12:38:14PM +0200, Kevin Wolf wrote: > Am 03.05.2019 um 21:37 hat Eduardo Habkost geschrieben: > > Python 2 will reach end of life in January 1 2020. Declare it as > > deprecated. > > > > Signed-off-by: Eduardo Habkost > > --- > > configure| 8 > >

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

Suraj Jitindar Singh writes: > Add a monitor command "dump-stack" to be used to dump the stack for the > current cpu. I guess this is just for debugging. Correct? Shouldn't this be "info stack", to match "info registers" and "info cpustats"? > > Signed-off-by: Suraj Jitindar Singh > --- >

Re: [Qemu-devel] [PATCH v4 11/24] cpus: Initialize pseudo-random seeds for all guest cpus

On 06/05/2019 19:33, Richard Henderson wrote: When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created; which is a no-op unless the subsystem is in deterministic mode. Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH v4 10/24] util: Add qemu_guest_getrandom and associated routines

On 06/05/2019 19:33, Richard Henderson wrote: This routine is intended to produce high-quality random numbers to the guest. Normally, such numbers are crypto quality from the host, but a command-line option can force the use of a fully deterministic sequence for use while debugging.

[Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

The Q35 machine uses the ICH9 chipset which is composed of various sub-devices. There is currently no generic Kconfig selector that selects all the required devices. Meanwhile, force the Q35 machine to select the 'ich9-ahci' device. This fixes: $ ./configure --without-default-devices && \

Re: [Qemu-devel] [PATCH v3 2/5] 9P: trivial cleanup of QID path collision mitigation

On Tue, Apr 23, 2019 at 01:35:23PM +0200, Christian Schoenebeck via Qemu-devel wrote: > Addresses trivial changes regarding the previous patch as requested > on the mailing list a while ago. These changes should just be made to the original 4 patches individually rather than in a new patch. >

Re: [Qemu-devel] [PATCH v2 0/4] 9p: Fix file ID collisions

On Fri, 03 May 2019 18:20:39 +0200 Christian Schoenebeck wrote: > Hi! > > This is v2 of a proposed patch set for fixing file ID collisions with 9pfs. > > Patch 1 to 3 are identical to the previous version. New in this v2 is patch 4 > which introduces variable length suffixes for inode mapping

Re: [Qemu-devel] [QEMU PATCH] MAINTAINERS: Downgrade status of block sections without "M:" to "Odd Fixes"

Am 06.05.2019 um 08:18 hat Thomas Huth geschrieben: > Fixes might still get picked up via the qemu-block mailing list, > so the status is not "Orphan" yet. > Also add the gluster mailing list as suggested by Niels here: > > https://patchwork.kernel.org/patch/10613297/#22409943 > >

[Qemu-devel] [PULL 01/15] pc: Rearrange pc_system_firmware_init()'s legacy -drive loop

From: Markus Armbruster The loop does two things: map legacy -drive to properties, and collect all the backends for use after the loop. The next patch will factor out the former for reuse in hw/arm/virt.c. To make that easier, rearrange the loop so it does the first thing first, and the second

[Qemu-devel] [PULL 07/15] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets

From: Cao Jiaxi gcc_struct is for x86 only, and it generates an warning on ARM64 Clang/MinGW targets. Signed-off-by: Cao Jiaxi Reviewed-by: Thomas Huth Message-id: 20190503003618.10089-1-driver1...@foxmail.com [PMM: dropped the slirp change as slirp is now a submodule] Signed-off-by: Peter

[Qemu-devel] [PULL 11/15] hw/arm/armv7m_nvic: Check subpriority in nvic_recompute_state_secure()

Rule R_CQRV says that if two pending interrupts have the same group priority then ties are broken by looking at the subpriority. We had a comment describing this but had forgotten to actually implement the subpriority comparison. Correct the omission. (The further tie break rules of "lowest

[Qemu-devel] [PULL 05/15] arm: Allow system registers for KVM guests to be changed by QEMU code

At the moment the Arm implementations of kvm_arch_{get,put}_registers() don't support having QEMU change the values of system registers (aka coprocessor registers for AArch32). This is because although kvm_arch_get_registers() calls write_list_to_cpustate() to update the CPU state struct fields

[Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

This fixes several things: - add "id" description to -virtfs documentation - split the description into several lines in both usage and documentation for accurateness and clarity - add documentation and usage of the synth fsdriver - add "throttling.*" description to -fsdev local - add some

Re: [Qemu-devel] [PATCH v4 02/24] crypto: Merge crypto-obj-y into libqemuutil.a

On 06/05/2019 19:33, Richard Henderson wrote: We will shortly need this in the user-only binaries, so drop the split into system and tools binaries. This also means that crypto-aes-obj-y can be merged back into crypto-obj-y. This patch breaks linux-user statically linked build on Fedora.

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. >

Re: [Qemu-devel] [PATCH v4 04/24] crypto: Do not fail for EINTR during qcrypto_random_bytes

On 06/05/2019 19:33, Richard Henderson wrote: We can always get EINTR for read; /dev/urandom is no exception. Rearrange the order of tests for likelihood; allow degenerate buflen==0 case to perform a no-op zero-length read. This means that the normal success path is a straight line with a

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

On Fri, May 03, 2019 at 10:47:57PM +0200, Kashyap Chamarthy wrote: > On Fri, May 03, 2019 at 04:49:05PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 03, 2019 at 05:46:13PM +0200, Kashyap Chamarthy wrote: > > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > > > source

Re: [Qemu-devel] [PATCH v2] block/rbd: increase dynamically the image size

Am 06.05.2019 um 11:50 hat Stefano Garzarella geschrieben: > On Fri, May 03, 2019 at 01:21:23PM -0400, Jason Dillaman wrote: > > On Fri, May 3, 2019 at 12:30 PM Stefano Garzarella > > wrote: > > > > > > RBD APIs don't allow us to write more than the size set with > > > rbd_create() or

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

On Mon, 06 May 2019 19:58:28 +0200 Christian Schoenebeck wrote: > This is the counter part patch against latest libvirt git master head to Hmm... shouldn't this be Cc'd to libvir-l...@redhat.com as well then ? > support the 'vii' feature of patch 5, which introduces the XML config What is

[Qemu-devel] [PULL 09/15] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64

From: Cao Jiaxi Windows ARM64 uses LLP64 model, which breaks current assumptions. Signed-off-by: Cao Jiaxi Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-id: 20190503003707.10185-1-driver1...@foxmail.com Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 00/15] target-arm queue

at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190507 for you to fetch changes up to 63159601fb3e396b28da14cbb71e50ed3f5a0331: target/arm: Stop using variable length array in dc_zva (2019-05-07 12:55:04 +0100

[Qemu-devel] [PATCH 0/6] fsdev/virtfs: Assorted cleanups and fixes

Hi, This series does several things, not necessarily related, but I post them all together anyway because it will be more convenient for me to merge them after review, given the little time I can spend on virtfs maintainership. Thomas, Patch 6 supersedes

[Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration

This is a leftover of the handle backend, removed in QEMU 4.0. Signed-off-by: Greg Kurz --- fsdev/qemu-fsdev.h |1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h index d9716b414492..844159d1e1ff 100644 --- a/fsdev/qemu-fsdev.h +++ b/fsdev/qemu-fsdev.h

[Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field

This was introduced along with -fsdev but it never got used. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 3fa062b39f1b..c757c8099f54 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 03 May 2019 16:10 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com;

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

24.04.2019 19:36, Max Reitz wrote: > On 19.04.19 12:23, Vladimir Sementsov-Ogievskiy wrote: >> 17.04.2019 19:22, Max Reitz wrote: >>> On 16.04.19 12:02, Vladimir Sementsov-Ogievskiy wrote: 10.04.2019 23:20, Max Reitz wrote: > What bs->file and bs->backing mean depends on the node. For

Re: [Qemu-devel] [PATCH v4 05/15] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

On Sun, 5 May 2019 09:27:45 +0800 Wei Yang wrote: > On Thu, May 02, 2019 at 04:51:53PM +0200, Igor Mammedov wrote: > >that way it would be possible to test a DSDT pointed by > >64bit X_DSDT field in FADT. > > > >PS: > >it will allow to enable testing arm/virt board, which sets > >only newer

Re: [Qemu-devel] [PATCH 1/1] MAINTAINERS: Add an entry for the Parallel NOR Flash devices

On 05/06/19 00:47, Philippe Mathieu-Daudé wrote: > Step in to maintain it, since I have some familiarity with > the technology. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

On Tue, 7 May 2019 16:23:16 +1000 David Gibson wrote: > The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), > itself an old compatibility function. Fold the two together to avoid > re-using the stale interface. > > While we're there replace the explicit fprintf()s with

Re: [Qemu-devel] [PATCH v4 08/24] ui/vnc: Split out authentication_failed

On 06/05/2019 19:33, Richard Henderson wrote: There were 3 copies of this code, one of which used the wrong data size for the failure indicator. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- ui/vnc.c |

[Qemu-devel] [PULL 08/15] qga: Fix mingw compilation warnings on enum conversion

From: Cao Jiaxi The win2qemu[] is supposed to be the conversion table to convert between STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga. But it was incorrectly written that it forces to set a GuestDiskBusType value to STORAGE_BUS_TYPE, which generates an enum conversion warning in

  1   2   3   4   >