[Qemu-devel] [PATCH v2 4/6] qapi: Disentangle QAPIDoc code

2019-05-17 Thread Kevin Wolf
Documentation comment follow a certain structure: First, we have a text with a general description (called QAPIDoc.body). After this, descriptions of the arguments follow. Finally, we have part that contains various named sections. The code doesn't show this structure but just checks the right

[Qemu-devel] [PATCH v2 5/6] qapi: Allow documentation for features

2019-05-17 Thread Kevin Wolf
Features will be documented in a new part introduced by a "Features:" line, after arguments and before named sections. Signed-off-by: Kevin Wolf --- scripts/qapi/common.py | 43 ++ scripts/qapi/doc.py| 11 +++ 2 files changed, 50

[Qemu-devel] [PATCH v2 2/6] tests/qapi-schema: Test for good feature lists in structs

2019-05-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qapi-schema/qapi-schema-test.json | 30 +++ tests/qapi-schema/qapi-schema-test.out | 32 + tests/qapi-schema/test-qapi.py | 4 3 files changed, 66 insertions(+) diff --git

[Qemu-devel] [PATCH v2 0/6] file-posix: Add dynamic-auto-read-only QAPI feature

2019-05-17 Thread Kevin Wolf
This series adds optional feature lists to struct definitions in the QAPI schema and makes use of them to advertise the new behaviour of auto-read-only=on in file-posix. v2: - Check that features have well-formed names instead of just checking that they are strings - Use QAPISchemaFeature

[Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs

2019-05-17 Thread Kevin Wolf
Sometimes, the behaviour of QEMU changes compatibly, but without a change in the QMP syntax (usually by allowing values or operations that previously resulted in an error). QMP clients may still need to know whether the extension is available. This allows to add a list of features to struct

[Qemu-devel] [Bug 676934] Re: Ability to use -net socket with unix sockets

2019-05-17 Thread Daniel Berrange
This is just about connecting the NIC backends for 2 QEMUs together using a UNIX socket, instead of the current TCP/UDP socket. It should be fairly trivial to support i would expect. Though ideally we'd port the netdev socket backend to use QIOChannel too -- You received this bug notification

[Qemu-devel] [PATCH v2 9/9] i386/kvm: add support for Direct Mode for Hyper-V synthetic timers

2019-05-17 Thread Vitaly Kuznetsov
Hyper-V on KVM can only use Synthetic timers with Direct Mode (opting for an interrupt instead of VMBus message). This new capability is only announced in KVM_GET_SUPPORTED_HV_CPUID. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt| 10 ++ target/i386/cpu.c | 2

[Qemu-devel] [PATCH v2 4/9] i386/kvm: document existing Hyper-V enlightenments

2019-05-17 Thread Vitaly Kuznetsov
Currently, there is no doc describing hv-* CPU flags, people are encouraged to get the information from Microsoft Hyper-V Top Level Functional specification (TLFS). There is, however, a bit of QEMU specifics. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt | 181

[Qemu-devel] [PATCH v2 8/9] i386/kvm: hv-evmcs requires hv-vapic

2019-05-17 Thread Vitaly Kuznetsov
Enlightened VMCS is enabled by writing to a field in VP assist page and these require virtual APIC. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 7fc97b749e..7ae2f63f72

[Qemu-devel] [PATCH v2 5/9] i386/kvm: implement 'hv-passthrough' mode

2019-05-17 Thread Vitaly Kuznetsov
In many case we just want to give Windows guests all currently supported Hyper-V enlightenments and that's where this new mode may come handy. We pass through what was returned by KVM_GET_SUPPORTED_HV_CPUID. hv_cpuid_check_and_set() is modified to also set cpu->hyperv_* flags as we may want to

[Qemu-devel] [PATCH v2 1/9] i386/kvm: convert hyperv enlightenments properties from bools to bits

2019-05-17 Thread Vitaly Kuznetsov
Representing Hyper-V properties as bits will allow us to check features and dependencies between them in a natural way. Suggested-by: Roman Kagan Signed-off-by: Vitaly Kuznetsov --- hw/i386/pc.c | 3 +- target/i386/cpu.c | 44 +++ target/i386/cpu.h | 37

Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

2019-05-17 Thread Igor Mammedov
On Fri, 17 May 2019 12:59:57 + Wei Yang wrote: > On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote: > >On Fri, 17 May 2019 08:51:14 +0800 > >Wei Yang wrote: > > > >> Pointed out by Philippe Mathieu-Daud?? . > >> > >> Signed-off-by: Wei Yang > >> --- > >> hw/acpi/Kconfig | 2

[Qemu-devel] [PATCH v2 2/9] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

2019-05-17 Thread Vitaly Kuznetsov
KVM now supports reporting supported Hyper-V features through CPUID (KVM_GET_SUPPORTED_HV_CPUID ioctl). Going forward, this is going to be the only way to announce new functionality and this has already happened with Direct Mode stimers. While we could just support KVM_GET_SUPPORTED_HV_CPUID for

[Qemu-devel] [Bug 676934] Re: Ability to use -net socket with unix sockets

2019-05-17 Thread Alex Bennée
Aren't these at different levels of the stack? Network devices deal in packets not connections. It sounds like you want to use something like vsock which provides a virtual socket device to the guest. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v2 3/9] i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties()

2019-05-17 Thread Vitaly Kuznetsov
Let's consolidate Hyper-V features handling in hyperv_handle_properties(). The change is necessary to support 'hv-passthrough' mode as we'll be just copying CPUIDs from KVM instead of filling them in. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 163

[Qemu-devel] [PATCH v2 6/9] i386/kvm: hv-stimer requires hv-time and hv-synic

2019-05-17 Thread Vitaly Kuznetsov
Synthetic timers operate in hv-time time and Windows won't use these without SynIC. Add .dependencies field to kvm_hyperv_properties[] and a generic mechanism to check dependencies between features. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 23 +++ 1 file

[Qemu-devel] [PATCH v2 0/9] i386/kvm/hyper-v: refactor and implement 'hv-stimer-direct' and 'hv-passthrough' enlightenments

2019-05-17 Thread Vitaly Kuznetsov
It has been a while since my 'v1' and I (again) apologize for that. Changes since v1: - Existing Hyper-V properties are converted from BOOL to BIT64, this allows us to express dependencies between them in a more natural way as well as simplifies search in kvm_hyperv_properties [Roman Kagan]

[Qemu-devel] [PATCH v2 7/9] i386/kvm: hv-tlbflush/ipi require hv-vpindex

2019-05-17 Thread Vitaly Kuznetsov
The corresponding hypercalls require using VP indexes. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index d8b83031a5..7fc97b749e 100644 --- a/target/i386/kvm.c +++

Re: [Qemu-devel] [PATCH v2 1/3] lsi53c895a: hide 53c895a registers in 53c810

2019-05-17 Thread Mark Cave-Ayland
On 07/05/2019 16:03, Artyom Tarasenko wrote: > On Mon, May 6, 2019 at 4:27 PM Mark Cave-Ayland > wrote: >> >> On 06/05/2019 09:42, Artyom Tarasenko wrote: >> >>> On Sun, May 5, 2019 at 12:43 PM Mark Cave-Ayland >>> wrote: On 04/05/2019 22:02, Artyom Tarasenko wrote: >

Re: [Qemu-devel] [PATCH 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge

2019-05-17 Thread Vladimir Sementsov-Ogievskiy
17.05.2019 16:50, Eric Blake wrote: > On 5/16/19 7:32 PM, John Snow wrote: >> >> >> On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Add new optional parameter making possible to merge bitmaps from >>> different nodes. It is needed to maintain external snapshots during >>> incremental

Re: [Qemu-devel] [PATCH 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge

2019-05-17 Thread Eric Blake
On 5/16/19 7:32 PM, John Snow wrote: > > > On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add new optional parameter making possible to merge bitmaps from >> different nodes. It is needed to maintain external snapshots during >> incremental backup chain history. >> >> Signed-off-by:

[Qemu-devel] [PATCH v3 2/4] net: avoid using variable length array in net_client_init()

2019-05-17 Thread Stefano Garzarella
net_client_init() uses a variable length array to store the prefix of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix is 'fec0::0'). This patch introduces g_strsplit() to split the 'ipv6-net' parameter, so we can remove the variable length array. Suggested-by: Markus Armbruster

[Qemu-devel] [PATCH v3 4/4] net: remove unused get_str_sep() function

2019-05-17 Thread Stefano Garzarella
Since the get_str_sep() function is no longer used in net/net.c, we can remove it. Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster --- net/net.c | 20 1 file changed, 20 deletions(-) diff --git a/net/net.c b/net/net.c index 23f29ef1d2..4e1b25ba91 100644

[Qemu-devel] [PATCH v3 1/4] net: fix assertion failure when ipv6-prefixlen is not a number

2019-05-17 Thread Stefano Garzarella
If 'ipv6-prefixlen' is not a number, the current behaviour produces an assertion failure: $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach: Assertion `!errp || !*errp' failed. Aborted (core dumped) This patch

[Qemu-devel] [Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2019-05-17 Thread nagaraju418
Do we got any solution for this issue ? I am seeing similar issue for qemu-system-arm, I have tried with "-nic user,model=virtio-net- pci,hostfwd=tcp:127.0.0.1:31258-:22,hostfwd=tcp:127.0.0.1:47175-:443,hostname=xxx.com" and also with "-net nic -net

[Qemu-devel] [PATCH v3 3/4] net: use g_strsplit() for parsing host address and port

2019-05-17 Thread Stefano Garzarella
Use the glib function to split host address and port in the parse_host_port() function. Suggested-by: Markus Armbruster Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster --- net/net.c | 43 +++ 1 file changed, 27 insertions(+), 16

[Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c

2019-05-17 Thread Stefano Garzarella
This series contains some clean ups in net/net.c The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I removed the get_str_sep() function (patch 4) because it

Re: [Qemu-devel] [PULL SUBSYSTEM v2 s390x 00/40] s390x/tcg: s390x/tcg: Vector Instruction Support Part 2

2019-05-17 Thread Cornelia Huck
On Fri, 17 May 2019 13:42:43 +0200 David Hildenbrand wrote: > This pull request is not for master. > > Hi Cornelia, > > This time a signed pull request :) > > The following changes since commit 85fa94e16927af2717093e5b8fe225206ec39e16: > > s390/css: handle CCW_FLAG_SKIP (2019-05-17

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-17 Thread Peter Krempa
On Wed, May 15, 2019 at 15:48:29 +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: [...] > > Do you expect libvirt to check a full list of all QMP commands, types, > > etc. it ever uses against the schema

[Qemu-devel] [PATCH v2 0/2] Add pseudo /proc/hardware and /proc/cpuinfo

2019-05-17 Thread Laurent Vivier
They are used by some package setup scripts to set the default configuration. v2: rebase Laurent Vivier (2): linux-user: add pseudo /proc/cpuinfo for sparc linux-user: add pseudo /proc/hardware for m68k linux-user/syscall.c | 27 ++- 1 file changed, 26

[Qemu-devel] [PATCH v2 1/2] linux-user: add pseudo /proc/cpuinfo for sparc

2019-05-17 Thread Laurent Vivier
SPARC libc6 debian package wants to check the cpu level to be installed or not: WARNING: This machine has a SPARC V8 or earlier class processor. Debian lenny and later does not support such old hardware any longer. To avoid this, it only needs to know if the machine type is sun4u or sun4v,

[Qemu-devel] [PATCH v2 2/2] linux-user: add pseudo /proc/hardware for m68k

2019-05-17 Thread Laurent Vivier
Debian console-setup uses /proc/hardware to guess the keyboard layout. If the file /proc/hardware cannot be opened, the installation fails. This patch adds a pseudo /proc/hardware file to report the model of the machine. Instead of reporting a known and fake model, it reports "qemu-m68k", which

[Qemu-devel] [PULL v3 00/21] Misc patches for 2019-05-15

2019-05-17 Thread Paolo Bonzini
The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into staging (2019-05-14 10:08:47 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-17 Thread Greg Kurz
On Mon, 13 May 2019 12:34:10 +0200 Greg Kurz wrote: > This fixes several things: > - add "id" description to -virtfs documentation > - split the description into several lines in both usage and documentation > for accurateness and clarity > - add documentation and usage of the synth fsdriver >

Re: [Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-17 Thread Thomas Huth
On 17/05/2019 15.17, Greg Kurz wrote: > On Mon, 13 May 2019 12:34:10 +0200 > Greg Kurz wrote: > >> This fixes several things: >> - add "id" description to -virtfs documentation >> - split the description into several lines in both usage and documentation >> for accurateness and clarity >> -

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

2019-05-17 Thread Christian Schoenebeck via Qemu-devel
On Freitag, 17. Mai 2019 14:30:29 CEST Greg Kurz wrote: > Then, we come to the bulk problem: how to handle the case where we > have multiple devices involved in a directory we want to share ? > Antonios's proposal is a clever way to address the collisions, but > your work proves it isn't enough...

[Qemu-devel] [PATCH] checkpatch: detect doubly-encoded UTF-8

2019-05-17 Thread Paolo Bonzini
Copy and pasting from Thunderbird's "view source" window results in double encoding of multibyte UTF-8 sequences. The appearance of those sequences is very peculiar, so detect it and give an error despite the (low) possibility of false positives. As the major offender, I am also adding the same

[Qemu-devel] [PATCH 4/4] vfio/pci: unplug failover primary device before migration

2019-05-17 Thread Jens Freimann
As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before migration happens by

Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

2019-05-17 Thread Wei Yang
On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote: >On Fri, 17 May 2019 08:51:14 +0800 >Wei Yang wrote: > >> Pointed out by Philippe Mathieu-Daud?? . >> >> Signed-off-by: Wei Yang >> --- >> hw/acpi/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

[Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-17 Thread Jens Freimann
This is another attempt at implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since last RFC: - work around circular dependency of commandline options. Just add failover=on to the virtio-net standby options and

[Qemu-devel] [PATCH 2/4] qdev/qbus: Add hidden device support

2019-05-17 Thread Jens Freimann
This adds support for hiding a device to the qbus and qdev APIs. qdev_device_add() is modified to check for a standby argument in the option string. A DeviceListener callback should_be_hidden() is added. It can be used by a standby device to inform qdev that this device should not be added now.

[Qemu-devel] [PATCH 1/4] migration: allow unplug during migration for failover devices

2019-05-17 Thread Jens Freimann
In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds a flag to DeviceState

[Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-17 Thread Jens Freimann
This patch adds support to handle failover device pairs of a virtio-net device and a vfio-pci device, where the virtio-net acts as the standby device and the vfio-pci device as the primary. The general idea is that we have a pair of devices, a vfio-pci and a emulated (virtio-net) device. Before

[Qemu-devel] [PATCH v3] mips: Decide to map PAGE_EXEC in map_address

2019-05-17 Thread Jakub Jermář
This commit addresses QEMU Bug #1825311: mips_cpu_handle_mmu_fault renders all accessed pages executable It allows finer-grained control over whether the accessed page should be executable by moving the decision to the underlying map_address function, which has more information for this. As a

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

2019-05-17 Thread Greg Kurz
On Fri, 17 May 2019 10:40:48 +0200 Christian Schoenebeck wrote: > On Dienstag, 7. Mai 2019 18:16:08 CEST Christian Schoenebeck wrote: > > Here are the archive links for latest v3 patch set [5(+1) patches total]: > > > > [PATCH v3 0/5] 9p: Fix file ID collisions: > >

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-05-17 Thread Vladimir Sementsov-Ogievskiy
07.05.2019 18:13, Max Reitz wrote: > On 07.05.19 15:30, Vladimir Sementsov-Ogievskiy wrote: >> 10.04.2019 23:20, Max Reitz wrote: >>> What bs->file and bs->backing mean depends on the node. For filter >>> nodes, both signify a node that will eventually receive all R/W >>> accesses. For format

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-17 Thread Paolo Bonzini
On 17/05/19 06:35, Jason Wang wrote: >> Yes, your honor. :)  The helper is the only way for unprivileged users >> to set up TAP networking, which is basically the only really way to have >> *working* network.  It's widely used in the wild, it's self-contained >> and the only alternative for users

Re: [Qemu-devel] [PATCH 3/4] iotests: Test driver whitelisting in 093

2019-05-17 Thread Max Reitz
On 17.05.19 13:00, Kevin Wolf wrote: > Am 17.05.2019 um 11:56 hat Max Reitz geschrieben: >> null-aio may not be whitelisted. If it is not, fall back to null-co. >> This may run tests twice in the same configuration, but this is the >> simplest way to effectively skip the tests in setUp() (without

[Qemu-devel] [PULL SUBSYSTEM v2 s390x 00/40] s390x/tcg: s390x/tcg: Vector Instruction Support Part 2

2019-05-17 Thread David Hildenbrand
This pull request is not for master. Hi Cornelia, This time a signed pull request :) The following changes since commit 85fa94e16927af2717093e5b8fe225206ec39e16: s390/css: handle CCW_FLAG_SKIP (2019-05-17 08:16:02 +0200) are available in the Git repository at:

Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

2019-05-17 Thread Igor Mammedov
On Fri, 17 May 2019 08:51:14 +0800 Wei Yang wrote: > Pointed out by Philippe Mathieu-Daudé . > > Signed-off-by: Wei Yang > --- > hw/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig > index 7265843cc3..7c59cf900b 100644 >

[Qemu-devel] [Bug 1824853] Re: 4.0.0-rc3 crashes with tcg/tcg.c:3952: tcg_gen_code: Assertion `s->gen_insn_end_off[num_insns] == off' failed

2019-05-17 Thread Alex Bennée
** Tags added: testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824853 Title: 4.0.0-rc3 crashes with tcg/tcg.c:3952: tcg_gen_code: Assertion `s->gen_insn_end_off[num_insns] == off' failed

Re: [Qemu-devel] [PATCH v2 4/4] iotests: add iotest 250 for testing blockdev-backup across iothread contexts

2019-05-17 Thread Max Reitz
On 10.05.19 21:03, John Snow wrote: > Signed-off-by: John Snow > --- > tests/qemu-iotests/250 | 129 + > tests/qemu-iotests/250.out | 119 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 249 insertions(+) >

Re: [Qemu-devel] [PATCH 1/4] iotests: Add -display none to the qemu options

2019-05-17 Thread Alex Bennée
Max Reitz writes: > Without this argument, qemu will print an angry message about not being > able to connect to a display server if $DISPLAY is not set. For me, > that breaks iotests.supported_formats() because it thus only sees > ["Could", "not", "connect"] as the supported formats. > >

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-17 Thread Philippe Mathieu-Daudé
On Fri, May 17, 2019 at 11:30 AM Jakub Jermar wrote: > > Hi Aleksandar and Philippe, > > On 5/16/19 8:04 PM, Aleksandar Markovic wrote: [...] > > I tested Jakub's scenario too, it works as expected, but I am not > > concerned about it as much as about regression tests. Knowing that you > > have

Re: [Qemu-devel] [PATCH v2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-17 Thread Igor Mammedov
On Fri, 17 May 2019 08:43:24 +0800 Wei Yang wrote: > build_append_foo() API doesn't need explicit endianness conversions > which eliminates a source of errors and it makes build_mcfg() look like > declarative definition of MCFG table in ACPI spec, which makes it easy > to review. > >

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-17 Thread Igor Mammedov
On Fri, 17 May 2019 10:59:03 +0800 Wei Yang wrote: > On Thu, May 16, 2019 at 08:53:04PM +0200, Philippe Mathieu-Daudé wrote: > >On Thu, May 16, 2019 at 8:33 PM Philippe Mathieu-Daudé > > wrote: > >> On 5/16/19 6:04 PM, Peter Maydell wrote: > >> > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin

[Qemu-devel] [Bug 1829498] [NEW] window 8 stuck during boot on Qemu

2019-05-17 Thread arseniy
Public bug reported: Description of problem: I've got windows 8 image(64 bit), installed on Qemu(x86-64_softmmu) and then i'm trying to boot/shutdown it in the same Qemu configuration. Windows 8 has feature - when you click "Shutdown" in UI, windows 8 doesn't actually power off, it goes to

Re: [Qemu-devel] [PATCH v2 00/16] hw: Use object_initialize_child for correct reference counting

2019-05-17 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 5/7/19 6:34 PM, Philippe Mathieu-Daudé wrote: > Hi, > > This series looks at Eduardo suggestions from [1] > and Thomas commit aff39be0ed97 to replace various > object_initialize + qdev_set_parent_bus calls by > sysbus_init_child_obj(). Do you think you can take this series? Else,

Re: [Qemu-devel] [PATCH 3/4] iotests: Test driver whitelisting in 093

2019-05-17 Thread Kevin Wolf
Am 17.05.2019 um 11:56 hat Max Reitz geschrieben: > null-aio may not be whitelisted. If it is not, fall back to null-co. > This may run tests twice in the same configuration, but this is the > simplest way to effectively skip the tests in setUp() (without changing > the output, and while having

[Qemu-devel] [PULL SUBSYSTEM s390x 00/40] s390x/tcg: s390x/tcg: Vector Instruction Support Part 2

2019-05-17 Thread David Hildenbrand
This pull request is not for master. Hi Cornelia, The following changes since commit 85fa94e16927af2717093e5b8fe225206ec39e16: s390/css: handle CCW_FLAG_SKIP (2019-05-17 08:16:02 +0200) are available in the Git repository at: https://github.com/davidhildenbrand/qemu.git

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-05-17 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 17 May 2019 09:41 > To: Shameerali Kolothum Thodi > Cc: peter.mayd...@linaro.org; sa...@linux.intel.com; > shannon.zha...@gmail.com; ard.biesheu...@linaro.org; > qemu-devel@nongnu.org; Linuxarm ; >

[Qemu-devel] [PULL SUBSYSTEM s390x 03/40] s390x/tcg: Implement VECTOR ADD WITH CARRY

2019-05-17 Thread David Hildenbrand
Only slightly ugly, perform two additions. At least it is only supported for 128 bit elements. Introduce gen_gvec128_4_i64() similar to gen_gvec128_3_i64(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++

Re: [Qemu-devel] [PULL v2 00/21] Misc patches for 2019-05-15

2019-05-17 Thread Peter Maydell
On Fri, 17 May 2019 at 05:02, Paolo Bonzini wrote: > > The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into > staging (2019-05-14 10:08:47 +0100) > > are available in the git repository at: > > >

[Qemu-devel] [Bug 1825311] Re: mips_cpu_handle_mmu_fault renders all accessed pages executable

2019-05-17 Thread Alex Bennée
** Tags added: testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825311 Title: mips_cpu_handle_mmu_fault renders all accessed pages executable Status in QEMU: In Progress Bug

[Qemu-devel] [PULL SUBSYSTEM s390x 04/40] s390x/tcg: Implement VECTOR ADD WITH CARRY COMPUTE CARRY

2019-05-17 Thread David Hildenbrand
Similar to VECTOR ADD COMPUTE CARRY, however 128-bit handling only. Courtesy of Richard H. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 32 2 files changed, 34

[Qemu-devel] [PULL SUBSYSTEM s390x 07/40] s390x/tcg: Implement VECTOR AVERAGE LOGICAL

2019-05-17 Thread David Hildenbrand
Similar to VECTOR AVERAGE but without sign extension. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 48 +

[Qemu-devel] [PULL SUBSYSTEM s390x 05/40] s390x/tcg: Implement VECTOR AND (WITH COMPLEMENT)

2019-05-17 Thread David Hildenbrand
Easy, as we can reuse existing gvec helpers. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 14 ++ 2 files changed, 18 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PULL SUBSYSTEM s390x 10/40] s390x/tcg: Implement VECTOR COMPARE *

2019-05-17 Thread David Hildenbrand
To carry out the comparison, we can reuse the existing gvec comparison function. In case the CC is to be computed, save the result vector and compute the CC lazily. The result is a vector consisting of all 1's for elements that matched and 0's for elements that didn't match. Reviewed-by: Richard

[Qemu-devel] [PULL SUBSYSTEM s390x 01/40] s390x/tcg: Implement VECTOR ADD

2019-05-17 Thread David Hildenbrand
Introduce two types of fancy new helpers that will be reused a couple of times 1. gen_gvec_fn_3: Call an existing tcg_gen_gvec_X function with 3 parameters, simplifying parameter passing 2. gen_gvec128_3_i64: Call a function that performs 128 bit calculations using two 64 bit values per

[Qemu-devel] [PULL SUBSYSTEM s390x 11/40] s390x/tcg: Implement VECTOR COUNT LEADING ZEROS

2019-05-17 Thread David Hildenbrand
For 8/16, use the 32 bit variant and properly subtract the added leading zero bits. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 31

[Qemu-devel] [PULL SUBSYSTEM s390x 02/40] s390x/tcg: Implement VECTOR ADD COMPUTE CARRY

2019-05-17 Thread David Hildenbrand
128-bit handling courtesy of Richard H. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 + target/s390x/translate_vx.inc.c | 98 + 2 files changed, 100 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-05-17 Thread Vladimir Sementsov-Ogievskiy
16.05.2019 22:03, John Snow wrote: > > > On 5/16/19 6:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.05.2019 23:19, John Snow wrote: >>> Shift from looking at every root BDS to *every* BDS. This will migrate >>> bitmaps that are attached to blockdev created nodes instead of just ones >>>

[Qemu-devel] [PULL SUBSYSTEM s390x 16/40] s390x/tcg: Implement VECTOR LOAD POSITIVE

2019-05-17 Thread David Hildenbrand
Similar to VECTOR LOAD COMPLEMENT. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 13 + 2 files changed, 15 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PULL SUBSYSTEM s390x 12/40] s390x/tcg: Implement VECTOR COUNT TRAILING ZEROS

2019-05-17 Thread David Hildenbrand
Implement it similar to VECTOR COUNT LEADING ZEROS. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 28

[Qemu-devel] [PULL SUBSYSTEM s390x 18/40] s390x/tcg: Implement VECTOR MULTIPLY AND ADD *

2019-05-17 Thread David Hildenbrand
Quite some variants to handle. At least handle some 32-bit element variants via gvec expansion (we could also handle 16/32-bit variants for ODD and EVEN easily via gvec expansion, but let's keep it simple for now). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PULL SUBSYSTEM s390x 06/40] s390x/tcg: Implement VECTOR AVERAGE

2019-05-17 Thread David Hildenbrand
Handle 32/64-bit elements via gvec expansion and the 8/16 bits via ool helpers. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/Makefile.objs | 2 +- target/s390x/helper.h | 4 +++ target/s390x/insn-data.def | 2 ++

[Qemu-devel] [PULL SUBSYSTEM s390x 08/40] s390x/tcg: Implement VECTOR CHECKSUM

2019-05-17 Thread David Hildenbrand
Time to introduce read_vec_element_i32 and write_vec_element_i32. Take proper care of properly adding the carry. We can perform both additions including the carry via tcg_gen_add2_i32(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 +

[Qemu-devel] [PULL SUBSYSTEM s390x 13/40] s390x/tcg: Implement VECTOR EXCLUSIVE OR

2019-05-17 Thread David Hildenbrand
Easy, we can reuse an existing gvec helper. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PULL SUBSYSTEM s390x 23/40] s390x/tcg: Implement VECTOR OR

2019-05-17 Thread David Hildenbrand
Reuse a gvec helper. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PULL SUBSYSTEM s390x 19/40] s390x/tcg: Implement VECTOR MULTIPLY *

2019-05-17 Thread David Hildenbrand
Yet another set of variants. Implement it similar to VECTOR MULTIPLY AND ADD *. At least for one variant we have a gvec helper we can reuse. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 16 + target/s390x/insn-data.def | 14

[Qemu-devel] [PULL SUBSYSTEM s390x 09/40] s390x/tcg: Implement VECTOR ELEMENT COMPARE *

2019-05-17 Thread David Hildenbrand
Fairly easy to implement, we can make use of the existing CC helpers cmps64 and cmpu64 - we siply have to sign extend the elements. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 20

[Qemu-devel] [PULL SUBSYSTEM s390x 15/40] s390x/tcg: Implement VECTOR LOAD COMPLEMENT

2019-05-17 Thread David Hildenbrand
We can reuse an existing gvec helper for negating the values. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 16 2 files changed, 18 insertions(+) diff --git

[Qemu-devel] [PULL SUBSYSTEM s390x 25/40] s390x/tcg: Implement VECTOR POPULATION COUNT

2019-05-17 Thread David Hildenbrand
Similar to VECTOR COUNT TRAILING ZEROES. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 19 +++ target/s390x/vec_int_helper.c | 14

[Qemu-devel] [PULL SUBSYSTEM s390x 20/40] s390x/tcg: Implement VECTOR NAND

2019-05-17 Thread David Hildenbrand
Part of vector enhancements facility 1, but easy to implement. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate.c| 1 + target/s390x/translate_vx.inc.c | 7 +++ 3 files changed, 10 insertions(+) diff

[Qemu-devel] [PULL SUBSYSTEM s390x 14/40] s390x/tcg: Implement VECTOR GALOIS FIELD MULTIPLY SUM (AND ACCUMULATE)

2019-05-17 Thread David Hildenbrand
A galois field multiplication in field 2 is like binary multiplication, however instead of doing ordinary binary additions, xor's are performed. So no carries are considered. Implement all variants via helpers. s390_vec_sar() and s390_vec_shr() will be reused later on. Reviewed-by: Richard

[Qemu-devel] [PULL SUBSYSTEM s390x 21/40] s390x/tcg: Implement VECTOR NOR

2019-05-17 Thread David Hildenbrand
Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index bc8b84e1c2..4983867a44 100644 ---

[Qemu-devel] [PULL SUBSYSTEM s390x 17/40] s390x/tcg: Implement VECTOR (MAXIMUM|MINIMUM) (LOGICAL)

2019-05-17 Thread David Hildenbrand
Luckily, we already have gvec helpers for all four cases. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 8 target/s390x/translate_vx.inc.c | 31 +++ 2 files changed, 39 insertions(+) diff --git

[Qemu-devel] [PULL SUBSYSTEM s390x 27/40] s390x/tcg: Implement VECTOR ELEMENT ROTATE AND INSERT UNDER MASK

2019-05-17 Thread David Hildenbrand
Use the new vector expansion for GVecGen3i. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 51 +

[Qemu-devel] [PULL SUBSYSTEM s390x 26/40] s390x/tcg: Implement VECTOR ELEMENT ROTATE LEFT LOGICAL

2019-05-17 Thread David Hildenbrand
Take care of properly taking the modulo of the count. We might later want to come back and create a variant of VERLL where the base register is 0, resulting in an immediate. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 +++

[Qemu-devel] [PULL SUBSYSTEM s390x 24/40] s390x/tcg: Implement VECTOR OR WITH COMPLEMENT

2019-05-17 Thread David Hildenbrand
Again, vector enhancements facility 1 material. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def

Re: [Qemu-devel] [PATCH 1/4] iotests: Add -display none to the qemu options

2019-05-17 Thread Thomas Huth
On 17/05/2019 11.56, Max Reitz wrote: > Without this argument, qemu will print an angry message about not being > able to connect to a display server if $DISPLAY is not set. For me, > that breaks iotests.supported_formats() because it thus only sees > ["Could", "not", "connect"] as the supported

[Qemu-devel] [PULL SUBSYSTEM s390x 22/40] s390x/tcg: Implement VECTOR NOT EXCLUSIVE OR

2019-05-17 Thread David Hildenbrand
Again, part of vector enhancement facility 1. The operation corresponds to an bitwise equality check. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff

[Qemu-devel] [PULL SUBSYSTEM s390x 30/40] s390x/tcg: Implement VECTOR SHIFT LEFT DOUBLE BY BYTE

2019-05-17 Thread David Hildenbrand
Inline expansion courtesy of Richard H. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 29 + 2 files changed, 31 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PULL SUBSYSTEM s390x 31/40] s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC

2019-05-17 Thread David Hildenbrand
Similar to VECTOR SHIFT LEFT ARITHMETIC. Add s390_vec_sar() similar to s390_vec_shr(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 17 +

[Qemu-devel] [PULL SUBSYSTEM s390x 32/40] s390x/tcg: Implement VECTOR SHIFT RIGHT LOGICAL *

2019-05-17 Thread David Hildenbrand
Similar to VECTOR SHIFT RIGHT ARITHMETICAL. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 17 + target/s390x/vec_int_helper.c | 6 ++

[Qemu-devel] [PULL SUBSYSTEM s390x 28/40] s390x/tcg: Implement VECTOR ELEMENT SHIFT

2019-05-17 Thread David Hildenbrand
We can use all the fancy new vector helpers implemented by Richard. One important thing to take care of is always to properly mask of unused bits from the shift count. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 9

[Qemu-devel] [PULL SUBSYSTEM s390x 33/40] s390x/tcg: Implement VECTOR SUBTRACT

2019-05-17 Thread David Hildenbrand
We can use tcg_gen_sub2_i64() to do 128-bit subtraction and otherwise existing gvec helpers. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 17 + 2 files changed, 19 insertions(+)

[Qemu-devel] [PULL SUBSYSTEM s390x 29/40] s390x/tcg: Implement VECTOR SHIFT LEFT (BY BYTE)

2019-05-17 Thread David Hildenbrand
We can reuse the existing 128-bit shift utility function. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 20

[Qemu-devel] [PULL SUBSYSTEM s390x 40/40] s390x/tcg: Implement VECTOR TEST UNDER MASK

2019-05-17 Thread David Hildenbrand
Let's return the cc value directly via cpu_env. Unfortunately there isn't a simple way to calculate the value lazily - one would have to calculate and store e.g. the population count of the mask and the result so it can be evaluated in a cc helper. But as VTM only sets the cc, we can assume the

[Qemu-devel] [PULL SUBSYSTEM s390x 35/40] s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW INDICATION

2019-05-17 Thread David Hildenbrand
Fairly easy as only 128-bit handling is required. Simply perform the subtraction and then subtract the borrow. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 26 ++ 2 files

<    1   2   3   >