[Qemu-devel] [PATCH] spapr_pci: Fix DRC owner in spapr_dt_pci_bus()

2019-06-18 Thread Greg Kurz
spapr_dt_drc() scans the aliases of all DRConnector objects and filters the ones that it will use to generate OF properties according to their owner and type. Passing bus->parent_dev _works_ if bus belongs to a PCI bridge, but it is NULL if it is the PHB's root bus. This causes all allocated PCI

Re: [Qemu-devel] [RFC PATCH v2 00/35] Initial support of multi-process qemu

2019-06-18 Thread Daniel P . Berrangé
On Mon, Jun 17, 2019 at 11:14:50AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Initial support of multi-process qemu > > Started with the presentation in October 2017 made by > Marc-Andre (Red Hat) and Konrad Wilk (Oracle) >

Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-18 Thread Daniel P . Berrangé
On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: > From: Kevin Wolf > > The -mon pretty=on|off switch of the -mon option applies only to QMP > monitors. It's silently ignored for HMP. Deprecate this combination so > that we can make it an error in future versions. No objection

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Add in details for GPIO controller for AST 2400 and 2500 I agree. C. > > Signed-off-by: Rashmica Gupta > --- > hw/gpio/Makefile.objs | 1 + > hw/gpio/aspeed_gpio.c | 869 ++ >

Re: [Qemu-devel] [QEMU PATCH v3 8/9] KVM: i386: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Kernel commit c4f55198c7c2 ("kvm: x86: Introduce KVM_CAP_EXCEPTION_PAYLOAD") > introduced a new KVM capability which allows userspace to correctly > distinguish between pending and injected exceptions. > > This distinguish is important in case of

Re: [Qemu-devel] [PATCH 4/4] block: drop bs->job

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:58, Kevin Wolf wrote: > Am 06.06.2019 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Drop remaining users of bs->job: >> 1. assertions actually duplicated by assert(!bs->refcnt) >> 2. trace-point seems not enough reason to change stream_start to return >> BlockJob

Re: [Qemu-devel] [RFC PATCH v2 09/35] multi-process: setup PCI host bridge for remote device

2019-06-18 Thread Gerd Hoffmann
On Mon, Jun 17, 2019 at 11:15:39AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > PCI host bridge is setup for the remote device process. It is > implemented using remote-pcihost object. It is an extension of the PCI > host bridge setup by QEMU. > Remote-pcihost

Re: [Qemu-devel] [PATCH 6/6] xics/kvm: Add proper rollback to xics_kvm_init()

2019-06-18 Thread Cédric Le Goater
On 17/06/2019 15:47, Greg Kurz wrote: > Make xics_kvm_disconnect() able to undo the changes of a partial execution > of xics_kvm_connect() and use it to perform rollback. > > Note that kvmppc_define_rtas_kernel_token(0) never fails, no matter the > RTAS call has been defined or not. > >

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 17:56, Max Reitz wrote: > On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: >> 14.06.2019 23:03, Max Reitz wrote: >>> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: 14.06.2019 15:57, Max Reitz wrote: > On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: >>

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 16:20, Kevin Wolf wrote: > Am 17.06.2019 um 15:09 hat Eric Blake geschrieben: >> On 6/17/19 7:09 AM, Kevin Wolf wrote: >> > > Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on > nbd driver? > I didn't implement it. But may be I should.. >

Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA

2019-06-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 17 June 2019 18:37 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano Stabellini > > Subject: Re: [PATCH 4/4] xen: Avoid VLA > > On Mon, Jun 17, 2019 at

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 09:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.06.2019 16:20, Kevin Wolf wrote: > > Am 17.06.2019 um 15:09 hat Eric Blake geschrieben: > >> On 6/17/19 7:09 AM, Kevin Wolf wrote: > >> > > > > Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called >

[Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
We need to check ram_end, not ram_size. Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or DTB off the end of RAM") Signed-off-by: Andrew Jones --- hw/arm/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index

Re: [Qemu-devel] [PATCH] target/ppc: fix compile error in kvmppc_define_rtas_kernel_token()

2019-06-18 Thread David Gibson
On Sat, Jun 15, 2019 at 10:12:52AM +0200, Cédric Le Goater wrote: > gcc9 reports : > > In file included from /usr/include/string.h:494, > from ./include/qemu/osdep.h:101, > from ./target/ppc/kvm.c:17: > In function ‘strncpy’, > inlined from

Re: [Qemu-devel] [QEMU PATCH v3 4/9] KVM: i386: Block migration for vCPUs exposed with nested virtualization

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") > added a migration blocker for vCPU exposed with Intel VMX. > However, migration should also be blocked for vCPU exposed with > AMD SVM. > > Both cases should be blocked because QEMU

[Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Rashmica Gupta
Add in details for GPIO controller for AST 2400 and 2500 Signed-off-by: Rashmica Gupta --- hw/gpio/Makefile.objs | 1 + hw/gpio/aspeed_gpio.c | 869 ++ include/hw/gpio/aspeed_gpio.h | 76 +++ 3 files changed, 946 insertions(+) create mode

Re: [Qemu-devel] [RFC PATCH v2 20/35] multi-process: Add QMP & extend HMP commands to list remote info

2019-06-18 Thread Stefan Hajnoczi
On Mon, Jun 17, 2019 at 7:28 PM wrote: > > From: Jagannathan Raman > > Add query-remote QMP command and extend "info" HMP command, to list > the remote objects used by QEMU. > > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > --- >

Re: [Qemu-devel] [PATCH v2 21/21] aspeed: vic: Add support for legacy register interface

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:55, Cédric Le Goater wrote: > > From: Andrew Jeffery > > The legacy interface only supported up to 32 IRQs, which became > restrictive around the AST2400 generation. QEMU support for the SoCs > started with the AST2400 along with an effort to reimplement and > upstream

Re: [Qemu-devel] [PATCH v2 11/21] aspeed/timer: Ensure positive muldiv delta

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:54, Cédric Le Goater wrote: > > From: Christian Svensson > > If the host decrements the counter register that results in a negative > delta. This is then passed to muldiv64 which only handles unsigned > numbers resulting in bogus results. > > This fix ensures the delta

Re: [Qemu-devel] [PATCH] xics/spapr: Only emulated XICS should use RTAS/hypercalls emulation

2019-06-18 Thread David Gibson
On Mon, Jun 17, 2019 at 01:55:36PM +0200, Greg Kurz wrote: > Checking that we're not using the in-kernel XICS is ok with the "xics" > interrupt controller mode, but it is definitely not enough with the > other modes since the guest could be using XIVE. > > Ensure XIVE is not in use when emulated

Re: [Qemu-devel] [PATCH v3 0/9] Introduce cpu die topology and enable CPUID.1F for i386

2019-06-18 Thread Like Xu
Ping for timely review. On 2019/6/12 16:40, Like Xu wrote: Multi-chip packaging technology allows integration of multi-cores in one die and multi-dies in one single package, for example Intel CLX-AP or AMD EPYC. This patch series extend the CPU topology to the socket/dies/core/thread model,

Re: [Qemu-devel] [PATCH v3 07/50] plugin: add user-facing API

2019-06-18 Thread Pranith Kumar
On Fri, Jun 14, 2019 at 10:24 AM Alex Bennée wrote: > > From: "Emilio G. Cota" > > Add the API first to ease review. > > Signed-off-by: Emilio G. Cota > Signed-off-by: Alex Bennée > > --- > v3 > - merge in changes to plugin install/reset/uninstall > - split api file > --- >

Re: [Qemu-devel] [PATCH v3 05/50] docs/devel: add plugins.rst design document

2019-06-18 Thread Pranith Kumar
Hi, On Fri, Jun 14, 2019 at 10:21 AM Alex Bennée wrote: > > This is mostly extracted from Emilio's more verbose commit comments > with some additional verbiage from me. > > Signed-off-by: Alex Bennée > --- > docs/devel/index.rst | 1 + > docs/devel/plugins.rst | 99

Re: [Qemu-devel] [PATCH v3 22/50] *-user: plugin syscalls

2019-06-18 Thread Pranith Kumar
Minor nits. On Fri, Jun 14, 2019 at 11:41 AM Alex Bennée wrote: > > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > bsd-user/syscall.c | 9 + > linux-user/syscall.c | 3 +++ > 2 files changed, 12 insertions(+) > > diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-18 Thread Mark Cave-Ayland
On 18/06/2019 06:00, Richard Henderson wrote: > Ping. Otherwise I'll include it in my next tcg pull. > > r~ I can give this another spin on my test images on a G4 over the next few days. I've also added Howard on CC as he reported some issues with the previous iteration at

[Qemu-devel] [RISU RFC PATCH v1 7/7] x86.risu: add SSE2 instructions

2019-06-18 Thread Jan Bobek
Add all SSE2 instructions to the x86 configuration file. Signed-off-by: Jan Bobek --- x86.risu | 160 --- 1 file changed, 153 insertions(+), 7 deletions(-) diff --git a/x86.risu b/x86.risu index cc40bbc..b3e4c88 100644 --- a/x86.risu +++

Re: [Qemu-devel] [PATCH v2 05/21] aspeed: introduce a configurable number of CPU per machine

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:54, Cédric Le Goater wrote: > > The current models of the Aspeed SoCs only have one CPU but future > ones will support SMP. Introduce a new num_cpus field at the SoC class > level to define the number of available CPUs per SoC and also > introduce a 'num-cpus' property

Re: [Qemu-devel] [PATCH v2 06/21] aspeed: add support for multiple NICs

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:54, Cédric Le Goater wrote: > > The Aspeed SoCs have two MACs. Extend the Aspeed model to support a > second NIC. > > Signed-off-by: Cédric Le Goater > --- > include/hw/arm/aspeed_soc.h | 3 ++- > hw/arm/aspeed_soc.c | 33 +++-- > 2

[Qemu-devel] [PATCH v3 5/6] hw/arm: Add the STM32F4xx SoC

2019-06-18 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- MAINTAINERS| 8 ++ hw/arm/Kconfig | 3 + hw/arm/Makefile.objs | 1 + hw/arm/stm32f405_soc.c | 301 + include/hw/arm/stm32f405_soc.h

[Qemu-devel] [RISU RFC PATCH v1 4/7] risugen_x86: add module

2019-06-18 Thread Jan Bobek
The risugen_x86.pm module contains most of the code specific to Intel i386 and x86_64 architectures. This commit also adds --x86_64 option, which enables emission of 64-bit (rather than 32-bit) assembly. Signed-off-by: Jan Bobek --- risugen| 6 +- risugen_x86.pm | 455

[Qemu-devel] [RISU RFC PATCH v1 0/7] Support for generating x86 SSE/SSE2 test images

2019-06-18 Thread Jan Bobek
Hi all, this is v1 of my changes to risugen in order to support generating x86 test images. It's still work-in-progress (thus marked RFC; notably, there is no support for AVX yet), but I would like to get this out there to get some early feedback on my approach. Initially, I thought adding

[Qemu-devel] [RISU RFC PATCH v1 5/7] risugen: allow all byte-aligned instructions

2019-06-18 Thread Jan Bobek
Accept all instructions whose bit length is divisible by 8. Note that the maximum instruction length (as specified in the config file) is 32 bits, hence this change permits instructions which are 8 bits or 24 bits long (16-bit instructions have already been considered valid). Note that while

Re: [Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-06-18 Thread Alistair Francis
On Sun, May 5, 2019 at 8:34 AM Peter Maydell wrote: > > On Sat, 4 May 2019 at 06:26, Alistair Francis wrote: > > Ah, it seems like -device loader doesn't work, it looks like not > > setting the thumb register causes this core dump: > > > > qemu: fatal: Lockup: can't escalate 3 to HardFault

Re: [Qemu-devel] [PATCH] migration: Improve accuracy of vCPU throttling with per-vCPU timers

2019-06-18 Thread Peter Xu
On Tue, Jun 18, 2019 at 04:52:09PM +, Cosmin Marin wrote: > > > On 18/06/2019, 15:51, "Peter Xu" wrote: > > On Tue, Jun 18, 2019 at 12:25:43PM +, Cosmin Marin wrote: > > Hi Peter, > > > > thanks for reviewing the patch. Indeed, I agree that it's >

Re: [Qemu-devel] [PATCH v2 08/21] aspeed/timer: Status register contains reload for stopped timer

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:54, Cédric Le Goater wrote: > > From: Andrew Jeffery > > From the datasheet: > > This register stores the current status of counter #N. When timer > enable bit TMC30[N * b] is disabled, the reload register will be > loaded into this counter. When timer bit TMC30[N

Re: [Qemu-devel] [PATCH v2 19/21] aspeed: Add support for the swift-bmc board

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 16:55, Cédric Le Goater wrote: > > From: Adriana Kobylak > > The Swift board is an OpenPOWER system hosting POWER processors. > Add support for their BMC including the I2C devices as found on HW. > > Signed-off-by: Adriana Kobylak > Reviewed-by: Cédric Le Goater

[Qemu-devel] [PATCH v3 3/6] hw/misc: Add the STM32F4xx Sysconfig device

2019-06-18 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- default-configs/arm-softmmu.mak| 1 + hw/arm/Kconfig | 9 ++ hw/misc/Kconfig| 3 + hw/misc/Makefile.objs | 1 + hw/misc/stm32f4xx_syscfg.c | 168

[Qemu-devel] [PATCH v3 4/6] hw/misc: Add the STM32F4xx EXTI device

2019-06-18 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + hw/misc/Kconfig | 3 + hw/misc/Makefile.objs| 1 + hw/misc/stm32f4xx_exti.c | 187 +++ hw/misc/trace-events

[Qemu-devel] [PATCH v3 1/6] armv7m: Allow entry information to be returned

2019-06-18 Thread Alistair Francis
Allow the kernel's entry point information to be returned when loading a kernel. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 4 +++- include/hw/arm/boot.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index

[Qemu-devel] [PATCH v3 0/6] Add the STM32F405 and Netduino Plus 2 machine

2019-06-18 Thread Alistair Francis
Now that the Arm-M4 CPU has been added to QEMU we can add the Netduino Plus 2 machine. This is very similar to the STM32F205 and Netduino 2 SoC and machine. v3: - Remove custom reset handler - Add init-entry and init-sp properties - Rebase on master (including Kconfig changes) v2: - Reorder

[Qemu-devel] [PATCH v3 2/6] target/arm: Allow setting M mode entry and sp

2019-06-18 Thread Alistair Francis
Add M mode initial entry PC and SP properties. Signed-off-by: Alistair Francis --- target/arm/cpu.c | 47 +++ target/arm/cpu.h | 3 +++ 2 files changed, 50 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 376db154f0..1d83972ab1

[Qemu-devel] [PATCH v3 6/6] hw/arm: Add the Netduino Plus 2

2019-06-18 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS| 6 ++ hw/arm/Kconfig | 3 +++ hw/arm/Makefile.objs | 1 + hw/arm/netduinoplus2.c | 58 ++ 4 files changed, 68 insertions(+) create mode 100644 hw/arm/netduinoplus2.c

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 4/5] roms: Add OpenSBI version 0.3

2019-06-18 Thread Anup Patel
On Wed, Jun 19, 2019 at 6:24 AM Alistair Francis wrote: > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > Signed-off-by: Alistair Francis > --- > .gitmodules | 3 +++ > Makefile| 3 ++- > configure

[Qemu-devel] [Bug 1832535] Re: [riscv/regression] Missing tlb flush introduced in refactoring

2019-06-18 Thread Alistair Francis
Hello, Thanks for reporting a bug. Can you please include details to reproduce the problems that you are seeing? This includes images and command line arguments. Do you also mind including the diff of what fixes the problem for you? Alistair ** Changed in: qemu Status: New =>

Re: [Qemu-devel] [PATCH v3 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-06-18 Thread Tao Xu
On 6/17/2019 11:39 AM, Xiaoyao Li wrote: On 6/16/2019 11:35 PM, Tao Xu wrote: UMWAIT and TPAUSE instructions use IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load

Re: [Qemu-devel] Recent python-sphinx errors out building doc

2019-06-18 Thread Bruce Rogers
>>> On 6/18/2019 at 6:11 PM, John Snow wrote: > > On 6/18/19 7:37 PM, Bruce Rogers wrote: >> Hi, >> >> (Resent with correct address for John) >> I build recent upstream qemu in the openSUSE Build Service, and for >> the Factory repository there, python-sphinx was recently updated to >> version

[Qemu-devel] [RISU RFC PATCH v1 1/7] risugen_common: add insnv, randint_constr, rand_fill

2019-06-18 Thread Jan Bobek
Add three common utility functions: - insnv allows emitting variable-length instructions in little-endian or big-endian byte order; it subsumes functionality of former insn16() and insn32() functions. - randint_constr allows generating random integers according to several constraints

[Qemu-devel] [RISU RFC PATCH v1 2/7] risugen_x86_asm: add module

2019-06-18 Thread Jan Bobek
The module risugen_x86_asm.pm exports several constants and the function write_insn, which work in tandem to allow emission of x86 instructions in more clear and structured manner. Signed-off-by: Jan Bobek --- risugen_x86_asm.pm | 186 + 1 file

[Qemu-devel] [RISU RFC PATCH v1 3/7] risugen_x86_emit: add module

2019-06-18 Thread Jan Bobek
The helper module risugen_x86_emit.pm exports a single function "parse_emitblock", which serves to capture and return instruction constraints described by "emit" blocks in an x86 configuration file. Signed-off-by: Jan Bobek --- risugen | 2 +- risugen_x86_emit.pm | 85

[Qemu-devel] [RISU RFC PATCH v1 6/7] x86.risu: add SSE instructions

2019-06-18 Thread Jan Bobek
Add an x86 configuration file with all SSE instructions. Signed-off-by: Jan Bobek --- x86.risu | 99 1 file changed, 99 insertions(+) create mode 100644 x86.risu diff --git a/x86.risu b/x86.risu new file mode 100644 index

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 5/5] hw/riscv: Load OpenSBI as the default firmware

2019-06-18 Thread Anup Patel
On Wed, Jun 19, 2019 at 6:21 AM Alistair Francis wrote: > > If the user hasn't specified a firmware to load (with -bios) or > specified no bios (with -bios none) then load OpenSBI by default. This > allows users to boot a RISC-V kernel with just -kernel. > > Signed-off-by: Alistair Francis > ---

Re: [Qemu-devel] [PATCH] spapr_pci: Fix DRC owner in spapr_dt_pci_bus()

2019-06-18 Thread David Gibson
On Tue, Jun 18, 2019 at 10:42:53AM +0200, Greg Kurz wrote: > spapr_dt_drc() scans the aliases of all DRConnector objects and filters > the ones that it will use to generate OF properties according to their > owner and type. > > Passing bus->parent_dev _works_ if bus belongs to a PCI bridge, but

Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 11:01 hat Daniel P. Berrangé geschrieben: > On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: > > From: Kevin Wolf > > > > The -mon pretty=on|off switch of the -mon option applies only to QMP > > monitors. It's silently ignored for HMP. Deprecate this

[Qemu-devel] [PATCH v2] qemu-ga: Convert invocation documentation to rST

2019-06-18 Thread Peter Maydell
The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 10:35:05AM +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Vadim Rozenfeld
On Tue, 2019-06-18 at 10:35 +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at 11:23:01AM

[Qemu-devel] [PATCH v2 2/4] xen: Import other xen/io/*.h

2019-06-18 Thread Anthony PERARD
Following "xen: Fix build with public headers", import other Xen public headers that are describing interfaces. Import fbif.h, kbdif.h, netif.h, console.h, xenbus.h, protocols.h. While editing xenfb.c, remove the include of event_channel.h as it isn't needed. The headers are cleaned up a bit

[Qemu-devel] [PATCH v2 1/4] xen: Fix build with public headers

2019-06-18 Thread Anthony PERARD
Following 37677d7db3 "Clean up a few header guard symbols", QEMU start to fail to build: In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0, from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5, from

[Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA

2019-06-18 Thread Anthony PERARD
Avoid using a variable length array. We allocate the `dirty_bitmap' buffer only once when we start tracking for dirty bits. Signed-off-by: Anthony PERARD --- Notes: v2: - Allocate the bitmap buffer only once when we start tracking dirty bits. (instead of at every function call)

[Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-18 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Use

Re: [Qemu-devel] [PATCH 0/2] Add Aspeed GPIO controller model

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Hi, > > These two patches add a bunch of the functionality of the ast2400 and > ast2500 gpio controllers. > > This is based off upstream/master with two of Cédric's patches: > - aspeed: add a per SoC mapping for the interrupt space > - aspeed: add a

[Qemu-devel] [Bug 1833204] [NEW] VM failed to start in nested virtualization with error "KVM: entry failed, hardware error 0x0"

2019-06-18 Thread Wei, Yu
Public bug reported: Hi, I have 3 ubuntu nodes provisioned by IaaS. Then I tried to launch VM again in my ubuntu nodes. It's a little strange that VM could be started successfully in two nodes. And always failed in one nodes with error "KVM: entry failed, hardware error 0x0". When using

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > We need to check ram_end, not ram_size. > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or > DTB off the end of RAM") > Signed-off-by: Andrew Jones > --- > hw/arm/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH] i386: make 'hv-spinlocks' a regular uint32 property

2019-06-18 Thread Roman Kagan
X86CPU.hv-spinlocks is a uint32 property that has a special setter validating the value to be no less than 0xFFF and no bigger than UINT_MAX. The latter check is redundant; as for the former, there appears to be no reason to prohibit the user from setting it to a lower value. So nuke the

[Qemu-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup

2019-06-18 Thread Anthony PERARD
Hi, Fix the build in osstest and some cleanup For reference: Recent flight failure: https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01022.html Bisect result: https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01029.html Thanks. Anthony PERARD (4): xen: Fix

[Qemu-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h

2019-06-18 Thread Anthony PERARD
xen-mapcache.c doesn't needs params.h. xen-hvm.c uses defines available in params.h but so is xen_common.h which is included before. HVM_PARAM_* flags are only needed to make xc_hvm_param_{get,set} calls so including only xenctrl.h, which is where the definition the function is, should be enough.

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2019-06-18 Thread Igor Mammedov
On Mon, 17 Jun 2019 13:27:00 -0300 Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jun 2019 17:15:21 +0200 > > Philippe Mathieu-Daudé wrote: > [...] > > > Yes. Eduardo and you should write some lines to explain this, and then > > > we

Re: [Qemu-devel] [PATCH 2/2] aspeed: add a GPIO controller to the SoC

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Signed-off-by: Rashmica Gupta > --- > hw/arm/aspeed_soc.c | 17 + > include/hw/arm/aspeed_soc.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c > index

Re: [Qemu-devel] [PATCH v4 1/5] net/announce: Allow optional list of interfaces

2019-06-18 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Allow the caller to restrict the set of interfaces that announces are > > sent on. The default is still to send on all interfaces. > > > > e.g. > >

Re: [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault

2019-06-18 Thread Peter Maydell
On Mon, 17 Jun 2019 at 20:28, Richard Henderson wrote: > > On 6/17/19 10:53 AM, Peter Maydell wrote: > > + * The HardFault is Secure if BFHFNMINS is 0 (meaning that all HFs are > > + * secure); otherwise it targets the same security state as the > > + * underlying exception. > >

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > > > On Mon, Jun 17, 2019 at

Re: [Qemu-devel] [PULL v2 00/16] Monitor patches for 2019-06-17

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 07:29, Markus Armbruster wrote: > > The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' > into staging (2019-06-17 16:41:25 +0100) > > are available in the Git repository

Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c

2019-06-18 Thread Anthony PERARD
On Tue, Jun 18, 2019 at 08:55:53AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > > > On Mon, Jun 17, 2019 at 05:45:44PM +0100, Anthony PERARD wrote: > > > On Mon, Jun 17, 2019 at 05:15:51PM +0100, Paul Durrant wrote: > >

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:02 PM, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: >> >> We need to check ram_end, not ram_size. >> >> Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or >> DTB off the end of RAM") >> Signed-off-by: Andrew Jones Reviewed-by:

Re: [Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:23 PM, Anthony PERARD wrote: > Avoid using a variable length array. > > We allocate the `dirty_bitmap' buffer only once when we start tracking > for dirty bits. > Suggested-by: Paul Durrant Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Anthony PERARD > --- > > Notes: >

Re: [Qemu-devel] [PATCH v5 5/8] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This initializes the GED device with base memory and irq, configures > ged memory hotplug event and builds the corresponding aml code. With > this, both hot and cold plug of device memory is enabled now for Guest > with ACPI boot. > >

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 12:58:30PM +0100, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > > > > > We need to check ram_end, not

[Qemu-devel] [Bug 1833101] Re: vexpress-a9 (but not -a15) creates two pl111 LCDs due to duplicate sysbus_create_simple("pl111", ...) calls

2019-06-18 Thread David Lindsay
Ah. :) As is probably somewhat evident at this point, I'm using vexpress-a9 because it's such a convenient QEMU target, rather than because I have real hardware anywhere. Hm, I didn't once stop and think that maybe there actually were two LCD controllers. (And this is where software is great; I

Re: [Qemu-devel] [PATCH v5 8/8] hw/arm: Use GED for system_powerdown event

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > Use GED for system_powerdown event instead of GPIO for ACPI. > Guest boot with DT still uses GPIO.> > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Thanks Eric > --- > hw/arm/virt-acpi-build.c | 37

Re: [Qemu-devel] [PATCH v5 0/8] ARM virt: ACPI memory hotplug support

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This series is an attempt to provide device memory hotplug support > on ARM virt platform. This is based on Eric's recent works here[1] > and carries some of the pc-dimm related patches dropped from his > series. > > The kernel support

Re: [Qemu-devel] [PATCH v5 0/8] ARM virt: ACPI memory hotplug support

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 13:52, Auger Eric wrote: > Feel free to add my T-b on next version: > Tested-by: Eric Auger I'm not sure we should carry across Tested-by tags like that: any respin might accidentally introduce bugs that make it stop working... thanks -- PMM

[Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot with initrd

2019-06-18 Thread Andrew Jones
Fix the condition used to check whether the initrd fits into RAM; in some cases if an initrd was also passed on the command line we would get an error stating that it was too big to fit into RAM after the kernel. Despite the error the loader continued anyway, though, so also add an exit(1) when

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 02:50:15PM +0200, Andrew Jones wrote: > On Tue, Jun 18, 2019 at 12:58:30PM +0100, Peter Maydell wrote: > > On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > > > > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > > > On Tue, 18 Jun 2019 at 09:34,

[Qemu-devel] [Bug 1833101] Re: vexpress-a9 (but not -a15) creates two pl111 LCDs due to duplicate sysbus_create_simple("pl111", ...) calls

2019-06-18 Thread Peter Maydell
You might want to check our advice on how to pick a machine type for Arm: https://wiki.qemu.org/Documentation/Platforms/ARM#Guidelines_for_choosing_a_QEMU_machine Basically we suggest 'virt' unless you have a strong reason for wanting to emulate something else. NB that we don't support PCI in

Re: [Qemu-devel] [PATCH v5 25/42] mirror: Deal with filters

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > This includes some permission limiting (for example, we only need to > take the RESIZE permission for active commits where the base is smaller > than the top). > > Signed-off-by: Max Reitz ohm, unfortunately I'm far from knowing block/mirror mechanics and

Re: [Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-18 Thread Max Reitz
On 18.06.19 11:24, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for known_hosts handling > -

[Qemu-devel] [PATCH v7 7/9] qemu/units: add SI decimal units

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/units.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu/units.h b/include/qemu/units.h index 692db3fbb2..52ccc7445c 100644 --- a/include/qemu/units.h +++ b/include/qemu/units.h @@ -17,4 +17,11 @@ #define PiB

[Qemu-devel] [PATCH v7 1/9] block/nbd: split connection_co start out of nbd_client_connect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
nbd_client_connect is going to be used from connection_co, so, let's refactor nbd_client_connect in advance, leaving io channel configuration all in nbd_client_connect. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd.c | 22 +- 1 file

[Qemu-devel] [PATCH v7 6/9] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Introduce a function to gracefully wake a coroutine sleeping in qemu_co_sleep_ns(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/coroutine.h| 17 -- block/null.c| 2 +- block/sheepdog.c| 2 +- tests/test-bdrv-drain.c | 6 ++---

[Qemu-devel] [PATCH v7 2/9] block/nbd: use non-blocking io channel for nbd negotiation

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
No reason to use blocking channel for negotiation and we'll benefit in further reconnect feature, as qio_channel reads and writes will do qemu_coroutine_yield while waiting for io completion. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/nbd.h | 3 ++-

[Qemu-devel] [PATCH v7 5/9] block/nbd: refactor nbd connection parameters

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
We'll need some connection parameters to be available all the time to implement nbd reconnect. So, let's refactor them: define additional parameters in BDRVNBDState, drop them from function parameters, drop nbd_client_init and separate options parsing instead from nbd_open. Signed-off-by:

[Qemu-devel] [PATCH v7 0/9] NBD reconnect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is NBD reconnect. Previously, if connection failed all current and future requests will fail. After the series, nbd-client driver will try to reconnect unlimited times. During first @reconnect-delay seconds of reconnecting all requests will wait for the connection, and if it is

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > We need to check ram_end, not ram_size. > > > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or > > DTB off the end of RAM") > > Signed-off-by: Andrew

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > > > We need to check ram_end, not ram_size. > > > > > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put

Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-18 Thread Bastian Koppelmann
On 6/17/19 6:45 PM, Richard Henderson wrote: On 6/17/19 7:35 AM, Bastian Koppelmann wrote: +static void tricore_tr_init_disas_context(DisasContextBase *dcbase, + CPUState *cs) { +DisasContext *ctx = container_of(dcbase, DisasContext, base);

Re: [Qemu-devel] [PATCH v5 24/42] block: Use child access functions for QAPI queries

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > query-block and query-named-block-nodes now return any filtered child > under "backing", not just bs->backing or COW children. This is so that > filters do not interrupt the reported backing chain. This changes the > output for iotest 184, as the throttled

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:55 PM, Andrew Jones wrote: > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: >> On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: >>> >>> We need to check ram_end, not ram_size. >>> >>> Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or >>> DTB off

Re: [Qemu-devel] [PATCH v2 1/4] xen: Fix build with public headers

2019-06-18 Thread Daniel P . Berrangé
On Tue, Jun 18, 2019 at 12:23:38PM +0100, Anthony PERARD wrote: > Following 37677d7db3 "Clean up a few header guard symbols", QEMU start > to fail to build: > > In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0, > from

Re: [Qemu-devel] [PATCH v5 4/8] hw/arm/virt: Add memory hotplug framework

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > From: Eric Auger > > This patch adds the memory hot-plug/hot-unplug infrastructure > in machvirt. The device memory is not yet exposed to the Guest > either through DT or ACPI and hence both cold/hot plug of memory > is explicitly

Re: [Qemu-devel] [PATCH v5 7/8] hw/acpi: Add system power down support to GED

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This adds support to use GED for system power down event. > > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Thanks Eric > --- > hw/acpi/generic_event_device.c | 16 >

<    1   2   3   4   >