Re: [Qemu-devel] [RFC PATCH 0/9] hw/acpi: make build_madt arch agnostic

2019-06-19 Thread Wei Yang
On Tue, Jun 18, 2019 at 05:59:56PM +0200, Igor Mammedov wrote: > >On Mon, 13 May 2019 14:19:04 +0800 >Wei Yang wrote: > >> Now MADT is highly depend in architecture and machine type and leaves >> duplicated code in different architecture. The series here tries to >> generalize >> it. >> >> MADT

[Qemu-devel] [PATCH v2 3/5] tricore: fix RRPW_INSERT instruction

2019-06-19 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 4/5] tricore: add QSEED instruction

2019-06-19 Thread David Brenken
From: Andreas Konopik Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 85 + target/tricore/helper.h | 1 +

Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.06.2019 um 11:01 hat Daniel P. Berrangé geschrieben: >> On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: >> > From: Kevin Wolf >> > >> > The -mon pretty=on|off switch of the -mon option applies only to QMP >> > monitors. It's silently ignored for

[Qemu-devel] [PATCH v2 2/5] tricore: add UTOF instruction

2019-06-19 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski Reviewed-by: Bastian Koppelmann --- target/tricore/fpu_helper.c | 16 target/tricore/helper.h |

[Qemu-devel] [PATCH v2 5/5] tricore: reset DisasContext before generating code

2019-06-19 Thread David Brenken
From: Georg Hofstetter Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/tricore/translate.c

[Qemu-devel] [PATCH v2 1/5] tricore: add FTOIZ instruction

2019-06-19 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski Reviewed-by: Bastian Koppelmann --- target/tricore/fpu_helper.c | 25 +

Re: [Qemu-devel] [PATCH] RISC-V: Update syscall list for 32-bit support.

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 00:32, Jim Wilson a écrit : > 32-bit RISC-V uses _llseek instead of lseek as syscall number 62. > Update syscall list from open-embedded build, primarily because > 32-bit RISC-V requires statx support. > > Tested with cross gcc testsuite runs for rv32 and rv64, with the > pending

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread Eric Blake
On 6/19/19 7:30 AM, Kevin Pouget wrote: > Hello, > > we're investigating the possibility to set some spice properties at > runtime, through the QMP interface, but we're not sure what's the best > way to proceed. > I've prepared the patch below, that adds a new QMP > command, but is there another

Re: [Qemu-devel] [RFC v1 3/5] hw/riscv: Extend the kernel loading support

2019-06-19 Thread Bin Meng
On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis wrote: > > Extend the RISC-V kernel loader to support uImage and Image files. > A Linux kernel can now be booted with: > > qemu-system-riscv64 -machine virt -bios fw_jump.elf -kernel Image > > Signed-off-by: Alistair Francis > --- >

[Qemu-devel] [PATCH v2 6/9] block: Add bdrv_drained_end_no_poll()

2019-06-19 Thread Max Reitz
In contrast to bdrv_drained_end(), which does poll and may thus lead to graph changes, this new interface to bdrv_do_drained_end() will not poll. Signed-off-by: Max Reitz --- include/block/block.h | 12 +++- block/io.c| 5 + 2 files changed, 16 insertions(+), 1

[Qemu-devel] [PATCH v2 4/9] block: Move polling out of bdrv_drain_invoke()

2019-06-19 Thread Max Reitz
Instead, let the root drained_end functions poll after the whole subtree has been undrained. These are bdrv_drain_all_end() and sometimes bdrv_do_drained_end(); the "sometimes" implies that the latter needs a parameter to tell whether it should poll or not. Note that bdrv_do_drained_end() now

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 2/5] hw/riscv: Add support for loading a firmware

2019-06-19 Thread Jonathan Behrens
I was actually just writing up the same thing. Shifting all the addresses in the ELF file by 2 or 4MB is somewhat surprising behavior, especially because this will apply to segments that are mapped even at much higher addresses. If you want a segment aligned to a 1GB superpage boundary you now

Re: [Qemu-devel] [PATCH] migration: Improve accuracy of vCPU throttling with per-vCPU timers

2019-06-19 Thread Cosmin Marin
On 19/06/2019, 02:35, "Peter Xu" wrote: On Tue, Jun 18, 2019 at 04:52:09PM +, Cosmin Marin wrote: > > > On 18/06/2019, 15:51, "Peter Xu" wrote: > > On Tue, Jun 18, 2019 at 12:25:43PM +, Cosmin Marin wrote: > > Hi Peter, > > >

[Qemu-devel] [PATCH v2 7/9] block: Fix BDS children's .drained_end()

2019-06-19 Thread Max Reitz
BdrvChildRole.drained_end() must not poll, bdrv_child_cb_drained_end() should use bdrv_drained_end_no_poll() instead of bdrv_drained_end(). The existing implementation works perfectly well for .drained_end_unquiesce(), though, so use it there. Signed-off-by: Max Reitz --- block.c | 9 +

[Qemu-devel] [PATCH v2 8/9] iotests: Add @has_quit to vm.shutdown()

2019-06-19 Thread Max Reitz
If a test has issued a quit command already (which may be useful to do explicitly because the test wants to show its effects), QEMUMachine.shutdown() should not do so again. Otherwise, the VM may well return an ECONNRESET which will lead QEMUMachine.shutdown() to killing it, which then turns into

Re: [Qemu-devel] [PATCH v5 30/42] qemu-img: Use child access functions

2019-06-19 Thread Max Reitz
On 19.06.19 11:18, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> This changes iotest 204's output, because blkdebug on top of a COW node >> used to make qemu-img map disregard the rest of the backing chain (the >> backing chain was broken by the filter). With this

[Qemu-devel] [QEMU PATCH v4 03/10] target/i386: kvm: Use symbolic constant for #DB/#BP exception constants

2019-06-19 Thread Liran Alon
Reviewed-by: Nikita Leshenko Reviewed-by: Krish Sadhukhan Signed-off-by: Liran Alon --- target/i386/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index efbecfc9d7f0..7b3b80833fdd 100644 --- a/target/i386/kvm.c +++

[Qemu-devel] [QEMU PATCH v4 02/10] KVM: Introduce kvm_arch_destroy_vcpu()

2019-06-19 Thread Liran Alon
Simiar to how kvm_init_vcpu() calls kvm_arch_init_vcpu() to perform arch-dependent initialisation, introduce kvm_arch_destroy_vcpu() to be called from kvm_destroy_vcpu() to perform arch-dependent destruction. This was added because some architectures (Such as i386) currently do not free memory

Re: [Qemu-devel] [QEMU PATCH v4 07/10] vmstate: Add support for kernel integer types

2019-06-19 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Reviewed-by: Nikita Leshenko > Reviewed-by: Maran Wilson > Signed-off-by: Liran Alon > --- > include/migration/vmstate.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/include/migration/vmstate.h

Re: [Qemu-devel] [PATCH v2] qemu-ga: Convert invocation documentation to rST

2019-06-19 Thread Michael Roth
Quoting Peter Maydell (2019-06-18 05:47:18) > The qemu-ga documentation is currently in qemu-ga.texi in > Texinfo format, which we present to the user as: > * a qemu-ga manpage > * a section of the main qemu-doc HTML documentation > > Convert the documentation to rST format, and present it to >

Re: [Qemu-devel] Recent python-sphinx errors out building doc

2019-06-19 Thread John Snow
On 6/19/19 12:28 AM, Bruce Rogers wrote: On 6/18/2019 at 6:11 PM, John Snow wrote: > >> >> On 6/18/19 7:37 PM, Bruce Rogers wrote: >>> Hi, >>> >>> (Resent with correct address for John) >>> I build recent upstream qemu in the openSUSE Build Service, and for >>> the Factory repository

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 4/5] roms: Add OpenSBI version 0.3

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 8:18 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 1:14 PM Anup Patel wrote: > > > > On Wed, Jun 19, 2019 at 6:24 AM Alistair Francis > > wrote: > > > > > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > > > > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v1 0/9] Update the RISC-V specification versions

2019-06-19 Thread Palmer Dabbelt
On Mon, 17 Jun 2019 18:31:00 PDT (-0700), Alistair Francis wrote: Based-on: Now that the RISC-V spec has started to be ratified let's update our QEMU implementation. There are a few things going on here: - Add priv version 1.11.0 to QEMU - This is the ratified version of the Privledge

Re: [Qemu-devel] [PATCH v3 07/50] plugin: add user-facing API

2019-06-19 Thread Alex Bennée
Pranith Kumar writes: > On Fri, Jun 14, 2019 at 10:24 AM Alex Bennée wrote: >> >> From: "Emilio G. Cota" >> >> Add the API first to ease review. >> >> Signed-off-by: Emilio G. Cota >> Signed-off-by: Alex Bennée >> >> --- >> v3 >> - merge in changes to plugin install/reset/uninstall >>

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 4/5] roms: Add OpenSBI version 0.3

2019-06-19 Thread Bin Meng
On Wed, Jun 19, 2019 at 1:14 PM Anup Patel wrote: > > On Wed, Jun 19, 2019 at 6:24 AM Alistair Francis > wrote: > > > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > > > Signed-off-by: Alistair Francis > > --- > > .gitmodules | 3 +++ > >

[Qemu-devel] [PATCH v2 5/9] block: Add @poll to bdrv_parent_drained_end_single()

2019-06-19 Thread Max Reitz
This function has two callers; one wants it to poll, the other does not. To implement this parameter, we also need a new BdrvChildRole method, namely .drained_end_unquiesce(). This function differs from .drained_end() in that it should poll and is thus allowed to modify the block graph. Note

Re: [Qemu-devel] [PATCH v5 33/42] blockdev: Fix active commit choice

2019-06-19 Thread Max Reitz
On 19.06.19 11:31, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> We have to perform an active commit whenever the top node has a parent >> that has taken the WRITE permission on it. >> >> Signed-off-by: Max Reitz >> --- >> blockdev.c | 24 +--- >>

Re: [Qemu-devel] [PATCH v2 3/3] vmdk: Add read-only support for seSparse snapshots

2019-06-19 Thread Max Reitz
On 05.06.19 14:17, Sam Eiderman wrote: > Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in > QEMU). > > This format was lacking in the following: > > * Grain directory (L1) and grain table (L2) entries were 32-bit, > allowing access to only 2TB (slightly less) of

Re: [Qemu-devel] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 7:42 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 10:30 PM Alistair Francis > wrote: > > > > On Wed, Jun 19, 2019 at 7:26 AM Bin Meng wrote: > > > > > > On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis > > > wrote: > > > > > > > > This is an RFC as it will break ALL

[Qemu-devel] [PATCH v2 3/9] block: Add bdrv_poll_drain_data_objs()

2019-06-19 Thread Max Reitz
This function polls all of the involved AioContexts for a GSList of BdrvCoDrainData objects until all objects' .done is true. Signed-off-by: Max Reitz --- block/io.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/block/io.c

[Qemu-devel] [PATCH v2 9/9] iotests: Test commit with a filter on the chain

2019-06-19 Thread Max Reitz
Before the previous patches, the first case resulted in a failed assertion (which is noted as qemu receiving a SIGABRT in the test output), and the second usually triggered a segmentation fault. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 40 +-

[Qemu-devel] [QEMU PATCH v4 07/10] vmstate: Add support for kernel integer types

2019-06-19 Thread Liran Alon
Reviewed-by: Nikita Leshenko Reviewed-by: Maran Wilson Signed-off-by: Liran Alon --- include/migration/vmstate.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 9224370ed59a..ca68584eba4d 100644 ---

Re: [Qemu-devel] [PATCH v12 5/5] linux-user: Fix flock structure for MIPS O64 ABI

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 16:17, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Only MIPS O32 and N32 have special (different than other > architectures) definition of structure flock in kernel. > > Bring flock definition for MIPS O64 ABI to the correct state. > > Reported-by: Dragan

[Qemu-devel] [QEMU PATCH v4 09/10] target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-19 Thread Liran Alon
Kernel commit c4f55198c7c2 ("kvm: x86: Introduce KVM_CAP_EXCEPTION_PAYLOAD") introduced a new KVM capability which allows userspace to correctly distinguish between pending and injected exceptions. This distinguish is important in case of nested virtualization scenarios because a L2 pending

Re: [Qemu-devel] [PATCH] blockjob: drain all job nodes in block_job_drain

2019-06-19 Thread Max Reitz
On 19.06.19 16:44, Vladimir Sementsov-Ogievskiy wrote: > Instead of draining additional nodes in each job code, let's do it in > common block_job_drain, draining just all job's children. > > It's also a first step to finally get rid of blockjob->blk. > > Signed-off-by: Vladimir

[Qemu-devel] [PATCH 2/2] MAINTAINERS: Consolidate MIPS disassembler-related items

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Eliminate duplicate MIPS disassembler-related items in the MAINTAINERS file, and use wildcards to shorten the list of involved files. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 0/2] target/mips: Misc fixes and maintenance for 4.1

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains miscelaneous fixes, improvements, and maintainance items intended to be integrated into QEMU 4.1. I will gradually add patches by the end of June 2019. Aleksandar Markovic (2): MAINTAINERS: Update file items for MIPS Malta board MAINTAINERS:

Re: [Qemu-devel] [RFC v1 1/5] hw/riscv: Split out the boot functions

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 8:16 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 8:51 AM Alistair Francis > wrote: > > > > Split the common RISC-V boot functions into a seperate file. This allows > > us to share the common code. > > > > Signed-off-by: Alistair Francis > > --- > >

[Qemu-devel] [PATCH v2 2/9] block: Add @data_objs to bdrv_drain_invoke()

2019-06-19 Thread Max Reitz
Callers can now pass a pointer to a GSList that bdrv_drain_invoke() (and its recursive callees) will fill with all BdrvCoDrainData objects they create. This will allow us to move the polling for BdrvCoDrainData.done to become true out of bdrv_drain_invoke() and into the root drain_end function.

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 2/5] hw/riscv: Add support for loading a firmware

2019-06-19 Thread Bin Meng
Hi, On Wed, Jun 19, 2019 at 11:26 PM Jonathan Behrens wrote: > > I was actually just writing up the same thing. Shifting all the addresses in > the ELF file by 2 or 4MB is somewhat surprising behavior, especially because > this will apply to segments that are mapped even at much higher

[Qemu-devel] [QEMU PATCH v4 04/10] target/i386: kvm: Re-inject #DB to guest with updated DR6

2019-06-19 Thread Liran Alon
If userspace (QEMU) debug guest, when #DB is raised in guest and intercepted by KVM, KVM forwards information on #DB to userspace instead of injecting #DB to guest. While doing so, KVM don't update vCPU DR6 but instead report the #DB DR6 value to userspace for further handling. See KVM's

[Qemu-devel] [QEMU PATCH v4 10/10] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-19 Thread Liran Alon
Previous commits have added support for migration of nested virtualization workloads. This was done by utilising two new KVM capabilities: KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are required in order to correctly migrate such workloads. Therefore, change code to add a

Re: [Qemu-devel] [PATCH] gdbstub: print message on startup as gdbserver

2019-06-19 Thread Alex Bennée
lukas.durf...@gmail.com writes: > From: Lukas Durfina > > It helps to test gdb running qemu instead of a gdbserver. > It prints the same message as the gdbserver on startup. > > Signed-off-by: Lukas Durfina > --- > gdbstub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdbstub.c

Re: [Qemu-devel] [PATCH v2 2/3] vmdk: Reduce the max bound for L1 table size

2019-06-19 Thread Max Reitz
On 05.06.19 14:17, Sam Eiderman wrote: > 512M of L1 entries is a very loose bound, only 32M are required to store > the maximal supported VMDK file size of 2TB. > > Fixed qemu-iotest 59# - now failure occures before on impossible L1 > table size. > > Reviewed-by: Karl Heubaum > Reviewed-by:

Re: [Qemu-devel] Recent python-sphinx errors out building doc

2019-06-19 Thread John Snow
On 6/19/19 2:15 PM, John Snow wrote: > > > On 6/19/19 12:28 AM, Bruce Rogers wrote: > On 6/18/2019 at 6:11 PM, John Snow wrote: >> >>> >>> On 6/18/19 7:37 PM, Bruce Rogers wrote: Hi, (Resent with correct address for John) I build recent upstream qemu in the openSUSE

Re: [Qemu-devel] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-19 Thread Bin Meng
On Wed, Jun 19, 2019 at 10:30 PM Alistair Francis wrote: > > On Wed, Jun 19, 2019 at 7:26 AM Bin Meng wrote: > > > > On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis > > wrote: > > > > > > This is an RFC as it will break ALL current users! See below for details. > > > > > > This series

Re: [Qemu-devel] [RFC v1 2/5] hw/riscv: Add support for loading a firmware

2019-06-19 Thread Bin Meng
On Wed, Jun 19, 2019 at 8:53 AM Alistair Francis wrote: > > Add support for loading a firmware file for the virt machine and the > SiFive U. This can be run with the following command: > > qemu-system-riscv64 -machine virt -bios fw_jump.elf -kernel vmlinux > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [RFC v1 1/5] hw/riscv: Split out the boot functions

2019-06-19 Thread Bin Meng
On Wed, Jun 19, 2019 at 8:51 AM Alistair Francis wrote: > > Split the common RISC-V boot functions into a seperate file. This allows > us to share the common code. > > Signed-off-by: Alistair Francis > --- > hw/riscv/Makefile.objs | 1 + > hw/riscv/boot.c | 69

[Qemu-devel] [PATCH v2 0/9] block: Delay poll when ending drained sections

2019-06-19 Thread Max Reitz
Hi, This is v2 to “block: Keep track of parent quiescing”. Please read this cover letter, because I’m very unsure about the design in this series and I’d appreciate some comments. As Kevin wrote in his reply to that series, the actual problem is that bdrv_drain_invoke() polls on every node

[Qemu-devel] [PATCH v2 1/9] block: Introduce BdrvChild.parent_quiesce_counter

2019-06-19 Thread Max Reitz
Commit 5cb2737e925042e6c7cd3fb0b01313950b03cddf laid out why bdrv_do_drained_end() must decrement the quiesce_counter after bdrv_drain_invoke(). It did not give a very good reason why it has to happen after bdrv_parent_drained_end(), instead only claiming symmetry to bdrv_do_drained_begin(). It

Re: [Qemu-devel] [PATCH v5 34/42] block: Inline bdrv_co_block_status_from_*()

2019-06-19 Thread Max Reitz
On 19.06.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> With bdrv_filtered_rw_bs(), we can easily handle this default filter >> behavior in bdrv_co_block_status(). >> >> blkdebug wants to have an additional assertion, so it keeps its own >> implementation,

Re: [Qemu-devel] [PATCH v12 3/5] linux-user: Add support for translation of statx() syscall

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 16:17, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Implement support for translation of system call statx(). > > The implementation is based on "best effort" approach: if host is > capable of executing statx(), host statx() is used. If not, the > implementation

[Qemu-devel] [QEMU PATCH v4 06/10] linux-headers: i386: Modify struct kvm_nested_state to have explicit fields for data

2019-06-19 Thread Liran Alon
Improve the KVM_{GET,SET}_NESTED_STATE structs by detailing the format of VMX nested state data in a struct. In order to avoid changing the ioctl values of KVM_{GET,SET}_NESTED_STATE, there is a need to preserve sizeof(struct kvm_nested_state). This is done by defining the data struct as

[Qemu-devel] [QEMU PATCH v4 01/10] target/i386: kvm: Delete VMX migration blocker on vCPU init failure

2019-06-19 Thread Liran Alon
Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") added migration blocker for vCPU exposed with Intel VMX because QEMU doesn't yet contain code to support migration of nested virtualization workloads. However, that commit missed adding deletion of the migration blocker in case

[Qemu-devel] [QEMU PATCH v4 05/10] target/i386: kvm: Block migration for vCPUs exposed with nested virtualization

2019-06-19 Thread Liran Alon
Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") added a migration blocker for vCPU exposed with Intel VMX. However, migration should also be blocked for vCPU exposed with AMD SVM. Both cases should be blocked because QEMU should extract additional vCPU state from KVM that

Re: [Qemu-devel] [PATCH 1/3] tests/acceptance: Specify arch for QueryCPUModelExpansion

2019-06-19 Thread Wainer dos Santos Moschetta
On 06/13/2019 03:07 AM, David Gibson wrote: At the moment this test runs on whatever the host arch is. But it looks for 'unavailable-features' which is an x86 specific cpu property. Tag it to always use qemu-system-x86_64. Signed-off-by: David Gibson --- tests/acceptance/cpu_queries.py |

[Qemu-devel] [PATCH 2/2] tests/tcg: target/mips: Amend tests for MSA pack instructions

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Add tests for cases when destination register is the same as one of source registers. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/include/wrappers_msa.h | 24 + .../tcg/mips/user/ase/msa/pack/test_msa_pckev_b.c | 58

[Qemu-devel] [PATCH] blockjob: drain all job nodes in block_job_drain

2019-06-19 Thread Vladimir Sementsov-Ogievskiy
Instead of draining additional nodes in each job code, let's do it in common block_job_drain, draining just all job's children. It's also a first step to finally get rid of blockjob->blk. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! As a follow-up for "block: drop bs->job" recently

Re: [Qemu-devel] [PATCH v12 0/5]

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1560953834-29584-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD

Re: [Qemu-devel] [PATCH v12 1/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 16:17, Aleksandar Markovic a écrit : > From: Neng Chen > > Add support for the option IPV6__MEMBERSHIP of the syscall > setsockopt(). This option controls membership in multicast groups. > Argument is a pointer to a struct ipv6_mreq. > > The glibc header defines the ipv6_mreq

Re: [Qemu-devel] [PATCH v5 34/42] block: Inline bdrv_co_block_status_from_*()

2019-06-19 Thread Max Reitz
On 19.06.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> With bdrv_filtered_rw_bs(), we can easily handle this default filter >> behavior in bdrv_co_block_status(). >> >> blkdebug wants to have an additional assertion, so it keeps its own >> implementation,

[Qemu-devel] [QEMU PATCH v4 0/10]: target/i386: kvm: Add support for save and restore of nested state

2019-06-19 Thread Liran Alon
Hi, This series aims to add support for QEMU to be able to migrate VMs that are running nested hypervisors. In order to do so, it utilizes the new IOCTLs introduced in KVM commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") which was created for this purpose. 1st patch add a missed

[Qemu-devel] [PATCH 1/2] MAINTAINERS: Update file items for MIPS Malta board

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Markovic hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to place this file in Malta board section of the MAINTAINERS file. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] qemu processes

2019-06-19 Thread Alex Bennée
Ryan Boyce writes: > Alex, > > I have another KVM/qemu related CPU question. I am hoping you will be so > kind as to answer again. I have a Dell Poweredge T430 server running a > single Intel Xeon E5-2603 v3 CPU with 6 cores. I have 6 VMs running CentOS > 7 via KVM. I am noticing some terrible

[Qemu-devel] [QEMU PATCH v4 08/10] target/i386: kvm: Add support for save and restore nested state

2019-06-19 Thread Liran Alon
Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") introduced new IOCTLs to extract and restore vCPU state related to Intel VMX & AMD SVM. Utilize these IOCTLs to add support for migration of VMs which are running nested hypervisors. Reviewed-by: Nikita Leshenko

Re: [Qemu-devel] [PATCH v2 1/3] vmdk: Fix comment regarding max l1_size coverage

2019-06-19 Thread Max Reitz
On 05.06.19 14:17, Sam Eiderman wrote: > Commit b0651b8c246d ("vmdk: Move l1_size check into vmdk_add_extent") > extended the l1_size check from VMDK4 to VMDK3 but did not update the > default coverage in the moved comment. > > The previous vmdk4 calculation: > > (512 * 1024 * 1024) * 512(l2

Re: [Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option

2019-06-19 Thread Stefan Hajnoczi
On Mon, Jun 17, 2019 at 04:01:45PM +0300, Maxim Levitsky wrote: > On Mon, 2019-06-10 at 19:19 +0530, Aarushi Mehta wrote: > > Signed-off-by: Aarushi Mehta > > Reviewed-by: Stefan Hajnoczi > > --- > > blockdev.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Qemu-devel] [PATCH v3 08/50] plugin: add core code

2019-06-19 Thread Alex Bennée
Pranith Kumar writes: > On Fri, Jun 14, 2019 at 10:30 AM Alex Bennée wrote: >> >> From: "Emilio G. Cota" >> >> Signed-off-by: Emilio G. Cota >> [AJB: moved directory and merged various fixes] >> Signed-off-by: Alex Bennée >> >> --- >> v3 >> - moved to plugins/ >> - merged >>

Re: [Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards

2019-06-19 Thread David Gibson
On Fri, Jun 14, 2019 at 01:08:44PM +0200, Greg Kurz wrote: > There are several places where CONFIG_KVM is used to guard code that > should only be built when KVM is supported. It is generally preferable > to avoid that and leave such guards in header files for improved > readability. > > In many

[Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread Kevin Pouget
Hello, we're investigating the possibility to set some spice properties at runtime, through the QMP interface, but we're not sure what's the best way to proceed. I've prepared the patch below, that adds a new QMP command, but is there another way like with a QOM object, that could reuse an

[Qemu-devel] [PATCH v12 3/5] linux-user: Add support for translation of statx() syscall

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation is based on "best effort" approach: if host is capable of executing statx(), host statx() is used. If not, the implementation includes invoking other (more mature) system calls (from the same

[Qemu-devel] [PATCH] blockjob: drain all job nodes in block_job_drain

2019-06-19 Thread Vladimir Sementsov-Ogievskiy
Instead of draining additional nodes in each job code, let's do it in common block_job_drain, draining just all job's children. It's also a first step to finally get rid of blockjob->blk. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! As a follow-up for "block: drop bs->job" recently

Re: [Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

2019-06-19 Thread Vladimir Sementsov-Ogievskiy
10.06.2019 16:21, Denis Plotnikov wrote: > The patch allows to provide a pattern file for write > command. There was no similar ability before. > > Signed-off-by: Denis Plotnikov > --- > v6: >* the pattern file is read once to reduce io > > v5: >* file name initiated with null to make

Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring

2019-06-19 Thread Maxim Levitsky
On Wed, 2019-06-19 at 11:14 +0100, Stefan Hajnoczi wrote: > On Mon, Jun 17, 2019 at 03:26:50PM +0300, Maxim Levitsky wrote: > > On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote: > > > +if (!cqes) { > > > +break; > > > +} > > > +LuringAIOCB *luringcb =

[Qemu-devel] [PATCH 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

2019-06-19 Thread Stefan Brankovic
Adding simple macro that is calling tcg implementation of appropriate instruction if altivec support is active. Optimization of altivec instruction lvsl (Load Vector for Shift Left). Place bytes sh:sh+15 of value 0x00 || 0x01 || 0x02 || ... || 0x1E || 0x1F in destination register. Sh is

[Qemu-devel] [PATCH 5/8] target/ppc: Optimize emulation of vclzd instruction

2019-06-19 Thread Stefan Brankovic
Optimize Altivec instruction vclzd (Vector Count Leading Zeros Doubleword). This instruction counts the number of leading zeros of each doubleword element in source register and places result in the appropriate doubleword element of destination register. Using tcg-s count leading zeros

[Qemu-devel] [PATCH 8/8] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

2019-06-19 Thread Stefan Brankovic
Since I found this two instructions implemented with tcg, I refactored them so they are consistent with other similar implementations that I introduced in this patch. Also, a new dual macro GEN_VXFORM_TRANS_DUAL is added. This macro is used if one instruction is realized with direct translation,

Re: [Qemu-devel] [PATCH v2 5/5] tricore: reset DisasContext before generating code

2019-06-19 Thread Brenken, David (EFS-GH2)
Ah. You are right. I will fix this one within the third version. Best regards David -Ursprüngliche Nachricht- Von: Bastian Koppelmann [mailto:kbast...@mail.uni-paderborn.de] Gesendet: Mittwoch, 19. Juni 2019 14:26 An: David Brenken ; qemu-devel@nongnu.org Cc: Biermanski, Lars

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190619123042.4822-1-kpou...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP Type: series Message-id:

Re: [Qemu-devel] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 7:26 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis > wrote: > > > > This is an RFC as it will break ALL current users! See below for details. > > > > This series consolidates the current RISC-V kernel loading > > impelementation while also adding

Re: [Qemu-devel] [PATCH v5 05/12] stubs: add stubs for io_uring interface

2019-06-19 Thread Stefan Hajnoczi
On Mon, Jun 17, 2019 at 03:33:01PM +0300, Maxim Levitsky wrote: > On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote: > > diff --git a/stubs/io_uring.c b/stubs/io_uring.c > > new file mode 100644 > > index 00..622d1e4648 > > --- /dev/null > > +++ b/stubs/io_uring.c > > @@ -0,0 +1,32 @@

Re: [Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option

2019-06-19 Thread Maxim Levitsky
On Wed, 2019-06-19 at 11:24 +0100, Stefan Hajnoczi wrote: > On Mon, Jun 17, 2019 at 04:01:45PM +0300, Maxim Levitsky wrote: > > On Mon, 2019-06-10 at 19:19 +0530, Aarushi Mehta wrote: > > > Signed-off-by: Aarushi Mehta > > > Reviewed-by: Stefan Hajnoczi > > > --- > > > blockdev.c | 4 +++- > > >

[Qemu-devel] [PATCH 6/8] target/ppc: Optimize emulation of vclzw instruction

2019-06-19 Thread Stefan Brankovic
Optimize Altivec instruction vclzw (Vector Count Leading Zeros Word). This instruction counts the number of leading zeros of each word element in source register and places result in the appropriate word element of destination register. Counting is to be performed in four iterations of for

Re: [Qemu-devel] [PATCH 0/8] target/ppc: Optimize emulation of some Altivec instructions

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1560942225-24728-1-git-send-email-stefan.branko...@rt-rk.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD

Re: [Qemu-devel] [PATCH] qmp: make qmp-shell work with python3

2019-06-19 Thread Cleber Rosa
On Tue, Jun 18, 2019 at 10:29:31AM -0400, Igor Mammedov wrote: > python3 doesn't have raw_input(), so qmp-shell breaks. > Use input() instead and override it with raw_input() > if running on python2. > > Signed-off-by: Igor Mammedov > --- > scripts/qmp/qmp-shell | 6 +- > 1 file changed, 5

[Qemu-devel] [PATCH v11 4/5] linux-user: Add support for strace for statx() syscall

2019-06-19 Thread Aleksandar Markovic
From: Jim Wilson All of the flags need to be conditional as old systems don't have statx support. Otherwise it works the same as other stat family syscalls. This requires the pending patch to add statx support. Tested on Ubuntu 16.04 (no host statx) and Ubuntu 19.04 (with host statx) using a

[Qemu-devel] [PATCH v11 5/5] linux-user: Fix flock structure for MIPS O64 ABI

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Only MIPS O32 and N32 have special (different than other architectures) definition of structure flock in kernel. Bring flock definition for MIPS O64 ABI to the correct state. Reported-by: Dragan Mladjenovic Signed-off-by: Aleksandar Markovic ---

Re: [Qemu-devel] [PATCH v11 0/5] linux-user: A set of miscellaneous patches

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1560953429-29203-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/5] linux-user: A set of miscellaneous patches Type:

[Qemu-devel] [PATCH v12 2/5] linux-user: Add support for setsockopt() option SOL_ALG

2019-06-19 Thread Aleksandar Markovic
From: Yunqiang Su Add support for options SOL_ALG of the syscall setsockopt(). This option is used in relation to Linux kernel Crypto API, and allows a user to set additional information for the cipher operation via syscall setsockopt(). The field "optname" must be one of the following: -

Re: [Qemu-devel] [PATCH v11 0/5] linux-user: A set of miscellaneous patches

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1560953429-29203-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD

Re: [Qemu-devel] [PATCH] blockjob: drain all job nodes in block_job_drain

2019-06-19 Thread Vladimir Sementsov-Ogievskiy
19.06.2019 17:44, Vladimir Sementsov-Ogievskiy wrote: > Instead of draining additional nodes in each job code, let's do it in > common block_job_drain, draining just all job's children. > > It's also a first step to finally get rid of blockjob->blk. Oops, sorry for double-sending. -- Best

[Qemu-devel] [PATCH] gdbstub: print message on startup as gdbserver

2019-06-19 Thread lukas . durfina
From: Lukas Durfina It helps to test gdb running qemu instead of a gdbserver. It prints the same message as the gdbserver on startup. Signed-off-by: Lukas Durfina --- gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub.c b/gdbstub.c index 8618e34311..9ad9929968 100644 ---

[Qemu-devel] [PATCH 0/8] target/ppc: Optimize emulation of some Altivec instructions

2019-06-19 Thread Stefan Brankovic
Optimize emulation of ten Altivec instructions: lvsl, lvsr, vsl, vsr, vpkpx, vgbbd, vclzb, vclzh, vclzw and vclzd. This series buils up on and complements recent work of Thomas Murta, Mark Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG translation implementation

Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190619092905.24029-1-shmuel.eider...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface Type: series Message-id:

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 14:12, Aleksandar Rikalo a écrit : > Hi Laurent, ... >> BTW, do we really need to emulate the syscall if it is not available? >> >> I think the user-space application calling statx() should be ready to >> receive ENOSYS and define some kinds of fallback (like you do below). So >>

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-19 Thread Auger Eric
Hi Yan, [+ Peter] On 6/19/19 10:49 AM, Yan Zhao wrote: > even if an entry overlaps with notifier's range, should not map/unmap > out of bound part in the entry. I don't think the patch was based on the master as the trace at the very end if not part of the upstream code. > > This would cause

[Qemu-devel] [PATCH v11 1/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-06-19 Thread Aleksandar Markovic
From: Neng Chen Add support for the option IPV6__MEMBERSHIP of the syscall setsockopt(). This option controls membership in multicast groups. Argument is a pointer to a struct ipv6_mreq. The glibc header defines the ipv6_mreq structure, which includes the following members: struct in6_addr

[Qemu-devel] [PATCH v11 3/5] linux-user: Add support for translation of statx() syscall

2019-06-19 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation is based on "best effort" approach: if host is capable of executing statx(), host statx() is used. If not, the implementation includes invoking other (more mature) system calls (from the same

[Qemu-devel] [PATCH 3/8] target/ppc: Optimize emulation of vpkpx instruction

2019-06-19 Thread Stefan Brankovic
Optimize altivec instruction vpkpx (Vector Pack Pixel). Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register) into contigous array of bits in the destination register. In each iteration of outer loop, the instruction is to be done with the 6-5-5 pack for 2 pixels of each

  1   2   3   >