Re: [Qemu-devel] [PATCH] hw/i386: Fix linker error when ISAPC is disabled

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190704180350.2086-1-julio.mon...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] hw/i386: Fix linker error when ISAPC is disabled Type: series Message-id:

[Qemu-devel] [PATCH for 4.1 v2] linux-user: Fix structure target_ucontext for MIPS

2019-07-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link;

[Qemu-devel] [RFC PATCH qemu] vfio-quirks: Pass the actual parent when deleting a memory region

2019-07-04 Thread Alexey Kardashevskiy
The usual way of using a quirk's MR is to add it as a subregion of a BAR as this is what quirks are for. However there is less than standard user of this - NVLink2-enabled NVIDIA GPU which exposes a GPU RAM and a ATSD 64K region outside of PCI MMIO window so these MRs get the system address space

[Qemu-devel] [Bug 1462640] Re: shmat fails on 32-to-64 setup

2019-07-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1462640 Title: shmat

Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode Type: series Message-id:

Re: [Qemu-devel] [PATCH] hw/ssi/xilinx_spips: add lqspi_write routine

2019-07-04 Thread Francisco Iglesias
Hi, On [2019 Jul 04] Thu 11:42:54, Peter Maydell wrote: > On Thu, 4 Jul 2019 at 11:11, Philippe Mathieu-Daudé wrote: > > However, looking at the datasheet 'UG1085 (v1.0) November 24, 2015', > > Chapter 22: Quad-SPI Controller, I understand this region is only > > accessible by the CPU in READ

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-04 Thread Michael S. Tsirkin
On Thu, Jul 04, 2019 at 07:03:42AM -0400, Pankaj Gupta wrote: > > > > > > > The following changes since commit > > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > > > Merge remote-tracking branch > > > 'remotes/maxreitz/tags/pull-block-2019-06-24' into staging (2019-07-01 > > > 11:28:28

[Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-04 Thread Marcel Apfelbaum
At some point vmxnet3 live migration stopped working and git-bisect didn't help finding a working version. The issue is the PCI configuration space is not being migrated successfully and MSIX remains masked at destination. Remove the migration differentiation between PCI and PCIe since the logic

[Qemu-devel] [PATCH for 4.1] linux-user: Fix structure target_ucontext for MIPS

2019-07-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link;

[Qemu-devel] [PULL 9/9] target/arm: Correct VMOV_imm_dp handling of short vectors

2019-07-04 Thread Peter Maydell
Coverity points out (CID 1402195) that the loop in trans_VMOV_imm_dp() that iterates over the destination registers in a short-vector VMOV accidentally throws away the returned updated register number from vfp_advance_dreg(). Add the missing assignment. (We got this correct in

[Qemu-devel] [PULL 6/9] target/arm: Use _ra versions of cpu_stl_data() in v7M helpers

2019-07-04 Thread Peter Maydell
In the various helper functions for v7M/v8M instructions, use the _ra versions of cpu_stl_data() and friends. Otherwise we may get wrong behaviour or an assert() due to not being able to locate the TB if there is an exception on the memory access or if it performs an IO operation when in icount

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-04 Thread Alex Bennée
vandersonmr writes: > adding options to list tbs by some metric and > investigate their code. > > Signed-off-by: Vanderson M. do Rosario > --- > hmp-commands-info.hx | 22 ++ > monitor/misc.c | 69 > 2 files changed, 91

Re: [Qemu-devel] [PATCH v2 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > I'm surprised it didn't come up sooner, but sometimes we have a +busy > bitmap as a source. This is dangerous from the QMP API, but if we are > the owner that marked the bitmap busy, it's safe to merge it using it as > a read only source. > > It is not safe

Re: [Qemu-devel] [PATCH v2 14/18] iotests: teach run_job to cancel pending jobs

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > run_job can cancel pending jobs to simulate failure. This lets us use > the pending callback to issue test commands while the job is open, but > then still have the job fail in the end. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 22

Re: [Qemu-devel] [PATCH v2 13/18] iotests: add testing shim for script-style python tests

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Because the new-style python tests don't use the iotests.main() test > launcher, we don't turn on the debugger logging for these scripts > when invoked via ./check -d. > > Refactor the launcher shim into new and old style shims so that they > share

Re: [Qemu-devel] [PATCH v2 18/18] block/backup: loosen restriction on readonly bitmaps

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > With the "never" sync policy, we actually can utilize readonly bitmaps > now. Loosen the check at the QMP level, and tighten it based on > provided arguments down at the job creation level instead. > > Signed-off-by: John Snow > --- > block/backup.c | 6

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-04 Thread Greg Kurz
On Thu, 4 Jul 2019 10:49:05 +0530 Aravinda Prasad wrote: > > > On Thursday 04 July 2019 06:42 AM, David Gibson wrote: > > On Wed, Jul 03, 2019 at 02:30:31PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Wednesday 03 July 2019 08:50 AM, David Gibson wrote: > >>> On Tue, Jul 02, 2019 at

Re: [Qemu-devel] [PATCH 0/2] tests: acpi: improve tests reproducability

2019-07-04 Thread Michael S. Tsirkin
On Thu, Jul 04, 2019 at 04:27:34AM -0400, Igor Mammedov wrote: > > series should help to make tests more reproducable and not depend > on IASL being installed. IASL will be required only is user needs > to get textual diff of mismatching files. I like this very much but pls send v3 with both

[Qemu-devel] [Bug 1835466] [NEW] qemu 4.0.0 abort()s in audio_get_pdo_in (poisoned drv->driver?)

2019-07-04 Thread Jakub Jankowski
Public bug reported: After upgrading qemu from 3.0.0 to 4.0.0 (compiled from release tarball), I'm seeing a (reproducible) crash related to audio subsystem. I recompiled qemu with debugging options and got it to crash under gdb: Thread 6 "qemu-system-x86" received signal SIGABRT, Aborted.

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-04 Thread Alistair Francis
On Thu, Jul 4, 2019 at 9:11 AM Stefan Hajnoczi wrote: > > On Mon, Jul 01, 2019 at 07:01:12PM +0100, Peter Maydell wrote: > > On Mon, 1 Jul 2019 at 18:50, Alistair Francis > > wrote: > > > > > > On Mon, 2019-07-01 at 17:54 +0100, Peter Maydell wrote: > > > > On Thu, 27 Jun 2019 at 16:24, Palmer

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-04 Thread David Gibson
On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: > > > On Thursday 04 July 2019 06:37 AM, David Gibson wrote: > > On Wed, Jul 03, 2019 at 02:58:24PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Wednesday 03 July 2019 08:33 AM, David Gibson wrote: > >>> On Tue, Jul 02, 2019 at

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-04 Thread Michael S. Tsirkin
On Thu, Jul 04, 2019 at 10:25:48AM +0100, Peter Maydell wrote: > On Tue, 2 Jul 2019 at 16:06, Michael S. Tsirkin wrote: > > > > The following changes since commit 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > Merge remote-tracking branch > > 'remotes/maxreitz/tags/pull-block-2019-06-24'

[Qemu-devel] [PATCH] ati-vga: Fix setting offset together with pitch for r128pro

2019-07-04 Thread BALATON Zoltan
Turns out my last fix to this broke one case for Rage 128 Pro so revert that part of previous patch. This now fixes the remaining rendering problems for MorphOS which now can produce picture with -device ati-vga (although it may not be optimised yet and video overlay emulation is still known to be

[Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Philippe Mathieu-Daudé
Hi Gerd, I'm looking at: static const MemoryRegionPortio vbe_portio_list[] = { { 0, 1, 2, .read = vbe_ioport_read_index, .write = vbe_ioport_write_index }, # ifdef TARGET_I386 { 1, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data }, # endif { 2, 1, 2, .read =

Re: [Qemu-devel] [PATCH v3 1/6] accel/tcg: adding structure to store TB statistics

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We want to store statistics for each TB even after flushes. > We do not want to modify or grow the TB struct. > So we create a new struct to contain this statistics and > we link one of it to each TB as they are generated. > > Signed-off-by: Vanderson M. do Rosario > ---

Re: [Qemu-devel] [PATCH v3 1/6] accel/tcg: adding structure to store TB statistics

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We want to store statistics for each TB even after flushes. > We do not want to modify or grow the TB struct. > So we create a new struct to contain this statistics and > we link one of it to each TB as they are generated. Mini note, what happened to the cover letter?

Re: [Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Paolo Bonzini
On 04/07/19 15:55, Gerd Hoffmann wrote: > On Thu, Jul 04, 2019 at 03:27:25PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Gerd, >> >> I'm looking at: >> >> static const MemoryRegionPortio vbe_portio_list[] = { >> { 0, 1, 2, .read = vbe_ioport_read_index, .write = >> vbe_ioport_write_index }, >>

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Paolo Bonzini
On 04/07/19 16:31, Liran Alon wrote: > > >> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: >> >> On 25/06/19 01:05, Liran Alon wrote: >>> When vCPU is in VMX operation and enters SMM mode, >>> it temporarily exits VMX operation but KVM maintained nested-state >>> still stores the VMXON region

[Qemu-devel] [PULL 5/9] target/arm: v8M: Check state of exception being returned from

2019-07-04 Thread Peter Maydell
In v8M, an attempt to return from an exception which is not active is an illegal exception return. For this purpose, exceptions which can configurably target either Secure or NonSecure are not considered to be active if they are configured for the opposite security state for the one we're trying

[Qemu-devel] [PULL 1/9] target/arm: Move debug routines to debug_helper.c

2019-07-04 Thread Peter Maydell
From: Philippe Mathieu-Daudé These routines are TCG specific. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20190701194942.10092-2-phi...@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/Makefile.objs | 2 +- target/arm/cpu.c | 9 +-

Re: [Qemu-devel] [PATCH v2 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > This simplifies some interface matters; namely the initialization and > (later) merging the manifest back into the sync_bitmap if it was > provided. > > Signed-off-by: John Snow > --- > block/backup.c | 76 --

[Qemu-devel] [PATCH v2 1/1] raw-posix.c - use max transfer length / max segement count only for SCSI passthrough

2019-07-04 Thread Maxim Levitsky
Regular kernel block devices (/dev/sda*, /dev/nvme*, etc) don't have max segment size/max segment count hardware requirements exposed to the userspace, but rather the kernel block layer takes care to split the incoming requests that violate these requirements. Allowing the kernel to do the

[Qemu-devel] [PATCH v2 00/14] target/arm/kvm: enable SVE in guests

2019-07-04 Thread Zhang, Lei
Hi Andrew, This patch series works fine for my use cases. Please feel free to add. Tested-by: Zhang, Lei I suppose v3 patches will be released. I'm looking forward to the v3 patches. Best Regards, Lei Zhang

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Marc-André Lureau
Hi On Thu, Jul 4, 2019 at 5:01 PM Li Qiang wrote: > > I have posted a fix for this several weeks ago: > > -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html Your patch looks reasonable, but I am not really able to review it. I hope Paolo and Vitaly will take care of it.

Re: [Qemu-devel] [PATCH v2] qapi: report the default CPU type for each machine

2019-07-04 Thread Daniel P . Berrangé
ping, any comments / thoughts ? On Wed, Jun 12, 2019 at 01:41:25PM +0200, Daniel P. Berrangé wrote: > When user doesn't request any explicit CPU model with libvirt or QEMU, > a machine type specific CPU model is picked. Currently there is no way > to determine what this QEMU built-in default is,

Re: [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > -

Re: [Qemu-devel] [PATCH v3 4/6] util/log: introduce dump of tbstats and -d hot_tbs:limit

2019-07-04 Thread Alex Bennée
vandersonmr writes: > add option to dump the N most hot TB blocks. > -d hot_tbs:N > and also add all tbstats dump functions. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/Makefile.objs | 1 + > accel/tcg/tb-stats.c | 293 +++ >

Re: [Qemu-devel] [PATCH v3 3/6] accel/tcg: Collecting translation/code quality measurements

2019-07-04 Thread Alex Bennée
vandersonmr writes: > Filling other tb statistics such as number of times the > tb is compiled, its number of guest/host/IR instructions... > > Signed-off-by: vandersonmr > --- > accel/tcg/translate-all.c | 14 + > accel/tcg/translator.c| 4 ++ > disas.c | 107

Re: [Qemu-devel] [PULL 0/1] Ui 20190704 patches

2019-07-04 Thread Peter Maydell
in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190704-pull-request > > for you to fetch changes up to 5b8541c6c70db776d0701bb5ce5862ae15779fb5: > > console: fix cell overflow (2019-07-03 10:57:12 +0200) > >

[Qemu-devel] [PATCH v2 0/1] Don't obey the kernel block device max transfer len / max segments for raw block devices

2019-07-04 Thread Maxim Levitsky
Linux block devices, even in O_DIRECT mode don't have any user visible limit on transfer size / number of segments, which underlying kernel block device can have. The kernel block layer takes care of enforcing these limits by splitting the bios. By limiting the transfer sizes, we force qemu to

[Qemu-devel] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-07-04 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 93 --- 1 file changed, 73 insertions(+), 20

Re: [Qemu-devel] [PULL v5 00/43] Machine and x86 queue, 2019-07-03

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 22:08, Eduardo Habkost wrote: > > Changes v4 -> v5: > * Rebase and solve conflicts with commit 374f63f6810a ("Merge remote-tracking > branch 'remotes/armbru/tags/pull-monitor-2019-07-02-v2' into staging") > > Changes v3 -> v4: > * Fix ppc64 "make check" failure > > Changes

[Qemu-devel] question:about introduce a new feature named “I/O hang”

2019-07-04 Thread wangjie (P)
Hi, everybody: I developed a feature named "I/O hang",my intention is to solve the problem like that: If the backend storage media of VM disk is far-end storage like IPSAN or FCSAN, storage net link will always disconnection and make I/O requests return EIO to Guest, and the status of

Re: [Qemu-devel] [PULL v2 0/4] Build system patches for 2019-07-02

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 12:49, Markus Armbruster wrote: > > The following changes since commit ab200dafc0e8a9925bb0ad0be478621f5f117c95: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-07-02 10:17:54 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PULL 0/9] target-arm queue

2019-07-04 Thread Peter Maydell
: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190704-pull-request' > into staging (2019-07-04 16:43:13 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190704-1 > &

Re: [Qemu-devel] [PATCH v2 17/18] iotests: add test 257 for bitmap-mode backups

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 409 +++ > tests/qemu-iotests/257.out | 2199 > tests/qemu-iotests/group |1 + > 3 files changed, 2609 insertions(+) > create mode 100755

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Marc-André Lureau
Hi On Thu, May 16, 2019 at 1:04 AM Paolo Bonzini wrote: > > From: Vitaly Kuznetsov > > It was found that Hyper-V 2016 on KVM in some configurations (q35 machine + > piix4-usb-uhci) hangs on boot. Root-cause was that one of Hyper-V > level-triggered interrupt handler performs EOI before fixing

[Qemu-devel] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-07-04 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

[Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
change log: v2: * relax the compression type setting restriction in the spec * fix qcow2 header size checking * fix error processing and messaging * fix qcow2 image specific info reporting * set Qcow2CompressionType zstd config dependant * add zstd compressed cluster

Re: [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented >

Re: [Qemu-devel] [PATCH v2 05/18] block/backup: Add mirror sync mode 'bitmap'

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > We don't need or want a new sync mode for simple differences in > semantics. Create a new mode simply named "BITMAP" that is designed to > make use of the new Bitmap Sync Mode field. > > Because the only bitmap mode is 'conditional', this adds no new >

Re: [Qemu-devel] [PATCH v2 06/18] block/backup: add 'never' policy to bitmap sync mode

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > This adds a "never" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, we never update the bitmap. This can be used > to perform differential backups, or simply to avoid the job modifying a > bitmap. > > Signed-off-by: John Snow

[Qemu-devel] [PULL 7/9] hw/timer/armv7m_systick: Forbid non-privileged accesses

2019-07-04 Thread Peter Maydell
Like most of the v7M memory mapped system registers, the systick registers are accessible to privileged code only and user accesses must generate a BusFault. We implement that for registers in the NVIC proper already, but missed it for systick since we implement it as a separate device. Correct

[Qemu-devel] [PULL 0/9] target-arm queue

2019-07-04 Thread Peter Maydell
: fix up for clash with the qapi refactor which only showed up in a build-from-clean. thanks -- PMM The following changes since commit c3e1d838cfa5aac1a6210c8ddf182d0ef7d95dd8: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190704-pull-request' into staging (2019-07-04 16:43:13 +0100

Re: [Qemu-devel] [PATCH v3 6/6] monitor: adding start_stats to monitor

2019-07-04 Thread Alex Bennée
vandersonmr writes: > adding the option to start collecting the tb > statistics later using the start_stats command. > > Signed-off-by: vandersonmr > --- > hmp-commands.hx | 15 +++ > monitor/misc.c | 15 +++ > 2 files changed, 30 insertions(+) > > diff --git

[Qemu-devel] [PATCH v2 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Igor Mammedov
tests do binary comparision so we can check tables without IASL. Move IASL condition right before decompilation step and skip it if IASL is not installed. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé --- v2: - fix typo in commit message Eric

Re: [Qemu-devel] [PATCH 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Igor Mammedov
On Thu, 4 Jul 2019 11:33:19 +0200 Philippe Mathieu-Daudé wrote: > On 7/4/19 10:27 AM, Igor Mammedov wrote: > > tests do binary comparition so we can check tables without > > IASL. Move IASL condition right before decompilation step > > and skip it if IASL is not installed. > > > >

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Paolo Bonzini
On 04/07/19 15:05, Marc-André Lureau wrote: > Hi > > On Thu, Jul 4, 2019 at 5:01 PM Li Qiang wrote: >> >> I have posted a fix for this several weeks ago: >> >> -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html > > Your patch looks reasonable, but I am not really able to

Re: [Qemu-devel] [PULL v2 00/20] testing/next for 4.1

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 00:02, Peter Maydell wrote: > NetBSD vm run seemed to get stuck. I tired a rerun, but it got stuck again on the "pkgin -y install git-base pkgconf xz python37 bash gmake gsed flex bison gnutls jpeg png SDL2 gtk3+ libxkbcommon" step. thanks -- PMM

[Qemu-devel] [PATCH] xen: Fix ring.h header

2019-07-04 Thread Anthony PERARD
The xen_[rw]?mb() macros defined in ring.h can't be used and the fact that there are gated behind __XEN_INTERFACE_VERSION__ means that it needs to be defined somewhere. QEMU doesn't implement interfaces with the Xen hypervisor so defining __XEN_INTERFACE_VERSION__ is pointless. This leads to:

Re: [Qemu-devel] [PATCH v2 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Nobody calls the function like this currently, but we neither prohibit > or cope with this behavior. I decided to make the function cope with it. > > Signed-off-by: John Snow > --- > util/hbitmap.c | 13 ++--- > 1 file changed, 10 insertions(+), 3

Re: [Qemu-devel] [PATCH for 4.1] linux-user: Fix structure target_ucontext for MIPS

2019-07-04 Thread Laurent Vivier
Le 04/07/2019 à 16:52, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Structure ucontext for MIPS is defined in the following way in > Linux kernel: > > (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) > > struct ucontext { > /* Historic fields matching asm-generic */ >

Re: [Qemu-devel] [PULL 27/27] hw/block/pflash_cfi02: Reduce I/O accesses to 16-bit

2019-07-04 Thread Philippe Mathieu-Daudé
Cc'ing PPC/taihu_405ep and ARM/Digic4 maintainers. On 7/3/19 6:36 PM, Philippe Mathieu-Daudé wrote: > On 7/3/19 6:20 PM, Stephen Checkoway wrote: >>> On Jul 3, 2019, at 12:02, Philippe Mathieu-Daudé wrote: >>> On 7/3/19 5:52 PM, Stephen Checkoway wrote: > On Jul 1, 2019, at 20:59,

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Li Qiang
I have posted a fix for this several weeks ago: -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html Thanks, Li Qiang Marc-André Lureau 于2019年7月4日周四 下午8:57写道: > Hi > > On Thu, May 16, 2019 at 1:04 AM Paolo Bonzini wrote: > > > > From: Vitaly Kuznetsov > > > > It was found

Re: [Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Gerd Hoffmann
On Thu, Jul 04, 2019 at 03:27:25PM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > I'm looking at: > > static const MemoryRegionPortio vbe_portio_list[] = { > { 0, 1, 2, .read = vbe_ioport_read_index, .write = > vbe_ioport_write_index }, > # ifdef TARGET_I386 > { 1, 1, 2, .read =

[Qemu-devel] [PATCH for-4.1] hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL

2019-07-04 Thread Peter Maydell
In the virt machine, we support TrustZone being either present or absent, and so the code must deal with the secure_sysmem pointer possibly being NULL. In the sbsa-ref machine, TrustZone is always present, but some code and comments copied from virt still treat it as possibly not being present.

Re: [Qemu-devel] [PATCH v2 08/18] hbitmap: enable merging across granularities

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Signed-off-by: John Snow > --- > util/hbitmap.c | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

[Qemu-devel] [PULL 0/9] target-arm queue

2019-07-04 Thread Peter Maydell
-arm.git tags/pull-target-arm-20190704 for you to fetch changes up to b75f3735802b5b33f10e4bfe374d4b17bb86d29a: target/arm: Correct VMOV_imm_dp handling of short vectors (2019-07-04 16:52:05 +0100) target-arm queue: * more code

[Qemu-devel] [PULL 2/9] target/arm: Restrict semi-hosting to TCG

2019-07-04 Thread Peter Maydell
From: Philippe Mathieu-Daudé Per Peter Maydell: Semihosting hooks either SVC or HLT instructions, and inside KVM both of those go to EL1, ie to the guest, and can't be trapped to KVM. Let check_for_semihosting() return False when not running on TCG. Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v2 10/18] block/dirty-bitmap: add bdrv_dirty_bitmap_get

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Add a public interface for get. While we're at it, > rename "bdrv_get_dirty_bitmap_locked" to "bdrv_dirty_bitmap_get_locked". > > (There are more functions to rename to the bdrv_dirty_bitmap_VERB form, > but they will wait until the conclusion of this

Re: [Qemu-devel] [PATCH v2 16/18] iotests: Add virtio-scsi device helper

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Seems that it comes up enough. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/040| 6 +- > tests/qemu-iotests/093| 6 ++ > tests/qemu-iotests/139| 7 ++- > tests/qemu-iotests/238| 5 + >

Re: [Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce multiple paths

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Use "FilePaths" instead of "FilePath" to request multiple files be > cleaned up after we leave that object's scope. > > This is not crucial; but it saves a little typing. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 33

[Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only compression method available. The performance test results: Test compresses and

Re: [Qemu-devel] [PULL 18/21] build: don't build hardware objects with linux-user

2019-07-04 Thread Philippe Mathieu-Daudé
On 5/21/19 10:16 PM, Laurent Vivier wrote: > On 21/05/2019 14:54, Daniel P. Berrangé wrote: >> On Tue, May 21, 2019 at 02:52:42PM +0200, Laurent Vivier wrote: >>> On 21/05/2019 13:52, Daniel P. Berrangé wrote: On Wed, May 15, 2019 at 10:50:30PM +0200, Paolo Bonzini wrote: > From: Laurent

Re: [Qemu-devel] [PATCH v3 2/6] accel/tcg: Adding an optional tb execution counter

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We add the option to instrument each TB to > count the number of times it is executed and > store this in the its TBStatistics struct. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/tcg-runtime.c | 7 +++ > accel/tcg/tcg-runtime.h | 2 ++ >

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Liran Alon
> On 4 Jul 2019, at 18:29, Paolo Bonzini wrote: > > On 04/07/19 16:31, Liran Alon wrote: >> >> >>> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: >>> >>> On 25/06/19 01:05, Liran Alon wrote: When vCPU is in VMX operation and enters SMM mode, it temporarily exits VMX operation but

[Qemu-devel] pl031 time across vm save/reload

2019-07-04 Thread Peter Maydell
I've had a report that the way the PL031 model handles time across a vm save/reload fails to correctly advance the guest RTC when the host RTC has advanced between the save and reload. I looked at the code and my correspondent's analysis (which I quote below, lightly edited) looks correct to me,

[Qemu-devel] [PULL 8/9] target/arm: Execute Thumb instructions when their condbits are 0xf

2019-07-04 Thread Peter Maydell
Thumb instructions in an IT block are set up to be conditionally executed depending on a set of condition bits encoded into the IT bits of the CPSR/XPSR. The architecture specifies that if the condition bits are 0b this means "always execute" (like 0b1110), not "never execute"; we were

[Qemu-devel] [PULL 4/9] arm v8M: Forcibly clear negative-priority exceptions on deactivate

2019-07-04 Thread Peter Maydell
To prevent execution priority remaining negative if the guest returns from an NMI or HardFault with a corrupted IPSR, the v8M interrupt deactivation process forces the HardFault and NMI to inactive based on the current raw execution priority, even if the interrupt the guest is trying to deactivate

Re: [Qemu-devel] [PULL v2 6/8] vmdk: Add read-only support for seSparse snapshots

2019-07-04 Thread Peter Maydell
On Tue, 2 Jul 2019 at 20:46, Max Reitz wrote: > So it looks to me like Coverity just thinks that *extent may be used > concurrently. Or it's just not smart enough to notice that it's assumed several mutually contradictory things... > Short of adding a “restrict”, I don’t know what to do > this

Re: [Qemu-devel] [PATCH v2 12/18] block/backup: add 'always' bitmap sync policy

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > This adds an "always" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, the bitmap is *always* synchronized. This means > that for backups that fail part-way through, the bitmap retains a record of > which sectors need to be

Re: [Qemu-devel] [PULL 0/2] vfio fixes 2019-07-02

2019-07-04 Thread Peter Maydell
On Tue, 2 Jul 2019 at 23:36, Alex Williamson wrote: > > The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' > into staging (2019-07-02 18:56:44 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v2 03/21] hw: timer: Add ASPEED RTC device

2019-07-04 Thread Peter Maydell
On Thu, 4 Jul 2019 at 08:49, Joel Stanley wrote: > > On Tue, 2 Jul 2019 at 19:19, Peter Maydell wrote: > > > > On Tue, 18 Jun 2019 at 17:53, Cédric Le Goater wrote: > > > > > > From: Joel Stanley > > > > > > The RTC is modeled to provide time and date functionality. It is > > > initialised at

Re: [Qemu-devel] [PULL 0/1] Audio 20190703 patches

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 07:57, Gerd Hoffmann wrote: > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH v2] qapi: report the default CPU type for each machine

2019-07-04 Thread Igor Mammedov
On Wed, 12 Jun 2019 13:41:25 +0200 Daniel P. Berrangé wrote: > When user doesn't request any explicit CPU model with libvirt or QEMU, > a machine type specific CPU model is picked. Currently there is no way > to determine what this QEMU built-in default is, so libvirt cannot > report this back

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Liran Alon
> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: > > On 25/06/19 01:05, Liran Alon wrote: >> When vCPU is in VMX operation and enters SMM mode, >> it temporarily exits VMX operation but KVM maintained nested-state >> still stores the VMXON region physical address, i.e. even when the >> vCPU is

Re: [Qemu-devel] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Create a common core that comprises the actual meat of what the backup API > boundary needs to do, and then switch drive-backup to use it. > > Questions: > - do_drive_backup now acquires and releases the aio_context in addition >to do_backup_common doing

Re: [Qemu-devel] [PATCH v2 03/18] blockdev-backup: utilize do_backup_common

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 73 +++--- > 1 file changed, 3 insertions(+), 70 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode Type: series Message-id:

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-04 Thread Stefan Hajnoczi
On Mon, Jul 01, 2019 at 07:01:12PM +0100, Peter Maydell wrote: > On Mon, 1 Jul 2019 at 18:50, Alistair Francis > wrote: > > > > On Mon, 2019-07-01 at 17:54 +0100, Peter Maydell wrote: > > > On Thu, 27 Jun 2019 at 16:24, Palmer Dabbelt > > > wrote: > > > > From: Alistair Francis > > > Also, new

Re: [Qemu-devel] [PULL 0/9] target-arm queue

2019-07-04 Thread Peter Maydell
19-07-04 15:58:46 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190704 > > for you to fetch changes up to b75f3735802b5b33f10e4bfe374d4b17bb86d29a: > > target/arm: Correc

Re: [Qemu-devel] [PATCH v3 4/6] util/log: introduce dump of tbstats and -d hot_tbs:limit

2019-07-04 Thread Alex Bennée
vandersonmr writes: > add option to dump the N most hot TB blocks. > -d hot_tbs:N > and also add all tbstats dump functions. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/Makefile.objs | 1 + > accel/tcg/tb-stats.c | 293 +++ >

Re: [Qemu-devel] [PATCH v2 12/18] block/backup: add 'always' bitmap sync policy

2019-07-04 Thread Max Reitz
On 04.07.19 19:43, Max Reitz wrote: > On 03.07.19 23:55, John Snow wrote: >> This adds an "always" policy for bitmap synchronization. Regardless of if >> the job succeeds or fails, the bitmap is *always* synchronized. This means >> that for backups that fail part-way through, the bitmap retains a

[Qemu-devel] [PATCH] hw/i386: Fix linker error when ISAPC is disabled

2019-07-04 Thread Julio Montes
How about a new header file with all devices? (see below patch) --- Makefile.target | 5 + hw/i386/pc_piix.c | 11 --- include/qemu/osdep.h | 1 + scripts/create_config | 2 ++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Makefile.target

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-04 Thread David Gibson
On Thu, Jul 04, 2019 at 10:12:04AM +0200, Greg Kurz wrote: > On Thu, 4 Jul 2019 10:23:57 +1000 > David Gibson wrote: > > > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > > ics_set_kvm_state_one() is called either during reset, in which case > > > both 'saved priority' and

[Qemu-devel] [Bug 1835477] [NEW] Converting qcow2 to vmdk on MacOSX results in a non-bootable image

2019-07-04 Thread Moshe Immerman
Public bug reported: When using qemu-img convert -O vmdk with version 3.1.0 or 4.0.0 on OSX (10.14.3) with a qcow2 image (https://cloud- images.ubuntu.com/bionic/20190703/bionic-server-cloudimg-amd64.img), the resulting image is not bootable. Running the same command on Ubuntu 18.04 results in

Re: [Qemu-devel] [RFC PATCH qemu] vfio-quirks: Pass the actual parent when deleting a memory region

2019-07-04 Thread David Gibson
On Fri, Jul 05, 2019 at 01:25:01PM +1000, Alexey Kardashevskiy wrote: > The usual way of using a quirk's MR is to add it as a subregion of a BAR > as this is what quirks are for. However there is less than standard user > of this - NVLink2-enabled NVIDIA GPU which exposes a GPU RAM and a ATSD >

[Qemu-devel] [Bug 1834113] Re: QEMU touchpad input erratic after wakeup from sleep

2019-07-04 Thread Christian Ehrhardt 
Hi Avi, for the sake of giving it a try I had a second level guest and suspended/resumed the first level guest a few times. I can't reproduce it. OTOH you seem to have a hard time to identify which change introduced this - if it was any change at all and not just by accident not showing up

Re: [Qemu-devel] [PULL 0/4] Python queue, 2019-07-01

2019-07-04 Thread Peter Maydell
On Mon, 1 Jul 2019 at 23:29, Eduardo Habkost wrote: > > The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 > 17:40:32 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH 1/2] tests: acpi: do not require IASL for dumping AML blobs

2019-07-04 Thread Auger Eric
Hi Igor, On 7/4/19 10:27 AM, Igor Mammedov wrote: > IASL isn't needed when dumping ACPI tables from guest for > rebuild purposes. So move this part out from IASL branch. > > Makes rebuild-expected-aml.sh work without IASL installed > on host. > > Signed-off-by: Igor Mammedov > --- >

  1   2   >