[Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements

2019-08-14 Thread David Hildenbrand
Wrong order of operands. The constant always comes last. Makes QEMU crash reliably on specific git fetch invocations. Reported-by: Stefano Brivio Signed-off-by: David Hildenbrand --- I guess it is too late for 4.1 :( --- target/s390x/translate_vx.inc.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

2019-08-14 Thread Eric Blake
On 8/14/19 4:11 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.08.2019 0:31, Max Reitz wrote: >> On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: >>> Further patch will run partial requests of iterations of >>> qcow2_co_preadv in parallel for performance reasons. To prepare for >>> this,

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 16:26, Max Reitz wrote: > On 12.08.19 13:09, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> This includes some permission limiting (for example, we only need to >>> take the RESIZE permission for active commits where the base is smaller >>> than the top).

Re: [Qemu-devel] [PATCH 2/6] migration: Make global sem_sync semaphore by channel

2019-08-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This makes easy to debug things because when you want for all threads > to arrive at that semaphore, you know which one your are waiting for. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert and queued. > --- >

[Qemu-devel] [PATCH 3/4] block/backup: use bdrv_dirty_bitmap_next_dirty

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
Use more effective search for next dirty byte. Trace point is dropped to not introduce additional variable and logic only for trace point. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 7 +++ block/trace-events | 1 - 2 files changed, 3 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 1/4] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
It's very uncomfortable that we can't use same variable as result of bdrv_dirty_bitmap_next_zero and parameter of bdrv_dirty_bitmap_next_dirty_area. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 6 +++--- include/qemu/hbitmap.h | 5 ++---

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-14 Thread Andrea Bolognani
On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: > > > The libssh packaged by a distribution can predate version 0.8, > > > but still provides the newer API introduced

Re: [Qemu-devel] [PATCH 3/6] migration: Make sure that all multifd channels have been created

2019-08-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If we start the migration before all have been created, we have to > handle the case that one channel still don't exist. This way it is > easier. > > Signed-off-by: Juan Quintela > --- > migration/ram.c| 14 ++ >

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-14 Thread Philippe Mathieu-Daudé
On 8/14/19 4:51 PM, Andrea Bolognani wrote: > On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: >> On 8/14/19 3:27 PM, Andrea Bolognani wrote: >>> On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: The libssh packaged by a distribution can predate version 0.8,

[Qemu-devel] [PATCH v4] riscv: hmp: Add a command to show virtual memory mappings

2019-08-14 Thread Bin Meng
This adds 'info mem' command for RISC-V, to show virtual memory mappings that aids debugging. Rather than showing every valid PTE, the command compacts the output by merging all contiguous physical address mappings into one block and only shows the merged block mapping details. Signed-off-by:

Re: [Qemu-devel] [PATCH] riscv: hmp: Add a command to show virtual memory mappings

2019-08-14 Thread Bin Meng
Hi Palmer, On Wed, Aug 14, 2019 at 9:35 AM Bin Meng wrote: > > Hi Palmer, > > On Tue, Aug 13, 2019 at 11:18 PM Palmer Dabbelt wrote: > > > > On Wed, 31 Jul 2019 05:49:15 PDT (-0700), bmeng...@gmail.com wrote: > > > This adds 'info mem' command for RISC-V, to show virtual memory > > > mappings

Re: [Qemu-devel] [PATCH 1/3] riscv: sifive_u: Add support for loading initrd

2019-08-14 Thread Palmer Dabbelt
On Mon, 12 Aug 2019 16:48:00 PDT (-0700), bmeng...@gmail.com wrote: Hi Palmer, On Tue, Aug 13, 2019 at 6:45 AM Palmer Dabbelt wrote: On Fri, 19 Jul 2019 06:40:43 PDT (-0700), li...@roeck-us.net wrote: > Add support for loading initrd with "-initrd " > to the sifive_u machine. This lets us

Re: [Qemu-devel] [PATCH] virtio-pci: Add Function Level Reset support

2019-08-14 Thread Julia Suvorova
On Fri, Aug 9, 2019 at 6:35 PM Michael S. Tsirkin wrote: > > On Wed, Aug 07, 2019 at 10:22:41AM +0200, Julia Suvorova wrote: > > Using FLR becomes convenient in cases where resetting the bus is > > impractical, for example, when debugging the behavior of individual > > functions. > > > >

Re: [Qemu-devel] [PATCH 1/2] memory: Align and add helper for comparing MemoryRegionSections

2019-08-14 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Hi David, > > On 8/13/19 12:29 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > MemoryRegionSection includes an Int128 'size' field; > > on some platforms the compiler causes an alignment of this to > > a

Re: [Qemu-devel] [PATCH 1/2] memory: Align and add helper for comparing MemoryRegionSections

2019-08-14 Thread Philippe Mathieu-Daudé
On 8/14/19 7:25 PM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >> Hi David, >> >> On 8/13/19 12:29 PM, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> MemoryRegionSection includes an Int128 'size' field; >>> on some platforms

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v2 2/6] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-14 Thread Thomas Huth
On 8/14/19 9:23 AM, David Hildenbrand wrote: > Instructions are always fetched from primary address space, except when > in home address mode. Perform the selection directly in cpu_mmu_index(). > > get_mem_index() is only used to perform data access, instructions are > fetched via

Re: [Qemu-devel] [PATCH 1/2] memory: Align and add helper for comparing MemoryRegionSections

2019-08-14 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 8/14/19 7:25 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > >> Hi David, > >> > >> On 8/13/19 12:29 PM, Dr. David Alan Gilbert (git) wrote: > >>> From: "Dr. David Alan Gilbert" > >>> > >>>

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v2 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails

2019-08-14 Thread Thomas Huth
On 8/14/19 9:23 AM, David Hildenbrand wrote: > We want to trace the actual return value, not "0". > > Reviewed-by: Cornelia Huck > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

[Qemu-devel] Question about libvhost-user and vhost-user-bridge.c

2019-08-14 Thread William Tu
Hi, I'm using libvhost-user.a to write a vhost backend, in order to receive and send packets from/to VMs from OVS. I started by reading the vhost-user-bridge.c. I can now pass the initialization stage, seeing .queue_set_started get invoked. However, I am stuck at receiving the packet from VM. So

[Qemu-devel] [PATCH v2 2/3] memory: Provide an equality function for MemoryRegionSections

2019-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Provide a comparison function that checks all the fields are the same. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 12 1 file changed, 12 insertions(+) diff --git a/include/exec/memory.h

[Qemu-devel] [PATCH v2 0/3] Fix MemoryRegionSection alignment and comparison

2019-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This fixes a symptom I've seen on vhost-user on aarch64 where the daemon would be falsely notified of memory region changes that didn't exist. The underlying problem was me memcmp'ing MemoryRegionSections even though they had padding in. (Discovered while getting

[Qemu-devel] [PATCH v2 1/3] memory: Align MemoryRegionSections fields

2019-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" MemoryRegionSection includes an Int128 'size' field; on some platforms the compiler causes an alignment of this to a 128bit boundary, leaving 8 bytes of dead space. This deadspace can be filled with junk. Move the size field to the top avoiding unnecessary

[Qemu-devel] [PATCH v2 3/3] vhost: Fix memory region section comparison

2019-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Using memcmp to compare structures wasn't safe, as I found out on ARM when I was getting falce miscompares. Use the helper function for comparing the MRSs. Fixes: ade6d081fc33948e56e6 Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 9 +++-- 1

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v2 6/6] s390x/mmu: Factor out storage key handling

2019-08-14 Thread Thomas Huth
On 8/14/19 9:23 AM, David Hildenbrand wrote: > Factor it out, add a comment how it all works, and also use it in the > REAL MMU. > > Reviewed-by: Cornelia Huck > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 113 +++--- > 1 file changed,

Re: [Qemu-devel] [PATCH-4.2 v2 5/5] target/riscv: Fix Floating Point register names

2019-08-14 Thread Palmer Dabbelt
On Tue, 13 Aug 2019 10:06:58 PDT (-0700), alistai...@gmail.com wrote: On Mon, Aug 12, 2019 at 4:08 PM Palmer Dabbelt wrote: On Tue, 30 Jul 2019 16:35:34 PDT (-0700), Alistair Francis wrote: > From: Atish Patra > > As per the RISC-V spec, Floating Point registers are named as f0..f31 > so

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v2 6/6] s390x/mmu: Factor out storage key handling

2019-08-14 Thread David Hildenbrand
On 14.08.19 20:01, Thomas Huth wrote: > On 8/14/19 9:23 AM, David Hildenbrand wrote: >> Factor it out, add a comment how it all works, and also use it in the >> REAL MMU. >> >> Reviewed-by: Cornelia Huck >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/mmu_helper.c | 113

Re: [Qemu-devel] [PATCH v2] RISC-V: Ignore the S and U letters when formatting ISA strings

2019-08-14 Thread Alistair Francis
On Tue, Aug 13, 2019 at 3:54 PM Palmer Dabbelt wrote: > > The ISA strings we're providing from QEMU aren't actually legal RISC-V > ISA strings, as both S and U cannot exist as single-letter extensions > and must instead be multi-letter strings. We're still using the ISA > strings inside QEMU to

Re: [Qemu-devel] [RFC] dirty-bitmaps: add block-dirty-bitmap-persist command

2019-08-14 Thread John Snow
On 8/13/19 8:08 PM, Eric Blake wrote: > On 8/13/19 5:44 PM, John Snow wrote: >> This is for the purpose of toggling on/off persistence on a bitmap. >> This enables you to save a bitmap that was not persistent, but may >> have already accumulated valuable data. >> >> This is simply a QOL

Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

2019-08-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1565799261-498-1-git-send-email...@us.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction Message-id:

Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

2019-08-14 Thread Paul Clarke
Should these 'checkpatch' ERRORs be addressed, even if it will diverge the code style from the existing, surrounding code? On 8/14/19 11:30 AM, no-re...@patchew.org wrote: > This series seems to have some coding style problems. See output below for > more information: > === OUTPUT BEGIN === >

Re: [Qemu-devel] [PATCH v3 13/14] migration/ram: add support to send encrypted pages

2019-08-14 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, the guest memory will be encrypted with > the guest specific key. The patch introduces RAM_SAVE_FLAG_ENCRYPTED_PAGE > flag to distinguish the encrypted data from plaintext. Encrypted pages > may need special

Re: [Qemu-devel] [PATCH 0/4] configure: Fix libssh on Ubuntu 18.04

2019-08-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190814121527.17876-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy написал: Hi all! There is a bug in not yet merged patch "block/backup: teach TOP to never copy unallocated regions" in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose to put 01-03 somewhere before

<    1   2   3