Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-19 Thread Peter Xu
On Mon, Aug 12, 2019 at 09:45:27AM +0200, Peter Xu wrote: > This is a RFC series. > > The VT-d code has some defects, one of them is that we cannot detect > the misuse of vIOMMU and vfio-pci early enough. > > For example, logically this is not allowed: > > -device intel-iommu,caching-mode=off

[Qemu-devel] [PATCH v2 1/2] memory: Inherit has_coalesced_range from the same old FlatRange

2019-08-19 Thread Peter Xu
The previous has_coalesced_range counter has a problem in that it only works for additions of coalesced mmio ranges but not deletions. The reason is that has_coalesced_range information can be lost when the FlatView updates the topology again when the updated region is not covering the coalesced

[Qemu-devel] [PATCH v2 0/2] memory: Fix up coalesced_io_del not working for KVM

2019-08-19 Thread Peter Xu
v2: - simply migrate has_coalesced_range in patch 1, while I added comments in the code because that can be a bit unobvious [Paolo] v1 is here: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg03293.html Peter Xu (2): memory: Inherit has_coalesced_range from the same old FlatRange

[Qemu-devel] [PATCH v2 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Peter Xu
It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO interface. The kernel interface only allows to unregister an mmio device with exactly the zone size when registered, or any smaller zone that is included in the device mmio zone. It does not support the userspace to specify a very

Re: [Qemu-devel] [PATCH 1/2] memory: Replace has_coalesced_range with add/del flags

2019-08-19 Thread Peter Xu
On Mon, Aug 19, 2019 at 04:30:45PM +0200, Paolo Bonzini wrote: > On 17/08/19 11:32, Peter Xu wrote: > > The previous has_coalesced_range counter has a problem in that it only > > works for additions of coalesced mmio ranges but not deletions. The > > reason is that has_coalesced_range information

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Peng Tao
On 2019/8/20 00:04, Stefan Hajnoczi wrote: I am delighted to announce the release of virtio-fs v0.3, a shared file system that lets virtual machines access a directory tree on the host. This release is based on QEMU 4.1.0 and Linux 5.3-rc3. Good news! As virtio-fs is maturing and

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Xu Wang
Thanks all the contributors, looking forward to having a product virtio-fs deployment shortly. > On Aug 20, 2019, at 12:04 AM, Stefan Hajnoczi wrote: > > I am delighted to announce the release of virtio-fs v0.3, a shared file > system that lets virtual machines access a directory tree on the

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Edgar E. Iglesias
On Mon, 19 Aug. 2019, 23:01 Richard Henderson, wrote: > On 8/19/19 11:29 AM, Paolo Bonzini wrote: > > On 19/08/19 20:28, Paolo Bonzini wrote: > >> On 16/08/19 12:12, Thomas Huth wrote: > >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the > >>> filter of the qemu-s390x

Re: [Qemu-devel] [PATCH v2] ppc: conform to processor User's Manual for xscvdpspn

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 12:43:21PM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > The POWER8 and POWER9 User's Manuals specify the implementation > behavior for what the ISA leaves "undefined" behavior for the > xscvdpspn and xscvdpsp instructions. This patch corrects the QEMU >

Re: [Qemu-devel] [PATCH] ppc: Fix emulated INFINITY and NAN conversions

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 01:57:42PM -0700, Richard Henderson wrote: > On 8/19/19 12:19 PM, Paul A. Clarke wrote: > > From: "Paul A. Clarke" > > > > helper_todouble() was not properly converting INFINITY from 32 bit > > float to 64 bit double. > > > > (Normalized operand conversion is unchanged,

Re: [Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 04:42:16PM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > helper_todouble() was not properly converting any denormalized 32 bit > float to 64 bit double. > > Fix-suggested-by: Richard Henderson > Signed-off-by: Paul A. Clarke > > v2: > - Splitting patch

Re: [Qemu-devel] RISCV: when will the CLIC be ready?

2019-08-19 Thread Bin Meng
On Tue, Aug 20, 2019 at 3:09 AM Alistair Francis wrote: > > On Mon, Aug 19, 2019 at 6:44 AM liuzhiwei wrote: > > > > > > On 2019/8/17 上午1:29, Alistair Francis wrote: > > > On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei wrote: > > >> Hi, Palmer > > >> > > >> When Michael Clark still was the

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-19 Thread Brad Parker
Just FYI that was the second bisect I had to do, the first time it produced an even more unrelated commit, so I assumed I must have done something wrong... apparently that is still the case. After trying the "working" commit outside of the Docker container, it now does not work... so I'm at a loss

Re: [Qemu-devel] [Virtio-fs] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread piaojun
A big step for virtio-fs! Jun On 2019/8/20 0:04, Stefan Hajnoczi wrote: > I am delighted to announce the release of virtio-fs v0.3, a shared file > system that lets virtual machines access a directory tree on the host. > This release is based on QEMU 4.1.0 and Linux 5.3-rc3. > > For more

Re: [Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread Aleksandar Markovic
20.08.2019. 00.32, "Paul A. Clarke" је написао/ла: > > From: "Paul A. Clarke" > > helper_todouble() was not properly converting any denormalized 32 bit > float to 64 bit double. > > Fix-suggested-by: Richard Henderson > Signed-off-by: Paul A. Clarke > > v2: > - Splitting patch "ppc: Three

Re: [Qemu-devel] Machine specific option ROMs

2019-08-19 Thread BALATON Zoltan
On Mon, 19 Aug 2019, Gerd Hoffmann wrote: > On Mon, Aug 19, 2019 at 02:38:09AM +0200, BALATON Zoltan wrote: >> I know about the possibility to set the option ROM of a PCIDevice with the >> romfile property (that we can set on command line or in a device's init >> method) but is there a way to set

[Qemu-devel] [Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2019-08-19 Thread Philippe Mathieu-Daudé
Bisected following note from http://gunkies.org/wiki/I386-softmmu: the isapc configuration no longer works... So legacy systems must resort to Qemu 0.9.0 or Qemu 0.10.0 I get: fd646122418ecefcde228d43821d07da79dd99bb is the first bad commit commit fd646122418ecefcde228d43821d07da79dd99bb

[Qemu-devel] [Bug 1840719] [NEW] win98se floppy fails to boot with isapc machine

2019-08-19 Thread Philippe Mathieu-Daudé
Public bug reported: QEMU emulator version 4.1.50 (commit 50d69ee0d) floppy image from: https://winworldpc.com/download/417d71c2-ae18-c39a-11c3-a4e284a2c3a5 $ qemu-system-i386 -M isapc -fda Windows\ 98\ Second\ Edition\ Boot.img SeaBIOS (version rel-1.12.1-0...) Booting from Floppy... Boot

Re: [Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree

2019-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190819213755.26175-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree

[Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread Paul A. Clarke
From: "Paul A. Clarke" helper_todouble() was not properly converting any denormalized 32 bit float to 64 bit double. Fix-suggested-by: Richard Henderson Signed-off-by: Paul A. Clarke v2: - Splitting patch "ppc: Three floating point fixes"; this is just one part. - Original suggested "fix"

[Qemu-devel] [PATCH v2 68/68] target/arm: Inline gen_bx_im into callers

2019-08-19 Thread Richard Henderson
There are only two remaining uses of gen_bx_im. In each case, we know the destination mode -- not changing in the case of gen_jmp or changing in the case of trans_BLX_i. Use this to simplify the surrounding code. For trans_BLX_i, use gen_jmp for the actual branch. For gen_jmp, use

[Qemu-devel] [PATCH v2 67/68] target/arm: Clean up disas_thumb_insn

2019-08-19 Thread Richard Henderson
Now that everything is converted, remove the rest of the legacy decode. Signed-off-by: Richard Henderson --- target/arm/translate.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 89 +++--- target/arm/t16.decode | 3 ++ 2 files changed, 43 insertions(+), 49 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 51b14d409f..f8997a8424 100644 ---

[Qemu-devel] [PATCH v2 65/68] target/arm: Convert T16, Unconditional branch

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 9 ++--- target/arm/t16.decode | 6 ++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 1882057402..51b14d409f 100644 --- a/target/arm/translate.c +++

[Qemu-devel] [PATCH v2 58/68] target/arm: Convert T16, nop hints

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 3 +-- target/arm/t16.decode | 17 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 176cba2992..67f0202d29 100644 --- a/target/arm/translate.c

[Qemu-devel] [PATCH v2 63/68] target/arm: Convert T16, shift immediate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 ++ target/arm/t16.decode | 8 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index dc670c9724..dc3c9049cd 100644 ---

[Qemu-devel] [PATCH v2 53/68] target/arm: Convert T16 add, compare, move (two high registers)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 49 ++ target/arm/t16.decode | 10 + 2 files changed, 12 insertions(+), 47 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 60bfc943a3..e639059a5a 100644

[Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 109 - target/arm/t16.decode | 31 2 files changed, 54 insertions(+), 86 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 941266df14..dc670c9724

[Qemu-devel] [PATCH v2 52/68] target/arm: Convert T16 branch and exchange

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 64 +++--- target/arm/t16.decode | 10 +++ 2 files changed, 33 insertions(+), 41 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 3a3b113822..60bfc943a3 100644

[Qemu-devel] [PATCH v2 61/68] target/arm: Convert T16, Conditional branches, Supervisor call

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 +++--- target/arm/t16.decode | 12 2 files changed, 15 insertions(+), 23 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 5f876290ba..941266df14 100644 ---

[Qemu-devel] [PATCH v2 51/68] target/arm: Convert T16 one low register and immediate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 44 ++ target/arm/t16.decode | 11 +++ 2 files changed, 13 insertions(+), 42 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 6f30415371..3a3b113822

[Qemu-devel] [PATCH v2 57/68] target/arm: Convert T16, Reverse bytes

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 18 +++--- target/arm/t16.decode | 9 + 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 368f0ab147..176cba2992 100644 ---

[Qemu-devel] [PATCH v2 50/68] target/arm: Convert T16 add/sub (3 low, 2 low and imm)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 ++ target/arm/t16.decode | 16 2 files changed, 18 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d417958b23..6f30415371 100644 ---

[Qemu-devel] [PATCH v2 47/68] target/arm: Convert T16 load/store (immediate offset)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 94 +++--- target/arm/t16.decode | 33 +++ 2 files changed, 38 insertions(+), 89 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index e19961fb6c..24537fc107

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-08-19 Thread Josh Kunz via Qemu-devel
Hi all, I have also experienced issues with SIGRTMIN + 1, and am interested in moving this patch forwards. Anything I can do here to help? Would the maintainers prefer myself or Marli re-submit the patch? The Go issue here seems particularly sticky. Even if we update the Go runtime, users may

[Qemu-devel] [PATCH v2 48/68] target/arm: Convert T16 add pc/sp (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 12 +--- target/arm/t16.decode | 7 +++ 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 24537fc107..2640f50fcf 100644 --- a/target/arm/translate.c +++

[Qemu-devel] [PATCH v2 42/68] target/arm: Simplify disas_thumb2_insn

2019-08-19 Thread Richard Henderson
Fold away all of the cases that now just goto illegal_op, because all of their internal bits are now in decodetree. Signed-off-by: Richard Henderson --- target/arm/translate.c | 79 ++ 1 file changed, 3 insertions(+), 76 deletions(-) diff --git

[Qemu-devel] [PATCH v2 60/68] target/arm: Convert T16, push and pop

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 83 ++ target/arm/t16.decode | 10 + 2 files changed, 22 insertions(+), 71 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9e0345adf7..5f876290ba 100644 ---

[Qemu-devel] [PATCH v2 64/68] target/arm: Convert T16, load (literal)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 42 ++ target/arm/t16.decode | 4 2 files changed, 6 insertions(+), 40 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index dc3c9049cd..1882057402 100644 ---

[Qemu-devel] [PATCH v2 43/68] target/arm: Simplify disas_arm_insn

2019-08-19 Thread Richard Henderson
Fold away all of the cases that now just goto illegal_op, because all of their internal bits are now in decodetree. Signed-off-by: Richard Henderson --- target/arm/translate.c | 69 ++ 1 file changed, 16 insertions(+), 53 deletions(-) diff --git

[Qemu-devel] [PATCH v2 38/68] target/arm: Convert Unallocated memory hint

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 target/arm/a32-uncond.decode | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index a30a9bb4e0..9ec6b25c03 100644 ---

[Qemu-devel] [PATCH v2 59/68] target/arm: Split gen_nop_hint

2019-08-19 Thread Richard Henderson
Now that there all callers pass a constant value, split the switch statement into the individual trans_* functions. Signed-off-by: Richard Henderson --- target/arm/translate.c | 67 +++--- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git

[Qemu-devel] [PATCH v2 56/68] target/arm: Convert T16, Change processor state

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 85 -- target/arm/t16.decode | 12 ++ 2 files changed, 52 insertions(+), 45 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 414c562fb3..368f0ab147 100644

[Qemu-devel] [PATCH v2 44/68] target/arm: Add skeleton for T16 decodetree

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 6 ++ target/arm/Makefile.objs | 6 ++ target/arm/t16.decode| 20 3 files changed, 32 insertions(+) create mode 100644 target/arm/t16.decode diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 37/68] target/arm: Convert PLI, PLD, PLDW

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 37 +++- target/arm/a32-uncond.decode | 10 ++ 2 files changed, 30 insertions(+), 17 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 46e88d1d17..a30a9bb4e0

[Qemu-devel] [PATCH v2 54/68] target/arm: Convert T16 adjust sp (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 15 ++- target/arm/t16.decode | 9 + 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index e639059a5a..cac3893386 100644 ---

[Qemu-devel] [PATCH v2 34/68] target/arm: Convert Clear-Exclusive, Barriers

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 122 +++ target/arm/a32-uncond.decode | 10 +++ target/arm/t32.decode| 10 +++ 3 files changed, 73 insertions(+), 69 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 55/68] target/arm: Convert T16, extract

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 14 +- target/arm/t16.decode | 10 ++ 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index cac3893386..414c562fb3 100644 ---

[Qemu-devel] [PATCH v2 36/68] target/arm: Convert SETEND

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 22 +- target/arm/a32-uncond.decode | 4 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 928205d993..46e88d1d17 100644 ---

[Qemu-devel] [PATCH v2 46/68] target/arm: Convert T16 load/store (register offset)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 51 ++ target/arm/t16.decode | 15 + 2 files changed, 17 insertions(+), 49 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c5769bd42..e19961fb6c

[Qemu-devel] [PATCH v2 26/68] target/arm: Convert MOVW, MOVT

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 89 -- target/arm/a32.decode | 6 +++ target/arm/t32.decode | 9 + 3 files changed, 48 insertions(+), 56 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 87 +++- target/arm/a32-uncond.decode | 3 ++ target/arm/t32.decode| 3 ++ 3 files changed, 42 insertions(+), 51 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 49/68] target/arm: Convert T16 load/store multiple

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 48 -- target/arm/t16.decode | 8 +++ 2 files changed, 17 insertions(+), 39 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 2640f50fcf..d417958b23 100644

[Qemu-devel] [PATCH v2 41/68] target/arm: Convert TT

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 87 +- target/arm/t32.decode | 5 ++- 2 files changed, 31 insertions(+), 61 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9a8864e8ff..d1078ca1ec 100644 ---

[Qemu-devel] [PATCH v2 45/68] target/arm: Convert T16 data-processing (two low regs)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 152 ++--- target/arm/t16.decode | 36 ++ 2 files changed, 43 insertions(+), 145 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 90d608a2d2..7c5769bd42

[Qemu-devel] [PATCH v2 25/68] target/arm: Convert Signed multiply, signed and unsigned divide

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 463 ++--- target/arm/a32.decode | 22 ++ target/arm/t32.decode | 18 ++ 3 files changed, 247 insertions(+), 256 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 33/68] target/arm: Convert RFE and SRS

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 150 ++- target/arm/a32-uncond.decode | 8 ++ target/arm/t32.decode| 12 +++ 3 files changed, 81 insertions(+), 89 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 40/68] target/arm: Convert SG

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 51 -- target/arm/t32.decode | 5 - 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c05e7006e..9a8864e8ff 100644 ---

[Qemu-devel] [PATCH v2 32/68] target/arm: Convert SVC

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 19 +-- target/arm/a32.decode | 4 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 6b7b3df685..b6d8b7be8c 100644 --- a/target/arm/translate.c

[Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 24 +--- target/arm/a32.decode | 1 + target/arm/t32.decode | 19 +++ 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 39/68] target/arm: Convert Table Branch

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 57 +- target/arm/t32.decode | 8 +- 2 files changed, 41 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9ec6b25c03..7c05e7006e 100644

[Qemu-devel] [PATCH v2 24/68] target/arm: Convert Packing, unpacking, saturation, and reversal

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 541 ++--- target/arm/a32.decode | 32 +++ target/arm/t32.decode | 37 ++- 3 files changed, 300 insertions(+), 310 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 31/68] target/arm: Convert B, BL, BLX (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 133 +++ target/arm/a32-uncond.decode | 8 +++ target/arm/a32.decode| 8 +++ target/arm/t32.decode| 81 - 4 files changed, 123 insertions(+), 107

[Qemu-devel] [PATCH v2 17/68] target/arm: Convert ERET

2019-08-19 Thread Richard Henderson
Pass the T5 encoding of SUBS PC, LR, #IMM through the normal SUBS path to make it clear exactly what's happening -- we hit ALUExceptionReturn along that path. Signed-off-by: Richard Henderson --- target/arm/translate.c | 58 ++ target/arm/a32.decode | 2

[Qemu-devel] [PATCH v2 30/68] target/arm: Diagnose base == pc for LDM/STM

2019-08-19 Thread Richard Henderson
We have been using store_reg and not store_reg_for_load when writing back a loaded value into the base register. At first glance this is incorrect when base == pc, however that case is UNPREDICTABLE. Signed-off-by: Richard Henderson --- target/arm/translate.c | 9 + 1 file changed, 9

[Qemu-devel] [PATCH v2 27/68] target/arm: Convert LDM, STM

2019-08-19 Thread Richard Henderson
This includes a minor bug fix to LDM (user), which requires bit 21 to be 0, which means no writeback. Signed-off-by: Richard Henderson --- target/arm/translate.c | 426 ++--- target/arm/a32.decode | 6 + target/arm/t32.decode | 10 + 3 files changed, 241

[Qemu-devel] [PATCH v2 16/68] target/arm: Convert CLZ

2019-08-19 Thread Richard Henderson
Document our choice about the T32 CONSTRAINED UNPREDICTABLE behaviour. This matches the undocumented choice made by the legacy decoder. Signed-off-by: Richard Henderson --- target/arm/translate.c | 31 +++ target/arm/a32.decode | 4 target/arm/t32.decode | 5

[Qemu-devel] [PATCH v2 23/68] target/arm: Convert Parallel addition and subtraction

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 229 - target/arm/a32.decode | 44 target/arm/t32.decode | 44 3 files changed, 200 insertions(+), 117 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 28/68] target/arm: Diagnose writeback register in list for LDM for v7

2019-08-19 Thread Richard Henderson
Prior to v7, for the A32 encoding, this operation wrote an UNKNOWN value back to the base register. Starting in v7 this is UNPREDICTABLE. Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 29/68] target/arm: Diagnose too few registers in list for LDM/STM

2019-08-19 Thread Richard Henderson
This has been a TODO item for quite a while. The minimum bit count for A32 and T16 is 1, and for T32 is 2. Signed-off-by: Richard Henderson --- target/arm/translate.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 13/68] target/arm: Convert MRS/MSR (banked, register)

2019-08-19 Thread Richard Henderson
The m-profile and a-profile, decodings overlap. Only return false for the case of wrong profile; handle UNDEFINED for permission failure directly. This ensures that we don't accidentally pass an insn that applies to the wrong profile. Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v2 22/68] target/arm: Convert USAD8, USADA8, SBFX, UBFX, BFC, BFI, UDF

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 200 + target/arm/a32.decode | 20 + target/arm/t32.decode | 19 3 files changed, 143 insertions(+), 96 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

2019-08-19 Thread Richard Henderson
This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM, in that it may be executed from user mode as with any other encoding of SUBS, not as ERET. Signed-off-by: Richard Henderson --- target/arm/translate.c | 119 + target/arm/a32.decode |

[Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 797 ++--- target/arm/a32.decode | 120 +++ target/arm/t32.decode | 141 3 files changed, 615 insertions(+), 443 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 12/68] target/arm: Convert MSR (immediate) and hints

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 60 +- target/arm/a32.decode | 25 ++ target/arm/t32.decode | 17 3 files changed, 84 insertions(+), 18 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 15/68] target/arm: Convert BX, BXJ, BLX (register)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 78 -- target/arm/a32.decode | 7 target/arm/t32.decode | 2 ++ 3 files changed, 47 insertions(+), 40 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 560 ++--- target/arm/a32.decode | 48 target/arm/t32.decode | 46 3 files changed, 396 insertions(+), 258 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 14/68] target/arm: Convert Cyclic Redundancy Check

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 121 +++-- target/arm/a32.decode | 9 +++ target/arm/t32.decode | 7 +++ 3 files changed, 72 insertions(+), 65 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 11/68] target/arm: Simplify op_smlawx for SMLAW*

2019-08-19 Thread Richard Henderson
By shifting the 16-bit input left by 16, we can align the desired portion of the 48-bit product and use tcg_gen_muls2_i32. Signed-off-by: Richard Henderson --- target/arm/translate.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 08/68] target/arm: Convert Saturating addition and subtraction

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 75 +++--- target/arm/a32.decode | 10 ++ target/arm/t32.decode | 9 + 3 files changed, 67 insertions(+), 27 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 09/68] target/arm: Convert Halfword multiply and multiply accumulate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 218 +++-- target/arm/a32.decode | 20 target/arm/t32.decode | 29 ++ 3 files changed, 170 insertions(+), 97 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 07/68] target/arm: Simplify UMAAL

2019-08-19 Thread Richard Henderson
Since all of the inputs and outputs are i32, dispense with the intermediate promotion to i64 and use tcg_gen_mulu2_i32 and tcg_gen_add2_i32. Signed-off-by: Richard Henderson --- target/arm/translate.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-)

[Qemu-devel] [PATCH v2 05/68] target/arm: Convert Data Processing (immediate)

2019-08-19 Thread Richard Henderson
Convert the modified immediate form of the data processing insns. For A32, we can finally remove any code that was intertwined with the register and register-shifted-register forms. Signed-off-by: Richard Henderson --- target/arm/translate.c | 449 +++--

[Qemu-devel] [PATCH v2 02/68] target/arm: Add stubs for aa32 decodetree

2019-08-19 Thread Richard Henderson
Add the infrastructure that will become the new decoder. No instructions adjusted so far. Signed-off-by: Richard Henderson --- target/arm/translate.c | 31 ++- target/arm/Makefile.objs | 18 ++ target/arm/a32-uncond.decode | 23

[Qemu-devel] [PATCH v2 10/68] target/arm: Simplify op_smlaxxx for SMLAL*

2019-08-19 Thread Richard Henderson
Since all of the inputs and outputs are i32, dispense with the intermediate promotion to i64 and use tcg_gen_add2_i32. Signed-off-by: Richard Henderson --- target/arm/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v2 04/68] target/arm: Convert Data Processing (reg-shifted-reg)

2019-08-19 Thread Richard Henderson
Convert the register shifted by register form of the data processing insns. For A32, we cannot yet remove any code because the legacy decoder intertwines the immediate form. Signed-off-by: Richard Henderson --- target/arm/translate.c | 74 ++

[Qemu-devel] [PATCH v2 03/68] target/arm: Convert Data Processing (register)

2019-08-19 Thread Richard Henderson
Convert the register shifted by immediate form of the data processing insns. For A32, we cannot yet remove any code because the legacy decoder intertwines the reg-shifted-reg and immediate forms. Signed-off-by: Richard Henderson --- target/arm/translate.c | 229

[Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree

2019-08-19 Thread Richard Henderson
This unifies the implementation of the actual instructions for a32, t32, and t16. This has been tested by running the debian 9 armhf installer, which does a far amount of switching between arm and thumb modes. I've also run Peter's ARM TFM image, and all of the existing RISU tests that we have.

[Qemu-devel] [PATCH v2 01/68] target/arm: Use store_reg_from_load in thumb2 code

2019-08-19 Thread Richard Henderson
This function already includes the test for an interworking write to PC from a load. Change the T32 LDM implementation to match the A32 LDM implementation. For LDM, the reordering of the tests does not change valid behaviour because the only case that differs is has rn == 15, which is

[Qemu-devel] [PATCH v2 06/68] target/arm: Convert multiply and multiply accumulate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 248 +++-- target/arm/a32.decode | 17 +++ target/arm/t32.decode | 19 3 files changed, 177 insertions(+), 107 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

Re: [Qemu-devel] [PATCH] block/io.c: fix for the allocation failure

2019-08-19 Thread Eric Blake
On 8/19/19 3:53 PM, Denis V. Lunev wrote: Or even better, fix the call site of fallocate() to skip attempting an unaligned fallocate(), and just directly return ENOTSUP, rather than trying to diagnose EINVAL after the fact. >>> No way. Single ENOTSUP will turn off fallocate()

Re: [Qemu-devel] [for-4.2 PATCH 0/2] PCI DMA alias support

2019-08-19 Thread Alex Williamson
On Mon, 29 Jul 2019 15:15:29 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 26, 2019 at 06:55:27PM -0600, Alex Williamson wrote: > > Please see patch 1/ for the motivation and utility of this series. > > This v1 submission improves on the previous RFC with revised commit > > logs, comments, and

[Qemu-devel] qemu icount mode timer accuracy

2019-08-19 Thread Wu, Wentong
Could anyone please give some comments? Thanks in advance! Hi, Recently I'm working to enable Qemu icount mode with TCG, with source code review I found that Qemu can give deterministic execution for guest code timeout. But for exact time point for guest OS, I have a question: For

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Richard Henderson
On 8/19/19 11:29 AM, Paolo Bonzini wrote: > On 19/08/19 20:28, Paolo Bonzini wrote: >> On 16/08/19 12:12, Thomas Huth wrote: >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the >>> filter of the qemu-s390x list each time you send it. Please: >>> >>> 1) Try to break it up in

Re: [Qemu-devel] [PATCH] ppc: Fix emulated INFINITY and NAN conversions

2019-08-19 Thread Richard Henderson
On 8/19/19 12:19 PM, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > helper_todouble() was not properly converting INFINITY from 32 bit > float to 64 bit double. > > (Normalized operand conversion is unchanged, other than indentation.) > > Signed-off-by: Paul A. Clarke > --- >

Re: [Qemu-devel] [PATCH] block/io.c: fix for the allocation failure

2019-08-19 Thread Denis V. Lunev
On 8/19/19 11:30 PM, Eric Blake wrote: > On 8/19/19 2:46 PM, Denis V. Lunev wrote: >> On 8/17/19 5:56 PM, Eric Blake wrote: >>> On 8/17/19 9:49 AM, Eric Blake wrote: >>> > This change is a regression of sorts. Now, you are unconditionally > attempting the fallback for ALL failures (such

[Qemu-devel] qemu icount mode timer accuracy

2019-08-19 Thread Wu, Wentong
Could you please give some comments about this? Thanks a lot!

Re: [Qemu-devel] [PATCH v4 18/28] riscv: sifive_u: Generate hfclk and rtcclk nodes

2019-08-19 Thread Alistair Francis
On Sun, Aug 18, 2019 at 10:29 PM Bin Meng wrote: > > To keep in sync with Linux kernel device tree, generate hfclk and > rtcclk nodes in the device tree, to be referenced by PRCI node. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > Changes in v4: None > Changes

Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-19 Thread Max Reitz
On 19.08.19 22:18, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz > Reviewed-by: John Snow Hm, sorry, I just noticed that I probably should have

[Qemu-devel] [PATCH v3 7/8] iotests: Test driver whitelisting in 136

2019-08-19 Thread Max Reitz
null-aio may not be whitelisted. Skip all test cases that require it. Signed-off-by: Max Reitz --- tests/qemu-iotests/136 | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/136 b/tests/qemu-iotests/136 index a46a7b7630..012ea111ac 100755 ---

  1   2   3   4   >