[Qemu-devel] [PULL 02/12] fpu: convert float[16/32/64]_squash_denormal to new modern style

2019-08-19 Thread Alex Bennée
This also allows us to remove the extractFloat16exp/frac helpers. We avoid using the floatXX_pack_raw functions as they are slight overkill for masking out all but the top bit of the number. The generated code is almost exactly the same as makes no difference to the pre-conversion code. Signed-off

[Qemu-devel] [PULL 01/12] fpu: replace LIT64 usage with UINT64_C for specialize constants

2019-08-19 Thread Alex Bennée
We have a wrapper that does the right thing from stdint.h so lets use it for our constants in softfloat-specialize.h Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index 7b8895726c5..5ab2fa19415 100644 --- a/fpu/sof

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/9] s390x/mmu: Implement access-exception-fetch/store-indication facility

2019-08-19 Thread David Hildenbrand
On 19.08.19 14:30, Thomas Huth wrote: > On 8/19/19 2:26 PM, David Hildenbrand wrote: >> On 19.08.19 14:22, Thomas Huth wrote: >>> On 8/19/19 2:16 PM, Thomas Huth wrote: On 8/5/19 5:29 PM, David Hildenbrand wrote: > We always have to indicate whether it is a fetch or a store for all access

[Qemu-devel] [PULL 03/12] fpu: use min/max values from stdint.h for integral overflow

2019-08-19 Thread Alex Bennée
Remove some more use of LIT64 while making the meaning more clear. We also avoid the need of casts as the results by definition fit into the return type. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 53855892b9f..d2cdf4a4a3b 10064

[Qemu-devel] [PULL 10/12] target/mips: rationalise softfloat includes

2019-08-19 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h in cpu.h for the few bits that are global. We also move the restore_snan_bit_mode into internal.h and include -helpers.h there. Sig

Re: [Qemu-devel] [PATCH v3 7/8] hw/misc: Add a config switch for the "unimplemented" device

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/17/19 12:19 PM, Thomas Huth wrote: > The device is only used by some few boards. Let's use a proper Kconfig > switch so that we only compile this code if we really need it. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/Kconfig| 11 +++ >

Re: [Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-08-19 Thread Clement Deschamps
It looks like the same USB controller is part of a TI SoC: http://www.ti.com/lit/ug/spruhj7a/spruhj7a.pdf Clement On 8/19/19 11:16 AM, Peter Maydell wrote: Thanks for digging those up. Unfortunately just the driver sources aren't really enough information for a good device model, and the othe

[Qemu-devel] [PULL 07/12] fpu: move inline helpers into a separate header

2019-08-19 Thread Alex Bennée
There are a bunch of users of the inline helpers who do not need access to the entire softfloat API. Move those inline helpers into a new header file which can be included without bringing in the rest of the world. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe M

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/9] s390x/mmu: Implement access-exception-fetch/store-indication facility

2019-08-19 Thread David Hildenbrand
On 19.08.19 14:22, Thomas Huth wrote: > On 8/19/19 2:16 PM, Thomas Huth wrote: >> On 8/5/19 5:29 PM, David Hildenbrand wrote: >>> We always have to indicate whether it is a fetch or a store for all access >>> exceptions. This is only missing for LAP exceptions. >> >> Do we really need this for LAP,

[Qemu-devel] [PULL 04/12] fpu: replace LIT64 with UINT64_C macros

2019-08-19 Thread Alex Bennée
In our quest to eliminate the home rolled LIT64 macro we fixup usage inside the softfloat code. While we are at it we remove some of the extraneous spaces to closer fit the house style. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c b/fpu/softfloat.c inde

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread David Hildenbrand
On 19.08.19 14:11, Peter Maydell wrote: > On Sat, 17 Aug 2019 at 17:14, David Hildenbrand wrote: >> >> On 17.08.19 17:59, David Hildenbrand wrote: >>> Hi everybody, >>> >>> I was just trying to run qemu-s390x (linux-user) with a very simple >>> binary (gzip + lib/ld64.so.1, compiled under Fedora 2

[Qemu-devel] [Bug 1834113] Re: QEMU touchpad input erratic after wakeup from sleep

2019-08-19 Thread Rafael David Tinoco
Avi, Something I have realized we missed as a feedback here - or maybe I missed checking previous comments - is how your mouse is being setup for the guest. Is it being PS/2 emulated (default) or is it being given as an USB device (when qemu cmd line has "-usb -device usb-tablet"). Also, are you u

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/9] s390x/mmu: Implement access-exception-fetch/store-indication facility

2019-08-19 Thread Thomas Huth
On 8/19/19 2:26 PM, David Hildenbrand wrote: > On 19.08.19 14:22, Thomas Huth wrote: >> On 8/19/19 2:16 PM, Thomas Huth wrote: >>> On 8/5/19 5:29 PM, David Hildenbrand wrote: We always have to indicate whether it is a fetch or a store for all access exceptions. This is only missing for LA

[Qemu-devel] [Bug 1834113] Re: QEMU touchpad input erratic after wakeup from sleep

2019-08-19 Thread Avi Eis
Right now it stopped happening, although I did see something briefly last week that fixed itself on a reboot. If it happens again I'll check those details. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] [PULL 0/3] Ide patches

2019-08-19 Thread Peter Maydell
On Sat, 17 Aug 2019 at 00:16, John Snow wrote: > > The following changes since commit afd760539308a5524accf964107cdb1d54a059e3: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190816' into staging (2019-08-16 > 17:21:40 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-19 Thread Maxim Levitsky
On Thu, 2019-08-15 at 10:00 -0500, Eric Blake wrote: > On 8/15/19 9:44 AM, Maxim Levitsky wrote: > > > > > > Does the idea of a union type with a default value for the > > > > > discriminator > > > > > help? Maybe we have a discriminator which defaults to 'auto', and > > > > > add a > > > > > u

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Peter Maydell
On Mon, 19 Aug 2019 at 13:22, David Hildenbrand wrote: > Thanks, running > > "ldconfig -c etc/ld.so.cache -r ." > > Seems to fix the issue for me. So you are sure the bug resides in glic > and not in the qemu-user pieces of the library loader? Pretty sure, yes. QEMU doesn't implement any of the d

Re: [Qemu-devel] [PATCH 0/2] target/arm: Take exceptions on ATS instructions

2019-08-19 Thread Peter Maydell
On Fri, 16 Aug 2019 at 13:58, Peter Maydell wrote: > > The translation table walk for an ATS instruction can result in > various faults. In general these are just reported back via the > PAR_EL1 fault status fields, but in some cases the architecture > requires that the fault is turned into an ex

Re: [Qemu-devel] Publishing binary images for testing

2019-08-19 Thread Cleber Rosa
On Fri, Aug 16, 2019 at 12:51:06PM +0200, Philippe Mathieu-Daudé wrote: > ping? :) > > On 6/17/19 7:17 AM, Philippe Mathieu-Daudé wrote: > > Hi Cleber, > > > > On 5/11/18 4:27 PM, Cleber Rosa wrote: > >> On 05/11/2018 09:55 AM, Eduardo Habkost wrote: > >>> (CCing Cleber and avocado-devel in case

[Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name

2019-08-19 Thread Bishara AbuHattoum
https://bugzilla.redhat.com/show_bug.cgi?id=1733165 Uppon renaming a NIC to a Chinese name and invoking the network get interfaces command, guest-network-get-interfaces, the returned name field has the (\ufffd) value for each Chinese character the NIC name had, this value is the indication that th

Re: [Qemu-devel] Patchew s390 QEMU build issues

2019-08-19 Thread Dan Horák
Hi guys, On Sun, 18 Aug 2019 12:05:27 +0100 Stefan Hajnoczi wrote: > Hi, > Peter messaged me on IRC to say that QEMU Patchew s390 builds seemed > broken. > > Any chance you could take a look? I'm looking into it now ... Dan

[Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)"

2019-08-19 Thread Bingsong Si
This reverts commit de2e68c902f7b6e438b0fa3cfedd74a06a20704f. Initial value of env->xcr0 == 0, then CPUID(EAX=0xd,ECX=0).EBX == 0, after kvm upstream commit 412a3c41, It is ok. On host before commit 412a3c41, some legacy guest, i.e. CentOS 6, get xstate_size == 0, will crash the guest. Signed-off

[Qemu-devel] [PATCH 1/1] qga-win: network-get-interfaces command name field bug fix

2019-08-19 Thread Bishara AbuHattoum
Network interface name is fetched as an encoded WCHAR array, (wide character), then it is decoded using the guest's CP_ACP Windows code page, which is the default code page as configure in the guest's Windows, then it is returned as a byte array, (char array). As stated in the BZ#1733165, when ren

Re: [Qemu-devel] [PATCH] migrtion: define MigrationState/MigrationIncomingState.state as MigrationStatus

2019-08-19 Thread Wei Yang
On Mon, Aug 19, 2019 at 12:26:55PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Fri, Jun 21, 2019 at 10:27:39PM +0800, Wei Yang wrote: >> >No functional change. Add default case to fix warning. >> > >> >> Hi, David & Juan >> >> Do you like this? >

Re: [Qemu-devel] [PATCH v8 10/37] target/mips: Style improvements in helper.c

2019-08-19 Thread Thomas Huth
On 8/19/19 2:07 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/helper.c | 98 > > 1 file changed, 60

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Aleksandar Markovic
Hi, David. I can't repro the problem either, but I do have a patch authored by an engineer that left the company a while ago that seems to be at least related to your scenario. May I ask you to test it (just apply it to QEMU ToT and rerun the scenario to see if it changes the outcome) (feel free t

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Aleksandar Markovic
On Mon, Aug 19, 2019 at 3:34 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > Hi, David. > > I can't repro the problem either, but I do have a patch authored by an > engineer that left the company a while ago that seems to be at least > related to your scenario. May I ask you to test

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Peter Maydell
On Mon, 19 Aug 2019 at 14:34, Aleksandar Markovic wrote: > I can't repro the problem either, but I do have a patch authored by an > engineer that left the company a while ago that seems to be at least related > to your scenario. May I ask you to test it (just apply it to QEMU ToT and > rerun th

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Laurent Vivier
Le 19/08/2019 à 15:34, Aleksandar Markovic a écrit : > Hi, David. > > I can't repro the problem either, but I do have a patch authored by an > engineer that left the company a while ago that seems to be at least > related to your scenario. May I ask you to test it (just apply it to > QEMU ToT and

Re: [Qemu-devel] RISCV: when will the CLIC be ready?

2019-08-19 Thread liuzhiwei
On 2019/8/17 上午1:29, Alistair Francis wrote: On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei wrote: Hi, Palmer When Michael Clark still was the maintainer of RISCV QEMU, he wrote in the mail list, "the CLIC interrupt controller is under testing, and will be included in QEMU 3.1 or 3.2". It is pit

Re: [Qemu-devel] [PATCH v2] migration: cleanup check on ops in savevm.handlers iterations

2019-08-19 Thread Juan Quintela
Wei Yang wrote: > During migration, there are several places to iterate on > savevm.handlers. And on each iteration, we need to check its ops and > related callbacks before invoke it. > > Generally, ops is the first element to check, and it is only necessary > to check it once. > > This patch clea

Re: [Qemu-devel] [EXTERNAL]Re: [PATCH v8 10/37] target/mips: Style improvements in helper.c

2019-08-19 Thread Aleksandar Markovic
> From: Thomas Huth > > On 8/19/19 2:07 PM, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > ... > > > @@ -48,26 +48,28 @@ int no_mmu_map_address (CPUMIPSState *env, hwaddr > > *physical, int *prot, > > } > > > > /* fixed mapping MMU emulation */ > > -int fixed_mmu_map_addres

Re: [Qemu-devel] [PATCH] migrtion: define MigrationState/MigrationIncomingState.state as MigrationStatus

2019-08-19 Thread Wei Yang
On Mon, Aug 19, 2019 at 12:26:32PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> No functional change. Add default case to fix warning. > >I think the problem with this is that migrate_set_state uses an >atomic_cmpxchg and so we have to be careful that t

Re: [Qemu-devel] [PULL 0/3] Run iotests during "make check"

2019-08-19 Thread Peter Maydell
On Sat, 17 Aug 2019 at 09:54, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit afd760539308a5524accf964107cdb1d54a059e3: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190816' into staging (2019-08-16 > 17:21:40 +0100) > > are available in t

Re: [Qemu-devel] [PATCH v2] migration: cleanup check on ops in savevm.handlers iterations

2019-08-19 Thread Wei Yang
On Mon, Aug 19, 2019 at 03:50:44PM +0200, Juan Quintela wrote: >Wei Yang wrote: >> During migration, there are several places to iterate on >> savevm.handlers. And on each iteration, we need to check its ops and >> related callbacks before invoke it. >> >> Generally, ops is the first element to ch

Re: [Qemu-devel] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-19 Thread Paolo Bonzini
On 19/08/19 01:00, Yao, Jiewen wrote: > in real world, we deprecate AB-seg usage because they are vulnerable > to smm cache poison attack. I assume cache poison is out of scope in > the virtual world, or there is a way to prevent ABseg cache poison. Indeed the SMRR would not cover the A-seg on rea

Re: [Qemu-devel] [PATCH v2] x86: Intel AVX512_BF16 feature enabling

2019-08-19 Thread Paolo Bonzini
On 25/07/19 08:14, Jing Liu wrote: > Intel CooperLake cpu adds AVX512_BF16 instruction, defining as > CPUID.(EAX=7,ECX=1):EAX[bit 05]. > > The patch adds a property for setting the subleaf of CPUID leaf 7 in > case that people would like to specify it. > > The release spec link as follows, > http

Re: [Qemu-devel] [EXTERNAL][PATCH v8 02/37] target/mips: Amend CP0 WatchHi register implementation

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 02/37] target/mips: Amend CP0 WatchHi register > implementation > > From: Yongbok Kim > > WatchHi

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-19 Thread Maxim Levitsky
On Thu, 2019-08-15 at 17:40 -0400, John Snow wrote: > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > This is also a preparation for key read/write/erase functions > > > > This is a matter of taste and I am not usually reviewing LUKS patches > (So don't take me too seriously), but I would prefer

Re: [Qemu-devel] [PATCH 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Paolo Bonzini
On 17/08/19 11:32, Peter Xu wrote: > It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO > interface. The kernel interface only allows to unregister an mmio > device with exactly the zone size when registered, or any smaller zone > that is included in the device mmio zone. It does n

Re: [Qemu-devel] [PATCH 1/2] memory: Replace has_coalesced_range with add/del flags

2019-08-19 Thread Paolo Bonzini
On 17/08/19 11:32, Peter Xu wrote: > The previous has_coalesced_range counter has a problem in that it only > works for additions of coalesced mmio ranges but not deletions. The > reason is that has_coalesced_range information can be lost when the > FlatView updates the topology again when the upd

Re: [Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)"

2019-08-19 Thread Dr. David Alan Gilbert
Copying in Eduardo. * Bingsong Si (owen...@ucloud.cn) wrote: > This reverts commit de2e68c902f7b6e438b0fa3cfedd74a06a20704f. > > Initial value of env->xcr0 == 0, then CPUID(EAX=0xd,ECX=0).EBX == 0, after kvm > upstream commit 412a3c41, It is ok. > On host before commit 412a3c41, some legacy guest

Re: [Qemu-devel] [EXTERNAL][PATCH v8 03/37] target/mips: Amend CP0 MemoryMapID register implementation

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 03/37] target/mips: Amend CP0 MemoryMapID > register implementation > > From: Yongbok Kim > > Add

Re: [Qemu-devel] [EXTERNAL][PATCH v8 10/37] target/mips: Style improvements in helper.c

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 10/37] target/mips: Style improvements in > helper.c > > From: Aleksandar Markovic > > Fixes mostl

Re: [Qemu-devel] [EXTERNAL][PATCH v8 11/37] target/mips: Style improvements in translate.c

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 11/37] target/mips: Style improvements in > translate.c > > From: Aleksandar Markovic > > Fixes mo

Re: [Qemu-devel] [EXTERNAL][PATCH v8 12/37] target/mips: Style improvements in cps.c

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 12/37] target/mips: Style improvements in cps.c > > From: Aleksandar Markovic > > Fixes mostly erro

Re: [Qemu-devel] [EXTERNAL][PATCH v8 13/37] target/mips: Style improvements in mips_fulong2e.c

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 13/37] target/mips: Style improvements in > mips_fulong2e.c > > From: Aleksandar Markovic > > Fixe

Re: [Qemu-devel] [EXTERNAL][PATCH v8 15/37] target/mips: Style improvements in mips_malta.c

2019-08-19 Thread Aleksandar Rikalo
From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 15/37] target/mips: Style improvements in > mips_malta.c > > From: Aleksandar Markovic > > Fixes mos

Re: [Qemu-devel] [EXTERNAL][PATCH v8 16/37] target/mips: Style improvements in mips_mipssim.c

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 16/37] target/mips: Style improvements in > mips_mipssim.c > > From: Aleksandar Markovic > > Fixes

Re: [Qemu-devel] [EXTERNAL][PATCH v8 14/37] target/mips: Style improvements in mips_int.c

2019-08-19 Thread Aleksandar Rikalo
From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:07 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 14/37] target/mips: Style improvements in > mips_int.c > > From: Aleksandar Markovic > > Fixes mostl

Re: [Qemu-devel] [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add optional printing of more detailed failure info

2019-08-19 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Monday, August 19, 2019 2:08 PM > To: qemu-devel@nongnu.org > Cc: phi...@redhat.com ; Aleksandar Markovic > ; Aleksandar Rikalo > Subject: [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add optional > printing of more detailed failure info > > From: Alek

[Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong'

2019-08-19 Thread Philippe Mathieu-Daudé
As its name implies, the Option/Architecture Vector is not target (per cpu) specific but arch-related. Use the proper arch-related header, allowing to use this header with non cpu-specific objects. This fixes this error when using this header with $common-obj: include/hw/ppc/spapr_ovec.h:76:44:

Re: [Qemu-devel] [PATCH 1/4] tests/docker: Use one package per line to improve readability

2019-08-19 Thread Cleber Rosa
On Mon, Aug 19, 2019 at 01:18:24AM +0200, Philippe Mathieu-Daudé wrote: > Use one package per line to improve readability. This also > helps while reviewing patches. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/travis.docker | 10 +- > 1 file changed, 9 inse

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 6/9] s390x/mmu: Implement enhanced suppression-on-protection facility 2

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > We already implement ESOP-1. For ESOP-2, we only have to indicate all > protection exceptions properly. Due to EDAT-1, we already indicate DAT > exceptions properly. We don't trigger KCP/ALCP/IEP exceptions yet. > > So all we have to do is set the TEID

[Qemu-devel] [PATCH v3 1/3] qcow2: introduce compression type feature

2019-08-19 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

[Qemu-devel] [PATCH v3 0/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
v3: * relax the compression type setting requirement when the compression type is not zlib [Eric, Kevin] * add compression type values to the spec [Eric] * fix wording in the spec and descriptions [Eric] * fix functions descriptions [Max] * fix zstd (de)compression functions flaws [Max] * fix zst

[Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-08-19 Thread Clement Deschamps
It looks like a similar USB controller is part of a TI SoC: http://www.ti.com/lit/ug/spruhj7a/spruhj7a.pdf Clement -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: arm raspi2/raspi3

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 7/9] s390x/mmu: Implement Instruction-Execution-Protection Facility

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > IEP support in the mmu is fairly easy. Set the right permissions for TLB > entries and properly report an exception. > > Make sure to handle EDAT-2 by setting bit 56/60/61 of the TEID (TEC) to > the right values. > > Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v3 3/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, at the moment, has been the only compression method available. The performance test results: Test compresses and decompres

[Qemu-devel] [PATCH v3 2/3] qcow2: rework the cluster compression routine

2019-08-19 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 78 +++ 1 file changed, 64 insertions(+), 14 delet

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 8/9] s390x/cpumodel: Prepare for changes of QEMU model

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > Setup the 4.1 compatibility model so we can add new features to the > LATEST model. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 ++ > target/s390x/gen-features.c | 6 +- > 2 files changed, 7 insertions(+), 1 delet

[Qemu-devel] [PULL 1/3] decodetree: Allow !function with no input bits

2019-08-19 Thread Richard Henderson
Call this form a "parameter", returning a value extracted from the DisasContext. Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Richard Henderson --- docs/devel/decodetree.rst | 8 - scripts/decodetree.py | 49 --- tests/decode/err_field6

[Qemu-devel] [PULL 3/3] target/riscv: Remove redundant declaration pragmas

2019-08-19 Thread Richard Henderson
These are now generated by decodetree itself. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Palmer Dabbelt Signed-off-by: Richard Henderson --- target/riscv/translate.c | 19 +-- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 2/3] decodetree: Suppress redundant declaration warnings

2019-08-19 Thread Richard Henderson
We can tell that a decodetree input file is "secondary" when it uses an argument set marked "!extern". This indicates that at least one of the insn translation functions will have already been declared by the "primary" input file, but given only the secondary we cannot tell which. Avoid redundant

[Qemu-devel] [PULL 0/3] decodetree improvements

2019-08-19 Thread Richard Henderson
gs/pull-dt-20190819 for you to fetch changes up to 59a3a1c0c211640e18b058a1b0444154c4eb6f99: target/riscv: Remove redundant declaration pragmas (2019-08-19 08:13:14 -0700) Implement parameter fields. Push warning pragmas into the

Re: [Qemu-devel] [PULL 00/12] softfloat header updates

2019-08-19 Thread Peter Maydell
On Mon, 19 Aug 2019 at 13:17, Alex Bennée wrote: > > The following changes since commit afd760539308a5524accf964107cdb1d54a059e3: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190816' into staging (2019-08-16 > 17:21:40 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PATCH 2/4] tests/docker: update our Travis image to run acceptance tests locally

2019-08-19 Thread Cleber Rosa
On Mon, Aug 19, 2019 at 01:18:25AM +0200, Philippe Mathieu-Daudé wrote: > Since commit aa983ff67c3, Travis CI runs acceptance tests using > the Avocado framework. Since Avocado requires Python 3, update > our Docker image to be able to run these tests locally. > > Signed-off-by: Philippe Mathieu-D

[Qemu-devel] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Stefan Hajnoczi
I am delighted to announce the release of virtio-fs v0.3, a shared file system that lets virtual machines access a directory tree on the host. This release is based on QEMU 4.1.0 and Linux 5.3-rc3. For more information about virtio-fs: https://virtio-fs.gitlab.io/ This is a development release ai

[Qemu-devel] [PULL 00/17] Block patches

2019-08-19 Thread Max Reitz
The following changes since commit 3fbd3405d2b0604ea530fc7a1828f19da1e95ff9: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-08-17' into staging (2019-08-19 14:14:09 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-

[Qemu-devel] [PULL 03/17] mirror: Fix bdrv_has_zero_init() use

2019-08-19 Thread Max Reitz
bdrv_has_zero_init() only has meaning for newly created images or image areas. If the mirror job itself did not create the image, it cannot rely on bdrv_has_zero_init()'s result to carry any meaning. This is the case for drive-mirror with mode=existing and always for blockdev-mirror. Note that w

[Qemu-devel] [PULL 01/17] LUKS: support preallocation

2019-08-19 Thread Max Reitz
From: Maxim Levitsky preallocation=off and preallocation=metadata both allocate luks header only, and preallocation=falloc/full is passed to underlying file. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534951 Signed-off-by: Maxim Levitsky Message-id: 20190716161901.1430-1-mlevi...@redh

[Qemu-devel] [PULL 05/17] block: Implement .bdrv_has_zero_init_truncate()

2019-08-19 Thread Max Reitz
We need to implement .bdrv_has_zero_init_truncate() for every block driver that supports truncation and has a .bdrv_has_zero_init() implementation. Implement it the same way each driver implements .bdrv_has_zero_init(). This is at least not any more unsafe than what we had before. Signed-off-by:

[Qemu-devel] [PULL 02/17] qemu-img: Fix bdrv_has_zero_init() use in convert

2019-08-19 Thread Max Reitz
bdrv_has_zero_init() only has meaning for newly created images or image areas. If qemu-img convert did not create the image itself, it cannot rely on bdrv_has_zero_init()'s result to carry any meaning. Signed-off-by: Max Reitz Message-id: 20190724171239.8764-2-mre...@redhat.com Reviewed-by: Maxi

[Qemu-devel] [PULL 04/17] block: Add bdrv_has_zero_init_truncate()

2019-08-19 Thread Max Reitz
No .bdrv_has_zero_init() implementation returns 1 if growing the file would add non-zero areas (at least with PREALLOC_MODE_OFF), so using it in lieu of this new function was always safe. But on the other hand, it is possible that growing an image that is not zero-initialized would still add a zer

[Qemu-devel] [PULL 10/17] iotests: Convert to preallocated encrypted qcow2

2019-08-19 Thread Max Reitz
Add a test case for converting an empty image (which only returns zeroes when read) to a preallocated encrypted qcow2 image. qcow2_has_zero_init() should return 0 then, thus forcing qemu-img convert to create zero clusters. Signed-off-by: Max Reitz Acked-by: Stefano Garzarella Tested-by: Stefano

[Qemu-devel] [PULL 09/17] vhdx: Fix .bdrv_has_zero_init()

2019-08-19 Thread Max Reitz
Fixed VHDX images cannot guarantee to be zero-initialized. If the image has the "fixed" subformat, forward the call to the underlying storage node. Reported-by: Stefano Garzarella Signed-off-by: Max Reitz Message-id: 20190724171239.8764-9-mre...@redhat.com Reviewed-by: Maxim Levitsky Signed-of

[Qemu-devel] [PULL 06/17] block: Use bdrv_has_zero_init_truncate()

2019-08-19 Thread Max Reitz
vhdx and parallels call bdrv_has_zero_init() when they do not really care about an image's post-create state but only about what happens when you grow an image. That is a bit ugly, and also overly safe when growing preallocated images without preallocating the new areas. Let them use bdrv_has_zer

[Qemu-devel] [PULL 07/17] qcow2: Fix .bdrv_has_zero_init()

2019-08-19 Thread Max Reitz
If a qcow2 file is preallocated, it can no longer guarantee that it initially appears as filled with zeroes. So implement .bdrv_has_zero_init() by checking whether the file is preallocated; if so, forward the call to the underlying storage node, except for when it is encrypted: Encrypted prealloca

[Qemu-devel] [PULL 13/17] vdi: Make block_status recurse for fixed images

2019-08-19 Thread Max Reitz
Suggested-by: Vladimir Sementsov-Ogievskiy Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 Signed-off-by: Max Reitz Message-id: 20190725155512.9827-2-mre...@redhat.com Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Max Reitz --- block/vdi.c | 3 ++- 1 file cha

[Qemu-devel] [PULL 15/17] vpc: Do not return RAW from block_status

2019-08-19 Thread Max Reitz
vpc is not really a passthrough driver, even when using the fixed subformat (where host and guest offsets are equal). It should handle preallocation like all other drivers do, namely by returning DATA | RECURSE instead of RAW. There is no tangible difference but the fact that bdrv_is_allocated()

[Qemu-devel] [PULL 17/17] doc: Preallocation does not require writing zeroes

2019-08-19 Thread Max Reitz
When preallocating an encrypted qcow2 image, it just lets the protocol driver write data and then does not mark the clusters as zero. Therefore, reading this image will yield effectively random data. As such, we have not fulfilled the promise of always writing zeroes when preallocating an image in

[Qemu-devel] [PULL 08/17] vdi: Fix .bdrv_has_zero_init()

2019-08-19 Thread Max Reitz
Static VDI images cannot guarantee to be zero-initialized. If the image has been statically allocated, forward the call to the underlying storage node. Reported-by: Stefano Garzarella Signed-off-by: Max Reitz Reviewed-by: Stefan Weil Acked-by: Stefano Garzarella Tested-by: Stefano Garzarella

[Qemu-devel] [PULL 12/17] iotests: Full mirror to existing non-zero image

2019-08-19 Thread Max Reitz
The result of a sync=full mirror should always be the equal to the input. Therefore, existing images should be treated as potentially non-zero and thus should be explicitly initialized to be zero beforehand. Signed-off-by: Max Reitz Message-id: 20190724171239.8764-12-mre...@redhat.com Signed-off

[Qemu-devel] [PULL 16/17] iotests: Fix 141 when run with qed

2019-08-19 Thread Max Reitz
69f47505ee has changed qcow2 in such a way that the commit job run in test 141 (and 144[1]) returns before it emits the READY event. However, 141 also runs with qed, where the order is still the other way around. Just filter out the {"return": {}} so the test passes for qed again. [1] 144 only ru

[Qemu-devel] [PULL 11/17] iotests: Test convert -n to pre-filled image

2019-08-19 Thread Max Reitz
Signed-off-by: Max Reitz Message-id: 20190724171239.8764-11-mre...@redhat.com Reviewed-by: Maxim Levitsky Signed-off-by: Max Reitz --- tests/qemu-iotests/122 | 17 + tests/qemu-iotests/122.out | 8 2 files changed, 25 insertions(+) diff --git a/tests/qemu-iotests/

[Qemu-devel] [PULL 14/17] vmdk: Make block_status recurse for flat extents

2019-08-19 Thread Max Reitz
Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 Signed-off-by: Max Reitz Message-id: 20190725155512.9827-3-mre...@redhat.com Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Max Reitz --- block/vmdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/v

[Qemu-devel] [PATCH v9] qemu-io: add pattern file for write command

2019-08-19 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v9: * replace flag cast to int with bool [Eric] * fix the error message [Eric] * use qemu_io_free instead of qemu_vfree [Eric] * add function description [

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Boeuf, Sebastien
That's great news :) Sebastien On Mon, 2019-08-19 at 17:04 +0100, Stefan Hajnoczi wrote: > I am delighted to announce the release of virtio-fs v0.3, a shared > file > system that lets virtual machines access a directory tree on the > host. > This release is based on QEMU 4.1.0 and Linux 5.3-rc3.

Re: [Qemu-devel] [PATCH-for-4.2 v2 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-19 Thread Cornelia Huck
On Wed, 14 Aug 2019 09:23:49 +0200 David Hildenbrand wrote: > The first two patches are modified patches from: > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > This series primarily fixes minor things in the storage key handling code > in the MMU and implements fairly reliable

Re: [Qemu-devel] [PATCH-for-4.2 v2 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-19 Thread Cornelia Huck
On Mon, 19 Aug 2019 18:36:23 +0200 Cornelia Huck wrote: > On Wed, 14 Aug 2019 09:23:49 +0200 > David Hildenbrand wrote: > > > The first two patches are modified patches from: > > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > > > This series primarily fixes minor things in th

Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-19 Thread Cornelia Huck
On Fri, 16 Aug 2019 10:47:02 +0200 David Hildenbrand wrote: > The first two patches are modified patches from: > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > This series primarily fixes minor things in the storage key handling code > in the MMU and implements fairly reliable

Re: [Qemu-devel] [Qemu-riscv] RISCV: when will the CLIC be ready?

2019-08-19 Thread Chih-Min Chao
On Mon, Aug 19, 2019 at 9:47 PM liuzhiwei wrote: > > On 2019/8/17 上午1:29, Alistair Francis wrote: > > On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei wrote: > >> Hi, Palmer > >> > >> When Michael Clark still was the maintainer of RISCV QEMU, he wrote in > the mail list, "the CLIC interrupt controller

Re: [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct

2019-08-19 Thread Paolo Bonzini
On 15/08/19 11:13, Yury Kotov wrote: > Ping ping Hi, sorry for the delay, I was waiting for the 4.1 release. I would like to make a small change so that preemption of QEMU does not result in overly long sleeps. The following patch on top of yours computes the throttle-end time just once. Of co

Re: [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

2019-08-19 Thread Max Reitz
Ping On 24.06.19 19:39, Max Reitz wrote: > Hi, > > There are two explanations of this cover letter, a relative one (to v3) > and an absolute one. > > > *** Important note *** > > The final patch in this series is an example that converts most of > block-core.json to use default values where po

Re: [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct

2019-08-19 Thread Paolo Bonzini
On 19/08/19 18:39, Paolo Bonzini wrote: > On 15/08/19 11:13, Yury Kotov wrote: >> Ping ping > > Hi, > > sorry for the delay, I was waiting for the 4.1 release. > > I would like to make a small change so that preemption of QEMU does not > result in overly long sleeps. The following patch on top

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Three floating point fixes

2019-08-19 Thread Paul Clarke
On 8/19/19 1:44 AM, Aleksandar Markovic wrote: > 19.08.2019. 08.30, "David Gibson" је > написао/ла: >> >> On Sun, Aug 18, 2019 at 10:59:01PM +0200, Aleksandar Markovic wrote: >>> 18.08.2019. 10.10, "Richard Henderson" је >>> написао/ла: On 8/16/19 11:59 PM, Aleksandar Markovic wrote: >>

Re: [Qemu-devel] [PATCH 0/2] target/arm: Take exceptions on ATS instructions

2019-08-19 Thread Edgar E. Iglesias
On Mon, Aug 19, 2019 at 01:44:37PM +0100, Peter Maydell wrote: > On Fri, 16 Aug 2019 at 13:58, Peter Maydell wrote: > > > > The translation table walk for an ATS instruction can result in > > various faults. In general these are just reported back via the > > PAR_EL1 fault status fields, but in s

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-19 Thread Brad Parker
Whoops, 3.11.0 does not exist. Went back and did a full bisect. 3.0.0 works fine, and the breakage starts before 3.0.1 and 3.1.0 was released, specifically, with commit 05306935b1ae49107c2dc2f301574dd6c29b6838. -- You received this bug notification because you are a member of qemu- devel-ml, whic

[Qemu-devel] [PATCH v2] ppc: conform to processor User's Manual for xscvdpspn

2019-08-19 Thread Paul A. Clarke
From: "Paul A. Clarke" The POWER8 and POWER9 User's Manuals specify the implementation behavior for what the ISA leaves "undefined" behavior for the xscvdpspn and xscvdpsp instructions. This patch corrects the QEMU implementation to match the hardware implementation for that case. ISA 3.0B has

Re: [Qemu-devel] [PATCH v3 0/8] Kconfig switches

2019-08-19 Thread Paolo Bonzini
On 17/08/19 12:19, Thomas Huth wrote: > Here are some more Kconfig patches that clean up the switches of > existing devices and introduce proper config switches for some > other devices that were always enabled before. Thomas, you can go ahead and send a pull request as I will be on vacation soon.

<    1   2   3   4   >