[Qemu-devel] [PATCH v4 03/10] hw/core: add Resettable interface in Bus and Device classes

2019-08-21 Thread Damien Hedde
Implement Resettable interface in BusClass and DeviceClass; it adds the ResetState structure into BusState and DeviceState and the required methods in the classes. Helpers device_cold_reset and bus_cold_reset are defined to call to use the new interface. Also add a [device|bus]_is_resetting

[Qemu-devel] [PATCH v4 06/10] hw/s390x/ipl.c: replace deprecated qbus_reset_all registration

2019-08-21 Thread Damien Hedde
Replace deprecated qbus_reset_all by resettable_cold_reset_fn for the ipl registration in the main reset handlers. This does not impact the behavior: qbus_reset_all is already a wrapper for the cold reset function. Signed-off-by: Damien Hedde --- Cc: Cornelia Huck Cc: qemu-s3...@nongnu.org Cc:

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-21 Thread Lukáš Doktor
Dne 21. 08. 19 v 17:49 Anton Nefedov napsal(a): > On 21/8/2019 5:14 PM, Lukáš Doktor wrote: >> Hello guys, >> >> First attempt was rejected due to zip attachment, let's try it again with >> just Avocado-vt debug.log and serial console log files attached. >> >> I bisected a regression on aarch64

[Qemu-devel] [PATCH v4 07/10] hw/core/qdev: replace deprecated device_legacy_reset when hotplugging device

2019-08-21 Thread Damien Hedde
Replace the hotplugged device_legacy_reset by device_cold_reset. Since we're talking hotplug, cold reset seems the proper reset type. This does change the behavior since the new function propagates also the reset to eventual child buses. But it should be a bug if resetting eventual child buses

[Qemu-devel] [PATCH v4 02/10] hw/core: create Resettable QOM interface

2019-08-21 Thread Damien Hedde
This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in which reset handlers are called. In particular doing external side-effect (like setting an

[Qemu-devel] [PATCH v3] RISC-V: Select FPU gdb xml file based on the supported extensions

2019-08-21 Thread Georg Kotheimer
The size of the FPU registers depends solely on the floating point extensions supported by the target architecture. However, in the previous implementation the floating point register size was derived from whether the target architecture is 32-bit or 64-bit. To allow RVF without RVD, changes to

[Qemu-devel] [PATCH v4 05/10] vl.c: replace deprecated qbus_reset_all registration

2019-08-21 Thread Damien Hedde
Replace deprecated qbus_reset_all by resettable_cold_reset_fn for the sysbus reset registration. This does not impact the behavior: qbus_reset_all is already a wrapper for the cold reset function. Signed-off-by: Damien Hedde Reviewed-by: Peter Maydell --- vl.c | 10 +- 1 file changed,

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/20/19 6:21 PM, BALATON Zoltan wrote: >On 8/20/19 5:37 PM, Richard Henderson wrote: >> What if we use the AArch64 mnemonics: zxt (zero-extend) and sxt >> (sign-extend)? >> This would give us >> >>    tcg_gen_zxt8_i32 >>    tcg_gen_sxt8_i32 >>    (etc) >>    tcg_gen_zxt_i32_i64 >>   

[Qemu-devel] [PATCH v4 00/10] Multi-phase reset mechanism

2019-08-21 Thread Damien Hedde
Hi all, Here's the 4th version of the multi-phase reset proposal patches. Previous version can be found here: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg06365.html The purpose of this series is to split the current reset procedure into multiple phases. This will help to solve some

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/20/19 6:46 PM, David Hildenbrand wrote: > On 20.08.19 17:37, Richard Henderson wrote: >> On 8/20/19 6:49 AM, Aleksandar Markovic wrote: From: Peter Maydell On Tue, 20 Aug 2019 at 13:50, Aleksandar Markovic wrote: > The idea is to provide significant "lexicographic"

[Qemu-devel] [PULL 1/4] hw/core: Move cpu.c, cpu.h from qom/ to hw/core/

2019-08-21 Thread Markus Armbruster
Suggested-by: Daniel P. Berrangé Signed-off-by: Markus Armbruster Message-Id: <20190709152053.16670-2-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [Rebased onto merge commit 95a9457fd44; missed instances of qom/cpu.h in comments replaced] ---

[Qemu-devel] [PULL 0/4] Monitor patches for 2019-08-21

2019-08-21 Thread Markus Armbruster
The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 14:14:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

[Qemu-devel] [PULL 2/4] qapi: Move query-target from misc.json to machine.json

2019-08-21 Thread Markus Armbruster
Move query-target and its return type TargetInfo from misc.json to machine.json, where they are covered by MAINTAINERS section "Machine core". Also move its implementation from arch_init.c to hw/core/machine-qmp-cmds, where it is likewise covered. All users of SysEmuTarget are now in

[Qemu-devel] [PULL 4/4] monitor/qmp: Update comment for commit 4eaca8de268

2019-08-21 Thread Markus Armbruster
Commit 4eaca8de268 dropped monitor_qmp_respond()'s parameter @id without updating its function comment. Fix that. Signed-off-by: Markus Armbruster Message-Id: <20190816193305.12090-1-arm...@redhat.com> --- monitor/qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 3/4] qdev: Collect HMP handlers command handlers in qdev-monitor.c

2019-08-21 Thread Markus Armbruster
Move hmp_device_add(), hmp_device_del() from monitor/hmp-cmds.c to qdev-monitor.c, where they are covered by MAINTAINERS section "QOM", just like qapi/qdev.json. hmp_info_qtree() and hmp_info_qdm() are already there. Signed-off-by: Markus Armbruster Message-Id:

Re: [Qemu-devel] [PULL 00/15] Audio 20190821 patches

2019-08-21 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20190821-pull-request > > for you to fetch changes up to e76ba19a1f1377314573a6df7e2d82b597aa3d0a: > > audio: fix memory leak r

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-21 Thread Anton Nefedov
On 21/8/2019 5:14 PM, Lukáš Doktor wrote: > Hello guys, > > First attempt was rejected due to zip attachment, let's try it again with > just Avocado-vt debug.log and serial console log files attached. > > I bisected a regression on aarch64 all the way to this commit: "qcow2: skip > writing

[Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering

2019-08-21 Thread Daniel P . Berrangé
The ordering of events that are emitted during the rmdir test have changed with kernel >= 5.3. Semantically both new & old orderings are correct, so we must be able to cope with either. To cope with this, when we see an unexpected event, we push it back onto the queue and look and the subsequent

Re: [Qemu-devel] [PATCH v1 3/4] s390x/tcg: MOVE (MVC): Increment the length once

2019-08-21 Thread Richard Henderson
On 8/21/19 2:22 AM, David Hildenbrand wrote: > Let's increment the length once. > > While at it, cleanup the comment. The memset() example is given as a > programming note in the PoP, so drop the description. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 20

Re: [Qemu-devel] [PATCH 2/2] target/m68k: Fix bug in semihosted exit handling

2019-08-21 Thread Laurent Vivier
Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : > This patch fixes a bug that caused semihosted exit to always return > status 0; it was incorrectly using the value of D0 (which > contains the HOSTED_EXIT request number) instead of D1. > > Signed-off-by: Sandra Loosemore > --- >

Re: [Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling

2019-08-21 Thread Laurent Vivier
Le 21/08/2019 à 17:27, Sandra Loosemore a écrit : > On 8/21/19 8:41 AM, Laurent Vivier wrote: >> Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : >>> This patch fixes a bug that caused semihosted exit to always return >>> status 0; it was incorrectly using the value of register R_ARG0 (which >>>

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-21 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 21 August 2019 10:20 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Stefano Stabellini > ; Paul > Durrant ; xen-de...@lists.xenproject.org > Subject: [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore > > When QEMU

Re: [Qemu-devel] [PATCH 01/13] block-crypto: misc refactoring

2019-08-21 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:07PM +0300, Maxim Levitsky wrote: > * rename the write_func to create_write_func, > and init_func to create_init_func > this is preparation for other write_func that will > be used to update the encryption keys. > > No functional changes > > Signed-off-by:

[Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends

2019-08-21 Thread Paul A. Clarke
From: "Paul A. Clarke" A class of instructions of the form: op Target,A,B which operate like: Target = Target * A + B have a bit set which distinguishes them from instructions that operate as: Target = Target * B + A This bit is not being checked properly (using PPC_BIT macro), so all

Re: [Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling

2019-08-21 Thread Sandra Loosemore
On 8/21/19 8:41 AM, Laurent Vivier wrote: Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : This patch fixes a bug that caused semihosted exit to always return status 0; it was incorrectly using the value of register R_ARG0 (which contains the HOSTED_EXIT request number) instead of register

[Qemu-devel] [PATCH v8 17/21] memory: Single byte swap along the I/O path

2019-08-21 Thread Tony Nguyen
Now that MemOp has been pushed down into the memory API, and callers are encoding endianness, we can collapse byte swaps along the I/O path into the accelerator and target independent adjust_endianness. Collapsing byte swaps along the I/O path enables additional endian inversion logic, e.g.

[Qemu-devel] [PATCH v8 14/21] exec: Hard code size with MO_{8|16|32|64}

2019-08-21 Thread Tony Nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoids size_memop calls. Signed-off-by:

[Qemu-devel] [PATCH v8 21/21] target/sparc: sun4u Invert Endian TTE bit

2019-08-21 Thread Tony Nguyen
This bit configures endianness of PCI MMIO devices. It is used by Solaris and OpenBSD sunhme drivers. Tested working on OpenBSD. Unfortunately Solaris 10 had a unrelated keyboard issue blocking testing... another inch towards Solaris 10 on SPARC64 =) Signed-off-by: Tony Nguyen Reviewed-by:

[Qemu-devel] [PATCH v8 13/21] target/mips: Hard code size with MO_{8|16|32|64}

2019-08-21 Thread Tony Nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoids size_memop calls. Signed-off-by:

[Qemu-devel] [PATCH v8 20/21] target/sparc: Add TLB entry with attributes

2019-08-21 Thread Tony Nguyen
Append MemTxAttrs to interfaces so we can pass along up coming Invert Endian TTE bit on SPARC64. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- target/sparc/mmu_helper.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH v8 12/21] hw/s390x: Hard code size with MO_{8|16|32|64}

2019-08-21 Thread Tony Nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoids size_memop calls. Signed-off-by:

[Qemu-devel] [PATCH v8 16/21] cputlb: Replace size and endian operands for MemOp

2019-08-21 Thread Tony Nguyen
Preparation for collapsing the two byte swaps adjust_endianness and handle_bswap into the former. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- accel/tcg/cputlb.c | 170 +-- include/exec/memop.h | 6 ++ 2 files changed, 87

[Qemu-devel] [PATCH v8 08/21] hw/vfio: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 18/21] cpu: TLB_FLAGS_MASK bit to force memory slow path

2019-08-21 Thread Tony Nguyen
The fast path is taken when TLB_FLAGS_MASK is all zero. TLB_FORCE_SLOW is simply a TLB_FLAGS_MASK bit to force the slow path, there are no other side effects. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- include/exec/cpu-all.h | 10 -- 1 file changed, 8 insertions(+),

[Qemu-devel] [PATCH v8 11/21] memory: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
Convert memory_region_dispatch_{read|write} operand "unsigned size" into a "MemOp op". Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- include/exec/memop.h | 20 ++-- include/exec/memory.h | 9 + memory.c | 7 +-- 3 files changed, 24

[Qemu-devel] [PATCH v8 07/21] hw/virtio: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 19/21] cputlb: Byte swap memory transaction attribute

2019-08-21 Thread Tony Nguyen
Notice new attribute, byte swap, and force the transaction through the memory slow path. Required by architectures that can invert endianness of memory transaction, e.g. SPARC64 has the Invert Endian TTE bit. Suggested-by: Richard Henderson Signed-off-by: Tony Nguyen Reviewed-by: Richard

[Qemu-devel] [PATCH v8 05/21] hw/s390x: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 09/21] exec: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 06/21] hw/intc/armv7m_nic: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 10/21] cputlb: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 03/21] memory: Introduce size_memop

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Introduce no-op size_memop to aid preparatory conversion of interfaces. Once interfaces are converted, size_memop will be implemented to return a MemOp from size in bytes. Signed-off-by: Tony

[Qemu-devel] [PATCH v8 04/21] target/mips: Access MemoryRegion with MemOp

2019-08-21 Thread Tony Nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be

[Qemu-devel] [PATCH v8 01/21] configure: Define TARGET_ALIGNED_ONLY in configure

2019-08-21 Thread Tony Nguyen
Rename ALIGNED_ONLY to TARGET_ALIGNED_ONLY for clarity and move defines out of target/foo/cpu.h into configure, as we do with TARGET_WORDS_BIGENDIAN, so that it is always defined early. Poisoned TARGET_ALIGNED_ONLY to prevent use in common code. Signed-off-by: Tony Nguyen Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH] nbd: Tolerate more errors to structured reply request

2019-08-21 Thread Eric Blake
On 8/19/19 12:57 PM, Eric Blake wrote: > A server may have a reason to reject a request for structured replies, > beyond just not recognizing them as a valid request. It doesn't hurt > us to continue talking to such a server; otherwise 'qemu-nbd --list' > of such a server fails to display all

Re: [Qemu-devel] [PATCH v7 0/9] NBD reconnect

2019-08-21 Thread Eric Blake
On 8/21/19 6:41 AM, Vladimir Sementsov-Ogievskiy wrote: > Should I resend with 07 dropped? > At this point, the earlier patches in the series are now in-tree, and the later patches need rebasing again... >>> v7: >>> almost all: rebased on merged nbd.c and nbd-client.c (including patch >>>

Re: [Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling

2019-08-21 Thread Laurent Vivier
Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : > This patch fixes a bug that caused semihosted exit to always return > status 0; it was incorrectly using the value of register R_ARG0 (which > contains the HOSTED_EXIT request number) instead of register R_ARG1. > > Signed-off-by: Sandra

Re: [Qemu-devel] [PATCH] block/backup: install notifier during creation

2019-08-21 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 23:13, John Snow wrote: > Backup jobs may yield prior to installing their handler, because of the > job_co_entry shim which guarantees that a job won't begin work until > we are ready to start an entire transaction. > > Unfortunately, this makes proving correctness about transactional

Re: [Qemu-devel] [PATCH v23 22/22] target/rx: remove unused functions.

2019-08-21 Thread Yoshinori Sato
On Wed, 21 Aug 2019 19:23:09 +0900, Philippe Mathieu-Daudé wrote: > > On 8/17/19 9:36 AM, Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > > --- > > target/rx/monitor.c | 38 -- > > target/rx/Makefile.objs | 1 - > > 2 files changed, 39

Re: [Qemu-devel] [PATCH 2/2] target/m68k: Fix bug in semihosted exit handling

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/21/19 4:21 PM, Sandra Loosemore wrote: > This patch fixes a bug that caused semihosted exit to always return > status 0; it was incorrectly using the value of D0 (which > contains the HOSTED_EXIT request number) instead of D1. > Fixes: a87295e8df0 and 0e1c9c54afb > Signed-off-by: Sandra

Re: [Qemu-devel] [PATCH v5 08/10] Adding info [tbs|tb|coverset] commands to HMP. These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host ins

2019-08-21 Thread Dr. David Alan Gilbert
* Vanderson Martins do Rosario (vanderson...@gmail.com) wrote: > Do you think that "info tb-list 15" as a command to list 15 TBs make more > sense than "info tbs 15"? > > It would be "into tb id" to investigate a specific TB and "into tb-list > number" to list the TBs. Yes I think that's

Re: [Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/21/19 4:21 PM, Sandra Loosemore wrote: > This patch fixes a bug that caused semihosted exit to always return > status 0; it was incorrectly using the value of register R_ARG0 (which > contains the HOSTED_EXIT request number) instead of register R_ARG1. > Fixes: 413a99a92c1 > Signed-off-by:

[Qemu-devel] [PATCH 0/2] Fix bug in nios2 and m68k semihosting

2019-08-21 Thread Sandra Loosemore
I noticed recently that the exit semihosting call on nios2 was ignoring its parameter and always returning status 0 instead. It turns out the handler was retrieving the value of the wrong register. Since the nios2 semihosting implementation was basically cut-and-pasted from that for m68k, I

[Qemu-devel] [PATCH 2/2] target/m68k: Fix bug in semihosted exit handling

2019-08-21 Thread Sandra Loosemore
This patch fixes a bug that caused semihosted exit to always return status 0; it was incorrectly using the value of D0 (which contains the HOSTED_EXIT request number) instead of D1. Signed-off-by: Sandra Loosemore --- target/m68k/m68k-semi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling

2019-08-21 Thread Sandra Loosemore
This patch fixes a bug that caused semihosted exit to always return status 0; it was incorrectly using the value of register R_ARG0 (which contains the HOSTED_EXIT request number) instead of register R_ARG1. Signed-off-by: Sandra Loosemore --- target/nios2/nios2-semi.c | 4 ++-- 1 file changed,

Re: [Qemu-devel] QEMU bitmap backup usability FAQ

2019-08-21 Thread Vladimir Sementsov-Ogievskiy
[CC Nikolay] 21.08.2019 1:25, John Snow wrote: > Hi, downstream here at Red Hat I've been fielding some questions about > the usability and feature readiness of Bitmaps (and related features) in > QEMU. > > Here are some questions I answered internally that I am copying to the > list for two

Re: [Qemu-devel] [PULL 00/42] ppc-for-4.2 queue 20190821

2019-08-21 Thread Peter Maydell
are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20190821 > > for you to fetch changes up to c0e6616b6685ffdb4c5e091bc152e46e14703dd1: > > ppc: Fix emulated single to double denormalized

Re: [Qemu-devel] [PATCH v5 08/10] Adding info [tbs|tb|coverset] commands to HMP. These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host ins

2019-08-21 Thread Vanderson Martins do Rosario
Do you think that "info tb-list 15" as a command to list 15 TBs make more sense than "info tbs 15"? It would be "into tb id" to investigate a specific TB and "into tb-list number" to list the TBs. Vanderson M. Rosario On Thu, Aug 15, 2019 at 6:00 AM Dr. David Alan Gilbert wrote: > *

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "qemu trace at -O2" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283732/+files/2822-1.trace.O2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title:

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "qemu trace at -Os" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283731/+files/2822-1.trace.Os -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title:

[Qemu-devel] [Bug 1840922] [NEW] qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
Public bug reported: Hi, While experimenting with running the GCC testsuite with cortex-m33 as target (to exercise v8-m code), I came across this failure: qemu: unhandled CPU exception 0x8 - aborting R00=fffeaf58 R01=fffeaf58 R02= R03=fffeaf5d R04=fffeaf5c R05=fffeaf9c R06=

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "executable at -O2" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283730/+files/2822-1.exe.O2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title:

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "executable at -Os" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283729/+files/2822-1.exe.Os -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title:

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "asm at -O2" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283728/+files/2822-1.s.O2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title: qemu-arm

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-21 Thread Christophe Lyon
** Attachment added: "asm at -Os" https://bugs.launchpad.net/qemu/+bug/1840922/+attachment/5283727/+files/2822-1.s.Os -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title: qemu-arm

Re: [Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-21 Thread Maxim Levitsky
On Wed, 2019-08-21 at 00:31 +0200, Aleksandar Markovic wrote: > 20.08.2019. 23.56, "Brad Parker" <1819...@bugs.launchpad.net> је написао/ла: > > > > So it looks like even though that commit fixed it, it seems to break > > again (differently) in 3.0.0, so I'll need to do another bisect between > >

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-21 Thread Philippe Mathieu-Daudé
> cd1bfd5ef336166b275a09dc9842542bf5e63ae3 is the first bad commit Unfortunately this is a commit related to SeaBIOS submodule. This commit only update the built BIOS roms. The commits before this one are the ones modifying SeaBIOS, justifying roms to be rebuilt: eda553a442 seabios: enable ide

Re: [Qemu-devel] [PATCH] target/alpha: fix tlb_fill trap_arg2 value for instruction fetch

2019-08-21 Thread Peter Maydell
On Wed, 21 Aug 2019 at 14:42, Aurelien Jarno wrote: > > Commit e41c94529740cc26 ("target/alpha: Convert to CPUClass::tlb_fill") > slightly changed the way the trap_arg2 value is computed in case of TLB > fill. The type of the variable used in the ternary operator has been > changed from an int to

[Qemu-devel] [Bug 1840920] [NEW] changelog 4.1 krenel typo

2019-08-21 Thread Nero Burner
Public bug reported: The changelog for 4.1 subsection Arm has a typo (krenel --> kernel) https://wiki.qemu.org/ChangeLog/4.1#Arm At the following line: The i.mx7 PCI controller emulation has been improved so it can boot current Linux krenels it should be: The i.mx7 PCI controller emulation

[Qemu-devel] [PATCH] target/alpha: fix tlb_fill trap_arg2 value for instruction fetch

2019-08-21 Thread Aurelien Jarno
Commit e41c94529740cc26 ("target/alpha: Convert to CPUClass::tlb_fill") slightly changed the way the trap_arg2 value is computed in case of TLB fill. The type of the variable used in the ternary operator has been changed from an int to an enum. This causes the -1 value to not be sign-extended to

Re: [Qemu-devel] [SeaBIOS] Re: Regression with floppy drive controller

2019-08-21 Thread Kevin O'Connor
On Wed, Aug 21, 2019 at 08:42:08AM +0200, Gerd Hoffmann wrote: > Hi, > > > Using the default QEMU config, we build SeaBIOS to use the TSC timer: > > > > builds/seabios-128k/.config:CONFIG_TSC_TIMER=y > > builds/seabios-256k/.config:CONFIG_TSC_TIMER=y > > > Do we need a cpu with TSC support to

Re: [Qemu-devel] [PATCH v2 44/68] target/arm: Add skeleton for T16 decodetree

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:37 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 6 ++ > target/arm/Makefile.objs | 6 ++ > target/arm/t16.decode| 20 > 3 files changed, 32 insertions(+)

Re: [Qemu-devel] [PATCH v2 38/68] target/arm: Convert Unallocated memory hint

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:37 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 8 > target/arm/a32-uncond.decode | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 37/68] target/arm: Convert PLI, PLD, PLDW

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:37 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 37 +++- > target/arm/a32-uncond.decode | 10 ++ > 2 files changed, 30 insertions(+), 17 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 36/68] target/arm: Convert SETEND

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:37 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 22 +- > target/arm/a32-uncond.decode | 4 > 2 files changed, 17 insertions(+), 9 deletions(-) > > diff --git a/target/arm/translate.c

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-21 Thread Maxim Levitsky
On Wed, 2019-08-21 at 13:31 +0200, Markus Armbruster wrote: > Maxim Levitsky writes: > > > On Thu, 2019-08-15 at 10:00 -0500, Eric Blake wrote: > > > On 8/15/19 9:44 AM, Maxim Levitsky wrote: > > > > > > > > > > Does the idea of a union type with a default value for the > > > > > > >

Re: [Qemu-devel] [PATCH v2 08/68] target/arm: Convert Saturating addition and subtraction

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:36 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson Nice :) Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 75 +++--- > target/arm/a32.decode | 10 ++ > target/arm/t32.decode | 9 + > 3 files

Re: [Qemu-devel] [PATCH v2 32/68] target/arm: Convert SVC

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:37 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 19 +-- > target/arm/a32.decode | 4 > 2 files changed, 17 insertions(+), 6 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 02/68] target/arm: Add stubs for aa32 decodetree

2019-08-21 Thread Philippe Mathieu-Daudé
On 8/19/19 11:36 PM, Richard Henderson wrote: > Add the infrastructure that will become the new decoder. > No instructions adjusted so far. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 31 ++- >

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2019-08-20

2019-08-21 Thread Peter Maydell
On Tue, 20 Aug 2019 at 19:03, Paolo Bonzini wrote: > > The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 > 14:14:20 +0100) > > are available in the git

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-21 Thread Brad Parker
I tried reverting that commit on top of master but it did not help, so I'm guessing it broke yet again (differently) somewhere else. I'll try reverting cd1bfd5 on top of the very next commit and bisect from there to master, and see where that takes me. -- You received this bug notification

Re: [Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop (resend)

2019-08-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190821122315.18015-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop (resend)

[Qemu-devel] [PATCH v2 2/5] target-tricore: Make env a member of DisasContext

2019-08-21 Thread Bastian Koppelmann
otherwise we have to pass env down through all functions which blocks the usage of translator_loop. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 340 ++--- 1 file changed, 168 insertions(+), 172 deletions(-)

[Qemu-devel] [PATCH v2 1/5] target/tricore: Use DisasContextBase API

2019-08-21 Thread Bastian Koppelmann
this gets rid of the copied fields of TriCore's DisasContext and now uses the shared DisasContextBase, which is necessary for the conversion to translate_loop. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 98

[Qemu-devel] [PATCH v2 4/5] target/tricore: Implement a qemu excptions helper

2019-08-21 Thread Bastian Koppelmann
this helper is only used to raise qemu specific exceptions. We use this helper to raise it on breakpoints as well as the TriCore debug insn. Signed-off-by: Bastian Koppelmann --- target/tricore/helper.h| 1 + target/tricore/op_helper.c | 7 +++ target/tricore/translate.c | 24

[Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop (resend)

2019-08-21 Thread Bastian Koppelmann
(sorry about the noise, git-sendmail just quit with "Temporary local problem - please try later" after sending two of the mails) Hi, I finally came around to port TriCore to the "new" translate_loop infrastructure. This is necessary such that TriCore can be used in the upcoming plugin API [1].

[Qemu-devel] [PATCH v2 5/5] target/tricore: Fix tricore_tr_translate_insn

2019-08-21 Thread Bastian Koppelmann
we now fetch 2 bytes first, check whether we have a 32 bit insn, and only then fetch another 2 bytes. We also make sure that a 16 bit insn that still fits into the current page does not end up in the next page. Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 47

[Qemu-devel] [PATCH v2 3/5] target/tricore: Use translate_loop

2019-08-21 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- v1 -> v2: - save hflags in tricore_tr_init_disas_context() target/tricore/translate.c | 118 +++-- 1 file changed, 74 insertions(+), 44 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c

Re: [Qemu-devel] [PATCH v8 9/9] qapi: query-blockstat: add driver specific file-posix stats

2019-08-21 Thread Anton Nefedov
On 21/8/2019 2:21 PM, Max Reitz wrote: > On 21.08.19 13:00, Anton Nefedov wrote: >> On 12/8/2019 10:04 PM, Max Reitz wrote: >>> On 16.05.19 16:33, Anton Nefedov wrote: A block driver can provide a callback to report driver-specific statistics. file-posix driver now reports

[Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop

2019-08-21 Thread Bastian Koppelmann
Hi, I finally came around to port TriCore to the "new" translate_loop infrastructure. This is necessary such that TriCore can be used in the upcoming plugin API [1]. Cheers, Bastian [1] (https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg03165.html) v1 -> v2: [03/05] Now also save

[Qemu-devel] [PATCH v2 1/5] target/tricore: Use DisasContextBase API

2019-08-21 Thread Bastian Koppelmann
this gets rid of the copied fields of TriCore's DisasContext and now uses the shared DisasContextBase, which is necessary for the conversion to translate_loop. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 98

[Qemu-devel] [PATCH v3] virtio pmem: user document

2019-08-21 Thread Pankaj Gupta
This patch documents the steps to use virtio pmem. It also documents other useful information about virtio pmem e.g use-case, comparison with Qemu NVDIMM backend and current limitations. Signed-off-by: Pankaj Gupta --- v3->v3 - Text format fixes - Cornerlia v1->v2 - Fixes on text format and

Re: [Qemu-devel] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-21 Thread Laszlo Ersek
On 08/19/19 16:10, Paolo Bonzini wrote: > On 19/08/19 01:00, Yao, Jiewen wrote: >> in real world, we deprecate AB-seg usage because they are vulnerable >> to smm cache poison attack. I assume cache poison is out of scope in >> the virtual world, or there is a way to prevent ABseg cache poison. >

[Qemu-devel] 答复: [BUG] living migrate vm pause forever

2019-08-21 Thread Yuchen
In migration_maybe_pause we have: migrate_set_state(>state, *current_active_state, MIGRATION_STATUS_PRE_SWITCHOVER); qemu_sem_wait(>pause_sem); migrate_set_state(>state, MIGRATION_STATUS_PRE_SWITCHOVER, new_state); the line numbers don't

Re: [Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)"

2019-08-21 Thread owen...@ucloud.cn
It is CentOS 6.3 with kernel version 2.6.32-279. Actually all CentOS 6 releases have this issue. owen...@ucloud.cn From: Eduardo Habkost Date: 2019-08-21 19:19 To: owen...@ucloud.cn CC: qemu-devel Subject: Re: Re: [Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)" On Wed, Aug 21,

Re: [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment

2019-08-21 Thread Corey Minyard
On Wed, Aug 21, 2019 at 01:19:42PM +0200, Laurent Vivier wrote: > From: Philippe Mathieu-Daudé > > GCC9 is confused by this comment when building with CFLAG > -Wimplicit-fallthrough=2: > > hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’: > hw/ipmi/ipmi_bmc_extern.c:178:12: error: this

Re: [Qemu-devel] [PATCH v3] make check-unit: use after free in test-opts-visitor

2019-08-21 Thread Andrey Shinkevich
On 21/08/2019 14:25, Markus Armbruster wrote: > Andrey Shinkevich writes: > >> In the struct OptsVisitor, the 'repeated_opts' member points to a list >> in the 'unprocessed_opts' hash table after the list has been destroyed. >> A subsequent call to visit_type_int() references the deleted list.

Re: [Qemu-devel] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev)

2019-08-21 Thread Markus Armbruster
Maxim Levitsky writes: > This adds: > > * x-blockdev-update-encryption and x-blockdev-erase-encryption qmp commands > Both commands take the QCryptoKeyManageOptions > the x-blockdev-update-encryption is meant for non destructive addition > of key slots / whatever the encryption driver

Re: [Qemu-devel] [PATCH v7 0/9] NBD reconnect

2019-08-21 Thread Vladimir Sementsov-Ogievskiy
Should I resend with 07 dropped? 25.07.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > ping > > 18.06.2019 14:43, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> Here is NBD reconnect. Previously, if connection failed all current >> and future requests will fail. After the series, nbd-client

Re: [Qemu-devel] [PATCH v8 9/9] qapi: query-blockstat: add driver specific file-posix stats

2019-08-21 Thread Max Reitz
On 21.08.19 13:00, Anton Nefedov wrote: > On 12/8/2019 10:04 PM, Max Reitz wrote: >> On 16.05.19 16:33, Anton Nefedov wrote: >>> A block driver can provide a callback to report driver-specific >>> statistics. >>> >>> file-posix driver now reports discard statistics >>> >>> Signed-off-by: Anton

<    1   2   3   4   5   >