Re: [Qemu-devel] [RFC,Draft] ui: add an embedded Barrier client

Hi, > For instance: > > section: screens > localhost: > ... > VM-1: > ... > end > > section: links > localhost: > right = VM-1 > VM-1: > left = localhost > end > > Then on the QEMU command line: > > ... -object

Re: [Qemu-devel] [PATCH v4 2/5] memory: Add IOMMU_ATTR_HW_NESTED_PAGING IOMMU memory region attribute

Hi Peter, On 8/27/19 6:19 PM, Peter Maydell wrote: > On Thu, 22 Aug 2019 at 18:24, Eric Auger wrote: >> >> We introduce a new IOMMU Memory Region attribute, >> IOMMU_ATTR_HW_NESTED_PAGING that tells whether the virtual >> IOMMU relies on physical IOMMU HW nested paging capability >> when

Re: [Qemu-devel] [PATCH 3/4] docs: document use of automatic cleanup functions in glib

On Fri, Aug 23, 2019 at 05:39:30PM +0100, Daniel P. Berrangé wrote: > Document the use of g_autofree and g_autoptr in glib for automatic > freeing of memory, or other resource cleanup (eg mutex unlocking). > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.md | 101

Re: [Qemu-devel] [Qemu-arm] [PATCH 6/7] target/arm: Simplify SMMLA, SMMLAR, SMMLS, SMMLSR

Hi Richard, On Thu, Aug 8, 2019 at 10:28 PM Richard Henderson wrote: > > All of the inputs to these instructions are 32-bits. Rather than > extend each input to 64-bits and then extract the high 32-bits of > the output, use tcg_gen_muls2_i32 and other 32-bit generator functions. > >

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

On Tue, 2019-08-27 at 18:29 -0400, John Snow wrote: > > On 8/25/19 3:15 AM, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > block/nvme.c | 83 ++ > > block/trace-events | 2 ++ > > 2 files changed, 85 insertions(+) > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/4] block: Add zoned device model property

On Fri, Aug 23, 2019 at 03:49:24PM -0400, Dmitry Fomichev wrote: > +uint8_t bdrv_is_zoned(BlockDriverState *bs) > +{ > +/* > + * Host Aware zone devices are supposed to be able to work > + * just like regular block devices. Thus, we only consider > + * Host Managed devices to be

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

27.08.2019 23:12, John Snow wrote: > > > On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: >>> To get rid of implicit filters related workarounds in future let's >>> deprecate them now. >> >> Interesting, could we deprecate implicit

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi as vhost-vsock maintainer

On Thu, Aug 15, 2019 at 02:26:51PM +0100, Stefan Hajnoczi wrote: > A MAINTAINERS entry wasn't added when this code was merged. Add it now > so that scripts/get_maintainer.pl works for vhost-vsock. > > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 7 +++ > 1 file changed, 7

Re: [Qemu-devel] [PATCH v3] libvhost-user-glib: fix VugDev main fd cleanup

Hi, > > +g_source_unref(src); > > +g_source_destroy(src); > > I would call destroy() (detach) before unref(). Fair enough. I think there's an internal reference, but it's probably safer that way. > > +vugg_source_destroy(vi.evsrc); > > typo Oops. I thought I compiled it, I guess

Re: [Qemu-devel] [PATCH V3] gdbstub: Fix handler for 'F' packet

Sandra Loosemore writes: > Handling of the 'F' packet has been broken since commit > 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use > the new packet parsing infrastructure. Per the GDB RSP specification > >

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

Le 26/08/2019 à 23:10, Josh Kunz a écrit : > On Wed, Aug 21, 2019 at 2:28 AM Laurent Vivier > wrote: > > Le 19/08/2019 à 23:46, Josh Kunz via Qemu-devel a écrit : > > Hi all, > > > > I have also experienced issues with SIGRTMIN + 1, and am interested in

Re: [Qemu-devel] [RFC,Draft] ui: add an embedded Barrier client

Hi, Le 28/08/2019 à 08:11, Gerd Hoffmann a écrit : > Hi, > >> For instance: >> >> section: screens >> localhost: >> ... >> VM-1: >> ... >> end >> >> section: links >> localhost: >> right = VM-1 >> VM-1: >> left =

Re: [Qemu-devel] [PATCH 2/2] backends/vhost-user.c: prevent using uninitialized vqs

On Thu, Aug 22, 2019 at 11:34:25AM -0700, Raphael Norwitz wrote: > Similar rational to: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844 > > For vhost scsi and vhost-user-scsi an issue was observed > where, of the 3 virtqueues, seabios would only set cmd, > leaving ctrl and event without a physical

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: prevent using uninitialized vqs

On Thu, Aug 22, 2019 at 11:34:24AM -0700, Raphael Norwitz wrote: > Same rational as: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844 > > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > and event without a physical address. This can cause > vhost_verify_ring_part_mapping to return ENOMEM,

Re: [Qemu-devel] [PATCH 1/2] block/nvme: add support for write zeros

On Tue, 2019-08-27 at 18:22 -0400, John Snow wrote: > Without a commit message, I have no real hope of reviewing this. I was > CC'd, though, so I'll give it a blind shot. > > We want to add write_zeroes support for block/nvme, but I can't really > verify any of that is correct or working without

Re: [Qemu-devel] [PATCH] pseries: Fix compat_pvr on reset

On Mon, 26 Aug 2019 11:08:12 +0200 Laurent Vivier wrote: > If we a migrate P8 machine to a P9 machine, the migration fails on > destination with: > > error while loading state for instance 0x1 of device 'cpu' > load of migration failed: Operation not permitted > > This is caused because

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi as vhost-vsock maintainer

Stefan Hajnoczi writes: > A MAINTAINERS entry wasn't added when this code was merged. Add it now > so that scripts/get_maintainer.pl works for vhost-vsock. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alex Bennée > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > >

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

> > Hmm, can we create an useful name automatically, without yet another > > config option? > > > > Useful choices could be the device name (usb-audio, ...) or the device > > id (whatever -device id=xxx was specified on the command line). > > I'm afraid this is not going to work with the current

Re: [Qemu-devel] [RFC,Draft] ui: add an embedded Barrier client

Hi, > >> +p = write_short(ib, p, 1920); /* width */ > >> +p = write_short(ib, p, 1080); /* height */ > > > > Hmm. > > > > This is the screen size I guess? Which you don't know ... > > What this is used for? > > Should we maybe use INPUT_EVENT_ABS_MAX here? > > > > Yes, it's

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

liuzhiwei writes: > Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 > Signed-off-by: liuzhiwei > --- > fpu/softfloat.c | 119 + > include/fpu/softfloat.h | 4 + Changes to softfloat should be in a separate patch, but see bellow. >

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

Eduardo Habkost writes: > We have this issue reported when using libvirt to hotplug CPUs: > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > Basically, libvirt is not copying die-id from > query-hotpluggable-cpus, but die-id is now mandatory. > > We could blame libvirt and say it is not

Re: [Qemu-devel] [PATCH v2 1/7] s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in probe_write_access()

On Mon, 26 Aug 2019 09:51:06 +0200 David Hildenbrand wrote: > If I'm not completely wrong, we are dealing with guest addresses here > and not with host addresses. Use the right check. > > Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access helper") > Reviewed-by: Richard Henderson >

[Qemu-devel] [PATCH] xhci: Fix memory leak in xhci_kick_epctx

From: fangying Address Sanitizer shows memory leak in xhci_kick_epctx hw/usb/hcd-xhci.c:1912. A sglist is leaked when a packet is retired and returns USB_RET_NAK status. The leak stack is as bellow: Direct leak of 2688 byte(s) in 168 object(s) allocated from: #0 0xae8b11db in

Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

On Tue, Aug 27, 2019 at 07:16:50PM +0800, Ying Fang wrote: > Address Sanitizer shows memory leak in migrate_params_test_apply > migration/migration.c:1253 and the stack is as bellow: > > Direct leak of 45 byte(s) in 9 object(s) allocated from: > #0 0xbd7fc1db in __interceptor_malloc

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On Wed, 2019-08-28 at 09:33 +0200, Gerd Hoffmann wrote: > > > Hmm, can we create an useful name automatically, without yet another > > > config option? > > > > > > Useful choices could be the device name (usb-audio, ...) or the device > > > id (whatever -device id=xxx was specified on the command

Re: [Qemu-devel] [RFC 3/3] virt: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256

Hi Richard, On 8/28/19 5:28 AM, Richard Henderson wrote: > On 8/27/19 9:05 AM, Eric Auger wrote: >> +++ b/target/arm/kvm_arm.h >> @@ -233,6 +233,14 @@ bool kvm_arm_pmu_supported(CPUState *cs); >> */ >> int kvm_arm_get_max_vm_ipa_size(MachineState *ms); >> >> +/** >> + *

Re: [Qemu-devel] [PATCH v2 2/7] s390x/tcg: Fix length calculation in probe_write_access()

On Mon, 26 Aug 2019 09:51:07 +0200 David Hildenbrand wrote: > Hm... how did that "-" slip in (-TAGRET_PAGE_SIZE would be correct). This s/TAGRET/TARGET/ > currently makes us exceed one page in a single probe_write() call, > essentially leaving some memory unchecked. > > Fixes: c5a7392cfb96

[Qemu-devel] [PATCH v4] libvhost-user-glib: fix VugDev main fd cleanup

From: Johannes Berg If you try to make a device implementation that can handle multiple connections and allow disconnections (which requires overriding the VHOST_USER_NONE handling), then glib will warn that we remove a src while it's still on the mainloop, and will poll() an FD that doesn't

Re: [Qemu-devel] [PATCH 1/1] protocol: Add NBD_CMD_FLAG_FAST_ZERO

23.08.2019 17:34, Eric Blake wrote: > While it may be counterintuitive at first, the introduction of > NBD_CMD_WRITE_ZEROES and NBD_CMD_BLOCK_STATUS has caused a performance > regression in qemu [1], when copying a sparse file. When the > destination file must contain the same contents as the

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On Wed, 2019-08-28 at 10:53 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote: > > On 2019-08-27 07:42, Gerd Hoffmann wrote: > > > On Mon, Aug 26, 2019 at 09:59:04PM +0200, Kővágó, Zoltán wrote: > > > > This can be used to identify stream in tools

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On Wed, Aug 28, 2019 at 01:14:03PM +0300, Maxim Levitsky wrote: > On Wed, 2019-08-28 at 10:53 +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote: > > > On 2019-08-27 07:42, Gerd Hoffmann wrote: > > > > On Mon, Aug 26, 2019 at 09:59:04PM +0200,

Re: [Qemu-devel] [PATCH] migration: register_savevm_live doesn't need dev

On Thu, 22 Aug 2019 12:54:33 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Commit 78dd48df3 removed the last caller of register_savevm_live for an > instantiable device (rather than a single system wide device); > so trim out the parameter. > >

Re: [Qemu-devel] [PATCH 0/2] contrib/gitdm: Minor adjustments

Markus Armbruster writes: > Markus Armbruster (2): > contrib/gitdm: filetype interface is not in order, fix > contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat Queued to gitdm/next, thanks. > > contrib/gitdm/filetypes.txt| 2 +- > contrib/gitdm/group-map-redhat | 1 + > 2

Re: [Qemu-devel] [PATCH v2 2/2] block: Remove unused masks

Nir Soffer wrote: > Replace confusing usage: > > ~BDRV_SECTOR_MASK > > With more clear: > > (BDRV_SECTOR_SIZE - 1) > > Remove BDRV_SECTOR_MASK and the unused BDRV_BLOCK_OFFSET_MASK which was > it's last user. > > Signed-off-by: Nir Soffer Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH] contrib/gitdm: Add RT-RK to the domain-map

Philippe Mathieu-Daudé writes: > This company has at least 7 contributors, add a domain-map entry. > > Signed-off-by: Philippe Mathieu-Daudé Opps I missed this one and added my own version this morning. > --- > contrib/gitdm/domain-map | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array

On 28.08.19 14:33, Thomas Huth wrote: > We're clearing the BSS in start.S now, so there is no need to > pre-initialize the loadparm_str array with zeroes anymore. Can you add a link to the commit that does the bss clearing? I think it was commit 339686a358b11a231aa5b6d1424e7a1460d7f277 Author:

Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/4] virtio/block: handle zoned backing devices

On Fri, Aug 23, 2019 at 03:49:23PM -0400, Dmitry Fomichev wrote: > Dmitry Fomichev (4): > block: Add zoned device model property > raw: Recognize zoned backing devices > block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED > raw: Don't open ZBDs if backend can't handle them The overall approach

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi as vhost-vsock maintainer

On Thu, Aug 15, 2019 at 02:26:51PM +0100, Stefan Hajnoczi wrote: > A MAINTAINERS entry wasn't added when this code was merged. Add it now > so that scripts/get_maintainer.pl works for vhost-vsock. > > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 7 +++ > 1 file changed, 7

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

On Wed, 28 Aug 2019 15:57:40 +1000 David Gibson wrote: > On Wed, Aug 28, 2019 at 01:27:35PM +1000, Alexey Kardashevskiy wrote: > > > > > > On 28/08/2019 12:12, David Gibson wrote: > > > On Wed, Aug 28, 2019 at 10:46:34AM +1000, David Gibson wrote: > > > > On Tue, Aug 27, 2019 at 04:56:50PM

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On Wed, 2019-08-28 at 11:26 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 28, 2019 at 01:14:03PM +0300, Maxim Levitsky wrote: > > On Wed, 2019-08-28 at 10:53 +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote: > > > > On 2019-08-27 07:42, Gerd

[Qemu-devel] [PULL 0/2] Audio 20190828 patches

The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190828-pull-request

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On Tue, 27 Aug 2019 22:11:15 +0200 Laszlo Ersek wrote: > On 08/27/19 18:23, Igor Mammedov wrote: > > On Mon, 26 Aug 2019 17:30:43 +0200 > > Laszlo Ersek wrote: > > > >> On 08/23/19 17:25, Kinney, Michael D wrote: > >>> Hi Jiewen, > >>> > >>> If a hot add CPU needs to run any code before the >

[Qemu-devel] [PATCH v1 3/8] mailmap: Reorder by sections

From: Philippe Mathieu-Daudé Our mailmap currently has 4 sections somehow documented. Reorder few entries not related to "addresses from the original git import" into the 3rd section, and add a comment to describe it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic

[Qemu-devel] [PATCH v1 2/8] contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat

From: Markus Armbruster Just to get the (few) accidental uses of my private e-mail address attributed correctly. Signed-off-by: Markus Armbruster Message-Id: <20190822122350.29852-3-arm...@redhat.com> --- contrib/gitdm/group-map-redhat | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v1 7/8] contrib/gitdm: add RT-RK to domain-map

I added this because Mateja is showing up in the top 10 stats for the last year. I have noticed a bunch of the Wavecomp guys have been sending messages from RT-RK but I'm assuming they are different entities. Signed-off-by: Alex Bennée Cc: Stefan Brankovic Cc: Mateja Marjanovic ---

[Qemu-devel] [PATCH v1 1/8] contrib/gitdm: filetype interface is not in order, fix

From: Markus Armbruster gitm prints the rather cryptic message "interface not found, appended to the last order". This is because filetypes.txt has filetype interface, but neglects to mention it in order. Fix that. Fixes: 2f28271d807edfcdc47a280c06999dd866dcae10 Signed-off-by: Markus

[Qemu-devel] [PATCH v1 6/8] .mailmap/aliases: add some further commentary

The two files are not interchangeable but a change to one *might* require a change to the other so lets flag that up with an explanation of what both files are trying to achieve. While we are at it document the many forms .mailmap can take in the header. Signed-off-by: Alex Bennée --- .mailmap

Re: [Qemu-devel] [PATCH 0/4] docs: add docs about use of automatic cleanup functions

[Qemu-devel] [PATCH] usb-mtp: add sanity checks on rootdir

Currently, we don't check if rootdir exists and is accessible. Furthermore, a trailing slash results in a null "desc" string which ends up in the share not visible in the guest. Add some simple sanity checks for appropriate permissions. Also, bail out if the user does not supply an absolute

[Qemu-devel] [PATCH] qemu-doc: Do not hard-code the name of the QEMU binary

In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and "qemu-system-x86_64" when we give examples to the users how to run QEMU. Some more consistency would be good here. Also some distributions use different names for the QEMU binary (e.g. "qemu-kvm" in RHEL), so providing more

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED

On Fri, Aug 23, 2019 at 03:49:26PM -0400, Dmitry Fomichev wrote: > Added a new boolean argument to blkconf_apply_backend_options() > to let the common block code know whether the chosen block > backend can handle zoned block devices or not. > > blkconf_apply_backend_options() then sets

Re: [Qemu-devel] [PATCH v5 4/4] raw: Don't open ZBDs if backend can't handle them

On Fri, Aug 23, 2019 at 03:49:27PM -0400, Dmitry Fomichev wrote: > diff --git a/block/file-posix.c b/block/file-posix.c > index d9f2fc5e46..090e7c4d2f 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -2884,6 +2884,20 @@ static int raw_check_perm(BlockDriverState *bs, > uint64_t

Re: [Qemu-devel] [PATCH v4] libvhost-user-glib: fix VugDev main fd cleanup

On Wed, Aug 28, 2019 at 12:37 PM Johannes Berg wrote: > > From: Johannes Berg > > If you try to make a device implementation that can handle multiple > connections and allow disconnections (which requires overriding the > VHOST_USER_NONE handling), then glib will warn that we remove a src >

Re: [Qemu-devel] [PATCH] hw/arm/boot: Load the Non Linux initrd to the memory

On 2019/8/27 17:47, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 10:42, Dongjiu Geng wrote: >> >> Except support linux operation system, qemu also supports other >> operation system which is non linux, such as microkernel system. >> >> But now Qemu only load linux initrd, so change it to load

[Qemu-devel] [PATCH v1 5/8] mailmap: Add many entries to improve 'git shortlog' statistics

From: Philippe Mathieu-Daudé All of these emails have a least 1 commit with utf8/latin1 encoding issue, or one with no author name. When there are multiple commits, keep the author name the most used. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190822230916.576-4-phi...@redhat.com>

Re: [Qemu-devel] [PATCH v1 6/8] .mailmap/aliases: add some further commentary

28.08.2019. 14.22, "Alex Bennée" је написао/ла: > > The two files are not interchangeable but a change to one *might* > require a change to the other so lets flag that up with an explanation > of what both files are trying to achieve. While we are at it document > the many forms .mailmap can take

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

On Fri, Aug 23, 2019 at 03:03:39PM +0200, Max Reitz wrote: > Hi, > > As suggested by Paolo, this series drops xfsctl() calls where we have > working fallocate() alternatives. (And thus replaces “block/file-posix: > Fix xfs_write_zeroes()”.) > > Unfortunately, we also use xfsctl() to inquire the

Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/4] raw: Recognize zoned backing devices

On Fri, Aug 23, 2019 at 03:49:25PM -0400, Dmitry Fomichev wrote: > +static int hdev_get_zoned_model(int fd) Please use the enum: static BdrvZonedModel hdev_get_zoned_model(int fd) > +{ > +#ifdef CONFIG_LINUX > +char buf[32]; > +int ret; > + > +ret = hdev_read_blk_queue_entry(fd,

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote: > On 2019-08-27 07:42, Gerd Hoffmann wrote: > > On Mon, Aug 26, 2019 at 09:59:04PM +0200, Kővágó, Zoltán wrote: > >> This can be used to identify stream in tools like pavucontrol when one > >> creates multiple -audiodevs or runs

[Qemu-devel] [PULL 1/2] audio: fix invalid malloc size in audio_create_pdos

From: Kővágó, Zoltán The code used sizeof(AudiodevAlsaPerDirectionOptions) instead of the appropriate per direction options for the audio backend. If the size of the actual audiodev's per direction options are larger than alsa's, it could cause a buffer overflow. However, alsa has three fields

[Qemu-devel] [PATCH v1 3/8] mailmap: Reorder by sections

From: Philippe Mathieu-Daudé Our mailmap currently has 4 sections somehow documented. Reorder few entries not related to "addresses from the original git import" into the 3rd section, and add a comment to describe it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

Hi Peter, On 8/13/19 10:41 AM, Jason Wang wrote: > > On 2019/8/12 下午3:45, Peter Xu wrote: >> This is a RFC series. >> >> The VT-d code has some defects, one of them is that we cannot detect >> the misuse of vIOMMU and vfio-pci early enough. >> >> For example, logically this is not allowed: >> >>

[Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page

... similar to tlb_vaddr_to_host(); however, allow access to the host page except when TLB_NOTDIRTY or TLB_MMIO is set. Signed-off-by: David Hildenbrand --- accel/tcg/cputlb.c | 22 +- accel/tcg/user-exec.c | 6 -- include/exec/exec-all.h | 4 ++-- 3 files

[Qemu-devel] [PATCH v1 7/8] contrib/gitdm: add RT-RK to domain-map

I added this because Mateja is showing up in the top 10 stats for the last year. I have noticed a bunch of the Wavecomp guys have been sending messages from RT-RK but I'm assuming they are different entities. Signed-off-by: Alex Bennée Cc: Stefan Brankovic Cc: Mateja Marjanovic ---

[Qemu-devel] [PATCH v1 2/8] contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat

From: Markus Armbruster Just to get the (few) accidental uses of my private e-mail address attributed correctly. Signed-off-by: Markus Armbruster Message-Id: <20190822122350.29852-3-arm...@redhat.com> --- contrib/gitdm/group-map-redhat | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v1 1/8] contrib/gitdm: filetype interface is not in order, fix

From: Markus Armbruster gitm prints the rather cryptic message "interface not found, appended to the last order". This is because filetypes.txt has filetype interface, but neglects to mention it in order. Fix that. Fixes: 2f28271d807edfcdc47a280c06999dd866dcae10 Signed-off-by: Markus

[Qemu-devel] [PATCH v1 4/8] mailmap: Update philmd email address

From: Philippe Mathieu-Daudé Use the email address where I spend most of my time. Suggested-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20190822230916.576-3-phi...@redhat.com> Signed-off-by: Alex Bennée --- .mailmap | 1 + 1

[Qemu-devel] [PATCH v1 0/8] various gitdm and mailmap updates

Hi, With another release out of the door and KVM Forum approaching it is a good time to clean up our gitdm stats. As usual updates for academic institutions and individual contributors involve a bit of guess work so I have CC'd those affected for their confirmation. There is also a large amount

[Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array

We're clearing the BSS in start.S now, so there is no need to pre-initialize the loadparm_str array with zeroes anymore. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v3] spapr_pci: Advertise BAR reallocation capability

On Fri, 19 Jul 2019 14:37:34 +1000 Alexey Kardashevskiy wrote: > The pseries guests do not normally allocate PCI resources and rely on > the system firmware doing so. Furthermore at least at some point in > the past the pseries guests won't even allowed to change BARs, probably > it is still the

[Qemu-devel] [PATCH v4 1/3] qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

[Qemu-devel] [PATCH v1 0/2] tcg: Introduce probe_access() and return a host pointer

Let's return a host pointer from probe_access() if possible and provide probe_access(). s390x will soon make use of probe_access() and use the provided host pointer. Based on tcg-next and "tcg: probe_write() refactorings". Cc: Paolo Bonzini Cc: Riku Voipio David Hildenbrand (2): tcg: Make

[Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write() logic into probe_access()

Let's also allow to probe other access types. Signed-off-by: David Hildenbrand --- accel/tcg/cputlb.c | 48 + accel/tcg/user-exec.c | 25 - include/exec/exec-all.h | 9 ++-- 3 files changed, 61 insertions(+), 21

[Qemu-devel] [PULL 2/2] audio: omitting audiodev= parameter is only deprecated

From: Kővágó, Zoltán Unfortunately, changes introduced in af2041ed2d "audio: audiodev= parameters no longer optional when -audiodev present" breaks backward compatibility. This patch changes the error into a deprecation warning. Signed-off-by: Kővágó, Zoltán Message-id:

Re: [Qemu-devel] [PATCH v2 2/4] audio: omitting audiodev= parameter is only deprecated

On Mon, Aug 26, 2019 at 09:59:02PM +0200, Kővágó, Zoltán wrote: > Unfortunately, changes introduced in af2041ed2d "audio: audiodev= > parameters no longer optional when -audiodev present" breaks backward > compatibility. This patch changes the error into a deprecation warning. Prepared a pull

[Qemu-devel] [PATCH v1 4/8] mailmap: Update philmd email address

From: Philippe Mathieu-Daudé Use the email address where I spend most of my time. Suggested-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20190822230916.576-3-phi...@redhat.com> Signed-off-by: Alex Bennée --- .mailmap | 1 + 1

[Qemu-devel] [PATCH v1 6/8] .mailmap/aliases: add some further commentary

The two files are not interchangeable but a change to one *might* require a change to the other so lets flag that up with an explanation of what both files are trying to achieve. While we are at it document the many forms .mailmap can take in the header. Signed-off-by: Alex Bennée --- .mailmap

Re: [Qemu-devel] [PATCH 1/4] docs: convert CODING_STYLE and HACKING to markdown syntax

Daniel P. Berrangé writes: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée > diff --git a/README b/README > index 441c33eb2f..374b8f1486 100644 > --- a/README > +++ b/README > @@ -60,7 +60,7 @@ When submitting patches, one common approach is to use 'git > format-patch' and/or

[Qemu-devel] [PATCH v1 0/8] various gitdm and mailmap updates

Hi, With another release out of the door and KVM Forum approaching it is a good time to clean up our gitdm stats. As usual updates for academic institutions and individual contributors involve a bit of guess work so I have CC'd those affected for their confirmation. There is also a large amount

Re: [Qemu-devel] [PATCH 0/4] docs: add docs about use of automatic cleanup functions

On Wed, Aug 28, 2019 at 01:30:15PM +0100, Alex Bennée wrote: > > Marc-André Lureau writes: > > > Hi > > > > On Fri, Aug 23, 2019 at 8:41 PM Daniel P. Berrangé > > wrote: > >> > >> This is ostensibly about adding docs for the g_autofree/g_autoptr > >> macros. As part of doing that, however,

Re: [Qemu-devel] [PATCH 1/4] docs: convert CODING_STYLE and HACKING to markdown syntax

On Wed, Aug 28, 2019 at 01:25:28PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > Signed-off-by: Daniel P. Berrangé > > Reviewed-by: Alex Bennée > > > diff --git a/README b/README > > index 441c33eb2f..374b8f1486 100644 > > --- a/README > > +++ b/README > > @@ -60,7 +60,7 @@

Re: [Qemu-devel] [PATCH v4 0/3] qcow2: add zstd cluster compression

Patchew URL: https://patchew.org/QEMU/20190828125654.10544-1-dplotni...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190828125654.10544-1-dplotni...@virtuozzo.com Type: series Subject: [Qemu-devel] [PATCH v4

[Qemu-devel] [PATCH v1 5/8] mailmap: Add many entries to improve 'git shortlog' statistics

From: Philippe Mathieu-Daudé All of these emails have a least 1 commit with utf8/latin1 encoding issue, or one with no author name. When there are multiple commits, keep the author name the most used. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190822230916.576-4-phi...@redhat.com>

[Qemu-devel] [PATCH v4 0/3] qcow2: add zstd cluster compression

v4: * remove not feasible switch case [Vladimir] * add sanity checks to zstd decompresssion [Vladimir] * store zstd compressed length in big endian [Max, Kevin] v3: * relax the compression type setting requirement when the compression type is not zlib [Eric, Kevin] * add compression type values

[Qemu-devel] [PATCH v4 2/3] qcow2: rework the cluster compression routine

The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 78 +++ 1 file changed, 64 insertions(+), 14

[Qemu-devel] [PATCH v4 3/3] qcow2: add zstd cluster compression

zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, at the moment, has been the only compression method available. The performance test results: Test compresses and

Re: [Qemu-devel] [PATCH 1/1] protocol: Add NBD_CMD_FLAG_FAST_ZERO

On 8/28/19 4:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hence, it is desirable to have a way for clients to specify that a >> particular write zero request is being attempted for a fast wipe, and >> get an immediate failure if the zero request would otherwise take the >> same time as a write.

Re: [Qemu-devel] [PATCH v1 5/8] mailmap: Add many entries to improve 'git shortlog' statistics

28.08.2019. 14.23, "Alex Bennée" је написао/ла: > > From: Philippe Mathieu-Daudé > > All of these emails have a least 1 commit with utf8/latin1 encoding > issue, or one with no author name. > When there are multiple commits, keep the author name the most used. > > Signed-off-by: Philippe

[Qemu-devel] [PATCH v1 0/2] Add live migration support in the PVRDMA device

This series enables the migration of various GIDs used by the device. This is in addition to the successful migration of PCI and MSIX states as well as various DMA addresses and ring page information. We have a setup having two hosts and two VMs running atop them. Migrations are

[Qemu-devel] [PATCH v1 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

Map to DSR only when there is no mapping done already i.e., when dev->dsr_info.dsr is NULL. This allows the rest of mappings and ring inits to be done by calling load_dsr() when DSR has already been mapped to, somewhere else. Move free_dsr() out of load_dsr() and call it before the latter as and

[Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

vmstate_pvrdma describes the PCI and MSIX states as well as the dma address for dsr and the gid table of device. vmstate_pvrdma_gids describes each gid in the gid table. pvrdma_post_save() does the job of unregistering gid entries from the backend device in the source host. pvrdma_post_load()

Re: [Qemu-devel] [PATCH 2/4] docs: merge HACKING.md contents into CODING_STYLE.md

On Wed, Aug 28, 2019 at 04:06:20PM +0100, Alex Bennée wrote: > > Eric Blake writes: > > > On 8/23/19 11:39 AM, Daniel P. Berrangé wrote: > >> The split of information between the two docs is rather arbitary and > >> unclear. It is simpler for contributors if all the information is in > >> one

Re: [Qemu-devel] [PATCH 1/2] build-sys: build ui-spice-app as a module

Marc-André Lureau writes: > This reverts commit 45db1ac157 ("modules-test: ui-spice-app is not > built as module") and fixes commit d8aec9d9f1 ("display: add -display > spice-app launching a Spice client"). > > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée Tested-by: Alex Bennée

Re: [Qemu-devel] [Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

On 27/08/2019 22:42, John Snow wrote: > > > On 8/23/19 11:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> 16.08.2019 4:01, John Snow wrote: >>> >>> >>> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: To synchronize the time when QEMU is running longer under the Valgrind, increase the

Re: [Qemu-devel] [PATCH v9 03/13] block/backup: introduce BlockCopyState

On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "block-copy", including separate > state structure and function renaming. This is needed to share it with > backup-top filter driver in further commits. > > Notes: > > 1. As BlockCopyState keeps own

Re: [Qemu-devel] [PATCH v1 1/8] contrib/gitdm: filetype interface is not in order, fix

28.08.2019. 14.09, "Alex Bennée" је написао/ла: > > From: Markus Armbruster > > gitm prints the rather cryptic message "interface not found, appended > to the last order". This is because filetypes.txt has filetype > interface, but neglects to mention it in order. Fix that. > > Fixes:

Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array

On 28/08/2019 15.48, Christian Borntraeger wrote: > > > On 28.08.19 15:47, Cornelia Huck wrote: >> On Wed, 28 Aug 2019 15:42:37 +0200 >> Thomas Huth wrote: >> >>> On 28/08/2019 15.27, Christian Borntraeger wrote: On 28.08.19 14:33, Thomas Huth wrote: > We're clearing the BSS in

Re: [Qemu-devel] [PATCH 0/5] Add NBD fast zero support to qemu client and server

On 8/28/19 8:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2019 17:37, Eric Blake wrote: >> See the cross-post cover letter for more details: >> https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html >> >> Based-on:

Re: [Qemu-devel] [PATCH v9 02/13] block/backup: split shareable copying part from backup_do_cow

On 28.08.19 16:27, Vladimir Sementsov-Ogievskiy wrote: > 28.08.2019 17:22, Max Reitz wrote: >> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >>> Split copying logic which will be shared with backup-top filter. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>

Re: [Qemu-devel] [PATCH v1 0/8] various gitdm and mailmap updates

Alex Bennée writes: > Hi, > > With another release out of the door and KVM Forum approaching it is a > good time to clean up our gitdm stats. As usual updates for academic > institutions and individual contributors involve a bit of guess work > so I have CC'd those affected for their

  1   2   3   4   >