[Qemu-devel] [PATCH v2 03/28] s390x/tcg: MVCL: Detect destructive overlaps

2019-09-06 Thread David Hildenbrand
We'll have to zero-out unused bit positions, so amke sure to write the addresses back. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 09/28] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time

2019-09-06 Thread David Hildenbrand
... and indicate cc=3 in case there is work remaining. Keep unicode padding simple. While reworking, properly wrap the addresses. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 54 ++- 1 file changed, 31 insertions(+), 23 deletions(-) diff

[Qemu-devel] [PATCH v2 10/28] s390x/tcg: MVCS/MVCP: Check for special operation exceptions

2019-09-06 Thread David Hildenbrand
Let's perform the documented checks. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 12 1 file changed, 12 insertions(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 6d8ebd18fa..041d01d63d 100644 --- a/target/s390x/mem_helper.c +++

[Qemu-devel] [PATCH v2 02/28] s390x/tcg: MVCL: Zero out unused bits of address

2019-09-06 Thread David Hildenbrand
We have to zero out unused bits in 24 and 31-bit addressing mode. Provide a new helper. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

2019-09-06 Thread Brad Campbell
On 2/9/19 6:23 pm, Brad Campbell wrote: Here is the holdup : 11725@1567416625.003504:qxl_ring_command_check 0 native 11725@1567416625.102653:qxl_io_write 0 native addr=0 (QXL_IO_NOTIFY_CMD) val=0 size=1 async=0 ~100ms delay prior to each logged QXL_IO_NOTIFY_CMD on the AMD box which

Re: [Qemu-devel] [PATCH] Check correct register for clock source

2019-09-06 Thread Cédric Le Goater
On 06/09/2019 03:16, Joel Stanley wrote: > On Fri, 6 Sep 2019 at 01:10, Amithash Prasad wrote: >> >> When WDT_RESTART is written, the data is not the contents >> of the WDT_CTRL register. Hence ensure we are looking at >> WDT_CTRL to check if bit WDT_CTRL_1MHZ_CLK is set or not. >> >>

[Qemu-devel] [PATCH v18 1/6] hw/arm/virt: Introduce RAS platform version and RAS machine option

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng Support RAS Virtualization feature since version 4.2, disable it by default in the old versions. Also add a machine option which allows user to enable it explicitly. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- hw/arm/virt.c | 33

[Qemu-devel] [PATCH v18 5/6] target-arm: kvm64: inject synchronous External Abort

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng Introduce kvm_inject_arm_sea() function in which we will setup the type of exception and the syndrome information in order to inject a virtual synchronous external abort. When switching to guest, it will jump to the synchronous external abort vector table entry. The

[Qemu-devel] [PATCH v18 2/6] docs: APEI GHES generation and CPER record description

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- docs/specs/acpi_hest_ghes.txt | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 docs/specs/acpi_hest_ghes.txt diff --git

[Qemu-devel] [PATCH v2 07/28] s390x/tcg: MVPG: Check for specification exceptions

2019-09-06 Thread David Hildenbrand
Perform the checks documented in the PoP. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 3c23c403cd..a763482ae0 100644 --- a/target/s390x/mem_helper.c +++

[Qemu-devel] [PATCH v2 12/28] s390x/tcg: MVST: Check for specification exceptions

2019-09-06 Thread David Hildenbrand
Bit position 32-55 of general register 0 must be zero. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index de5e69b500..afcd452a00 100644 --- a/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the length

2019-09-06 Thread David Hildenbrand
... and don't perform any move in case the length is zero. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 041d01d63d..de5e69b500 100644 ---

[Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-06 Thread David Hildenbrand
Replace fast_memmove() variants by access_memmove() variants, that first try to probe access to all affected pages (maximum is two pages). In MVCOS, simply always call access_memmove_as() and drop the TODO about LAP. LAP is already handled in the MMU. Get rid of adj_len_to_page(), which is now

[Qemu-devel] [PATCH v2 22/28] s390x/tcg: NC: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 88ff6c21ed..49b4879859

Re: [Qemu-devel] [PATCH v6 1/4] block: Add zoned device model property

2019-09-06 Thread Stefano Garzarella
On Wed, Sep 04, 2019 at 05:00:57PM -0400, Dmitry Fomichev wrote: > This commit adds Zoned Device Model (as defined in T10 ZBC and > T13 ZAC standards) as a block driver property, along with some > useful access functions. > > A new backend driver permission, BLK_PERM_SUPPORT_HM_ZONED, is also >

[Qemu-devel] [PATCH v2 15/28] s390x/tcg: Fault-safe memset

2019-09-06 Thread David Hildenbrand
Replace fast_memset() by access_memset(), that first tries to probe access to all affected pages (maximum is two). We'll use the same mechanism for other types of accesses soon. Only in very rare cases (especially TLB_NOTDIRTY), we'll have to fallback to ld/st helpers. Signed-off-by: David

[Qemu-devel] [PATCH v18 0/6] Add ARMv8 RAS virtualization support in QEMU

2019-09-06 Thread Xiang Zheng
In the ARMv8 platform, the CPU error types are synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, sometimes it's better for guest to perform the recovery, because host does not know the detailed information of guest. For example, if an exception happens in a

[Qemu-devel] [PATCH v4 0/6] Add the STM32F405 and Netduino Plus 2 machine

2019-09-06 Thread Alistair Francis
Now that the Arm-M4 CPU has been added to QEMU we can add the Netduino Plus 2 machine. This is very similar to the STM32F205 and Netduino 2 SoC and machine. v4: - Rebase on master v3: - Remove custom reset handler - Add init-entry and init-sp properties - Rebase on master (including Kconfig

[Qemu-devel] [PATCH v4 1/6] armv7m: Allow entry information to be returned

2019-09-06 Thread Alistair Francis
Allow the kernel's entry point information to be returned when loading a kernel. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/arm/armv7m.c | 4 +++- include/hw/arm/boot.h | 4 +++- 2 files changed, 6 insertions(+), 2

[Qemu-devel] [PATCH v4 4/6] hw/misc: Add the STM32F4xx EXTI device

2019-09-06 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + hw/misc/Kconfig | 3 + hw/misc/Makefile.objs| 1 + hw/misc/stm32f4xx_exti.c | 187 +++ hw/misc/trace-events |

[Qemu-devel] [PATCH v4 3/6] hw/misc: Add the STM32F4xx Sysconfig device

2019-09-06 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- default-configs/arm-softmmu.mak| 1 + hw/arm/Kconfig | 9 ++ hw/misc/Kconfig| 3 + hw/misc/Makefile.objs | 1 + hw/misc/stm32f4xx_syscfg.c | 168

[Qemu-devel] [PATCH v4 2/6] target/arm: Allow setting M mode entry and sp

2019-09-06 Thread Alistair Francis
Add M mode initial entry PC and SP properties. Signed-off-by: Alistair Francis --- target/arm/cpu.c | 52 +++- target/arm/cpu.h | 3 +++ 2 files changed, 50 insertions(+), 5 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index

[Qemu-devel] [PATCH v4 5/6] hw/arm: Add the STM32F4xx SoC

2019-09-06 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- MAINTAINERS| 8 + hw/arm/Kconfig | 3 + hw/arm/Makefile.objs | 1 + hw/arm/stm32f405_soc.c | 301 + include/hw/arm/stm32f405_soc.h | 73

[Qemu-devel] [PATCH v4 6/6] hw/arm: Add the Netduino Plus 2

2019-09-06 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS| 6 + hw/arm/Kconfig | 3 +++ hw/arm/Makefile.objs | 1 + hw/arm/netduinoplus2.c | 58 ++ 4 files changed, 68 insertions(+) create mode 100644 hw/arm/netduinoplus2.c diff --git

Re: [Qemu-devel] [PATCH v4 0/6] Add the STM32F405 and Netduino Plus 2 machine

2019-09-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1567750222.git.alist...@alistair23.me/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4 0/6] Add the STM32F405 and Netduino Plus 2 machine Message-id:

Re: [Qemu-devel] [PATCH v5 13/17] target/arm: Split out arm_mmu_idx_el

2019-09-06 Thread Philippe Mathieu-Daudé
On 8/20/19 11:07 PM, Richard Henderson wrote: > Avoid calling arm_current_el() twice. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/internals.h | 9 + > target/arm/helper.c| 12 +++- > 2 files changed, 16 insertions(+), 5

[Qemu-devel] [PATCH v2 00/28] s390x/tcg: mem_helper: Fault-safe handling

2019-09-06 Thread David Hildenbrand
This is the successor of "[PATCH v1 0/4] s390x/tcg: MOVE (MVC): Fault-safe handling" This series fixes a bunch of issues related to some mem helpers and makes sure that they are fault-safe, meaning no system state is modified in case a fault is triggered. I can spot tons of other

[Qemu-devel] [PATCH v2 05/28] s390x/tcg: MVC: Increment the length once

2019-09-06 Thread David Hildenbrand
Let's increment the length once. While at it, cleanup the comment. The memset() example is given as a programming note in the PoP, so drop the description. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 20 1 file changed,

[Qemu-devel] [PATCH v2 01/28] s390x/tcg: Reset exception_index to -1 instead of 0

2019-09-06 Thread David Hildenbrand
We use the marker "-1" for "no exception". s390_cpu_do_interrupt() might get confused by that. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index

[Qemu-devel] [PATCH v2 13/28] s390x/tcg: MVST: Fix storing back the addresses to registers

2019-09-06 Thread David Hildenbrand
24 and 31-bit address space handling is wrong when it comes to storing back the addresses to the register. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 20 target/s390x/translate.c

[Qemu-devel] [PATCH v2 23/28] s390x/tcg: MVCIN: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Calculate the accessed range upfront - src is accessed right-to-left. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap()

2019-09-06 Thread David Hildenbrand
Let's use the new helper, that also detects destructive overlaps when wrapping. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 2bc2cd09c1..3c23c403cd

[Qemu-devel] [PATCH v2 27/28] s390x/tcg: MVO: Fault-safe handling

2019-09-06 Thread David Hildenbrand
Each operand can have a maximum length of 16. Make sure to prepare all reads/writes before writing. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 26/28] s390x/tcg: MVST: Fault-safe handling

2019-09-06 Thread David Hildenbrand
Access at most single pages and document why. Using the access helpers might over-indicate watchpoints within the same page, I guess we can live with that. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 23 --- 1 file changed, 16 insertions(+), 7

[Qemu-devel] [PATCH v2 25/28] s390x/tcg: MVZ: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 5e38b2c4d8..4c67c6f37e

[Qemu-devel] [PATCH v18 3/6] ACPI: Add APEI GHES table generation support

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng This patch implements APEI GHES Table generation via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel mainly wants userspace

[Qemu-devel] [PATCH v2 08/28] s390x/tcg: MVPG: Properly wrap the addresses

2019-09-06 Thread David Hildenbrand
We have to mask of any unused bits. While at it, document what exactly is missing. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index

[Qemu-devel] [PATCH v2 18/28] s390x/tcg: MVC: Fault-safe handling on destructive overlaps

2019-09-06 Thread David Hildenbrand
The last remaining bit for MVC is handling destructive overlaps in a fault-safe way. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index

[Qemu-devel] [PATCH v2 17/28] s390x/tcg: MVCS/MVCP: Use access_memmove_idx()

2019-09-06 Thread David Hildenbrand
As we are moving between address spaces, we can use access_memmove_idx() without checking for destructive overlaps (especially of real storage locations): "Each storage operand is processed left to right. The storage-operand-consistency rules are the same as for MOVE (MVC), except that

[Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0366cbc753..ff57fec8de

[Qemu-devel] [PATCH v2 21/28] s390x/tcg: XC: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. While at it, increment the length once. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-06 Thread Philippe Mathieu-Daudé
On 9/2/19 3:26 AM, Tony Nguyen wrote: > Existing read rejecting validator was mistakenly cleared. > > Reads dispatched to io_mem_notdirty then segfaults as there is no read > handler. > > Signed-off-by: Tony Nguyen > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Qemu-devel] [PATCH v3] ui: add an embedded Barrier client

2019-09-06 Thread Laurent Vivier
This allows to receive mouse and keyboard events from a Barrier server. This is enabled by adding the following parameter on the command line ... -object input-barrier,id=$id,name=$name ... Where $name is the name declared in the screens section of barrier.conf The barrier server

Re: [Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-09-06 Thread Chao Gao
On Thu, Aug 29, 2019 at 12:21:11PM +0200, Roger Pau Monné wrote: >On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote: >> Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's >> perspective, assigned devices cannot be reset. But some devices rely on PCI >> reset to

[Qemu-devel] [PATCH v2 04/28] s390x/tcg: MVCL: Process max 2k bytes at a time

2019-09-06 Thread David Hildenbrand
Process max 2k bytes at a time, writing back registers between the accesses. The instruction is interruptible. "For operands longer than 2K bytes, access exceptions are not recognized for locations more than 2K bytes beyond the current location being processed." MVCL handling is quite

[Qemu-devel] [PATCH v2 19/28] s390x/tcg: MVCLU: Fault-safe handling

2019-09-06 Thread David Hildenbrand
The last remaining bit is padding with two bytes. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index f636f3a011..0366cbc753 100644 ---

[Qemu-devel] [PATCH v2 14/28] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY

2019-09-06 Thread David Hildenbrand
Although we basically ignore the index all the time for CONFIG_USER_ONLY, let's simply skip all the checks and always return MMU_USER_IDX in cpu_mmu_index() and get_mem_index(). Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 4 target/s390x/translate.c | 4 2 files

[Qemu-devel] [PATCH v2 24/28] s390x/tcg: MVN: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index ba8a657e18..5e38b2c4d8

[Qemu-devel] [PATCH v2 28/28] tests/tcg: target/s390x: Test MVO

2019-09-06 Thread David Hildenbrand
Let's add the simple test based on the example from the PoP. Signed-off-by: David Hildenbrand --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/mvo.c | 25 + 2 files changed, 26 insertions(+) create mode 100644 tests/tcg/s390x/mvo.c diff --git

[Qemu-devel] [PATCH v18 6/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fills this PA to guest APEI GHES memory, then notifies guest according to the SIGBUS type. If guest accesses the poisoned memory, it generates

[Qemu-devel] [PATCH v18 4/6] KVM: Move hwpoison page related functions into include/sysemu/kvm_int.h

2019-09-06 Thread Xiang Zheng
From: Dongjiu Geng kvm_hwpoison_page_add() and kvm_unpoison_all() will both be used by X86 and ARM platforms, so moving them into "include/sysemu/kvm_int.h" to avoid duplicate code. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- accel/kvm/kvm-all.c | 33

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-06 Thread Alex Bennée
Libo Zhou writes: > Hi Alex, > > > I just need to log the registers and memory after the program finishes > its execution. Is it possible to add this functionality myself? You'll need to set some sort of breakpoint on the last instruction so gdb can inspect things before the program is

Re: [Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-09-06 Thread Paul Durrant
> -Original Message- > From: Chao Gao > Sent: 06 September 2019 10:01 > To: Roger Pau Monne > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano Stabellini > ; Anthony Perard ; Paul > Durrant > ; Jan Beulich > Subject: Re: [RFC Patch] xen/pt: Emulate FLR capability > >

Re: [Qemu-devel] [EXTERNAL][PATCH for 4.2 v4 12/12] linux-user: Add support for semtimedop() syscall

2019-09-06 Thread Laurent Vivier
Le 31/07/2019 à 20:22, Aleksandar Markovic a écrit : >> From: Aleksandar Rikalo >> >> Add support for semtimedop() emulation. It is based on invocation >> of safe_semtimedop(). > > Hi, Laurent, > > Aleksandar R. is considering submitting this part too: > > diff --git a/linux-user/syscall.c

Re: [Qemu-devel] [PATCH v6 3/8] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FIOGETOWN and FIOSETOWN ioctls have platform-specific definitions, > hence non-standard definition in QEMU too. > > Other than that, they both have a single integer argument, and their > functionality is

Re: [Qemu-devel] [PATCH v6 5/8] linux-user: Add support for FDMSGON and FDMSGOFF ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDMSGON and FDMSGOFF switch informational messages of floppy drives > on and off. > > Signed-off-by: Aleksandar Markovic > Reviewed-by: Laurent Vivier > --- > linux-user/ioctls.h | 2 ++ >

Re: [Qemu-devel] [PATCH v6 7/8] linux-user: Add support for FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling > formatting of a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h| 3 +++ >

Re: [Qemu-devel] [PATCH] hw/arm/raspi: avoid reparenting the sd card during qbus tree reset

2019-09-06 Thread Peter Maydell
On Wed, 4 Sep 2019 at 17:23, Damien Hedde wrote: > > In the raspi machine, the sd card can be on several sd bus (in reality > there is one bus but several controllers). It is initially created in > the "sd-bus" child in the gpio peripheral. Then is moved (parent bus > changes) during machine

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-09-06 Thread Geert Uytterhoeven
Hi Bartosz, On Fri, Jul 12, 2019 at 11:27 AM Bartosz Golaszewski wrote: > wt., 9 lip 2019 o 17:59 Geert Uytterhoeven napisał(a): > > On Tue, Jul 9, 2019 at 4:59 PM Bartosz Golaszewski > > wrote: > > > pon., 8 lip 2019 o 12:24 Geert Uytterhoeven > > > napisał(a): > > > > On Mon, Jul 8, 2019

[Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

2019-09-06 Thread Thomas Huth
When running "make check -j8" or something similar, the iotests are running in parallel with the other tests. So when they are printing out "Passed all xx tests" or a similar status message at the end, it might not be quite clear that this message belongs to the iotests, since the output might be

Re: [Qemu-devel] [PATCH v2 04/13] qcrypto-luks: don't overwrite cipher_mode in header

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:54PM +0300, Maxim Levitsky wrote: > This way we can store the header we loaded, which > will be used in key management code > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2 03/13] qcrypto-luks: rename some fields in QCryptoBlockLUKSHeader

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:53PM +0300, Maxim Levitsky wrote: > * key_bytes -> master_key_len > * payload_offset = payload_offset_sector (to emphasise that this isn't byte > offset) > * key_offset -> key_offset_sector - same as above for luks slots > > Signed-off-by: Maxim Levitsky > --- >

[Qemu-devel] [PATCH v3 3/4] target/arm: remove run time semihosting checks

2019-09-06 Thread Alex Bennée
Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups v5 - move CONFIG_TCG ifdefs

[Qemu-devel] [PATCH v3 2/4] target/arm: handle A-profile semihosting at translate time

2019-09-06 Thread Alex Bennée
As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree, merge T32 & A32 commits - dropped r-b due to changes --- target/arm/translate.c | 19

[Qemu-devel] [PATCH v3 4/4] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2019-09-06 Thread Alex Bennée
From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/atomic_template.h

[Qemu-devel] [PATCH v3 0/4] semihosting fixes

2019-09-06 Thread Alex Bennée
Hi Peter, I've re-based and re-tested on the post-decodetree changes. In the end I merged the A32/T32 patches and dropped Richard's r-b as the code has changed a bit. Alex Bennée (3): target/arm: handle M-profile semihosting at translate time target/arm: handle A-profile semihosting at

[Qemu-devel] [PATCH v3 1/4] target/arm: handle M-profile semihosting at translate time

2019-09-06 Thread Alex Bennée
We do this for other semihosting calls so we might as well do it for M-profile as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree --- target/arm/m_helper.c | 18 ++

Re: [Qemu-devel] [PATCH v2 08/13] qcrypto-luks: extract store and load header

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:58PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 166 +++- > 1 file changed, 102 insertions(+), 64 deletions(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-06 Thread Eric Blake
On 9/6/19 3:28 AM, Philippe Mathieu-Daudé wrote: > On 9/2/19 3:26 AM, Tony Nguyen wrote: >> Existing read rejecting validator was mistakenly cleared. >> >> Reads dispatched to io_mem_notdirty then segfaults as there is no read >> handler. >> >> Signed-off-by: Tony Nguyen >> --- >> exec.c | 2 +-

Re: [Qemu-devel] [PULL 0/4] Docs patches

2019-09-06 Thread Eric Blake
On 9/6/19 4:24 AM, Daniel P. Berrangé wrote: >> >> I'm going to apply this, but something I thought of looking at >> the diffstat: should some or all of this be in the docs/devel >> manual rather than free-floating rst files in the root directory? > > The answer really hinges on whether moving

Re: [Qemu-devel] [PATCH v2 10/13] qcrypto-luks: refactoring: extract store key function

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:51:00PM +0300, Maxim Levitsky wrote: > This function will be used later to store > new keys to the luks metadata > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 310 ++-- > 1 file changed, 184 insertions(+), 126

Re: [Qemu-devel] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

2019-09-06 Thread Brad Campbell
On 6/9/19 16:49, Brad Campbell wrote: On 2/9/19 6:23 pm, Brad Campbell wrote: Here is the holdup : 11725@1567416625.003504:qxl_ring_command_check 0 native 11725@1567416625.102653:qxl_io_write 0 native addr=0 (QXL_IO_NOTIFY_CMD) val=0 size=1 async=0 ~100ms delay prior to each logged

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-06 Thread Eric Blake
On 9/6/19 8:24 AM, Philippe Mathieu-Daudé wrote: static const MemoryRegionOps notdirty_mem_ops = { .write = notdirty_mem_write, -.valid.accepts = notdirty_mem_accepts, .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 1,

Re: [Qemu-devel] [PATCH 02/10] qcrypto-luks: extend the create options for upcoming encryption key management

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:00PM +0300, Maxim Levitsky wrote: > Now you can specify which slot to put the encryption key to > Plus add 'active' option which will let user erase the key secret > instead of adding it. > Check that it is true for creation > > Signed-off-by: Maxim Levitsky > ---

Re: [Qemu-devel] [PATCH 05/10] block/crypto: implement the encryption key management

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:03PM +0300, Maxim Levitsky wrote: > This implements the encryption key management > using the generic code in qcrypto layer > (currently only for qemu-img amend) > > This code adds another 'write_func' because the initialization > write_func works directly on the

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-06 Thread Peter Maydell
On Wed, 4 Sep 2019 at 03:41, Peter Xu wrote: > On Tue, Sep 03, 2019 at 05:50:56PM +0100, Peter Maydell wrote: > > Do you have a backtrace of QEMU from the segfault? I'm having trouble > > thinking of what the situation is when we'd try to invoke the > > read handler on io_mem_notdirty... > > I've

Re: [Qemu-devel] [PATCH 08/10] block/crypto: implement blockdev-amend

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:06PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/crypto.c | 86 +--- > qapi/block-core.json | 4 +-- > 2 files changed, 68 insertions(+), 22 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH v3 2/4] target/arm: handle A-profile semihosting at translate time

2019-09-06 Thread Peter Maydell
On Fri, 6 Sep 2019 at 13:47, Alex Bennée wrote: > > As for the other semihosting calls we can resolve this at translate > time. > > Signed-off-by: Alex Bennée > > --- > v2 > - update for change to gen_exception_internal_insn API > v3 > - update for decode tree, merge T32 & A32 commits > -

Re: [Qemu-devel] [PULL 4/9] block: workaround for unaligned byte range in fallocate()

2019-09-06 Thread Andrey Shinkevich
Many thanks Andrey On 05/09/2019 21:21, Eric Blake wrote: > From: Andrey Shinkevich > > Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' > and use better error handling for file systems that do not support > fallocate() for an unaligned byte range. Allow falling back

Re: [Qemu-devel] [PATCH v3 2/4] target/arm: handle A-profile semihosting at translate time

2019-09-06 Thread Alex Bennée
Peter Maydell writes: > On Fri, 6 Sep 2019 at 13:47, Alex Bennée wrote: >> >> As for the other semihosting calls we can resolve this at translate >> time. >> >> Signed-off-by: Alex Bennée >> >> --- >> v2 >> - update for change to gen_exception_internal_insn API >> v3 >> - update for

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-06 Thread Philippe Mathieu-Daudé
On 9/6/19 3:08 PM, Eric Blake wrote: > On 9/6/19 3:28 AM, Philippe Mathieu-Daudé wrote: >> On 9/2/19 3:26 AM, Tony Nguyen wrote: >>> Existing read rejecting validator was mistakenly cleared. >>> >>> Reads dispatched to io_mem_notdirty then segfaults as there is no read >>> handler. >>> >>>

Re: [Qemu-devel] [PATCH v3 2/4] target/arm: handle A-profile semihosting at translate time

2019-09-06 Thread Peter Maydell
On Fri, 6 Sep 2019 at 14:16, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Fri, 6 Sep 2019 at 13:47, Alex Bennée wrote: > > > > > Doesn't this accidentally enable semihosting via SVC for > > M-profile ? > > We must have done that before then. No, we didn't do it before, because we

Re: [Qemu-devel] [PATCH 02/10] qcrypto-luks: extend the create options for upcoming encryption key management

2019-09-06 Thread Maxim Levitsky
On Fri, 2019-09-06 at 14:49 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 30, 2019 at 11:56:00PM +0300, Maxim Levitsky wrote: > > Now you can specify which slot to put the encryption key to > > Plus add 'active' option which will let user erase the key secret > > instead of adding it. > > Check

Re: [Qemu-devel] [PATCH 10/10] iotests : add tests for encryption key management

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:08PM +0300, Maxim Levitsky wrote: > Note that currently I add tests 300-302, which are > placeholders to ease the rebase. In final version > of these patches I will update these. > > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/087.out | 6 +- >

[Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery

2019-09-06 Thread Peter Xu
We've got max-postcopy-bandwidth parameter but it's not applied correctly after a postcopy recovery so the recovered migration stream will still eat the whole net bandwidth. Fix that up. Reported-by: Xiaohui Li Signed-off-by: Peter Xu --- migration/migration.c | 3 ++- 1 file changed, 2

Re: [Qemu-devel] [PATCH v2 09/13] qcrypto-block: extract check and parse header

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:59PM +0300, Maxim Levitsky wrote: > This is just to make qcrypto_block_luks_open more > reasonable in size. > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 254 +--- > 1 file changed, 146 insertions(+), 108

Re: [Qemu-devel] [PATCH v2 11/13] qcrypto-luks: refactoring: simplify the math used for keyslot locations

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:51:01PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 64 + > 1 file changed, 41 insertions(+), 23 deletions(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index

Re: [Qemu-devel] [PATCH v2 13/13] qcrypto-luks: implement more rigorous header checking

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:51:03PM +0300, Maxim Levitsky wrote: > Check that keyslots don't overlap with the data, > and check that keyslots don't overlap with each other. > (this is done using naive O(n^2) nested loops, > but since there are just 8 keyslots, this doesn't really matter. > >

Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery

2019-09-06 Thread Juan Quintela
Peter Xu wrote: > We've got max-postcopy-bandwidth parameter but it's not applied > correctly after a postcopy recovery so the recovered migration stream > will still eat the whole net bandwidth. Fix that up. > > Reported-by: Xiaohui Li > Signed-off-by: Peter Xu > --- > migration/migration.c

Re: [Qemu-devel] [PATCH 01/10] qcrypto: add suport for amend options

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:55:59PM +0300, Maxim Levitsky wrote: > This adds the qcrypto_amend_options and corresponding > crypto driver callbacks for the for encrypted > key managedment > > Signed-off-by: Maxim Levitsky > --- > crypto/block.c | 31 +++ >

Re: [Qemu-devel] [PATCH 03/10] qcrypto-luks: implement the encryption key management

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:01PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 366 +++- > 1 file changed, 364 insertions(+), 2 deletions(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index

Re: [Qemu-devel] [PATCH 04/10] block: amend: add 'force' option

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:02PM +0300, Maxim Levitsky wrote: This could do with some text to explain what this will be used for. > Signed-off-by: Maxim Levitsky > --- > block.c | 4 +++- > block/qcow2.c | 1 + > include/block/block.h | 1 + >

Re: [Qemu-devel] [PATCH 06/10] qcow2: implement crypto amend options

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:04PM +0300, Maxim Levitsky wrote: > --- > block/qcow2.c | 79 --- > 1 file changed, 63 insertions(+), 16 deletions(-) > > @@ -4888,9 +4899,22 @@ static int qcow2_amend_options(BlockDriverState *bs, > QemuOpts *opts,

Re: [Qemu-devel] [PATCH 09/10] block/qcow2: implement blockdev-amend

2019-09-06 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:56:07PM +0300, Maxim Levitsky wrote: > Currently only for changing crypto parameters > > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c| 71 > qapi/block-core.json | 4 +-- > 2 files changed, 73 insertions(+),

Re: [Qemu-devel] [PATCH 02/10] qcrypto-luks: extend the create options for upcoming encryption key management

2019-09-06 Thread Daniel P . Berrangé
On Fri, Sep 06, 2019 at 04:57:22PM +0300, Maxim Levitsky wrote: > On Fri, 2019-09-06 at 14:49 +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 30, 2019 at 11:56:00PM +0300, Maxim Levitsky wrote: > > > Now you can specify which slot to put the encryption key to > > > Plus add 'active' option which

Re: [Qemu-devel] [PATCH 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Maxim Levitsky
On Fri, 2019-09-06 at 14:00 -0500, Eric Blake wrote: > On 9/6/19 1:55 PM, Maxim Levitsky wrote: > > > > > +/* > > > > + * qcow2_co_encrypt() > > > > + * > > > > + * Encrypts a sector size aligned contiguous area > > > > + * > > > > + * @host_cluster_offset - on disk offset of the cluster in which

[Qemu-devel] [RFC 2 PATCH 03/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2019-09-06 Thread Moger, Babu
This is an effort to re-arrange few data structure for better readability. Add X86CPUTopoInfo which will have all the topology informations required to build the cpu topology. There is no functional changes. Signed-off-by: Babu Moger --- hw/i386/pc.c | 40

[Qemu-devel] [RFC 2 PATCH 07/16] hw/386: Add new epyc mode topology decoding functions

2019-09-06 Thread Moger, Babu
These functions add support for building new epyc mode topology given smp details like numa nodes, cores, threads and sockets. Subsequent patches will use these functions to build the topology. The topology details are available in Processor Programming Reference (PPR) for AMD Family 17h Model

[Qemu-devel] [RFC 2 PATCH 04/16] machine: Add SMP Sockets in CpuTopology

2019-09-06 Thread Moger, Babu
Store the smp Sockets in CpuTopology. Socket information is required to build the cpu topology in new epyc mode. Signed-off-by: Babu Moger --- hw/core/machine.c |1 + hw/i386/pc.c|1 + include/hw/boards.h |2 ++ vl.c|1 + 4 files changed, 5

[Qemu-devel] [PATCH 3/3] qemu-iotests: test for bz #1745922

2019-09-06 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/263 | 76 ++ tests/qemu-iotests/263.out | 19 ++ tests/qemu-iotests/group | 1 + 3 files changed, 96 insertions(+) create mode 100755 tests/qemu-iotests/263 create mode 100644

  1   2   3   >