[Qemu-devel] [PATCH RESEND v4 0/2] x86: Enable user wait instructions

2019-09-18 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to

[Qemu-devel] [PATCH RESEND v4 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-09-18 Thread Tao Xu
UMWAIT and TPAUSE instructions use 32bits IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu

[Qemu-devel] [PATCH RESEND v4 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

2019-09-18 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may be executed at any

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

2019-09-18 Thread Kevin Wolf
Am 17.09.2019 um 21:10 hat John Snow geschrieben: > > > On 9/17/19 10:46 AM, Kevin Wolf wrote: > > Am 17.09.2019 um 16:39 hat Eric Blake geschrieben: > >> On 9/17/19 5:20 AM, Greg Kurz wrote: > >>> Ensure that hints are added even if errp is _fatal or _abort. > >>> > >>> Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 1/2] audio: fix buffer-length typo in documentation

2019-09-18 Thread Stefan Hajnoczi
On Tue, Sep 17, 2019 at 09:29:34PM +0200, Zoltán Kővágó wrote: > On 2019-09-11 16:58, Stefan Hajnoczi wrote: > > Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") > > Signed-off-by: Stefan Hajnoczi > > --- > > qemu-options.hx | 4 ++-- > > 1 file changed, 2

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

2019-09-18 Thread Alex Bennée
David Hildenbrand writes: > Let's add the simple test based on the example from the PoP. > > Signed-off-by: David Hildenbrand > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/mvo.c | 25 + > 2 files changed, 26 insertions(+) > create mode

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-18 Thread Jason Wang
On 2019/9/18 上午9:31, Tian, Kevin wrote: From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Tuesday, September 17, 2019 10:54 PM On Tue, 17 Sep 2019 08:48:36 + "Tian, Kevin" wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, September 16, 2019 4:33 PM On

[Qemu-devel] KVM call for 2019-09-24

2019-09-18 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details:

Re: [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float)

2019-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917184109.12564-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float) Message-id:

[Qemu-devel] [PATCH v14 3/7] target/ppc: Handle NMI guest exit

2019-09-18 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI

[Qemu-devel] [PATCH v14 2/7] ppc: spapr: Introduce FWNMI capability

2019-09-18 Thread Aravinda Prasad
Introduce the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. This patch

[Qemu-devel] [PATCH v14 4/7] target/ppc: Build rtas error log upon an MCE

2019-09-18 Thread Aravinda Prasad
Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the guest registered machine

[Qemu-devel] [PATCH v14 1/7] Wrapper function to wait on condition for the main loop mutex

2019-09-18 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

2019-09-18 Thread Adrian Moreno
That way the state can be correctly restored when the device is opened again. This might happen if the backend is restarted. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1738768 Reported-by: Pei Zhang Fixes: 6ab79a20af3a (do not call vhost_net_cleanup() on running net from char user

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Kevin Wolf
Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > From: Pavel Dovgalyuk > > > > > > This patch updates the description of the command lines for using > > > record/replay with

Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093

2019-09-18 Thread Max Reitz
On 17.09.19 16:25, Andrey Shinkevich wrote: > > > On 17/09/2019 12:20, Max Reitz wrote: >> null-aio may not be whitelisted. Skip all test cases that require it. >> >> (And skip the whole test if null-co is not whitelisted.) > This solution has been persisting since v1. Nevertheless, I am still

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-09-18 Thread Peter Krempa
On Wed, Sep 18, 2019 at 10:22:13 +0200, Kevin Wolf wrote: > Am 17.09.2019 um 18:33 hat Eric Blake geschrieben: > > On 9/17/19 10:49 AM, Peter Krempa wrote: > > > savevm was buggy as it considered all monitor owned block device nodes > > > for snapshot. With introduction of -blockdev the common

[Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-18 Thread Kevin Wolf
Running iotests is not required to build QEMU, so we can have stricter version requirements for Python here and can make use of new features and drop compatibility code earlier. This makes qemu-iotests skip all Python tests if a Python version before 3.5 is used for the build. Suggested-by:

Re: [Qemu-devel] [PULL 3/8] m68k: Add NeXTcube machine

2019-09-18 Thread Thomas Huth
On 16/09/2019 12.48, Peter Maydell wrote: > On Sat, 7 Sep 2019 at 16:47, Thomas Huth wrote: >> >> It is still quite incomplete (no SCSI, no floppy emulation, no network, >> etc.), but the firmware already shows up the debug monitor prompt in the >> framebuffer display, so at least the very basics

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

2019-09-18 Thread Cornelia Huck
On Wed, 18 Sep 2019 10:25:15 +0200 David Hildenbrand wrote: > On 16.09.19 15:57, David Hildenbrand wrote: > > This series fixes a bunch of issues related to some mem helpers and makes > > sure that they are fault-safe, meaning no system state is modified in case > > a fault is triggered. > > >

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-18 Thread Jason Wang
On 2019/9/18 上午9:44, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, September 17, 2019 6:36 PM On 2019/9/17 下午4:48, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, September 16, 2019 4:33 PM On 2019/9/16 上午9:51, Tian, Kevin

[Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

2019-09-18 Thread David Gibson
Hi, I'm finding make check-acceptance is currently useless for me as a pre-pull test, because a bunch of the tests are not at all reliable. There are a bunch which I'm still investigating, but for now I'm looking at the MIPS Malta SSH tests. There seem to be at least two problems here. First,

Re: [Qemu-devel] [PATCH v3 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove()

2019-09-18 Thread David Hildenbrand
On 17.09.19 22:20, Richard Henderson wrote: > On 9/16/19 9:57 AM, David Hildenbrand wrote: >> As we are moving between address spaces, we can use access_memmove_idx() >> without checking for destructive overlaps (especially of real storage >> locations): >> "Each storage operand is processed

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

2019-09-18 Thread Pierre Muller
Hi Thomas, I tried to use git format-patch -s below, and change the commit message that appears below: muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s a017dc6d43aaa4ffc7be40ae3adee4086be9cec2^ 0001-Fix-floatx80_invalid_encoding-function-for-m68k-cpu.patch muller@gcc123:~/gnu/qemu/qemu$

[Qemu-devel] [PATCH v14 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-09-18 Thread Aravinda Prasad
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error

Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb

2019-09-18 Thread David Hildenbrand
On 18.09.19 07:26, Richard Henderson wrote: > RFC because this doesn't work, and I don't quite understand why. > The only failing test is {i386,x86_64} pxe-test -- the other > migration tests that use notdirty all pass. > > Note that if you try to reproduce this on x86, you'll likely > have to

Re: [Qemu-devel] [RFC 1/3] exec: Adjust notdirty tracing

2019-09-18 Thread David Hildenbrand
On 18.09.19 07:26, Richard Henderson wrote: > The memory_region_tb_read tracepoint is unreachable, since notdirty > is supposed to apply only to reads. The memory_region_tb_write > tracepoint is mis-named, because notdirty is not only used for TB > invalidation. It is also used for e.g. VGA RAM

Re: [Qemu-devel] [PATCH v3 00/18] ppc/pnv: add XIVE support for KVM guests

2019-09-18 Thread Cédric Le Goater
On 18/09/2019 07:44, David Gibson wrote: > On Tue, Sep 17, 2019 at 01:54:24PM +0200, Cédric Le Goater wrote: >> On 31/07/2019 16:12, Cédric Le Goater wrote: >>> Hello, >>> >>> The QEMU PowerNV machine emulates a baremetal OpenPOWER system and >>> acts as an hypervisor (L0). Supporting emulation of

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

2019-09-18 Thread David Hildenbrand
On 18.09.19 11:26, Cornelia Huck wrote: > On Wed, 18 Sep 2019 10:25:15 +0200 > David Hildenbrand wrote: > >> On 16.09.19 15:57, David Hildenbrand wrote: >>> This series fixes a bunch of issues related to some mem helpers and makes >>> sure that they are fault-safe, meaning no system state is

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

2019-09-18 Thread Thomas Huth
On 17/09/2019 22.04, Pierre Muller wrote: > > Hello, > > I submitted September 12. a bug report about wrong handling of > infinity values for m68k emulator. > > https://bugs.launchpad.net/qemu/+bug/1843651 > > The analysis I made in the bug report is wrong, because > I did not know that

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-18 Thread Thomas Huth
On 17/09/2019 12.03, Philippe Mathieu-Daudé wrote: > On 9/17/19 7:07 AM, Thomas Huth wrote: >> On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: >>> The MC146818 is a Real Time Clock, not a timer. >>> Move it under the hw/rtc/ subdirectory. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >> [...]

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-18 Thread Stefano Garzarella
On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM,

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-18 Thread Tian, Kevin
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:10 PM > > >> > >> Note that the HVA to GPA mapping is not an 1:1 mapping. One HVA > range > >> could be mapped to several GPA ranges. > > This is fine. Currently vfio_dma maintains IOVA->HVA mapping. > > > >

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Kevin Wolf
Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > From: Pavel Dovgalyuk > > This patch updates the description of the command lines for using > record/replay with attached block devices. > > Signed-off-by: Pavel Dovgalyuk > --- > docs/replay.txt | 12 +--- > 1 file changed,

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-18 Thread Stefan Hajnoczi
On Mon, Sep 16, 2019 at 12:41:44PM -0400, John Snow wrote: > On 9/16/19 12:40 PM, Philippe Mathieu-Daudé wrote: > > On 9/16/19 6:36 PM, Eric Blake wrote: > >> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: > >>> While the tracing frawework does not forbid trailing newline in > >> > >> framework

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > > From: Pavel Dovgalyuk > > > > > > > > This patch updates the description of

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Kevin Wolf
Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > > > From:

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-18 Thread Tian, Kevin
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:04 PM > > On 2019/9/18 上午9:31, Tian, Kevin wrote: > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Tuesday, September 17, 2019 10:54 PM > >> > >> On Tue, 17 Sep 2019 08:48:36 + >

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

2019-09-18 Thread Greg Kurz
On Tue, 17 Sep 2019 17:40:11 + Vladimir Sementsov-Ogievskiy wrote: > 17.09.2019 18:37, Greg Kurz wrote: > > On Tue, 17 Sep 2019 13:25:03 + > > Vladimir Sementsov-Ogievskiy wrote: > > > >> 17.09.2019 13:20, Greg Kurz wrote: > >>> Ensure that hints are added even if errp is _fatal or

[Qemu-devel] [PATCH v14 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-18 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the

Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb

2019-09-18 Thread Paolo Bonzini
On 18/09/19 07:26, Richard Henderson wrote: > RFC because this doesn't work, and I don't quite understand why. > The only failing test is {i386,x86_64} pxe-test -- the other > migration tests that use notdirty all pass. > > Note that if you try to reproduce this on x86, you'll likely > have to

[Qemu-devel] [PATCH v14 7/7] ppc: spapr: Activate the FWNMI functionality

2019-09-18 Thread Aravinda Prasad
This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a72a4b1..b6a249f 100644 ---

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-09-18 Thread Kevin Wolf
Am 17.09.2019 um 18:33 hat Eric Blake geschrieben: > On 9/17/19 10:49 AM, Peter Krempa wrote: > > savevm was buggy as it considered all monitor owned block device nodes > > for snapshot. With introduction of -blockdev the common usage made all > > nodes including protocol nodes monitor owned and

Re: [Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

2019-09-18 Thread Adrian Moreno
On 9/17/19 11:40 PM, Michael S. Tsirkin wrote: > On Tue, Sep 17, 2019 at 09:19:01PM +0200, Adrian Moreno wrote: >> That way the state can be correctly restored when the device is opened >> again. This might happen if the backend is restarted. >> >> Buglink:

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-18 Thread Thomas Huth
On 18/09/2019 10.55, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a Python version

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > From: Pavel Dovgalyuk > > > > This patch updates the description of the command lines for using > > record/replay with attached block devices. > > > > Signed-off-by: Pavel Dovgalyuk > > ---

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-18 Thread Stefan Hajnoczi
On Tue, Sep 17, 2019 at 02:25:59PM +0200, Johannes Berg wrote: > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost-user/libvhost-user.c > index f1677da21201..17b7833d1f6b 100644 > --- a/contrib/libvhost-user/libvhost-user.c > +++ b/contrib/libvhost-user/libvhost-user.c > @@

[Qemu-devel] [RESEND PATCH] tests/acceptance: Specify arch for QueryCPUModelExpansion

2019-09-18 Thread David Gibson
At the moment this test runs on whatever the host arch is. But it looks for 'unavailable-features' which is an x86 specific cpu property. Tag it to always use qemu-system-x86_64. Signed-off-by: David Gibson Reviewed-by: Wainer dos Santos Moschetta --- tests/acceptance/cpu_queries.py | 3 +++

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-18 Thread Tian, Kevin
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:10 PM > > On 2019/9/18 上午9:44, Tian, Kevin wrote: > >> From: Jason Wang [mailto:jasow...@redhat.com] > >> Sent: Tuesday, September 17, 2019 6:36 PM > >> > >> On 2019/9/17 下午4:48, Tian, Kevin wrote: >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-09-18 Thread Kevin Wolf
Am 17.09.2019 um 23:48 hat Eduardo Habkost geschrieben: > On Tue, Sep 17, 2019 at 03:57:26PM +0200, Kevin Wolf wrote: > > Am 11.06.2019 um 19:12 hat Eduardo Habkost geschrieben: > > > On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: > > > > On Tue, 11 Jun 2019 at 17:03, Eduardo

[Qemu-devel] [PATCH v14 6/7] migration: Include migration support for machine check handling

2019-09-18 Thread Aravinda Prasad
This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. Signed-off-by: Aravinda Prasad ---

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

2019-09-18 Thread David Hildenbrand
On 16.09.19 15:57, David Hildenbrand wrote: > This series fixes a bunch of issues related to some mem helpers and makes > sure that they are fault-safe, meaning no system state is modified in case > a fault is triggered. > > I can spot tons of other issues with other mem helpers that will have >

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

2019-09-18 Thread Pavel Dovgalyuk
> -Original Message- > From: Alex Bennée [mailto:alex.ben...@linaro.org] > Sent: Tuesday, September 17, 2019 10:02 PM > To: Pavel Dovgalyuk > Cc: qemu-devel@nongnu.org; kw...@redhat.com; peter.mayd...@linaro.org; > crosthwaite.pe...@gmail.com; boost.li...@gmail.com; >

[Qemu-devel] qemu patches

2019-09-18 Thread Ilias
Hi, Your recent patch https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 to the file target/i386/whpx-all.c breaks compilation when WHPX is enabled. Please add

Re: [Qemu-devel] [PATCH v4 02/10] hw/core: create Resettable QOM interface

2019-09-18 Thread David Gibson
On Wed, Sep 11, 2019 at 04:56:13PM +0200, Damien Hedde wrote: > > > On 9/11/19 10:06 AM, David Gibson wrote: > > On Wed, Aug 21, 2019 at 06:33:33PM +0200, Damien Hedde wrote: > >> This commit defines an interface allowing multi-phase reset. This aims > >> to solve a problem of the actual

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format

2019-09-18 Thread Stefan Hajnoczi
On Mon, Sep 16, 2019 at 11:51:19AM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > I'v been confused by trailing newline in trace reports, > so this series aims to fix this, by cleaning current > formats and add a check to catch new one introduced. > > v2: > - Use regex format (easier to

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-18 Thread Max Reitz
On 18.09.19 10:55, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a Python version before

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-18 Thread Kevin Wolf
Am 18.09.2019 um 11:20 hat Max Reitz geschrieben: > On 18.09.19 10:55, Kevin Wolf wrote: > > Running iotests is not required to build QEMU, so we can have stricter > > version requirements for Python here and can make use of new features > > and drop compatibility code earlier. > > > > This makes

Re: [Qemu-devel] [PATCH 2/2] audio: add -audiodev pa, in|out.latency= to documentation

2019-09-18 Thread Stefan Hajnoczi
On Tue, Sep 17, 2019 at 09:47:11PM +0200, Zoltán Kővágó wrote: > On 2019-09-11 16:58, Stefan Hajnoczi wrote: > > The "latency" parameter wasn't covered by the documentation. > > > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Zoltán Kővágó > > --- > > How is this parameter related to

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-18 Thread Johannes Berg
On Wed, 2019-09-18 at 10:39 +0100, Stefan Hajnoczi wrote: > > > vu_check_queue_msg_file(VuDev *dev, VhostUserMsg *vmsg) > > { > > int index = vmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK; > > +bool nofd = vmsg->payload.u64 & VHOST_USER_VRING_NOFD_MASK; > > > > if (index >=

[Qemu-devel] [PATCH 6/8] block: Let format drivers pass @exact

2019-09-18 Thread Max Reitz
When truncating a format node, the @exact parameter is generally handled simply by virtue of the format storing the new size in the image metadata. Such formats do not need to pass on the parameter to their file nodes. There are exceptions, though: - raw and crypto cannot store the image size,

[Qemu-devel] [PATCH 1/8] block: Handle filter truncation like native impl.

2019-09-18 Thread Max Reitz
Make the filter truncation (passing it through to bs->file) a first-class citizen and handle it exactly as if it was the filter driver's native implementation of .bdrv_co_truncate(). I do not see a reason not to, it makes the code a bit shorter, and may be even more correct because this gets us

Re: [Qemu-devel] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-18 Thread Cornelia Huck
On Tue, 17 Sep 2019 14:02:59 +0100 Stefan Hajnoczi wrote: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, and

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-18 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 17.09.2019 um

[Qemu-devel] [PATCH v2 0/3] audio: -audiodev documentation tweaks

2019-09-18 Thread Stefan Hajnoczi
v2: * Added ALSA period-length fix [Zoltán] * Expanded PulseAudio latency documentation [Zoltán] Small fixes to the -audiodev documentation. Stefan Hajnoczi (3): audio: fix buffer-length typo in documentation audio: add -audiodev pa,in|out.latency= to documentation audio: fix ALSA

Re: [Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/18/19 9:16 AM, David Gibson wrote: > Hi, > > I'm finding make check-acceptance is currently useless for me as a > pre-pull test, because a bunch of the tests are not at all reliable. > There are a bunch which I'm still investigating, but for now I'm > looking at the MIPS Malta SSH tests. >

Re: [Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

2019-09-18 Thread David Gibson
On Wed, Sep 18, 2019 at 01:13:29PM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/19 9:16 AM, David Gibson wrote: > > Hi, > > > > I'm finding make check-acceptance is currently useless for me as a > > pre-pull test, because a bunch of the tests are not at all reliable. > > There are a bunch which

[Qemu-devel] [PATCH-for-4.2 v11 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-18 Thread Shameer Kolothum
This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. We are making changes so that MMIO region can be accommodated and board can pass the base address into the aml build function. Also move few MEMORY_* definitions to header so that

[Qemu-devel] [PATCH-for-4.2 v11 02/11] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-09-18 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v11 04/11] hw/arm/virt: Add memory hotplug framework

2019-09-18 Thread Shameer Kolothum
From: Eric Auger This patch adds the memory hot-plug/hot-unplug infrastructure in machvirt. The device memory is not yet exposed to the Guest either through DT or ACPI and hence both cold/hot plug of memory is explicitly disabled for now. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee

[Qemu-devel] [PATCH 5/8] block: Evaluate @exact in protocol drivers

2019-09-18 Thread Max Reitz
We have two protocol drivers that return success when trying to shrink a block device even though they cannot shrink it. This behavior is now only allowed with exact=false, so they should return an error with exact=true. Signed-off-by: Max Reitz --- block/file-posix.c | 8 +++-

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/18/19 9:43 AM, Thomas Huth wrote: > On 17/09/2019 12.03, Philippe Mathieu-Daudé wrote: >> On 9/17/19 7:07 AM, Thomas Huth wrote: >>> On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: The MC146818 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory.

Re: [Qemu-devel] [RESEND PATCH] tests/acceptance: Specify arch for QueryCPUModelExpansion

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/18/19 9:06 AM, David Gibson wrote: > At the moment this test runs on whatever the host arch is. But it looks > for 'unavailable-features' which is an x86 specific cpu property. Tag it > to always use qemu-system-x86_64. > > Signed-off-by: David Gibson > Reviewed-by: Wainer dos Santos

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/18/19 11:29 AM, Kevin Wolf wrote: > Am 18.09.2019 um 11:20 hat Max Reitz geschrieben: >> On 18.09.19 10:55, Kevin Wolf wrote: >>> Running iotests is not required to build QEMU, so we can have stricter >>> version requirements for Python here and can make use of new features >>> and drop

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/17/19 1:40 PM, David Gibson wrote: > On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote: >> On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: >>> On 9/16/19 11:52 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > Hi David, > >

Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices

2019-09-18 Thread Marc-André Lureau
Hi Tomáš On Wed, Sep 18, 2019 at 3:23 PM Tomáš Golembiovský wrote: > > On Mon, Sep 16, 2019 at 04:31:49PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Aug 29, 2019 at 8:06 PM Tomáš Golembiovský > > wrote: > > > > > > Add command for reporting devices on Windows guest. The intent is

[Qemu-devel] [PATCH] target/i386: Fix broken build with WHPX enabled

2019-09-18 Thread Philippe Mathieu-Daudé
The WHPX build is broken since commit 12e9493df92 which removed the "hw/boards.h" where MachineState is declared: $ ./configure \ --enable-hax --enable-whpx $ make x86_64-softmmu/all [...] CC x86_64-softmmu/target/i386/whpx-all.o target/i386/whpx-all.c: In function

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-18 Thread Thomas Huth
On 18/09/2019 00.29, John Snow wrote: > > > On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: [...] >> Finally do we support something except linux for iotests? >> for bash tests _supported_os also used only with "Linux" in 87 tests.. The iotests in the "auto" group are supposed to work

[Qemu-devel] [PATCH 2/8] block/cor: Drop cor_co_truncate()

2019-09-18 Thread Max Reitz
No other filter driver has a .bdrv_co_truncate() implementation, and there is no need to because the general block layer code can handle it just as well. Signed-off-by: Max Reitz --- block/copy-on-read.c | 8 1 file changed, 8 deletions(-) diff --git a/block/copy-on-read.c

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

2019-09-18 Thread Alex Bennée
Pierre Muller writes: > Hi Thomas, > > I tried to use git format-patch -s below, > and change the commit message that appears below: > > > muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s > a017dc6d43aaa4ffc7be40ae3adee4086be9cec2^ >

[Qemu-devel] [PATCH 8/8] Revert "qemu-img: Check post-truncation size"

2019-09-18 Thread Max Reitz
This reverts commit 5279b30392da7a3248b320c75f20c61e3a95863c. We no longer need this check because exact=true forces the block driver to give the image the exact size requested by the user. Signed-off-by: Max Reitz --- qemu-img.c | 39 --- 1 file changed, 4

[Qemu-devel] [PATCH] Fix wrong behavior of cpu_memory_rw_debug() function in SMM

2019-09-18 Thread Dmitry Poletaev
There is a problem, that you don't have access to the data using cpu_memory_rw_debug() function when in SMM. You can't remotely debug SMM mode program because of that for example. Likely attrs version of get_phys_page_debug should be used to get correct asidx at the end to handle access

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-18 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 1:29, John Snow wrote: > > > On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.09.2019 3:16, John Snow wrote: >>> Like script_main, but doesn't require a single point of entry. >>> Replace all existing initialization sections with this drop-in replacement. >>> >>> This

[Qemu-devel] [PATCH-for-4.2 v11 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-18 Thread Shameer Kolothum
This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. With this, both hot and cold plug of device memory is enabled now for Guest with ACPI boot. Memory cold plug support with Guest DT boot is not yet supported. As

[Qemu-devel] [PATCH-for-4.2 v11 00/11] ARM virt: ACPI memory hotplug support

2019-09-18 Thread Shameer Kolothum
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the

[Qemu-devel] [PATCH-for-4.2 v11 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-09-18 Thread Shameer Kolothum
Generate Memory Affinity Structures for PC-DIMM ranges. Also, Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Hence add support(>=4.2) to create numa node automatically

[Qemu-devel] [PATCH 4/8] block: Add @exact parameter to bdrv_co_truncate()

2019-09-18 Thread Max Reitz
We have two drivers (iscsi and file-posix) that (in some cases) return success from their .bdrv_co_truncate() implementation if the block device is larger than the requested offset, but cannot be shrunk. Some callers do not want that behavior, so this patch adds a new parameter that they can use

[Qemu-devel] [PATCH 3/8] block: Do not truncate file node when formatting

2019-09-18 Thread Max Reitz
There is no reason why the format drivers need to truncate the protocol node when formatting it. When using the old .bdrv_co_create_ops() interface, the file will be created with no size option anyway, which generally gives it a size of 0. (Exceptions are block devices, which cannot be truncated

[Qemu-devel] [PATCH v2 1/3] audio: fix buffer-length typo in documentation

2019-09-18 Thread Stefan Hajnoczi
Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bbfd936d29..a4f9f74f52 100644 --- a/qemu-options.hx +++

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-18 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella wrote: > > On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > I volunteer for "Libvirt: Never too Late to Learn New Tricks" by > Daniel Berrange. Hi Stefano, Paolo has already volunteered for that. Is there another talk you are

[Qemu-devel] [PATCH v2 3/3] audio: fix ALSA period-length typo in documentation

2019-09-18 Thread Stefan Hajnoczi
Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 6d7fe57dd4..0f79c70c37 100644 --- a/qemu-options.hx +++

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

2019-09-18 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 10:58, Greg Kurz wrote: > On Tue, 17 Sep 2019 17:40:11 + > Vladimir Sementsov-Ogievskiy wrote: > >> 17.09.2019 18:37, Greg Kurz wrote: >>> On Tue, 17 Sep 2019 13:25:03 + >>> Vladimir Sementsov-Ogievskiy wrote: >>> 17.09.2019 13:20, Greg Kurz wrote: > Ensure that

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-18 Thread Stefano Garzarella
On Wed, Sep 18, 2019 at 11:02:54AM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella > wrote: > > > > On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > > I volunteer for "Libvirt: Never too Late to Learn New Tricks" by > > Daniel Berrange. > >

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

2019-09-18 Thread Alex Bennée
David Hildenbrand writes: > On 18.09.19 11:47, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Let's add the simple test based on the example from the PoP. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> tests/tcg/s390x/Makefile.target | 1 + >>> tests/tcg/s390x/mvo.c

Re: [Qemu-devel] qemu patches

2019-09-18 Thread Philippe Mathieu-Daudé
Hi Ilias, On 9/18/19 10:19 AM, Ilias wrote: > Hi, > > Your recent patch > > https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 > > to the file > > target/i386/whpx-all.c >

[Qemu-devel] [PATCH-for-4.2 v11 09/11] docs/specs: Add ACPI GED documentation

2019-09-18 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- Addressed Peter's comments, -changed to rst format. -typo/grammer corrections. --- docs/specs/acpi_hw_reduced_hotplug.rst | 70

[Qemu-devel] [PATCH 7/8] block: Pass truncate exact=true where reasonable

2019-09-18 Thread Max Reitz
This is a change in behavior, so all instances need a good justification. The comments added here should explain my reasoning. qed already had a comment that suggests it always expected bdrv_truncate()/blk_truncate() to behave as if exact=true were passed (c743849bee7 came eight months before

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

2019-09-18 Thread Laurent Vivier
Le 18/09/2019 à 11:59, Alex Bennée a écrit : > > Pierre Muller writes: > >> Hi Thomas, >> >> I tried to use git format-patch -s below, >> and change the commit message that appears below: >> >> >> muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s >>

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-18 Thread Philippe Mathieu-Daudé
On 9/17/19 10:32 PM, Richard Henderson wrote: > On 9/16/19 11:48 AM, Philippe Mathieu-Daudé wrote: >> include/hw/rtc/mc146818rtc.h | 38 > > Same rebase failure as for patch 4? This one is actually correct, it got moved from: include/hw/timer/mc146818rtc.h

[Qemu-devel] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-18 Thread Paul Durrant
When a frontend gracefully disconnects from an offline backend, it will set its own state to XenbusStateClosed. The code in xen-block.c correctly deals with this and sets the backend into XenbusStateClosed. Unfortunately it is possible for toolstack to actually delete the frontend area before the

  1   2   3   4   >