[Qemu-devel] [PULL 30/34] pc-bios/s390-ccw: Do not pre-initialize empty array

2019-09-19 Thread Cornelia Huck
From: Thomas Huth Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw: zero out bss section"), we are clearing now the BSS in start.S, so there is no need to pre-initialize the loadparm_str array with zeroes anymore. Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Paolo Bonzini
On 19/09/19 14:39, Jason Wang wrote: >> In general, userspace cannot assume that it's okay to sync just through >> GPA1.  It must sync the host page if *either* GPA1 or GPA2 are marked >> dirty. > > Maybe we need document this somewhere. Well, it's implicit but it should be kind of obvious. The

Re: [Qemu-devel] [PATCH v3 16/22] fuzz: add fuzzer skeleton

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:43PM +, Oleinik, Alexander wrote: > +void set_fuzz_target_args(int argc, char **argv) > +{ > +if (fuzz_target) { > +fuzz_target->main_argc = argc; > +fuzz_target->main_argv = argv; > +} > +} Why calls this and why? > + > +void

Re: [Qemu-devel] [PULL] RISC-V Patches for the 4.2 Soft Freeze, Part 1, v3

2019-09-19 Thread Peter Maydell
On Wed, 18 Sep 2019 at 16:27, Palmer Dabbelt wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [RFC v2 0/5] Move notdirty handling to cputlb

2019-09-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190918180251.32003-1-richard.hender...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[Qemu-devel] [PATCH v2 5/5] amd_iommu: Let amdvi_iommu_notify_flag_changed() fail

2019-09-19 Thread Eric Auger
In case a MAP notifier is attempted to be registered, let's simply return an error. This latter now is handled in the VFIO code. Signed-off-by: Eric Auger --- hw/i386/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index

Re: [Qemu-devel] [RFC v2 0/5] Move notdirty handling to cputlb

2019-09-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190918180251.32003-1-richard.hender...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v2 3/5] exec: assert on memory_region_register_iommu_notifier() failure

2019-09-19 Thread Eric Auger
memory_region_register_iommu_notifier now returns an error in case of failure. Assert in such a case. Signed-off-by: Eric Auger --- v1 -> v2: - add assert(!ret) --- exec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 8b998974f8..5be8db6253

[Qemu-devel] [PATCH v2 2/5] vfio/common: Handle memory_region_register_iommu_notifier() failure

2019-09-19 Thread Eric Auger
Now memory_region_register_iommu_notifier() is allowed to fail, let's handle the returned value in vfio_listener_region_add(). This will allow to remove the error handling (exit) in the IOMMUs that implement a notify_flag_changed() that sometimes cannot accept the MAP flag. Signed-off-by: Eric

[Qemu-devel] [PATCH v2 4/5] vhost: assert on memory_region_register_iommu_notifier() failure

2019-09-19 Thread Eric Auger
memory_region_register_iommu_notifier now returns an error in case of failure. Assert in such a case. Signed-off-by: Eric Auger --- v1 -> v2: - assert(!ret) --- hw/virtio/vhost.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c

[Qemu-devel] [PATCH v2 1/5] memory: allow memory_region_register_iommu_notifier() to fail

2019-09-19 Thread Eric Auger
Currently, when a notifier is attempted to be registered and its flags are not supported (especially the MAP one) by the IOMMU MR, we generally abruptly exit in the IOMMU code. The failure could be handled more nicely in the caller and especially in the VFIO code. So let's allow

[Qemu-devel] [PATCH v2 0/5] Allow memory_region_register_iommu_notifier() to fail

2019-09-19 Thread Eric Auger
This series allows the memory_region_register_iommu_notifier() to fail. As of now, when a MAP notifier is attempted to be registered along with SMMUv3, Intel iommu without caching mode or AMD IOMMU, we exit in the IOMMU MR notify_flag_changed() callback. In case of VFIO assigned device hotplug,

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午6:16, Yan Zhao wrote: On Thu, Sep 19, 2019 at 06:06:52PM +0800, Jason Wang wrote: On 2019/9/19 下午2:29, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote:

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 19.09.2019 um 11:05 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > > > > > However, global -snapshot is just a convenient shortcut for specifying > > > > > snapshot=on for all -drive arguments. So if

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 12:17, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: >>> + */ >>> +#define MAKE_ERRP_SAFE(errp) \ >>> +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ >>> +if ((errp) == NULL ||

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 10:21:44AM +, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 13:09, Daniel P. Berrangé wrote: > > On Thu, Sep 19, 2019 at 11:17:20AM +0200, Kevin Wolf wrote: > >> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > >>> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Max Reitz
On 19.09.19 12:03, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 12:33, Max Reitz wrote: >> On 19.09.19 11:14, Vladimir Sementsov-Ogievskiy wrote: >>> 19.09.2019 11:59, Max Reitz wrote: On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 02:25, Eric Blake wrote: > > On 9/13/19 10:49 AM, Peter Maydell wrote: > > The qemu-ga documentation is currently in qemu-ga.texi in > > Texinfo format, which we present to the user as: > > * a qemu-ga manpage > > * a section of the main qemu-doc HTML documentation > > >

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 01:18:57PM +0200, Stefan Weil wrote: > Am 19.09.2019 um 12:59 schrieb Philippe Mathieu-Daudé: > > Add a job to cross-build QEMU with WHPX enabled. > > > > Use the Win10SDK headers from the Android Project, as commented > > in

Re: [Qemu-devel] [PATCH v1 1/6] memory: allow memory_region_register_iommu_notifier() to fail

2019-09-19 Thread Auger Eric
Hi Peter, On 9/16/19 5:23 AM, Peter Xu wrote: > On Fri, Sep 13, 2019 at 10:36:10AM +0200, Eric Auger wrote: >> Currently, when a notifier is attempted to be registered and its >> flags are not supported (especially the MAP one) by the IOMMU MR, >> we generally abruptly exit in the IOMMU code. The

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 1:41 PM, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 01:18:57PM +0200, Stefan Weil wrote: >> Am 19.09.2019 um 12:59 schrieb Philippe Mathieu-Daudé: >>> Add a job to cross-build QEMU with WHPX enabled. >>> >>> Use the Win10SDK headers from the Android Project, as commented >>> in

Re: [Qemu-devel] [PATCH v3] virtio-blk: schedule virtio_notify_config to run on main context

2019-09-19 Thread Kevin Wolf
Am 16.09.2019 um 13:24 hat Sergio Lopez geschrieben: > virtio_notify_config() needs to acquire the global mutex, which isn't > allowed from an iothread, and may lead to a deadlock like this: > > - main thead > * Has acquired: qemu_global_mutex. > * Is trying the acquire: iothread AioContext

Re: [Qemu-devel] [PATCH 1/2] tests/docker: Add fedora-win10sdk-cross image

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 1:28 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/docker/Makefile.include | 1 + >> .../dockerfiles/fedora-win10sdk-cross.docker | 21 +++ >> 2 files changed, 22 insertions(+)

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Laurent Vivier
Le 19/09/2019 à 13:01, Gerd Hoffmann a écrit : > On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote: >> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : >>> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > This

Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Gerd Hoffmann
-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 > > 09:48:34 +0100) > > > > are available in the Git repository at: > > > > git://git.kraxel.org/qemu tags/ui-20190919-pull-request > > > > for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6

Re: [Qemu-devel] [PATCH 1/2] tests/docker: Add fedora-win10sdk-cross image

2019-09-19 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 1 + > .../dockerfiles/fedora-win10sdk-cross.docker | 21 +++ > 2 files changed, 22 insertions(+) > create mode 100644

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Paolo Bonzini
On 19/09/19 09:16, Tian, Kevin wrote: >>> why GPA1 and GPA2 should be both dirty? >>> even they have the same HVA due to overlaping virtual address space in >>> two processes, they still correspond to two physical pages. >>> don't get what's your meaning :) >> >> The point is not leave any corner

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Kevin Wolf
Am 19.09.2019 um 11:05 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > > > However, global -snapshot is just a convenient shortcut for specifying > > > > snapshot=on for all -drive arguments. So if -snapshot is incompatible > > > > with replay, shouldn't

Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv

2019-09-19 Thread Paolo Bonzini
On 19/09/19 01:19, Oleinik, Alexander wrote: > The names i2c_send and i2c_recv collide with functions defined in > hw/i2c/core.c. This causes an error when linking against libqos and > softmmu simultaneously (for example when using qtest inproc). Rename the > libqos functions to avoid this. I'd

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 1:18 PM, Stefan Weil wrote: > Am 19.09.2019 um 12:59 schrieb Philippe Mathieu-Daudé: >> Add a job to cross-build QEMU with WHPX enabled. >> >> Use the Win10SDK headers from the Android Project, as commented >> in https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03842.html >> >>

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 1:09 PM, Thomas Huth wrote: > On 19/09/2019 12.59, Philippe Mathieu-Daudé wrote: >> Add a job to cross-build QEMU with WHPX enabled. >> >> Use the Win10SDK headers from the Android Project, as commented >> in https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03842.html >> >>

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Stefan Weil
Am 19.09.2019 um 12:59 schrieb Philippe Mathieu-Daudé: > Add a job to cross-build QEMU with WHPX enabled. > > Use the Win10SDK headers from the Android Project, as commented > in https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03842.html > > Based-on:

Re: [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Thomas Huth
On 19/09/2019 12.59, Philippe Mathieu-Daudé wrote: > Add a job to cross-build QEMU with WHPX enabled. > > Use the Win10SDK headers from the Android Project, as commented > in https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03842.html > > Based-on:

Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv

2019-09-19 Thread Paolo Bonzini
On 19/09/19 01:19, Oleinik, Alexander wrote: > +static GString *qtest_client_inproc_recv_line(void *); This is not defined as of this patch, please move it to patch 14. > > +qtest_client_set_rx_handler(s, qtest_client_socket_recv_line, s); > +qtest_client_set_tx_handler(s,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Gerd Hoffmann
On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote: > Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : > > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: > >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > >>> This dependency is currently "automagic", which is bad

Re: [Qemu-devel] [PATCH] util/qemu-option: Document the get_opt_value() function

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 12:58 PM, Damien Hedde wrote: > Hi Philippe, > > On 9/19/19 12:49 PM, Philippe Mathieu-Daudé wrote: >> Coverity noticed commit 950c4e6c94 introduced a dereference before >> null check in get_opt_value (CID1391003): >> >> In get_opt_value: All paths that lead to this null pointer >>

[Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
Add a job to cross-build QEMU with WHPX enabled. Use the Win10SDK headers from the Android Project, as commented in https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03842.html Based-on: <20190918121101.30690-1-phi...@redhat.com>

Re: [Qemu-devel] [PATCH 2/2] .shippable.yml: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 12:59 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > .shippable.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.shippable.yml b/.shippable.yml > index bbc6f88510..01b33bd034 100644 > --- a/.shippable.yml > +++ b/.shippable.yml > @@

[Qemu-devel] [PATCH 1/2] tests/docker: Add fedora-win10sdk-cross image

2019-09-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + .../dockerfiles/fedora-win10sdk-cross.docker | 21 +++ 2 files changed, 22 insertions(+) create mode 100644 tests/docker/dockerfiles/fedora-win10sdk-cross.docker diff --git

Re: [Qemu-devel] [PATCH] util/qemu-option: Document the get_opt_value() function

2019-09-19 Thread Damien Hedde
Hi Philippe, On 9/19/19 12:49 PM, Philippe Mathieu-Daudé wrote: > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer earlier

[Qemu-devel] [PATCH 2/2] .shippable.yml: Build WHPX enabled binaries

2019-09-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index bbc6f88510..01b33bd034 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -25,6 +25,8 @@ env:

[Qemu-devel] [Bug 1843151] Re: Regression: QEMU 4.1.0 qxl and KMS resoluiton only 4x10

2019-09-19 Thread Dr. David Alan Gilbert
James: Freedy proposed a fix for the bug I was looking at with a spice fix: https://lists.freedesktop.org/archives/spice-devel/2019-September/050859.html That's in the spice-server package. If you can check that it also fixes your bug that would be great. -- You received this bug

[Qemu-devel] [PATCH] util/qemu-option: Document the get_opt_value() function

2019-09-19 Thread Philippe Mathieu-Daudé
Coverity noticed commit 950c4e6c94 introduced a dereference before null check in get_opt_value (CID1391003): In get_opt_value: All paths that lead to this null pointer comparison already dereference the pointer earlier (CWE-476) We fixed this in commit 6e3ad3f0e31, but relaxed the check in

Re: [Qemu-devel] [PATCH v3 14/22] libqtest: add in-process qtest.c tx/rx handlers

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:41PM +, Oleinik, Alexander wrote: > @@ -830,6 +832,9 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...) > > const char *qtest_get_arch(void) Maybe this should be per QTestState just like big_endian, but the global qtest_arch variable is okay for now.

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-19 Thread Li Qiang
Gerd Hoffmann 于2019年9月19日周四 下午4:54写道: > On Sun, Sep 01, 2019 at 10:43:42PM +0800, Li Qiang wrote: > > fangying 于2019年9月1日周日 下午8:29写道: > > > > > Nice work, your patch does fix this issue in my test. > > > > > > I think we should make VncState.zlib to be a pointer type as well. > > > > > > Since

Re: [Qemu-devel] [PATCH v3 09/22] qtest: add in-process incoming command handler

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:36PM +, Oleinik, Alexander wrote: > The handler allows a qtest client to send commands to the server by > directly calling a function, rather than using a file/CharBackend > > Signed-off-by: Alexander Oleinik > --- > include/sysemu/qtest.h | 1 + > qtest.c

Re: [Qemu-devel] [PATCH v3 13/22] libqtest: make qtest_bufwrite send "atomic"

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:40PM +, Oleinik, Alexander wrote: > When using qtest "in-process" communication, qtest_sendf directly calls > a function in the server (qtest.c). Combining the contents of the > subsequent socket_sends into the qtest_sendf, makes it so the server can > immediately

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Alex Bennée
Eric Blake writes: > On 9/13/19 10:49 AM, Peter Maydell wrote: >> The qemu-ga documentation is currently in qemu-ga.texi in >> Texinfo format, which we present to the user as: >> * a qemu-ga manpage >> * a section of the main qemu-doc HTML documentation >> >> Convert the documentation to rST

Re: [Qemu-devel] [PATCH v3 12/22] libqos: move useful qos-test funcs to qos_external

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:39PM +, Oleinik, Alexander wrote: > The moved functions are not specific to qos-test and might be useful > elsewhere. For example the virtual-device fuzzer makes use of them for > qos-assisted fuzz-targets. > > Signed-off-by: Alexander Oleinik > --- >

[Qemu-devel] [Bug 1782300] Re: COLO unable to failover to secondary VM

2019-09-19 Thread YanFu Cho
I also meet the same problem. Does anybody have solutions for this problem? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1782300 Title: COLO unable to failover to secondary VM Status in QEMU:

Re: [Qemu-devel] [PATCH v3 06/22] fuzz: add configure flag --enable-fuzzing

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:33PM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > configure | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/configure b/configure > index 30aad233d1..775f46f55a 100755 > --- a/configure > +++ b/configure > @@

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix typo in header of kvm_device_access()

2019-09-19 Thread Laurent Vivier
Le 12/09/2019 à 15:57, Greg Kurz a écrit : > Signed-off-by: Greg Kurz > --- > include/sysemu/kvm.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 909bcd77cf82..fd674772ab31 100644 > --- a/include/sysemu/kvm.h > +++

Re: [Qemu-devel] [PATCH v3 00/22] Add virtual device fuzzing support

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:27PM +, Oleinik, Alexander wrote: > create mode 100644 docs/devel/fuzzing.txt > create mode 100644 main.c > create mode 100644 tests/fuzz/Makefile.include > create mode 100644 tests/fuzz/fork_fuzz.c > create mode 100644 tests/fuzz/fork_fuzz.h > create mode

Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:32PM +, Oleinik, Alexander wrote: > This makes it simple to swap the transport functions for qtest commands > to and from the qtest client. For example, now it is possible to > directly pass qtest commands to a server handler that exists within the > same process,

Re: [Qemu-devel] [PATCH v3 08/22] module: check module wasn't already initialized

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:35PM +, Oleinik, Alexander wrote: > The virtual-device fuzzer must initialize QOM, prior to running > vl:qemu_init, so that it can use the qos_graph to identify the arguments > required to initialize a guest for libqos-assisted fuzzing. This change > prevents

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Laurent Vivier
Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit : >>> This dependency is currently "automagic", which is bad for distributions. >>> >>> Signed-off-by: James Le Cuirot >>> --- >>>

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 06:06:52PM +0800, Jason Wang wrote: > > On 2019/9/19 下午2:29, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > >> On 2019/9/19 下午2:17, Yan Zhao wrote: > >>> On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > On 2019/9/19

Re: [Qemu-devel] [RFC v2 0/5] Move notdirty handling to cputlb

2019-09-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190918180251.32003-1-richard.hender...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

2019-09-19 Thread Laurent Vivier
Le 13/09/2019 à 13:34, Eric Blake a écrit : > cc: qemu-trivial > > On 9/12/19 1:46 PM, Eric Blake wrote: >> This file is version-controlled, and not generated from a .json file. >> >> Fixes: bf582c3461b >> Reported-by: Thomas Huth >> Signed-off-by: Eric Blake >> --- >> .gitignore | 1 + >> 1

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 13:09, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 11:17:20AM +0200, Kevin Wolf wrote: >> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >>> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: + */ +#define MAKE_ERRP_SAFE(errp) \

Re: [Qemu-devel] [PATCH 1/1] Fix cacheline detection on FreeBSD/powerpc.

2019-09-19 Thread Laurent Vivier
Le 21/08/2019 à 10:25, Laurent Vivier a écrit : > From: Justin Hibbits > > machdep.cacheline_size is an integer, not a long. Since PowerPC is > big-endian this causes sysctlbyname() to fill in the upper bits of the > argument, rather than the correct 'lower bits' of the word. Specify the >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix typo in header of kvm_device_access()

2019-09-19 Thread Laurent Vivier
Le 12/09/2019 à 15:57, Greg Kurz a écrit : > Signed-off-by: Greg Kurz > --- > include/sysemu/kvm.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 909bcd77cf82..fd674772ab31 100644 > --- a/include/sysemu/kvm.h > +++

[Qemu-devel] [Bug 1844644] Re: Compiler warnings using MSVC

2019-09-19 Thread Peter Maydell
Hi; MSVC is not a supported compiler for QEMU. We expect it to be built with either gcc or llvm. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午5:36, Yan Zhao wrote: On Thu, Sep 19, 2019 at 05:35:05PM +0800, Jason Wang wrote: On 2019/9/19 下午2:32, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote:

Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190919-pull-request > > for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0: > > vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200) > > -

Re: [Qemu-devel] [PULL 00/10] virtio, vhost, pc: features, fixes, cleanups.

2019-09-19 Thread Peter Maydell
On Tue, 17 Sep 2019 at 16:10, Michael S. Tsirkin wrote: > > The following changes since commit 138985c1ef8b66e4e5b383354e133e05d01d0b5f: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-sep-12-2019' into staging (2019-09-13 > 16:04:46 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH v3 04/22] qtest: add qtest_server_send abstraction

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:31PM +, Oleinik, Alexander wrote: > qtest_server_send is a function pointer specifying the handler used to > transmit data to the qtest client. In the standard configuration, this > calls the CharBackend handler, but now it is possible for other types of >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/m68k/fpu_helper.c: rename the access arguments

2019-09-19 Thread Laurent Vivier
Le 12/09/2019 à 16:02, KONRAD Frederic a écrit : > The "access" arguments clash with a macro under Windows with MinGW: > CC m68k-softmmu/target/m68k/fpu_helper.o > target/m68k/fpu_helper.c: In function 'fmovem_predec': > target/m68k/fpu_helper.c:405:56: error: macro "access" passed 4

Re: [Qemu-devel] [PATCH] tests/tcg: add simple record/replay smoke test for aarch64

2019-09-19 Thread Alex Bennée
Pavel Dovgalyuk writes: > Thanks! > > This seem to correctly run record and replay command lines. > When I break the replay correctness, then the test reports a timeout error. > > However, we need some kind of a manual for tcg testing. I had to dig through > makefile and configure > scripts

Re: [Qemu-devel] [PATCH v3 03/22] fuzz: Add FUZZ_TARGET module type

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:30PM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > include/qemu/module.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 11:17:20AM +0200, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > > On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > > > + */ > > > +#define MAKE_ERRP_SAFE(errp) \ > > > +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)};

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Greg Kurz
On Thu, 19 Sep 2019 09:28:11 + Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 11:59, Greg Kurz wrote: > > On Wed, 18 Sep 2019 16:02:44 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> Hi all! > >> > >> Here is a proposal (three of them, actually) of auto propagation for > >>

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午2:29, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrote: On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote:

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 0/3] Minor fixes for the s390-ccw firmware

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 18:15:11 +0200 Thomas Huth wrote: > This pull request is not for master ! > > Hi Cornelia, > > the following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are

Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:29PM +, Oleinik, Alexander wrote: > The names i2c_send and i2c_recv collide with functions defined in > hw/i2c/core.c. This causes an error when linking against libqos and > softmmu simultaneously (for example when using qtest inproc). Rename the > libqos

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 12:33, Max Reitz wrote: > On 19.09.19 11:14, Vladimir Sementsov-Ogievskiy wrote: >> 19.09.2019 11:59, Max Reitz wrote: >>> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a proposal (three of them, actually) of auto propagation for local_err,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

2019-09-19 Thread Laurent Vivier
Le 04/09/2019 à 07:27, Thomas Huth a écrit : > We've got a separate option to configure the accelerator nowadays, which > is shorter to type and the preferred way of specifying an accelerator. > Use it in the source and examples to show that it is the favored option. > (However, do not touch the

Re: [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:28PM +, Oleinik, Alexander wrote: > diff --git a/vl.c b/vl.c > index 630f5c5e9c..327510c81f 100644 > --- a/vl.c > +++ b/vl.c > @@ -36,18 +36,6 @@ > #include "sysemu/seccomp.h" > #include "sysemu/tcg.h" > > -#ifdef CONFIG_SDL > -#if defined(__APPLE__) ||

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 00/29] s390x/tcg: mem_helper: Fault-safe handling

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 17:28:53 +0200 David Hildenbrand wrote: > This pull request is not for master. > > Hi Conny, > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

2019-09-19 Thread Laurent Vivier
Le 03/09/2019 à 14:05, Philippe Mathieu-Daudé a écrit : > "qemu/cutils.h" contains various qemu_strtosz_*() functions > useful to convert strings to size. It seems natural to have > the opposite usage (from size to string) there too. > > The function definition is already in util/cutils.c. > >

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 12:17, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: >>> + */ >>> +#define MAKE_ERRP_SAFE(errp) \ >>> +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ >>> +if ((errp) == NULL ||

[Qemu-devel] [Bug 1844644] [NEW] Compiler warnings using MSVC

2019-09-19 Thread Patrick van Logchem
Public bug reported: The following line of code results in an implicit truncation of an uint16_t value to an uint8_t variable, which triggers a compiler warning in MSVC : https://github.com/qemu/qemu/blob/f8c3db33a5e863291182f8862ddf81618a7c6194/hw/usb/dev-hub.c#L387 (Two lines down, the same

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 05:35:05PM +0800, Jason Wang wrote: > > On 2019/9/19 下午2:32, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: > >> On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > >>> On 2019/9/19 下午2:17, Yan Zhao wrote: > On Thu, Sep 19,

Re: [Qemu-devel] [PATCH] target/i386: Correct extra enter and spaces in comment

2019-09-19 Thread Philippe Mathieu-Daudé
Hi Tao, On 9/19/19 4:06 AM, Tao Xu wrote: > There is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, > remove the extra enter and spaces. > > Signed-off-by: Tao Xu > --- > target/i386/cpu.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/i386/cpu.h

Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
On 19.09.19 11:28, David Hildenbrand wrote: > Let's add a test that especially verifies that no data will be touched > in case we cross page boundaries and one page access triggers a fault. > > Before the fault-safe handling fixes, the test failes with: > TESTmvc on s390x > data

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午3:16, Tian, Kevin wrote: +Paolo to help clarify here. From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, September 19, 2019 2:32 PM On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午2:32, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrote:

Re: [Qemu-devel] [PATCH] hw/arm: set machine 'virt' as default

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/18/19 11:56 PM, Dan Streetman wrote: > On Wed, Sep 18, 2019 at 4:34 PM Alex Bennée wrote: >> >> Dan Streetman writes: >> >>> From: Dan Streetman >>> >>> There is currently no default machine type for arm so one must be specified >>> with --machine. This sets the 'virt' machine type as

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Max Reitz
On 19.09.19 11:14, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 11:59, Max Reitz wrote: >> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a proposal (three of them, actually) of auto propagation for >>> local_err, to not call error_propagate on every exit

Re: [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 05:51:16PM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/19 3:21 PM, Stefan Hajnoczi wrote: > > Reviewed-by: John Snow > > Reviewed-by: Kevin Wolf > > Signed-off-by: Philippe Mathieu-Daudé > > Message-id: 20190916095121.29506-2-phi...@redhat.com > > Message-Id:

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 11:59, Greg Kurz wrote: > On Wed, 18 Sep 2019 16:02:44 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >>

[Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
Let's add a test that especially verifies that no data will be touched in case we cross page boundaries and one page access triggers a fault. Before the fault-safe handling fixes, the test failes with: TESTmvc on s390x data modified during a fault make[2]: ***

Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

2019-09-19 Thread Stefan Hajnoczi
On Mon, Sep 16, 2019 at 11:00:35AM +0100, Dr. David Alan Gilbert wrote: > (Copying in Stefan since he was looking at DBus for virtiofs) > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Signed-off-by: Marc-André Lureau > > --- > > docs/interop/dbus.rst | 73

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > > + */ > > +#define MAKE_ERRP_SAFE(errp) \ > > +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ > > +if ((errp) == NULL || *(errp) == error_abort || *(errp) ==

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 11:59, Max Reitz wrote: > On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >> >> It also may help

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > However, global -snapshot is just a convenient shortcut for specifying > > > snapshot=on for all -drive arguments. So if -snapshot is incompatible > > > with replay, shouldn't manually marking all drives as snapshot=on be > > > incompatible

[Qemu-devel] [PULL 0/2] Ati 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ati-20190919-pull-request for you to fetch changes up

[Qemu-devel] [PULL 2/2] ati: use vga_read_byte in ati_cursor_define

2019-09-19 Thread Gerd Hoffmann
This makes sure reads are confined to vga video memory. v3: use uint32_t, fix cut+paste bug. v2: fix ati_cursor_draw_line too. Reported-by: xu hang Signed-off-by: Gerd Hoffmann Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-id:

Re: [Qemu-devel] [PATCH] docker: remove python2.7 from docker9-mxe

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 12:25 AM, John Snow wrote: > When it was based on docker8 which uses python-minimal, it needed this. > It no longer does. Good catch, thanks! > Goodbye, python2.7. > > Signed-off-by: John Snow > --- > tests/docker/dockerfiles/debian9-mxe.docker | 3 +-- > 1 file changed, 1

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Greg Kurz
On Wed, 18 Sep 2019 16:02:44 +0300 Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1]

<    1   2   3   4   5   >