[Qemu-devel] [PULL 1/2] vga: move access helpers to separate include file

2019-09-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190917111441.27405-2-kra...@redhat.com --- hw/display/vga-access.h | 49 hw/display/vga-helpers.h | 26 - hw/display/vga.c | 1 + 3 files

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-19 Thread Gerd Hoffmann
On Sun, Sep 01, 2019 at 10:43:42PM +0800, Li Qiang wrote: > fangying 于2019年9月1日周日 下午8:29写道: > > > Nice work, your patch does fix this issue in my test. > > > > I think we should make VncState.zlib to be a pointer type as well. > > > > Since we are going to use pointers instead of copy, we must

Re: [Qemu-devel] [PATCH] tests/tcg: add simple record/replay smoke test for aarch64

2019-09-19 Thread Pavel Dovgalyuk
Thanks! This seem to correctly run record and replay command lines. When I break the replay correctness, then the test reports a timeout error. However, we need some kind of a manual for tcg testing. I had to dig through makefile and configure scripts to undestand that testing needs the cross

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 11:52 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > > > From:

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Max Reitz
On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1] about

Re: [Qemu-devel] [PATCH] docker: remove python2.7 from docker9-mxe

2019-09-19 Thread Alex Bennée
John Snow writes: > When it was based on docker8 which uses python-minimal, it needed this. > It no longer does. Queued to testing/next, thanks. > > Goodbye, python2.7. > > Signed-off-by: John Snow > --- > tests/docker/dockerfiles/debian9-mxe.docker | 3 +-- > 1 file changed, 1

[Qemu-devel] [PULL 14/26] audio: split ctl_* functions into enable_* and volume_*

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This way we no longer need vararg functions, improving compile time error detection. Also now it's possible to check actually what commands are supported, without needing to manually update ctl_caps. Signed-off-by: Kővágó, Zoltán Message-id:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Gerd Hoffmann
On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: > Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > > This dependency is currently "automagic", which is bad for distributions. > > > > Signed-off-by: James Le Cuirot > > --- > > configure | 5 + > > 1 file changed, 5

Re: [Qemu-devel] Docker Tests

2019-09-19 Thread Alex Bennée
John Snow writes: > Hi, I'm having a regular trainwreck here w/ the Docker test suite and I > have a few questions; > > 1. Which tests should I expect to work by default? for instance, > make-debug doesn't but I think that might be normal. Is that the only > one? test-build is the only one

[Qemu-devel] [PULL 12/26] audio: unify input and output mixeng buffer management

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the initial size of the STSampleBuffer. The next commit tries to fix this inconsistency. Signed-off-by: Kővágó, Zoltán Message-id:

[Qemu-devel] [PULL 18/26] audio: support more than two channels in volume setting

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 4c938a46b760792319dbc2f61a442a41a36718d3.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/audio.c | 30

Re: [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 12:46:42 -0500 Eric Blake wrote: > On 9/18/19 5:26 AM, Cornelia Huck wrote: > > On Tue, 17 Sep 2019 18:36:20 +0200 > > Greg Kurz wrote: > > > >> On Tue, 17 Sep 2019 13:24:12 +0200 > >> Cornelia Huck wrote: > >> > >>> On Tue, 17 Sep 2019 12:21:34 +0200 > >>> Greg Kurz

[Qemu-devel] [PULL 23/26] usb-audio: support more than two channels of audio

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This commit adds support for 5.1 and 7.1 audio playback. This commit adds a new property to usb-audio: * multi=on|off Whether to enable the 5.1 and 7.1 audio support. When off (default) it continues to emulate the old stereo-only device. When on, it emulates a

[Qemu-devel] [PULL 26/26] audio: fix ALSA period-length typo in documentation

2019-09-19 Thread Gerd Hoffmann
From: Stefan Hajnoczi Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi Message-Id: <20190918095335.7646-4-stefa...@redhat.com> Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL 07/26] paaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: f8f15e33739cd18305a3719270b52d61ece68bd5.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- configure| 5 - audio/audio_pt_int.h | 22 --- audio/audio_pt_int.c | 173

[Qemu-devel] [PULL 19/26] audio: replace shift in audio_pcm_info with bytes_per_frame

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán

[Qemu-devel] [PULL 24/26] usbaudio: change playback counters to 64 bit

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán With stereo playback, they need about 375 minutes of continuous audio playback to overflow, which is usually not a problem (as stopping and later resuming playback resets the counters). But with 7.1 audio, they only need about 95 minutes to overflow. After the overflow,

[Qemu-devel] [PULL 22/26] usb-audio: do not count on avail bytes actually available

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán Message-id: 90b5ec62109a69ee7c28d95b367e40dc41ad658a.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-audio.c | 30 ++

Re: [Qemu-devel] [PATCH] chardev: Add RFC2217 support for telnet client mode

2019-09-19 Thread Marc-André Lureau
Hi Sylvain On Wed, Sep 18, 2019 at 5:05 AM Sylvain Munaut wrote: > > This allow remote control of the baudrate and other comms > parameters. > > Signed-off-by: Sylvain Munaut > --- > chardev/char-socket.c | 232 ++ > chardev/char.c| 6 ++ >

[Qemu-devel] [PULL 21/26] paaudio: channel-map option

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán Message-id: 66670d43bd932be0919668cec6a8cd172bfb8383.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd

[Qemu-devel] [PULL 11/26] audio: remove remains of the old backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3c160307074a29e5826a89994ab7cfdee7b8ccf8.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_int.h | 7 --- audio/audio.c | 42 ++ 2 files changed, 6

[Qemu-devel] [PULL 04/26] dsoundaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 0019bfb5ae50b0750b839460b5dbc1b3073f02e7.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/dsound_template.h | 47 +++--- audio/dsoundaudio.c | 329 ++-- 2 files

[Qemu-devel] [PULL 09/26] spiceaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 71731ff2437028514284394de0f60d195d42e593.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/spiceaudio.c | 116 - 1 file changed, 42 insertions(+), 74

[Qemu-devel] [PULL 13/26] audio: common rate control code for timer based outputs

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This commit removes the ad-hoc rate-limiting code from noaudio and wavaudio, and replaces them with a (slightly modified) code from spiceaudio. This way multiple write calls (for example when the circular buffer wraps around) do not cause problems. Signed-off-by: Kővágó,

[Qemu-devel] [PULL 06/26] ossaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 44f4e888975c1d94f5d89e945df9782c0f541582.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/ossaudio.c | 288 +-- 1 file changed, 104 insertions(+), 184

[Qemu-devel] [PULL 02/26] alsaaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3978a3642e68da4d0af61c7618fcaa4ee22b009f.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/alsaaudio.c | 308 +- 1 file changed, 83 insertions(+), 225

[Qemu-devel] [PULL 01/26] audio: api for mixeng code free backends

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This will make it possible to skip mixeng with audio playback and recording, allowing us to free ourselves from the limitations of the current mixeng (stereo, int64 samples only). In this case, HW and SW voices will be essentially the same, for every SW voice we will create

[Qemu-devel] [PULL 25/26] audio: fix buffer-length typo in documentation

2019-09-19 Thread Gerd Hoffmann
From: Stefan Hajnoczi Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi Message-Id: <20190918095335.7646-2-stefa...@redhat.com> Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL 10/26] wavaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: fc447ed1336d60025485bbe6f3a4da52b1359077.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/wavaudio.c | 54 1 file changed, 9 insertions(+), 45

[Qemu-devel] [PULL 08/26] sdlaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3e95a57a0663f1f4464cd3515e252628791c971e.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/sdlaudio.c | 87 +++- 1 file changed, 42 insertions(+), 45

[Qemu-devel] [PULL 20/26] audio: basic support for multichannel audio

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán Message-id: 00998152d6e1c25b3194b9b71e27f14c4d26f396.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd

[Qemu-devel] [PULL 16/26] audio: make mixeng optional

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Implementation of the previously added mixing-engine option. Signed-off-by: Kővágó, Zoltán Message-id: 0adb9ca41b5abad2e048e9e36137446e86d5905c.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_template.h | 20 audio/audio.c

[Qemu-devel] [PULL 15/26] audio: add mixeng option (documentation)

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert,

[Qemu-devel] [PULL 05/26] noaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 066dc6dd54f4382d80de4376306f585b7fb47805.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/noaudio.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 2/3] audio: add -audiodev pa, in|out.latency= to documentation

2019-09-19 Thread Gerd Hoffmann
On Wed, Sep 18, 2019 at 10:53:34AM +0100, Stefan Hajnoczi wrote: > The "latency" parameter wasn't covered by the documentation. Doesn't apply cleanly (on top of the surround sound patch series). Picked the other two into the pull request. Please rebase & resend once this is merged. thanks,

[Qemu-devel] [PULL 17/26] paaudio: get/put_buffer functions

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This lets us avoid some buffer copying when using mixeng. Signed-off-by: Kővágó, Zoltán Message-id: 4554ff54ad04f706ad0e9af87fe07650fd6d9ac1.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 83

[Qemu-devel] [PULL 03/26] coreaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 60d68c051ed180c7315f7cdd6084b58b6fc9bb6d.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/coreaudio.c | 130 -- 1 file changed, 69 insertions(+), 61

[Qemu-devel] [PULL 00/26] Audio 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190919-pull-request for you to fetch changes up

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 20:49 hat John Snow geschrieben: > > > On 9/18/19 4:55 AM, Kevin Wolf wrote: > > Running iotests is not required to build QEMU, so we can have stricter > > version requirements for Python here and can make use of new features > > and drop compatibility code earlier. > > > >

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 19.09.19 10:20, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 10:53, David Hildenbrand wrote: >> On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: >>> 19.09.2019 10:32, David Hildenbrand wrote: On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 10:53, David Hildenbrand wrote: > On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: >> 19.09.2019 10:32, David Hildenbrand wrote: >>> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a proposal (three of them, actually) of auto propagation for

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 10:32, David Hildenbrand wrote: >> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a proposal (three of them, actually) of auto propagation for >>> local_err, to not call error_propagate on every

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 10:32, David Hildenbrand wrote: > On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >> >> It also may

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1] about

Re: [Qemu-devel] [PULL 4/4] vnc: fix memory leak when vnc disconnect

2019-09-19 Thread Li Qiang
Gerd Hoffmann 于2019年9月19日周四 下午3:12写道: > From: Li Qiang > > Currently when qemu receives a vnc connect, it creates a 'VncState' to > represent this connection. In 'vnc_worker_thread_loop' it creates a > local 'VncState'. The connection 'VcnState' and local 'VncState' exchange > data in

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Tian, Kevin
+Paolo to help clarify here. > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, September 19, 2019 2:32 PM > > > On 2019/9/19 下午2:17, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > >> On 2019/9/19 下午1:28, Yan Zhao wrote: > >>> On Thu, Sep 19,

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 23:31, John Snow wrote: > > > On 9/10/19 9:23 AM, John Snow wrote: >> >> >> On 9/10/19 4:19 AM, Stefan Hajnoczi wrote: >>> On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 23:13, John

[Qemu-devel] [PULL 3/4] ui: add an embedded Barrier client

2019-09-19 Thread Gerd Hoffmann
From: Laurent Vivier This allows to receive mouse and keyboard events from a Barrier server. This is enabled by adding the following parameter on the command line ... -object input-barrier,id=$id,name=$name ... Where $name is the name declared in the screens section of barrier.conf The

[Qemu-devel] [PULL 4/4] vnc: fix memory leak when vnc disconnect

2019-09-19 Thread Gerd Hoffmann
From: Li Qiang Currently when qemu receives a vnc connect, it creates a 'VncState' to represent this connection. In 'vnc_worker_thread_loop' it creates a local 'VncState'. The connection 'VcnState' and local 'VncState' exchange data in 'vnc_async_encoding_start' and 'vnc_async_encoding_end'. In

[Qemu-devel] [PULL 1/4] ui/egl: fix framebuffer reads

2019-09-19 Thread Gerd Hoffmann
Fix egl_fb_read() to use the (destination) surface size instead of the (source) framebuffer source for glReadPixels. Pass the DisplaySurface instead of the pixeldata pointer to egl_fb_read() to make this possible. With that in place framebuffer reads work fine even if the surface and framebuffer

[Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190919-pull-request

[Qemu-devel] [PULL 2/4] vnc: fix websocket field in events

2019-09-19 Thread Gerd Hoffmann
Just need to fill VncClientInfo.websocket in vnc_client_cache_addr(). Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1748175 Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Hajnoczi Message-id: 20190904055250.22421-1-kra...@redhat.com --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH v12 2/2] block/backup: fix backup_cow_with_offload for last cluster

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 23:14, John Snow wrote: > > > On 9/17/19 12:07 PM, Vladimir Sementsov-Ogievskiy wrote: >> We shouldn't try to copy bytes beyond EOF. Fix it. >> >> Fixes: 9ded4a0114968e >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Reviewed-by: Max Reitz >> --- >>   block/backup.c | 2 +- >>   1

Re: [Qemu-devel] [PATCH v3 2/2] ppc: Add support for 'mffsce' instruction

2019-09-19 Thread David Gibson
On Wed, Sep 18, 2019 at 09:31:22AM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) > instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. > This patch adds support for 'mffsce' instruction. > >

Re: [Qemu-devel] [PATCH] ppc: Use FPSCR defines instead of constants

2019-09-19 Thread David Gibson
On Wed, Sep 18, 2019 at 09:32:49AM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > There are FPSCR-related defines in target/ppc/cpu.h which can be used in > place of constants and explicit shifts which arguably improve the code a > bit in places. > > Signed-off-by: Paul A. Clarke

Re: [Qemu-devel] [PATCH v3 1/2] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-19 Thread David Gibson
On Wed, Sep 18, 2019 at 09:31:21AM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) > instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. > This patch adds support for 'mffscrn' and 'mffscrni'

Re: [Qemu-devel] [PATCH v12 1/2] block/backup: fix max_transfer handling for copy_range

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 22:57, John Snow wrote: > > > On 9/17/19 12:07 PM, Vladimir Sementsov-Ogievskiy wrote: >> Of course, QEMU_ALIGN_UP is a typo, it should be QEMU_ALIGN_DOWN, as we >> are trying to find aligned size which satisfy both source and target. >> Also, don't ignore too small max_transfer. In

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 21:32, Eric Blake wrote: > On 9/18/19 1:05 PM, Eric Blake wrote: > #define MAKE_ERRP_SAFE() \ g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = errp}; \ errp = &__auto_errp_prop.local_err > > I tried to see if this could be done with just a single

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: > On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > > > > On 2019/9/19 下午2:17, Yan Zhao wrote: > > > On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > > >> On 2019/9/19 下午1:28, Yan Zhao wrote: > > >>> On Thu, Sep

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > > On 2019/9/19 下午2:17, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > >> On 2019/9/19 下午1:28, Yan Zhao wrote: > >>> On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote: > On 2019/9/18

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrote: On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote: On 2019/9/18 下午4:37, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent:

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > > On 2019/9/19 下午1:28, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote: > >> On 2019/9/18 下午4:37, Tian, Kevin wrote: > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September

Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv

2019-09-19 Thread Thomas Huth
On 19/09/2019 01.19, Oleinik, Alexander wrote: > The names i2c_send and i2c_recv collide with functions defined in > hw/i2c/core.c. This causes an error when linking against libqos and > softmmu simultaneously (for example when using qtest inproc). Rename the > libqos functions to avoid this. > >

[Qemu-devel] [PATCH 19/21] aspeed: Parameterise number of MACs

2019-09-19 Thread Cédric Le Goater
From: Joel Stanley To support the ast2600's four MACs allow SoCs to specify the number they have, and create that many. Signed-off-by: Joel Stanley [clg: included a check on sc->macs_num when realizing the macs ] Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 5 -

[Qemu-devel] [PATCH 20/21] aspeed: add support for the Aspeed MII controller of the AST2600

2019-09-19 Thread Cédric Le Goater
The AST2600 SoC has an extra controller to set the PHY registers. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 5 ++ include/hw/net/ftgmac100.h | 17 hw/arm/aspeed_ast2600.c | 20 + hw/net/ftgmac100.c | 162 4

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午1:28, Yan Zhao wrote: On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote: On 2019/9/18 下午4:37, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Wednesday, September 18, 2019 2:10 PM Note that the HVA to GPA mapping is not an 1:1 mapping. One HVA

[Qemu-devel] [PATCH 18/21] aspeed: Add an AST2600 eval board

2019-09-19 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 52993f84b461..4450e71e5547 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -88,6 +88,9 @@ struct AspeedBoardState { /*

[Qemu-devel] [PATCH 15/21] aspeed/i2c: Add AST2600 support

2019-09-19 Thread Cédric Le Goater
The I2C controller of the AST2400 and AST2500 SoCs have one IRQ shared by all I2C busses. The AST2600 SoC I2C controller has one IRQ per bus and 16 busses. Signed-off-by: Cédric Le Goater --- include/hw/i2c/aspeed_i2c.h | 5 +++- hw/i2c/aspeed_i2c.c | 46

[Qemu-devel] [PATCH 17/21] aspeed/soc: Add AST2600 support

2019-09-19 Thread Cédric Le Goater
Initial definitions for a simple machine using an AST2600 SoC (Cortex CPU). The Cortex CPU and its interrupt controller are too complex to handle in the common Aspeed SoC framework. We introduce a new Aspeed SoC class with instance_init and realize handlers to handle the differences with the

[Qemu-devel] [PATCH 16/21] aspeed: Introduce an object class per SoC

2019-09-19 Thread Cédric Le Goater
It prepares ground for the AST2600. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 9 +-- hw/arm/aspeed.c | 4 +- hw/arm/aspeed_soc.c | 148 +++- 3 files changed, 84 insertions(+), 77 deletions(-) diff --git

[Qemu-devel] [PATCH 13/21] hw/gpio: Add in AST2600 specific implementation

2019-09-19 Thread Cédric Le Goater
From: Rashmica Gupta The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an addtional two sets of 1.8V gpios. Signed-off-by: Rashmica Gupta Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater --- hw/gpio/aspeed_gpio.c | 142 -- 1

[Qemu-devel] [PATCH 10/21] watchdog/aspeed: Introduce an object class per SoC

2019-09-19 Thread Cédric Le Goater
It cleanups the current models for the Aspeed AST2400 and AST2500 SoCs and prepares ground for future SoCs. It removes the need of the 'silicon_rev' property. Signed-off-by: Cédric Le Goater --- include/hw/watchdog/wdt_aspeed.h | 18 - hw/arm/aspeed_soc.c | 9 ++-

[Qemu-devel] [PATCH 14/21] aspeed/i2c: Introduce an object class per SoC

2019-09-19 Thread Cédric Le Goater
It prepares ground for register differences between SoCs. Signed-off-by: Cédric Le Goater --- include/hw/i2c/aspeed_i2c.h | 15 ++ hw/arm/aspeed_soc.c | 3 +- hw/i2c/aspeed_i2c.c | 60 - 3 files changed, 69 insertions(+), 9

[Qemu-devel] [PATCH 08/21] aspeed/sdmc: Introduce an object class per SoC

2019-09-19 Thread Cédric Le Goater
Use class handlers and class constants to differentiate the characteristics of the memory controller and remove the 'silicon_rev' property. Signed-off-by: Cédric Le Goater --- include/hw/misc/aspeed_sdmc.h | 19 +++- hw/arm/aspeed_soc.c | 5 +- hw/misc/aspeed_sdmc.c | 168

[Qemu-devel] [PATCH 09/21] aspeed/sdmc: Add AST2600 support

2019-09-19 Thread Cédric Le Goater
From: Joel Stanley The AST2600 SDMC controller is slightly different from its predecessor (DRAM training). Max memory is now 2G on the AST2600. Signed-off-by: Joel Stanley [clg: - improved commit log - reworked model integration into new objet class ] Signed-off-by: Cédric Le Goater

<    1   2   3   4   5