Re: [PATCH v9 04/15] hw/i386/pc: replace use of strtol with qemu_strtol in x86_load_linux()

Sergio Lopez writes: > Markus Armbruster writes: > >> Philippe Mathieu-Daudé writes: >> >>> Hi Sergio, >>> >>> On 10/15/19 1:23 PM, Sergio Lopez wrote: Follow checkpatch.pl recommendation and replace the use of strtol with qemu_strtol in x86_load_linux(). >>> >>> "with qemu_strtoui"

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

Cornelia Huck writes: > On Thu, 17 Oct 2019 16:40:56 +0200 > Thomas Huth wrote: > >> On 17/10/2019 16.34, Cornelia Huck wrote: >> > On Thu, 17 Oct 2019 16:21:23 +0200 >> > Thomas Huth wrote: >> > >> >> There is no USB on s390x, so running qemu-system-s390x with >> >> "-machine ...,usb=on"

Re: [PATCH] vhost-user-scsi: implement handle_output

On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: > > Originally, vhost-user-scsi did not implement a handle_output callback > as that didn't seem necessary. Turns out it is. > > Depending on which other devices are presented to a VM, SeaBIOS may > decide to map vhost-user-scsi devices on the

Re: [PATCH v10 14/15] hw/i386: Introduce the microvm machine type

Marc-André Lureau writes: > Hi > > On Wed, Oct 16, 2019 at 12:24 PM Sergio Lopez wrote: >> >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-lived guests.

RE: [PATCH] ssi: xilinx_spips: Filter the non spi registers transactions

Hi Alistair, > -Original Message- > From: Alistair Francis > Sent: Thursday, October 17, 2019 4:39 AM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; qemu-devel@nongnu.org Developers de...@nongnu.org> > Subject: Re: [PATCH] ssi: xilinx_spips: Filter the non spi

Re: [PATCH v19 5/5] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On 2019/10/15 22:48, Peter Maydell wrote: > On Tue, 15 Oct 2019 at 15:02, Xiang Zheng wrote: >> >> From: Dongjiu Geng >> >> Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, >> translates the host VA delivered by host to guest PA, then fills this PA >> to guest APEI

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

Marc-André Lureau writes: > Hi > > On Wed, Oct 16, 2019 at 12:19 PM Sergio Lopez wrote: >> >> Document the new microvm machine type. >> >> Signed-off-by: Sergio Lopez >> Reviewed-by: Michael S. Tsirkin >> --- >> docs/microvm.rst | 98 >> 1

[PATCH 4/6] migration/postcopy: set all_zero to true on the first target page

For the first target page, all_zero is set to true for this round check. After target_pages introduced, we could leverage this variable instead of checking the address offset. Signed-off-by: Wei Yang --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size

In this case, page_buffer content would not be used. Skip this to save some time. Signed-off-by: Wei Yang --- migration/ram.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 99a98b2da4..7938a643d9 100644 --- a/migration/ram.c

[PATCH 2/6] migration/postcopy: wait for decompress thread in precopy

Compress is not supported with postcopy, it is safe to wait for decompress thread just in precopy. This is a preparation for later patch. Signed-off-by: Wei Yang --- migration/ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[PATCH 6/6] migration/postcopy: enable compress during postcopy

postcopy requires to place a whole host page, while migration thread migrate memory in target page size. This makes postcopy need to collect all target pages in one host page before placing via userfaultfd. To enable compress during postcopy, there are two problems to solve: 1. Random order

[PATCH 5/6] migration/postcopy: enable random order target page arrival

After using number of target page received to track one host page, we could have the capability to handle random order target page arrival in one host page. This is a preparation for enabling compress during postcopy. Signed-off-by: Wei Yang --- migration/ram.c | 16 +++- 1 file

[PATCH 3/6] migration/postcopy: count target page number to decide the place_needed

In postcopy, it requires to place whole host page instead of target page. Currently, it relies on the page offset to decide whether this is the last target page. We also can count the target page number during the iteration. When the number of target page equals (host page size / target page

[PATCH 0/6] migration/postcopy: enable compress during postcopy

This patch set tries enable compress during postcopy. postcopy requires to place a whole host page, while migration thread migrate memory in target page size. This makes postcopy need to collect all target pages in one host page before placing via userfaultfd. To enable compress during postcopy,

Re: [PATCH RESEND v6 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

Hi Paolo, Ping :) On 10/11/2019 3:49 PM, Tao Xu wrote: On 10/11/2019 3:41 PM, Xu, Tao3 wrote: [...] diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 11b9c854b5..a465c893b5 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -401,6 +401,12 @@ uint32_t

[PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

Switch the slavio_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PATCH 0/8] Convert misc-arch devices to new ptimer API

This patchset converts the devices used by the miscellaneous minor architecture machines to the new ptimer API. More specifically: cris: hw/timer/etraxfs_timer.c lm32: hw/timer/lm32_timer.c hw/timer/milkymist-sysctl.c nios2: hw/timer/altera_timer.c sh4: hw/timer/sh_timer.c unicore32:

Re: [PATCH v2 4/7] libqos: add MSI-X callbacks to QVirtioPCIDevice

On 11/10/2019 10.56, Stefan Hajnoczi wrote: > The MSI-X vectors are programmed differently in the VIRTIO 1.0 and > Legacy interfaces. Introduce callbacks so different implementations can > be used depending on the interface version. > > Signed-off-by: Stefan Hajnoczi > --- >

[PATCH v6 50/54] tests/plugin: add hotpages to analyse memory access patterns

This plugin gives a summary of access patterns grouped by "pages" and showing read/write patterns by vCPUS. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - tweaks for new hwaddr api - add sorting and pagesize selection args v6 - init api update - plugin_outs

[PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PATCH v6 54/54] scripts/checkpatch.pl: don't complain about (foo, /* empty */)

It's quite common to have a mini comment inside braces to acknowledge we know it's empty. Expand the inline detection to allow closing braces before the end of line. Signed-off-by: Alex Bennée --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 04/23] iotests: Filter $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/common.filter | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 9f418b4881..0ee6042524 100644 ---

[PATCH 1/2] hw/timer/grlib_gptimer.c: Switch to transaction-based ptimer API

Switch the grlib_gptimer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PATCH 1/8] hw/timer/puv3_ost.c: Switch to transaction-based ptimer API

Switch the puv3_ost code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

[PATCH v6 34/54] translator: inject instrumentation from plugins

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - note we can't inject instrumentation if ! DISAS_NEXT --- accel/tcg/translator.c | 20 1 file changed, 20 insertions(+) diff --git

Re: [QEMU][PATCH v2] ssi: xilinx_spips: Skip update of cs and fifo releated to spips in gqspi

Hi Sai, On [2019 Oct 17] Thu 15:47:54, Sai Pavan Boddu wrote: > GQSPI handles chip selects and fifos in a different way compared to > spips. So skip update of cs and fifos related to spips in gqspi mode. > > Signed-off-by: Sai Pavan Boddu > --- > Changes for V2: > Just skip update of spips

[PATCH v2 06/23] iotests/083: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- tests/qemu-iotests/083 | 6 +++--- tests/qemu-iotests/083.out | 34 +- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotests/083

[PATCH v6 22/54] translator: add translator_ld{ub,sw,uw,l,q}

From: "Emilio G. Cota" We don't bother with replicating the fast path (tlb_hit) of the old cpu_ldst helpers as it has no measurable effect on performance. This probably indicates we should consider flattening the whole set of helpers but that is out of scope for this change. Suggested-by:

[PATCH v2 12/23] iotests/183: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- tests/qemu-iotests/183 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index 04fb344d08..bced83fae0 100755 --- a/tests/qemu-iotests/183 +++

[PATCH v2 11/23] iotests/182: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- tests/qemu-iotests/182 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182 index 7f494eb9bb..1ccb850055 100755 --- a/tests/qemu-iotests/182 +++

[PATCH v2 18/23] iotests/209: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/209 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 index 259e991ec6..e0f464bcbe 100755 --- a/tests/qemu-iotests/209 +++ b/tests/qemu-iotests/209 @@

[PATCH v2 14/23] iotests/194: Create sockets in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/194 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194 index d746ab1e21..72e47e8833 100755 --- a/tests/qemu-iotests/194 +++ b/tests/qemu-iotests/194 @@

[PATCH v2 17/23] iotests/208: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/208 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208 index 1e202388dc..546eb1de3e 100755 --- a/tests/qemu-iotests/208 +++ b/tests/qemu-iotests/208 @@ -26,7

[PATCH v2 00/23] iotests: Add and use $SOCK_DIR

Hi, Perhaps the main reason we cannot run important tests such as 041 in CI is that when they care Unix sockets in $TEST_DIR, the path may become too long to connect to them. To get by this problem, this series lets the check script create a new temporary directory (mktemp -d) and then makes the

QMP netdev_add multiple dnssearch values

Hi, I'm trying to create a user (slirp) interface with several `dnssearch` values using QMP. But every variant I pass can't do that. According to the QAPI schema it should be like: {     "execute": "netdev_add",     "arguments": {         "id": "netdev0",         "type": "user",        

[PATCH v2 20/23] iotests/223: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/223 | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223 index 2ba3d8124b..b5a80e50bb 100755 --- a/tests/qemu-iotests/223 +++

[PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

Sockets should be placed into $SOCK_DIR instead of $TEST_DIR, so remove the $TEST_DIR filter from _filter_nbd. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/common.filter | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter

[PATCH v6 52/54] include/exec: wrap cpu_ldst.h in CONFIG_TCG

This gets around a build problem with --disable-tcg. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/exec/exec-all.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index eadcf29d0c..d85e610e85 100644 ---

[PATCH v6 41/54] linux-user: support -plugin option

From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- linux-user/main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/linux-user/main.c

[PATCH v6 53/54] .travis.yml: add --enable-plugins tests

check-tcg will automatically run the plugins against most TCG tests if it is enabled in the build. We exclude sparc64-linux-user for now as there are pending patches that need to be merged fixing it's fork implementation. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson ---

Re: [PATCH] aspeed: Add an AST2600 eval board

On Thu, 17 Oct 2019 at 07:33, Joel Stanley wrote: > > On Wed, 16 Oct 2019 at 09:08, Cédric Le Goater wrote: > > > > Define the board with 1 GiB of RAM but some boards can have up to 2 > > GiB. > > > > Signed-off-by: Cédric Le Goater > > Reviewed-by: Joel Stanley > > --- > > > > Changes since

Re: [PATCH] target/arm: Fix sign-extension for SMLAL*

On Tue, 15 Oct 2019 at 00:42, Richard Henderson wrote: > > Ping. > > On 9/12/19 11:30 AM, Richard Henderson wrote: > > The 32-bit product should be sign-extended, not zero-extended. > > > > Fixes: ea96b374641b > > Reported-by: Laurent Desnogues > > Signed-off-by: Richard Henderson Applied to

[PATCH v6 45/54] tests/tcg: move "virtual" tests to EXTRA_TESTS

Otherwise clever expanders like the plugins test get unstuck. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/tcg/Makefile.target | 4 +++- tests/tcg/aarch64/Makefile.softmmu-target | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 07/32] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The PIIX4 Southbridge is not used by the PC machine, > but by the Malta board (MIPS). Add a new section to > keep it covered. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Philippe

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 17/10/2019 16.34, Cornelia Huck wrote: > On Thu, 17 Oct 2019 16:21:23 +0200 > Thomas Huth wrote: > >> There is no USB on s390x, so running qemu-system-s390x with >> "-machine ...,usb=on" is certainly wrong. Emit a warning to make >> the users aware of their misconfiguration. >> >>

Re: [PATCH 18/32] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > The Malta board instantiate a PIIX4 chipset doing various > calls. Refactor all those related calls into a single > function: piix4_create(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_malta.c | 47

Re: [PATCH 16/32] piix4: add a mc146818rtc controller as specified in datasheet

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Remove mc146818rtc instanciated in malta board, to not have it twice. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id:

Re: [PATCH v2 2/3] iotests: Include QMP input in .out files

On 10/17/19 7:59 AM, Max Reitz wrote: On 15.10.19 21:35, Eric Blake wrote: We generally include relevant HMP input in .out files, by virtue of the fact that HMP echoes its input. But QMP does not, so we have to explicitly inject it in the output stream, in order to make it easier to read .out

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

Hi Peter, On 10/17/19 3:23 PM, Peter Maydell wrote: Switch the slavio_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init()

Re: [PATCH v19 3/5] ACPI: Add APEI GHES table generation support

On 2019/10/15 22:52, Peter Maydell wrote: > On Tue, 15 Oct 2019 at 15:02, Xiang Zheng wrote: >> >> From: Dongjiu Geng >> >> This patch implements APEI GHES Table generation via fw_cfg blobs. Now >> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, >> we can extend the

Re: [PATCH] aspeed: Add an AST2600 eval board

On Wed, 16 Oct 2019 at 09:08, Cédric Le Goater wrote: > > Define the board with 1 GiB of RAM but some boards can have up to 2 > GiB. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Joel Stanley > --- > > Changes since AST2600 patchset: > > - lowered the RAM size to 1 GiB as it was breaking

Re: [PATCH v9 04/15] hw/i386/pc: replace use of strtol with qemu_strtol in x86_load_linux()

Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> Hi Sergio, >> >> On 10/15/19 1:23 PM, Sergio Lopez wrote: >>> Follow checkpatch.pl recommendation and replace the use of strtol with >>> qemu_strtol in x86_load_linux(). >> >> "with qemu_strtoui" >> >>> >>> Signed-off-by: Sergio

[PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

Switch the altera_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PATCH v6 18/54] *-user: notify plugin of exit

From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- bsd-user/syscall.c | 3 +++ linux-user/exit.c | 1 + 2 files changed, 4 insertions(+) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index

[PATCH v6 29/54] target/alpha: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index a69f58bf65..f7f1ed0f41

[PATCH v6 36/54] plugin: add API symbols to qemu-plugins.symbols

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota [AJB: moved into plugins] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v3 - moved to plugins/ - include qemu_plugin_reset v5 - re-trigger configure if symbols are updated - wrap ld checks inside if static = no ---

[PATCH v2 02/23] iotests.py: Store socket files in $SOCK_DIR

iotests.py itself does not store socket files, but machine.py and qtest.py do. iotests.py needs to pass the respective path to them, and they need to adhere to it. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- python/qemu/machine.py| 15 ---

[PATCH v2 07/23] iotests/140: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- tests/qemu-iotests/140 | 8 tests/qemu-iotests/140.out | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140 index b965b1dd5d..8d2ce5d9e3

[PATCH 6/8] hw/watchdog/etraxfs_timer.c: Switch to transaction-based ptimer API

Switch the etraxfs_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PATCH v6 46/54] tests/tcg: drop test-i386-fprem from TESTS when not SLOW

This is a very slow running test which we only enable explicitly. However having it in the TESTS lists would confuse additional tests like the plugins test which want to run on all currently enabled tests. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson ---

[PATCH v6 26/54] target/i386: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/i386/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index

[PATCH] hw/timer/arm_mptimer.c: Undo accidental rename of arm_mptimer_init()

In commit b01422622b we did an automated rename of the ptimer_init() function to ptimer_init_with_bh(). Unfortunately this caught the unrelated arm_mptimer_init() function. Undo that accidental renaming. Fixes: b01422622b7c7293196fdaf1dbb4f495af44ecf9 Signed-off-by: Peter Maydell ---

[PATCH 8/8] hw/m68k/mcf5208.c: Switch to transaction-based ptimer API

Switch the mcf5208 code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

Re: [RFC 5/5] spapr: Work around spurious warnings from vfio INTx initialization

On 17/10/2019 10:43, Cédric Le Goater wrote: > On 17/10/2019 07:42, David Gibson wrote: >> Traditional PCI INTx for vfio devices can only perform well if using >> an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning >> if an in kernel irqchip is not available. >> >> We usually do

[PATCH v2 13/23] iotests/192: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/192 | 4 ++-- tests/qemu-iotests/192.out | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/192 b/tests/qemu-iotests/192 index 034432272f..d2ba55dd90 100755 ---

[PATCH v6 20/54] cpu: hook plugin vcpu events

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- cpus.c| 10 ++ exec.c| 2 ++ hw/core/cpu.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/cpus.c b/cpus.c index 367f0657c5..cdd2798c0a 100644

[PATCH v2 19/23] iotests/222: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/222 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index 0ead56d574..3f9f934ad8 100644 --- a/tests/qemu-iotests/222 +++ b/tests/qemu-iotests/222 @@ -48,7

Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

Hi Philippe, I've checked and yes, I can make time to review patches. This is part of my current paid work, so when my contract eventually ends I will likely have to step down as reviewer. I'll have notice of that happening some time before, so I can pass that along when it comes. This message

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

On 10/17/19 6:21 AM, Peter Maydell wrote: > Switch the xilinx_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

[PATCH v6 28/54] target/m68k: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 24c1dd3408..fcdb7bc8e4 100644

[PATCH v6 49/54] tests/plugin: add instruction execution breakdown

This gives a break down of instruction classes and individual instruction types. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v5 - add a bitmap guide to the comment ;-) v6 - init api update - merge updates --- tests/plugin/Makefile | 1 + tests/plugin/howvec.c | 352

Re: [PATCH] sphinx: Use separate doctree directories for different builders

On Mon, 14 Oct 2019 at 16:01, Eduardo Habkost wrote: > > sphinx-build is buggy when multiple processes are using the same > doctree directory in parallel. See the 3-year-old Sphinx bug > report at: https://github.com/sphinx-doc/sphinx/issues/2946 > > Instead of avoiding parallel builds or adding

Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE

On Thu, 17 Oct 2019 14:19:22 +0200 David Hildenbrand wrote: > No need to double-check if we have a write. > > Found by Coverity (CID: 1381016). > > Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real") > Cc: Peter Maydell > Signed-off-by: David Hildenbrand > --- >

Re: [PATCH v3 0/10] add failover feature for assigned network devices

On Thu, Oct 17, 2019 at 06:51:54AM -0600, Alex Williamson wrote: On Thu, 17 Oct 2019 12:33:47 +0200 Jens Freimann wrote: On Tue, Oct 15, 2019 at 01:03:17PM -0600, Alex Williamson wrote: >On Fri, 11 Oct 2019 13:20:05 +0200 >Jens Freimann wrote: > >> This is implementing the host side of the

[PATCH v2] Added hardfloat conversion from float32 to float64

Reintroduce float32_to_float64 that was removed here: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg00455.html - nbench test it not actually calling this function at all - SPECS 2006 significat number of tests impoved their runtime, just few of them showed small slowdown

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On Thu, 17 Oct 2019 16:21:23 +0200 Thomas Huth wrote: > There is no USB on s390x, so running qemu-system-s390x with > "-machine ...,usb=on" is certainly wrong. Emit a warning to make > the users aware of their misconfiguration. > > Signed-off-by: Thomas Huth > --- > After a year or two, we

Re: [PATCH 19/32] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Now that we properly refactored the piix4_create() function, let's > move it to hw/isa/piix4.c where it belongs, so it can be reused > on other places. > > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [PATCH 2/8] hw/timer/sh_timer: Switch to transaction-based ptimer API

On 10/17/19 6:28 AM, Peter Maydell wrote: > Switch the sh_timer code away from bottom-half based ptimers to the > new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to

[PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

The interrupt presenters are not reseted today. Extend the sPAPR IRQ backend with a new cpu_intc_reset() handler which will be called by the CPU reset handler. spapr_realize_vcpu() is modified to call the CPU reset only after the the intc presenter has been created. Signed-off-by: Cédric Le

Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support

On 11/10/2019 10.56, Stefan Hajnoczi wrote: > Implement the VIRTIO 1.0 virtio-pci interface. The main change here is > that the register layout is no longer a fixed layout in BAR 0. Instead > we have to iterate of PCI Capabilities to find descriptions of where > various registers are located.

Re: [PATCH 1/2] hw/timer/grlib_gptimer.c: Switch to transaction-based ptimer API

On 10/17/19 3:23 PM, Peter Maydell wrote: Switch the grlib_gptimer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function

Re: [PATCH 3/8] hw/timer/lm32_timer: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the lm32_timer code away from bottom-half based ptimers to the > new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

Re: [PULL 00/23] tcg patch queue

On 10/13/19 3:25 PM, Richard Henderson wrote: > The following changes since commit 9e5319ca52a5b9e84d55ad9c36e2c0b317a122bb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-10-04 18:32:34 +0100) > > are available in the Git repository at: > >

[PATCH 0/4] crypto: improve performance of ciphers in XTS mode

Currently QEMU uses its own XTS cipher mode, however, this has relatively poor performance. Gcrypt now includes its own XTS cipher which is at least x2 faster than what we get with QEMU's on Fedora/RHEL hosts. With gcrypt git master, a further x5-6 speed up is seen. This is essential for QEMU's

[PATCH v6 39/54] plugin: add qemu_plugin_outs helper

Having the plugins grab stdout and spew stuff there is a bit ugly and certainly makes the tests look ugly. Provide a hook back into QEMU which can be redirected as needed. Signed-off-by: Alex Bennée --- v6 - split and move to pre example plugins --- include/qemu/log.h | 1 +

[PATCH v6 48/54] tests/plugin: add a hotblocks plugin

This is a simple plugin to track which translation blocks are call most often. As we don't have a view of the internals of TCG we can only work by the address of the start of the block so we also need to tracks how often the address is translated. As there will be multiple blocks starting at the

[PATCH v6 15/54] tcg: let plugins instrument virtual memory accesses

From: "Emilio G. Cota" To capture all memory accesses we need hook into all the various helper functions that are involved in memory operations as well as the injected inline helper calls. A later commit will allow us to resolve the actual guest HW addresses by replaying the lookup.

[PATCH v6 25/54] target/sh4: fetch code with translator_ld

From: "Emilio G. Cota" There is a small wrinkle with the gUSA instruction. The translator effectively treats a (known) gUSA sequence as a single instruction. For the purposes of the plugin we end up with a long multi-instruction qemu_plugin_insn. If the known sequence isn't detected we shall

[PATCH v2 16/23] iotests/205: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/205 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 index 76f6c5fa2b..4bb2c21e8b 100755 --- a/tests/qemu-iotests/205 +++ b/tests/qemu-iotests/205 @@ -24,7

[PATCH 7/8] hw/m68k/mcf5206.c: Switch to transaction-based ptimer API

Switch the mcf5206 code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

[PATCH v2 03/23] iotests.py: Add @base_dir to FilePaths etc.

Specifying this optional parameter allows creating temporary files in other directories than the test_dir; for example in sock_dir. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v2 08/23] iotests/143: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Thomas Huth --- tests/qemu-iotests/143 | 6 +++--- tests/qemu-iotests/143.out | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/143 b/tests/qemu-iotests/143 index 92249ac8da..f649b36195

[PATCH v6 14/54] atomic_template: add inline trace/plugin helpers

From: "Emilio G. Cota" In preparation for plugin support. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - move common stuff to atomic_common.inc.c - fix ups for widened uint16_t info - drop haddr in helpers - fix wide lines v6 -

Re: [PATCH 0/3] Convert ppc and microblaze devices to new ptimer API

On Thu, 17 Oct 2019 at 14:21, Peter Maydell wrote: > > This patchset converts the devices used by ppc and microblaze > machines to the new ptimer API. (xilinx_timer is used by both, > hence putting both archs in the same patchset). Apologies for the duplicate cover-letter: messed up the

[PATCH v2 21/23] iotests/240: Create socket in $SOCK_DIR

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/240 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/240 b/tests/qemu-iotests/240 index f73bc07d80..8b4337b58d 100755 --- a/tests/qemu-iotests/240 +++ b/tests/qemu-iotests/240 @@

[PATCH v6 32/54] target/xtensa: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/xtensa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index

[PATCH v6 31/54] target/sparc: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index c68bf4a2e4..edc23a7c40

[PATCH v6 16/54] plugins: implement helpers for resolving hwaddr

We need to keep a local per-cpu copy of the data as other threads may be running. Currently we can provide insight as to if the access was IO or not and give the offset into a given device (usually the main RAMBlock). We store enough information to get details such as the MemoryRegion which might

[PATCH v6 17/54] translate-all: notify plugin code of tb_flush

From: "Emilio G. Cota" Plugins might allocate per-TB data that then they get passed each time a TB is executed (via the *userdata pointer). Notify plugin code every time a code cache flush occurs, so that plugins can then reclaim the memory of the per-TB data. Reviewed-by: Alex Bennée

Re: [PULL 33/36] block/backup: use backup-top instead of write notifiers

17.10.2019 15:04, Peter Maydell wrote: > On Thu, 10 Oct 2019 at 12:44, Max Reitz wrote: >> >> From: Vladimir Sementsov-Ogievskiy >> >> Drop write notifiers and use filter node instead. > > Hi; after this change Coverity complains about dead code in > backup_job_create() (CID 1406402): Oops,

  1   2   3   4   5   >