Re: qemu/powernv: coreboot support?

On Sun, Oct 20, 2019 at 08:51:47AM +0200, Cédric Le Goater wrote: > On 20/10/2019 08:28, David Gibson wrote: > > On Sat, Oct 19, 2019 at 11:09:34AM -0500, Marty E. Plummer wrote: > >> On Sat, Oct 19, 2019 at 05:53:12PM +0200, Cédric Le Goater wrote: > >>> On 19/10/2019 17:31, Marty E. Plummer

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

On 18.10.2019 18:02, Max Reitz wrote: > On 18.10.19 14:09, Denis Plotnikov wrote: >> The modification is useful to workaround exclusive file access restrictions, >> e.g. to implement VM migration with shared disk stored on a storage with >> the exclusive file opening model: a destination VM is

RE: [PATCH v4 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

> > > > f9f4cd1..097c953 100644 > > > > --- a/target/i386/kvm.c > > > > +++ b/target/i386/kvm.c > > > > @@ -1811,6 +1811,25 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > > > > kvm_msr_entry_add(cpu, MSR_MTRRphysMask(i), mask); > > > > } > > > > } > > >

[Bug 1846451] Re: K800 keyboard no longer works when attached to a VM

I am bit slow to test, but i just realized that i am still not sure how to test this. My devices are attached using "virsh attach" after system has started. So it seems to me there is no way to test it with libvirt. A global option to restore old behavior would be useful until libvirt starts

Re: [PATCH v1 6/6] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION

On 18.10.19 20:55, Richard Henderson wrote: > On 10/18/19 9:10 AM, David Hildenbrand wrote: >> +/* Isolate the carry to the next doubleword */ >> tcg_gen_andi_i64(dl, th, 1); > > You can remove this now, since the only possible results are 0/1; it was only > our subtract implementation

Re: [PATCH v2 02/20] piix4: Add the Reset Control Register

On 10/21/19 3:25 AM, Li Qiang wrote: Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 2019年10月18日周五 下午9:50写道： From: Hervé Poussineau mailto:hpous...@reactos.org>> The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. Acked-by: Michael S. Tsirkin

[Bug 1847793] Re: qemu 4.1.0 - Corrupt guest filesystem after new vm install

The bug reported here is not about qcow2 metadata corruption, but about guest data corruption (qemu-img check reports a clean image). It’s entirely possible (and I would even say likely) that there are two different causes. We know about two guest data corruptions already (which appeared in

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Hi Max, libcurl 7.65.3-1ubuntu3 and was >7.59 for several releases (more than a year at least) - so there must be something else going on that this triggers now. But never the less with the fix from [1] I can again get it to work successfully. I think I should backport that to our qemu 4.0 in

Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory

On Mon, 21 Oct 2019 at 10:34, Philippe Mathieu-Daudé wrote: > > On 10/21/19 11:22 AM, Peter Maydell wrote: > > On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daudé > > wrote: > >> > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > > > >> hw/arm/virt.c | 2 +- > > > > I think

Re: [PATCH v7 2/9] linux-user/strace: Add print_timezone()

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Suggested-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > v7: tz_minuteswest and tz_dsttime are abi_int -> %d/tswap32 (lvivier) > checkpatch error: > ERROR: storage class should be at the beginning of the declaration >

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Fri, Oct 18, 2019 at 08:51:20AM +, misono.tomoh...@fujitsu.com wrote: > > Doing unshare(CLONE_FS) after thread startup seems safe, though must be > > careful to change the working directory to the root of > > the mount > > *before* starting any threads. > > I think working directry is

Re: qemu/powernv: coreboot support?

On 10/20/19 9:48 PM, Peter Maydell wrote: On Sat, 19 Oct 2019 at 20:24, Marty E. Plummer wrote: Turns out the 'not text' warning came from lists.sr.ht, I wonder why that mailed me. It's just an individual subscribed address that complains, not the qemu mailing list itself. Philippe, did you

Re: [PATCH v7 6/9] linux-user/strace: Add print_sockfd()

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Extract common print_sockfd() from various socket related syscalls. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v6: use another ifdef TARGET_NR_socketcall > --- > linux-user/strace.c | 23 --- > 1 file changed,

Re: [PATCH] vhost-user-scsi: implement handle_output

On Mon, 21 Oct 2019 at 16:00, Felipe Franciosi wrote: > > > > > On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote: > > > > On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote: > >> > >> > >> > >>> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: > >>> > >>> On Fri, 18 Oct 2019 at 01:17, Felipe

Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes

query-machines probes with the "none" machine all other machines. Current code only fixes up the active machine. To be more precise, libvirt probes with "-machine none,accel=kvm:tcg" all other machines. (that's why you won't notice when starting a machine - you will always get "host"

[Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

I believe this was fixed by qemu 4.0 in eoan. ** Changed in: qemu (Ubuntu Eoan) Status: Triaged => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815889 Title:

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

On Fri, Oct 18, 2019 at 11:38:37AM -0500, Michael Roth wrote: > Quoting Dr. David Alan Gilbert (2019-10-18 04:43:52) > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > On 18/10/2019 10:16, Dr. David Alan Gilbert wrote: > > > > * Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: > > > >>

Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

On 10/21/19 9:27 AM, Thomas Huth wrote: On 21/10/2019 00.56, Philippe Mathieu-Daudé wrote: All the codebase calls memory_region_allocate_system_memory() with a NULL 'owner' from the board_init() function. It's a little bit weird that you first changed the owner to NULL in patch 7, just to

Re: [PATCH] error: Fix -msg timestamp default

On 21/10/19 09:03, Markus Armbruster wrote: > In my review, I proposed replacing it by error_guest_name, to avoid > having to get -name parameter "guest" all the time. I included a > revised patch to illustrate. Goes on top of this one. My revised patch > doesn't fully address my review. In

Re: [PATCH v3 03/16] libqos: extend feature bits to 64-bit

On 19/10/2019 08.37, Stefan Hajnoczi wrote: > In VIRTIO 1.0 feature bits changed from 32-bit to 64-bit. (In fact, the > transports allow even more feature bits but nothing uses more than 64 > bits today.) > > Add 64-bit feature bit support to virtio-mmio and virtio-pci. This will > be necessary

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Hi Rod, You don’t need to add anything, but maybe there’s some library missing. --enable-curl should force support and then tell you whether there’s something missing. Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v7 8/9] linux-user/strace: Let print_sockaddr() have a 'last' argument

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > If the format is not the syscall last argument, a comma is append. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Laurent Vivier > --- > checkpatch error: > ERROR: storage class should be at the beginning of the declaration >

Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory

Cc'ing Paolo/David. On 10/21/19 11:39 AM, Peter Maydell wrote: On Mon, 21 Oct 2019 at 10:34, Philippe Mathieu-Daudé wrote: On 10/21/19 11:22 AM, Peter Maydell wrote: On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c

[PATCH 03/30] virtiofsd: Add auxiliary .c's

From: "Dr. David Alan Gilbert" Add most of the non-main .c files we need from upstream a0d713619d4f21e8240ede38eefe6101ea580724 Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/buffer.c | 321 ++ contrib/virtiofsd/fuse_log.c | 40 +++

[PATCH 07/30] virtiofsd: remove mountpoint dummy argument

From: Stefan Hajnoczi Classic FUSE file system daemons take a mountpoint argument but virtiofsd exposes a vhost-user UNIX domain socket instead. The mountpoint argument is not used by virtiofsd but the user is still required to pass a dummy argument on the command-line. Remove the mountpoint

[PATCH 15/30] virtiofsd: Open vhost connection instead of mounting

From: "Dr. David Alan Gilbert" When run with vhost-user options we conect to the QEMU instead via a socket. Start this off by creating the socket. Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/fuse_i.h| 7 ++- contrib/virtiofsd/fuse_lowlevel.c | 53

[PATCH 02/30] virtiofsd: Pull in kernel's fuse.h

From: "Dr. David Alan Gilbert" Pull in fuse.h from the kernel; version 97f9a3c4eee55b0178b518ae7114a6a53372913d Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/fuse_kernel.h | 858 1 file changed, 858 insertions(+) create mode 100644

[PATCH 10/30] virtiofsd: Fix common header and define for QEMU builds

From: "Dr. David Alan Gilbert" All of the fuse files include config.h and define GNU_SOURCE where we don't have either under our build - remove them. Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/buffer.c | 3 --- contrib/virtiofsd/fuse_i.h | 3 +++

[PATCH 19/30] virtiofsd: Start queue threads

From: "Dr. David Alan Gilbert" Start a thread for each queue when we get notified it's been started. Signed-off-by: Dr. David Alan Gilbert fix by: Signed-off-by: Jun Piao Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/fuse_virtio.c | 89 + 1 file

Re: [PATCH 18/21] hw/mips: Let the machine be the owner of the system memory

On Monday, October 21, 2019, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/boston.c| 2 +- > hw/mips/mips_fulong2e.c | 3 ++- > hw/mips/mips_jazz.c | 2 +- > hw/mips/mips_malta.c| 2 +- > hw/mips/mips_mipssim.c | 2 +- >

Re: [PATCH v1 5/6] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION

On 18.10.19 21:11, Richard Henderson wrote: > On 10/18/19 9:10 AM, David Hildenbrand wrote: >> Testing this, there seems to be something messed up. We are dealing with >> unsigned numbers. "Each operand is treated as an unsigned binary integer." >> Let's just implement as written in the PoP: >> >>

RE: [PATCH] vhost-user-scsi: implement handle_output

There is some logic in vhost_user_blk_handle_output() for now, it's not empty as vhost-user-scsi. There should be other issue if it can't start from SeaBIOS. > -Original Message- > From: Felipe Franciosi [mailto:fel...@nutanix.com] > Sent: Monday, October 21, 2019 4:00 PM > To: Yongji

[PATCH v3] yield_until_fd_readable: make it work with any AioContect

Simply use qemu_get_current_aio_context(). Signed-off-by: Dietmar Maurer --- Changelog for v3: - use (IOHandler *) instead of ((void (*)(void *)) - coding style: fix max line length Changelog for v2: - use correct read handler in aio_set_fd_handler (instead of write handler)

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

On Mon, 21 Oct 2019 10:59:56 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 10/8/19 1:33 PM, Igor Mammedov wrote: > > Series cleans up remaining boards that call > > memory_region_allocate_system_memory() > > multiple times, violating interface contract (the function should be called >

Re: [PATCH v7 1/9] linux-user/strace: Display invalid pointer in print_timeval()

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Suggested-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/strace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index

Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes

On 21/10/2019 11.34, David Hildenbrand wrote: > We have to set the default model of all machine classes, not just for > the active one. Otherwise, "query-machines" will indicate the wrong > CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as > "default-cpu-type". > > Doing a >

Re: [PATCH v7 7/9] linux-user/strace: Improve bind() output

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > --- > v6: use TARGET_NR_socketcall || TARGET_NR_bind (lvivier) > --- > linux-user/strace.c| 15 ++- > linux-user/strace.list | 2 +- > 2 files changed,

Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes

On 21.10.19 11:52, Thomas Huth wrote: On 21/10/2019 11.34, David Hildenbrand wrote: We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as

[PATCH v2] s390x/kvm: Set default cpu model for all machine classes

We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". Doing a {"execute":"query-machines"} under KVM now results in

Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK

On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/dma/sparc32_dma.c | 2 +- > hw/net/lance.c | 5 ++--- > hw/net/pcnet-pci.c | 2 +- > hw/net/pcnet.h | 2 +- > 4 files changed, 5 insertions(+), 6 deletions(-) I feel like

Re: [PATCH 18/21] hw/mips: Let the machine be the owner of the system memory

On Monday, October 21, 2019, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 10/21/19 8:25 AM, Aleksandar Markovic wrote: > >> >> >> On Monday, October 21, 2019, Philippe Mathieu-Daudé > > wrote: >> >> Signed-off-by: Philippe Mathieu-Daudé >

[PATCH 00/30] virtiofs daemon (base)

From: "Dr. David Alan Gilbert" Hi, This is the 1st set for the virtiofsd - a daemon that implements the user space side of virtiofs. The kernel and qemu device parts recently went in, so the daemon is the only thing missing to have a working set. This set is the absolute minimal base set

[PATCH v2 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for

[PATCH 13/30] virtiofsd: Add options for virtio

From: "Dr. David Alan Gilbert" Add options to specify parameters for virtio-fs paths, i.e. ./virtiofsd -o vhost_user_socket=/tmp/vhostqemu Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/fuse_i.h| 1 + contrib/virtiofsd/fuse_lowlevel.c | 10 +++---

[PATCH 21/30] virtiofsd: Start reading commands from queue

From: "Dr. David Alan Gilbert" Pop queue elements off queues, copy the data from them and pass that to fuse. Note: 'out' in a VuVirtqElement is from QEMU 'in' in libfuse is into the daemon So we read from the out iov's to get a fuse_in_header When we get a kick we've got to read

Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

On 21/10/2019 00.56, Philippe Mathieu-Daudé wrote: > All the codebase calls memory_region_allocate_system_memory() with > a NULL 'owner' from the board_init() function. It's a little bit weird that you first changed the owner to NULL in patch 7, just to change the type of the parameter here and

Re: [PATCH 17/21] hw/m68k: Let the machine be the owner of the system memory

On 21/10/2019 00.56, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/m68k/an5206.c| 2 +- > hw/m68k/mcf5208.c | 2 +- > hw/m68k/next-cube.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c >

Re: [PATCH] vhost-user-scsi: implement handle_output

> On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote: > > On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote: >> >> >> >>> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: >>> >>> On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: Originally, vhost-user-scsi did not implement

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 18, 2019 at 10:43:52AM +0100, Dr. David Alan Gilbert wrote: > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > On 18/10/2019 10:16, Dr. David Alan Gilbert wrote: > > > > * Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: > > >

Re: [PATCH v5 3/3] tests/vm/netbsd: Disable IPv6

On 18/10/2019 20.17, Eduardo Habkost wrote: > Workaround for issues when the host has no IPv6 connectivity. > > Signed-off-by: Eduardo Habkost > --- > tests/vm/netbsd | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/vm/netbsd b/tests/vm/netbsd > index

Re: [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board

On 10/21/19 12:56 AM, Philippe Mathieu-Daudé wrote: The SDRAM is incorrectly created in the Tyohoon northbridge ASIC. Move its creation in the board code, this will later allow the board to have the QOM ownership of the RAM. Signed-off-by: Philippe Mathieu-Daudé --- checkpatch complains:

Re: [PATCH 00/21] hw: Let the machine be the owner of the system memory

On 10/21/19 12:56 AM, Philippe Mathieu-Daudé wrote: Hi, This series is based on Igor's "eliminate remaining places that abuse memory_region_allocate_system_memory()": https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01601.html It is quite simple, we enforce all machines to be the QOM

Re: [PATCH v7 4/9] linux-user/syscall: Introduce target_sockaddr_nl

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > --- > v7: use abi_ushort and abi_uint to keep alignments good (lvivier) > --- > linux-user/syscall.c | 6 -- > linux-user/syscall_defs.h | 7 +++ > 2 files

[PATCH v2 6/6] iotests: Remove 130 from the "auto" group

Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" error with 130 already twice. Looks like this test is a little bit shaky, so for the time being, let's disable it from the "auto" group so that it does not

Re: [PATCH v4 0/11] add failover feature for assigned network devices

On Sat, Oct 19, 2019 at 08:12:27AM -0700, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191018202040.30349-1-jfreim...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker

[PATCH v2 1/6] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD

We have to read from odd offsets. Fixes: 2bf3ee38f1f8 ("s390x/tcg: Implement VECTOR MULTIPLY *") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/vec_int_helper.c

[PATCH v2 2/6] s390x/tcg: Fix VECTOR MULTIPLY AND ADD *

We missed that we always read a "double-wide even-odd element pair of the fourth operand". Fix it in all four variants. Fixes: 1b430aec4157 ("s390x/tcg: Implement VECTOR MULTIPLY AND ADD *") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 8

Re: [PATCH v3 01/16] tests/virtio-blk-test: read config space after feature negotiation

On 19/10/2019 08.37, Stefan Hajnoczi wrote: > The VIRTIO Configuration Space cannot be accessed before device feature > bits have been read because a driver doesn't know the endianness until > it has checked VIRTIO_F_VERSION_1. > > Fix this problem in preparation for VIRTIO 1.0 support. > >

Re: [PATCH] Fix unsigned integer underflow in fd-trans.c

Le 18/10/2019 à 02:19, Shu-Chun Weng a écrit : > In any of these `*_for_each_*` functions, the last entry in the buffer (so the > "remaining length in the buffer" `len` is equal to the length of the > entry `nlmsg_len`/`nla_len`/etc) has size that is not a multiple of the > alignment, the aligned

Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory

On 10/21/19 11:22 AM, Peter Maydell wrote: On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 2 +- I think from a quick code scan that this is ok, but did you test that migration compat from old to new

Re: [PATCH v7 5/9] linux-user/strace: Dump AF_NETLINK sockaddr content

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > --- > linux-user/strace.c | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/linux-user/strace.c b/linux-user/strace.c >

Re: [RFC PATCH v7 9/9] linux-user/syscall: Align target_sockaddr fields using ABI types

Le 15/09/2019 à 23:39, Philippe Mathieu-Daudé a écrit : > Target architectures align types differently for instance > m68k aligns on 16bit whereas others on 32bit). > Use ABI types to keep alignments good. > > Suggested-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC: Is

Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes

On 21/10/2019 11.54, David Hildenbrand wrote: > On 21.10.19 11:52, Thomas Huth wrote: >> On 21/10/2019 11.34, David Hildenbrand wrote: >>> We have to set the default model of all machine classes, not just for >>> the active one. Otherwise, "query-machines" will indicate the wrong >>> CPU model

Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage

On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau wrote: > > etraxfs_dma_client are not Object, so can't be exposed to user with > QOM path. Let's remove property usage and move the constructor to the > .c unit, simplifying some code on the way. > > Signed-off-by: Marc-André Lureau > +/*

Re: [PATCH] vhost-user-scsi: implement handle_output

On Mon, 21 Oct 2019 at 16:20, Liu, Changpeng wrote: > > There is some logic in vhost_user_blk_handle_output() for now, it's not empty > as vhost-user-scsi. > There should be other issue if it can't start from SeaBIOS. > No, it's the same issue. We can see the notify is triggered from the

[PATCH v2 1/6] iotests: remove 'linux' from default supported platforms

From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH v2 3/6] iotests: Test 183 does not work on macOS and OpenBSD

When running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it fails with an "Timeout waiting for return on handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth ---

[PATCH v2 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

The next patch is going to add some python-based tests to the "auto" group, and these tests require virtio-blk to work properly. Running iotests without virtio-blk likely does not make too much sense anyway, so instead of adding a check for the availability of virtio-blk to each and every test

[PATCH v2 2/6] iotests: Test 041 only works on certain systems

041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 16/30] virtiofsd: Start wiring up vhost-user

From: "Dr. David Alan Gilbert" Listen on our unix socket for the connection from QEMU, when we get it initialise vhost-user and dive into our own loop variant (currently dummy). Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/fuse_i.h | 4 ++

[PATCH 08/30] virtiofsd: remove unused notify reply support

From: Stefan Hajnoczi Notify reply support is unused by virtiofsd. The code would need to be updated to validate input buffer sizes. Remove this unused code since changes to it are untestable. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/fuse_lowlevel.c | 142

[PATCH v2 0/6] s390x/tcg: Vector instruction fixes

Ivan reported that a simple $ go get -v -d github.com/FactomProject/factom Will result in errors when vector instructions are in use. Turns out golang makes excessive use of vector instructions, e.g., for crypto, hashes but also basic math. I tracked the involved vector instructions and

[PATCH v2 3/6] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE

We forgot to propagate the highest bit accross the high doubleword in two cases (shift >=64). Fixes: 5f724887e3dd ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 6 -- 1 file changed,

Re: [PATCH v3 02/16] libqos: read QVIRTIO_MMIO_VERSION register

On 19/10/2019 08.37, Stefan Hajnoczi wrote: > There was no real virtio-mmio ABI change between Legacy and VIRTIO 1.0 > except that the Version field was incremented from 1 to 2. > > However, QEMU does not allow Legacy drivers to perform VIRTIO 1.0 > operations like accessing 64-bit feature bits.

Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory

On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c | 2 +- I think from a quick code scan that this is ok, but did you test that migration compat from old to new still works? I vaguely recall that there are

[PATCH v1] s390x/kvm: Set default cpu model for all machine classes

We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". Doing a {"execute":"query-machines"} under KVM now results in

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Hi Christian, I don’t see any issue but the fact that the whole series should be backported (0487861685294660b23bc146e1ebd5304aa8bbe0 through bfb23b480a49114315877aacf700b49453e0f9d9, maybe also c34dc07f9f01cf686, but that isn’t strictly necessary). Max -- You received this bug notification

Re: [PATCH 02/14] vmmouse: replace PROP_PTR with PROP_LINK

On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau wrote: > > While at it, use the expected type. > > Signed-off-by: Marc-André Lureau > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 12/30] virtiofsd: Make fsync work even if only inode is passed in

From: Vivek Goyal If caller has not sent file handle in request, then using inode, retrieve the fd opened using O_PATH and use that to open file again and issue fsync. This will be needed when dax_flush() calls fsync. At that time we only have inode information (and not file). Signed-off-by:

[PATCH 06/30] virtiofsd: Trim down imported files

From: "Dr. David Alan Gilbert" There's a lot of the original fuse code we don't need; trim them down. Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/fuse_i.h| 22 - contrib/virtiofsd/fuse_loop_mt.c | 308 -- contrib/virtiofsd/fuse_lowlevel.c | 653

[PATCH 23/30] virtiofsd: Keep track of replies

From: "Dr. David Alan Gilbert" Keep track of whether we sent a reply to a request; this is a bit paranoid but it means: a) We should always recycle an element even if there was an error in the request b) Never try and send two replies on one queue element Signed-off-by: Dr. David Alan

[PATCH 09/30] virtiofsd: Fix fuse_daemonize ignored return values

From: "Dr. David Alan Gilbert" QEMU's compiler enables warnings/errors for ignored values and the (void) trick used in the fuse code isn't enough. Turn all the return values into a return value on the function. Signed-off-by: Dr. David Alan Gilbert --- contrib/virtiofsd/helper.c | 25

[PATCH 29/30] virtiofsd: add --print-capabilities option

From: Stefan Hajnoczi Add the --print-capabilities option as per vhost-user.rst "Backend programs conventions". Currently there are no advertised features. Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-André Lureau --- contrib/virtiofsd/fuse_lowlevel.h | 1 + contrib/virtiofsd/helper.c

Re: [PATCH 18/21] hw/mips: Let the machine be the owner of the system memory

On 10/21/19 12:56 PM, Aleksandar Markovic wrote: On Monday, October 21, 2019, Philippe Mathieu-Daudé > wrote: Hi Aleksandar, On 10/21/19 8:25 AM, Aleksandar Markovic wrote: On Monday, October 21, 2019, Philippe Mathieu-Daudé

[Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

** Changed in: mesa (Ubuntu) Status: Triaged => In Progress ** Changed in: mesa (Ubuntu) Milestone: ubuntu-19.04 => None -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815889 Title:

[PATCH v8 8/9] linux-user/strace: Let print_sockaddr() have a 'last' argument

If the format is not the syscall last argument, a comma is append. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- v8: do not name prototype arguments checkpatch error: ERROR: storage class should be at the beginning of the declaration #10: FILE: linux-user/strace.c:70:

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

On 19/10/2019 08.38, Stefan Hajnoczi wrote: > According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device > Initialization", configuration space and virtqueues cannot be accessed > before features have been negotiated. Enforce this requirement. > > Signed-off-by: Stefan Hajnoczi > --- >

Re: [PATCH 01/11] qdev/qbus: add hidden device support

On Fri, 18 Oct 2019 22:20:30 +0200 Jens Freimann wrote: > This adds support for hiding a device to the qbus and qdev APIs. The > first user of this will be the virtio-net failover feature but the API > introduced with this patch could be used to implement other features as > well, for example

Re: [PATCH v7 3/3] target/ppc: Optimize emulation of vupkhpx and vupklpx instructions

Hello Aleksandar, Thank you for taking a look at this patch. I will start working on a version 8 of the patch where I will address all your suggestions. Kind Regards, Stefan On 19.10.19. 22:40, Aleksandar Markovic wrote: On Thursday, October 17, 2019, Stefan Brankovic

Re: [PATCH 0/9] ppc/pnv: XIVE cleanup and fixes

On 07/10/2019 10:40, Cédric Le Goater wrote: > Hello, > > Here is a short series adding the cleanups and fixes of the bigger > series "ppc/pnv: add XIVE support for KVM guests". There is still some > rework to be done on the XivePresenter before it can be resent. > > These are valuable changes

Re: [PATCH v8 8/9] linux-user/strace: Let print_sockaddr() have a 'last' argument

Le 21/10/2019 à 13:48, Philippe Mathieu-Daudé a écrit : > If the format is not the syscall last argument, a comma is append. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Laurent Vivier > --- > v8: do not name prototype arguments > > checkpatch error: > ERROR: storage class should

Re: [PATCH v3 15/16] libqos: extract Legacy virtio-pci.c code

On 10/19/19 8:38 AM, Stefan Hajnoczi wrote: The current libqos virtio-pci.c code implements the VIRTIO Legacy interface. Extract existing code in preparation for VIRTIO 1.0 support. Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Reviewed-by: Thomas Huth ---

Re: [PATCH 01/11] qdev/qbus: add hidden device support

On Mon, Oct 21, 2019 at 01:53:58PM +0100, Peter Maydell wrote: On Fri, 18 Oct 2019 at 21:22, Jens Freimann wrote: This adds support for hiding a device to the qbus and qdev APIs. The first user of this will be the virtio-net failover feature but the API introduced with this patch could be

[PATCH 0/5] ppc/pnv: Add PNOR support

Hello, On a POWERPC PowerNV system, the host firmware is stored in a PNOR flash chip which contents is mapped on the LPC bus. This model adds a simple dummy device to map the contents of a block device in the host address space and activates HIOMAP support on the QEMU PowerNV machine to let the

[PATCH 1/5] ppc/pnv: Add a PNOR model

From: Cédric Le Goater On a POWERPC PowerNV system, the host firmware is stored in a PNOR flash chip which contents is mapped on the LPC bus. This model adds a simple dummy device to map the contents of a block device in the host address space. Signed-off-by: Cédric Le Goater ---

[PATCH 5/5] ppc/pnv: Read the PNOR partition table

From: Cédric Le Goater This patch adds the logic to read the partition table of a PNOR file and a routine to load the PAYLOAD (skiboot) partition in the machine memory. Code based on the libflash of skiboot: https://github.com/open-power/skiboot/blob/master/libflash/ Signed-off-by: Cédric

Re: [PATCH v8 1/9] linux-user/strace: Display invalid pointer in print_timeval()

Le 21/10/2019 à 13:48, Philippe Mathieu-Daudé a écrit : > Suggested-by: Laurent Vivier > Reviewed-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/strace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/linux-user/strace.c

Re: [PATCH v8 2/9] linux-user/strace: Add print_timezone()

Le 21/10/2019 à 13:48, Philippe Mathieu-Daudé a écrit : > Suggested-by: Laurent Vivier > Reviewed-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > v7: tz_minuteswest and tz_dsttime are abi_int -> %d/tswap32 (lvivier) > > checkpatch error: > ERROR: storage class should be at

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > From: "Denis V. Lunev" > > Linux guests submit IO requests no longer than PAGE_SIZE * max_seg > field reported by SCSI controler. Thus typical sequential read with > 1 MB size results in the following pattern of the IO from the

Re: [PATCH v8 8/9] linux-user/strace: Let print_sockaddr() have a 'last' argument

Le 21/10/2019 à 13:48, Philippe Mathieu-Daudé a écrit : > If the format is not the syscall last argument, a comma is append. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Laurent Vivier > --- > v8: do not name prototype arguments > > checkpatch error: > ERROR: storage class should

  1   2   3   4   >