Re: [PATCH v8 7/8] bootdevice: FW_CFG interface for LCHS values

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being

Re: [PATCH v8 6/8] bootdevice: Refactor get_boot_devices_list

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by:

Re: [PATCH v2 5/6] block/block-copy: add memory limit

2019-10-22 Thread Max Reitz
On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote: > Currently total allocation for parallel requests to block-copy instance > is unlimited. Let's limit it to 128 MiB. > > For now block-copy is used only in backup, so actually we limit total > allocation for backup job. > > Signed-off-by:

Re: [PATCH v8 5/8] bootdevice: Gather LCHS from all relevant devices

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not

Re: [PATCH v6 0/9] target/arm/kvm: enable SVE in guests

2019-10-22 Thread Peter Maydell
On Mon, 21 Oct 2019 at 17:18, Peter Maydell wrote: > > On Mon, 21 Oct 2019 at 17:12, Andrew Jones wrote: > > > > On Mon, Oct 21, 2019 at 04:43:22PM +0100, Peter Maydell wrote: > > > On Mon, 21 Oct 2019 at 15:23, Andrew Jones wrote: > > > > Peter, would you mind running your test on the kvm32

Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

2019-10-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019 Type: series

Re: [PATCH 21/30] virtiofsd: Start reading commands from queue

2019-10-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Mon, Oct 21, 2019 at 1:09 PM Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Pop queue elements off queues, copy the data from them and > > pass that to fuse. > > > > Note: 'out' in a

Re: [PATCH v2 4/6] util: introduce SharedResource

2019-10-22 Thread Max Reitz
On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote: > Introduce an API for some shared splittable resource, like memory. > It's going to be used by backup. Backup uses both read/write io and > copy_range. copy_range may consume memory implictly, so the new API is > abstract: it doesn't allocate

Re: [PATCH v8 3/8] bootdevice: Add interface to gather LCHS

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman

Re: [PATCH v8 4/8] scsi: Propagate unrealize() callback to scsi-hd

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Andrey Shinkevich
On 22/10/2019 12:28, Max Reitz wrote: > On 20.10.19 22:37, Andrey Shinkevich wrote: >> To inform the block layer about writing all the data compressed, we >> introduce the 'compress' command line option. Based on that option, the >> written data will be aligned by the cluster size at the generic

Re: [PATCH v8 2/8] block: Support providing LCHS from user

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 6:41 PM, Sam Eiderman wrote: From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci

Re: [PATCH] runstate: ignore exit request in finish migrate state

2019-10-22 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 17/10/19 12:18, Laurent Vivier wrote: > > Trying to reboot a VM while a migration is running can > > move to the prelaunch state (because of the reset) while > > the runstate is in finish migrate state. > > As the logical step after the finish

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 11:53 AM, Aleksandar Markovic wrote: On Friday, October 18, 2019, Philippe Mathieu-Daudé > wrote: From: Hervé Poussineau mailto:hpous...@reactos.org>> Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove

[PULL 8/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand The numbers are unsigned, the computation is wrong. "Each operand is treated as an unsigned binary integer". Let's implement as given in the PoP: "A subtraction is performed by adding the contents of the second operand with the bitwise complement of the third operand

[PULL 6/9] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand Looks like my idea of what a "borrow" is was wrong. The PoP says: "If the resulting subtraction results in a carry out of bit zero, a value of one is placed in the corresponding element of the first operand; otherwise, a value of zero is placed in the corresponding

Re: [PATCH v2 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 7:54 AM, Sven Schnelle wrote: From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 +-

[PULL 5/9] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand We forgot to propagate the highest bit accross the high doubleword in two cases (shift >=64). Fixes: 5f724887e3dd ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id:

[PULL 3/9] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand We have to read from odd offsets. Fixes: 2bf3ee38f1f8 ("s390x/tcg: Implement VECTOR MULTIPLY *") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20191021085715.3797-2-da...@redhat.com> Signed-off-by: Cornelia Huck ---

Re: [PATCH 11/30] virtiofsd: fuse: Make iov_length usable outside fuse_lowlevel.c

2019-10-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Mon, Oct 21, 2019 at 1:24 PM Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > Similar function already exists in util/iov.c, iov_size() > >

[PULL 9/9] s390x/kvm: Set default cpu model for all machine classes

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". Doing a {"execute":"query-machines"} under KVM

[PULL 4/9] s390x/tcg: Fix VECTOR MULTIPLY AND ADD *

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand We missed that we always read a "double-wide even-odd element pair of the fourth operand". Fix it in all four variants. Fixes: 1b430aec4157 ("s390x/tcg: Implement VECTOR MULTIPLY AND ADD *") Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id:

[PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand No need to double-check if we have a write. Found by Coverity (CID: 1406404). Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real") Cc: Peter Maydell Signed-off-by: David Hildenbrand Message-Id: <20191017121922.18840-1-da...@redhat.com>

[PULL 7/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION

2019-10-22 Thread Cornelia Huck
From: David Hildenbrand Testing this, there seems to be something messed up. We are dealing with unsigned numbers. "Each operand is treated as an unsigned binary integer." Let's just implement as written in the PoP: "A subtraction is performed by adding the contents of the second operand with

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Aleksandar Markovic
On Friday, October 18, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() function. > >

[PULL 0/9] more s390x fixes

2019-10-22 Thread Cornelia Huck
The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 14:13:11 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20191022

[PULL 1/9] s390x/cpumodel: Add missing visit_free

2019-10-22 Thread Cornelia Huck
From: Andrew Jones Beata Michalska noticed this missing visit_free() while reviewing arm's implementation of qmp_query_cpu_model_expansion(), which is modeled off this s390x implementation. Signed-off-by: Andrew Jones Message-Id: <20191016145434.7007-1-drjo...@redhat.com> Reviewed-by: David

Re: [PATCH v2 3/6] block/block-copy: refactor copying

2019-10-22 Thread Max Reitz
On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote: > Merge copying code into one function block_copy_do_copy, which only > calls bdrv_ io functions and don't do any synchronization (like dirty > bitmap set/reset). > > Refactor block_copy() function so that it takes full decision about > size

Re: [PATCH v3 1/4] spapr: move CPU reset after presenter creation

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 09:22:43 +0200 Cédric Le Goater wrote: > spapr_realize_vcpu() is modified to call the CPU reset only after the > the intc presenter has been created. > Maybe indicate why this change is needed ? Anyway, Reviewed-by: Greg Kurz > Signed-off-by: Cédric Le Goater > --- >

Re: [PATCH v2 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 7:54 AM, Sven Schnelle wrote: HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and

Re: [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls

2019-10-22 Thread Artyom Tarasenko
On Tue, Oct 22, 2019 at 1:23 AM Alistair Francis wrote: > > On Sun, Oct 20, 2019 at 4:10 PM Philippe Mathieu-Daudé > wrote: > > > > All the memory_region_allocate_system_memory() calls are in the > > board_init() code. From the 58 calls in the repository, only > > 4 set the 'owner' parameter.

Re: [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > We will move this code, fix its style first. > > Reviewed-by: Aleksandar Markovic > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/piix.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 09:52, Esteban Bosse wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > > +static void piix4_request_i8259_irq(void *opaque, int irq, int > > level) > > +{ > > +PIIX4State *s = opaque; > > +qemu_set_irq(s->cpu_intr, level); > > +} >

Re: [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create()

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > Extract the PIIX3 creation code from the i440fx_init() function. > > Reviewed-by: Aleksandar Markovic > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/piix.c | 51 -- >

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 10:44 AM, Esteban Bosse wrote: El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: From: Hervé Poussineau Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also

Re: [PULL 00/12] QAPI patches for 2019-10-22

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 09:11, Markus Armbruster wrote: > > The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 > 14:13:11 +0100) > > are available in the Git

[Bug 1849234] Re: Macos Catalina bug

2019-10-22 Thread Peter Maydell
*** This bug is a duplicate of bug 1847906 *** https://bugs.launchpad.net/bugs/1847906 ** This bug has been marked a duplicate of bug 1847906 Cocoa display hangs on macOS 10.15 (Catalina) -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 20.10.19 22:37, Andrey Shinkevich wrote: > To inform the block layer about writing all the data compressed, we > introduce the 'compress' command line option. Based on that option, the > written data will be aligned by the cluster size at the generic layer. > > Suggested-by: Roman Kagan >

Re: [PATCH v5 4/4] tests/qemu-iotests: add case for block-stream compress

2019-10-22 Thread Max Reitz
On 20.10.19 22:37, Andrey Shinkevich wrote: > Add a case to the iotest #030 that tests the 'compress' option for a > block-stream job. > > Signed-off-by: Andrey Shinkevich > --- > tests/qemu-iotests/030 | 34 +- > tests/qemu-iotests/030.out | 4 ++-- > 2

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 10:48 AM, Esteban Bosse wrote: El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: From: Hervé Poussineau Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also

Re: [Qemu-devel] [PATCH v8 05/37] target/mips: Add support for emulation of CRC32 group of instructions

2019-10-22 Thread Aleksandar Markovic
On Monday, August 19, 2019, Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Yongbok Kim > > Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. > Reuse zlib crc32() and Linux crc32c(). Note that, at the time being, > there is no MIPS CPU that supports CRC32

Re: [PATCH v4] qga: add command guest-get-devices for reporting VirtIO devices

2019-10-22 Thread Tomáš Golembiovský
Ping, Michael, would be nice if we could get this in 4.2. Tomas On Wed, Sep 25, 2019 at 11:03:58PM +0200, Tomáš Golembiovský wrote: > Add command for reporting devices on Windows guest. The intent is not so > much to report the devices but more importantly the driver (and its > version) that

Re: [PATCH v3 3/4] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Philippe Mathieu-Daudé
Hi Cédric, On 10/22/19 9:22 AM, Cédric Le Goater wrote: On the sPAPR machine and PowerNV machine, the interrupt presenters are created by a machine handler at the core level and are reseted Typo "reset" independently. This is not consistent and it raises issues when it comes to handle

Re: [PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Remove i8257 instantiated in malta board, to not have it twice. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id:

Re: [PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Other piix4 parts are already named piix4-ide and piix4-usb-uhci. > > Reviewed-by: Philippe Mathieu-Daudé > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé

Re: [PATCH v3 2/4] spapr_cpu_core: Implement DeviceClass::reset

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 9:22 AM, Cédric Le Goater wrote: From: Greg Kurz Since vCPUs aren't plugged into a bus, we manually register a reset handler for each vCPU. We also call this handler at realize time to ensure hot plugged vCPUs are reset before being exposed to the guest. This results in vCPUs being

Re: [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()"

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Philippe Mathieu-Daudé > > This function isn't used anymore. > > This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92. > > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v3 1/4] spapr: move CPU reset after presenter creation

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 9:22 AM, Cédric Le Goater wrote: spapr_realize_vcpu() is modified to call the CPU reset only after the the intc presenter has been created. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_cpu_core.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init()

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Dr. David Alan Gilbert
* yezhenyu (A) (yezhen...@huawei.com) wrote: > Since qemu2.9, QEMU added three AioContext poll parameters to struct > IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are > used to control iothread polling time. > > However, there isn't properly hmp commands to adjust them when

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-10-22 Thread Philippe Mathieu-Daudé
tags/qemu-slof-20191022 for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc: pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1100) Alexey Kardashevskiy (1): pseries: Update SLOF firmware

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init()

Re: [PATCH] Semihost SYS_READC implementation

2019-10-22 Thread Paolo Bonzini
On 22/10/19 05:13, Keith Packard wrote: > Provides a blocking call to read a character from the console by hooking > into the console input chain. This happens *after* any uart has hooked in, > so specifying -semihost overrides input to any emulated uarts. > > Signed-off-by: Keith Packard I'm a

[PULL 2/2] tests/migration: fix a typo in comment

2019-10-22 Thread Laurent Vivier
From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1d0aa8142a10edf735dac0a3330c46e98b06e8eb.1570208781.git.maozhon...@cmss.chinamobile.com> Signed-off-by: Laurent Vivier ---

Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information

2019-10-22 Thread Tao Xu
On 10/22/2019 3:08 PM, Igor Mammedov wrote: On Sun, 20 Oct 2019 19:11:19 +0800 Tao Xu wrote: From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information

[PULL 1/2] qemu-doc: Remove paragraph about requiring a HD image with -kernel

2019-10-22 Thread Laurent Vivier
From: Thomas Huth The need for specifying "-hda" together with "-kernel" has been removed in commit 57a46d057995 ("Convert linux bootrom to external rom and fw_cfg"), almost 10 years ago, so let's remove this description from our documentation now, too. Signed-off-by: Thomas Huth Reviewed-by:

[PULL 0/2] Trivial branch patches

2019-10-22 Thread Laurent Vivier
The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 14:13:11 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[PULL 02/11] Fix unsigned integer underflow in fd-trans.c

2019-10-22 Thread Laurent Vivier
From: Shu-Chun Weng In any of these `*_for_each_*` functions, the last entry in the buffer (so the "remaining length in the buffer" `len` is equal to the length of the entry `nlmsg_len`/`nla_len`/etc) has size that is not a multiple of the alignment, the aligned lengths `*_ALIGN(*_len)` will be

[RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread yezhenyu (A)
Since qemu2.9, QEMU added three AioContext poll parameters to struct IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are used to control iothread polling time. However, there isn't properly hmp commands to adjust them when the VM is alive. It's useful to adjust them online when

[PULL 01/11] linux-user: add strace for dup3

2019-10-22 Thread Laurent Vivier
From: Andreas Schwab Signed-off-by: Andreas Schwab Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier --- linux-user/strace.list | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/strace.list b/linux-user/strace.list index 63a946642d29..863283418ef9

[PULL 05/11] linux-user/strace: Improve settimeofday()

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier Message-Id: <20191021114857.20538-4-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c| 13 + linux-user/strace.list | 2 +- 2 files

[PULL 09/11] linux-user/strace: Improve bind() output

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191021114857.20538-8-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c| 15 ++- linux-user/strace.list | 2 +- 2 files

[PULL 11/11] linux-user/syscall: Align target_sockaddr fields using ABI types

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Target architectures align types differently for instance m68k aligns on 16bit whereas others on 32bit). Use ABI types to keep alignments good. Suggested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id:

[PULL 08/11] linux-user/strace: Add print_sockfd()

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Extract common print_sockfd() from various socket related syscalls. Reviewed-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191021114857.20538-7-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 23

[PULL 10/11] linux-user/strace: Let print_sockaddr() have a 'last' argument

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé If the format is not the syscall last argument, a comma is append. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Reviewed-by: Laurent Vivier Message-Id: <20191021114857.20538-9-f4...@amsat.org> Signed-off-by: Laurent Vivier ---

[PULL 03/11] linux-user/strace: Display invalid pointer in print_timeval()

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Suggested-by: Laurent Vivier Reviewed-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191021114857.20538-2-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PULL 00/11] Linux user for 4.2 patches

2019-10-22 Thread Laurent Vivier
The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 14:13:11 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[PULL 04/11] linux-user/strace: Add print_timezone()

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Suggested-by: Laurent Vivier Reviewed-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20191021114857.20538-3-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 20 1

[PULL 06/11] linux-user/syscall: Introduce target_sockaddr_nl

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191021114857.20538-5-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 6 -- linux-user/syscall_defs.h | 7 +++ 2 files

[PULL 07/11] linux-user/strace: Dump AF_NETLINK sockaddr content

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Tested-By: Guido Günther Reviewed-by: Laurent Vivier Message-Id: <20191021114857.20538-6-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 37 + 1 file changed, 37

Re: [PATCH] runstate: ignore exit request in finish migrate state

2019-10-22 Thread Paolo Bonzini
On 17/10/19 12:18, Laurent Vivier wrote: > Trying to reboot a VM while a migration is running can > move to the prelaunch state (because of the reset) while > the runstate is in finish migrate state. > As the logical step after the finish migrate is postmigrate, > this can create an invalid state

Re: [PATCH] virtio: drop unused virtio_device_stop_ioeventfd() function

2019-10-22 Thread Stefano Garzarella
On Mon, Oct 21, 2019 at 04:03:43PM +0100, Stefan Hajnoczi wrote: > virtio_device_stop_ioeventfd() has not been used since commit > 310837de6c1e0badfd736b1b316b1698c53120a7 ("virtio: introduce > grab/release_ioeventfd to fix vhost") in 2016. > > Nowadays ioeventfd is stopped implicitly by the

[PULL 00/12] QAPI patches for 2019-10-22

2019-10-22 Thread Markus Armbruster
The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 14:13:11 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

[PULL 05/12] qapi: Move gen_enum(), gen_enum_lookup() back to qapi/types.py

2019-10-22 Thread Markus Armbruster
The next commit will split up qapi/common.py. gen_enum() needs QAPISchemaEnumMember, and that's in the way. Move it to qapi/types.py along with its buddy gen_enum_lookup(). Permit me a short a digression on history: how did gen_enum() end up in qapi/common.py? Commit 21cd70dfc1 "qapi script:

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 09.21, Thomas Huth wrote: > As discussed here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html > > and here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html > > it would be good to have some more valuable iotests enabled in the >

Re: qemu/powernv: coreboot support?

2019-10-22 Thread Cédric Le Goater
On 22/10/2019 02:32, Marty E. Plummer wrote: > On Mon, Oct 21, 2019 at 02:46:59PM +0200, Cédric Le Goater wrote: >> On 21/10/2019 07:34, David Gibson wrote: >>> On Sun, Oct 20, 2019 at 08:51:47AM +0200, Cédric Le Goater wrote: On 20/10/2019 08:28, David Gibson wrote: > > Ok. Note

[PULL 08/12] tests/qapi-schema: Tidy up test output indentation

2019-10-22 Thread Markus Armbruster
Command and event details are indented three spaces, everything else four. Messed up in commit 156402e5042. Use four spaces consistently. Signed-off-by: Markus Armbruster Reviewed-by: Peter Krempa Message-Id: <20191018081454.21369-2-arm...@redhat.com> --- tests/qapi-schema/doc-good.out

[PULL 11/12] tests/qapi-schema: Cover feature documentation comments

2019-10-22 Thread Markus Armbruster
Commit 8aa3a33e44 "tests/qapi-schema: Test for good feature lists in structs" neglected to cover documentation comments, and the previous commit followed its example. Make up for them. Signed-off-by: Markus Armbruster Message-Id: <20191018081454.21369-5-arm...@redhat.com> Reviewed-by: Eric

[PULL 10/12] tests: qapi: Test 'features' of commands

2019-10-22 Thread Markus Armbruster
From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20191018081454.21369-4-arm...@redhat.com> --- tests/test-qmp-cmds.c | 24 tests/qapi-schema/qapi-schema-test.json | 18

[PULL 09/12] qapi: Add feature flags to commands

2019-10-22 Thread Markus Armbruster
From: Peter Krempa Similarly to features for struct types introduce the feature flags also for commands. This will allow notifying management layers of fixes and compatible changes in the behaviour of a command which may not be detectable any other way. The changes were heavily inspired by

[PULL 07/12] qapi: Clear scripts/qapi/doc.py executable bits again

2019-10-22 Thread Markus Armbruster
Commit fbf09a2fa4 "qapi: add 'ifcond' to visitor methods" brought back the executable bits. Fix that. Drop the #! line for good measure. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20191018074345.24034-8-arm...@redhat.com> --- scripts/qapi/doc.py | 1 - 1 file

[PULL 01/12] qapi: Don't suppress doc generation without pragma doc-required

2019-10-22 Thread Markus Armbruster
Commit bc52d03ff5 "qapi: Make doc comments optional where we don't need them" made scripts/qapi2texi.py fail[*] unless the schema had pragma 'doc-required': true. The stated reason was inability to cope with incomplete documentation. When commit fb0bc835e5 "qapi-gen: New common driver for code

[PULL 12/12] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-22 Thread Markus Armbruster
From: Peter Krempa 'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With the introduction of -blockdev, the common usage made all nodes including protocol and backing file nodes be monitor-owned and thus considered for snapshot. This is a problem since the

Re: qemu/powernv: coreboot support?

2019-10-22 Thread David Gibson
On Mon, Oct 21, 2019 at 09:17:55PM -0500, Marty E. Plummer wrote: > On Tue, Oct 22, 2019 at 12:40:32PM +1100, David Gibson wrote: > > On Mon, Oct 21, 2019 at 07:32:09PM -0500, Marty E. Plummer wrote: > > > On that note, is qemu-ppc64 currently capable of running LE > > > firmware? > > > > Well..

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-10-22 Thread David Gibson
itory at: > > g...@github.com:aik/qemu.git tags/qemu-slof-20191022 > > for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc: > > pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1

[PULL 03/12] qapi: Eliminate accidental global frontend state

2019-10-22 Thread Markus Armbruster
The frontend can't be run more than once due to its global state. A future commit will want to do that. The only global frontend state remaining is accidental: QAPISchemaParser.__init__()'s parameter previously_included=[]. Python evaluates the default once, at definition time. Any modifications

[PULL 02/12] qapi: Store pragma state in QAPISourceInfo, not global state

2019-10-22 Thread Markus Armbruster
The frontend can't be run more than once due to its global state. A future commit will want to do that. Recent commit "qapi: Move context-sensitive checking to the proper place" got rid of many global variables already, but pragma state is still stored in global variables (that's why a pragma

Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)

2019-10-22 Thread Paolo Bonzini
On 17/10/19 02:46, Wei Yang wrote: > Signed-off-by: Wei Yang > CC: Richard Henderson > CC: Stefan Hajnoczi > > --- > v2: add "\b" for better match, suggested by Richard Henderson > > --- > scripts/checkpatch.pl | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

[Resend PATCH 3/3] i386: Add new CPU model Cooperlake

2019-10-22 Thread Cathy Zhang
Cooper Lake is intel's successor to Cascade Lake, the new CPU model inherits features from Cascadelake-Server, while add one platform associated new feature: AVX512_BF16. Meanwhile, add STIBP for speculative execution. Signed-off-by: Cathy Zhang Reviewed-by: Xiaoyao Li Reviewed-by: Tao Xu ---

[Resend PATCH 0/3] Add CPU model for intel processor Cooper Lake

2019-10-22 Thread Cathy Zhang
This patchset is to add CPU model for intel processor Cooper Lake. It will inherit features from the existing CPU model Cascadelake-Server, meanwhile, add the platform associated new instruction and feature for speculative execution which the host supports. There are associated feature bit and

[Resend PATCH 1/3] i386: Add MSR feature bit for MDS-NO

2019-10-22 Thread Cathy Zhang
Define MSR_ARCH_CAP_MDS_NO in the IA32_ARCH_CAPABILITIES MSR to allow CPU models to report the feature when host supports it. Signed-off-by: Cathy Zhang Reviewed-by: Xiaoyao Li Reviewed-by: Tao Xu --- target/i386/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.h

[Resend PATCH 2/3] i386: Add macro for stibp

2019-10-22 Thread Cathy Zhang
stibp feature is already added through the following commit. https://github.com/qemu/qemu/commit/0e8916582991b9fd0b94850a8444b8b80d0a0955 Add a macro for it to allow CPU models to report it when host supports. Signed-off-by: Cathy Zhang Reviewed-by: Xiaoyao Li Reviewed-by: Tao Xu ---

[PATCH v3 2/4] spapr_cpu_core: Implement DeviceClass::reset

2019-10-22 Thread Cédric Le Goater
From: Greg Kurz Since vCPUs aren't plugged into a bus, we manually register a reset handler for each vCPU. We also call this handler at realize time to ensure hot plugged vCPUs are reset before being exposed to the guest. This results in vCPUs being reset twice at machine reset. It doesn't break

[PATCH v3 1/4] spapr: move CPU reset after presenter creation

2019-10-22 Thread Cédric Le Goater
spapr_realize_vcpu() is modified to call the CPU reset only after the the intc presenter has been created. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_cpu_core.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c

[PATCH v3 4/4] spapr/xive: Set the OS CAM line at reset

2019-10-22 Thread Cédric Le Goater
When a Virtual Processor is scheduled to run on a HW thread, the hypervisor pushes its identifier in the OS CAM line. When running with kernel_irqchip=off, QEMU needs to emulate the same behavior. Set the OS CAM line when the interrupt presenter of the sPAPR core is reseted. This will also cover

[PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-22 Thread Thomas Huth
According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for

[PATCH v3 0/4] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Cédric Le Goater
Hello, On the sPAPR machine and PowerNV machine, the interrupt presenters are created by a machine handler at the core level and are reseted independently. This is not consistent and it raises issues when it comes to handle hot-plugged CPUs. In that case, the presenters are not reseted. This is

[PATCH v3 6/6] iotests: Remove 130 from the "auto" group

2019-10-22 Thread Thomas Huth
Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" error with 130 already twice. Looks like this test is a little bit shaky, so for the time being, let's disable it from the "auto" group so that it does not

[PATCH v3 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-22 Thread Thomas Huth
In the long term, we might want to add test 183 to the "auto" group (but it still fails occasionally, so we cannot do that yet). However, when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it currently always fails with an "Timeout waiting for return on handle 0" error.

[PATCH v3 2/6] iotests: Test 041 only works on certain systems

2019-10-22 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

<    1   2   3   4   5   >