> > +aio_set_fd_handler(ctx, fd, false, (IOHandler *)qemu_coroutine_enter,
> > + NULL, NULL, qemu_coroutine_self());
>
> This cast is unsafe. If qemu_coroutine_enter()'s prototype is changed
> there will be no compiler warning that the prototypes are now
> incompatible.
Simply use qemu_get_current_aio_context().
Signed-off-by: Dietmar Maurer
---
Changelog for v4:
- avoid unsafe cast and keep fd_coroutine_enter()
Changelog for v3:
- use (IOHandler *) instead of ((void (*)(void *))
- coding style: fix max line length
Changelog for v2:
- use correct read
VIRTIO Device Initialization requires feature negotiation. Currently
virtio-scsi-test.c is non-compliant.
libqos tests acknowledge all feature bits advertised by the device,
except VIRTIO_F_BAD_FEATURE (which devices use to detect broken
drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not
There was no real virtio-mmio ABI change between Legacy and VIRTIO 1.0
except that the Version field was incremented from 1 to 2.
However, QEMU does not allow Legacy drivers to perform VIRTIO 1.0
operations like accessing 64-bit feature bits. Since we will introduce
64-bit feature bit support we
Thomas Huth writes:
> - Original Message -
>> From: "Alex Bennée"
>> Sent: Tuesday, October 22, 2019 9:16:45 PM
>>
>> Hi,
>>
>> This is the current status of testing/next. I dropped the Travis arm64
>> build due to stability concerns. As far as I can tell Thomas' latest
>> iotest
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 11 +-
target/mips/msa_helper.c | 386 +--
target/mips/translate.c |
- Original Message -
> From: "Stefan Hajnoczi"
> Sent: Wednesday, October 23, 2019 12:04:13 PM
>
> VIRTIO Device Initialization requires feature negotiation. Currently
> virtio-scsi-test.c is non-compliant.
>
> libqos tests acknowledge all feature bits advertised by the device,
>
Build error message:
qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features'
despite being its Up target
Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
Signed-off-by: Gerd Hoffmann
---
qemu-doc.texi | 1 +
1 file changed, 1 insertion(+)
diff
From: Aleksandar Markovic
This makes searches for instances of opcode usages easier.
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 247 +---
1 file changed, 173 insertions(+), 74 deletions(-)
diff --git a/target/mips/translate.c
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 12 +++-
target/mips/msa_helper.c | 169 ++-
target/mips/translate.c | 38 +--
3 files
I will exercise this thoroughly ! The go application involved is itself
a blockchain signing/verification application, so I suspect it will be a
good exercise (codenotary.io)
Thanks for looking into this and fixing this !
--Ivan
--
You received this bug notification because you are a member of
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Wednesday, October 23, 2019 7:01 PM
> To: Zhang, Chen ; Jason Wang
> ; Paolo Bonzini ; qemu-
> dev
> Cc: Zhang Chen
> Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
> module framework
>
> Hi Chen,
>
>
Patchew URL: https://patchew.org/QEMU/20191023020126.24991-1-ebl...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
It seemed "easy" to add cortex-m7 based on cortex-m4 (copy m4
description, update ID register values), but I realized that QEMU does
not support FPv5 which not only supports DP, but also adds new
instructions that QEMU does not handle yet (see section A2.5 of the
ARMv7-M ARM).
* Are there plans
Optimize emulation of twelve Altivec instructions: lvsl, lvsr, vsl, vsr, vpkpx,
vgbbd, vclzb, vclzh, vclzw, vclzd, vupkhpx and vupklpx.
This series builds up on and complements recent work of Thomas Murta, Mark
Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG
On 10/23/19 7:10 AM, Philippe Mathieu-Daudé wrote:
> Cc'ed trivial@
>
> On 10/23/19 12:19 PM, Gerd Hoffmann wrote:
>> Build error message:
>> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed
>> features' despite being its Up target
>>
>> Fixes: 3264ffced3d0 ("dirty-bitmaps:
We already print availabled devices with "-device help", or available
backends with "-netdev help" or "-chardev help". Let's provide a way
for the users to query the available display backends, too.
Signed-off-by: Thomas Huth
---
include/ui/console.h | 1 +
ui/console.c | 12
VIRTIO Device Initialization requires feature negotiation. The libqos
virtio-9p driver lacks feature negotiation and is therefore
non-compliant.
libqos tests acknowledge all feature bits advertised by the device,
except VIRTIO_F_BAD_FEATURE (which devices use to detect broken
drivers!) and
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 20 ++-
target/mips/msa_helper.c | 320 ++-
target/mips/translate.c
On 23.10.19 11:37, Ivan Warren wrote:
> Looks fixed to me ! The issue no longer shows even without specifying
> vx=off
>
Nice, I suspect that there might be more issues when using golang (as it
really makes excessive use of vector registers to my surprise). So in
case you run into problems
From: Aleksandar Markovic
Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions.
Reuse zlib crc32() and Linux crc32c(). Note that, at the time being,
there is no MIPS CPU that supports CRC32 instructions (they are an
optional part of MIPS64/32 R6 anf nanoMIPS ISAs).
Signed-off-by:
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 21 +-
target/mips/msa_helper.c | 768 +--
target/mips/translate.c |
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote:
> On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote:
> > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote:
> > > v2:
> > > - use uint32_t rather than int64_t [Juan]
> > > - one more patch (patch 4) to check dup
On 10/23/19 5:32 AM, maozy wrote:
ping...
I'm not sure qemu-trivial@ received this one because the email address
looked odd (now fixed).
On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-trivial@
On 8/11/18 13:21, Mao Zhongyi wrote:
Signed-off-by: Mao Zhongyi
> -Original Message-
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> Sent: Monday, October 21, 2019 6:41 PM
> To: Misono, Tomohiro/味曽野 智礼
> Cc: 'Miklos Szeredi' ; virtio...@redhat.com;
> qemu-devel@nongnu.org
> Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr
On Wed, Oct 23, 2019 at 01:16:38PM +0200, Vitaly Kuznetsov wrote:
> Eduardo Habkost writes:
>
> > On Mon, Oct 21, 2019 at 06:26:14PM +0200, Paolo Bonzini wrote:
> >> On 21/10/19 16:09, Vitaly Kuznetsov wrote:
> >> >>> +if (cpu->hyperv_no_nonarch_cs == ON_OFF_AUTO_ON) {
> >> >>> +
On 10/23/19 1:09 PM, Zhang, Chen wrote:
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Wednesday, October 23, 2019 7:01 PM
To: Zhang, Chen ; Jason Wang
; Paolo Bonzini ; qemu-
dev
Cc: Zhang Chen
Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
module
On 10/22/19 9:16 PM, Alex Bennée wrote:
Hopefully we'll see the same benefits as the other builds.
Signed-off-by: Alex Bennée
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index da6a2063fca..c43597f1331 100644
--- a/.travis.yml
+++
Optimize altivec instruction vpkpx (Vector Pack Pixel).
Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register)
into a contigous array of bits in the destination register.
In each iteration of outer loop, the instruction is to be done with
the 6-5-5 pack for 2 pixels of each
'trans_vupkpx' function implements emulation of both vupkhpx and vupklpx
instructions, while its argument 'high' determines which instruction is
processed. Instructions are implemented in two 'for' loops. Outer 'for'
loop repeats unpacking two times, since both doubleword elements of the
Hello,
The property names of AST2600 GPIO 1.8V model are one character bigger
than the names of the other ASPEED GPIO model. This change increases
the string buffer size by one and parses the property name with a
better pattern.
This fixes the QOM test of the ast2600-evb machine under :
Apple
Signed-off-by: Cédric Le Goater
Reviewed-by: Joel Stanley
---
include/hw/arm/aspeed.h | 1 +
hw/arm/aspeed.c | 23 +++
2 files changed, 24 insertions(+)
diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 02073a6b4d61..f49bc7081e4d 100644
---
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 30 +++-
target/mips/msa_helper.c | 426 +--
target/mips/translate.c
Hi!
This is very interesting! Could you please export a branch to look at,
as patches can't be applied on master now :(
15.10.2019 18:23, Alberto Garcia wrote:
> Hi,
>
> this series adds a new feature to the qcow2 on-disk format called
> "Extended L2 Entries", which allows us to do subcluster
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 10 -
target/mips/msa_helper.c | 108 +--
target/mips/translate.c | 32 +++---
3 files
- Original Message -
> From: "Stefan Hajnoczi"
> Sent: Wednesday, October 23, 2019 12:04:25 PM
>
> Implement the VIRTIO 1.0 virtio-pci interface. The main change here is
> that the register layout is no longer a fixed layout in BAR 0. Instead
> we have to iterate of PCI Capabilities to
Hi Chen,
On 10/16/19 1:22 PM, Zhang Chen wrote:
From: Zhang Chen
This patch introduce a new module named Advanced Watch Dog,
and defined the input and output parameter. AWD use standard chardev
as the way of communicationg with the outside world.
Demo command:
-object
Hi Sven,
(Please Cc reviewers who previously commented your patch)
On 10/22/19 10:59 PM, Sven Schnelle wrote:
HP-UX sends both the 'Set key make and break (0xfc) and
'Set all key typematic make and break' (0xfa). QEMU response
with 'Resend' as it doesn't handle these commands. HP-UX than
Cc'ed trivial@
On 10/23/19 12:19 PM, Gerd Hoffmann wrote:
Build error message:
qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features'
despite being its Up target
Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
Signed-off-by: Gerd Hoffmann
On 10/22/19 6:38 PM, Cédric Le Goater wrote:
We will use it to reset the interrupt presenter from the CPU reset
handler.
Signed-off-by: Cédric Le Goater
Reviewed-by: Greg Kurz
---
include/hw/ppc/pnv_core.h | 3 +++
hw/ppc/pnv_core.c | 3 ++-
2 files changed, 5 insertions(+), 1
I finally got an image with which I can reproduce the problem. I think I
may have had the wrong image size before because both tmpfs and my spare
LVM volume are rather limited in size.
Anyway, so far locking around qcow2_get_refcount() seems to do the
trick. I'll try to investigate the details a
On 05.10.19 15:05, Lukas Straub wrote:
> After failover the Secondary side of replication shouldn't change state,
> because
> it now functions as our primary disk.
>
> In replication_start, replication_do_checkpoint, replication_stop, ignore
> the request if current state is
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit :
> Signed-off-by: Frediano Ziglio
> ---
> util/qemu-timer.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/util/qemu-timer.c b/util/qemu-timer.c
> index d428fec567..094a20a05a 100644
> --- a/util/qemu-timer.c
> +++
The VIRTIO Configuration Space cannot be accessed before device feature
bits have been read because a driver doesn't know the endianness until
it has checked VIRTIO_F_VERSION_1.
Fix this problem in preparation for VIRTIO 1.0 support.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
---
v4:
* Introduce bool d->features_negotiated so that tests can negotiate a
0 feature bit set in Legacy mode [Thomas]
* Make the FEATURES_OK code change in qvirtio_set_driver_ok() clearer and
mention it in the commit description [Thomas]
* Fix indentation in qvring_init() [Thomas]
v3:
*
Instead of just passing the vring page frame number, pass the full
QVirtQueue. This will allow the VIRTIO 1.0 transport to program the
fine-grained vring address registers in the future.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Sergio Lopez
Reviewed-by: Thomas Huth
Reviewed-by: Philippe
Thomas Huth writes:
> - Original Message -
>> From: "Alex Bennée"
>> Sent: Tuesday, October 22, 2019 9:16:52 PM
>>
>> The MacOS build can time out on Cirrus running to almost an hour.
>> Reduce the scope to the historical MacOS architectures much the same
>> way we do on Travis.
>
>
The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need
to use a different BAR index, so make it configurable.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
---
v3:
* Change uint8_t bar_idx to int [Thomas]
---
The VIRTIO 1.0 code will need to perform additional steps but it will
reuse the common virtqueue setup/cleanup code. Make these functions
public.
Make sure to invoke callbacks via QVirtioBus instead of directly calling
the virtio-pci Legacy versions of these functions.
Signed-off-by: Stefan
Implement the VIRTIO 1.0 virtio-pci interface. The main change here is
that the register layout is no longer a fixed layout in BAR 0. Instead
we have to iterate of PCI Capabilities to find descriptions of where
various registers are located. The vring registers are also more
fine-grained,
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 10 +++-
target/mips/msa_helper.c | 131 ++-
target/mips/translate.c
Improve the help text of the "-display" option:
- Only print the options that we have enabled in the binary
(similar to what we do for other options like -netdev already)
- The "frame=on|off" from "-display sdl" has been removed in commit
09bd7ba9f5f7 ("Remove deprecated -no-frame option"),
On 10/23/19 3:27 AM, Jens Freimann wrote:
This event is emitted when we sent a request to unplug a
failover primary device from the Guest OS and it includes the
device id of the primary device.
Signed-off-by: Jens Freimann
---
qapi/migration.json | 19 +++
1 file changed, 19
On 10/22/19 9:17 PM, Alex Bennée wrote:
From: Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS.
Let's mark it as only supported on the systems where we know that it is
working fine.
Signed-off-by: Thomas Huth
Message-Id:
On 10/22/19 9:17 PM, Alex Bennée wrote:
From: Thomas Huth
In the long term, we might want to add test 183 to the "auto" group
(but it still fails occasionally, so we cannot do that yet). However,
when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd
target, it currently always
On 10/23/19 2:01 PM, Thomas Huth wrote:
Improve the help text of the "-display" option:
- Only print the options that we have enabled in the binary
(similar to what we do for other options like -netdev already)
- The "frame=on|off" from "-display sdl" has been removed in commit
event_notifier_dummy_cb is already compatible with EventNotifierHandler.
Signed-off-by: Frediano Ziglio
---
util/async.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/async.c b/util/async.c
index ca83e32c7f..b1fa5319e5 100644
--- a/util/async.c
+++ b/util/async.c
@@ -429,7 +429,6 @@
Signed-off-by: Frediano Ziglio
---
util/qemu-timer.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/util/qemu-timer.c b/util/qemu-timer.c
index d428fec567..094a20a05a 100644
--- a/util/qemu-timer.c
+++ b/util/qemu-timer.c
@@ -322,11 +322,7 @@ int
Looks fixed to me ! The issue no longer shows even without specifying
vx=off
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1847232
Title:
qemu TCG in s390x mode issue with calculating HASH
Status
VIRTIO Device Initialization requires that feature negotiation has
completed before virtqueues are set up. This makes sense because the
driver must know whether it is operating in Legacy or VIRTIO 1.0 mode
before it can access vring fields with the correct endianness.
Signed-off-by: Stefan
The current libqos virtio-pci.c code implements the VIRTIO Legacy
interface. Extract existing code in preparation for VIRTIO 1.0 support.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Sergio Lopez
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
---
tests/libqos/virtio-pci.h | 2
VIRTIO 1.0 uses little-endian for the vring. Legacy VIRTIO uses guest
endianness. Adjust the code to handle both.
Note that qvirtio_readq() is not defined because it has no users. All
the other accessors are really needed.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
---
v4:
*
In VIRTIO 1.0 feature bits changed from 32-bit to 64-bit. (In fact, the
transports allow even more feature bits but nothing uses more than 64
bits today.)
Add 64-bit feature bit support to virtio-mmio and virtio-pci. This will
be necessary for VIRTIO 1.0 support.
Signed-off-by: Stefan Hajnoczi
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 11 +++-
target/mips/msa_helper.c | 163 ++-
target/mips/translate.c
From: Aleksandar Markovic
Mostly cosmetic changes.
v6->v7:
- minor corrections in commit messages
- added patches 13 and 14
v5->v6:
- minor corrections (r-b, t-b marks) in commit messages
- added patches 11 and 12
v4->v5:
- minor correction in patch on helper.c
- added patches
On 10/23/19 10:24 AM, Paolo Bonzini wrote:
Reported by Coverity (CID 1406449).
Gerd sent the same patch earlier:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg05923.html
But your description is better.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
- Original Message -
> From: "Stefan Hajnoczi"
> Sent: Wednesday, October 23, 2019 12:04:15 PM
>
> VIRTIO Device Initialization requires feature negotiation. The libqos
> virtio-9p driver lacks feature negotiation and is therefore
> non-compliant.
>
> libqos tests acknowledge all
- Original Message -
> From: "Stefan Hajnoczi"
> Sent: Wednesday, October 23, 2019 12:04:17 PM
>
> Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK
> status bit is set to indicate that feature negotiation has completed.
> The driver then reads the status register
On 10/22/19 6:38 PM, Cédric Le Goater wrote:
The 'vcpu' suffix is inherited from the sPAPR machine. Use better
names for PowerNV.
Signed-off-by: Cédric Le Goater
Reviewed-by: Greg Kurz
---
hw/ppc/pnv_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Eduardo Habkost writes:
> On Mon, Oct 21, 2019 at 06:26:14PM +0200, Paolo Bonzini wrote:
>> On 21/10/19 16:09, Vitaly Kuznetsov wrote:
>> >>> +if (cpu->hyperv_no_nonarch_cs == ON_OFF_AUTO_ON) {
>> >>> +env->features[FEAT_HV_RECOMM_EAX] |= HV_NO_NONARCH_CORESHARING;
>> >>> +} else
- Original Message -
> From: "Stefan Hajnoczi"
> Sent: Wednesday, October 23, 2019 12:04:16 PM
>
> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device
> Initialization", configuration space and virtqueues cannot be accessed
> before features have been negotiated. Enforce this
Hi Philippe,
On Wed, Oct 23, 2019 at 01:08:35PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Sven,
>
> (Please Cc reviewers who previously commented your patch)
>
> On 10/22/19 10:59 PM, Sven Schnelle wrote:
> > HP-UX sends both the 'Set key make and break (0xfc) and
> > 'Set all key typematic make
If rfd is equal to wfd the file descriptor is closed but
rfd will still have the closed value.
The EventNotifier structure should not be used again after calling
event_notifier_cleanup or should be initialized again but make
sure to not have dandling file descriptors around.
Signed-off-by:
On 10/23/19 2:08 PM, Sven Schnelle wrote:
Hi Philippe,
On Wed, Oct 23, 2019 at 01:08:35PM +0200, Philippe Mathieu-Daudé wrote:
Hi Sven,
(Please Cc reviewers who previously commented your patch)
On 10/22/19 10:59 PM, Sven Schnelle wrote:
HP-UX sends both the 'Set key make and break (0xfc)
Optimize emulation of Altivec instructions vclzh (Vector Count Leading Zeros
Halfword) and vclzb (Vector Count Leading Zeros Byte).This instructions
count the number of leading zeros of each halfword/byte element in source
register and place result in the appropriate halfword/byte element of the
Any comments on this?
It would be interesting to have this in 4.2
Thanks,
Laurent
Le 08/09/2019 à 12:48, Laurent Vivier a écrit :
> Add --preserve-arg0 in qemu-binfmt-conf.sh to configure the preserve-arg0
> flag.
>
> Now, if QEMU is started with -0 or QEMU_ARGV0 and an empty parameter
>
The property names of AST2600 GPIO 1.8V model are one character bigger
than the names of the other ASPEED GPIO model. Increase the string
buffer size by one and be more strict on the expected pattern of the
property name.
This fixes the QOM test of the ast2600-evb machine under :
Apple LLVM
According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device
Initialization", configuration space and virtqueues cannot be accessed
before features have been negotiated. Enforce this requirement.
Signed-off-by: Stefan Hajnoczi
---
v4:
* Introduce bool d->features_negotiated so that tests can
Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK
status bit is set to indicate that feature negotiation has completed.
The driver then reads the status register again to check that the device
agrees with the final features.
Implement this step as part of
VIRTIO 1.0 PCI devices have multiple PCI_CAP_ID_VNDR capabilities so we
need a way to iterate over them. Extend qpci_find_capability() to take
the last address.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
--
v3:
* Document qpci_find_capability()
---
tests/libqos/pci.h | 2 +-
The MSI-X vectors are programmed differently in the VIRTIO 1.0 and
Legacy interfaces. Introduce callbacks so different implementations can
be used depending on the interface version.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Sergio Lopez
Reviewed-by: Thomas Huth
---
From: Aleksandar Markovic
Aleksandar Rikalo wishes to change his primary mail address for QEMU.
Some minor line order is corrected in .mailmap to be alphabetical,
too.
Reviewed-by: Aleksandar Rikalo
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by:
From: Aleksandar Markovic
Mostly fix errors and warnings reported by 'checkpatch.pl -f'.
Cc: Markus Armbruster
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.c | 123 +++
1 file changed, 74
From: Aleksandar Markovic
Achieves clearer code and slightly better performance.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/helper.h | 30 +++-
target/mips/msa_helper.c | 424 +--
target/mips/translate.c
On 10/22/19 6:38 PM, Cédric Le Goater wrote:
On the sPAPR machine and PowerNV machine, the interrupt presenters are
created by a machine handler at the core level and are reset
independently. This is not consistent and it raises issues when it
comes to handle hot-plugged CPUs. In that case, the
From: Aleksandar Markovic
Mostly fix errors and warnings reported by 'checkpatch.pl -f'.
Reviewed-by: Aleksandar Rikalo
Signed-off-by: Aleksandar Markovic
---
target/mips/op_helper.c | 1010 +++
1 file changed, 663 insertions(+), 347 deletions(-)
On 10/23/19 3:33 AM, Vladimir Sementsov-Ogievskiy wrote:
23.10.2019 4:31, Eric Blake wrote:
On 10/9/19 3:41 AM, Vladimir Sementsov-Ogievskiy wrote:
Add test, which starts backup to nbd target and restarts nbd server
during backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
On 10/22/19 9:16 PM, Alex Bennée wrote:
From: Thomas Huth
The "command -v ccache && ccache ..." likely were supposed to test
the availability of ccache before running the program. But this
shell construct causes Travis to abort if ccache is not available.
Use an if-statement instead to fix
Hi Cédric,
On 10/22/19 6:38 PM, Cédric Le Goater wrote:
in which individual CPUs are reset. It will ease the introduction of
future change reseting the interrupt presenter from the CPU reset
handler.
Signed-off-by: Cédric Le Goater
Reviewed-by: Greg Kurz
---
hw/ppc/pnv_core.c | 19
Hi Alex,
On 10/22/19 9:16 PM, Alex Bennée wrote:
As 10.3 is available lets use it. I don't know what Apple's
deprecation policy is for Xcode because it requires an AppleID to find
out.
Can you add a link to:
https://docs.travis-ci.com/user/reference/osx/#macos-version
Signed-off-by: Alex
Fixed:
commit 0dacea92d26c31d453c58de2e99c178fee554166
Author: Ed Swierk
Date: Thu Nov 16 06:06:06 2017 -0800
net: Transmit zero UDP checksum as 0x
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per
When writeback mode is enabled (-o writeback), O_APPEND handling is
done in kernel. Therefore virtiofsd clears O_APPEND flag when open.
Otherwise O_APPEND flag takes precedence over pwrite() and write
data may corrupt.
Currently clearing O_APPEND flag is done in lo_open(), but we also
need the
On Tue, 22 Oct 2019 at 17:45, Peter Maydell wrote:
>
> Changes v2->v3:
> dropped the aspeed new board patch as it fails in
> tests/qom-test on OSX (intermittently).
>
> thanks
> -- PMM
>
> The following changes since commit f9bec781379dd7ccf9d01b4b6a79a9ec82c192e5:
>
> Merge remote-tracking
By performing this store early, we avoid having to save and restore
the register holding the address around any function calls.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Changes since v8:
* Rebuild hflags in linux-user/*/cpu_loop.c, after changing to big-endian.
This allows the armeb busybox ls to pass. I don't have a test image for
aarch64_eb, but the code looks the same.
Changes since v7:
* Rebuild hflags for all successful nvic writes (Peter).
*
Create a function to compute the values of the TBFLAG_ANY bits
that will be cached. For now, the env->hflags variable is not
used, and the results are fed back to cpu_get_tb_cpu_state.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 29
Hoist the computation of some TBFLAG_A32 bits that only apply to
M-profile under a single test for ARM_FEATURE_M.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 49 +
1 file changed, 23 insertions(+), 26
Set TBFLAG_ANY.BE_DATA in rebuild_hflags_common_32 and
rebuild_hflags_a64 instead of rebuild_hflags_common, where we do
not need to re-test is_a64() nor re-compute the various inputs.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 49
This is the payoff.
>From perf record -g data of ubuntu 18 boot and shutdown:
BEFORE:
- 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr
- 20.22% helper_lookup_tb_ptr
+ 10.05% tb_htable_lookup
- 9.13% cpu_get_tb_cpu_state
3.20% aa64_va_parameters_both
Create a function to compute the values of the TBFLAG_A32 bits
that will be cached, and are used by all profiles.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git
1 - 100 of 340 matches
Mail list logo
