Re: privileged entropy sources in QEMU/KVM guests

2019-11-07 Thread Daniel P . Berrangé
On Thu, Nov 07, 2019 at 11:10:57AM +0100, Laszlo Ersek wrote: > Hi, > > related TianoCore BZ: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > (I'm starting this thread separately because at least some of the topics > are specific to QEMU, and I didn't want to litter the BZ with a

Re: [PATCH 0/6] migration/postcopy: enable compress during postcopy

2019-11-07 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Thu, Nov 07, 2019 at 09:15:44AM +, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.y...@linux.intel.com) wrote: > >> On Wed, Nov 06, 2019 at 08:11:44PM +, Dr. David Alan Gilbert wrote: > >> >* Wei Yang

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Aleksandar Markovic
On Thu, Nov 7, 2019 at 11:37 AM Aleksandar Markovic wrote: > > > > On Thursday, November 7, 2019, Rajath Shashidhara > wrote: >> >> Hi all, >> >> I am a Computer Science graduate student at The University of Texas at >> Austin (UT, Austin). I am looking forward to contributing to qemu ! >> >>

Re: privileged entropy sources in QEMU/KVM guests

2019-11-07 Thread Laszlo Ersek
On 11/07/19 13:47, Paolo Bonzini wrote: > On 07/11/19 12:52, Daniel P. Berrangé wrote: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bb5530e4082446aac3a3d69780cd4dbfa4520013 >> >> Is it practical to provide a jitter entropy source for EDK2 >> too ? > > The

Re: [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores

2019-11-07 Thread Richard Henderson
On 11/6/19 3:14 PM, Edgar E. Iglesias wrote: > @@ -967,12 +967,14 @@ static void dec_load(DisasContext *dc) > 10 -> 10 > 11 -> 00 */ > TCGv low = tcg_temp_new(); > +TCGv t3 = tcg_const_tl(3); > >

Re: [PATCH v4 20/20] fuzz: add documentation to docs/devel/

2019-11-07 Thread Alexander Oleinik
On 11/7/19 8:40 AM, Stefan Hajnoczi wrote: On Wed, Oct 30, 2019 at 02:50:04PM +, Oleinik, Alexander wrote: +== Building the fuzzers == + +NOTE: If possible, build a 32-bit binary. When forking, the 32-bit fuzzer is +much faster, since the page-map has a smaller size. This is due to the fact

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-07 Thread Eric Blake
On 11/7/19 9:27 AM, Kevin Wolf wrote: Am 07.11.2019 um 14:45 hat Eric Blake geschrieben: On 11/7/19 2:33 AM, Kevin Wolf wrote: As a replacement nbd-server-add, I envisioned adding something like a block-export-add, which would work the way that --export already does. It would also come with

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-07 Thread Cleber Rosa
On Wed, Nov 06, 2019 at 04:26:41PM -0300, Eduardo Habkost wrote: > On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: > > On 06.11.19 10:24, Stefan Hajnoczi wrote: > > > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > > >> It tests proper queue size settings for all

[PATCH v3 17/22] iotests: Make 091 work with data_file

2019-11-07 Thread Max Reitz
The image end offset as reported by qemu-img check is different when using an external data file; we do not care about its value here, so we can just filter it. Incidentally, common.rc already has _check_test_img for us which does exactly that. Signed-off-by: Max Reitz Reviewed-by: Maxim

[PATCH v3 11/22] iotests: Replace IMGOPTS= by -o

2019-11-07 Thread Max Reitz
Tests should not overwrite all user-supplied image options, but only add to it (which will effectively overwrite conflicting values). Accomplish this by passing options to _make_test_img via -o instead of $IMGOPTS. For some tests, there is no functional change because they already only appended

[PATCH v3 21/22] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/007 | 5 +++-- tests/qemu-iotests/014 | 2 ++ tests/qemu-iotests/015 | 5 +++-- tests/qemu-iotests/026 | 5 - tests/qemu-iotests/029 | 5 +++-- tests/qemu-iotests/031 | 6 +++--- tests/qemu-iotests/036 | 5 +++-- tests/qemu-iotests/039 | 3 +++

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 16:57, Alex Bennée wrote: > > > Beata Michalska writes: > > > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > > wrote: > >> qemu_log_mask w/ GUEST_ERROR? How do we expect the length to overflow? > > > > In theory it shouldn't, at least with current usage. > > I guess the

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Palmer Dabbelt
On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: Coreboot developers have requested that they have at least 32MB of flash to load binaries. We currently have 32MB of flash, but it is split in two to allow loading two flash binaries. Let's increase the flash size from 32MB to

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Alex Bennée
Alex Bennée writes: > Robert Foley writes: > >> One test ensures that the logfile handle is still valid even if >> the logfile is changed during logging. >> The other test validates that the logfile handle remains valid under >> the logfile lock even if the logfile is closed. Also this

Re: [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine

2019-11-07 Thread Philippe Mathieu-Daudé
On 11/7/19 5:52 PM, Palmer Dabbelt wrote: On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote: This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Alistair Francis
On Thu, Nov 7, 2019 at 10:01 AM Peter Maydell wrote: > > On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: > > > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > > Coreboot developers have requested that they have at least 32MB of flash > > > to load binaries. We

[PATCH v2 1/2] i386: Add missing cpu feature bits in EPYC model

2019-11-07 Thread Moger, Babu
Adds the following missing CPUID bits: perfctr-core : core performance counter extensions support. Enables the VM to use extended performance counter support. It enables six programmable counters instead of 4 counters. clzero : instruction zeroes out the 64 byte

[PATCH v2 2/2] i386: Add 2nd Generation AMD EPYC processors

2019-11-07 Thread Moger, Babu
Adds the support for 2nd Gen AMD EPYC Processors. The model display name will be EPYC-Rome. Adds the following new feature bits on top of the feature bits from the first generation EPYC models. perfctr-core : core performance counter extensions support. Enables the VM to use

Re: [PULL 0/3] Block patches for 4.2.0-rc0/4.1.1

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 14:34, Max Reitz wrote: > > The following changes since commit d0f90e1423b4f412adc620eee93e8bfef8af4117: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191106-pull-request' into staging (2019-11-07 > 09:21:52 +) > > are available in the Git

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20191107-pull-request > > for you to fetch changes up to 1dfe2b91dcb1633d0ba450a8139d53006e700a9b: > > usb-host: add option to al

[PATCH v3 01/22] iotests: s/qocw2/qcow2/

2019-11-07 Thread Max Reitz
Probably due to blind copy-pasting, we have several instances of "qocw2" in our iotests. Fix them. Reported-by: Maxim Levitsky Signed-off-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- tests/qemu-iotests/061 | 2 +- tests/qemu-iotests/062 | 2 +- tests/qemu-iotests/066 | 2 +-

[PATCH v3 00/22] iotests: Allow ./check -o data_file

2019-11-07 Thread Max Reitz
Hi, The cover letter from v1 (explaining the motivation behind this series and the general structure) is here: https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html For v2, I’ve addressed more of Maxim’s comments: - Patch 1: Added; Maxim noted this problem on patch 5, but that

[PATCH v3 04/22] iotests: Add _filter_json_filename

2019-11-07 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/common.filter | 24 1 file changed, 24 insertions(+) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index f870e00e44..8a0169f19a 100644 ---

[PATCH v3 02/22] iotests/qcow2.py: Add dump-header-exts

2019-11-07 Thread Max Reitz
This is useful for tests that want to whitelist fields from dump-header (with grep) but still print all header extensions. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/qcow2.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/qcow2.py

[PATCH v3 07/22] iotests: Drop compat=1.1 in 050

2019-11-07 Thread Max Reitz
IMGOPTS can never be empty for qcow2, because the check scripts adds compat=1.1 unless the user specified any compat option themselves. Thus, this block does not do anything and can be dropped. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/050 | 4 1 file

[PATCH v3 09/22] iotests: Add -o and --no-opts to _make_test_img

2019-11-07 Thread Max Reitz
Blindly overriding IMGOPTS is suboptimal as this discards user-specified options. Whatever options the test needs should simply be appended. Some tests do this (with IMGOPTS=$(_optstr_add "$IMGOPTS" "...")), but that is cumbersome. It’s simpler to just give _make_test_img an -o parameter with

[PATCH v3 03/22] iotests/qcow2.py: Split feature fields into bits

2019-11-07 Thread Max Reitz
Print the feature fields as a set of bits so that filtering is easier. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/031.out | 36 +-- tests/qemu-iotests/036.out | 18 +- tests/qemu-iotests/039.out | 22 ++--

[PATCH v3 05/22] iotests: Filter refcount_order in 036

2019-11-07 Thread Max Reitz
This test can run just fine with other values for refcount_bits, so we should filter the value from qcow2.py's dump-header. In fact, we can filter everything but the feature bits and header extensions, because that is what the test is about. (036 currently ignores user-specified image options,

[PATCH v3 22/22] iotests: Allow check -o data_file

2019-11-07 Thread Max Reitz
The problem with allowing the data_file option is that you want to use a different data file per image used in the test. Therefore, we need to allow patterns like -o data_file='$TEST_IMG.data_file'. Then, we need to filter it out from qemu-img map, qemu-img create, and remove the data file in

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread David Gibson
On Sun, Oct 27, 2019 at 01:33:47PM -0500, Corey Minyard wrote: > On Sun, Oct 27, 2019 at 06:47:39PM +0100, David Gibson wrote: > > On Mon, Oct 21, 2019 at 09:30:17AM -0500, Corey Minyard wrote: > > > On Mon, Oct 21, 2019 at 03:12:12PM +0200, Cédric Le Goater wrote: > > > > The routine

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Laurent Vivier
Le 07/11/2019 à 17:38, Cleber Rosa a écrit : > > > - Original Message - >> From: "Eric Blake" >> To: "Cleber Rosa" , qemu-devel@nongnu.org >> Cc: "Peter Maydell" , "Eduardo Habkost" >> , "Philippe Mathieu-Daudé" >> , "Wainer dos Santos Moschetta" , >> "Laurent Vivier" , >> "Willian

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread Alex Williamson
Presumably w-bits (aw-bits?) implies using intel-iommu, there's a opportunity for the vfio iommu backend to return -ENOSPC (-28) if we exceed the default number of in-flight DMA mappings per container. The default limit is 65535. You can try increasing this by changing the dma_entry_limit module

[PATCH v2 0/2] Add support for 2nd generation AMD EPYC processors

2019-11-07 Thread Moger, Babu
The following series adds the support for 2nd generation AMD EPYC Processors on qemu guests. The model display name for 2nd generation will be EPYC-Rome. Also fixes few missed cpu feature bits in 1st generation EPYC models. The Reference documents are available at

Re: [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test

2019-11-07 Thread Wainer dos Santos Moschetta
Hi Cleber, On 11/4/19 1:13 PM, Cleber Rosa wrote: This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc and q35 machine types, with and without kvm as an accellerator *

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Alex Bennée
Alistair Francis writes: > On Thu, Nov 7, 2019 at 10:01 AM Peter Maydell > wrote: >> >> On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: >> > >> > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: >> > > Coreboot developers have requested that they have at least 32MB of

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
acb28c4544858c66a3: > >> > >>Merge remote-tracking branch > >> 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > >> (2019-11-05 20:17:11 +) > >> > >> are available in the Git repository at: > >

Re: QEMU HTML documentation now on qemu.org

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 09:29, Stefan Hajnoczi wrote: > > On Wed, Nov 6, 2019 at 5:21 PM Stefan Hajnoczi wrote: > > Hi, > > You can now access the latest QEMU HTML documentation built from > > qemu.git/master nightly at: > > > > https://wiki.qemu.org/docs/qemu-doc.html > >

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread Thomas Huth
Please provide information how you started QEMU, and some information about your PCI device (e.g. the output of lspci). ** Information type changed from Private Security to Public ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Cédric Le Goater
On 07/11/2019 18:25, Corey Minyard wrote: > On Thu, Nov 07, 2019 at 06:14:58PM +0100, Cédric Le Goater wrote: > What's the plan for merging this, once it's ready? Is there an IPMI > tree for it to be staged in? If not I could take it through the ppc > tree, but I'd need some

[Bug 1810105] Re: Hint showing volume never disappears, blocking buttons to minimize, maximize and close

2019-11-07 Thread Leonardo Müller
I finally found a real computer on which this bug is present. The computer in question is a netbook manufactured by Positivo, the Mobo 5900, which is common on schools. It has a touchscreen with a pen which is compatible with evdev but that doesn't work with libinput. Its touchscreen is: Bus 004

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:54, Kamil Rytarowski wrote: > > On 07.11.2019 18:46, Peter Maydell wrote: > > On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > >> > >> Hi, > >> > >> As we approach hard-freeze I'm trying to temper what comes in through > >> the testing/next tree. However it would be

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
Thank you Aleksandar ! This is really helpful. Rajath Shashidhara On 07-11-2019 07:33, Aleksandar Markovic wrote: On Thu, Nov 7, 2019 at 11:37 AM Aleksandar Markovic wrote: On Thursday, November 7, 2019, Rajath Shashidhara wrote: Hi all, I am a Computer Science graduate student at The

Re: [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-07 Thread Philippe Mathieu-Daudé
Hi Markus, On 8/15/19 7:40 PM, John Snow wrote: On 8/15/19 10:16 AM, Markus Armbruster wrote: John Snow writes: [...] I asked Markus this not too long ago; do we want to amend the QAPI schema specification to allow commands to return with "Warning" strings, or "Deprecated" stings to allow

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
Hi, Thanks Stefan ! I spoke to Dinah and this issue is still up for grabs. I would be working on both SeaBIOS MMConfig task and the DS3231 RTC emulation feature. Thanks for your help! Regards, Rajath Shashidhara On 07-11-2019 07:54, Stefan Hajnoczi wrote: On Wed, Nov 06, 2019 at 05:50:44PM

Re: [PATCH v7 4/8] Acceptance tests: use relative location for tests

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: An Avocado Test ID[1] is composed by a number of components, but it starts with the Test Name, usually a file system location that was given to the loader. Because the source directory is being given as a prefix to the "tests/acceptance" directory

Re: QEMU HTML documentation now on qemu.org

2019-11-07 Thread Daniel P . Berrangé
On Thu, Nov 07, 2019 at 04:44:34PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 7, 2019 at 11:07 AM Daniel P. Berrangé > wrote: > > > > On Wed, Nov 06, 2019 at 05:19:28PM +0100, Stefan Hajnoczi wrote: > > > Hi, > > > You can now access the latest QEMU HTML documentation built from > > >

Re: [PATCH 2/4] Add use of RCU for qemu_logfile.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > This now allows changing the logfile while logging is active, > and also solves the issue of a seg fault while changing the logfile. > > Any read access to the qemu_logfile handle will use > the rcu_read_lock()/unlock() around the use of the handle. > To fetch the handle

[PATCH v3 10/22] iotests: Inject space into -ocompat=0.10 in 051

2019-11-07 Thread Max Reitz
It did not matter before, but now that _make_test_img understands -o, we should use it properly here. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/051 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/051

[PATCH v3 16/22] iotests: Avoid cp/mv of test images

2019-11-07 Thread Max Reitz
This will not work with external data files, so try to get tests working without it as far as possible. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/063 | 12 tests/qemu-iotests/063.out | 3 ++- tests/qemu-iotests/085 | 9 +++--

[PATCH v3 13/22] iotests: Drop IMGOPTS use in 267

2019-11-07 Thread Max Reitz
Overwriting IMGOPTS means ignoring all user-supplied options, which is not what we want. Replace the current IMGOPTS use by a new BACKING_FILE variable. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/267 | 12 1 file changed, 8 insertions(+), 4

[PATCH v3 19/22] iotests: Make 137 work with data_file

2019-11-07 Thread Max Reitz
When using an external data file, there are no refcounts for data clusters. We thus have to adjust the corruption test in this patch to not be based around a data cluster allocation, but the L2 table allocation (L2 tables are still refcounted with external data files). Furthermore, we should not

Re: [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine

2019-11-07 Thread Palmer Dabbelt
On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote: This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is

[PATCH v3 14/22] iotests: Avoid qemu-img create

2019-11-07 Thread Max Reitz
Use _make_test_img whenever possible. This way, we will not ignore user-specified image options. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/094 | 2 +- tests/qemu-iotests/111 | 3 +-- tests/qemu-iotests/123 | 2 +- tests/qemu-iotests/153 | 2 +-

Re: [PATCH 1/4] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > This is being added in preparation for using RCU with the logfile handle. > Also added qemu_logfile_init() for initializing the logfile mutex. > > Signed-off-by: Robert Foley > --- > util/log.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff

Re: [PULL v3 0/3] Trivial branch patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 16:26, Laurent Vivier wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 18:46, Peter Maydell wrote: > On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: >> >> Hi, >> >> As we approach hard-freeze I'm trying to temper what comes in through >> the testing/next tree. However it would be nice to get the NetBSD upto >> speed with the other NetBSDs. Although the

Re: [PATCH v15 02/12] util/cutils: Add qemu_strtotime_ns()

2019-11-07 Thread Eduardo Habkost
On Thu, Nov 07, 2019 at 03:45:01PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" > for second. Add test for qemu_strtotime_ns, test the input of basic, > time suffixes, float,

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread IndrasenaReddy Gali
qemu-system-x86_64 -name guest=fedora24 -machine q35,accel=kvm,kernel-irqchip=split \ -enable-kvm \ -m 4G \ -smp 8,sockets=1,cores=8,threads=1 \ -device intel-iommu,intremap=on,caching-mode=on,aw-bits=48 \ -drive file=,format=raw \ -device

Re: [PATCH v3 01/22] iotests: s/qocw2/qcow2/

2019-11-07 Thread Eric Blake
On 11/7/19 10:36 AM, Max Reitz wrote: Probably due to blind copy-pasting, we have several instances of "qocw2" in our iotests. Fix them. Reported-by: Maxim Levitsky Signed-off-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- Reviewed-by: Eric Blake -- Eric Blake, Principal Software

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Philippe Mathieu-Daudé
20:17:11 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20191107-pull-request for you to fetch changes up to 1dfe2b91dcb1633d0ba450a8139d53006e700a9b: usb-host: add option to allow all resets. (2019-11-06 13:26:04 +0100

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-07 Thread Jason Andryuk
On Wed, Nov 6, 2019 at 8:08 PM wrote: > > Patchew URL: > https://patchew.org/QEMU/20191106130309.6737-1-jandr...@gmail.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed, you can

Re: [RFC PATCH 01/18] qemu-storage-daemon: Add barebone tool

2019-11-07 Thread Markus Armbruster
In addition to Eric's review: Kevin Wolf writes: > This adds a new binary qemu-storage-daemon that doesn't yet do more than > some typical initialisation for tools and parsing the basic command > options --version, --help and --trace. > > Signed-off-by: Kevin Wolf > --- > configure

Re: [PATCH 0/4] Make the qemu_logfile handle thread safe.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > This patch adds thread safety to the qemu_logfile handle. This now > allows changing the logfile while logging is active, and also solves > the issue of a seg fault while changing the logfile. > > This patch adds use of RCU for handling the swap out of the > old

[PATCH v3 20/22] iotests: Make 198 work with data_file

2019-11-07 Thread Max Reitz
We do not care about the json:{} filenames here, so we can just filter them out and thus make the test work both with and without external data files. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/198 | 6 -- tests/qemu-iotests/198.out | 4 ++-- 2 files

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Alex Bennée
Beata Michalska writes: > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > wrote: >> >> On 11/6/19 12:40 AM, Beata Michalska wrote: >> > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t >> > length) >> > +{ >> > +void *addr = ramblock_ptr(block, start); >> > + >> >

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Corey Minyard
On Thu, Nov 07, 2019 at 06:14:58PM +0100, Cédric Le Goater wrote: > >>> What's the plan for merging this, once it's ready? Is there an IPMI > >>> tree for it to be staged in? If not I could take it through the ppc > >>> tree, but I'd need some Acked-bys in that case. > >> > >> I have an IPMI

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > > Hi, > > As we approach hard-freeze I'm trying to temper what comes in through > the testing/next tree. However it would be nice to get the NetBSD upto > speed with the other NetBSDs. Although the serial install is working > well for me this has

Re: [PATCH v15 01/12] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-07 Thread Eduardo Habkost
On Thu, Nov 07, 2019 at 03:45:00PM +0800, Tao Xu wrote: > Add do_strtomul() to convert string according to different suffixes. > > Signed-off-by: Tao Xu Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow loading

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Laurent Vivier
Le 07/11/2019 à 19:00, Philippe Mathieu-Daudé a écrit : > On 11/7/19 6:18 PM, Laurent Vivier wrote: >> Le 07/11/2019 à 17:38, Cleber Rosa a écrit : >>> - Original Message - From: "Eric Blake" To: "Cleber Rosa" , qemu-devel@nongnu.org Cc: "Peter Maydell" , "Eduardo Habkost"

Re: [Qemu-devel] [PATCH PULL 0/2] RDMA queue

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 14:51, Marcel Apfelbaum wrote: > > The following changes since commit 412fbef3d076c43e56451bacb28c4544858c66a3: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > (2019-11-05 20:17:11 +) > > are available in the

Re: [PATCH 3/4] qemu_log_lock/unlock now preserves the qemu_logfile handle.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > qemu_log_lock() now returns a handle and qemu_log_unlock() receives a > handle to unlock. This allows for changing the handle during logging > and ensures the lock() and unlock() are for the same file. Ahh there it is! We probably want to put the API change through

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > One test ensures that the logfile handle is still valid even if > the logfile is changed during logging. > The other test validates that the logfile handle remains valid under > the logfile lock even if the logfile is closed. > > Signed-off-by: Robert Foley > --- >

[PATCH v3 15/22] iotests: Use _rm_test_img for deleting test images

2019-11-07 Thread Max Reitz
Just rm will not delete external data files. Use _rm_test_img every time we delete a test image. (In the process, clean up the indentation of every _cleanup() this patch touches.) ((Also, use quotes consistently. I am happy to see unquoted instances like "rm -rf $TEST_DIR/..." go.))

[PATCH v3 12/22] iotests: Replace IMGOPTS='' by --no-opts

2019-11-07 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/071 | 4 ++-- tests/qemu-iotests/174 | 2 +- tests/qemu-iotests/178 | 4 ++-- tests/qemu-iotests/197 | 4 ++-- tests/qemu-iotests/215 | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v3 06/22] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-11-07 Thread Max Reitz
Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' globally. That is not how it should be done; instead, they should simply set _unsupported_imgopts to compat=0.10 (compat=1.1 is the default anyway). This makes the tests heed user-specified $IMGOPTS. Some do not work with all image

[PATCH v3 08/22] iotests: Let _make_test_img parse its parameters

2019-11-07 Thread Max Reitz
This will allow us to add more options than just -b. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/common.rc | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/common.rc

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Cleber Rosa
- Original Message - > From: "Eric Blake" > To: "Cleber Rosa" , qemu-devel@nongnu.org > Cc: "Peter Maydell" , "Eduardo Habkost" > , "Philippe Mathieu-Daudé" > , "Wainer dos Santos Moschetta" , > "Laurent Vivier" , > "Willian Rampazzo" , "Philippe Mathieu-Daudé" > > Sent: Thursday,

Re: [PATCH v2 20/21] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
On 07.11.19 16:19, Maxim Levitsky wrote: > On Thu, 2019-11-07 at 12:36 +0100, Max Reitz wrote: >> On 06.11.19 16:52, Maxim Levitsky wrote: >>> On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/007 | 5 +++--

Re: [PATCH v3 21/22] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
On 07.11.19 17:37, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/007 | 5 +++-- > tests/qemu-iotests/014 | 2 ++ > tests/qemu-iotests/015 | 5 +++-- > tests/qemu-iotests/026 | 5 - > tests/qemu-iotests/029 | 5 +++-- > tests/qemu-iotests/031 | 6 +++--- >

[PATCH v3 18/22] iotests: Make 110 work with data_file

2019-11-07 Thread Max Reitz
The only difference is that the json:{} filename of the image looks different. We actually do not care about that filename in this test, we are only interested in (1) that there is a json:{} filename, and (2) whether the backing filename can be constructed. So just filter out the json:{} data,

Re: [PATCH] ppc/pnv: Add a "/qemu" device tree node

2019-11-07 Thread David Gibson
On Wed, Nov 06, 2019 at 03:21:29PM +0100, Cédric Le Goater wrote: > It helps skiboot identifying that is running on a QEMU platform. The > compatible string will define the POWERPC processor version. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-4.3. > --- > hw/ppc/pnv.c | 3 +++ > 1

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Cédric Le Goater
>>> What's the plan for merging this, once it's ready? Is there an IPMI >>> tree for it to be staged in? If not I could take it through the ppc >>> tree, but I'd need some Acked-bys in that case. >> >> I have an IPMI tree for this. I was assuming it was going in to the PPC >> tree, but it's not

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Philippe Mathieu-Daudé
On 11/7/19 6:18 PM, Laurent Vivier wrote: Le 07/11/2019 à 17:38, Cleber Rosa a écrit : - Original Message - From: "Eric Blake" To: "Cleber Rosa" , qemu-devel@nongnu.org Cc: "Peter Maydell" , "Eduardo Habkost" , "Philippe Mathieu-Daudé" , "Wainer dos Santos Moschetta" , "Laurent

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread IndrasenaReddy Gali
Please find the above qemu command to lunch guest machine -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851664 Title: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to

Re: [PATCH 2/3] Acceptance tests: introduce utility method for tags unique vals

2019-11-07 Thread Wainer dos Santos Moschetta
On 10/28/19 8:02 PM, Cleber Rosa wrote: On Thu, Oct 24, 2019 at 06:12:25PM -0300, Wainer dos Santos Moschetta wrote: Hi Cleber, On 9/24/19 4:45 PM, Cleber Rosa wrote: Currently a test can describe the target architecture binary that it should primarily be run with, be setting a single tag

Re: [qemu-web PATCH] Add device fuzzing blog post

2019-11-07 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Thursday, November 7, 2019 10:11:36 AM > > This blog post covers the device fuzzing GSoC project that Alexander > Olenik did in 2019. [...] > +This article was contributed by Stefan Hajnoczi and Alexander Oleinik. You could also use

Re: [PATCH v2 10/21] iotests: Replace IMGOPTS= by -o

2019-11-07 Thread Maxim Levitsky
On Thu, 2019-11-07 at 10:20 +0100, Max Reitz wrote: > On 06.11.19 16:47, Maxim Levitsky wrote: > > On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > > > Tests should not overwrite all user-supplied image options, but only add > > > to it (which will effectively overwrite conflicting values).

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

2019-11-07 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.0+dfsg-0ubuntu10 --- qemu (1:4.0+dfsg-0ubuntu10) focal; urgency=medium * d/p/ubuntu/lp-1848556-curl-Handle-success-in-multi_check_completion.patch: fix a potential hang when qemu or qemu-img where accessing http backed disks via

Re: [PULL 0/1] Audio 20191106 patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 08:27, Gerd Hoffmann wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: QEMU HTML documentation now on qemu.org

2019-11-07 Thread Daniel P . Berrangé
On Wed, Nov 06, 2019 at 05:19:28PM +0100, Stefan Hajnoczi wrote: > Hi, > You can now access the latest QEMU HTML documentation built from > qemu.git/master nightly at: > > https://wiki.qemu.org/docs/qemu-doc.html > https://wiki.qemu.org/docs/qemu-qmp-ref.html >

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-07 Thread Kevin Wolf
Am 06.11.2019 um 15:32 hat Max Reitz geschrieben: > On 17.10.19 15:02, Kevin Wolf wrote: > > This adds and parses the --monitor option, so that a QMP monitor can be > > used in the storage daemon. The monitor offers commands defined in the > > QAPI schema at storage-daemon/qapi/qapi-schema.json. >

Re: privileged entropy sources in QEMU/KVM guests

2019-11-07 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > Hi, > > related TianoCore BZ: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > (I'm starting this thread separately because at least some of the topics > are specific to QEMU, and I didn't want to litter the BZ with a > discussion that

Re: privileged entropy sources in QEMU/KVM guests

2019-11-07 Thread Ard Biesheuvel
Hi Laszlo, Thanks for starting this thread. On Thu, 7 Nov 2019 at 11:11, Laszlo Ersek wrote: > > Hi, > > related TianoCore BZ: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > (I'm starting this thread separately because at least some of the topics > are specific to QEMU, and I

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-11-07 Thread Daniel P . Berrangé
On Thu, Oct 17, 2019 at 03:01:46PM +0200, Kevin Wolf wrote: > This series adds a new tool 'qemu-storage-daemon', which can be used to > export and perform operations on block devices. There is some overlap > between qemu-img/qemu-nbd and the new qemu-storage-daemon, but there are > a few important

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Aleksandar Markovic
On Thursday, November 7, 2019, Rajath Shashidhara wrote: > Hi all, > > I am a Computer Science graduate student at The University of Texas at > Austin (UT, Austin). I am looking forward to contributing to qemu ! > > This semester, I am taking a class in Virtualization ( >

Re: [PATCH v3 11/16] hw/arm/raspi: Use -smp cores= option to restrict enabled cores

2019-11-07 Thread Bonnans, Laurent
On 10/20/19 1:47 AM, Philippe Mathieu-Daudé wrote: > The abstract TYPE_BCM283X device provides a 'enabled-cpus' property > to restrict the number of cores powered on reset. This because on > real hardware the GPU is responsible of starting the cores and keep > them spinning until the Linux kernel

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-07 Thread Max Reitz
On 07.11.19 11:12, Kevin Wolf wrote: > Am 06.11.2019 um 15:32 hat Max Reitz geschrieben: >> On 17.10.19 15:02, Kevin Wolf wrote: >>> This adds and parses the --monitor option, so that a QMP monitor can be >>> used in the storage daemon. The monitor offers commands defined in the >>> QAPI schema at

[Bug 1851547] Re: qemu 4 crashes with this parameter attached -usb -device usb-host, hostbus=1, hostaddr=7 \

2019-11-07 Thread Dr. David Alan Gilbert
Hi Marietto, Can you attach an lsusb output from your host? I'm curious what host bug 1, addr 7 and 8 are. Dave -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851547 Title: qemu 4 crashes with

Re: [PATCH v2 05/21] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-11-07 Thread Maxim Levitsky
On Thu, 2019-11-07 at 10:08 +0100, Max Reitz wrote: > On 06.11.19 16:45, Maxim Levitsky wrote: > > On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > > > Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' > > > globally. That is not how it should be done; instead, they should > >

  1   2   3   >