[PATCH 1/5] MAINTAINERS: Add a section on git infrastructure

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic There should be a patient person maintaining gory details of git-related files, and there is no better person for that role than Philippe. Alex should be the reviewer for some relations with gitdm. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 17

[PATCH 3/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the maintainership for Fulong 2E board to improve its quality. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 69cdc13..4a478f8 100644 ---

Re: Looking for issues/features for my first contribution

2019-11-08 Thread Aleksandar Markovic
> [c] DS3231 also has programmable square-wave output + 32 KHz output pin. > M41T80 chip also supports this feature. However, qemu does not support > emulation of these features [2]. Do I take the same approach ? Hi, Rajath. I would rather have you amend M41T80, if there is a missing

Re: [RFC v5 023/126] hw/vfio/ap: drop local_err from vfio_ap_realize

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 9:27 PM Vladimir Sementsov-Ogievskiy wrote: > > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/vfio/ap.c | 16 +++- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH v1 2/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread David Hildenbrand
On 08.11.19 20:51, Eduardo Habkost wrote: On Fri, Nov 08, 2019 at 12:07:14PM +0100, David Hildenbrand wrote: For a specific CPU model, we have a lot of feature variability depending on - The microcode version of the HW - The hypervisor we're running on (LPAR vs. KVM vs. z/VM) - The hypervisor

Re: [RFC v5 026/126] python: add commit-per-subsystem.py

2019-11-08 Thread Marc-André Lureau
Hi On Fri, Oct 11, 2019 at 9:11 PM Vladimir Sementsov-Ogievskiy wrote: > > Add script to automatically commit tree-wide changes per-subsystem. Oh interesting! I guess it could use a --help or a larger commit message to explain a bit what it does (I imagine from the rest of the series, but

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-08 Thread Laurent Vivier
On 08/11/2019 17:47, Greg Kurz wrote: > On Fri, 8 Nov 2019 16:40:35 +0100 > Laurent Vivier wrote: > >> Commit 29cb4187497d sets by default the VSMT to smp_threads, >> but older kernels (< 4.13) don't support that. >> >> We can reasonably restore previous behavior with this kernel >> to allow to

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-08 Thread Greg Kurz
On Fri, 8 Nov 2019 16:40:35 +0100 Laurent Vivier wrote: > Commit 29cb4187497d sets by default the VSMT to smp_threads, > but older kernels (< 4.13) don't support that. > > We can reasonably restore previous behavior with this kernel > to allow to run QEMU as before. > > If VSMT is not

[PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Palmer Dabbelt
The test finisher implements the reset command, which means it's a "sifive,test1" device. This is a backwards compatible change, so it's also a "sifive,test0" device. I copied the odd idiom for adding a two-string compatible field from the ARM virt board. Fixes: 9a2551ed6f ("riscv: sifive_test:

[PULL 0/2] Q800 branch patches

2019-11-08 Thread Laurent Vivier
The following changes since commit 1cee80fa665d37411f8ad8a930b84840bbab62e5: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20191107-pull-request' into staging (2019-11-08 11:00:28 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git

[PULL 2/2] dp8393x: fix dp8393x_receive()

2019-11-08 Thread Laurent Vivier
RXpkt.in_use is always 16 bit wide, but when the bus access mode is 32bit and the endianness is big, we must access the second word and not the first. This patch adjusts the offset according to the size and endianness. This fixes DHCP for Q800 guest. Fixes: be9208419865 ("dp8393x: manage big

Re: [RFC v5 022/126] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 8:58 PM Vladimir Sementsov-Ogievskiy wrote: > > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > backends/cryptodev.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Palmer Dabbelt
On Fri, 08 Nov 2019 10:04:47 PST (-0800), Peter Maydell wrote: On Fri, 8 Nov 2019 at 17:15, Alistair Francis wrote: On Fri, Nov 8, 2019 at 9:05 AM Palmer Dabbelt wrote: > > The test finisher implements the reset command, which means it's a > "sifive,test1" device. This is a backwards

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread Dr. David Alan Gilbert
Hi Jens, the unplug failover stuff is triggering an assertion occasionally on aarch64; but a) I'm not sure the right way to fix it b) And I'm out for a little over a week so... * no-re...@patchew.org (no-re...@patchew.org) wrote: > Patchew URL: >

[PATCH v2 2/3] ARM/virt: Use fdt_setprop_strings()

2019-11-08 Thread Palmer Dabbelt
This new helper function encodes the idiom used by the ARM virt board to set a string array. I don't currently have a working ARM userspace, so I haven't tested this, but I made the helper function because I wanted to use it for the RISC-V virt board where I have tested it. Signed-off-by:

[PATCH v2 1/3] device_tree: Add a helper function for string arrays

2019-11-08 Thread Palmer Dabbelt
The device tree format allows for arrays of strings, which are encoded with '\0's inside regular strings. These are ugly to represent in C, so the helper function represents them as strings with internal '\0's that are terminated with a double '\0'. In other words, the array ["string1",

[PATCH v2 0/3] device_tree: Allow for and use string arrays [Was: RISC-V: virt: This is a "sifive, test1" test finisher]

2019-11-08 Thread Palmer Dabbelt
Device trees commonly contain arrays of strings for compatible nodes. We recently extended the "sifive,test0" node in a backwards-compatible way, but QEMU didn't contain an FDT function to set 'compatible = "sifive,test1", "sifive,test0";'. I've converted over the code from the ARM virt board

Re: [RFC v5 010/126] hw/core/qdev: cleanup Error ** variables

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 8:18 PM Vladimir Sementsov-Ogievskiy wrote: > > Rename Error ** parameter in check_only_migratable to common errp. > > In device_set_realized: > > - Move "if (local_err != NULL)" closer to error setters. > > - Drop 'Error **local_errp': it doesn't save any LoCs, but it's

Re: [RFC PATCH 10/18] qemu-storage-daemon: Add --chardev option

2019-11-08 Thread Markus Armbruster
Kevin Wolf writes: > This adds a --chardev option to the storage daemon that works the same > as the -chardev option of the system emulator. > > Signed-off-by: Kevin Wolf > --- > qemu-storage-daemon.c | 19 +++ > Makefile | 2 +- > 2 files changed, 20

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108110714.7475-1-da...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants Type: series Message-id:

Re: [PATCH v1 2/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread Eduardo Habkost
On Fri, Nov 08, 2019 at 12:07:14PM +0100, David Hildenbrand wrote: > For a specific CPU model, we have a lot of feature variability depending on > - The microcode version of the HW > - The hypervisor we're running on (LPAR vs. KVM vs. z/VM) > - The hypervisor version we're running on > - The KVM

[PATCH v2 3/3] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Palmer Dabbelt
The test finisher implements the reset command, which means it's a "sifive,test1" device. This is a backwards compatible change, so it's also a "sifive,test0" device. Fixes: 9a2551ed6f ("riscv: sifive_test: Add reset functionality") Signed-off-by: Palmer Dabbelt --- hw/riscv/virt.c | 3 ++- 1

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-08 Thread Alistair Francis
On Thu, Nov 7, 2019 at 8:58 AM Palmer Dabbelt wrote: > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow

Re: [PATCH v2 1/3] target/microblaze: Plug temp leaks for loads/stores

2019-11-08 Thread Alistair Francis
On Fri, Nov 8, 2019 at 4:43 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Simplify endian reversion of address also plugging TCG temp > leaks for loads/stores. > > Suggested-by: Richard Henderson > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair >

Re: [RFC PATCH 12/18] stubs: Update monitor stubs for qemu-storage-daemon

2019-11-08 Thread Markus Armbruster
Kevin Wolf writes: > Before we can add the monitor to qemu-storage-daemon, we need to add a > few monitor stubs, I can see just one: monitor_fdsets_cleanup(). >and we need to make sure that stubs that are actually > implemented in the monitor core aren't linked so that we

Re: [PULL v2 00/73] tcg plugins and testing updates

2019-11-08 Thread Peter Maydell
On Wed, 6 Nov 2019 at 12:42, Markus Armbruster wrote: > > Markus Armbruster writes: > > > Alex Bennée writes: > > > >> Markus Armbruster writes: > >> > >>> I hate to interfere with the merging of working code for non-technical > >>> reasons > >>> > >>> This is a plugin interface. As I

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-08 Thread Greg Kurz
On Fri, 8 Nov 2019 18:03:08 +0100 Laurent Vivier wrote: > On 08/11/2019 17:47, Greg Kurz wrote: > > On Fri, 8 Nov 2019 16:40:35 +0100 > > Laurent Vivier wrote: > > > >> Commit 29cb4187497d sets by default the VSMT to smp_threads, > >> but older kernels (< 4.13) don't support that. > >> > >>

Re: [PULL 1/3] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-11-08 Thread Peter Maydell
On Wed, 23 Oct 2019 at 03:04, Eric Blake wrote: > > From: Vladimir Sementsov-Ogievskiy > > Introduce a function to gracefully wake a coroutine sleeping in > qemu_co_sleep_ns(). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Kevin Wolf > Reviewed-by: Eric Blake > Message-Id:

Re: Looking for issues/features for my first contribution

2019-11-08 Thread Aleksandar Markovic
> [a] Is there any particular reason that you picked DS3231 ? Linux kernel > has drivers for DS3232/34 only [1]. I did read the datasheets of both > 3232 & 3231 and found that they are quite similar except for the 236 > bytes of SRAM support found only in 3232. > Yes, DS3231 is a part of a board

[PATCH] WHPX: refactor load library

2019-11-08 Thread Sunil Muthuswamy
This refactors the load library of WHV libraries to make it more modular. It makes a helper routine that can be called on demand. This allows future expansion of load library/functions to support functionality that is depenedent on some feature being available. Signed-off-by: Sunil Muthuswamy

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé wrote: > On 11/8/19 4:43 PM, Eric Blake wrote: > > bzip2 is no longer a favored compression. If we are trying to pick a > > compression that is most likely to be present on any system, go with > > gzip. If we are trying to pick a compression

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Alistair Francis
On Fri, Nov 8, 2019 at 9:05 AM Palmer Dabbelt wrote: > > The test finisher implements the reset command, which means it's a > "sifive,test1" device. This is a backwards compatible change, so it's > also a "sifive,test0" device. I copied the odd idiom for adding a > two-string compatible field

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108104307.125020-1-dgilb...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108104307.125020-1-dgilb...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [RFC v5 006/126] qdev-monitor: well form error hint helpers

2019-11-08 Thread Marc-André Lureau
Hi On Fri, Oct 11, 2019 at 8:11 PM Vladimir Sementsov-Ogievskiy wrote: > > Make qbus_list_bus and qbus_list_dev hint append helpers well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp), rename functions to be error_append_*_hint. > > Signed-off-by:

Re: [RFC v5 008/126] ppc: well form kvmppc_hint_smt_possible error hint helper

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 8:14 PM Vladimir Sementsov-Ogievskiy wrote: > > Make kvmppc_hint_smt_possible hint append helper well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp), rename function to be error_append_*_hint. > > Signed-off-by: Vladimir

Re: [RFC v5 024/126] error: auto propagated local_err

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 10:11 PM Vladimir Sementsov-Ogievskiy wrote: > > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_prepend/error_append_hint: user > can't see this

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 4:43 PM, Eric Blake wrote: On 11/8/19 5:01 AM, Laszlo Ersek wrote: Add a check in ./configure to warn the user if bzip2 is missing. We've come full circle. Let me explain: Fixes: 536d2173b2b So this makes me kinda grumpy. If you look at the v3 posting of the patch that

[PATCH v2 for-4.2] Remove unassigned_access CPU hook

2019-11-08 Thread Peter Maydell
All targets have now migrated away from the old unassigned_access hook to the new do_transaction_failed hook. This means we can remove the core-code infrastructure for that hook and the code that calls it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair

Re: [PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets

2019-11-08 Thread Laszlo Ersek
On 11/08/19 12:45, Philippe Mathieu-Daudé wrote: > The EDK2 firmware blobs only target the X86/ARM architectures. > Define the DECOMPRESS_EDK2_BLOBS variable and only decompress > the blobs when the variable exists. > > Fixes: 536d2173b2b > Suggested-by: Thomas Huth > Signed-off-by: Philippe

Re: [RFC v5 000/126] error: auto propagated local_err

2019-11-08 Thread Marc-André Lureau
Hi On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy wrote: > > Finally, what is the plan? > > Markus what do you think? > > Now a lot of patches are reviewed, but a lot of are not. > > Is there any hope that all patches will be reviewed? Should I resend the > whole series, or may be

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread Eduardo Habkost
On Fri, Nov 08, 2019 at 01:02:28PM +, Peter Maydell wrote: > On Fri, 8 Nov 2019 at 12:46, David Hildenbrand wrote: > > There is a small but important difference between "max"/"host" and > > "best". Max really means "all features", including deprecated ones. > > "best", however, can disable

[PATCH 4/5] MAINTAINERS: Adjust maintainership for Malta board

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the maintainership for Malta board to improve its quality. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4a478f8..1a49381 100644 --- a/MAINTAINERS +++

[PATCH 2/5] MAINTAINERS: Add a section on UI translation

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic There should be a person who will quickly evaluate new UI translation, and find a way to update existing ones should something changes in UI. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS

[PATCH 0/5] MAINTAINERS: Fine adjustment for (mostly mips) content

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic The goal of this series is to: * reduce the amount of "unmainatined" files (not having their maintainer in "MAINTAINERS") * reduce the amount of nominally maintained files, but unmaintained in reality * increase the role of non-mips open source

Re: [PATCH] gdbstub: Fix buffer overflow in handle_read_all_regs

2019-11-08 Thread Alex Bennée
Damien Hedde writes: > On 11/8/19 3:09 PM, Alex Bennée wrote: >> >> Damien Hedde writes: >> >>> Ensure we don't put too much register data in buffers. This avoids >>> a buffer overflow (and stack corruption) when a target has lots >>> of registers. >>> >>> Signed-off-by: Damien Hedde >>> ---

Re: [PATCH v6 01/25] qmp: constify QmpCommand and list

2019-11-08 Thread Damien Hedde
On 11/8/19 4:00 PM, Marc-André Lureau wrote: > Since 0b69f6f72ce47a37a749b056b6d5ec64c61f11e8 "qapi: remove > qmp_unregister_command()", the command list can be declared const. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/dispatch.h | 9 + > monitor/misc.c

Re: [PATCH v2 2/2] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 12:48, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 12:45:31PM +0100, Philippe Mathieu-Daudé wrote: >> The bzip2 tool is not included in default installations. >> On freshly installed systems, ./configure succeeds but 'make' >> might fail later: >> >> BUNZIP2

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 17:15, Alistair Francis wrote: > > On Fri, Nov 8, 2019 at 9:05 AM Palmer Dabbelt wrote: > > > > The test finisher implements the reset command, which means it's a > > "sifive,test1" device. This is a backwards compatible change, so it's > > also a "sifive,test0" device. I

[PATCH 5/5] MAINTAINERS: Adjust maintainership for R4000 systems

2019-11-08 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the maintainership for R4000 systems to improve its quality. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1a49381..62e7d6d 100644 --- a/MAINTAINERS

Re: [PATCH v7 8/8] Acceptance test: add "boot_linux" tests

2019-11-08 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc and q35 machine types, with and without kvm as an accellerator * aarch64 and

Re: [PATCH v2 0/1] virtio: fix IO request length in virtio SCSI/block

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108134249.19004-1-dplotni...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[PULL 1/2] dp8393x: put the DMA buffer in the state structure

2019-11-08 Thread Laurent Vivier
Move it from the stack. It's only 24 bytes, and this simplifies the dp8393x_get()/ dp8393x_put() interface. Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Message-Id: <20191106112341.23735-2-laur...@vivier.eu> --- hw/net/dp8393x.c | 105

Re: Looking for issues/features for my first contribution

2019-11-08 Thread BALATON Zoltan
Hello, On Fri, 8 Nov 2019, Aleksandar Markovic wrote: [c] DS3231 also has programmable square-wave output + 32 KHz output pin. M41T80 chip also supports this feature. However, qemu does not support emulation of these features [2]. Do I take the same approach ? Hi, Rajath. I would rather have

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread David Hildenbrand
On 08.11.19 20:10, Eduardo Habkost wrote: On Fri, Nov 08, 2019 at 01:02:28PM +, Peter Maydell wrote: On Fri, 8 Nov 2019 at 12:46, David Hildenbrand wrote: There is a small but important difference between "max"/"host" and "best". Max really means "all features", including deprecated ones.

Re: [PATCH 0/2] replace sysconf(_SC_PAGESIZE) with qemu_real_host_page_size

2019-11-08 Thread Wei Yang
On Tue, Oct 15, 2019 at 11:13:48AM +0800, Wei Yang wrote: >This is a following up patch to cleanup page size, suggested by >"Dr. David Alan Gilbert" . > >Patch 2 does the job, while during the cleanup I found test-mmap.c has quite a >lot code style problem. To make the code looks good, patch 1 is

Re: guest / host buffer sharing ...

2019-11-08 Thread Stéphane Marchesin
On Thu, Nov 7, 2019 at 11:35 PM Stefan Hajnoczi wrote: > > On Fri, Nov 8, 2019 at 8:22 AM Gerd Hoffmann wrote: > > > > Adding a list of common properties to the spec certainly makes sense, > > > > so everybody uses the same names. Adding struct-ed properties for > > > > common use cases might

Re: [PULL 1/3] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-11-08 Thread Eric Blake
On 11/8/19 12:42 PM, Peter Maydell wrote: On Wed, 23 Oct 2019 at 03:04, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Introduce a function to gracefully wake a coroutine sleeping in qemu_co_sleep_ns(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf

Re: [RFC v5 024/126] error: auto propagated local_err

2019-11-08 Thread Eric Blake
On 11/8/19 3:10 PM, Marc-André Lureau wrote: +/* + * ERRP_AUTO_PROPAGATE + * + * This macro is created to be the first line of a function with Error **errp + * OUT parameter. It's needed only in cases where we want to use error_prepend, + * error_append_hint or dereference *errp. It's still

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Eric Blake
On 11/8/19 5:01 AM, Laszlo Ersek wrote: Add a check in ./configure to warn the user if bzip2 is missing. We've come full circle. Let me explain: Fixes: 536d2173b2b So this makes me kinda grumpy. If you look at the v3 posting of the patch that would later become commit 536d2173b2b:

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-08 Thread IndrasenaReddy Gali
After increasing dma_entry_limit limit no issue observed. But ideal senario device is getting hung and recovery happening only with host hard rebooting. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-08 Thread Eric Blake
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe

Re: [RFC PATCH 08/18] qemu-storage-daemon: Add --export option

2019-11-08 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.11.2019 um 14:11 hat Max Reitz geschrieben: >> On 17.10.19 15:01, Kevin Wolf wrote: >> > Add a --export option to qemu-storage-daemon to export a block node. For >> > now, only NBD exports are implemented. Apart from the 'type' option >> > (which is the implied key),

Re: [PATCH v5 00/13] Multi-phase reset mechanism

2019-11-08 Thread Damien Hedde
On 11/8/19 4:28 PM, Peter Maydell wrote: > On Fri, 8 Nov 2019 at 15:26, Damien Hedde wrote: >> >> >> On 10/29/19 4:53 PM, Damien Hedde wrote: >>> Hi, >>> >>> Does anyone has comment about the interface / patch 3 ? >>> Should I try to split it ? >> >> ping > > Hi; this patchset is still in my

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-08 Thread Peter Maydell
On Mon, 4 Nov 2019 at 11:52, Alexander Graf wrote: > > The current pl031 RTCICR register implementation always clears the IRQ > pending status on a register write, regardless of the value it writes. > > To justify that behavior, it references the arm926e documentation > (DDI0287B) and indicates

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-08 Thread Eric Blake
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe

Re: [RFC PATCH 09/18] qemu-storage-daemon: Add main loop

2019-11-08 Thread Markus Armbruster
Kevin Wolf writes: > Instead of exiting after processing all command line options, start a > main loop and keep processing events until exit is requested with a > signal (e.g. SIGINT). > > Now qemu-storage-daemon can be used as an alternative for qemu-nbd that > provides a few features that were

Re: [PATCH v6 02/25] json-lexer: make it safe to call destroy multiple times

2019-11-08 Thread Damien Hedde
On 11/8/19 4:01 PM, Marc-André Lureau wrote: > We can easily avoid the burden of checking if the lexer was > initialized prior to calling destroy by the caller, let's do it. > > This allows simplification in state tracking with the following patch, > "qmp: add QmpSession" can call

Re: [PATCH v2 3/7] configure: Detect compiler support for __attribute__((alias))

2019-11-08 Thread Thomas Huth
On 25/10/2019 16.04, Alex Bennée wrote: Richard Henderson writes: Such support is present almost everywhere, except for Xcode 9. It is added in Xcode 10, but travis uses xcode9 by default, so we should support it for a while yet. We really should get someone who has an AppleID to check

Re: [PATCH v2 3/3] trace: Forbid dynamic field width in event format

2019-11-08 Thread Eric Blake
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), forbid them. Add a check to refuse field width in new formats: +++ b/scripts/tracetool/__init__.py @@ -206,6 +206,7 @@ class Event(object):

Re: [PATCH 1/5] hw/arm: Align ACPI blob len to PAGE size

2019-11-08 Thread Igor Mammedov
On Fri, 4 Oct 2019 16:52:58 +0100 Shameer Kolothum wrote: > If ACPI blob length modifications happens after the initial > virt_acpi_build() call, and the changed blob length is within > the PAGE size boundary, then the revised size is not seen by > the firmware on Guest reboot. The is because in

Re: [PATCH] tcg plugins: expose an API version concept

2019-11-08 Thread Alex Bennée
Peter Maydell writes: > On Mon, 4 Nov 2019 at 13:18, Alex Bennée wrote: >> >> This is a very simple versioning API which allows the plugin >> infrastructure to check the API a plugin was built against. We also >> expose a min/cur API version to the plugin via the info block in case >> it

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-08 Thread Markus Armbruster
Tao Xu writes: > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: >> On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: >>> On 11/7/2019 4:53 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: > Add tests for time input such as zero, around limit of

Re: [PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-08 Thread gengdongjiu
On 2019/11/4 20:14, Xiang Zheng wrote: > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER section, > currently it is

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:01 PM, Laszlo Ersek wrote: On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh:

Re: [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108101655.10611-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 12.39, Laszlo Ersek wrote: On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but

Re: [PATCH v15 07/12] numa: Calculate hmat latency and bandwidth entry list

2019-11-08 Thread Igor Mammedov
On Thu, 7 Nov 2019 15:45:06 +0800 Tao Xu wrote: > Compress HMAT latency and bandwidth raw data into uint16_t data, > which can be stored in HMAT table. > > Suggested-by: Igor Mammedov > Signed-off-by: Tao Xu > --- > > No changes in v15. > > Changes in v14: > - Convert latency from ns

[PATCH for-5.0 v4 4/5] iotests: Add @error to wait_until_completed

2019-11-08 Thread Max Reitz
Callers can use this new parameter to expect failure during the completion process. Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH for-5.0 v4 3/5] blkdebug: Allow taking/unsharing permissions

2019-11-08 Thread Max Reitz
Sometimes it is useful to be able to add a node to the block graph that takes or unshare a certain set of permissions for debugging purposes. This patch adds this capability to blkdebug. (Note that you cannot make blkdebug release or share permissions that it needs to take or cannot share,

Re: [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores

2019-11-08 Thread Edgar E. Iglesias
On Thu, Nov 07, 2019 at 03:19:20PM +0100, Richard Henderson wrote: > On 11/6/19 3:14 PM, Edgar E. Iglesias wrote: > > @@ -967,12 +967,14 @@ static void dec_load(DisasContext *dc) > > 10 -> 10 > > 11 -> 00 */ > > TCGv low = tcg_temp_new(); >

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread David Hildenbrand
On 08.11.19 12:10, Peter Maydell wrote: On Fri, 8 Nov 2019 at 11:08, David Hildenbrand wrote: There was recently a discussion regarding CPU model versions. That concept does not fit s390x where we have a lot of feature variability. I proposed an alternative approach in [1], which might work

Re: Looking for issues/features for my first contribution

2019-11-08 Thread Richard Henderson
On 11/8/19 10:08 AM, Alex Bennée wrote: > Rajath Shashidhara writes: >> [b] As per the datasheet, DS3231 has a built-in temperature sensor. >> Temperature can be read from a dedicated register. There can be two >> approaches to emulating this: (1) Return a constant temperature value >> on every

Re: [PULL 06/28] spapr: Set VSMT to smp_threads by default

2019-11-08 Thread Laurent Vivier
On 24/10/2019 10:17, David Gibson wrote: > From: Greg Kurz > > Support for setting VSMT is available in KVM since linux-4.13. Most distros > that support KVM on POWER already have it. It thus seem reasonable enough > to have the default machine to set VSMT to smp_threads. > > This brings

Re: [PATCH v2 1/3] target/microblaze: Plug temp leaks for loads/stores

2019-11-08 Thread Richard Henderson
On 11/8/19 1:42 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Simplify endian reversion of address also plugging TCG temp > leaks for loads/stores. > > Suggested-by: Richard Henderson > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 46

Re: [PATCH v2 05/11] block/crypto: implement the encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-11-08 at 14:12 +0100, Max Reitz wrote: > On 08.11.19 12:04, Maxim Levitsky wrote: > > On Fri, 2019-11-08 at 11:49 +0100, Max Reitz wrote: > > > On 08.11.19 10:30, Maxim Levitsky wrote: > > > > On Fri, 2019-10-04 at 20:41 +0200, Max Reitz wrote: > > > > > On 13.09.19 00:30, Maxim

Re: QEMU HTML documentation now on qemu.org

2019-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2019 at 04:01:42PM +, Daniel P. Berrangé wrote: > On Thu, Nov 07, 2019 at 04:44:34PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 7, 2019 at 11:07 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Nov 06, 2019 at 05:19:28PM +0100, Stefan Hajnoczi wrote: > > > > Hi, > > >

[PATCH 2/2] iotests: Test multiple blockdev-snapshot calls

2019-11-08 Thread Kevin Wolf
Test that doing a second blockdev-snapshot doesn't make the first overlay's backing file go away. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/273 | 76 + tests/qemu-iotests/273.out | 337 + tests/qemu-iotests/group | 1 + 3 files

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-08 Thread Markus Armbruster
Quick observation: --help fails to mention --monitor.

Re: [PATCH v2] ivshmem-server: Clean up shmem on shutdown

2019-11-08 Thread Jan Kiszka
On 06.08.19 15:01, Claudio Fontana wrote: On 8/5/19 7:54 AM, Jan Kiszka wrote: From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the user to explicitly remove it in order to start a new instance. Signed-off-by: Jan Kiszka ---

Re: Deprecating stuff for 4.2

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
08.11.2019 9:41, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > [...] >>> Pre-release period, time to deprecate some stuffs :) >>> >>> How should we proceed? Do you have something in mind? >>> >>> There are older threads

[PATCH 1/4 V2] block: add SCSI COMPARE_AND_WRITE support

2019-11-08 Thread Yaowei Bai
Some storages(i.e. librbd) already have interfaces to handle some SCSI commands directly. This patch adds COMPARE_AND_WRITE command support through the write path in the block io layer by introducing a new element BDRV_REQ_COMPARE_AND_WRITE into BdrvRequestFlags which indicates a COMPARE_AND_WRITE

[PATCH 4/4 V2] scsi-disk: add FUA support for COMPARE_AND_WRITE

2019-11-08 Thread Yaowei Bai
It is implemented in the blk_aio_pwritev's callback function in a way similar to its emulation in scsi_write_do_fua function Signed-off-by: Yaowei Bai --- hw/scsi/scsi-disk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-08 Thread Thomas Huth
On 07/11/2019 20.27, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@

[PATCH 1/3] docs: fix rst syntax errors in unbuilt docs

2019-11-08 Thread Stefan Hajnoczi
The .rst files outside docs/{devel,interop,specs} aren't built yet and therefore a few syntax errors have slipped through. Fix them. Signed-off-by: Stefan Hajnoczi --- docs/arm-cpu-features.rst| 6 +++--- docs/virtio-net-failover.rst | 4 ++-- docs/virtio-pmem.rst | 19

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: ***

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command not found > make: ***

Re: [RFC v4 PATCH 49/49] multi-process: add configure and usage information

2019-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2019 at 10:53:27AM -0500, Jag Raman wrote: > > > On 11/7/2019 9:39 AM, Daniel P. Berrangé wrote: > > On Thu, Nov 07, 2019 at 03:02:20PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Oct 24, 2019 at 05:09:30AM -0400, Jagannathan Raman wrote: > > > > From: Elena Ufimtseva > > > > >

Re: [RFC v4 PATCH 49/49] multi-process: add configure and usage information

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:17:41PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 07, 2019 at 09:33:45AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2019 at 03:02:20PM +0100, Stefan Hajnoczi wrote: > > > This documentation suggests that QEMU spawns the remote processes. How > > > do this

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Stefan Hajnoczi
On Fri, Nov 8, 2019 at 11:52 AM Peter Maydell wrote: > On Fri, 8 Nov 2019 at 09:59, Stefan Hajnoczi wrote: > > Build docs/ in a single sphinx invocation instead of treating > > docs/{devel,interop,specs} separately. This allows us to build a global > > index page that links to documentation

  1   2   3   >