Re: [PATCH 1/2] tests/tcg/multiarch: fix code style in function main of test-mmap.c

2019-11-11 Thread Stefano Garzarella
On Tue, Oct 15, 2019 at 11:13:49AM +0800, Wei Yang wrote: > This file uses quite a different code style and changing just one line > would leads to some awkward appearance. > > This is a preparation for the following replacement of > sysconf(_SC_PAGESIZE). > > BTW, to depress ERROR message from

Re: [PULL 0/2] Q800 branch patches

2019-11-11 Thread Peter Maydell
On Fri, 8 Nov 2019 at 20:40, Laurent Vivier wrote: > > The following changes since commit 1cee80fa665d37411f8ad8a930b84840bbab62e5: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20191107-pull-request' into staging (2019-11-08 > 11:00:28 +) > > are available in the Git

Re: [PATCH 1/2] hw/vfio/pci: Fix double free of migration_blocker

2019-11-11 Thread Cornelia Huck
On Mon, 11 Nov 2019 11:37:41 +0100 Michal Privoznik wrote: > When user tries to hotplug a VFIO device, but the operation fails > somewhere in the middle (in my testing it failed because of > RLIMIT_MEMLOCK forbidding more memory allocation), then a double > free occurs. In vfio_realize() the

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-11-11 Thread Kevin Wolf
Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > From: Aarushi Mehta > > Signed-off-by: Aarushi Mehta > Signed-off-by: Stefan Hajnoczi This commit message needs to answer at least where these stubs are actually used. Aren't all callers protected with #ifdef CONFIG_LINUX_IO_URING?

Re: [PATCH v2 1/1] virtio: make seg_max virtqueue size dependent

2019-11-11 Thread Denis Plotnikov
On 11.11.2019 14:19, Stefan Hajnoczi wrote: > On Fri, Nov 08, 2019 at 04:42:49PM +0300, Denis Plotnikov wrote: >> +virtio_stl_p(vdev, _max, s->conf.queue_size - 2); > [...] >> +virtio_stl_p(vdev, >seg_max, s->conf.virtqueue_size - 2); > Please extend the queue_size checks to report an

[PATCH v3 16/21] nvme: support multiple namespaces

2019-11-11 Thread Klaus Jensen
This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This changes how an nvme device is created. Example with

[PATCH v3 15/21] nvme: add support for scatter gather lists

2019-11-11 Thread Klaus Jensen
For now, support the Data Block, Segment and Last Segment descriptor types. See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). Signed-off-by: Klaus Jensen Acked-by: Fam Zheng --- block/nvme.c | 18 +- hw/block/nvme.c | 380

[PATCH v3 17/21] nvme: bump controller pci device id

2019-11-11 Thread Klaus Jensen
Since commits 9d6459d21a6e ("nvme: fix write zeroes offset and count") and c7fe50bcf1f1 ("nvme: support multiple namespaces") the controller device no longer has the quirks that the Linux kernel think it has. As the quirks are applied based on pci vendor and device id, bump the device id to get

Re: [PATCH v3] iotests: Test NBD client reconnection

2019-11-11 Thread Andrey Shinkevich
On 08/11/2019 16:49, Vladimir Sementsov-Ogievskiy wrote: > 01.11.2019 19:54, Andrey Shinkevich wrote: >> The test for an NBD client. The NBD server is disconnected after the >> client write request. The NBD client should reconnect and complete >> the write operation. >> >> Suggested-by: Denis V.

Re: [PATCH v3] iotests: Test NBD client reconnection

2019-11-11 Thread Roman Kagan
On Mon, Nov 11, 2019 at 12:18:48PM +0300, Andrey Shinkevich wrote: > > > On 08/11/2019 17:05, Roman Kagan wrote: > > On Fri, Nov 08, 2019 at 01:49:50PM +, Vladimir Sementsov-Ogievskiy > > wrote: > >> 01.11.2019 19:54, Andrey Shinkevich wrote: > >>> +def check_proc_NBD(proc, connector): >

[PATCH v4] iotests: Test NBD client reconnection

2019-11-11 Thread Andrey Shinkevich
The test for an NBD client. The NBD server is disconnected after the client write request. The NBD client should reconnect and complete the write operation. Suggested-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- v3 was discussed in the

[PATCH 1/2] hw/vfio/pci: Fix double free of migration_blocker

2019-11-11 Thread Michal Privoznik
When user tries to hotplug a VFIO device, but the operation fails somewhere in the middle (in my testing it failed because of RLIMIT_MEMLOCK forbidding more memory allocation), then a double free occurs. In vfio_realize() the vdev->migration_blocker is allocated, then something goes wrong which

[PATCH 2/2] vfio-helpers: Free QEMUVFIOState in qemu_vfio_close()

2019-11-11 Thread Michal Privoznik
The qemu_vfio_open_pci() allocates this QEMUVFIOState structure but free counterpart is missing. Since we already have qemu_vfio_close() which does cleanup of the state, it looks like a perfect place to free the structure too. ==178278== 528 (360 direct, 168 indirect) bytes in 1 blocks are

[PATCH v3 11/21] nvme: add missing mandatory features

2019-11-11 Thread Klaus Jensen
Add support for returning a resonable response to Get/Set Features of mandatory features. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 51 --- hw/block/trace-events | 2 ++ include/block/nvme.h | 3 ++- 3 files changed, 52 insertions(+), 4

[PATCH v3 02/21] nvme: move device parameters to separate struct

2019-11-11 Thread Klaus Jensen
Move device configuration parameters to separate struct to make it explicit what is configurable and what is set internally. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 44 ++-- hw/block/nvme.h | 16 +--- 2 files changed, 35

[PATCH v3 07/21] nvme: refactor device realization

2019-11-11 Thread Klaus Jensen
This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 176 +++- hw/block/nvme.h | 22 ++ 2 files changed, 135 insertions(+), 63

[PATCH v3 14/21] nvme: allow multiple aios per command

2019-11-11 Thread Klaus Jensen
This refactors how the device issues asynchronous block backend requests. The NvmeRequest now holds a queue of NvmeAIOs that are associated with the command. This allows multiple aios to be issued for a command. Only when all requests have been completed will the device post a completion queue

[PATCH v3 18/21] nvme: remove redundant NvmeCmd pointer parameter

2019-11-11 Thread Klaus Jensen
The command struct is available in the NvmeRequest that we generally pass around anyway. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 218 +++- 1 file changed, 106 insertions(+), 112 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c

Re: [RFC PATCH 13/18] qapi: Create module 'monitor'

2019-11-11 Thread Markus Armbruster
Kevin Wolf writes: > misc.json contains definitions that are related to the system emulator, > so it can't be used for the storage daemon. This patch moves basic > functionality that is related to the monitor itself into a new > monitor.json, which could be used in tools as well. > >

Re: [PATCH 4/5] MAINTAINERS: Adjust maintainership for Malta board

2019-11-11 Thread Aurelien Jarno
On 2019-11-08 20:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the maintainership for Malta board to improve its quality. > > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 1/2] tests/tcg/multiarch: fix code style in function main of test-mmap.c

2019-11-11 Thread Alex Bennée
Wei Yang writes: > This file uses quite a different code style and changing just one line > would leads to some awkward appearance. > > This is a preparation for the following replacement of > sysconf(_SC_PAGESIZE). > > BTW, to depress ERROR message from checkpatch.pl, this patch replaces >

[PATCH v3 03/21] nvme: add missing fields in the identify controller data structure

2019-11-11 Thread Klaus Jensen
Not used by the device model but added for completeness. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/1] pci: pass along the return value of dma_memory_rw

2019-11-11 Thread Klaus Birkelund
On Thu, Oct 24, 2019 at 01:13:36AM +0200, Philippe Mathieu-Daudé wrote: > On 10/11/19 9:01 AM, Klaus Jensen wrote: > > Some might actually care about the return value of dma_memory_rw. So > > let us pass it along instead of ignoring it. > > > > Signed-off-by: Klaus Jensen > > --- > >

Re: [PATCH 1/1] pci: pass along the return value of dma_memory_rw

2019-11-11 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 10:30:07AM +0100, Klaus Birkelund wrote: > On Thu, Oct 24, 2019 at 01:13:36AM +0200, Philippe Mathieu-Daudé wrote: > > On 10/11/19 9:01 AM, Klaus Jensen wrote: > > > Some might actually care about the return value of dma_memory_rw. So > > > let us pass it along instead of

Re: [PATCH v2] tcg plugins: expose an API version concept

2019-11-11 Thread Peter Maydell
On Mon, 11 Nov 2019 at 11:35, Alex Bennée wrote: > > This is a very simple versioning API which allows the plugin > infrastructure to check the API a plugin was built against. We also > expose a min/cur API version to the plugin via the info block in case > it wants to avoid using old deprecated

[PATCH v3 21/21] nvme: handle dma errors

2019-11-11 Thread Klaus Jensen
Handling DMA errors gracefully is required for the device to pass the block/011 test ("disable PCI device while doing I/O") in the blktests suite. With this patch the device passes the test by retrying "critical" transfers (posting of completion entries and processing of submission queue

[PATCH v3 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces

2019-11-11 Thread Klaus Jensen
Hi all, This v3 fixes a number of issues found doing v2[1]. Below is a list of commits that changed for v3. * In "nvme: add missing fields in the identify controller data structure", the size of the RTD3R field was incorrectly two instead of four bytes wide. * Fix status code for an invalid

[PATCH v3 20/21] pci: pass along the return value of dma_memory_rw

2019-11-11 Thread Klaus Jensen
Some might actually care about the return value of dma_memory_rw. So let us pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin ---

Re: [RFC PATCH v2 14/26] qcow2: Add subcluster support to qcow2_get_cluster_offset()

2019-11-11 Thread Max Reitz
On 08.11.19 16:42, Alberto Garcia wrote: > On Mon 04 Nov 2019 03:58:57 PM CET, Max Reitz wrote: [...] >>> @@ -514,8 +499,8 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, >>> uint64_t offset, >> >> I suppose this is get_subcluster_offset now. > > Hmmm no, this returns the actual host

Re: [PATCH v3] iotests: Test NBD client reconnection

2019-11-11 Thread Andrey Shinkevich
On 08/11/2019 17:05, Roman Kagan wrote: > On Fri, Nov 08, 2019 at 01:49:50PM +, Vladimir Sementsov-Ogievskiy wrote: >> 01.11.2019 19:54, Andrey Shinkevich wrote: >>> +def check_proc_NBD(proc, connector): >>> +try: >>> +exitcode = proc.wait(timeout=10) >>> + >>> +if

Re: [PATCH 2/2] core: replace sysconf(_SC_PAGESIZE) with qemu_real_host_page_size

2019-11-11 Thread Stefano Garzarella
Why "core:" in the commit title? Perhaps to indicate that the patch concerns different subsystems, I'd use "qemu: ", but I'm not sure :-) On Tue, Oct 15, 2019 at 11:13:50AM +0800, Wei Yang wrote: > Signed-off-by: Wei Yang > Suggested-by: "Dr. David Alan Gilbert" > CC: Richard Henderson > ---

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-11 Thread Jens Freimann
On Fri, Nov 08, 2019 at 06:38:17PM +, Dr. David Alan Gilbert wrote: Hi Jens, the unplug failover stuff is triggering an assertion occasionally on aarch64; but a) I'm not sure the right way to fix it b) And I'm out for a little over a week so... I'll take care of it. *

Re: [PATCH 1/1] pci: pass along the return value of dma_memory_rw

2019-11-11 Thread Klaus Birkelund
On Mon, Nov 11, 2019 at 05:16:41AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 11, 2019 at 10:30:07AM +0100, Klaus Birkelund wrote: > > On Thu, Oct 24, 2019 at 01:13:36AM +0200, Philippe Mathieu-Daudé wrote: > > > On 10/11/19 9:01 AM, Klaus Jensen wrote: > > > > Some might actually care about

Re: [PATCH 2/2] vfio-helpers: Free QEMUVFIOState in qemu_vfio_close()

2019-11-11 Thread Cornelia Huck
On Mon, 11 Nov 2019 11:37:42 +0100 Michal Privoznik wrote: > The qemu_vfio_open_pci() allocates this QEMUVFIOState structure > but free counterpart is missing. Since we already have > qemu_vfio_close() which does cleanup of the state, it looks like > a perfect place to free the structure too. >

[PATCH v3 10/21] nvme: add logging to error information log page

2019-11-11 Thread Klaus Jensen
This adds the nvme_set_error_page function which allows errors to be written to the error information log page. The functionality is largely unused in the device, but with this in place we can at least try to push new contributions to use it. NOTE: In violation of the specification the Error

[PATCH v3 04/21] nvme: populate the mandatory subnqn and ver fields

2019-11-11 Thread Klaus Jensen
Required for compliance with NVMe revision 1.2.1 or later. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Section 7.9 ("NVMe Qualified Names"). This also bumps the supported version to 1.2.1. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 11 --- 1 file

[PATCH v3 08/21] nvme: add support for the get log page command

2019-11-11 Thread Klaus Jensen
Add support for the Get Log Page command and basic implementations of the mandatory Error Information, SMART/Health Information and Firmware Slot Information log pages. In violation of the specification, the SMART/Health Information log page does not persist information over the lifetime of the

[PATCH 0/2] A pair of memory access problems

2019-11-11 Thread Michal Privoznik
The first patch fixes a crasher, the second fixes a memleak. Michal Privoznik (2): hw/vfio/pci: Fix double free of migration_blocker vfio-helpers: Free QEMUVFIOState in qemu_vfio_close() hw/vfio/pci.c | 2 ++ util/vfio-helpers.c | 1 + 2 files changed, 3 insertions(+) -- 2.23.0

Re: [PATCH v2 1/1] virtio: make seg_max virtqueue size dependent

2019-11-11 Thread Stefan Hajnoczi
On Fri, Nov 08, 2019 at 04:42:49PM +0300, Denis Plotnikov wrote: > +virtio_stl_p(vdev, _max, s->conf.queue_size - 2); [...] > +virtio_stl_p(vdev, >seg_max, s->conf.virtqueue_size - 2); Please extend the queue_size checks to report an error when queue_size <= 2. Stefan signature.asc

[PATCH v2] tcg plugins: expose an API version concept

2019-11-11 Thread Alex Bennée
This is a very simple versioning API which allows the plugin infrastructure to check the API a plugin was built against. We also expose a min/cur API version to the plugin via the info block in case it wants to avoid using old deprecated APIs in the future. Signed-off-by: Alex Bennée

Re: [PATCH] configure: Check bzip2 is available

2019-11-11 Thread Thomas Huth
On 08/11/2019 18.10, Peter Maydell wrote: > On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé wrote: >> On 11/8/19 4:43 PM, Eric Blake wrote: >>> bzip2 is no longer a favored compression. If we are trying to pick a >>> compression that is most likely to be present on any system, go with >>>

[PATCH v3 19/21] nvme: make lba data size configurable

2019-11-11 Thread Klaus Jensen
Signed-off-by: Klaus Jensen --- hw/block/nvme-ns.c | 2 +- hw/block/nvme-ns.h | 4 +++- hw/block/nvme.c| 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 36deedee07a6..dc7e63b01037 100644 --- a/hw/block/nvme-ns.c +++

[PATCH v3 12/21] nvme: bump supported specification version to 1.3

2019-11-11 Thread Klaus Jensen
Add the new Namespace Identification Descriptor List (CNS 03h) and track creation of queues to enable the controller to return Command Sequence Error if Set Features is called for Number of Queues after any queues have been created. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 82

Re: [PATCH 5/5] MAINTAINERS: Adjust maintainership for R4000 systems

2019-11-11 Thread Aurelien Jarno
On 2019-11-08 20:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the maintainership for R4000 systems to improve its quality. > > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 4/5] MAINTAINERS: Adjust maintainership for Malta board

2019-11-11 Thread Aurelien Jarno
On 2019-11-08 20:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the maintainership for Malta board to improve its quality. > > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

[PATCH v2] docs: build an index page for the HTML docs

2019-11-11 Thread Stefan Hajnoczi
There is no index.html start page for the QEMU HTML documentation. An index page is needed so that documentation can be browsed easily on the web. This patch adds an index.html.in template file where the QEMU version number is expanded. It is written in HTML instead of using the existing sphinx

Re: [PATCH 1/1] pci: pass along the return value of dma_memory_rw

2019-11-11 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 11:33:17AM +0100, Klaus Birkelund wrote: > On Mon, Nov 11, 2019 at 05:16:41AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2019 at 10:30:07AM +0100, Klaus Birkelund wrote: > > > On Thu, Oct 24, 2019 at 01:13:36AM +0200, Philippe Mathieu-Daudé wrote: > > > > On

Re: [PATCH] hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine

2019-11-11 Thread Peter Maydell
On Mon, 4 Nov 2019 at 15:12, Clement Deschamps wrote: > > Set the NSACR CP11 and CP10 bits, to allow FPU access in Non-Secure state > when using dummy SMC setup routine. Otherwise an AArch32 kernel will UNDEF as > soon as it tries to use the FPU. > > This fixes kernel panic when booting raspbian

[PATCH v3 06/21] nvme: add support for the abort command

2019-11-11 Thread Klaus Jensen
Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.1 ("Abort command"). The Abort command is a best effort command; for now, the device always fails to abort the given command. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 16 1 file

[PATCH v3 09/21] nvme: add support for the asynchronous event request command

2019-11-11 Thread Klaus Jensen
Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.2 ("Asynchronous Event Request command"). Mostly imported from Keith's qemu-nvme tree. Modified to not enqueue events if something of the same type is already queued (but not cleared by the host). Signed-off-by:

[PATCH v3 01/21] nvme: remove superfluous breaks

2019-11-11 Thread Klaus Jensen
These break statements was left over when commit 3036a626e9ef ("nvme: add Get/Set Feature Timestamp support") was merged. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 12d825425016..c06e3ca31905

[PATCH] docs: fix rst syntax errors in unbuilt docs

2019-11-11 Thread Stefan Hajnoczi
The .rst files outside docs/{devel,interop,specs} aren't built yet and therefore a few syntax errors have slipped through. Fix them. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- Sent as a separate patch. This used to be part of "[PATCH 0/3] docs: build an index page for

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-11 Thread Igor Mammedov
On Mon, 11 Nov 2019 11:12:28 +0800 Tao Xu wrote: > On 11/8/2019 4:41 PM, Igor Mammedov wrote: > > On Fri, 08 Nov 2019 09:05:52 +0100 > > Markus Armbruster wrote: > > > >> Tao Xu writes: > >> > >>> On 11/7/2019 9:31 PM, Eduardo Habkost wrote: > On Thu, Nov 07, 2019 at 02:24:52PM

Re: [PATCH v2 03/15] block/block: add BDRV flag for io_uring

2019-11-11 Thread Kevin Wolf
Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > From: Aarushi Mehta > > Signed-off-by: Aarushi Mehta > Reviewed-by: Maxim Levitsky > Signed-off-by: Stefan Hajnoczi > --- > include/block/block.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/block/block.h

[PATCH v3 13/21] nvme: refactor prp mapping

2019-11-11 Thread Klaus Jensen
Instead of handling both QSGs and IOVs in multiple places, simply use QSGs everywhere by assuming that the request does not involve the controller memory buffer (CMB). If the request is found to involve the CMB, convert the QSG to an IOV and issue the I/O. The QSG is converted to an IOV by the dma

[PATCH v3 05/21] nvme: allow completion queues in the cmb

2019-11-11 Thread Klaus Jensen
Allow completion queues in the controller memory buffer. This also inlines the nvme_addr_{read,write} functions and adds an nvme_addr_is_cmb helper. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-)

[PATCH] tests/migration: use the common library function

2019-11-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/migration/stress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/migration/stress.c b/tests/migration/stress.c index 0c239646934..915389b53ae 100644 --- a/tests/migration/stress.c +++ b/tests/migration/stress.c @@ -31,7 +31,7 @@

Re: [PATCH] configure: Check bzip2 is available

2019-11-11 Thread Aleksandar Markovic
On Monday, November 11, 2019, Thomas Huth wrote: > On 08/11/2019 18.10, Peter Maydell wrote: > > On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé > wrote: > >> On 11/8/19 4:43 PM, Eric Blake wrote: > >>> bzip2 is no longer a favored compression. If we are trying to pick a > >>> compression

RE: [PATCH] riscv/virt: Add syscon reboot and poweroff DT nodes

2019-11-11 Thread Anup Patel
Correct Palmer's email address. > -Original Message- > From: Anup Patel > Sent: Monday, November 11, 2019 7:08 PM > To: Peter Maydell ; Palmer Dabbelt > ; Alistair Francis ; Sagar > Karandikar > Cc: Atish Patra ; Christoph Hellwig ; > Anup Patel ; qemu-ri...@nongnu.org; qemu- >

Re: [PATCH] s390x: Properly fetch and test the short psw on diag308 subc 0/1

2019-11-11 Thread Janosch Frank
On 11/5/19 9:07 PM, David Hildenbrand wrote: > On 05.11.19 20:34, Janosch Frank wrote: >> On 11/5/19 8:29 PM, David Hildenbrand wrote: >>> On 05.11.19 19:44, Janosch Frank wrote: [...] > Note: For TCG we miss many of these validity checks. For KVM, most > should be triggered when running the VCPU

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Jan Kiszka
On 11.11.19 14:45, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 01:57:11PM +0100, Jan Kiszka wrote: +| Offset | Register | Content | +|---:|:---|:-| +|

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: > On 11.11.19 14:45, Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2019 at 01:57:11PM +0100, Jan Kiszka wrote: > > > +| Offset | Register | Content > > > | > > >

Re: [PATCH 1/2] tests/tcg/multiarch: fix code style in function main of test-mmap.c

2019-11-11 Thread Wei Yang
On Mon, Nov 11, 2019 at 10:25:43AM +, Alex Benn??e wrote: > >Wei Yang writes: > >> This file uses quite a different code style and changing just one line >> would leads to some awkward appearance. >> >> This is a preparation for the following replacement of >> sysconf(_SC_PAGESIZE). >> >>

[PULL 4/4] tcg/LICENSE: Remove out of date claim about TCG subdirectory licensing

2019-11-11 Thread Richard Henderson
From: Peter Maydell Since 2008 the tcg/LICENSE file has not changed: it claims that everything under tcg/ is BSD-licensed. This is not true and hasn't been true for years: in 2013 we accepted the tcg/aarch64 target code under a GPLv2-or-later license statement. We also have generic vector

[PATCH for-5.0 v2 07/23] blkverify: Implement .bdrv_recurse_can_replace()

2019-11-11 Thread Max Reitz
Signed-off-by: Max Reitz --- block/blkverify.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/blkverify.c b/block/blkverify.c index 304b0a1368..0add3ab483 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -282,6 +282,20 @@ static bool

[PATCH for-5.0 v2 18/23] iotests: Add VM.assert_block_path()

2019-11-11 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 59 +++ 1 file changed, 59 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index d34305ce69..3e03320ce3 100644 --- a/tests/qemu-iotests/iotests.py +++

Re: [RFC v4 PATCH 47/49] multi-process: Enable support for multiple devices in remote

2019-11-11 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:28AM -0400, Jagannathan Raman wrote: > @@ -93,7 +94,8 @@ static void process_config_write(MPQemuMsg *msg) > struct conf_data_msg *conf = (struct conf_data_msg *)msg->data2; > > qemu_mutex_lock_iothread(); > -pci_default_write_config(remote_pci_dev,

[PATCH for-5.0 v2 23/23] iotests: Mirror must not attempt to create loops

2019-11-11 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 235 + tests/qemu-iotests/041.out | 4 +- 2 files changed, 237 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 9a00cf6f7b..0e43bb699d 100755 ---

Re: [PATCH v2 03/15] block/block: add BDRV flag for io_uring

2019-11-11 Thread Max Reitz
On 11.11.19 11:57, Kevin Wolf wrote: > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: >> From: Aarushi Mehta >> >> Signed-off-by: Aarushi Mehta >> Reviewed-by: Maxim Levitsky >> Signed-off-by: Stefan Hajnoczi >> --- >> include/block/block.h | 1 + >> 1 file changed, 1 insertion(+) >>

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Jan Kiszka
On 11.11.19 17:14, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 04:42:52PM +0100, Jan Kiszka wrote: On 11.11.19 16:27, Daniel P. Berrangé wrote: On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: On 11.11.19

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 04:42:52PM +0100, Jan Kiszka wrote: > On 11.11.19 16:27, Daniel P. Berrangé wrote: > > On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: > > > > On 11.11.19 14:45, Michael S. Tsirkin wrote:

Re: [PULL 0/3] target-arm queue

2019-11-11 Thread Peter Maydell
efcb511d394c1d3f5292c28503d1d19e5b1d3: > > Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request' > into staging (2019-11-11 09:23:46 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git >

[RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Jan Kiszka
From: Jan Kiszka This imports the ivshmem v2 specification draft from Jailhouse. Its final home is to be decided, this shall just simplify the review process at this stage. Note that specifically the Features register (offset 08h) is still under consideration. In particular, its bit 0 seems

[RFC][PATCH 0/3] IVSHMEM version 2 device for QEMU

2019-11-11 Thread Jan Kiszka
To get the ball rolling after my presentation of the topic at KVM Forum [1] and many fruitful discussions around it, this is a first concrete code series. As discussed, I'm starting with the IVSHMEM implementation of a QEMU device and server. It's RFC because, besides specification and

[RFC][PATCH 1/3] hw/misc: Add implementation of ivshmem revision 2 device

2019-11-11 Thread Jan Kiszka
From: Jan Kiszka This adds a reimplementation of ivshmem in its new revision 2 as separate device. The goal of this is not to enable sharing with v1, rather to allow explore the properties and potential limitation of the new version prior to discussing its integration with the existing code. v2

Re: [PATCH] MAINTAINERS: slirp: Remove myself as maintainer

2019-11-11 Thread Samuel Thibault
Thomas Huth, le lun. 11 nov. 2019 14:15:36 +0100, a ecrit: > On 11/11/2019 08.57, Jan Kiszka wrote: > > May I point out that this one was never merged? > > > > Sorry, I really can't help in this area anymore. > > I'm planning to send a "qtest + misc" PULL request tomorrow ... I can > add the

[PULL 1/3] ptimer: Remove old ptimer_init_with_bh() API

2019-11-11 Thread Peter Maydell
Now all the users of ptimers have converted to the transaction-based API, we can remove ptimer_init_with_bh() and all the code paths that are used only by bottom-half based ptimers, and tidy up the documentation comments to consider the transaction-based API the only possibility. The code changes

[PULL 3/3] hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine

2019-11-11 Thread Peter Maydell
From: Clement Deschamps The boot.c code usually puts the CPU into NS mode directly when it is booting a kernel. Since fc1120a7f5f2d4b6 this has included a requirement to set NSACR to give NS state access to the FPU; we fixed that for the usual code path in ece628fcf6. However, it is also

[PULL 0/3] target-arm queue

2019-11-11 Thread Peter Maydell
ll-request' into staging (2019-11-11 09:23:46 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-2019 for you to fetch changes up to 45c078f163fd47c35e7505d98928fae63baada7d: hw/arm/boot: Set NSACR.{CP11, CP10} in

Re: [PATCH] s390x: Properly fetch and test the short psw on diag308 subc 0/1

2019-11-11 Thread David Hildenbrand
> Am 11.11.2019 um 14:52 schrieb Janosch Frank : > > On 11/5/19 9:07 PM, David Hildenbrand wrote: >>> On 05.11.19 20:34, Janosch Frank wrote: >>> On 11/5/19 8:29 PM, David Hildenbrand wrote: On 05.11.19 19:44, Janosch Frank wrote: > [...] >> Note: For TCG we miss many of these validity

Re: [PATCH v1 1/6] tests/vm: netbsd autoinstall, using serial console

2019-11-11 Thread Thomas Huth
On 04/11/2019 18.36, Alex Bennée wrote: > From: Gerd Hoffmann > > Instead of fetching the prebuilt image from patchew download the install > iso and prepare the image locally. Install to disk, using the serial > console. Create qemu user, configure ssh login. Install packages > needed for

[PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1

2019-11-11 Thread Janosch Frank
We need to actually fetch the cpu mask and set it. As we invert the short psw indication in the mask, SIE will report a specification exception, if it wasn't present in the reset psw. Signed-off-by: Janosch Frank --- target/s390x/cpu.c | 12 ++-- target/s390x/cpu.h | 1 + 2 files

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Jan Kiszka
On 11.11.19 16:27, Daniel P. Berrangé wrote: On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: On 11.11.19 14:45, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 01:57:11PM +0100, Jan Kiszka wrote: +| Offset |

[PATCH for-5.0 v2 05/23] quorum: Fix child permissions

2019-11-11 Thread Max Reitz
Quorum cannot share WRITE or RESIZE on its children. Presumably, it only does so because as a filter, it seemed intuitively correct to point its .bdrv_child_perm to bdrv_filter_default_perm(). However, it is not really a filter, and bdrv_filter_default_perm() does not work for it, so we have to

[PATCH for-5.0 v2 08/23] quorum: Store children in own structure

2019-11-11 Thread Max Reitz
This will be useful when we want to store additional attributes for each child. Signed-off-by: Max Reitz --- block/quorum.c | 64 -- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index

[PATCH v6 0/3] qcow2: advanced compression options

2019-11-11 Thread Andrey Shinkevich
The compression filter driver is introduced as suggested by Max. A sample usage of the filter can be found in the test #214. Now, multiple clusters can be written compressed. It is useful for the backup job. v6: The new approach to write compressed data was applied. The patch v5 4/4 with the

[PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041

2019-11-11 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 2ab59e9c53..d636cb7f1d 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -918,8 +918,7 @@ class

Re: [RFC v4 PATCH 32/49] multi-process: Use separate MMIO communication channel

2019-11-11 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:13AM -0400, Jagannathan Raman wrote: > Using a separate communication channel for MMIO helps > with improving Performance Why? signature.asc Description: PGP signature

[PULL 2/3] Remove unassigned_access CPU hook

2019-11-11 Thread Peter Maydell
All targets have now migrated away from the old unassigned_access hook to the new do_transaction_failed hook. This means we can remove the core-code infrastructure for that hook and the code that calls it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair

Re: [PATCH 2/5] nvdimm: Use configurable ACPI IO base and size

2019-11-11 Thread Igor Mammedov
On Fri, 4 Oct 2019 16:52:59 +0100 Shameer Kolothum wrote: > From: Kwangwoo Lee > > This patch makes IO base and size configurable to create NPIO AML for > ACPI NFIT. Since a different architecture like AArch64 does not use > port-mapped IO, a configurable IO base is required to create correct

Re: [PATCH 4/5] hw/arm/boot: Expose the pmem nodes in the DT

2019-11-11 Thread Igor Mammedov
On Fri, 4 Oct 2019 16:53:01 +0100 Shameer Kolothum wrote: > From: Eric Auger > > In case of NV-DIMM slots, let's add /pmem DT nodes Why should we do it for NVDIMM but not for PC-DIMM? > > Signed-off-by: Eric Auger > Signed-off-by: Shameer Kolothum > --- > hw/arm/boot.c | 45

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Daniel P . Berrangé
On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: > > On 11.11.19 14:45, Michael S. Tsirkin wrote: > > > On Mon, Nov 11, 2019 at 01:57:11PM +0100, Jan Kiszka wrote: > > > > +| Offset | Register | Content

[PATCH for-5.0 v2 17/23] iotests: Use skip_if_unsupported decorator in 041

2019-11-11 Thread Max Reitz
We can use this decorator above TestRepairQuorum.setUp() to skip all quorum tests with a single line. Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 39 +++ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/tests/qemu-iotests/041

[PATCH v6 3/3] tests/qemu-iotests: add case to write compressed data of multiple clusters

2019-11-11 Thread Andrey Shinkevich
Add the case to the iotest #214 that checks possibility of writing compressed data of more than one cluster size. The test case involves the compress filter driver showing a sample usage of that. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 43

Re: [PATCH v3 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-11-11 Thread Max Reitz
On 11.11.19 15:02, Thomas Huth wrote: > On 30/10/2019 12.21, Max Reitz wrote: >> On 22.10.19 09:21, Thomas Huth wrote: >>> The next patch is going to add some python-based tests to the "auto" >>> group, and these tests require virtio-blk to work properly. Running >>> iotests without virtio-blk

Re: [RFC v4 PATCH 33/49] multi-process: perform device reset in the remote process

2019-11-11 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:14AM -0400, Jagannathan Raman wrote: > +void proxy_device_reset(DeviceState *dev) > +{ > +PCIProxyDev *pdev = PCI_PROXY_DEV(dev); > +MPQemuMsg msg; > + > +memset(, 0, sizeof(MPQemuMsg)); > + > +msg.bytestream = 0; > +msg.size = sizeof(msg.data1); >

[PATCH for-5.0 v2 21/23] iotests: Add tests for invalid Quorum @replaces

2019-11-11 Thread Max Reitz
Add two tests to see that you cannot replace a Quorum child with the mirror job while the child is in use by a different parent. Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 70 +- tests/qemu-iotests/041.out | 4 +-- 2 files changed, 71

Re: [RFC v4 PATCH 30/49] multi-process: send heartbeat messages to remote

2019-11-11 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:11AM -0400, Jagannathan Raman wrote: > +static void broadcast_msg(MPQemuMsg *msg, bool need_reply) > +{ > +PCIProxyDev *entry; > +unsigned int pid; > +int wait; > + > +QLIST_FOREACH(entry, _dev_list.devices, next) { > +if (need_reply) { > +

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-11 Thread Jan Kiszka
On 11.11.19 17:11, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote: On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote: On 11.11.19 14:45, Michael S. Tsirkin wrote: On

Re: [PATCH] tests/migration: use the common library function

2019-11-11 Thread Alex Bennée
Thomas Huth writes: > On 11/11/2019 13.55, Alex Bennée wrote: >> Signed-off-by: Alex Bennée > > Could you please add at least a short patch description? (Why is this > change necessary / a good idea?) It's just a minor clean-up Dave happened to comment on last week. Using the helper function

  1   2   3   >