Re: Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Samuel Thibault
Samuel Thibault, le jeu. 14 nov. 2019 14:08:41 +0100, a ecrit: > The way to properly fix it is to add a brlapi channel to spice: And that would be workable through a spice agent as well, so that braille management from orca running inside the guest could talk directly through to brltty running on

[PATCH 0/1] tests/vm: Allow to set path to qemu-img

2019-11-14 Thread Wainer dos Santos Moschetta
Usually I build QEMU in a system which doesn't have any qemu package installed. When I need to `make vm-build-something` it fails due system-qemu- and qemu-img not found system-wide (and I want to use the built binaries). The formed can be set with QEMU env var, but the later can't. So this patch

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Halil Pasic
On Thu, 14 Nov 2019 14:19:15 +0100 Cornelia Huck wrote: > On Thu, 14 Nov 2019 14:02:35 +0100 > Halil Pasic wrote: > > > On Thu, 14 Nov 2019 11:38:23 +0100 > > Cornelia Huck wrote: > > > > > On Wed, 13 Nov 2019 20:02:33 +0100 > > > Pierre Morel wrote: > > > > > > Minor nit for $SUBJECT:

Re: [PATCH] gdbstub: Fix buffer overflow in handle_read_all_regs

2019-11-14 Thread Damien Hedde
On 11/14/19 2:47 PM, Alex Bennée wrote: > > Damien Hedde writes: > >> On 11/8/19 5:50 PM, Alex Bennée wrote: >>> >>> Damien Hedde writes: >>> On 11/8/19 3:09 PM, Alex Bennée wrote: > > Damien Hedde writes: > >> Ensure we don't put too much register data in buffers.

Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice()

2019-11-14 Thread Alberto Garcia
On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote: >> /* First remove L2 entries */ >> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >> -if (!full_discard && s->qcow_version >= 3) { >> +if (has_subclusters(s)) { >> +set_l2_entry(s,

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Fri, 25 Oct 2019 at 20:15, Keith Packard wrote: > There seems to be convergence on a pretty simple interface which uses > ebreak surrounded by a couple of specific no-ops: > > slli x0, x0, 0x1f > ebreak > srai x0, x0, 0x7 > > There are implementations in rust and openocd, and

Re: [PATCH] gdbstub: Fix buffer overflow in handle_read_all_regs

2019-11-14 Thread Alex Bennée
Damien Hedde writes: > On 11/8/19 5:50 PM, Alex Bennée wrote: >> >> Damien Hedde writes: >> >>> On 11/8/19 3:09 PM, Alex Bennée wrote: Damien Hedde writes: > Ensure we don't put too much register data in buffers. This avoids > a buffer overflow (and stack corruption)

Re: [RFC PATCH v2 10/26] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2019-11-14 Thread Alberto Garcia
On Wed 30 Oct 2019 05:55:04 PM CET, Max Reitz wrote: >> This patch also adds the get/set_l2_bitmap() functions that are used >> to access the bitmaps. For convenience, these functions are no-ops >> when used in traditional qcow2 images. > > Granted, I haven’t seen the following patches yet, but if

[PATCH v3] qemu-gdb: add an Object pretty printer

2019-11-14 Thread Marc-André Lureau
Inspired by GObject/GType pretty printer. Example: machine_set_accel (obj=0x56807550 [pc-i440fx-4.0-machine],... Signed-off-by: Marc-André Lureau --- scripts/qemu-gdb.py | 58 + 1 file changed, 58 insertions(+) mode change 100644 => 100755

Re: [PATCH v5 00/20] Add virtual device fuzzing support

2019-11-14 Thread Alexander Bulekov
On 11/14/19 5:55 AM, Darren Kenny wrote: Hi Alexander, A quick comment on the fact that you omitted any Reviewed-by's that you have received so far. Was that intentional? No - I'll find a way to add them. sorry about that -Alex Thanks, Darren. On Wed, Nov 13, 2019 at 10:50:41PM +,

[PATCH v2 for 5.0 0/6] linux-user: Add support for real time clock ioctls

2019-11-14 Thread Filip Bozuta
Add ioctls for all RTC features that are currently supported in linux kernel. This series covers following iocts: * RTC_AIE_ON * RTC_AIE_OFF * RTC_UIE_ON * RTC_UIE_OFF * RTC_PIE_ON * RTC_PIE_OFF * RTC_WIE_ON * RTC_WIE_OFF * RTC_ALM_SET * RTC_ALM_READ *

[PATCH v2 for 5.0 2/6] linux-user: Add support for read/set RTC time and alarm using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_RD_TIME - Read RTC time Returns this RTC's time in the following structure: struct rtc_time { int tm_sec; int tm_min; int tm_hour; int tm_mday; int tm_mon;

[PATCH v2 for 5.0 4/6] linux-user: Add support for get/set RTC wakeup alarm using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_WKALM_SET, RTC_WKALM_GET - Get/Set wakeup alarm Some RTCs support a more powerful alarm interface, using these ioctls to read or write the RTC's alarm time (respectively) with this structure: struct rtc_wkalrm {

[PATCH v2 for 5.0 3/6] linux-user: Add support for read/set RTC periodic interrupt and epoch using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_IRQP_READ, RTC_IRQP_SET - Read/Set IRQ rate Read and set the frequency for periodic interrupts, for RTCs that support periodic interrupts. The periodic interrupt must be separately enabled or disabled using the

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-14 Thread chen huacai
Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: > > Hi, Philippe, > > > From: Philippe Mathieu-Daudé > > > > Hi Aleksandar, > > > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > > From: Aleksandar Markovic > > > > > > Change the maintainership for Fulong 2E board to

Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_slice()

2019-11-14 Thread Alberto Garcia
On Mon 04 Nov 2019 04:10:58 PM CET, Max Reitz wrote: >>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >>> if (cluster_type == QCOW2_CLUSTER_COMPRESSED || unmap) { >>> -set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO); >>>

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Alistair Francis
On Mon, Nov 11, 2019 at 6:51 AM Peter Maydell wrote: > > On Tue, 5 Nov 2019 at 05:10, Keith Packard wrote: > > > > Peter Maydell writes: > > > > > I'm going to push for somebody actually writing out a > > > document and putting it somewhere that we can point to > > > and say "that's the

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-14 Thread Markus Armbruster
Less than thorough review, because I expect the necessary rebase will require a bit of rewriting here and there. Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description,

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Christoph Hellwig
On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: > The XFS kernel driver has a bug that may cause data corruption for qcow2 > images as of qemu commit c8bb23cbdbe32f. We can work around it by > treating post-EOF fallocates as serializing up until infinity (INT64_MAX > in practice).

Re: Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Samuel Thibault
Samuel Thibault, le jeu. 14 nov. 2019 14:27:12 +0100, a ecrit: > Samuel Thibault, le jeu. 14 nov. 2019 14:08:41 +0100, a ecrit: > > The way to properly fix it is to add a brlapi channel to spice: > > And that would be workable through a spice agent as well, so that > braille management from orca

Re: [PATCH] tests: fix modules-test 'duplicate test case' error

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/13/19 10:09 PM, Cole Robinson wrote: ./configure --enable-sdl --audio-drv-list=sdl --enable-modules Will generate two identical test names: /$arch/module/load/sdl Which generates an error like: (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path:

[PATCH 4/4] net/virtio: return error when device_opts arg is NULL

2019-11-14 Thread Jens Freimann
device_opts could be NULL. Make sure we don't pass it to qemu_opts_to_dict. When we made sure it can't be NULL we can also remove it from the if condition. This fixes CID 1407222. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freimann --- hw/net/virtio-net.c | 9

[PATCH 2/4] net/virtio: return early when failover primary alread added

2019-11-14 Thread Jens Freimann
Bail out when primary device was already added before. This avoids printing a wrong warning message during reboot. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freimann --- hw/net/virtio-net.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2 for 5.0 5/6] linux-user: Add support for get/set RTC PLL correction using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_PLL_GET - Get PLL correction Read the PLL correction for RTCs that support PLL. The PLL correction is returned in the following structure: struct rtc_pll_info { int pll_ctrl;/* placeholder for

Re: [PATCH] MAINTAINERS: add more bitmap-related to Dirty Bitmaps section

2019-11-14 Thread Eric Blake
On 10/26/19 11:56 AM, Vladimir Sementsov-Ogievskiy wrote: Let's add bitmaps persistence qcow2 feature and postcopy bitmaps migration to Dirty Bitmaps section. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) I see no reason why this

[PATCH] vfio: don't ignore return value of migrate_add_blocker

2019-11-14 Thread Jens Freimann
When an error occurs in migrate_add_blocker() it sets a negative return value and uses error pointer we pass in. Instead of just looking at the error pointer check for a negative return value and avoid a coverity error because the return value is set but never used. This fixes CID 1407219. Fixes:

Re: [PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes

2019-11-14 Thread Peter Maydell
On Wed, 13 Nov 2019 at 22:13, Joel Stanley wrote: > > Three of these are fixes for ast2600 models that I found when testing > master. The forth is a usability improvement that is helpful when > diagnosing why a watchdog is biting. > > v3 adds some comments and fixes whitespace, and r-b from Alex.

[PATCH 1/4] net/virtio: fix dev_unplug_pending

2019-11-14 Thread Jens Freimann
.dev_unplug_pending is set up by virtio-net code indepent of whether failover=on was set for the device or not. This gives a wrong result when we check for existing primary devices in migration code. Fix this by actually calling dev_unplug_pending() instead of just checking if the function

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-14 Thread Denis Plotnikov
On 13.11.2019 16:18, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 12:38:48PM +, Denis Plotnikov wrote: >> >> On 06.11.2019 15:03, Michael S. Tsirkin wrote: >>> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: > On

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-14 Thread Eric Blake
On 11/14/19 4:04 AM, Maxim Levitsky wrote: On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Peter Maydell
On Tue, 12 Nov 2019 at 11:57, Peter Maydell wrote: > On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: > > I still think that being consistent with the actual PL031 spec is > > preferable though. If any real world guest breaks because of this, we > > can still revert this patch and document

Re: [PATCH 17/30] virtiofsd: Add main virtio loop

2019-11-14 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 12:07:25PM +0100, Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > On Mon, Oct 21, 2019 at 1:26 PM Dr. David Alan Gilbert (git) > > wrote: > > > > > > From: "Dr. David Alan Gilbert" > > > > > > Processes incoming requests on the

Re: [PULL 0/1] Seabios 20191113 patches

2019-11-14 Thread Peter Maydell
On Wed, 13 Nov 2019 at 14:05, Gerd Hoffmann wrote: > > The following changes since commit 9f2ce35dfa4ea4a31dbb765dd02bed2500891887: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-2019' into > staging (2019-11-11 16:54:16 +) > > are available in the Git repository at: > >

[PATCH v2 for 5.0 1/6] linux-user: Add support for enable/disable RTC features using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_AIE_ON, RTC_AIE_OFF - Alarm interrupt enable on/off Enable or disable the alarm interrupt, for RTCs that support alarms. The third ioctl's argument is ignored. RTC_UIE_ON, RTC_UIE_OFF - Update interrupt enable on/off

[PATCH v2 for 5.0 6/6] linux-user: Add support for read/clear RTC voltage low detector using ioctls

2019-11-14 Thread Filip Bozuta
RTC_VL_READ - Read voltage low detection information Read the voltage low for RTCs that support voltage low. The third ioctl's' argument points to an int in which the voltage low is returned. RTC_VL_CLR - Clear voltage low information Clear the information about voltage low for

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-14 Thread Tony Asleson
On 9/20/19 12:28 PM, Tony Asleson wrote: > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: >> blkdebug is purely at the QEMU block layer level. It is not aware of >> storage controller-specific error information or features. If you want >> to inject NVMe- or SCSI-specific errors that make no sense in

Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice()

2019-11-14 Thread Max Reitz
On 14.11.19 16:33, Alberto Garcia wrote: > On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote: >>> /* First remove L2 entries */ >>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >>> -if (!full_discard && s->qcow_version >= 3) { >>> +if

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Cornelia Huck
On Thu, 14 Nov 2019 14:02:35 +0100 Halil Pasic wrote: > On Thu, 14 Nov 2019 11:38:23 +0100 > Cornelia Huck wrote: > > > On Wed, 13 Nov 2019 20:02:33 +0100 > > Pierre Morel wrote: > > > > Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just > > one consumer :) > > And

Re: [PATCH] vfio: don't ignore return value of migrate_add_blocker

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/14/19 2:34 PM, Jens Freimann wrote: When an error occurs in migrate_add_blocker() it sets a negative return value and uses error pointer we pass in. Instead of just looking at the error pointer check for a negative return value and avoid a coverity error because the return value is set but

[PATCH 1/1] tests/vm: Allow to set qemu-img path

2019-11-14 Thread Wainer dos Santos Moschetta
By default VM build test use qemu-img from system's PATH to create the image disk. Due the lack of qemu-img on the system or the desire to simply use a version built with QEMU, it would be nice to allow one to set its path. So this patch makes that possible by reading the path to qemu-img from

Re: [PATCH] migration: Fix the re-run check of the migrate-incoming command

2019-11-14 Thread Darren Kenny
On Wed, Nov 13, 2019 at 08:53:25PM +0300, Yury Kotov wrote: The current check sets an error but doesn't fail the command. This may cause a problem if new connection attempt by the same URI affects the first connection. Signed-off-by: Yury Kotov Reviewed-by: Darren Kenny ---

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/14/19 2:08 PM, chen huacai wrote: Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: Hi, Philippe, From: Philippe Mathieu-Daudé Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for Fulong 2E

[PATCH 3/4] net/virtio: avoid passing NULL to qdev_set_parent_bus

2019-11-14 Thread Jens Freimann
Make sure no arguments for qdev_set_parent_bus are NULL. This fixes CID 1407224. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freimann --- hw/net/virtio-net.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c

Re: [PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes

2019-11-14 Thread Cédric Le Goater
On 14/11/2019 15:04, Peter Maydell wrote: > On Wed, 13 Nov 2019 at 22:13, Joel Stanley wrote: >> >> Three of these are fixes for ast2600 models that I found when testing >> master. The forth is a usability improvement that is helpful when >> diagnosing why a watchdog is biting. >> >> v3 adds some

Re: [PATCH v5] iotests: Test NBD client reconnection

2019-11-14 Thread Eric Blake
On 11/11/19 9:39 PM, Andrey Shinkevich wrote: The test for an NBD client. The NBD server is disconnected after the client write request. The NBD client should reconnect and complete the write operation. Suggested-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by:

Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Teemu Kuusisto
Hello, As a blind developer I would be very happy to use QEMU's baum chardev for a braille display. Unfortunately, this device fails to detect the tty in which the spice client is running. I would like to improve this device but I don't yet know how to achieve a better solution. The current

Re: [RFC PATCH v2 18/26] qcow2: Add subcluster support to expand_zero_clusters_in_l1()

2019-11-14 Thread Alberto Garcia
On Tue 05 Nov 2019 12:05:02 PM CET, Max Reitz wrote: >> @@ -2102,6 +2103,7 @@ static int expand_zero_clusters_in_l1(BlockDriverState >> *bs, uint64_t *l1_table, >> } else { >> set_l2_entry(s, l2_slice, j, offset); >> } >> +

Re: [RFC PATCH v2 20/26] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2()

2019-11-14 Thread Alberto Garcia
On Tue 05 Nov 2019 12:43:16 PM CET, Max Reitz wrote: > Speaking of handle_copied(); both elements of Qcow2COWRegion are of > type unsigned. handle_copied() doesn’t look like it takes any > precautions to limit the range to even UINT_MAX (and it should > probably limit it to INT_MAX). Or rather,

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 13:33, Thomas Huth wrote: On 14/11/2019 11.38, Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) The PONG device accept two commands: PONG_READ and PONG_WRITE

[PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-14 Thread Alexander Popov
The commit a718978ed58a from July 2015 introduced the assertion which implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement. PoC for Linux that uses

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 14:02, Halil Pasic wrote: On Thu, 14 Nov 2019 11:38:23 +0100 Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) And subchannel is one word in s390-speak. OK,

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:39, Keith Packard wrote: > > Peter Maydell writes: > > > That defines the instruction sequence used to make a semihosting > > call, but not the specification of what the calls are: > > * what call numbers perform which functions > > * how arguments are passed to the

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 18:05, Keith Packard wrote: > > Peter Maydell writes: > > > I had an idle glance at this implementation, and this: > > > >uint32_t pre = opcode_at(>base, ctx->base.pc_next - 4); > >uint32_t ebreak = opcode_at(>base, ctx->base.pc_next); > >uint32_t post =

Re: [PATCH v2 00/10] Further bitmaps improvements

2019-11-14 Thread Eric Blake
On 10/22/19 7:58 AM, Vladimir Sementsov-Ogievskiy wrote: Hi! The main feature here is improvement of _next_dirty_area API, which I'm going to use then for backup / block-copy. v2: 01: just use INT64_MAX instead of adding new constant 08: add separate function nbd_extent_array_convert_to_be and

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 2:10 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:47:04 +0530 Kirti Wankhede wrote: On 11/14/2019 1:18 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 00:59:52 +0530 Kirti Wankhede wrote: On 11/13/2019 11:57 PM, Alex Williamson wrote: On Wed, 13 Nov 2019 11:24:17

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 1:37 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:07:21 +0530 Kirti Wankhede wrote: On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:37 +0530 Kirti Wankhede wrote: All pages pinned by vendor driver through vfio_pin_pages API should be

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Richard Henderson
On 11/14/19 5:14 PM, Peter Maydell wrote: > On Fri, 25 Oct 2019 at 20:15, Keith Packard wrote: >> There seems to be convergence on a pretty simple interface which uses >> ebreak surrounded by a couple of specific no-ops: >> >> slli x0, x0, 0x1f >> ebreak >> srai x0, x0, 0x7 >>

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 18:15, Max Reitz wrote: > On 14.11.19 17:27, Christoph Hellwig wrote: >> On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >>> The XFS kernel driver has a bug that may cause data corruption for qcow2 >>> images as of qemu commit c8bb23cbdbe32f. We can work around it by >>>

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 1:52 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:22:39 +0530 Kirti Wankhede wrote: On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:38 +0530 Kirti Wankhede wrote: With vIOMMU, during pre-copy phase of migration, while CPUs are still

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:47, Peter Maydell wrote: > The ARM semihosting ABI also has a number of warts > which are basically historical legacy. With a clean > sheet you get to avoid some of them. (Notably you could > skip the whole 'negotiate presence of extensions' business > by just getting

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 17:27, Christoph Hellwig wrote: > On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >> The XFS kernel driver has a bug that may cause data corruption for qcow2 >> images as of qemu commit c8bb23cbdbe32f. We can work around it by >> treating post-EOF fallocates as serializing

Re: [PATCH RFC] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-14 Thread Michael Roth
Quoting Michael S. Tsirkin (2019-11-14 03:12:00) > On Thu, Nov 14, 2019 at 04:10:36AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 13, 2019 at 07:07:36PM -0600, Michael Roth wrote: > > > Quoting Michael S. Tsirkin (2019-11-13 04:09:02) > > > > On Tue, Nov 12, 2019 at 11:43:01PM -0600, Michael

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Alistair Francis writes: > This sounds like something that the platform spec should contain. I'm frankly happy with it specifying the semantics by reference to the ARM docs -- that way we can easily share existing code without concern about subtle semantic differences. The only thing that

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 14:19, Cornelia Huck wrote: On Thu, 14 Nov 2019 14:02:35 +0100 Halil Pasic wrote: On Thu, 14 Nov 2019 11:38:23 +0100 Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: ...snip... We made some different design decisions, while aiming essentially

Re: [PATCH v2 00/10] Further bitmaps improvements

2019-11-14 Thread Vladimir Sementsov-Ogievskiy
14.11.2019 21:47, Eric Blake wrote: > On 10/22/19 7:58 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> The main feature here is improvement of _next_dirty_area API, which I'm >> going to use then for backup / block-copy. >> >> v2: >> 01: just use INT64_MAX instead of adding new constant >>

Convert VMDK to RAW

2019-11-14 Thread janine.schneider
Ladies and Gentlemen, I am a PhD student at the Friedrich-Alexander-University Erlangen-Nuremberg in Bavaria, Germany and am currently working on a forensic reconstruction tool. The tool can be used to analyze physical and virtual hard disks and to reconstruct files. I would now like to extend

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 11:38, Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) yes, right. The PONG device accept two commands: PONG_READ and PONG_WRITE which allow to read from

Re: Convert VMDK to RAW

2019-11-14 Thread Max Reitz
On 14.11.19 17:12, janine.schnei...@fau.de wrote: > Ladies and Gentlemen, > >   > > I am a PhD student at the Friedrich-Alexander-University > Erlangen-Nuremberg in Bavaria, Germany and am currently working on a > forensic reconstruction tool. The tool can be used to analyze physical > and

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Peter Maydell writes: > I had an idle glance at this implementation, and this: > >uint32_t pre = opcode_at(>base, ctx->base.pc_next - 4); >uint32_t ebreak = opcode_at(>base, ctx->base.pc_next); >uint32_t post = opcode_at(>base, ctx->base.pc_next + 4); > > (where opcode_at() is a

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-14 Thread Kirti Wankhede
+ * Vendor driver should decide whether to partition data section and how to + * partition the data section. Vendor driver should return data_offset + * accordingly. + * + * Sequence to be followed for _SAVING|_RUNNING device state or pre-copy phase + * and for _SAVING device state or

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-14 Thread Alexander Popov
On 07.11.2019 01:05, Alexander Popov wrote: > On 06.11.2019 15:05, Michael S. Tsirkin wrote: >> Do you want to cook up a patch like this then? > > Yes, I will take this task and return with a patch. > > Thanks! I've just sent the v2 of the patch. Looking forward to your feedback. Best regards,

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Peter Maydell writes: > That defines the instruction sequence used to make a semihosting > call, but not the specification of what the calls are: > * what call numbers perform which functions > * how arguments are passed to the call (registers? parameter >blocks in memory? other?) > * the

Re: [PATCH 03/16] vl: merge -accel processing into configure_accelerators

2019-11-14 Thread Marc-André Lureau
Hi On Wed, Nov 13, 2019 at 6:42 PM Paolo Bonzini wrote: > > The next step is to move the parsing of "-machine accel=..." into vl.c, > unifying it with the configure_accelerators() function that has just > been introduced. This way, we will be able to desugar it into multiple > "-accel" options,

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:52, Richard Henderson wrote: > Yet another reason why I prefer any semi-hosting call to use an encoding that > is otherwise reserved illegal. > > For this, you have to make up your mind: is it important to execute the > instructions as specified by the ISA, or as

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Richard Henderson
On 11/14/19 8:29 PM, Peter Maydell wrote: > On Thu, 14 Nov 2019 at 19:18, Richard Henderson > wrote: >> - If the sequence crosses a page, then so be it. Because of >> step 1, this only happens when we *must* cross a page, and >> will have recognized any paging exception anyway. >>

[ANNOUNCE] QEMU 4.1.1 Stable released

2019-11-14 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v4.1.1 stable release is now available: You can grab the tarball from our download page here: https://www.qemu.org/download/#source v4.1.1 is now tagged in the official qemu.git repository, and the stable-4.1 branch has been updated

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 19:18, Richard Henderson wrote: > - If the sequence crosses a page, then so be it. Because of > step 1, this only happens when we *must* cross a page, and > will have recognized any paging exception anyway. > The generic parts of qemu will handle proper

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Alexander Graf
On 14.11.19 15:42, Peter Maydell wrote: On Tue, 12 Nov 2019 at 11:57, Peter Maydell wrote: On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: I still think that being consistent with the actual PL031 spec is preferable though. If any real world guest breaks because of this, we can still

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:45, Alexander Graf wrote: > On 14.11.19 15:42, Peter Maydell wrote: > > Is that OK? > > It's much better. Will you just fix it up inline for me please? :) Sure :-) -- PMM

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Alex Williamson
On Fri, 15 Nov 2019 00:26:07 +0530 Kirti Wankhede wrote: > On 11/14/2019 1:37 AM, Alex Williamson wrote: > > On Thu, 14 Nov 2019 01:07:21 +0530 > > Kirti Wankhede wrote: > > > >> On 11/13/2019 4:00 AM, Alex Williamson wrote: > >>> On Tue, 12 Nov 2019 22:33:37 +0530 > >>> Kirti Wankhede

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-14 Thread Alex Williamson
On Fri, 15 Nov 2019 00:26:26 +0530 Kirti Wankhede wrote: > On 11/14/2019 1:52 AM, Alex Williamson wrote: > > On Thu, 14 Nov 2019 01:22:39 +0530 > > Kirti Wankhede wrote: > > > >> On 11/13/2019 4:00 AM, Alex Williamson wrote: > >>> On Tue, 12 Nov 2019 22:33:38 +0530 > >>> Kirti Wankhede

Re: [PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board

2019-11-14 Thread Philippe Mathieu-Daudé
+Paul Burton On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for Malta board to improve its quality. Acked-by: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/8/19 4:58 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink:

[PATCH v3 4/4] tests: More iotest 223 improvements

2019-11-14 Thread Eric Blake
Run the core of the test twice, once without iothreads, and again with, for more coverage of both setups. Suggested-by: Nir Soffer Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/223 | 16 ++- tests/qemu-iotests/223.out | 85

[PATCH v3 2/4] iotests: Switch nbd tests to use Unix rather than TCP

2019-11-14 Thread Eric Blake
Up to now, all it took to cause a lot of iotest failures was to have a background process such as 'nbdkit -p 10810 null' running, because we hard-coded the TCP port. Switching to a Unix socket eliminates this contention. We still have TCP coverage in test 233, and that test is more careful to

[PATCH v3 1/4] iotests: Fix 173

2019-11-14 Thread Eric Blake
This test has been broken since 3.0. It used TEST_IMG to influence the name of a file created during _make_test_img, but commit 655ae6bb changed things so that the wrong file name is being created, which then caused _launch_qemu to fail. In the meantime, the set of events issued for the actions

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
Hi Eric, On 11/8/19 4:56 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink:

[PATCH v3 3/4] iotests: Include QMP input in .out files

2019-11-14 Thread Eric Blake
We generally include relevant HMP input in .out files, by virtue of the fact that HMP echoes its input. But QMP does not, so we have to explicitly inject it in the output stream (appropriately filtered to keep the tests passing), in order to make it easier to read .out files to see what behavior

[PATCH v3 for-4.2 0/4] tests: More iotest 223 improvements

2019-11-14 Thread Eric Blake
Since v2: - rebase to SOCK_DIR changes - new patch 2 to avoid TCP port 10810 contention [Max] - add imgfmt filtering [Max] As this is limited to iotests, I think it is fair game for -rc2. Eric Blake (4): iotests: Fix 173 iotests: Switch nbd tests to use Unix rather than TCP iotests:

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Richard Henderson writes: > For semi-hosting, it seems even better if the semi-hosting syscall instruction > is not "real", because you're explicitly requesting services from "unreal" > hardware. It should be specified to generate a SIGILL type of exception > anywhere semi-hosting is not

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-11-14 Thread Matti Hameister
I tried the ArchLinux package that includes three patches applied to qemu 4.1 ( see https://git.archlinux.org/svntogit/packages.git/commit/trunk/PKGBUILD?h=packages/qemu=e9707066408de26aa04f8d0ddebe5556aa87e662 ). My Windows 10 qcow2 image got corrupted again after a short time of use. Host

[PATCH] Modify tests to work with clang

2019-11-14 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- tests/tcg/multiarch/float_helpers.c | 13 - tests/tcg/multiarch/linux-test.c| 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/multiarch/float_helpers.c index 8ee7903..437247c

[PATCH] Implement backend program convention command for vhost-user-blk

2019-11-14 Thread Micky Yun Chan
From: michan Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 95 +++-- 1 file changed, 57 insertions(+), 38 deletions(-) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c index

[RFC PATCH v1 7/8] vfio-ccw: Refactor ccw irq handler

2019-11-14 Thread Eric Farman
Make it easier to add new ones in the future. Signed-off-by: Eric Farman --- hw/vfio/ccw.c | 55 --- 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 2b1a83b94c..b16526d5de 100644 ---

[PULL 3/4] opensbi: Upgrade from v0.4 to v0.5

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis This release has: Lot of critical fixes Hypervisor extension support SBI v0.2 base extension support Debug prints support Handle traps when doing unpriv load/store Allow compiling without FP support Use git describe to generate boot-time banner

[PULL 1/4] remove unnecessary ifdef TARGET_RISCV64

2019-11-14 Thread Palmer Dabbelt
From: "hiroyuki.obinata" Signed-off-by: Hiroyuki Obinata Signed-off-by: Palmer Dabbelt --- target/riscv/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index b26533d4fd78..ab6a891dc381 100644 ---

[PULL 2/4] target/riscv: Remove atomic accesses to MIP CSR

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis Instead of relying on atomics to access the MIP register let's update our helper function to instead just lock the IO mutex thread before writing. This follows the same concept as used in PPC for handling interrupts Signed-off-by: Alistair Francis Reviewed-by: Richard

[PULL 4/4] riscv/virt: Increase flash size

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis Coreboot developers have requested that they have at least 32MB of flash to load binaries. We currently have 32MB of flash, but it is split in two to allow loading two flash binaries. Let's increase the flash size from 32MB to 64MB to ensure we have a single region that is

RE: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, November 15, 2019 11:22 AM > > On Thu, 14 Nov 2019 21:40:35 -0500 > Yan Zhao wrote: > > > On Fri, Nov 15, 2019 at 05:06:25AM +0800, Alex Williamson wrote: > > > On Fri, 15 Nov 2019 00:26:07 +0530 > > > Kirti Wankhede wrote: > > > > > > > On 11/14/2019

Re: [PATCH] Modify tests to work with clang

2019-11-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1573792691-398-1-git-send-email-tsimp...@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Modify tests to work with clang Type: series Message-id:

  1   2   >